iarv/znc
1
0
Fork 0
mirror of https://github.com/znc/znc.git synced 2026-05-06 21:42:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix dead assign/init found by clang static analyzer

Browse Source 
Value stored to 'pUser' (during its initialization) is never read
This commit is contained in:
J-P Nurmi
2015-02-25 11:50:06 +01:00
parent eb5aa75c16
commit 36a03ce29f
2 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/controlpanel.cpp
View File

@@ -440,14 +440,12 @@ class CAdminMod : public CModule {
const CString sUsername = sLine.Token(2);
const CString sNetwork = sLine.Token(3);
CUser *pUser = NULL;
CIRCNetwork *pNetwork = NULL;
if (sUsername.empty()) {
pUser = GetUser();
pNetwork = CModule::GetNetwork();
} else {
pUser = FindUser(sUsername);
CUser* pUser = FindUser(sUsername);
if (!pUser) {
return;
}

3
src/ClientCommand.cpp
View File

@@ -429,7 +429,6 @@ void CClient::UserCommand(CString& sLine) {
return;
}
CUser* pUser = m_pUser;
CIRCNetwork* pNetwork = m_pNetwork;
const CString sNick = sLine.Token(1);
@@ -441,7 +440,7 @@ void CClient::UserCommand(CString& sLine) {
return;
}
pUser = CZNC::Get().FindUser(sNick);
CUser* pUser = CZNC::Get().FindUser(sNick);
if (!pUser) {
PutStatus("No such user [" + sNick + "]");