From 36a03ce29f824ccd23bc6ba77d9ecb397ee3d247 Mon Sep 17 00:00:00 2001 From: J-P Nurmi Date: Wed, 25 Feb 2015 11:50:06 +0100 Subject: [PATCH] Fix dead assign/init found by clang static analyzer Value stored to 'pUser' (during its initialization) is never read --- modules/controlpanel.cpp | 4 +--- src/ClientCommand.cpp | 3 +-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/modules/controlpanel.cpp b/modules/controlpanel.cpp index 287f6f8a..04ae64ca 100644 --- a/modules/controlpanel.cpp +++ b/modules/controlpanel.cpp @@ -440,14 +440,12 @@ class CAdminMod : public CModule { const CString sUsername = sLine.Token(2); const CString sNetwork = sLine.Token(3); - CUser *pUser = NULL; CIRCNetwork *pNetwork = NULL; if (sUsername.empty()) { - pUser = GetUser(); pNetwork = CModule::GetNetwork(); } else { - pUser = FindUser(sUsername); + CUser* pUser = FindUser(sUsername); if (!pUser) { return; } diff --git a/src/ClientCommand.cpp b/src/ClientCommand.cpp index 78f67115..e5e3e470 100644 --- a/src/ClientCommand.cpp +++ b/src/ClientCommand.cpp @@ -429,7 +429,6 @@ void CClient::UserCommand(CString& sLine) { return; } - CUser* pUser = m_pUser; CIRCNetwork* pNetwork = m_pNetwork; const CString sNick = sLine.Token(1); @@ -441,7 +440,7 @@ void CClient::UserCommand(CString& sLine) { return; } - pUser = CZNC::Get().FindUser(sNick); + CUser* pUser = CZNC::Get().FindUser(sNick); if (!pUser) { PutStatus("No such user [" + sNick + "]");