Commit Graph

1214 Commits

Author SHA1 Message Date
Lluís Batlle i Rossell
87cdee0438 Fixing unaligned accesses in sasl module
Visible for example in armv5tel, without kernel fixup for unaligned accesses.
2013-06-12 20:45:29 +00:00
Alexey Sokolov
a06b6495e8 Revert "Rewrite the JOIN channel logic, dropping MaxJoins"
This reverts commit db7c47f97d.

Too many joined channels at once started to cause disconnect because of
"Max SendQ Exceeded", which is not much better than previous Flood.

Now MaxJoins is 0 by default, which preserves the current behavior of
joining all channels at once. If someone experiences those disconnects
due to SendQ, they can tune MaxJoins.

Fix #329

Conflicts:
	include/znc/User.h
	modules/controlpanel.cpp
	modules/webadmin.cpp
	src/User.cpp
2013-06-09 23:39:10 +04:00
Alexey Sokolov
d0e0b565ba Use modified AM_ICONV instead of AC_CHECK_FUNC for iconv
Modifications from /usr/share/aclocal/ version:
1. Don't use AC_LIB_RPATH
2. AC_SUBST([HAVE_ICONV])

So now charset module is buildable on openbsd with:
./configure CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib

Fix #255
2013-05-29 21:15:24 +04:00
Alexey Sokolov
2bd410ee55 Fix NULL pointer dereference in webadmin.
Triggerable by any non-admin, if webadmin is loaded.

The only affected version is 1.0

Thanks to ChauffeR (Simone Esposito) for reporting this.
2013-05-27 23:52:32 +04:00
Ravomavain
3ba4598994 Add -sanitize option to log module. 2013-05-20 12:23:40 +02:00
Alexey Sokolov
40fa544e10 Make autocycle network module, fix #340
As user module, it even doesn't behave very well, because of shared
state between networks.
2013-05-19 20:43:09 +04:00
Alexey Sokolov
501a9f21c4 Revert "Make simple_away and keepnick also support user modules"
This reverts commit fb62b5e7a6.
I need to test changes better...
To be proper user modules they need to store per-network state, just a
flag isn't enough.
2013-05-19 20:39:55 +04:00
Alexey Sokolov
46b28559fc webadmin: Enable embedding network modules and to network pages. 2013-05-19 18:40:12 +04:00
Alexey Sokolov
fb62b5e7a6 Make simple_away and keepnick also support user modules
Fix #318
2013-05-19 14:45:12 +04:00
Alexey Sokolov
2b0469769f Merge commit 'refs/pull/360/head' of github.com:znc/znc 2013-05-18 17:15:42 +04:00
Alexey Sokolov
5e568a30f2 nickserv: don't confuse people so much
Password is hidden from arguments, because it's bad to show it right
here. But it looked like it refused to save the pass.
2013-05-18 14:23:49 +04:00
md-5
c9c66cb9b6 Close issue #359 - partyline rejoin on delete 2013-05-14 17:34:00 +10:00
Alexey Sokolov
588e478f9e webadmin: clarify that + is SSL 2013-05-12 13:21:32 +04:00
TheLordOfTime
4f5245f502 controlpanel.cpp: Increase verbosity of successful "Disconnect" command
This modifies line 897 to have more verbosity on the output for a successful execution of the "Disconnect" command, which will allow for the output to say what network was force-disconnected on what user.

This is a repaired version of pull request #352 which I closed after a FTBFS which I did not realize.
2013-05-11 16:22:27 -03:00
Alexey Sokolov
a3c0b74ffc Merge pull request #345 from protomouse/add-missing-tmodinfo
Add TModInfo for charset and missingmotd modules
2013-05-10 03:36:46 -07:00
Martin Häger
6fee11f765 add missing TModInfo to missingmotd module 2013-05-09 13:41:19 +02:00
Martin Häger
84fbb24dc5 add missing TModInfo to charset module 2013-05-09 13:41:18 +02:00
Uli Schlachter
c28207d35b Makefile: Remove unused (and broken) variable
Signed-off-by: Uli Schlachter <psychon@znc.in>
2013-05-07 21:33:46 +02:00
Uli Schlachter
ed478e6f7b make clean: Only delete files that can be regenerated
Previously, "make clean" would happily delete swig's output files even though
configure did not find swig and thus these files could not be generated again.

This half-fixes issue 276. It would be great if the Makefiles never delete files
which are part of the tarball, but at least they now don't delete files which
cannot be regenerated.

Signed-off-by: Uli Schlachter <psychon@znc.in>
2013-05-07 21:29:11 +02:00
Mantas Mikulėnas
72c9513f6e route_replies: Add some WHOIS numerics
Charybdis can return all these.
2013-04-28 03:16:57 +03:00
Kyle Fuller
78be38d802 Allow block_motd to be loaded per-network and globally
Closes #326
2013-04-21 12:31:30 +01:00
Uli Schlachter
1dbdc4f37d sasl: Add missing length check
This could otherwise lead to an integer underflow on specially crafted input.

Signed-off-by: Uli Schlachter <psychon@znc.in>
2013-04-20 21:31:35 +02:00
Elizabeth Myers
f161ac6182 Fix memory leak. Oops :(.
Found by KindOne on IRC. Thanks!
2013-04-16 17:19:52 -05:00
Elizabeth Myers
f578bf9424 Implement DH-AES encrypted password scheme.
This is superior to DH-BLOWFISH as Blowfish may suffer from certain
classes of weak keys, which is difficult to mitigate against without
regenerating DH parameters repeatedly. AES also has faced far more
scrutiny and is believed to be more secure.

Reference implementation (services-side):
https://github.com/atheme/atheme/blob/master/modules/saslserv/dh-aes.c
2013-04-16 05:39:10 -05:00
Alexey Sokolov
f2e8738ffc Fix #313 2013-04-05 08:38:21 +07:00
Alexey Sokolov
636ca24088 A bit more beatiful way to build modules 2013-04-05 08:38:00 +07:00
Alexey Sokolov
8fdb530ee3 Fix use-after-free which may happen during shutdown
If a module, e.g. keepnick, tries to remove a timer in
OnIRCDisconnected.

Thanks to KindOne for the report.
2013-03-31 23:40:19 +07:00
Alexey Sokolov
ae7bcaf87d Use " " instead of ":" in awaystore's buffer internal format. Fix #267 2013-03-17 01:11:59 +07:00
Alexey Sokolov
9f4f2817d1 Fix #293
In GetAvailableMods() modules paths were returned like "moddir//module.pm",
but when they are loaded, they use path "moddir/module.pm".

Because of that our hack of cleaning %INC when the module is unloaded,
which enables UpdateMod, removed wrong record from %INC, left right
record in it, and erased the module's namespace.

When the module was loaded again, the namespace was not restored,
because "require" didn't load the module, because it was still in %INC.

So, when we call a function of that module, the function does not exist
anymore.
2013-03-16 23:35:19 +07:00
KindOne
2db7307ac3 Remove unneeded headers. 2013-03-08 01:47:57 +07:00
Alexey Sokolov
ea5406f334 Fix issue introduced in previous commit. 2013-02-28 09:58:50 +07:00
Alexey Sokolov
58a8781b02 Merge commit 'refs/pull/304/head' of github.com:znc/znc 2013-02-28 09:33:32 +07:00
baines
82a708d6a1 Cleaned up more warnings. 2013-02-27 20:53:14 -05:00
Alexey Sokolov
5021d09519 Merge commit 'refs/pull/303/head' of github.com:znc/znc 2013-02-27 22:19:15 +07:00
md_5
9f4d2ffa1f Fix PartyLine so that forced channels may not be left at all - users will be rejoined at once. 2013-02-23 18:31:10 +11:00
Thomas Ward
7496704f3e controlpanel.cpp: Fixed a Fail to Compile error introduced in prior commit. 2013-02-01 15:51:36 -05:00
TheLordOfTime
e559bc6677 controlpanel.cpp: Standardize error wordings
When a network cannot be found for a user, and where a command will output an error under such circumstances, use similar wording in each message.
2013-01-30 22:58:32 -05:00
The Lord of Time
e6414e3c98 controlpanel.cpp: Increases general verbosity of command results. 2013-01-30 18:05:55 +00:00
TheLordOfTime
fd813c01af controlpanel.cpp: Fix bug for "Disconnect" help
This fixes a bug in which providing empty data for the 'disconnect' command for controlpanel will return the 'reconnect' command's syntax help, which can confuse users.
2013-01-29 04:46:55 -05:00
Alexey Sokolov
f661f2a002 Use CModule::ExpandString 2013-01-20 10:39:50 +07:00
Alexey Sokolov
42cb0d7de7 It's 2013 now (few modules were forgotten :P) 2013-01-19 09:19:41 +07:00
TheLordOfTime
29d2ff001a modules/sasl.cpp: Description line for DH-BLOWFISH
Added a description to the output for DH-BLOWFISH SASL mechanism.
2013-01-11 21:39:51 -05:00
Un1matr1x
3a34593359 The same procedure as last year, Miss sophie?
Same procedure as every year, James.
2012-12-31 12:44:31 +01:00
Uli Schlachter
d9d6a2228c Fix OOT builds with swig files in source dir
Normally, when the Makefile calls swig, the resulting files end up in the build
directory. However, when the files are pre-generated (e.g. as in the znc 1.0
tarball) and an out of tree build is used, they are in the source directory and
installation fails.

Thanks to Kinji for reporting this.

Signed-off-by: Uli Schlachter <psychon@znc.in>
2012-12-26 14:12:58 +01:00
Alexey Sokolov
3e2152c77e Make default type of cert mod to be network. 2012-12-20 20:29:28 +07:00
Alexey Sokolov
2b51222245 Show example timezone in webadmin 2012-12-04 09:24:47 +07:00
Alexey Sokolov
c06f95b452 Webadmin: Show instructions on how to use networks in Add Network too
not only in Edit Network
2012-12-02 19:28:02 +07:00
Alexey Sokolov
cf8925c930 Webadmin: don't modify listeners if loaded as user mod
Thanks to TheLordOfTime
2012-12-01 14:28:07 +07:00
Alexey Sokolov
833e63fb64 Allow loading webadmin as user module. 2012-12-01 08:55:41 +07:00
Michael Senn
f70f1086fd Fixed minor typo in webadmin module. 2012-11-28 13:37:31 +01:00