iarv/znc
1
0
Fork 0
mirror of https://github.com/znc/znc.git synced 2026-03-28 17:42:41 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix use-after-free which may happen during shutdown

Browse Source 
If a module, e.g. keepnick, tries to remove a timer in
OnIRCDisconnected.

Thanks to KindOne for the report.
This commit is contained in:
Alexey Sokolov
2013-03-31 23:38:04 +07:00
parent 20c5c7d8be
commit 8fdb530ee3
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/keepnick.cpp
View File

@@ -121,7 +121,7 @@ public:
return;
m_pTimer->Stop();
RemTimer(m_pTimer->GetName());
RemTimer(m_pTimer);
m_pTimer = NULL;
}

5
src/znc.cpp
View File

@@ -51,6 +51,11 @@ CZNC::~CZNC() {
for (map<CString,CUser*>::iterator a = m_msUsers.begin(); a != m_msUsers.end(); ++a) {
a->second->GetModules().UnloadAll();
const vector<CIRCNetwork*>& networks = a->second->GetNetworks();
for (vector<CIRCNetwork*>::const_iterator b = networks.begin(); b != networks.end(); ++b) {
(*b)->GetModules().UnloadAll();
}
}
for (size_t b = 0; b < m_vpListeners.size(); b++) {