Commit Graph

1857 Commits

Author SHA1 Message Date
cflakes 611e4e6d4e Do not create empty directories if one does ./znc --datadir=NON_EXISTING_DIR
git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1878 726aef4b-f618-498e-8847-2d620e286838
2010-04-04 15:58:04 +00:00
cflakes e67b07f07a Do not expose ZNC's version number through the web interface
unless there's an active user session.


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1877 726aef4b-f618-498e-8847-2d620e286838
2010-04-04 15:20:22 +00:00
cflakes 3366c02777 Miscellaneous fixes and improvements to the look of dark-clouds and forest.
git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1876 726aef4b-f618-498e-8847-2d620e286838
2010-04-04 14:24:25 +00:00
cflakes d338b3d08c Re-add lost options, fix some space, adjust some captions.
git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1875 726aef4b-f618-498e-8847-2d620e286838
2010-04-04 14:11:22 +00:00
cflakes 1b79a28b37 Fix forest skin.
git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1874 726aef4b-f618-498e-8847-2d620e286838
2010-04-04 13:46:29 +00:00
cflakes 7aadc8e250 "dark-clouds" now looks okish again, still needs some finishing touches applied, but generally fine.
The MOTD textarea will use a monospace font now.


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1873 726aef4b-f618-498e-8847-2d620e286838
2010-04-04 13:44:47 +00:00
cflakes 32a42f1375 Re-add missing IPv4 column for listeners on webadmin's settings page.
git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1872 726aef4b-f618-498e-8847-2d620e286838
2010-04-04 12:58:14 +00:00
cflakes dad7d73a3c More skin updates on the way from webadmin to webmods. Not yet done.
git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1871 726aef4b-f618-498e-8847-2d620e286838
2010-04-04 12:42:00 +00:00
cflakes f8811a1897 WebAdmin: Show global settings previous to user settings.
git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1870 726aef4b-f618-498e-8847-2d620e286838
2010-04-04 11:56:10 +00:00
silverleo 7a21198dbb Renamed the default css file to properly work after the changes done in r1868
git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1869 726aef4b-f618-498e-8847-2d620e286838
2010-04-04 11:02:37 +00:00
cflakes e4f8935c17 Deleted obsolete modules/webadmin dir, copied CSS files for ice & default to
webskins dir, made default the _default_ skin, moved dark-clouds to dark-clouds,
added /skinfiles/ feature to base skins on each other (and not only on default).

Next up: re-adding help texts that got lost during webadmin->webmods transition,
making skins look nice again.


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1868 726aef4b-f618-498e-8847-2d620e286838
2010-04-04 10:27:33 +00:00
psychon 7285bb9cc7 Entirely my fault, sorry :(
git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1867 726aef4b-f618-498e-8847-2d620e286838
2010-04-01 08:41:57 +00:00
psychon b66b3f8950 Add functions for modifing the ports on which znc listens
Patch is based on a patch from BrianC, thanks a lot.


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1866 726aef4b-f618-498e-8847-2d620e286838
2010-04-01 08:39:10 +00:00
psychon dd905ba3eb CRealListener: Inform CListener about being destroyed
git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1865 726aef4b-f618-498e-8847-2d620e286838
2010-04-01 08:28:45 +00:00
cflakes 9d82e9b920 Add missing DenyLoadMod check in admin.cpp, following
up revision 1845. Patch by Nirjen, thanks again!


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1864 726aef4b-f618-498e-8847-2d620e286838
2010-03-31 21:41:30 +00:00
psychon 8b865f7c82 Include Socket.h in HTTPSock.h
CHTTPSock is derived from CSocket, so it obviously needs its definition.


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1863 726aef4b-f618-498e-8847-2d620e286838
2010-03-31 18:48:48 +00:00
psychon 4eb7d604a2 GetSession(): Properly cache the result
This function caches its result for not-logged-in users since r1857. With this
commit, it also now works properly for logged-in ones.


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1862 726aef4b-f618-498e-8847-2d620e286838
2010-03-30 19:52:17 +00:00
psychon 2039f4e831 Bugfix for CWebSock::GetRequestCookie()
When a module page is requested, m_sModName is set. When then GetSession() tries
to look up its session cookie, it doesn't find it since GetRequestCookie()
actually looks up Mod::<modname>::<cookie name>.

The fix is to look up the global cookie name if the mod one doesnt exist.


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1861 726aef4b-f618-498e-8847-2d620e286838
2010-03-30 19:49:51 +00:00
psychon 43db68026c Don't forward our own QUITs to clients
Colloquy disconnects if it receives a QUIT from the server. Also, the old
behavior wasn't really consistent, a quit was only forwarded if the user was in
any non-detached channels.


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1860 726aef4b-f618-498e-8847-2d620e286838
2010-03-30 15:09:32 +00:00
psychon 9bf75ce0e7 Remove CWebSock::m_bLoggedIn
We can just check if m_pUser is NULL for the very same thing.


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1859 726aef4b-f618-498e-8847-2d620e286838
2010-03-30 12:20:31 +00:00
psychon fd750daa5f Use GetSession() instead of m_spSession
m_spSession could be a NULL pointer while GetSession() new returns a NULL
pointer.


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1858 726aef4b-f618-498e-8847-2d620e286838
2010-03-30 12:11:27 +00:00
psychon ede188aaa5 Make sure CWebSock::GetSession() only generates one session
When one sent a basic-auth header, OnLogin() was called with the request's data
which caused a GetSession() call which generated a new session. Sadly, this
session wasn't saved anywhere, so a new one session was generated later when
OnPageRequest() triggered. This could lead to a NULL pointer dereference.


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1857 726aef4b-f618-498e-8847-2d620e286838
2010-03-30 12:06:27 +00:00
cflakes 7d39481460 "Fix" trailing whitespace in /settings' textareas.
git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1856 726aef4b-f618-498e-8847-2d620e286838
2010-03-30 10:17:56 +00:00
psychon c4703fb709 And again a little less spamminess
Meh, so much work to do on these --debug spam. :(


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1855 726aef4b-f618-498e-8847-2d620e286838
2010-03-30 10:10:26 +00:00
cflakes a8c95c5882 Fix (hide) "Add Channel" link while creating new users. Regression
from porting webadmin to webmods.


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1854 726aef4b-f618-498e-8847-2d620e286838
2010-03-30 09:59:37 +00:00
cflakes 9c9234f9f2 Minor webmods skin fixes.
git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1853 726aef4b-f618-498e-8847-2d620e286838
2010-03-30 09:48:23 +00:00
cflakes 8f4d3f8467 Remember "automatically connect + reconnect" flag across restarts by writing it to the config file.
git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1852 726aef4b-f618-498e-8847-2d620e286838
2010-03-30 09:24:24 +00:00
cflakes 073ef0873a Added "Connect to IRC & automatically re-connect" checkbox to webadmin.
Sets the internal "automatically connect" flag just like /msg *status connect and
/msg *status disconnect do. Idea by Advis0r, thanks!


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1851 726aef4b-f618-498e-8847-2d620e286838
2010-03-30 09:16:09 +00:00
psychon 4a7b82b1e3 Oh look, invisible, pink unicorns!
No really, over there! You really should take a look. Come on, I'm not messing
with you. There really are those IPU (invisible pink unicorns) right behind you.
DarthGandalf found them. Oh, now they flew away. :(


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1850 726aef4b-f618-498e-8847-2d620e286838
2010-03-29 19:29:20 +00:00
psychon 82ad224465 Make OnConfigLine() a user module hook
It's only called for stuff defined in that user's section. The stuff outside of
a user section still can only be caught by global modules.


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1849 726aef4b-f618-498e-8847-2d620e286838
2010-03-29 19:23:48 +00:00
psychon 027404e05b Move OnWrite{User,Chan}Config() to CModule
That way, user modules can write stuff to the user section, too.

OnWriteConfig() is still a global module call. A later commit will have to make
OnConfigLine() a user module hook...


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1848 726aef4b-f618-498e-8847-2d620e286838
2010-03-29 19:04:37 +00:00
cflakes be130f2034 Fix admin.cpp. Search and replace isn't what it used to be.
git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1847 726aef4b-f618-498e-8847-2d620e286838
2010-03-28 21:06:40 +00:00
cflakes a3a7bb71f9 Fix whitespace and general cleanup for admin.cpp. Let's hope this doesn't break anything. :P
git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1846 726aef4b-f618-498e-8847-2d620e286838
2010-03-28 21:04:25 +00:00
cflakes 03c5f5cbfe Add LoadModule, UnLoadModule, ListMods commands to the admin module.
This means that admins can now load user modules for other users.

Patch by Nirjen. Thanks, great job!


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1845 726aef4b-f618-498e-8847-2d620e286838
2010-03-28 20:37:48 +00:00
cflakes dfca1e535d Add some doxygen comments for WebMods module stuff.
git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1844 726aef4b-f618-498e-8847-2d620e286838
2010-03-25 16:57:37 +00:00
cflakes f358130220 Add a robots.txt file. Since WebMods now deliver (albeit basic) pages to visitors
that have not logged into any ZNC account, we certainly want to protect peoples'
ZNC's from Google's crawlers.


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1843 726aef4b-f618-498e-8847-2d620e286838
2010-03-23 23:26:38 +00:00
cflakes 8b52393eb7 WebSock: Add PAGE_DONE to EPageReqResult. It's used to better differentiate between
async processing (PAGE_DEFERRED) and redirects and other synchronous stuff (-> PAGE_DONE).


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1842 726aef4b-f618-498e-8847-2d620e286838
2010-03-23 18:03:12 +00:00
cflakes 44d2114f37 Add OnWebPreRequest web module hook to allow modules to do PAGE_DEFERRED style async processing.
git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1841 726aef4b-f618-498e-8847-2d620e286838
2010-03-23 17:59:42 +00:00
cflakes 968a0bd3ff WebMods/HTTPSock: Do not send Set-Cookie headers if the cookie has not changed.
To achieve that, split internal cookie jar into a jar for received cookies
and one for cookies that are to be sent with the response.


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1840 726aef4b-f618-498e-8847-2d620e286838
2010-03-23 16:48:25 +00:00
cflakes 72dccb5560 WebMods: Add an error message for users that have cookie support turned off.
git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1839 726aef4b-f618-498e-8847-2d620e286838
2010-03-23 16:12:38 +00:00
psychon 6228055bb9 Fix a couple of places where WebMods tried to send multiple pages
git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1838 726aef4b-f618-498e-8847-2d620e286838
2010-03-16 10:04:31 +00:00
psychon fc2f732c4b CHTTPSock: Print warnings if one tries to send multiple pages
git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1837 726aef4b-f618-498e-8847-2d620e286838
2010-03-16 09:55:10 +00:00
psychon 1fae97ab92 Remove the spamminess of --debug a little
git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1836 726aef4b-f618-498e-8847-2d620e286838
2010-03-16 09:53:58 +00:00
psychon f4b07373ae Really fix auth modules
It turns out that there was still another Close() hiding in CHTTPSock which made
stuff fail. However, just removing it fixes stuff.

Thanks to DarthGandalf for noticing that my fix wasn't fixing the bug that was
bugging him.


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1835 726aef4b-f618-498e-8847-2d620e286838
2010-03-16 09:23:32 +00:00
psychon f87b69b3dc Fix WebModules with auth modules
When e.g. imapauth started handling a login from WebMods it opened a new TCP
connection etc. This took time, but WebMods didn't actually wait for the login
to finish which caused the login to fail later on since the HTTP socket was
already destroyed.

This fixes it by letting the HTTP sock just hang. Once the login finishes,
CHTTPSock::Redirect() is called to let it come back to life again.

Thanks to DarthGandalf for finding this issue.


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1834 726aef4b-f618-498e-8847-2d620e286838
2010-03-15 16:06:56 +00:00
psychon 8447db4da6 Change the return type of OnPageRequestInternal()
Instead of return a bool, this now returns an enum. This explains the meaning of
the returned value better and will be used in the next commit to fix a bug.


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1833 726aef4b-f618-498e-8847-2d620e286838
2010-03-15 15:58:15 +00:00
psychon e91690c283 Revert r1831
No, I'm not going to explain why. :P


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1832 726aef4b-f618-498e-8847-2d620e286838
2010-03-15 15:43:22 +00:00
psychon 4b75861993 Remove a self-assignment due to copy&paste
git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1831 726aef4b-f618-498e-8847-2d620e286838
2010-03-15 15:36:04 +00:00
psychon 92121d20a8 Make it possible to process HTTP requests async
This changes CHTTPSock so that one can handle HTTP requests asynchronously.
This is done by not forcing a page to be sent out in the caller of
OnPageRequest() but instead requiring a call to the new function
CHTTPSock::PrintPage().


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1830 726aef4b-f618-498e-8847-2d620e286838
2010-03-15 15:27:02 +00:00
psychon 4a1dfa020d Fix some minor "Whooops"
Someone semi-messed-up Makefile.in and the very same guy forgot to regenerate
configure when he modified configure.in. Whooops.


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1829 726aef4b-f618-498e-8847-2d620e286838
2010-03-14 12:19:54 +00:00