Compare commits

..

14 Commits

Author SHA1 Message Date
l5y c64a46a481 web: address review comments 2026-02-14 23:09:41 +01:00
l5y 11e5de2851 web: address review comments 2026-02-14 22:09:04 +01:00
l5y 8b3aa2533c web: address review comments 2026-02-14 22:02:02 +01:00
l5y e004cfacd7 web: address review comments 2026-02-14 21:38:56 +01:00
l5y 05d267d0c0 web: add cursor pagination to apis 2026-02-14 21:16:38 +01:00
l5y 5b0a6f5f8b web: expose node stats in distinct api (#641)
* web: expose node stats in distinct api

* web: address review comments

* web: address review comments

* web: address review comments

* web: address review comments
2026-02-14 21:14:10 +01:00
l5y 2e8b5ad856 web: do not merge channels by name (#640) 2026-02-14 15:42:14 +01:00
l5y e32b098be4 web: do not merge channels by ID in frontend (#637)
* web: do not merge channels by ID in frontend

* web: address review comments

* web: address review comments
2026-02-14 14:56:25 +01:00
l5y b45629f13c web: do not touch neighbor last seen on neighbor info (#636)
* web: do not touch neighbor last seen on neighbor info

* web: address review comments
2026-02-14 14:43:46 +01:00
l5y 96421c346d ingestor: report self id per packet (#635)
* ingestor: report self id per packet

* ingestor: address review comments

* ingestor: address review comments

* ingestor: address review comments

* ingestor: address review comments
2026-02-14 14:29:05 +01:00
l5y 724b3e14e5 ci: fix docker compose and docs (#634)
* ci: fix docker compose and docs

* docker: address review comments
2026-02-14 13:25:43 +01:00
l5y e8c83a2774 web: supress encrypted text messages in frontend (#633)
* web: supress encrypted text messages in frontend

* web: address review comments

* web: address review comments

* web: address review comments

* web: address review comments
2026-02-14 13:11:02 +01:00
l5y 5c5a9df5a6 federation: ensure requests timeout properly and can be terminated (#631)
* federation: ensure requests timeout properly and can be terminated

* web: address review comments

* web: address review comments

* web: address review comments

* web: address review comments
2026-02-14 12:29:01 +01:00
dependabot[bot] 7cb4bbe61b build(deps): bump bytes from 1.11.0 to 1.11.1 in /matrix (#627)
Bumps [bytes](https://github.com/tokio-rs/bytes) from 1.11.0 to 1.11.1.
- [Release notes](https://github.com/tokio-rs/bytes/releases)
- [Changelog](https://github.com/tokio-rs/bytes/blob/master/CHANGELOG.md)
- [Commits](https://github.com/tokio-rs/bytes/compare/v1.11.0...v1.11.1)

---
updated-dependencies:
- dependency-name: bytes
  dependency-version: 1.11.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-02-06 21:40:49 +01:00
36 changed files with 4136 additions and 560 deletions
+26 -5
View File
@@ -252,15 +252,36 @@ services.potato-mesh = {
## Docker
Docker images are published on Github for each release:
Docker images are published on GitHub Container Registry for each release.
Image names and tags follow the workflow format:
`${IMAGE_PREFIX}-${service}-${architecture}:${tag}` (see `.github/workflows/docker.yml`).
```bash
docker pull ghcr.io/l5yth/potato-mesh/web:latest # newest release
docker pull ghcr.io/l5yth/potato-mesh/web:v0.5.5 # pinned historical release
docker pull ghcr.io/l5yth/potato-mesh/ingestor:latest
docker pull ghcr.io/l5yth/potato-mesh/matrix-bridge:latest
docker pull ghcr.io/l5yth/potato-mesh-web-linux-amd64:latest
docker pull ghcr.io/l5yth/potato-mesh-web-linux-arm64:latest
docker pull ghcr.io/l5yth/potato-mesh-web-linux-armv7:latest
docker pull ghcr.io/l5yth/potato-mesh-ingestor-linux-amd64:latest
docker pull ghcr.io/l5yth/potato-mesh-ingestor-linux-arm64:latest
docker pull ghcr.io/l5yth/potato-mesh-ingestor-linux-armv7:latest
docker pull ghcr.io/l5yth/potato-mesh-matrix-bridge-linux-amd64:latest
docker pull ghcr.io/l5yth/potato-mesh-matrix-bridge-linux-arm64:latest
docker pull ghcr.io/l5yth/potato-mesh-matrix-bridge-linux-armv7:latest
# version-pinned examples
docker pull ghcr.io/l5yth/potato-mesh-web-linux-amd64:v0.5.5
docker pull ghcr.io/l5yth/potato-mesh-ingestor-linux-amd64:v0.5.5
docker pull ghcr.io/l5yth/potato-mesh-matrix-bridge-linux-amd64:v0.5.5
```
Note: `latest` is only published for non-prerelease versions. Pre-release tags
such as `-rc`, `-beta`, `-alpha`, or `-dev` are version-tagged only.
When using Compose, set `POTATOMESH_IMAGE_ARCH` in `docker-compose.yml` (or via
environment) so service images resolve to the correct architecture variant and
you avoid manual tag mistakes.
Feel free to run the [configure.sh](./configure.sh) script to set up your
environment. See the [Docker guide](DOCKER.md) for more details and custom
deployment instructions.
-1
View File
@@ -29,7 +29,6 @@ if SCRIPT_DIR in sys.path:
from google.protobuf.json_format import MessageToDict
from meshtastic.protobuf import mesh_pb2, telemetry_pb2
PORTNUM_MAP: Dict[int, Tuple[str, Any]] = {
3: ("POSITION_APP", mesh_pb2.Position),
4: ("NODEINFO_APP", mesh_pb2.NodeInfo),
+5
View File
@@ -424,6 +424,7 @@ def store_position_packet(packet: Mapping, decoded: Mapping) -> None:
"hop_limit": hop_limit,
"bitfield": bitfield,
"payload_b64": payload_b64,
"ingestor": host_node_id(),
}
if raw_payload:
position_payload["raw"] = raw_payload
@@ -568,6 +569,7 @@ def store_traceroute_packet(packet: Mapping, decoded: Mapping) -> None:
"rssi": rssi,
"snr": snr,
"elapsed_ms": elapsed_ms,
"ingestor": host_node_id(),
}
_queue_post_json(
@@ -935,6 +937,7 @@ def store_telemetry_packet(packet: Mapping, decoded: Mapping) -> None:
"rssi": rssi,
"hop_limit": hop_limit,
"payload_b64": payload_b64,
"ingestor": host_node_id(),
}
if battery_level is not None:
@@ -1263,6 +1266,7 @@ def store_neighborinfo_packet(packet: Mapping, decoded: Mapping) -> None:
"neighbors": neighbor_entries,
"rx_time": rx_time,
"rx_iso": _iso(rx_time),
"ingestor": host_node_id(),
}
if node_broadcast_interval is not None:
@@ -1520,6 +1524,7 @@ def store_packet_dict(packet: Mapping) -> None:
"hop_limit": int(hop) if hop is not None else None,
"reply_id": reply_id,
"emoji": emoji,
"ingestor": host_node_id(),
}
if not encrypted_flag and channel_name_value:
+1 -2
View File
@@ -30,8 +30,7 @@ CREATE TABLE IF NOT EXISTS messages (
channel_name TEXT,
reply_id INTEGER,
emoji TEXT,
decrypted INTEGER NOT NULL DEFAULT 0,
decryption_confidence REAL
ingestor TEXT
);
CREATE INDEX IF NOT EXISTS idx_messages_rx_time ON messages(rx_time);
+1
View File
@@ -17,6 +17,7 @@ CREATE TABLE IF NOT EXISTS neighbors (
neighbor_id TEXT NOT NULL,
snr REAL,
rx_time INTEGER NOT NULL,
ingestor TEXT,
PRIMARY KEY (node_id, neighbor_id),
FOREIGN KEY (node_id) REFERENCES nodes(node_id) ON DELETE CASCADE,
FOREIGN KEY (neighbor_id) REFERENCES nodes(node_id) ON DELETE CASCADE
+2 -1
View File
@@ -33,7 +33,8 @@ CREATE TABLE IF NOT EXISTS positions (
rssi INTEGER,
hop_limit INTEGER,
bitfield INTEGER,
payload_b64 TEXT
payload_b64 TEXT,
ingestor TEXT
);
CREATE INDEX IF NOT EXISTS idx_positions_rx_time ON positions(rx_time);
+2 -1
View File
@@ -53,7 +53,8 @@ CREATE TABLE IF NOT EXISTS telemetry (
rainfall_1h REAL,
rainfall_24h REAL,
soil_moisture INTEGER,
soil_temperature REAL
soil_temperature REAL,
ingestor TEXT
);
CREATE INDEX IF NOT EXISTS idx_telemetry_rx_time ON telemetry(rx_time);
+2 -1
View File
@@ -21,7 +21,8 @@ CREATE TABLE IF NOT EXISTS traces (
rx_iso TEXT NOT NULL,
rssi INTEGER,
snr REAL,
elapsed_ms INTEGER
elapsed_ms INTEGER,
ingestor TEXT
);
CREATE TABLE IF NOT EXISTS trace_hops (
+8 -1
View File
@@ -81,7 +81,12 @@ x-matrix-bridge-base: &matrix-bridge-base
image: ghcr.io/l5yth/potato-mesh-matrix-bridge-${POTATOMESH_IMAGE_ARCH:-linux-amd64}:${POTATOMESH_IMAGE_TAG:-latest}
volumes:
- potatomesh_matrix_bridge_state:/app
- ./matrix/Config.toml:/app/Config.toml:ro
- type: bind
source: ./matrix/Config.toml
target: /app/Config.toml
read_only: true
bind:
create_host_path: false
restart: unless-stopped
deploy:
resources:
@@ -128,6 +133,8 @@ services:
matrix-bridge:
<<: *matrix-bridge-base
network_mode: host
profiles:
- matrix
depends_on:
- web
extra_hosts:
+2 -2
View File
@@ -169,9 +169,9 @@ checksum = "5dd9dc738b7a8311c7ade152424974d8115f2cdad61e8dab8dac9f2362298510"
[[package]]
name = "bytes"
version = "1.11.0"
version = "1.11.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "b35204fbdc0b3f4446b89fc1ac2cf84a8a68971995d0bf2e925ec7cd960f9cb3"
checksum = "1e748733b7cbc798e1434b6ac524f0c1ff2ab456fe201501e6497c8417a4fc33"
[[package]]
name = "cc"
+32
View File
@@ -146,6 +146,38 @@ Container detection checks `POTATOMESH_CONTAINER`, `CONTAINER`, and `/proc/1/cgr
Set `POTATOMESH_CONTAINER=0` or `--no-container` to opt out of container defaults.
### Docker Compose First Run
Before starting Compose, complete this preflight checklist:
1. Ensure `matrix/Config.toml` exists as a regular file on the host (not a directory).
2. Fill required Matrix values in `matrix/Config.toml`:
- `matrix.as_token`
- `matrix.hs_token`
- `matrix.server_name`
- `matrix.room_id`
- `matrix.homeserver`
This is required because the shared Compose anchor `x-matrix-bridge-base` mounts `./matrix/Config.toml` to `/app/Config.toml`.
Then follow the token and namespace requirements in [Matrix Appservice Setup (Synapse example)](#matrix-appservice-setup-synapse-example).
#### Troubleshooting
| Symptom | Likely cause | What to check |
| --- | --- | --- |
| `Is a directory (os error 21)` | Host mount source became a directory | `matrix/Config.toml` was missing at mount time and got created as a directory on host. |
| `M_UNKNOWN_TOKEN` / `401 Unauthorized` | Matrix appservice token mismatch | Verify `matrix.as_token` matches your appservice registration and setup in [Matrix Appservice Setup (Synapse example)](#matrix-appservice-setup-synapse-example). |
#### Recovery from accidental `Config.toml` directory creation
```bash
# from repo root
rm -rf matrix/Config.toml
touch matrix/Config.toml
# then edit matrix/Config.toml and set valid matrix.as_token, matrix.hs_token,
# matrix.server_name, matrix.room_id, and matrix.homeserver before starting compose
```
### PotatoMesh API
The bridge assumes:
+10
View File
@@ -788,6 +788,7 @@ def test_store_packet_dict_posts_text_message(mesh_module, monkeypatch):
mesh.config.LORA_FREQ = 868
mesh.config.MODEM_PRESET = "MediumFast"
mesh.register_host_node_id("!f00dbabe")
packet = {
"id": 123,
@@ -823,6 +824,7 @@ def test_store_packet_dict_posts_text_message(mesh_module, monkeypatch):
assert payload["rssi"] == -70
assert payload["reply_id"] is None
assert payload["emoji"] is None
assert payload["ingestor"] == "!f00dbabe"
assert payload["lora_freq"] == 868
assert payload["modem_preset"] == "MediumFast"
assert priority == mesh._MESSAGE_POST_PRIORITY
@@ -879,6 +881,7 @@ def test_store_packet_dict_posts_position(mesh_module, monkeypatch):
mesh.config.LORA_FREQ = 868
mesh.config.MODEM_PRESET = "MediumFast"
mesh.register_host_node_id("!f00dbabe")
packet = {
"id": 200498337,
@@ -946,6 +949,7 @@ def test_store_packet_dict_posts_position(mesh_module, monkeypatch):
)
assert payload["lora_freq"] == 868
assert payload["modem_preset"] == "MediumFast"
assert payload["ingestor"] == "!f00dbabe"
assert payload["raw"]["time"] == 1_758_624_189
@@ -960,6 +964,7 @@ def test_store_packet_dict_posts_neighborinfo(mesh_module, monkeypatch):
mesh.config.LORA_FREQ = 868
mesh.config.MODEM_PRESET = "MediumFast"
mesh.register_host_node_id("!f00dbabe")
packet = {
"id": 2049886869,
@@ -1004,6 +1009,7 @@ def test_store_packet_dict_posts_neighborinfo(mesh_module, monkeypatch):
assert neighbors[2]["neighbor_num"] == 0x0BAD_C0DE
assert payload["lora_freq"] == 868
assert payload["modem_preset"] == "MediumFast"
assert payload["ingestor"] == "!f00dbabe"
def test_store_packet_dict_handles_nodeinfo_packet(mesh_module, monkeypatch):
@@ -2282,6 +2288,7 @@ def test_store_packet_dict_handles_telemetry_packet(mesh_module, monkeypatch):
mesh.config.LORA_FREQ = 868
mesh.config.MODEM_PRESET = "MediumFast"
mesh.register_host_node_id("!f00dbabe")
packet = {
"id": 1_256_091_342,
@@ -2334,6 +2341,7 @@ def test_store_packet_dict_handles_telemetry_packet(mesh_module, monkeypatch):
assert payload["current"] == pytest.approx(0.0715)
assert payload["lora_freq"] == 868
assert payload["modem_preset"] == "MediumFast"
assert payload["ingestor"] == "!f00dbabe"
def test_store_packet_dict_handles_environment_telemetry(mesh_module, monkeypatch):
@@ -2477,6 +2485,7 @@ def test_store_packet_dict_handles_traceroute_packet(mesh_module, monkeypatch):
mesh.config.LORA_FREQ = 915
mesh.config.MODEM_PRESET = "LongFast"
mesh.register_host_node_id("!f00dbabe")
packet = {
"id": 2_934_054_466,
@@ -2518,6 +2527,7 @@ def test_store_packet_dict_handles_traceroute_packet(mesh_module, monkeypatch):
assert "elapsed_ms" in payload
assert payload["lora_freq"] == 915
assert payload["modem_preset"] == "LongFast"
assert payload["ingestor"] == "!f00dbabe"
def test_traceroute_hop_normalization_supports_mappings(mesh_module, monkeypatch):
+3
View File
@@ -139,7 +139,10 @@ module PotatoMesh
set :public_folder, File.expand_path("../../public", __dir__)
set :views, File.expand_path("../../views", __dir__)
set :federation_thread, nil
set :initial_federation_thread, nil
set :federation_worker_pool, nil
set :federation_shutdown_requested, false
set :federation_shutdown_hook_installed, false
set :port, resolve_port
set :bind, DEFAULT_BIND_ADDRESS
@@ -616,6 +616,7 @@ module PotatoMesh
payload_b64 = string_or_nil(payload["payload_b64"] || payload["payload"])
payload_b64 ||= string_or_nil(position_section.dig("payload", "__bytes_b64__"))
ingestor = string_or_nil(payload["ingestor"])
row = [
pos_id,
@@ -639,13 +640,14 @@ module PotatoMesh
hop_limit,
bitfield,
payload_b64,
ingestor,
]
with_busy_retry do
db.execute <<~SQL, row
INSERT INTO positions(id,node_id,node_num,rx_time,rx_iso,position_time,to_id,latitude,longitude,altitude,location_source,
precision_bits,sats_in_view,pdop,ground_speed,ground_track,snr,rssi,hop_limit,bitfield,payload_b64)
VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)
precision_bits,sats_in_view,pdop,ground_speed,ground_track,snr,rssi,hop_limit,bitfield,payload_b64,ingestor)
VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)
ON CONFLICT(id) DO UPDATE SET
node_id=COALESCE(excluded.node_id,positions.node_id),
node_num=COALESCE(excluded.node_num,positions.node_num),
@@ -666,7 +668,8 @@ module PotatoMesh
rssi=COALESCE(excluded.rssi,positions.rssi),
hop_limit=COALESCE(excluded.hop_limit,positions.hop_limit),
bitfield=COALESCE(excluded.bitfield,positions.bitfield),
payload_b64=COALESCE(excluded.payload_b64,positions.payload_b64)
payload_b64=COALESCE(excluded.payload_b64,positions.payload_b64),
ingestor=COALESCE(NULLIF(positions.ingestor,''), excluded.ingestor)
SQL
end
@@ -721,6 +724,7 @@ module PotatoMesh
touch_node_last_seen(db, node_id || node_num, node_num, rx_time: rx_time, source: :neighborinfo)
neighbor_entries = []
ingestor = string_or_nil(payload["ingestor"])
neighbors_payload = payload["neighbors"]
neighbors_list = neighbors_payload.is_a?(Array) ? neighbors_payload : []
@@ -757,21 +761,41 @@ module PotatoMesh
snr = coerce_float(neighbor["snr"])
ensure_unknown_node(db, neighbor_id || neighbor_num, neighbor_num, heard_time: entry_rx_time)
touch_node_last_seen(db, neighbor_id || neighbor_num, neighbor_num, rx_time: entry_rx_time, source: :neighborinfo)
neighbor_entries << [neighbor_id, snr, entry_rx_time]
neighbor_entries << [neighbor_id, snr, entry_rx_time, ingestor]
end
with_busy_retry do
db.transaction do
db.execute("DELETE FROM neighbors WHERE node_id = ?", [node_id])
neighbor_entries.each do |neighbor_id, snr_value, heard_time|
if neighbor_entries.empty?
db.execute("DELETE FROM neighbors WHERE node_id = ?", [node_id])
else
expected_neighbors = neighbor_entries.map(&:first).uniq
existing_neighbors = db.execute(
"SELECT neighbor_id FROM neighbors WHERE node_id = ?",
[node_id],
).flatten
stale_neighbors = existing_neighbors - expected_neighbors
stale_neighbors.each_slice(500) do |slice|
placeholders = slice.map { "?" }.join(",")
db.execute(
"DELETE FROM neighbors WHERE node_id = ? AND neighbor_id IN (#{placeholders})",
[node_id] + slice,
)
end
end
neighbor_entries.each do |neighbor_id, snr_value, heard_time, reporter_id|
db.execute(
<<~SQL,
INSERT OR REPLACE INTO neighbors(node_id, neighbor_id, snr, rx_time)
VALUES (?, ?, ?, ?)
INSERT INTO neighbors(node_id, neighbor_id, snr, rx_time, ingestor)
VALUES (?, ?, ?, ?, ?)
ON CONFLICT(node_id, neighbor_id) DO UPDATE SET
snr = excluded.snr,
rx_time = excluded.rx_time,
ingestor = COALESCE(NULLIF(neighbors.ingestor,''), excluded.ingestor)
SQL
[node_id, neighbor_id, snr_value, heard_time],
[node_id, neighbor_id, snr_value, heard_time, reporter_id],
)
end
end
@@ -981,6 +1005,7 @@ module PotatoMesh
payload_b64 = string_or_nil(payload["payload_b64"] || payload["payload"])
lora_freq = coerce_integer(payload["lora_freq"] || payload["loraFrequency"])
modem_preset = string_or_nil(payload["modem_preset"] || payload["modemPreset"])
ingestor = string_or_nil(payload["ingestor"])
telemetry_section = normalize_json_object(payload["telemetry"])
device_metrics = normalize_json_object(payload["device_metrics"] || payload["deviceMetrics"])
@@ -1310,6 +1335,7 @@ module PotatoMesh
rainfall_24h,
soil_moisture,
soil_temperature,
ingestor,
]
placeholders = Array.new(row.length, "?").join(",")
@@ -1317,7 +1343,7 @@ module PotatoMesh
with_busy_retry do
db.execute <<~SQL, row
INSERT INTO telemetry(id,node_id,node_num,from_id,to_id,rx_time,rx_iso,telemetry_time,channel,portnum,hop_limit,snr,rssi,bitfield,payload_b64,
battery_level,voltage,channel_utilization,air_util_tx,uptime_seconds,temperature,relative_humidity,barometric_pressure,gas_resistance,current,iaq,distance,lux,white_lux,ir_lux,uv_lux,wind_direction,wind_speed,weight,wind_gust,wind_lull,radiation,rainfall_1h,rainfall_24h,soil_moisture,soil_temperature)
battery_level,voltage,channel_utilization,air_util_tx,uptime_seconds,temperature,relative_humidity,barometric_pressure,gas_resistance,current,iaq,distance,lux,white_lux,ir_lux,uv_lux,wind_direction,wind_speed,weight,wind_gust,wind_lull,radiation,rainfall_1h,rainfall_24h,soil_moisture,soil_temperature,ingestor)
VALUES (#{placeholders})
ON CONFLICT(id) DO UPDATE SET
node_id=COALESCE(excluded.node_id,telemetry.node_id),
@@ -1359,7 +1385,8 @@ module PotatoMesh
rainfall_1h=COALESCE(excluded.rainfall_1h,telemetry.rainfall_1h),
rainfall_24h=COALESCE(excluded.rainfall_24h,telemetry.rainfall_24h),
soil_moisture=COALESCE(excluded.soil_moisture,telemetry.soil_moisture),
soil_temperature=COALESCE(excluded.soil_temperature,telemetry.soil_temperature)
soil_temperature=COALESCE(excluded.soil_temperature,telemetry.soil_temperature),
ingestor=COALESCE(NULLIF(telemetry.ingestor,''), excluded.ingestor)
SQL
end
@@ -1410,6 +1437,7 @@ module PotatoMesh
metrics&.[]("latency_ms") ||
metrics&.[]("latencyMs"),
)
ingestor = string_or_nil(payload["ingestor"])
hops_value = payload.key?("hops") ? payload["hops"] : payload["path"]
hops = normalize_trace_hops(hops_value)
@@ -1421,9 +1449,9 @@ module PotatoMesh
end
with_busy_retry do
db.execute <<~SQL, [trace_identifier, request_id, src, dest, rx_time, rx_iso, rssi, snr, elapsed_ms]
INSERT INTO traces(id, request_id, src, dest, rx_time, rx_iso, rssi, snr, elapsed_ms)
VALUES(?,?,?,?,?,?,?,?,?)
db.execute <<~SQL, [trace_identifier, request_id, src, dest, rx_time, rx_iso, rssi, snr, elapsed_ms, ingestor]
INSERT INTO traces(id, request_id, src, dest, rx_time, rx_iso, rssi, snr, elapsed_ms, ingestor)
VALUES(?,?,?,?,?,?,?,?,?,?)
ON CONFLICT(id) DO UPDATE SET
request_id=COALESCE(excluded.request_id,traces.request_id),
src=COALESCE(excluded.src,traces.src),
@@ -1432,7 +1460,8 @@ module PotatoMesh
rx_iso=excluded.rx_iso,
rssi=COALESCE(excluded.rssi,traces.rssi),
snr=COALESCE(excluded.snr,traces.snr),
elapsed_ms=COALESCE(excluded.elapsed_ms,traces.elapsed_ms)
elapsed_ms=COALESCE(excluded.elapsed_ms,traces.elapsed_ms),
ingestor=COALESCE(NULLIF(traces.ingestor,''), excluded.ingestor)
SQL
trace_id = trace_identifier || db.last_insert_row_id
@@ -1497,7 +1526,6 @@ module PotatoMesh
portnum: data[:portnum],
payload: data[:payload],
channel_name: channel_name,
decryption_confidence: data[:decryption_confidence],
}
end
@@ -1567,13 +1595,10 @@ module PotatoMesh
channel_index = coerce_integer(message["channel"] || message["channel_index"] || message["channelIndex"])
decrypted_payload = nil
decrypted_text = nil
decrypted_portnum = nil
decrypted_flag = false
decryption_confidence = nil
if encrypted && (text.nil? || text.to_s.strip.empty?)
decrypted_data = decrypt_meshtastic_message(
decrypted = decrypt_meshtastic_message(
message,
msg_id,
from_id,
@@ -1581,24 +1606,9 @@ module PotatoMesh
channel_index,
)
if decrypted_data
decrypted_payload = decrypted_data
decrypted_portnum = decrypted_data[:portnum]
if decrypted_data[:text]
text = decrypted_data[:text]
decrypted_text = text
clear_encrypted = true
encrypted = nil
message["text"] = text
message["channel_name"] ||= decrypted_data[:channel_name]
decrypted_flag = true
decryption_confidence = decrypted_data[:decryption_confidence] || 0.0
if portnum.nil? && decrypted_portnum
portnum = decrypted_portnum
message["portnum"] = portnum
end
end
if decrypted
decrypted_payload = decrypted
decrypted_portnum = decrypted[:portnum]
end
end
@@ -1612,6 +1622,7 @@ module PotatoMesh
channel_name = string_or_nil(message["channel_name"] || message["channelName"])
reply_id = coerce_integer(message["reply_id"] || message["replyId"])
emoji = string_or_nil(message["emoji"])
ingestor = string_or_nil(message["ingestor"])
row = [
msg_id,
@@ -1631,13 +1642,12 @@ module PotatoMesh
channel_name,
reply_id,
emoji,
decrypted_flag ? 1 : 0,
decryption_confidence,
ingestor,
]
with_busy_retry do
existing = db.get_first_row(
"SELECT from_id, to_id, text, encrypted, lora_freq, modem_preset, channel_name, reply_id, emoji, portnum, decrypted, decryption_confidence FROM messages WHERE id = ?",
"SELECT from_id, to_id, text, encrypted, lora_freq, modem_preset, channel_name, reply_id, emoji, portnum, ingestor FROM messages WHERE id = ?",
[msg_id],
)
if existing
@@ -1692,11 +1702,6 @@ module PotatoMesh
updates["rx_iso"] = rx_iso if rx_iso
end
if clear_encrypted
updates["decrypted"] = 1
updates["decryption_confidence"] = decryption_confidence
end
if portnum
existing_portnum = existing.is_a?(Hash) ? existing["portnum"] : existing[9]
existing_portnum_str = existing_portnum&.to_s
@@ -1740,6 +1745,12 @@ module PotatoMesh
updates["emoji"] = emoji if should_update
end
if ingestor
existing_ingestor = existing.is_a?(Hash) ? existing["ingestor"] : existing[10]
existing_ingestor = string_or_nil(existing_ingestor)
updates["ingestor"] = ingestor if existing_ingestor.nil?
end
unless updates.empty?
assignments = updates.keys.map { |column| "#{column} = ?" }.join(", ")
db.execute("UPDATE messages SET #{assignments} WHERE id = ?", updates.values + [msg_id])
@@ -1749,12 +1760,12 @@ module PotatoMesh
begin
db.execute <<~SQL, row
INSERT INTO messages(id,rx_time,rx_iso,from_id,to_id,channel,portnum,text,encrypted,snr,rssi,hop_limit,lora_freq,modem_preset,channel_name,reply_id,emoji,decrypted,decryption_confidence)
VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)
INSERT INTO messages(id,rx_time,rx_iso,from_id,to_id,channel,portnum,text,encrypted,snr,rssi,hop_limit,lora_freq,modem_preset,channel_name,reply_id,emoji,ingestor)
VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)
SQL
rescue SQLite3::ConstraintException
existing_row = db.get_first_row(
"SELECT text, encrypted FROM messages WHERE id = ?",
"SELECT text, encrypted, ingestor FROM messages WHERE id = ?",
[msg_id],
)
existing_text = existing_row.is_a?(Hash) ? existing_row["text"] : existing_row&.[](0)
@@ -1762,6 +1773,8 @@ module PotatoMesh
allow_encrypted_update = existing_text_str.nil? || existing_text_str.strip.empty?
existing_encrypted = existing_row.is_a?(Hash) ? existing_row["encrypted"] : existing_row&.[](1)
existing_encrypted_str = existing_encrypted&.to_s
existing_ingestor = existing_row.is_a?(Hash) ? existing_row["ingestor"] : existing_row&.[](2)
existing_ingestor = string_or_nil(existing_ingestor)
decrypted_precedence = text && (clear_encrypted || (existing_encrypted_str && !existing_encrypted_str.strip.empty?))
fallback_updates = {}
@@ -1771,10 +1784,6 @@ module PotatoMesh
fallback_updates["encrypted"] = encrypted if encrypted && allow_encrypted_update
fallback_updates["encrypted"] = nil if clear_encrypted
fallback_updates["portnum"] = portnum if portnum
if clear_encrypted
fallback_updates["decrypted"] = 1
fallback_updates["decryption_confidence"] = decryption_confidence
end
if decrypted_precedence
fallback_updates["channel"] = message["channel"] if message.key?("channel")
fallback_updates["snr"] = message["snr"] if message.key?("snr")
@@ -1793,6 +1802,7 @@ module PotatoMesh
end
fallback_updates["reply_id"] = reply_id unless reply_id.nil?
fallback_updates["emoji"] = emoji if emoji
fallback_updates["ingestor"] = ingestor if ingestor && existing_ingestor.nil?
unless fallback_updates.empty?
assignments = fallback_updates.keys.map { |column| "#{column} = ?" }.join(", ")
db.execute("UPDATE messages SET #{assignments} WHERE id = ?", fallback_updates.values + [msg_id])
@@ -1801,7 +1811,7 @@ module PotatoMesh
end
end
if clear_encrypted && decrypted_text
if clear_encrypted && text
debug_log(
"Stored decrypted text message",
context: "data_processing.insert_message",
@@ -1843,7 +1853,7 @@ module PotatoMesh
)
end
should_touch_message = !stored_decrypted || decrypted_text
should_touch_message = !stored_decrypted
if should_touch_message
ensure_unknown_node(db, from_id || raw_from_id, message["from_num"], heard_time: rx_time)
touch_node_last_seen(
@@ -1909,7 +1919,7 @@ module PotatoMesh
return false unless portnum_value
payload_b64 = Base64.strict_encode64(payload_bytes)
supported_ports = [3, 67, 70, 71]
supported_ports = [3, 4, 67, 70, 71]
return false unless supported_ports.include?(portnum_value)
decoded = PotatoMesh::App::Meshtastic::PayloadDecoder.decode(
@@ -1934,6 +1944,7 @@ module PotatoMesh
"lora_freq" => coerce_integer(message["lora_freq"] || message["loraFrequency"]),
"modem_preset" => string_or_nil(message["modem_preset"] || message["modemPreset"]),
"payload_b64" => payload_b64,
"ingestor" => string_or_nil(message["ingestor"]),
}
case decoded["type"]
@@ -1947,6 +1958,33 @@ module PotatoMesh
portnum: portnum_value,
)
true
when "NODEINFO_APP"
node_payload = normalize_decrypted_nodeinfo_payload(decoded["payload"])
return false unless valid_decrypted_nodeinfo_payload?(node_payload)
node_id = string_or_nil(node_payload["id"]) || from_id
node_num = coerce_integer(node_payload["num"]) ||
coerce_integer(message["from_num"]) ||
resolve_node_num(from_id, message)
node_id ||= format("!%08x", node_num & 0xFFFFFFFF) if node_num
return false unless node_id
payload = node_payload.merge(
"num" => node_num,
"lastHeard" => coerce_integer(node_payload["lastHeard"] || node_payload["last_heard"]) || rx_time,
"snr" => node_payload.key?("snr") ? node_payload["snr"] : snr,
"lora_freq" => common_payload["lora_freq"],
"modem_preset" => common_payload["modem_preset"],
)
upsert_node(db, node_id, payload)
debug_log(
"Stored decrypted node payload",
context: "data_processing.store_decrypted_payload",
message_id: packet_id,
portnum: portnum_value,
node_id: node_id,
)
true
when "TELEMETRY_APP"
payload = common_payload.merge("telemetry" => decoded["payload"])
insert_telemetry(db, payload)
@@ -2009,6 +2047,92 @@ module PotatoMesh
end
end
# Validate decoded NodeInfo payloads before upserting node records.
#
# @param payload [Object] decoded payload candidate.
# @return [Boolean] true when the payload resembles a Meshtastic NodeInfo.
def valid_decrypted_nodeinfo_payload?(payload)
return false unless payload.is_a?(Hash)
return false if payload.empty?
return false unless payload["user"].is_a?(Hash)
return false if payload.key?("position") && !payload["position"].is_a?(Hash)
return false if payload.key?("deviceMetrics") && !payload["deviceMetrics"].is_a?(Hash)
return false unless nodeinfo_user_has_identifying_fields?(payload["user"])
true
end
# Normalize decoded NodeInfo payload keys for +upsert_node+ compatibility.
#
# The Python decoder preserves protobuf field names, so nested hashes may
# use +snake_case+ keys that +upsert_node+ does not read.
#
# @param payload [Object] decoded NodeInfo payload.
# @return [Hash] normalized payload hash.
def normalize_decrypted_nodeinfo_payload(payload)
return {} unless payload.is_a?(Hash)
user = payload["user"]
normalized_user = user.is_a?(Hash) ? user.dup : nil
if normalized_user
normalized_user["shortName"] ||= normalized_user["short_name"]
normalized_user["longName"] ||= normalized_user["long_name"]
normalized_user["hwModel"] ||= normalized_user["hw_model"]
normalized_user["publicKey"] ||= normalized_user["public_key"]
normalized_user["isUnmessagable"] = normalized_user["is_unmessagable"] if normalized_user.key?("is_unmessagable")
end
metrics = payload["deviceMetrics"] || payload["device_metrics"]
normalized_metrics = metrics.is_a?(Hash) ? metrics.dup : nil
if normalized_metrics
normalized_metrics["batteryLevel"] ||= normalized_metrics["battery_level"]
normalized_metrics["channelUtilization"] ||= normalized_metrics["channel_utilization"]
normalized_metrics["airUtilTx"] ||= normalized_metrics["air_util_tx"]
normalized_metrics["uptimeSeconds"] ||= normalized_metrics["uptime_seconds"]
end
position = payload["position"]
normalized_position = position.is_a?(Hash) ? position.dup : nil
if normalized_position
normalized_position["precisionBits"] ||= normalized_position["precision_bits"]
normalized_position["locationSource"] ||= normalized_position["location_source"]
end
normalized = payload.dup
normalized["user"] = normalized_user if normalized_user
normalized["deviceMetrics"] = normalized_metrics if normalized_metrics
normalized["position"] = normalized_position if normalized_position
normalized["lastHeard"] ||= normalized["last_heard"]
normalized["hopsAway"] ||= normalized["hops_away"]
normalized["isFavorite"] = normalized["is_favorite"] if normalized.key?("is_favorite")
normalized["hwModel"] ||= normalized["hw_model"]
normalized
end
# Validate that a decoded NodeInfo user section contains identifying data.
#
# @param user [Hash] decoded NodeInfo user payload.
# @return [Boolean] true when at least one identifying field is present.
def nodeinfo_user_has_identifying_fields?(user)
identifying_fields = [
user["id"],
user["shortName"],
user["short_name"],
user["longName"],
user["long_name"],
user["macaddr"],
user["hwModel"],
user["hw_model"],
user["publicKey"],
user["public_key"],
]
identifying_fields.any? do |value|
value.is_a?(String) ? !value.strip.empty? : !value.nil?
end
end
def normalize_node_id(db, node_ref)
return nil if node_ref.nil?
ref_str = node_ref.to_s.strip
+31 -9
View File
@@ -149,15 +149,8 @@ module PotatoMesh
db.execute("ALTER TABLE messages ADD COLUMN emoji TEXT")
message_columns << "emoji"
end
unless message_columns.include?("decrypted")
db.execute("ALTER TABLE messages ADD COLUMN decrypted INTEGER NOT NULL DEFAULT 0")
message_columns << "decrypted"
end
unless message_columns.include?("decryption_confidence")
db.execute("ALTER TABLE messages ADD COLUMN decryption_confidence REAL")
message_columns << "decryption_confidence"
unless message_columns.include?("ingestor")
db.execute("ALTER TABLE messages ADD COLUMN ingestor TEXT")
end
reply_index_exists =
@@ -198,6 +191,31 @@ module PotatoMesh
db.execute("ALTER TABLE telemetry ADD COLUMN #{name} #{type}")
telemetry_columns << name
end
unless telemetry_columns.include?("ingestor")
db.execute("ALTER TABLE telemetry ADD COLUMN ingestor TEXT")
end
position_tables =
db.execute("SELECT name FROM sqlite_master WHERE type='table' AND name='positions'").flatten
if position_tables.empty?
positions_schema = File.expand_path("../../../../data/positions.sql", __dir__)
db.execute_batch(File.read(positions_schema))
end
position_columns = db.execute("PRAGMA table_info(positions)").map { |row| row[1] }
unless position_columns.include?("ingestor")
db.execute("ALTER TABLE positions ADD COLUMN ingestor TEXT")
end
neighbor_tables =
db.execute("SELECT name FROM sqlite_master WHERE type='table' AND name='neighbors'").flatten
if neighbor_tables.empty?
neighbors_schema = File.expand_path("../../../../data/neighbors.sql", __dir__)
db.execute_batch(File.read(neighbors_schema))
end
neighbor_columns = db.execute("PRAGMA table_info(neighbors)").map { |row| row[1] }
unless neighbor_columns.include?("ingestor")
db.execute("ALTER TABLE neighbors ADD COLUMN ingestor TEXT")
end
trace_tables =
db.execute(
@@ -207,6 +225,10 @@ module PotatoMesh
traces_schema = File.expand_path("../../../../data/traces.sql", __dir__)
db.execute_batch(File.read(traces_schema))
end
trace_columns = db.execute("PRAGMA table_info(traces)").map { |row| row[1] }
unless trace_columns.include?("ingestor")
db.execute("ALTER TABLE traces ADD COLUMN ingestor TEXT")
end
ingestor_tables =
db.execute("SELECT name FROM sqlite_master WHERE type='table' AND name='ingestors'").flatten
+337 -59
View File
@@ -17,6 +17,8 @@
module PotatoMesh
module App
module Federation
FEDERATION_SLEEP_SLICE_SECONDS = 0.2
# Resolve the canonical domain for the running instance.
#
# @return [String, nil] sanitized instance domain or nil outside production.
@@ -170,6 +172,9 @@ module PotatoMesh
# @return [PotatoMesh::App::WorkerPool, nil] active worker pool if created.
def ensure_federation_worker_pool!
return nil unless federation_enabled?
return nil if federation_shutdown_requested?
ensure_federation_shutdown_hook!
existing = settings.respond_to?(:federation_worker_pool) ? settings.federation_worker_pool : nil
return existing if existing&.alive?
@@ -181,16 +186,77 @@ module PotatoMesh
name: "potato-mesh-fed",
)
set(:federation_worker_pool, pool) if respond_to?(:set)
pool
end
# Ensure federation background workers are torn down during process exit.
#
# @return [void]
def ensure_federation_shutdown_hook!
application = is_a?(Class) ? self : self.class
return application.ensure_federation_shutdown_hook! unless application.equal?(self)
installed = if respond_to?(:settings) && settings.respond_to?(:federation_shutdown_hook_installed)
settings.federation_shutdown_hook_installed
else
instance_variable_defined?(:@federation_shutdown_hook_installed) && @federation_shutdown_hook_installed
end
return if installed
if respond_to?(:set) && settings.respond_to?(:federation_shutdown_hook_installed=)
set(:federation_shutdown_hook_installed, true)
else
@federation_shutdown_hook_installed = true
end
at_exit do
begin
pool.shutdown(timeout: PotatoMesh::Config.federation_task_timeout_seconds)
application.shutdown_federation_background_work!(timeout: PotatoMesh::Config.federation_shutdown_timeout_seconds)
rescue StandardError
# Suppress shutdown errors during interpreter teardown.
end
end
end
set(:federation_worker_pool, pool) if respond_to?(:set)
pool
# Check whether federation workers have received a shutdown request.
#
# @return [Boolean] true when stop has been requested.
def federation_shutdown_requested?
return false unless respond_to?(:settings)
return false unless settings.respond_to?(:federation_shutdown_requested)
settings.federation_shutdown_requested == true
end
# Mark federation background work as shutting down.
#
# @return [void]
def request_federation_shutdown!
set(:federation_shutdown_requested, true) if respond_to?(:set)
end
# Clear any previously requested federation shutdown marker.
#
# @return [void]
def clear_federation_shutdown_request!
set(:federation_shutdown_requested, false) if respond_to?(:set)
end
# Sleep in short intervals so federation loops can react to shutdown.
#
# @param seconds [Numeric] target sleep duration.
# @return [Boolean] true when the full delay elapsed without shutdown.
def federation_sleep_with_shutdown(seconds)
remaining = seconds.to_f
while remaining.positive?
return false if federation_shutdown_requested?
slice = [remaining, FEDERATION_SLEEP_SLICE_SECONDS].min
Kernel.sleep(slice)
remaining -= slice
end
!federation_shutdown_requested?
end
# Shutdown and clear the federation worker pool if present.
@@ -214,6 +280,44 @@ module PotatoMesh
end
end
# Gracefully terminate federation background loops and worker pool tasks.
#
# @param timeout [Numeric, nil] maximum join time applied per thread.
# @return [void]
def shutdown_federation_background_work!(timeout: nil)
request_federation_shutdown!
timeout_value = timeout || PotatoMesh::Config.federation_shutdown_timeout_seconds
stop_federation_thread!(:initial_federation_thread, timeout: timeout_value)
stop_federation_thread!(:federation_thread, timeout: timeout_value)
shutdown_federation_worker_pool!
clear_federation_crawl_state!
end
# Stop a specific federation thread setting and clear its reference.
#
# @param setting_name [Symbol] settings key storing the thread object.
# @param timeout [Numeric] seconds to wait for clean thread exit.
# @return [void]
def stop_federation_thread!(setting_name, timeout:)
return unless respond_to?(:settings)
return unless settings.respond_to?(setting_name)
thread = settings.public_send(setting_name)
if thread&.alive?
begin
thread.wakeup if thread.respond_to?(:wakeup)
rescue ThreadError
# The thread may not currently be sleeping; continue shutdown.
end
thread.join(timeout)
if thread.alive?
thread.kill
thread.join(0.1)
end
end
set(setting_name, nil) if respond_to?(:set)
end
def federation_target_domains(self_domain)
normalized_self = sanitize_instance_domain(self_domain)&.downcase
ordered = []
@@ -265,16 +369,21 @@ module PotatoMesh
def announce_instance_to_domain(domain, payload_json)
return false unless domain && !domain.empty?
return false if federation_shutdown_requested?
https_failures = []
instance_uri_candidates(domain, "/api/instances").each do |uri|
published = instance_uri_candidates(domain, "/api/instances").any? do |uri|
break false if federation_shutdown_requested?
begin
http = build_remote_http_client(uri)
response = http.start do |connection|
request = build_federation_http_request(Net::HTTP::Post, uri)
request.body = payload_json
connection.request(request)
response = Timeout.timeout(PotatoMesh::Config.remote_instance_request_timeout) do
http.start do |connection|
request = build_federation_http_request(Net::HTTP::Post, uri)
request.body = payload_json
connection.request(request)
end
end
if response.is_a?(Net::HTTPSuccess)
debug_log(
@@ -283,14 +392,16 @@ module PotatoMesh
target: uri.to_s,
status: response.code,
)
return true
true
else
debug_log(
"Federation announcement failed",
context: "federation.announce",
target: uri.to_s,
status: response.code,
)
false
end
debug_log(
"Federation announcement failed",
context: "federation.announce",
target: uri.to_s,
status: response.code,
)
rescue StandardError => e
metadata = {
context: "federation.announce",
@@ -305,9 +416,18 @@ module PotatoMesh
**metadata,
)
https_failures << metadata
next
else
warn_log(
"Federation announcement raised exception",
**metadata,
)
end
false
end
end
unless published
https_failures.each do |metadata|
warn_log(
"Federation announcement raised exception",
**metadata,
@@ -315,14 +435,7 @@ module PotatoMesh
end
end
https_failures.each do |metadata|
warn_log(
"Federation announcement raised exception",
**metadata,
)
end
false
published
end
# Determine whether an HTTPS announcement failure should fall back to HTTP.
@@ -342,6 +455,7 @@ module PotatoMesh
def announce_instance_to_all_domains
return unless federation_enabled?
return if federation_shutdown_requested?
attributes, signature = ensure_self_instance_record!
payload_json = JSON.generate(instance_announcement_payload(attributes, signature))
@@ -349,13 +463,15 @@ module PotatoMesh
pool = federation_worker_pool
scheduled = []
domains.each do |domain|
domains.each_with_object(scheduled) do |domain, scheduled_tasks|
break if federation_shutdown_requested?
if pool
begin
task = pool.schedule do
announce_instance_to_domain(domain, payload_json)
end
scheduled << [domain, task]
scheduled_tasks << [domain, task]
next
rescue PotatoMesh::App::WorkerPool::QueueFullError
warn_log(
@@ -396,7 +512,9 @@ module PotatoMesh
return if scheduled.empty?
timeout = PotatoMesh::Config.federation_task_timeout_seconds
scheduled.each do |domain, task|
scheduled.all? do |domain, task|
break false if federation_shutdown_requested?
begin
task.wait(timeout: timeout)
rescue PotatoMesh::App::WorkerPool::TaskTimeoutError => e
@@ -417,19 +535,23 @@ module PotatoMesh
error_message: e.message,
)
end
true
end
end
def start_federation_announcer!
# Federation broadcasts must not execute when federation support is disabled.
return nil unless federation_enabled?
clear_federation_shutdown_request!
ensure_federation_shutdown_hook!
existing = settings.federation_thread
return existing if existing&.alive?
thread = Thread.new do
loop do
sleep PotatoMesh::Config.federation_announcement_interval
break unless federation_sleep_with_shutdown(PotatoMesh::Config.federation_announcement_interval)
begin
announce_instance_to_all_domains
rescue StandardError => e
@@ -455,6 +577,8 @@ module PotatoMesh
def start_initial_federation_announcement!
# Skip the initial broadcast entirely when federation is disabled.
return nil unless federation_enabled?
clear_federation_shutdown_request!
ensure_federation_shutdown_hook!
existing = settings.respond_to?(:initial_federation_thread) ? settings.initial_federation_thread : nil
return existing if existing&.alive?
@@ -462,7 +586,12 @@ module PotatoMesh
thread = Thread.new do
begin
delay = PotatoMesh::Config.initial_federation_delay_seconds
Kernel.sleep(delay) if delay.positive?
if delay.positive?
completed = federation_sleep_with_shutdown(delay)
next unless completed
end
next if federation_shutdown_requested?
announce_instance_to_all_domains
rescue StandardError => e
warn_log(
@@ -523,15 +652,19 @@ module PotatoMesh
end
def perform_instance_http_request(uri)
raise InstanceFetchError, "federation shutdown requested" if federation_shutdown_requested?
http = build_remote_http_client(uri)
http.start do |connection|
request = build_federation_http_request(Net::HTTP::Get, uri)
response = connection.request(request)
case response
when Net::HTTPSuccess
response.body
else
raise InstanceFetchError, "unexpected response #{response.code}"
Timeout.timeout(PotatoMesh::Config.remote_instance_request_timeout) do
http.start do |connection|
request = build_federation_http_request(Net::HTTP::Get, uri)
response = connection.request(request)
case response
when Net::HTTPSuccess
response.body
else
raise InstanceFetchError, "unexpected response #{response.code}"
end
end
end
rescue StandardError => e
@@ -588,8 +721,12 @@ module PotatoMesh
end
def fetch_instance_json(domain, path)
return [nil, ["federation shutdown requested"]] if federation_shutdown_requested?
errors = []
instance_uri_candidates(domain, path).each do |uri|
break if federation_shutdown_requested?
begin
body = perform_instance_http_request(uri)
return [JSON.parse(body), uri] if body
@@ -602,6 +739,34 @@ module PotatoMesh
[nil, errors]
end
# Resolve the best matching active-node count from a remote /api/stats payload.
#
# @param payload [Hash, nil] decoded JSON payload from /api/stats.
# @param max_age_seconds [Integer] activity window currently expected for federation freshness.
# @return [Integer, nil] selected active-node count when available.
def remote_active_node_count_from_stats(payload, max_age_seconds:)
return nil unless payload.is_a?(Hash)
active_nodes = payload["active_nodes"]
return nil unless active_nodes.is_a?(Hash)
age = coerce_integer(max_age_seconds) || 0
key = if age <= 3600
"hour"
elsif age <= 86_400
"day"
elsif age <= PotatoMesh::Config.week_seconds
"week"
else
"month"
end
value = coerce_integer(active_nodes[key])
return nil unless value
[value, 0].max
end
# Parse a remote federation instance payload into canonical attributes.
#
# @param payload [Hash] JSON object describing a remote instance.
@@ -662,51 +827,149 @@ module PotatoMesh
# @param overall_limit [Integer, nil] maximum unique domains visited.
# @return [Boolean] true when the crawl was scheduled successfully.
def enqueue_federation_crawl(domain, per_response_limit:, overall_limit:)
pool = federation_worker_pool
sanitized_domain = sanitize_instance_domain(domain)
unless sanitized_domain
warn_log(
"Skipped remote instance crawl",
context: "federation.instances",
domain: domain,
reason: "invalid domain",
)
return false
end
return false if federation_shutdown_requested?
application = is_a?(Class) ? self : self.class
pool = application.federation_worker_pool
unless pool
debug_log(
"Skipped remote instance crawl",
context: "federation.instances",
domain: domain,
domain: sanitized_domain,
reason: "federation disabled",
)
return false
end
application = is_a?(Class) ? self : self.class
claim_result = application.claim_federation_crawl_slot(sanitized_domain)
unless claim_result == :claimed
debug_log(
"Skipped remote instance crawl",
context: "federation.instances",
domain: sanitized_domain,
reason: claim_result == :in_flight ? "crawl already in flight" : "recent crawl completed",
)
return false
end
pool.schedule do
db = application.open_database
db = nil
begin
db = application.open_database
application.ingest_known_instances_from!(
db,
domain,
sanitized_domain,
per_response_limit: per_response_limit,
overall_limit: overall_limit,
)
ensure
db&.close
application.release_federation_crawl_slot(sanitized_domain)
end
end
true
rescue PotatoMesh::App::WorkerPool::QueueFullError
warn_log(
"Skipped remote instance crawl",
context: "federation.instances",
domain: domain,
reason: "worker queue saturated",
)
false
application.handle_failed_federation_crawl_schedule(sanitized_domain, "worker queue saturated")
rescue PotatoMesh::App::WorkerPool::ShutdownError
application.handle_failed_federation_crawl_schedule(sanitized_domain, "worker pool shut down")
end
# Handle a failed crawl schedule attempt without applying cooldown.
#
# @param domain [String] canonical domain that failed to schedule.
# @param reason [String] human-readable failure reason.
# @return [Boolean] always false because scheduling did not succeed.
def handle_failed_federation_crawl_schedule(domain, reason)
release_federation_crawl_slot(domain, record_completion: false)
warn_log(
"Skipped remote instance crawl",
context: "federation.instances",
domain: domain,
reason: "worker pool shut down",
reason: reason,
)
false
end
# Initialize shared in-memory state used to deduplicate crawl scheduling.
#
# @return [void]
def initialize_federation_crawl_state!
@federation_crawl_init_mutex ||= Mutex.new
return if instance_variable_defined?(:@federation_crawl_mutex) && @federation_crawl_mutex
@federation_crawl_init_mutex.synchronize do
return if instance_variable_defined?(:@federation_crawl_mutex) && @federation_crawl_mutex
@federation_crawl_mutex = Mutex.new
@federation_crawl_in_flight = Set.new
@federation_crawl_last_completed_at = {}
end
end
# Retrieve the cooldown period used for duplicate crawl suppression.
#
# @return [Integer] seconds a domain remains in cooldown after completion.
def federation_crawl_cooldown_seconds
PotatoMesh::Config.federation_crawl_cooldown_seconds
end
# Mark a domain crawl as claimed if no active or recent crawl exists.
#
# @param domain [String] canonical domain name.
# @return [Symbol] +:claimed+, +:in_flight+, or +:cooldown+.
def claim_federation_crawl_slot(domain)
initialize_federation_crawl_state!
now = Time.now.to_i
@federation_crawl_mutex.synchronize do
return :in_flight if @federation_crawl_in_flight.include?(domain)
last_completed = @federation_crawl_last_completed_at[domain]
if last_completed && now - last_completed < federation_crawl_cooldown_seconds
return :cooldown
end
@federation_crawl_in_flight << domain
:claimed
end
end
# Release an in-flight crawl claim and record completion timestamp.
#
# @param domain [String] canonical domain name.
# @param record_completion [Boolean] true to apply cooldown tracking.
# @return [void]
def release_federation_crawl_slot(domain, record_completion: true)
return unless domain
initialize_federation_crawl_state!
@federation_crawl_mutex.synchronize do
@federation_crawl_in_flight.delete(domain)
@federation_crawl_last_completed_at[domain] = Time.now.to_i if record_completion
end
end
# Clear all in-memory crawl scheduling state.
#
# @return [void]
def clear_federation_crawl_state!
initialize_federation_crawl_state!
@federation_crawl_mutex.synchronize do
@federation_crawl_in_flight.clear
@federation_crawl_last_completed_at.clear
end
end
# Recursively ingest federation records exposed by the supplied domain.
#
# @param db [SQLite3::Database] open database connection used for writes.
@@ -724,6 +987,7 @@ module PotatoMesh
)
sanitized = sanitize_instance_domain(domain)
return visited || Set.new unless sanitized
return visited || Set.new if federation_shutdown_requested?
visited ||= Set.new
@@ -758,6 +1022,8 @@ module PotatoMesh
processed_entries = 0
recent_cutoff = Time.now.to_i - PotatoMesh::Config.remote_instance_max_node_age
payload.each do |entry|
break if federation_shutdown_requested?
if per_response_limit && per_response_limit.positive? && processed_entries >= per_response_limit
debug_log(
"Skipped remote instance entry due to response limit",
@@ -811,21 +1077,33 @@ module PotatoMesh
attributes[:is_private] = false if attributes[:is_private].nil?
stats_payload, stats_metadata = fetch_instance_json(attributes[:domain], "/api/stats")
stats_count = remote_active_node_count_from_stats(
stats_payload,
max_age_seconds: PotatoMesh::Config.remote_instance_max_node_age,
)
attributes[:nodes_count] = stats_count if stats_count
nodes_since_path = "/api/nodes?since=#{recent_cutoff}&limit=1000"
nodes_since_window, nodes_since_metadata = fetch_instance_json(attributes[:domain], nodes_since_path)
if nodes_since_window.is_a?(Array)
if stats_count.nil? && attributes[:nodes_count].nil? && nodes_since_window.is_a?(Array)
attributes[:nodes_count] = nodes_since_window.length
elsif nodes_since_metadata
warn_log(
"Failed to load remote node window",
context: "federation.instances",
domain: attributes[:domain],
reason: Array(nodes_since_metadata).map(&:to_s).join("; "),
)
end
remote_nodes, node_metadata = fetch_instance_json(attributes[:domain], "/api/nodes")
remote_nodes ||= nodes_since_window if nodes_since_window.is_a?(Array)
remote_nodes = nodes_since_window if remote_nodes.nil? && nodes_since_window.is_a?(Array)
if attributes[:nodes_count].nil? && remote_nodes.is_a?(Array)
attributes[:nodes_count] = remote_nodes.length
end
if stats_count.nil? && Array(stats_metadata).any?
debug_log(
"Remote instance /api/stats unavailable; using node list fallback",
context: "federation.instances",
domain: attributes[:domain],
reason: Array(stats_metadata).map(&:to_s).join("; "),
)
end
unless remote_nodes
warn_log(
"Failed to load remote node data",
+81 -22
View File
@@ -165,37 +165,96 @@ module PotatoMesh
# malformed rows gracefully. The dataset is restricted to records updated
# within the rolling window defined by PotatoMesh::Config.week_seconds.
#
# @return [Array<Hash>] list of cleaned instance payloads.
def load_instances_for_api
# @param limit [Integer, nil] optional page size used when pagination is enabled.
# @param cursor [String, nil] optional keyset cursor for pagination.
# @param with_pagination [Boolean] when true, return items and next cursor metadata.
# @return [Array<Hash>, Hash] list of cleaned instance payloads or pagination metadata hash.
def load_instances_for_api(limit: nil, cursor: nil, with_pagination: false)
clean_duplicate_instances!
db = open_database(readonly: true)
db.results_as_hash = true
now = Time.now.to_i
min_last_update_time = now - PotatoMesh::Config.week_seconds
sql = <<~SQL
SELECT id, domain, pubkey, name, version, channel, frequency,
latitude, longitude, last_update_time, is_private, nodes_count, contact_link, signature
FROM instances
WHERE domain IS NOT NULL AND TRIM(domain) != ''
AND pubkey IS NOT NULL AND TRIM(pubkey) != ''
AND last_update_time IS NOT NULL AND last_update_time >= ?
ORDER BY LOWER(domain)
SQL
safe_limit = coerce_query_limit(limit) if with_pagination
fetch_limit = with_pagination ? safe_limit + 1 : nil
where_clauses = [
"id IS NOT NULL",
"TRIM(id) != ''",
"domain IS NOT NULL",
"TRIM(domain) != ''",
"pubkey IS NOT NULL",
"TRIM(pubkey) != ''",
"last_update_time IS NOT NULL",
"last_update_time >= ?",
]
items = []
cursor_payload = with_pagination ? decode_query_cursor(cursor) : nil
cursor_domain = cursor_payload ? sanitize_instance_domain(cursor_payload["domain"])&.downcase : nil
cursor_id = cursor_payload ? string_or_nil(cursor_payload["id"]) : nil
rows = with_busy_retry do
db.execute(sql, min_last_update_time)
loop do
page_where_clauses = where_clauses.dup
page_params = [min_last_update_time]
if with_pagination && cursor_domain && cursor_id
page_where_clauses << "(LOWER(domain) > ? OR (LOWER(domain) = ? AND id > ?))"
page_params.concat([cursor_domain, cursor_domain, cursor_id])
end
sql = <<~SQL
SELECT id, domain, pubkey, name, version, channel, frequency,
latitude, longitude, last_update_time, is_private, nodes_count, contact_link, signature
FROM instances
WHERE #{page_where_clauses.join("\n AND ")}
ORDER BY LOWER(domain), id
SQL
sql += " LIMIT ?" if with_pagination
page_params << fetch_limit if with_pagination
rows = with_busy_retry do
db.execute(sql, page_params)
end
rows.each do |row|
normalized = normalize_instance_row(row)
next unless normalized
last_update_time = normalized["lastUpdateTime"]
next unless last_update_time.is_a?(Integer) && last_update_time >= min_last_update_time
items << normalized
end
return items unless with_pagination
break if items.length > safe_limit
break if rows.length < fetch_limit
marker_row = rows.reverse.find do |row|
string_or_nil(row["domain"]) && string_or_nil(row["id"])
end
break unless marker_row
marker_domain = string_or_nil(marker_row["domain"])&.downcase
marker_id = string_or_nil(marker_row["id"])
break unless marker_domain && marker_id
cursor_domain = marker_domain
cursor_id = marker_id
end
rows.each_with_object([]) do |row, memo|
normalized = normalize_instance_row(row)
next unless normalized
last_update_time = normalized["lastUpdateTime"]
next unless last_update_time.is_a?(Integer) && last_update_time >= min_last_update_time
memo << normalized
has_more = items.length > safe_limit
paged_items = has_more ? items.first(safe_limit) : items
next_cursor = nil
if has_more && !paged_items.empty?
marker = paged_items.last
next_cursor = encode_query_cursor({
"domain" => string_or_nil(marker["domain"]),
"id" => string_or_nil(marker["id"]),
})
end
{ items: paged_items, next_cursor: next_cursor }
rescue SQLite3::Exception => e
warn_log(
"Failed to load instance records",
@@ -203,7 +262,7 @@ module PotatoMesh
error_class: e.class.name,
error_message: e.message,
)
[]
with_pagination ? { items: [], next_cursor: nil } : []
ensure
db&.close
end
@@ -29,8 +29,6 @@ module PotatoMesh
DEFAULT_PSK_B64 = "AQ=="
TEXT_MESSAGE_PORTNUM = 1
# Number of characters required for full confidence scoring.
CONFIDENCE_LENGTH_TARGET = 8.0
# Decrypt an encrypted Meshtastic payload into UTF-8 text.
#
@@ -80,21 +78,12 @@ module PotatoMesh
return nil unless data
text = nil
decryption_confidence = nil
if data[:portnum] == TEXT_MESSAGE_PORTNUM
candidate = data[:payload].dup.force_encoding("UTF-8")
if candidate.valid_encoding? && !candidate.empty?
text = candidate
decryption_confidence = text_confidence(text)
end
text = candidate if candidate.valid_encoding? && !candidate.empty?
end
{
portnum: data[:portnum],
payload: data[:payload],
text: text,
decryption_confidence: decryption_confidence,
}
{ portnum: data[:portnum], payload: data[:payload], text: text }
rescue ArgumentError, OpenSSL::Cipher::CipherError
nil
end
@@ -165,25 +154,6 @@ module PotatoMesh
nil
end
# Score the plausibility of decrypted text content.
#
# @param text [String] decrypted text candidate.
# @return [Float] confidence score between 0.0 and 1.0.
def text_confidence(text)
return 0.0 unless text.is_a?(String)
return 0.0 if text.empty?
total = text.length.to_f
length_score = [total / CONFIDENCE_LENGTH_TARGET, 1.0].min
control_count = text.scan(/[\p{Cc}\p{Cs}]/).length
control_ratio = control_count / total
acceptable_count = text.scan(/[\p{L}\p{N}\p{P}\p{S}\p{Zs}\t\n\r]/).length
acceptable_ratio = acceptable_count / total
score = length_score * acceptable_ratio * (1.0 - control_ratio)
score.clamp(0.0, 1.0)
end
# Resolve the node number from any of the supported identifiers.
#
# @param from_id [String, nil] Meshtastic node identifier.
+410 -72
View File
@@ -127,6 +127,162 @@ module PotatoMesh
[threshold, floor].max
end
# Normalise an optional upper-bound timestamp for keyset pagination.
#
# @param before [Object] requested upper bound expressed as unix seconds.
# @param ceiling [Integer] maximum allowable timestamp.
# @return [Integer, nil] normalized upper bound or nil when absent.
def normalize_before_threshold(before, ceiling: Time.now.to_i)
value = coerce_integer(before)
return nil if value.nil?
value = 0 if value.negative?
[value, ceiling].min
end
# Decode a keyset cursor token previously emitted by {encode_query_cursor}.
#
# @param token [String, nil] base64 cursor token.
# @return [Hash, nil] decoded cursor payload.
def decode_query_cursor(token)
value = string_or_nil(token)
return nil unless value
decoded = Base64.urlsafe_decode64(value)
parsed = JSON.parse(decoded)
parsed.is_a?(Hash) ? parsed : nil
rescue ArgumentError, JSON::ParserError
nil
end
# Encode a cursor payload for keyset pagination transport.
#
# @param payload [Hash] cursor components.
# @return [String] URL-safe base64 cursor token.
def encode_query_cursor(payload)
Base64.urlsafe_encode64(JSON.generate(payload))
end
# Parse a rowid-based time cursor payload from pagination token.
#
# @param cursor [String, nil] cursor token.
# @param time_key [String] payload key containing the timestamp component.
# @return [Array<(Integer, Integer)>, Array<(nil, nil)>] decoded time/rowid pair.
def decode_rowid_time_cursor(cursor, time_key:)
cursor_payload = decode_query_cursor(cursor)
return [nil, nil] unless cursor_payload
[coerce_integer(cursor_payload[time_key]), coerce_integer(cursor_payload["rowid"])]
end
# Build pagination metadata for rowid-keyset collections.
#
# @param items [Array<Hash>] compacted rows.
# @param limit [Integer] requested limit.
# @param time_key [String] cursor payload timestamp key.
# @param marker_time [Proc] extractor receiving marker row hash.
# @return [Hash{Symbol => Object}] items and optional next_cursor.
def build_rowid_pagination_response(items, limit, time_key:, marker_time:)
has_more = items.length > limit
paged_items = has_more ? items.first(limit) : items
next_cursor = nil
if has_more && !paged_items.empty?
marker = paged_items.last
next_cursor = encode_query_cursor({
time_key => coerce_integer(marker_time.call(marker)),
"rowid" => coerce_integer(marker["_cursor_rowid"]),
})
end
paged_items.each { |item| item.delete("_cursor_time") }
paged_items.each { |item| item.delete("_cursor_rowid") }
{ items: paged_items, next_cursor: next_cursor }
end
# Append normalized since/before predicates for time-windowed collections.
#
# @param where_clauses [Array<String>] mutable SQL predicate fragments.
# @param params [Array<Object>] mutable SQL bind parameters.
# @param since [Object] lower-bound timestamp candidate.
# @param before [Object] upper-bound timestamp candidate.
# @param since_floor [Integer] minimum accepted since threshold.
# @param ceiling [Integer] maximum accepted before threshold.
# @param time_expression [String] SQL expression used for temporal filtering.
# @return [Integer] normalized since threshold.
def append_time_window_filters!(
where_clauses:,
params:,
since:,
before:,
since_floor:,
ceiling:,
time_expression:
)
since_threshold = normalize_since_threshold(since, floor: since_floor)
before_threshold = normalize_before_threshold(before, ceiling: ceiling)
where_clauses << "#{time_expression} >= ?"
params << since_threshold
if before_threshold
where_clauses << "#{time_expression} <= ?"
params << before_threshold
end
since_threshold
end
# Append rowid/timestamp keyset predicates for descending time-ordered tables.
#
# @param where_clauses [Array<String>] mutable SQL predicate fragments.
# @param params [Array<Object>] mutable SQL bind parameters.
# @param cursor [String, nil] encoded cursor token.
# @param time_key [String] cursor payload timestamp key.
# @param time_expression [String] SQL timestamp expression used for ordering.
# @return [void]
def append_rowid_time_cursor_filter!(where_clauses:, params:, cursor:, time_key:, time_expression:)
cursor_time, cursor_rowid = decode_rowid_time_cursor(cursor, time_key: time_key)
return unless cursor_time && cursor_rowid
where_clauses << "(#{time_expression} < ? OR (#{time_expression} = ? AND rowid < ?))"
params.concat([cursor_time, cursor_time, cursor_rowid])
end
# Return exact active-node counts across common activity windows.
#
# Counts are resolved directly in SQL with COUNT(*) thresholds against
# +nodes.last_heard+ to avoid sampling bias from list endpoint limits.
#
# @param now [Integer] reference unix timestamp in seconds.
# @param db [SQLite3::Database, nil] optional open database handle to reuse.
# @return [Hash{String => Integer}] counts keyed by hour/day/week/month.
def query_active_node_stats(now: Time.now.to_i, db: nil)
handle = db || open_database(readonly: true)
handle.results_as_hash = true
reference_now = coerce_integer(now) || Time.now.to_i
hour_cutoff = reference_now - 3600
day_cutoff = reference_now - 86_400
week_cutoff = reference_now - PotatoMesh::Config.week_seconds
month_cutoff = reference_now - (30 * 24 * 60 * 60)
private_filter = private_mode? ? " AND (role IS NULL OR role <> 'CLIENT_HIDDEN')" : ""
sql = <<~SQL
SELECT
(SELECT COUNT(*) FROM nodes WHERE last_heard >= ?#{private_filter}) AS hour_count,
(SELECT COUNT(*) FROM nodes WHERE last_heard >= ?#{private_filter}) AS day_count,
(SELECT COUNT(*) FROM nodes WHERE last_heard >= ?#{private_filter}) AS week_count,
(SELECT COUNT(*) FROM nodes WHERE last_heard >= ?#{private_filter}) AS month_count
SQL
row = with_busy_retry do
handle.get_first_row(sql, [hour_cutoff, day_cutoff, week_cutoff, month_cutoff])
end || {}
{
"hour" => row["hour_count"].to_i,
"day" => row["day_count"].to_i,
"week" => row["week_count"].to_i,
"month" => row["month_count"].to_i,
}
ensure
handle&.close unless db
end
def node_reference_tokens(node_ref)
parts = canonical_node_parts(node_ref)
canonical_id, numeric_id = parts ? parts[0, 2] : [nil, nil]
@@ -215,26 +371,43 @@ module PotatoMesh
# @param node_ref [String, Integer, nil] optional node reference to narrow results.
# @param since [Integer] unix timestamp threshold applied in addition to the rolling window for collections.
# @return [Array<Hash>] compacted node rows suitable for API responses.
def query_nodes(limit, node_ref: nil, since: 0)
def query_nodes(limit, node_ref: nil, since: 0, before: nil, cursor: nil, with_pagination: false)
limit = coerce_query_limit(limit)
fetch_limit = with_pagination ? limit + 1 : limit
db = open_database(readonly: true)
db.results_as_hash = true
now = Time.now.to_i
min_last_heard = now - PotatoMesh::Config.week_seconds
since_floor = node_ref ? 0 : min_last_heard
since_threshold = normalize_since_threshold(since, floor: since_floor)
before_threshold = normalize_before_threshold(before, ceiling: now)
params = []
where_clauses = []
if node_ref
clause = node_lookup_clause(node_ref, string_columns: ["node_id"], numeric_columns: ["num"])
return [] unless clause
return with_pagination ? { items: [], next_cursor: nil } : [] unless clause
where_clauses << clause.first
params.concat(clause.last)
else
where_clauses << "last_heard >= ?"
params << since_threshold
end
if before_threshold
where_clauses << "last_heard <= ?"
params << before_threshold
end
if with_pagination
cursor_payload = decode_query_cursor(cursor)
if cursor_payload
cursor_last_heard = coerce_integer(cursor_payload["last_heard"])
cursor_node_id = string_or_nil(cursor_payload["node_id"])
if cursor_last_heard && cursor_node_id
where_clauses << "(last_heard < ? OR (last_heard = ? AND node_id < ?))"
params.concat([cursor_last_heard, cursor_last_heard, cursor_node_id])
end
end
end
if private_mode?
where_clauses << "(role IS NULL OR role <> 'CLIENT_HIDDEN')"
@@ -250,10 +423,10 @@ module PotatoMesh
SQL
sql += " WHERE #{where_clauses.join(" AND ")}\n" if where_clauses.any?
sql += <<~SQL
ORDER BY last_heard DESC
ORDER BY last_heard DESC, node_id DESC
LIMIT ?
SQL
params << limit
params << fetch_limit
rows = db.execute(sql, params)
rows = rows.select do |r|
@@ -263,7 +436,15 @@ module PotatoMesh
.max
last_candidate && last_candidate >= since_threshold
end
rows.each do |r|
has_more = with_pagination && rows.length > limit
paged_rows = has_more ? rows.first(limit) : rows
marker_row = has_more ? paged_rows.last : nil
marker_last_heard = marker_row ? coerce_integer(marker_row["last_heard"]) : nil
marker_node_id = marker_row ? string_or_nil(marker_row["node_id"]) : nil
output_rows = with_pagination ? paged_rows : rows
output_rows.each do |r|
r["role"] ||= "CLIENT"
lh = r["last_heard"]&.to_i
pt = r["position_time"]&.to_i
@@ -276,7 +457,18 @@ module PotatoMesh
pb = r["precision_bits"]
r["precision_bits"] = pb.to_i if pb
end
rows.map { |row| compact_api_row(row) }
items = output_rows.map { |row| compact_api_row(row) }
items.each { |item| item.delete("_cursor_rowid") }
return items unless with_pagination
next_cursor = nil
if has_more && marker_last_heard && marker_node_id
next_cursor = encode_query_cursor({
"last_heard" => marker_last_heard,
"node_id" => marker_node_id,
})
end
{ items: items, next_cursor: next_cursor }
ensure
db&.close
end
@@ -286,22 +478,41 @@ module PotatoMesh
# @param limit [Integer] maximum number of ingestors to return.
# @param since [Integer] unix timestamp threshold applied in addition to the rolling window for collections.
# @return [Array<Hash>] compacted ingestor rows suitable for API responses.
def query_ingestors(limit, since: 0)
def query_ingestors(limit, since: 0, before: nil, cursor: nil, with_pagination: false)
limit = coerce_query_limit(limit)
fetch_limit = with_pagination ? limit + 1 : limit
db = open_database(readonly: true)
db.results_as_hash = true
now = Time.now.to_i
cutoff = now - PotatoMesh::Config.week_seconds
since_threshold = normalize_since_threshold(since, floor: cutoff)
before_threshold = normalize_before_threshold(before, ceiling: now)
where_clauses = ["last_seen_time >= ?"]
params = [since_threshold]
if before_threshold
where_clauses << "last_seen_time <= ?"
params << before_threshold
end
if with_pagination
cursor_payload = decode_query_cursor(cursor)
if cursor_payload
cursor_last_seen = coerce_integer(cursor_payload["last_seen_time"])
cursor_node_id = string_or_nil(cursor_payload["node_id"])
if cursor_last_seen && cursor_node_id
where_clauses << "(last_seen_time < ? OR (last_seen_time = ? AND node_id < ?))"
params.concat([cursor_last_seen, cursor_last_seen, cursor_node_id])
end
end
end
sql = <<~SQL
SELECT node_id, start_time, last_seen_time, version, lora_freq, modem_preset
FROM ingestors
WHERE last_seen_time >= ?
ORDER BY last_seen_time DESC
WHERE #{where_clauses.join(" AND ")}
ORDER BY last_seen_time DESC, node_id DESC
LIMIT ?
SQL
rows = db.execute(sql, [since_threshold, limit])
rows = db.execute(sql, params + [fetch_limit])
rows.each do |row|
row.delete_if { |key, _| key.is_a?(Integer) }
start_time = coerce_integer(row["start_time"])
@@ -317,7 +528,21 @@ module PotatoMesh
row["last_seen_iso"] = Time.at(last_seen_time).utc.iso8601 if last_seen_time
end
rows.map { |row| compact_api_row(row) }
items = rows.map { |row| compact_api_row(row) }
items.each { |item| item.delete("_cursor_rowid") }
return items unless with_pagination
has_more = items.length > limit
paged_items = has_more ? items.first(limit) : items
next_cursor = nil
if has_more && !paged_items.empty?
marker = paged_items.last
next_cursor = encode_query_cursor({
"last_seen_time" => coerce_integer(marker["last_seen_time"]),
"node_id" => string_or_nil(marker["node_id"]),
})
end
{ items: paged_items, next_cursor: next_cursor }
ensure
db&.close
end
@@ -329,9 +554,11 @@ module PotatoMesh
# @param include_encrypted [Boolean] when true, include encrypted payloads in the response.
# @param since [Integer] unix timestamp threshold; messages with rx_time older than this are excluded.
# @return [Array<Hash>] compacted message rows safe for API responses.
def query_messages(limit, node_ref: nil, include_encrypted: false, since: 0)
def query_messages(limit, node_ref: nil, include_encrypted: false, since: 0, before: nil, cursor: nil, with_pagination: false)
limit = coerce_query_limit(limit)
fetch_limit = with_pagination ? limit + 1 : limit
since_threshold = normalize_since_threshold(since, floor: 0)
before_threshold = normalize_before_threshold(before)
db = open_database(readonly: true)
db.results_as_hash = true
params = []
@@ -341,10 +568,25 @@ module PotatoMesh
include_encrypted = !!include_encrypted
where_clauses << "m.rx_time >= ?"
params << since_threshold
if before_threshold
where_clauses << "m.rx_time <= ?"
params << before_threshold
end
unless include_encrypted
where_clauses << "COALESCE(TRIM(m.encrypted), '') = ''"
end
if with_pagination
cursor_payload = decode_query_cursor(cursor)
if cursor_payload
cursor_rx_time = coerce_integer(cursor_payload["rx_time"])
cursor_id = string_or_nil(cursor_payload["id"])
if cursor_rx_time && cursor_id
where_clauses << "(m.rx_time < ? OR (m.rx_time = ? AND m.id < ?))"
params.concat([cursor_rx_time, cursor_rx_time, cursor_id])
end
end
end
if node_ref
clause = node_lookup_clause(node_ref, string_columns: ["m.from_id", "m.to_id"])
@@ -357,15 +599,15 @@ module PotatoMesh
SELECT m.id, m.rx_time, m.rx_iso, m.from_id, m.to_id, m.channel,
m.portnum, m.text, m.encrypted, m.rssi, m.hop_limit,
m.lora_freq, m.modem_preset, m.channel_name, m.snr,
m.reply_id, m.emoji, m.decrypted, m.decryption_confidence
m.reply_id, m.emoji, m.ingestor
FROM messages m
SQL
sql += " WHERE #{where_clauses.join(" AND ")}\n"
sql += <<~SQL
ORDER BY m.rx_time DESC
ORDER BY m.rx_time DESC, m.id DESC
LIMIT ?
SQL
params << limit
params << fetch_limit
rows = db.execute(sql, params)
rows.each do |r|
r.delete_if { |key, _| key.is_a?(Integer) }
@@ -374,27 +616,6 @@ module PotatoMesh
if string_or_nil(r["encrypted"])
r.delete("portnum")
end
if r.key?("decrypted")
decrypted_raw = r["decrypted"]
decrypted = case decrypted_raw
when true, false
decrypted_raw
when Integer
!decrypted_raw.zero?
when String
trimmed = decrypted_raw.strip
!trimmed.empty? && trimmed != "0" && trimmed.casecmp("false") != 0
else
!!decrypted_raw
end
r["decrypted"] = decrypted
r.delete("decryption_confidence") unless decrypted
end
if r.key?("decryption_confidence") && !r["decryption_confidence"].nil?
r["decryption_confidence"] = r["decryption_confidence"].to_f
end
if PotatoMesh::Config.debug? && (r["from_id"].nil? || r["from_id"].to_s.strip.empty?)
raw = db.execute("SELECT * FROM messages WHERE id = ?", [r["id"]]).first
debug_log(
@@ -428,7 +649,21 @@ module PotatoMesh
)
end
end
rows.map { |row| compact_api_row(row) }
items = rows.map { |row| compact_api_row(row) }
items.each { |item| item.delete("_cursor_rowid") }
return items unless with_pagination
has_more = items.length > limit
paged_items = has_more ? items.first(limit) : items
next_cursor = nil
if has_more && !paged_items.empty?
marker = paged_items.last
next_cursor = encode_query_cursor({
"rx_time" => coerce_integer(marker["rx_time"]),
"id" => string_or_nil(marker["id"]),
})
end
{ items: paged_items, next_cursor: next_cursor }
ensure
db&.close
end
@@ -439,18 +674,26 @@ module PotatoMesh
# @param node_ref [String, Integer, nil] optional node reference to scope results.
# @param since [Integer] unix timestamp threshold applied in addition to the rolling window.
# @return [Array<Hash>] compacted position rows suitable for API responses.
def query_positions(limit, node_ref: nil, since: 0)
def query_positions(limit, node_ref: nil, since: 0, before: nil, cursor: nil, with_pagination: false)
limit = coerce_query_limit(limit)
fetch_limit = with_pagination ? limit + 1 : limit
db = open_database(readonly: true)
db.results_as_hash = true
params = []
where_clauses = []
now = Time.now.to_i
min_rx_time = now - PotatoMesh::Config.week_seconds
time_expression = "COALESCE(rx_time, position_time, 0)"
since_floor = node_ref ? 0 : min_rx_time
since_threshold = normalize_since_threshold(since, floor: since_floor)
where_clauses << "COALESCE(rx_time, position_time, 0) >= ?"
params << since_threshold
append_time_window_filters!(
where_clauses: where_clauses,
params: params,
since: since,
before: before,
since_floor: since_floor,
ceiling: now,
time_expression: time_expression,
)
if node_ref
clause = node_lookup_clause(node_ref, string_columns: ["node_id"], numeric_columns: ["node_num"])
@@ -459,15 +702,22 @@ module PotatoMesh
params.concat(clause.last)
end
sql = <<~SQL
SELECT * FROM positions
SQL
append_rowid_time_cursor_filter!(
where_clauses: where_clauses,
params: params,
cursor: cursor,
time_key: "cursor_time",
time_expression: time_expression,
) if with_pagination
select_sql = with_pagination ? "SELECT *, rowid AS _cursor_rowid, COALESCE(rx_time, position_time, 0) AS _cursor_time FROM positions" : "SELECT * FROM positions"
sql = "#{select_sql}\n"
sql += " WHERE #{where_clauses.join(" AND ")}\n" if where_clauses.any?
sql += <<~SQL
ORDER BY rx_time DESC
ORDER BY COALESCE(rx_time, position_time, 0) DESC, rowid DESC
LIMIT ?
SQL
params << limit
params << fetch_limit
rows = db.execute(sql, params)
rows.each do |r|
rx_time = coerce_integer(r["rx_time"])
@@ -487,7 +737,16 @@ module PotatoMesh
r["pdop"] = coerce_float(r["pdop"])
r["snr"] = coerce_float(r["snr"])
end
rows.map { |row| compact_api_row(row) }
items = rows.map { |row| compact_api_row(row) }
items.each { |item| item.delete("_cursor_rowid") } unless with_pagination
return items unless with_pagination
build_rowid_pagination_response(
items,
limit,
time_key: "cursor_time",
marker_time: ->(marker) { marker["_cursor_time"] },
)
ensure
db&.close
end
@@ -498,18 +757,26 @@ module PotatoMesh
# @param node_ref [String, Integer, nil] optional node reference to scope results.
# @param since [Integer] unix timestamp threshold applied in addition to the rolling window for collections.
# @return [Array<Hash>] compacted neighbor rows suitable for API responses.
def query_neighbors(limit, node_ref: nil, since: 0)
def query_neighbors(limit, node_ref: nil, since: 0, before: nil, cursor: nil, with_pagination: false)
limit = coerce_query_limit(limit)
fetch_limit = with_pagination ? limit + 1 : limit
db = open_database(readonly: true)
db.results_as_hash = true
params = []
where_clauses = []
now = Time.now.to_i
min_rx_time = now - PotatoMesh::Config.week_seconds
time_expression = "COALESCE(rx_time, 0)"
since_floor = node_ref ? 0 : min_rx_time
since_threshold = normalize_since_threshold(since, floor: since_floor)
where_clauses << "COALESCE(rx_time, 0) >= ?"
params << since_threshold
append_time_window_filters!(
where_clauses: where_clauses,
params: params,
since: since,
before: before,
since_floor: since_floor,
ceiling: now,
time_expression: time_expression,
)
if node_ref
clause = node_lookup_clause(node_ref, string_columns: ["node_id", "neighbor_id"])
@@ -518,15 +785,22 @@ module PotatoMesh
params.concat(clause.last)
end
sql = <<~SQL
SELECT * FROM neighbors
SQL
append_rowid_time_cursor_filter!(
where_clauses: where_clauses,
params: params,
cursor: cursor,
time_key: "rx_time",
time_expression: "rx_time",
) if with_pagination
select_sql = with_pagination ? "SELECT *, rowid AS _cursor_rowid FROM neighbors" : "SELECT * FROM neighbors"
sql = "#{select_sql}\n"
sql += " WHERE #{where_clauses.join(" AND ")}\n" if where_clauses.any?
sql += <<~SQL
ORDER BY rx_time DESC
ORDER BY rx_time DESC, rowid DESC
LIMIT ?
SQL
params << limit
params << fetch_limit
rows = db.execute(sql, params)
rows.each do |r|
rx_time = coerce_integer(r["rx_time"])
@@ -535,7 +809,16 @@ module PotatoMesh
r["rx_iso"] = Time.at(rx_time).utc.iso8601 if rx_time
r["snr"] = coerce_float(r["snr"])
end
rows.map { |row| compact_api_row(row) }
items = rows.map { |row| compact_api_row(row) }
items.each { |item| item.delete("_cursor_rowid") } unless with_pagination
return items unless with_pagination
build_rowid_pagination_response(
items,
limit,
time_key: "rx_time",
marker_time: ->(marker) { marker["rx_time"] },
)
ensure
db&.close
end
@@ -546,18 +829,26 @@ module PotatoMesh
# @param node_ref [String, Integer, nil] optional node reference to scope results.
# @param since [Integer] unix timestamp threshold applied in addition to the rolling window for collections.
# @return [Array<Hash>] compacted telemetry rows suitable for API responses.
def query_telemetry(limit, node_ref: nil, since: 0)
def query_telemetry(limit, node_ref: nil, since: 0, before: nil, cursor: nil, with_pagination: false)
limit = coerce_query_limit(limit)
fetch_limit = with_pagination ? limit + 1 : limit
db = open_database(readonly: true)
db.results_as_hash = true
params = []
where_clauses = []
now = Time.now.to_i
min_rx_time = now - PotatoMesh::Config.week_seconds
time_expression = "COALESCE(rx_time, telemetry_time, 0)"
since_floor = node_ref ? 0 : min_rx_time
since_threshold = normalize_since_threshold(since, floor: since_floor)
where_clauses << "COALESCE(rx_time, telemetry_time, 0) >= ?"
params << since_threshold
append_time_window_filters!(
where_clauses: where_clauses,
params: params,
since: since,
before: before,
since_floor: since_floor,
ceiling: now,
time_expression: time_expression,
)
if node_ref
clause = node_lookup_clause(node_ref, string_columns: ["node_id"], numeric_columns: ["node_num"])
@@ -566,15 +857,22 @@ module PotatoMesh
params.concat(clause.last)
end
sql = <<~SQL
SELECT * FROM telemetry
SQL
append_rowid_time_cursor_filter!(
where_clauses: where_clauses,
params: params,
cursor: cursor,
time_key: "cursor_time",
time_expression: time_expression,
) if with_pagination
select_sql = with_pagination ? "SELECT *, rowid AS _cursor_rowid, COALESCE(rx_time, telemetry_time, 0) AS _cursor_time FROM telemetry" : "SELECT * FROM telemetry"
sql = "#{select_sql}\n"
sql += " WHERE #{where_clauses.join(" AND ")}\n" if where_clauses.any?
sql += <<~SQL
ORDER BY rx_time DESC
ORDER BY COALESCE(rx_time, telemetry_time, 0) DESC, rowid DESC
LIMIT ?
SQL
params << limit
params << fetch_limit
rows = db.execute(sql, params)
rows.each do |r|
rx_time = coerce_integer(r["rx_time"])
@@ -622,7 +920,16 @@ module PotatoMesh
r["soil_moisture"] = coerce_integer(r["soil_moisture"])
r["soil_temperature"] = coerce_float(r["soil_temperature"])
end
rows.map { |row| compact_api_row(row) }
items = rows.map { |row| compact_api_row(row) }
items.each { |item| item.delete("_cursor_rowid") } unless with_pagination
return items unless with_pagination
build_rowid_pagination_response(
items,
limit,
time_key: "cursor_time",
marker_time: ->(marker) { marker["_cursor_time"] },
)
ensure
db&.close
end
@@ -755,8 +1062,9 @@ module PotatoMesh
# @param node_ref [String, Integer, nil] optional node reference to scope results.
# @param since [Integer] unix timestamp threshold applied in addition to the rolling window.
# @return [Array<Hash>] compacted trace rows suitable for API responses.
def query_traces(limit, node_ref: nil, since: 0)
def query_traces(limit, node_ref: nil, since: 0, before: nil, cursor: nil, with_pagination: false)
limit = coerce_query_limit(limit)
fetch_limit = with_pagination ? limit + 1 : limit
db = open_database(readonly: true)
db.results_as_hash = true
params = []
@@ -764,14 +1072,19 @@ module PotatoMesh
now = Time.now.to_i
min_rx_time = now - PotatoMesh::Config.trace_neighbor_window_seconds
since_threshold = normalize_since_threshold(since, floor: min_rx_time)
before_threshold = normalize_before_threshold(before, ceiling: now)
where_clauses << "COALESCE(rx_time, 0) >= ?"
params << since_threshold
if before_threshold
where_clauses << "COALESCE(rx_time, 0) <= ?"
params << before_threshold
end
if node_ref
tokens = node_reference_tokens(node_ref)
numeric_values = tokens[:numeric_values]
if numeric_values.empty?
return []
return with_pagination ? { items: [], next_cursor: nil } : []
end
placeholders = Array.new(numeric_values.length, "?").join(", ")
candidate_clauses = []
@@ -782,16 +1095,28 @@ module PotatoMesh
3.times { params.concat(numeric_values) }
end
if with_pagination
cursor_payload = decode_query_cursor(cursor)
if cursor_payload
cursor_rx_time = coerce_integer(cursor_payload["rx_time"])
cursor_id = coerce_integer(cursor_payload["id"])
if cursor_rx_time && cursor_id
where_clauses << "(rx_time < ? OR (rx_time = ? AND id < ?))"
params.concat([cursor_rx_time, cursor_rx_time, cursor_id])
end
end
end
sql = <<~SQL
SELECT id, request_id, src, dest, rx_time, rx_iso, rssi, snr, elapsed_ms
FROM traces
SQL
sql += " WHERE #{where_clauses.join(" AND ")}\n" if where_clauses.any?
sql += <<~SQL
ORDER BY rx_time DESC
ORDER BY rx_time DESC, id DESC
LIMIT ?
SQL
params << limit
params << fetch_limit
rows = db.execute(sql, params)
trace_ids = rows.map { |row| coerce_integer(row["id"]) }.compact
@@ -828,7 +1153,20 @@ module PotatoMesh
r["hops"] = hops_by_trace[trace_id]
end
end
rows.map { |row| compact_api_row(row) }
items = rows.map { |row| compact_api_row(row) }
return items unless with_pagination
has_more = items.length > limit
paged_items = has_more ? items.first(limit) : items
next_cursor = nil
if has_more && !paged_items.empty?
marker = paged_items.last
next_cursor = encode_query_cursor({
"rx_time" => coerce_integer(marker["rx_time"]),
"id" => coerce_integer(marker["id"]),
})
end
{ items: paged_items, next_cursor: next_cursor }
ensure
db&.close
end
+126 -15
View File
@@ -64,7 +64,23 @@ module PotatoMesh
app.get "/api/nodes" do
content_type :json
limit = [params["limit"]&.to_i || 200, 1000].min
query_nodes(limit, since: params["since"]).to_json
result = query_nodes(
limit,
since: params["since"],
before: params["before"],
cursor: params["cursor"],
with_pagination: true,
)
response["X-Next-Cursor"] = result[:next_cursor] if result[:next_cursor]
result[:items].to_json
end
app.get "/api/stats" do
content_type :json
{
active_nodes: query_active_node_stats,
sampled: false,
}.to_json
end
app.get "/api/nodes/:id" do
@@ -80,7 +96,15 @@ module PotatoMesh
app.get "/api/ingestors" do
content_type :json
limit = coerce_query_limit(params["limit"])
query_ingestors(limit, since: params["since"]).to_json
result = query_ingestors(
limit,
since: params["since"],
before: params["before"],
cursor: params["cursor"],
with_pagination: true,
)
response["X-Next-Cursor"] = result[:next_cursor] if result[:next_cursor]
result[:items].to_json
end
app.get "/api/messages" do
@@ -89,7 +113,16 @@ module PotatoMesh
include_encrypted = coerce_boolean(params["encrypted"]) || false
since = coerce_integer(params["since"])
since = 0 if since.nil? || since.negative?
query_messages(limit, include_encrypted: include_encrypted, since: since).to_json
result = query_messages(
limit,
include_encrypted: include_encrypted,
since: since,
before: params["before"],
cursor: params["cursor"],
with_pagination: true,
)
response["X-Next-Cursor"] = result[:next_cursor] if result[:next_cursor]
result[:items].to_json
end
app.get "/api/messages/:id" do
@@ -100,18 +133,31 @@ module PotatoMesh
include_encrypted = coerce_boolean(params["encrypted"]) || false
since = coerce_integer(params["since"])
since = 0 if since.nil? || since.negative?
query_messages(
result = query_messages(
limit,
node_ref: node_ref,
include_encrypted: include_encrypted,
since: since,
).to_json
before: params["before"],
cursor: params["cursor"],
with_pagination: true,
)
response["X-Next-Cursor"] = result[:next_cursor] if result[:next_cursor]
result[:items].to_json
end
app.get "/api/positions" do
content_type :json
limit = [params["limit"]&.to_i || 200, 1000].min
query_positions(limit, since: params["since"]).to_json
result = query_positions(
limit,
since: params["since"],
before: params["before"],
cursor: params["cursor"],
with_pagination: true,
)
response["X-Next-Cursor"] = result[:next_cursor] if result[:next_cursor]
result[:items].to_json
end
app.get "/api/positions/:id" do
@@ -119,13 +165,30 @@ module PotatoMesh
node_ref = string_or_nil(params["id"])
halt 400, { error: "missing node id" }.to_json unless node_ref
limit = [params["limit"]&.to_i || 200, 1000].min
query_positions(limit, node_ref: node_ref, since: params["since"]).to_json
result = query_positions(
limit,
node_ref: node_ref,
since: params["since"],
before: params["before"],
cursor: params["cursor"],
with_pagination: true,
)
response["X-Next-Cursor"] = result[:next_cursor] if result[:next_cursor]
result[:items].to_json
end
app.get "/api/neighbors" do
content_type :json
limit = [params["limit"]&.to_i || 200, 1000].min
query_neighbors(limit, since: params["since"]).to_json
result = query_neighbors(
limit,
since: params["since"],
before: params["before"],
cursor: params["cursor"],
with_pagination: true,
)
response["X-Next-Cursor"] = result[:next_cursor] if result[:next_cursor]
result[:items].to_json
end
app.get "/api/neighbors/:id" do
@@ -133,13 +196,30 @@ module PotatoMesh
node_ref = string_or_nil(params["id"])
halt 400, { error: "missing node id" }.to_json unless node_ref
limit = [params["limit"]&.to_i || 200, 1000].min
query_neighbors(limit, node_ref: node_ref, since: params["since"]).to_json
result = query_neighbors(
limit,
node_ref: node_ref,
since: params["since"],
before: params["before"],
cursor: params["cursor"],
with_pagination: true,
)
response["X-Next-Cursor"] = result[:next_cursor] if result[:next_cursor]
result[:items].to_json
end
app.get "/api/telemetry" do
content_type :json
limit = [params["limit"]&.to_i || 200, 1000].min
query_telemetry(limit, since: params["since"]).to_json
result = query_telemetry(
limit,
since: params["since"],
before: params["before"],
cursor: params["cursor"],
with_pagination: true,
)
response["X-Next-Cursor"] = result[:next_cursor] if result[:next_cursor]
result[:items].to_json
end
app.get "/api/telemetry/aggregated" do
@@ -182,13 +262,30 @@ module PotatoMesh
node_ref = string_or_nil(params["id"])
halt 400, { error: "missing node id" }.to_json unless node_ref
limit = [params["limit"]&.to_i || 200, 1000].min
query_telemetry(limit, node_ref: node_ref, since: params["since"]).to_json
result = query_telemetry(
limit,
node_ref: node_ref,
since: params["since"],
before: params["before"],
cursor: params["cursor"],
with_pagination: true,
)
response["X-Next-Cursor"] = result[:next_cursor] if result[:next_cursor]
result[:items].to_json
end
app.get "/api/traces" do
content_type :json
limit = [params["limit"]&.to_i || 200, 1000].min
query_traces(limit, since: params["since"]).to_json
result = query_traces(
limit,
since: params["since"],
before: params["before"],
cursor: params["cursor"],
with_pagination: true,
)
response["X-Next-Cursor"] = result[:next_cursor] if result[:next_cursor]
result[:items].to_json
end
app.get "/api/traces/:id" do
@@ -196,7 +293,16 @@ module PotatoMesh
node_ref = string_or_nil(params["id"])
halt 400, { error: "missing node id" }.to_json unless node_ref
limit = [params["limit"]&.to_i || 200, 1000].min
query_traces(limit, node_ref: node_ref, since: params["since"]).to_json
result = query_traces(
limit,
node_ref: node_ref,
since: params["since"],
before: params["before"],
cursor: params["cursor"],
with_pagination: true,
)
response["X-Next-Cursor"] = result[:next_cursor] if result[:next_cursor]
result[:items].to_json
end
app.get "/api/instances" do
@@ -205,8 +311,13 @@ module PotatoMesh
content_type :json
ensure_self_instance_record!
payload = load_instances_for_api
JSON.generate(payload)
result = load_instances_for_api(
limit: params["limit"],
cursor: params["cursor"],
with_pagination: true,
)
response["X-Next-Cursor"] = result[:next_cursor] if result[:next_cursor]
JSON.generate(result[:items])
end
end
end
+33
View File
@@ -37,11 +37,14 @@ module PotatoMesh
DEFAULT_MAX_DISTANCE_KM = 42.0
DEFAULT_REMOTE_INSTANCE_CONNECT_TIMEOUT = 15
DEFAULT_REMOTE_INSTANCE_READ_TIMEOUT = 60
DEFAULT_REMOTE_INSTANCE_REQUEST_TIMEOUT = 30
DEFAULT_FEDERATION_MAX_INSTANCES_PER_RESPONSE = 64
DEFAULT_FEDERATION_MAX_DOMAINS_PER_CRAWL = 256
DEFAULT_FEDERATION_WORKER_POOL_SIZE = 4
DEFAULT_FEDERATION_WORKER_QUEUE_CAPACITY = 128
DEFAULT_FEDERATION_TASK_TIMEOUT_SECONDS = 120
DEFAULT_FEDERATION_SHUTDOWN_TIMEOUT_SECONDS = 3
DEFAULT_FEDERATION_CRAWL_COOLDOWN_SECONDS = 300
DEFAULT_INITIAL_FEDERATION_DELAY_SECONDS = 2
DEFAULT_FEDERATION_SEED_DOMAINS = %w[potatomesh.net potatomesh.jmrp.io mesh.qrp.ro].freeze
@@ -350,6 +353,16 @@ module PotatoMesh
)
end
# End-to-end timeout applied to each outbound federation HTTP request.
#
# @return [Integer] maximum request duration in seconds.
def remote_instance_request_timeout
fetch_positive_integer(
"REMOTE_INSTANCE_REQUEST_TIMEOUT",
DEFAULT_REMOTE_INSTANCE_REQUEST_TIMEOUT,
)
end
# Limit the number of remote instances processed from a single response.
#
# @return [Integer] maximum entries processed per /api/instances payload.
@@ -400,6 +413,26 @@ module PotatoMesh
)
end
# Determine how long shutdown waits before forcing federation thread exit.
#
# @return [Integer] per-thread shutdown timeout in seconds.
def federation_shutdown_timeout_seconds
fetch_positive_integer(
"FEDERATION_SHUTDOWN_TIMEOUT",
DEFAULT_FEDERATION_SHUTDOWN_TIMEOUT_SECONDS,
)
end
# Define how long finished crawl domains remain on cooldown.
#
# @return [Integer] cooldown window in seconds.
def federation_crawl_cooldown_seconds
fetch_positive_integer(
"FEDERATION_CRAWL_COOLDOWN",
DEFAULT_FEDERATION_CRAWL_COOLDOWN_SECONDS,
)
end
# Maximum acceptable age for remote node data.
#
# @return [Integer] seconds before remote nodes are considered stale.
@@ -62,6 +62,22 @@ function buildModel(overrides = {}) {
});
}
function findChannelByLabel(model, label) {
return model.channels.find(channel => channel.label === label);
}
function assertChannelMessages(model, { label, id, index, messageIds }) {
const channel = findChannelByLabel(model, label);
assert.ok(channel);
if (id instanceof RegExp) {
assert.match(channel.id, id);
} else {
assert.equal(channel.id, id);
}
assert.equal(channel.index, index);
assert.deepEqual(channel.entries.map(entry => entry.message.id), messageIds);
}
test('buildChatTabModel returns sorted nodes and channel buckets', () => {
const model = buildModel();
assert.equal(model.logEntries.length, 3);
@@ -75,12 +91,13 @@ test('buildChatTabModel returns sorted nodes and channel buckets', () => {
['recent-node', 'iso-node', 'encrypted']
);
assert.equal(model.channels.length, 5);
assert.equal(model.channels.length, 6);
assert.deepEqual(model.channels.map(channel => channel.label), [
'EnvDefault',
'Fallback',
'MediumFast',
'ShortFast',
'1',
'BerlinMesh'
]);
@@ -106,11 +123,16 @@ test('buildChatTabModel returns sorted nodes and channel buckets', () => {
assert.equal(presetChannel.id, 'channel-0-shortfast');
assert.deepEqual(presetChannel.entries.map(entry => entry.message.id), ['primary-preset']);
const unnamedSecondaryChannel = channelByLabel['1'];
assert.equal(unnamedSecondaryChannel.index, 1);
assert.equal(unnamedSecondaryChannel.id, 'channel-1');
assert.deepEqual(unnamedSecondaryChannel.entries.map(entry => entry.message.id), ['iso-ts']);
const secondaryChannel = channelByLabel.BerlinMesh;
assert.equal(secondaryChannel.index, 1);
assert.equal(secondaryChannel.id, 'channel-secondary-berlinmesh');
assert.equal(secondaryChannel.entries.length, 2);
assert.deepEqual(secondaryChannel.entries.map(entry => entry.message.id), ['iso-ts', 'recent-alt']);
assert.match(secondaryChannel.id, /^channel-secondary-name-berlinmesh-[a-z0-9]+$/);
assert.equal(secondaryChannel.entries.length, 1);
assert.deepEqual(secondaryChannel.entries.map(entry => entry.message.id), ['recent-alt']);
});
test('buildChatTabModel skips channel buckets when there are no messages', () => {
@@ -272,7 +294,7 @@ test('buildChatTabModel ignores plaintext log-only entries', () => {
assert.equal(encryptedEntries[0]?.message?.id, 'enc');
});
test('buildChatTabModel merges secondary channels with matching labels regardless of index', () => {
test('buildChatTabModel merges secondary channels with matching labels across indexes', () => {
const primaryId = 'primary';
const secondaryFirstId = 'secondary-one';
const secondarySecondId = 'secondary-two';
@@ -296,55 +318,139 @@ test('buildChatTabModel merges secondary channels with matching labels regardles
assert.equal(primaryChannel.entries.length, 1);
assert.equal(primaryChannel.entries[0]?.message?.id, primaryId);
const secondaryChannel = meshChannels.find(channel => channel.index > 0);
assert.ok(secondaryChannel);
assert.equal(secondaryChannel.id, 'channel-secondary-meshtown');
assert.equal(secondaryChannel.index, 3);
assert.deepEqual(secondaryChannel.entries.map(entry => entry.message.id), [secondaryFirstId, secondarySecondId]);
const mergedSecondaryChannel = meshChannels.find(channel => channel.index === 3);
assert.ok(mergedSecondaryChannel);
assert.match(mergedSecondaryChannel.id, /^channel-secondary-name-meshtown-[a-z0-9]+$/);
assert.deepEqual(
mergedSecondaryChannel.entries.map(entry => entry.message.id),
[secondaryFirstId, secondarySecondId]
);
});
test('buildChatTabModel rekeys unnamed secondary buckets when a label later arrives', () => {
const unnamedId = 'unnamed';
const namedId = 'named';
const label = 'SideMesh';
const index = 4;
test('buildChatTabModel keeps unnamed secondary buckets separate when a label later arrives', () => {
const scenarios = [
{
index: 4,
label: 'SideMesh',
messages: [
{ id: 'unnamed', rx_time: NOW - 15, channel: 4 },
{ id: 'named', rx_time: NOW - 10, channel: 4, channel_name: 'SideMesh' }
],
namedId: /^channel-secondary-name-sidemesh-[a-z0-9]+$/,
namedMessages: ['named'],
unnamedMessages: ['unnamed']
},
{
index: 5,
label: 'MeshNorth',
messages: [
{ id: 'named', rx_time: NOW - 12, channel: 5, channel_name: 'MeshNorth' },
{ id: 'unlabeled', rx_time: NOW - 8, channel: 5 }
],
namedId: /^channel-secondary-name-meshnorth-[a-z0-9]+$/,
namedMessages: ['named'],
unnamedMessages: ['unlabeled']
}
];
for (const scenario of scenarios) {
const model = buildChatTabModel({
nodes: [],
messages: scenario.messages,
nowSeconds: NOW,
windowSeconds: WINDOW
});
const secondaryChannels = model.channels.filter(channel => channel.index === scenario.index);
assert.equal(secondaryChannels.length, 2);
assertChannelMessages(model, {
label: scenario.label,
id: scenario.namedId,
index: scenario.index,
messageIds: scenario.namedMessages
});
assertChannelMessages(model, {
label: String(scenario.index),
id: `channel-${scenario.index}`,
index: scenario.index,
messageIds: scenario.unnamedMessages
});
}
});
test('buildChatTabModel keeps same-index channels with different names in separate tabs', () => {
const model = buildChatTabModel({
nodes: [],
messages: [
{ id: unnamedId, rx_time: NOW - 15, channel: index },
{ id: namedId, rx_time: NOW - 10, channel: index, channel_name: label }
{ id: 'public-msg', rx_time: NOW - 12, channel: 1, channel_name: 'PUBLIC' },
{ id: 'berlin-msg', rx_time: NOW - 8, channel: 1, channel_name: 'BerlinMesh' }
],
nowSeconds: NOW,
windowSeconds: WINDOW
});
const secondaryChannels = model.channels.filter(channel => channel.index === index);
assert.equal(secondaryChannels.length, 1);
const [secondaryChannel] = secondaryChannels;
assert.equal(secondaryChannel.id, 'channel-secondary-sidemesh');
assert.equal(secondaryChannel.label, label);
assert.deepEqual(secondaryChannel.entries.map(entry => entry.message.id), [unnamedId, namedId]);
assertChannelMessages(model, {
label: 'PUBLIC',
id: /^channel-secondary-name-public-[a-z0-9]+$/,
index: 1,
messageIds: ['public-msg']
});
assertChannelMessages(model, {
label: 'BerlinMesh',
id: /^channel-secondary-name-berlinmesh-[a-z0-9]+$/,
index: 1,
messageIds: ['berlin-msg']
});
});
test('buildChatTabModel merges unlabeled secondary messages into existing named buckets by index', () => {
const namedId = 'named';
const unlabeledId = 'unlabeled';
const label = 'MeshNorth';
const index = 5;
test('buildChatTabModel merges same-name channels even when indexes differ', () => {
const model = buildChatTabModel({
nodes: [],
messages: [
{ id: namedId, rx_time: NOW - 12, channel: index, channel_name: label },
{ id: unlabeledId, rx_time: NOW - 8, channel: index }
{ id: 'test-1', rx_time: NOW - 12, channel: 1, channel_name: 'TEST' },
{ id: 'test-2', rx_time: NOW - 8, channel: 2, channel_name: 'TEST' }
],
nowSeconds: NOW,
windowSeconds: WINDOW
});
const secondaryChannels = model.channels.filter(channel => channel.index === index);
assert.equal(secondaryChannels.length, 1);
const [secondaryChannel] = secondaryChannels;
assert.equal(secondaryChannel.id, 'channel-secondary-meshnorth');
assert.equal(secondaryChannel.label, label);
assert.deepEqual(secondaryChannel.entries.map(entry => entry.message.id), [namedId, unlabeledId]);
assertChannelMessages(model, {
label: 'TEST',
id: /^channel-secondary-name-test-[a-z0-9]+$/,
index: 1,
messageIds: ['test-1', 'test-2']
});
});
test('buildChatTabModel keeps same-index slug-colliding labels on distinct tab ids', () => {
const model = buildChatTabModel({
nodes: [],
messages: [
{ id: 'foo-space', rx_time: NOW - 10, channel: 1, channel_name: 'Foo Bar' },
{ id: 'foo-dash', rx_time: NOW - 8, channel: 1, channel_name: 'Foo-Bar' }
],
nowSeconds: NOW,
windowSeconds: WINDOW
});
const fooSpaceChannel = findChannelByLabel(model, 'Foo Bar');
const fooDashChannel = findChannelByLabel(model, 'Foo-Bar');
assert.ok(fooSpaceChannel);
assert.ok(fooDashChannel);
assert.match(fooSpaceChannel.id, /^channel-secondary-name-foo-bar-[a-z0-9]+$/);
assert.match(fooDashChannel.id, /^channel-secondary-name-foo-bar-[a-z0-9]+$/);
assert.notEqual(fooSpaceChannel.id, fooDashChannel.id);
});
test('buildChatTabModel falls back to hashed id for unsluggable secondary labels', () => {
const model = buildChatTabModel({
nodes: [],
messages: [{ id: 'hash-fallback', rx_time: NOW - 5, channel: 2, channel_name: '###' }],
nowSeconds: NOW,
windowSeconds: WINDOW
});
const channel = findChannelByLabel(model, '###');
assert.ok(channel);
assert.equal(channel.index, 2);
assert.ok(channel.id.startsWith('channel-secondary-name-'));
assert.ok(channel.id.length > 'channel-secondary-name-'.length);
});
@@ -21,6 +21,55 @@ import { createDomEnvironment } from './dom-environment.js';
import { initializeFederationPage } from '../federation-page.js';
import { roleColors } from '../role-helpers.js';
function createFailureScenarioPage(env) {
const { document, createElement, registerElement } = env;
registerElement('map', createElement('div', 'map'));
const statusEl = createElement('div', 'status');
registerElement('status', statusEl);
const tableEl = createElement('table', 'instances');
const tbodyEl = createElement('tbody');
registerElement('instances', tableEl);
const configEl = createElement('div');
configEl.setAttribute('data-app-config', JSON.stringify({}));
document.querySelector = selector => {
if (selector === '[data-app-config]') return configEl;
if (selector === '#instances tbody') return tbodyEl;
return null;
};
return { statusEl };
}
function createMinimalLeafletStub() {
return {
map() {
return {
setView() {},
on() {},
getPane() {
return null;
}
};
},
tileLayer() {
return {
addTo() {
return this;
},
getContainer() {
return null;
},
on() {}
};
},
layerGroup() {
return { addLayer() {}, addTo() { return this; } };
},
circleMarker() {
return { bindPopup() { return this; } };
}
};
}
test('federation map centers on configured coordinates and follows theme filters', async () => {
const env = createDomEnvironment({ includeBody: true, bodyHasDarkClass: true });
const { document, window, createElement, registerElement, cleanup } = env;
@@ -604,51 +653,9 @@ test('federation legend toggle respects media query changes', async () => {
test('federation page tolerates fetch failures', async () => {
const env = createDomEnvironment({ includeBody: true, bodyHasDarkClass: false });
const { document, createElement, registerElement, cleanup } = env;
const mapEl = createElement('div', 'map');
registerElement('map', mapEl);
const statusEl = createElement('div', 'status');
registerElement('status', statusEl);
const tableEl = createElement('table', 'instances');
const tbodyEl = createElement('tbody');
registerElement('instances', tableEl);
const configEl = createElement('div');
configEl.setAttribute('data-app-config', JSON.stringify({}));
document.querySelector = selector => {
if (selector === '[data-app-config]') return configEl;
if (selector === '#instances tbody') return tbodyEl;
return null;
};
const leafletStub = {
map() {
return {
setView() {},
on() {},
getPane() {
return null;
}
};
},
tileLayer() {
return {
addTo() {
return this;
},
getContainer() {
return null;
},
on() {}
};
},
layerGroup() {
return { addLayer() {}, addTo() { return this; } };
},
circleMarker() {
return { bindPopup() { return this; } };
}
};
const { cleanup } = env;
createFailureScenarioPage(env);
const leafletStub = createMinimalLeafletStub();
const fetchImpl = async () => {
throw new Error('boom');
@@ -657,3 +664,16 @@ test('federation page tolerates fetch failures', async () => {
await initializeFederationPage({ config: {}, fetchImpl, leaflet: leafletStub });
cleanup();
});
test('federation page tolerates non-ok paginated instance responses', async () => {
const env = createDomEnvironment({ includeBody: true, bodyHasDarkClass: false });
const { statusEl } = createFailureScenarioPage(env);
const { cleanup } = env;
const leafletStub = createMinimalLeafletStub();
const fetchImpl = async () => ({ ok: false, json: async () => [] });
await initializeFederationPage({ config: {}, fetchImpl, leaflet: leafletStub });
assert.match(statusEl.textContent, /0 instances/);
cleanup();
});
@@ -221,6 +221,74 @@ test('initializeInstanceSelector updates federation navigation labels with insta
}
});
test('initializeInstanceSelector follows paginated instance responses', async () => {
const env = createDomEnvironment();
const select = setupSelectElement(env.document);
const calls = [];
const fetchImpl = async url => {
calls.push(url);
if (url === '/api/instances?limit=500') {
return {
ok: true,
headers: { get: name => (name === 'X-Next-Cursor' ? 'cursor-1' : null) },
async json() {
return [{ domain: 'alpha.mesh' }];
}
};
}
if (url === '/api/instances?limit=500&cursor=cursor-1') {
return {
ok: true,
headers: { get: () => null },
async json() {
return [{ domain: 'bravo.mesh' }];
}
};
}
throw new Error(`unexpected url ${url}`);
};
try {
await initializeInstanceSelector({
selectElement: select,
fetchImpl,
windowObject: env.window,
documentObject: env.document
});
assert.deepEqual(calls, ['/api/instances?limit=500', '/api/instances?limit=500&cursor=cursor-1']);
assert.equal(select.options.length, 3);
} finally {
env.cleanup();
}
});
test('initializeInstanceSelector handles non-ok instance responses without adding options', async () => {
const env = createDomEnvironment();
const select = setupSelectElement(env.document);
const fetchImpl = async () => ({
ok: false,
async json() {
return [{ domain: 'ignored.mesh' }];
}
});
try {
await initializeInstanceSelector({
selectElement: select,
fetchImpl,
windowObject: env.window,
documentObject: env.document
});
assert.equal(select.options.length, 1);
} finally {
env.cleanup();
}
});
test('updateFederationNavCount prefers stored labels and normalizes counts', () => {
const env = createDomEnvironment();
const navLink = env.document.createElement('a');
@@ -0,0 +1,399 @@
/*
* Copyright © 2025-26 l5yth & contributors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import test from 'node:test';
import assert from 'node:assert/strict';
import {
computeLocalActiveNodeStats,
fetchPaginatedCollection,
fetchActiveNodeStats,
formatActiveNodeStatsText,
normaliseActiveNodeStatsPayload,
readNextCursorHeader,
} from '../main.js';
const NOW = 1_700_000_000;
test('computeLocalActiveNodeStats calculates local hour/day/week/month counts', () => {
const nodes = [
{ last_heard: NOW - 60 },
{ last_heard: NOW - 4_000 },
{ last_heard: NOW - 90_000 },
{ last_heard: NOW - (8 * 86_400) },
{ last_heard: NOW - (20 * 86_400) },
];
const stats = computeLocalActiveNodeStats(nodes, NOW);
assert.deepEqual(stats, {
hour: 1,
day: 2,
week: 3,
month: 5,
sampled: true,
});
});
test('normaliseActiveNodeStatsPayload validates and normalizes API payload', () => {
const payload = {
active_nodes: {
hour: '11',
day: 22,
week: 33,
month: 44,
},
sampled: false,
};
assert.deepEqual(normaliseActiveNodeStatsPayload(payload), {
hour: 11,
day: 22,
week: 33,
month: 44,
sampled: false,
});
assert.equal(normaliseActiveNodeStatsPayload({}), null);
});
test('normaliseActiveNodeStatsPayload rejects malformed stat values', () => {
assert.equal(
normaliseActiveNodeStatsPayload({ active_nodes: { hour: 'x', day: 1, week: 1, month: 1 } }),
null
);
assert.equal(
normaliseActiveNodeStatsPayload({ active_nodes: null }),
null
);
});
test('normaliseActiveNodeStatsPayload clamps negatives and truncates floats', () => {
assert.deepEqual(
normaliseActiveNodeStatsPayload({
active_nodes: { hour: -1.9, day: 2.8, week: 3.1, month: 4.9 },
sampled: 1
}),
{ hour: 0, day: 2, week: 3, month: 4, sampled: true }
);
});
test('fetchActiveNodeStats uses /api/stats when available', async () => {
const calls = [];
const fetchImpl = async (url) => {
calls.push(url);
return {
ok: true,
async json() {
return {
active_nodes: { hour: 5, day: 15, week: 25, month: 35 },
sampled: false,
};
},
};
};
const stats = await fetchActiveNodeStats({ nodes: [], nowSeconds: NOW, fetchImpl });
assert.equal(calls[0], '/api/stats');
assert.deepEqual(stats, {
hour: 5,
day: 15,
week: 25,
month: 35,
sampled: false,
});
});
test('fetchActiveNodeStats reuses cached /api/stats response for repeated calls', async () => {
const calls = [];
const fetchImpl = async (url) => {
calls.push(url);
return {
ok: true,
async json() {
return {
active_nodes: { hour: 2, day: 4, week: 6, month: 8 },
sampled: false,
};
},
};
};
const first = await fetchActiveNodeStats({ nodes: [], nowSeconds: NOW, fetchImpl });
const second = await fetchActiveNodeStats({ nodes: [], nowSeconds: NOW, fetchImpl });
assert.equal(calls.length, 1);
assert.deepEqual(first, second);
});
test('fetchActiveNodeStats does not reuse cache across different fetch implementations', async () => {
const callsA = [];
const callsB = [];
const fetchImplA = async (url) => {
callsA.push(url);
return {
ok: true,
async json() {
return { active_nodes: { hour: 1, day: 1, week: 1, month: 1 }, sampled: false };
},
};
};
const fetchImplB = async (url) => {
callsB.push(url);
return {
ok: true,
async json() {
return { active_nodes: { hour: 2, day: 2, week: 2, month: 2 }, sampled: false };
},
};
};
await fetchActiveNodeStats({ nodes: [], nowSeconds: NOW, fetchImpl: fetchImplA });
await fetchActiveNodeStats({ nodes: [], nowSeconds: NOW, fetchImpl: fetchImplB });
assert.equal(callsA.length, 1);
assert.equal(callsB.length, 1);
});
test('fetchActiveNodeStats falls back to local counts when stats fetch fails', async () => {
const nodes = [
{ last_heard: NOW - 120 },
{ last_heard: NOW - (10 * 86_400) },
];
const fetchImpl = async () => {
throw new Error('network down');
};
const stats = await fetchActiveNodeStats({ nodes, nowSeconds: NOW, fetchImpl });
assert.deepEqual(stats, {
hour: 1,
day: 1,
week: 1,
month: 2,
sampled: true,
});
});
test('fetchActiveNodeStats falls back to local counts on non-OK HTTP responses', async () => {
const stats = await fetchActiveNodeStats({
nodes: [{ last_heard: NOW - 10 }],
nowSeconds: NOW,
fetchImpl: async () => ({ ok: false, status: 503 })
});
assert.equal(stats.sampled, true);
assert.equal(stats.hour, 1);
});
test('fetchActiveNodeStats falls back to local counts on invalid payloads', async () => {
const stats = await fetchActiveNodeStats({
nodes: [{ last_heard: NOW - (31 * 86_400) }],
nowSeconds: NOW,
fetchImpl: async () => ({
ok: true,
async json() {
return { active_nodes: { hour: 'bad' } };
}
})
});
assert.equal(stats.sampled, true);
assert.equal(stats.month, 0);
});
test('formatActiveNodeStatsText emits expected dashboard string', () => {
const text = formatActiveNodeStatsText({
channel: 'LongFast',
frequency: '868MHz',
stats: { hour: 1, day: 2, week: 3, month: 4, sampled: false },
});
assert.equal(
text,
'LongFast (868MHz) — active nodes: 1/hour, 2/day, 3/week, 4/month.'
);
});
test('formatActiveNodeStatsText appends sampled marker when local fallback is used', () => {
const text = formatActiveNodeStatsText({
channel: 'LongFast',
frequency: '868MHz',
stats: { hour: 9, day: 8, week: 7, month: 6, sampled: true },
});
assert.equal(
text,
'LongFast (868MHz) — active nodes: 9/hour, 8/day, 7/week, 6/month (sampled).'
);
});
test('readNextCursorHeader reads cursor token from response headers', () => {
const response = {
headers: {
get(name) {
return name === 'X-Next-Cursor' ? 'cursor-token' : null;
},
},
};
assert.equal(readNextCursorHeader(response), 'cursor-token');
});
test('readNextCursorHeader returns null when response headers are missing', () => {
assert.equal(readNextCursorHeader(null), null);
assert.equal(readNextCursorHeader({ headers: {} }), null);
});
test('fetchPaginatedCollection follows cursor headers and merges pages', async () => {
const calls = [];
const pages = new Map([
['/api/nodes?limit=2', { items: [{ id: 'a' }, { id: 'b' }], next: 'cursor-1' }],
['/api/nodes?limit=2&cursor=cursor-1', { items: [{ id: 'c' }], next: null }],
]);
const fetchImpl = async (url) => {
calls.push(url);
const page = pages.get(url);
if (!page) {
throw new Error(`unexpected url ${url}`);
}
return {
ok: true,
headers: { get: (name) => (name === 'X-Next-Cursor' ? page.next : null) },
async json() {
return page.items;
},
};
};
const items = await fetchPaginatedCollection({
path: '/api/nodes',
limit: 2,
maxRows: 10,
fetchImpl,
});
assert.deepEqual(calls, ['/api/nodes?limit=2', '/api/nodes?limit=2&cursor=cursor-1']);
assert.deepEqual(items.map((item) => item.id), ['a', 'b', 'c']);
});
test('fetchPaginatedCollection returns empty list when path is missing', async () => {
const items = await fetchPaginatedCollection({
path: '',
limit: 10,
fetchImpl: async () => ({ ok: true, headers: { get: () => null }, json: async () => [] }),
});
assert.deepEqual(items, []);
});
test('fetchPaginatedCollection enforces maxRows and propagates params', async () => {
const calls = [];
const fetchImpl = async (url) => {
calls.push(url);
return {
ok: true,
headers: { get: () => (url.includes('cursor=') ? null : 'next-1') },
async json() {
return [{ id: 1 }, { id: 2 }, { id: 3 }];
},
};
};
const items = await fetchPaginatedCollection({
path: '/api/messages',
limit: 3,
maxRows: 4,
params: { since: '123', encrypted: 'true' },
fetchImpl,
});
assert.equal(calls[0], '/api/messages?limit=3&since=123&encrypted=true');
assert.equal(items.length, 4);
});
test('fetchPaginatedCollection throws on non-ok responses', async () => {
await assert.rejects(
fetchPaginatedCollection({
path: '/api/messages',
limit: 2,
fetchImpl: async () => ({ ok: false, status: 503, json: async () => [] }),
}),
/HTTP 503/
);
});
test('fetchPaginatedCollection throws on invalid payload shapes', async () => {
await assert.rejects(
fetchPaginatedCollection({
path: '/api/messages',
limit: 2,
fetchImpl: async () => ({ ok: true, headers: { get: () => null }, json: async () => ({}) }),
}),
/invalid paginated payload/
);
});
test('fetchPaginatedCollection ignores blank params and defaults invalid limits', async () => {
const calls = [];
const items = await fetchPaginatedCollection({
path: '/api/messages',
limit: 0,
maxRows: 0,
params: { since: ' ', encrypted: null, scope: 'recent' },
fetchImpl: async (url) => {
calls.push(url);
return {
ok: true,
headers: { get: () => null },
async json() {
return [{ id: 1 }];
},
};
},
});
assert.deepEqual(items, [{ id: 1 }]);
assert.equal(calls[0], '/api/messages?limit=200&scope=recent');
});
test('fetchPaginatedCollection stops when a page is empty even if cursor was present', async () => {
const calls = [];
const fetchImpl = async (url) => {
calls.push(url);
if (url === '/api/nodes?limit=2') {
return {
ok: true,
headers: { get: (name) => (name === 'X-Next-Cursor' ? 'cursor-1' : null) },
async json() {
return [{ id: 'a' }];
},
};
}
return {
ok: true,
headers: { get: () => null },
async json() {
return [];
},
};
};
const items = await fetchPaginatedCollection({
path: '/api/nodes',
limit: 2,
fetchImpl,
});
assert.deepEqual(items, [{ id: 'a' }]);
assert.deepEqual(calls, ['/api/nodes?limit=2', '/api/nodes?limit=2&cursor=cursor-1']);
});
@@ -154,12 +154,14 @@ test('additional format helpers provide table friendly output', () => {
channel_name: 'Primary',
node: { short_name: 'SRCE', role: 'ROUTER', node_id: '!src' },
},
{ text: ' GAA= ', encrypted: true, rx_time: 1_700_000_405 },
{ emoji: '😊', rx_time: 1_700_000_401 },
],
renderShortHtml,
nodeContext,
);
assert.equal(messagesHtml.includes('hello'), true);
assert.equal(messagesHtml.includes('GAA='), false);
assert.equal(messagesHtml.includes('😊'), true);
assert.match(messagesHtml, /\[\d{4}-\d{2}-\d{2} \d{2}:\d{2}\]\[868\]/);
assert.equal(messagesHtml.includes('[868]'), true);
+25 -42
View File
@@ -20,7 +20,7 @@ import { extractModemMetadata } from './node-modem-metadata.js';
* Highest channel index that should be represented within the tab view.
* @type {number}
*/
export const MAX_CHANNEL_INDEX = 9;
export const MAX_CHANNEL_INDEX = 255;
/**
* Discrete event types that can appear in the chat activity log.
@@ -245,28 +245,12 @@ export function buildChatTabModel({
modemPreset,
envFallbackLabel: primaryChannelEnvLabel
});
const nameBucketKey = safeIndex > 0 ? buildSecondaryNameBucketKey(labelInfo) : null;
const nameBucketKey = safeIndex > 0 ? buildSecondaryNameBucketKey(safeIndex, labelInfo) : null;
const primaryBucketKey = safeIndex === 0 && labelInfo.label !== '0' ? buildPrimaryBucketKey(labelInfo.label) : '0';
let bucketKey = safeIndex === 0 ? primaryBucketKey : nameBucketKey ?? String(safeIndex);
const bucketKey = safeIndex === 0 ? primaryBucketKey : nameBucketKey ?? String(safeIndex);
let bucket = channelBuckets.get(bucketKey);
if (!bucket && safeIndex > 0) {
const existingBucketKey = findExistingBucketKeyByIndex(channelBuckets, safeIndex);
if (existingBucketKey) {
bucketKey = existingBucketKey;
bucket = channelBuckets.get(existingBucketKey);
}
}
if (bucket && nameBucketKey && bucket.key !== nameBucketKey) {
channelBuckets.delete(bucket.key);
bucket.key = nameBucketKey;
bucket.id = buildChannelTabId(nameBucketKey);
channelBuckets.set(nameBucketKey, bucket);
bucketKey = nameBucketKey;
}
if (!bucket) {
bucket = {
key: bucketKey,
@@ -569,43 +553,42 @@ function buildPrimaryBucketKey(primaryChannelLabel) {
return '0';
}
function buildSecondaryNameBucketKey(labelInfo) {
function buildSecondaryNameBucketKey(index, labelInfo) {
const label = labelInfo?.label ?? null;
const priority = labelInfo?.priority ?? CHANNEL_LABEL_PRIORITY.INDEX;
if (priority !== CHANNEL_LABEL_PRIORITY.NAME || !label) {
if (!Number.isFinite(index) || index <= 0 || priority !== CHANNEL_LABEL_PRIORITY.NAME || !label) {
return null;
}
const trimmedLabel = label.trim().toLowerCase();
if (!trimmedLabel.length) {
return null;
}
return `secondary::${trimmedLabel}`;
}
function findExistingBucketKeyByIndex(channelBuckets, targetIndex) {
if (!channelBuckets || !Number.isFinite(targetIndex) || targetIndex <= 0) {
return null;
}
const normalizedTarget = Math.trunc(targetIndex);
for (const [key, bucket] of channelBuckets.entries()) {
if (!bucket || !Number.isFinite(bucket.index)) {
continue;
}
if (Math.trunc(bucket.index) !== normalizedTarget) {
continue;
}
if (bucket.index === 0) {
continue;
}
return key;
}
return null;
return `secondary-name::${trimmedLabel}`;
}
function buildChannelTabId(bucketKey) {
if (bucketKey === '0') {
return 'channel-0';
}
const secondaryNameParts = /^secondary-name::(.+)$/.exec(String(bucketKey));
if (secondaryNameParts) {
const secondaryLabelSlug = slugify(secondaryNameParts[1]);
const secondaryHash = hashChannelKey(bucketKey);
if (secondaryLabelSlug) {
return `channel-secondary-name-${secondaryLabelSlug}-${secondaryHash}`;
}
return `channel-secondary-name-${secondaryHash}`;
}
const secondaryParts = /^secondary::(\d+)::(.+)$/.exec(String(bucketKey));
if (secondaryParts) {
const secondaryIndex = secondaryParts[1];
const secondaryLabelSlug = slugify(secondaryParts[2]);
const secondaryHash = hashChannelKey(bucketKey);
if (secondaryLabelSlug) {
return `channel-secondary-${secondaryIndex}-${secondaryLabelSlug}-${secondaryHash}`;
}
return `channel-secondary-${secondaryIndex}-${secondaryHash}`;
}
const slug = slugify(bucketKey);
if (slug) {
if (slug !== '0') {
+54 -7
View File
@@ -80,6 +80,59 @@ function buildInstanceUrl(domain) {
return `https://${trimmed}`;
}
/**
* Read the next-page cursor token from response headers.
*
* @param {*} response Fetch response candidate.
* @returns {string|null} Cursor token when present.
*/
function readNextCursorHeader(response) {
const headers = response && response.headers;
if (!headers || typeof headers.get !== 'function') return null;
const cursor = headers.get('X-Next-Cursor');
return cursor && String(cursor).trim() ? String(cursor).trim() : null;
}
/**
* Fetch all federation instances using keyset cursor pagination.
*
* @param {Function} fetchImpl Fetch-compatible function.
* @returns {Promise<Array<Object>>} Combined instance rows.
*/
async function fetchAllInstances(fetchImpl) {
const results = [];
let cursor = null;
let pageCount = 0;
const limit = 500;
while (pageCount < 100) {
const query = new URLSearchParams({ limit: String(limit) });
if (cursor) {
query.set('cursor', cursor);
}
const response = await fetchImpl(`/api/instances?${query.toString()}`, {
headers: { Accept: 'application/json' },
credentials: 'omit'
});
if (!response || !response.ok || typeof response.json !== 'function') {
return results;
}
const payload = await response.json();
if (!Array.isArray(payload) || payload.length === 0) {
return results;
}
results.push(...payload);
cursor = readNextCursorHeader(response);
pageCount += 1;
if (!cursor) {
return results;
}
}
return results;
}
const NODE_COUNT_COLOR_STOPS = [
{ limit: 100, color: roleColors.CLIENT_HIDDEN },
{ limit: 200, color: roleColors.SENSOR },
@@ -524,13 +577,7 @@ export async function initializeFederationPage(options = {}) {
// Fetch instances data
let instances = [];
try {
const response = await fetchImpl('/api/instances', {
headers: { Accept: 'application/json' },
credentials: 'omit'
});
if (response.ok) {
instances = await response.json();
}
instances = await fetchAllInstances(fetchImpl);
} catch (err) {
console.warn('Failed to fetch federation instances', err);
}
+60 -21
View File
@@ -78,6 +78,64 @@ function updateFederationNavCount(options) {
});
}
/**
* Read the next-page cursor header from an HTTP response.
*
* @param {*} response Fetch response candidate.
* @returns {string|null} Cursor token when available.
*/
function readNextCursorHeader(response) {
const headers = response && response.headers;
if (!headers || typeof headers.get !== 'function') {
return null;
}
const cursor = headers.get('X-Next-Cursor');
return cursor && String(cursor).trim().length > 0 ? String(cursor).trim() : null;
}
/**
* Load federation instances across paginated API responses.
*
* @param {Function} fetchImpl Fetch-compatible function.
* @returns {Promise<Array<Object>>} Combined instance payload rows.
*/
async function fetchAllInstances(fetchImpl) {
const results = [];
let cursor = null;
let pageCount = 0;
const limit = 500;
while (pageCount < 100) {
const query = new URLSearchParams({ limit: String(limit) });
if (cursor) {
query.set('cursor', cursor);
}
const response = await fetchImpl(`/api/instances?${query.toString()}`, {
headers: { Accept: 'application/json' },
credentials: 'omit',
});
if (!response || typeof response.json !== 'function' || !response.ok) {
return results;
}
const payload = await response.json();
if (!Array.isArray(payload) || payload.length === 0) {
return results;
}
results.push(...payload);
cursor = readNextCursorHeader(response);
pageCount += 1;
if (!cursor) {
return results;
}
}
return results;
}
/**
* Construct a navigable URL for the provided instance domain.
*
@@ -179,30 +237,11 @@ export async function initializeInstanceSelector(options) {
return;
}
let response;
try {
response = await fetchImpl('/api/instances', {
headers: { Accept: 'application/json' },
credentials: 'omit',
});
} catch (error) {
console.warn('Failed to load federation instances', error);
return;
}
if (!response || typeof response.json !== 'function') {
return;
}
if (!response.ok) {
return;
}
let payload;
try {
payload = await response.json();
payload = await fetchAllInstances(fetchImpl);
} catch (error) {
console.warn('Invalid federation instances payload', error);
console.warn('Failed to load federation instances', error);
return;
}
+303 -37
View File
@@ -69,6 +69,221 @@ import {
roleRenderOrder,
} from './role-helpers.js';
/**
* Compute active-node counts from a local node array.
*
* @param {Array<Object>} nodes Node payloads.
* @param {number} nowSeconds Reference timestamp.
* @returns {{hour: number, day: number, week: number, month: number, sampled: boolean}} Local count snapshot.
*/
export function computeLocalActiveNodeStats(nodes, nowSeconds) {
const safeNodes = Array.isArray(nodes) ? nodes : [];
const referenceNow = Number.isFinite(nowSeconds) ? nowSeconds : Date.now() / 1000;
const windows = [
{ key: 'hour', secs: 3600 },
{ key: 'day', secs: 86_400 },
{ key: 'week', secs: 7 * 86_400 },
{ key: 'month', secs: 30 * 86_400 }
];
const counts = { sampled: true };
for (const window of windows) {
counts[window.key] = safeNodes.filter(node => {
const lastHeard = Number(node?.last_heard);
return Number.isFinite(lastHeard) && referenceNow - lastHeard <= window.secs;
}).length;
}
return counts;
}
/**
* Parse and validate the `/api/stats` payload.
*
* @param {*} payload Candidate JSON object from the stats endpoint.
* @returns {{hour: number, day: number, week: number, month: number, sampled: boolean}|null} Normalized stats or null.
*/
export function normaliseActiveNodeStatsPayload(payload) {
const activeNodes = payload && typeof payload === 'object' ? payload.active_nodes : null;
if (!activeNodes || typeof activeNodes !== 'object') {
return null;
}
const hour = Number(activeNodes.hour);
const day = Number(activeNodes.day);
const week = Number(activeNodes.week);
const month = Number(activeNodes.month);
if (![hour, day, week, month].every(Number.isFinite)) {
return null;
}
return {
hour: Math.max(0, Math.trunc(hour)),
day: Math.max(0, Math.trunc(day)),
week: Math.max(0, Math.trunc(week)),
month: Math.max(0, Math.trunc(month)),
sampled: Boolean(payload.sampled)
};
}
const ACTIVE_NODE_STATS_CACHE_TTL_MS = 30_000;
let activeNodeStatsCache = null;
let activeNodeStatsFetchPromise = null;
let activeNodeStatsFetchImpl = null;
/**
* Fetch active-node stats from the dedicated API endpoint with short-lived caching.
*
* @param {Function} fetchImpl Fetch implementation.
* @returns {Promise<{hour: number, day: number, week: number, month: number, sampled: boolean} | null>} Normalized stats or null.
*/
async function fetchRemoteActiveNodeStats(fetchImpl) {
const nowMs = Date.now();
if (activeNodeStatsCache?.fetchImpl === fetchImpl && activeNodeStatsCache.expiresAt > nowMs) {
return activeNodeStatsCache.stats;
}
if (activeNodeStatsFetchPromise && activeNodeStatsFetchImpl === fetchImpl) {
return activeNodeStatsFetchPromise;
}
activeNodeStatsFetchImpl = fetchImpl;
activeNodeStatsFetchPromise = (async () => {
const response = await fetchImpl('/api/stats', { cache: 'no-store' });
if (!response?.ok) {
throw new Error(`stats HTTP ${response?.status ?? 'unknown'}`);
}
const payload = await response.json();
const normalized = normaliseActiveNodeStatsPayload(payload);
if (!normalized) {
throw new Error('invalid stats payload');
}
activeNodeStatsCache = {
fetchImpl,
expiresAt: Date.now() + ACTIVE_NODE_STATS_CACHE_TTL_MS,
stats: normalized
};
return normalized;
})();
try {
return await activeNodeStatsFetchPromise;
} finally {
activeNodeStatsFetchPromise = null;
activeNodeStatsFetchImpl = null;
}
}
/**
* Fetch active-node stats from the dedicated API endpoint with local fallback.
*
* @param {{
* nodes: Array<Object>,
* nowSeconds: number,
* fetchImpl?: Function
* }} params Fetch parameters.
* @returns {Promise<{hour: number, day: number, week: number, month: number, sampled: boolean}>} Stats snapshot.
*/
export async function fetchActiveNodeStats({ nodes, nowSeconds, fetchImpl = fetch }) {
try {
const normalized = await fetchRemoteActiveNodeStats(fetchImpl);
if (normalized) return normalized;
throw new Error('invalid stats payload');
} catch (error) {
console.debug('Failed to fetch /api/stats; using local active-node counts.', error);
return computeLocalActiveNodeStats(nodes, nowSeconds);
}
}
/**
* Format the dashboard refresh-info sentence for active-node counts.
*
* @param {{channel: string, frequency: string, stats: {hour:number,day:number,week:number,month:number,sampled:boolean}}} params Formatting data.
* @returns {string} User-visible sentence for the dashboard header.
*/
export function formatActiveNodeStatsText({ channel, frequency, stats }) {
const parts = [
`${Number(stats?.hour) || 0}/hour`,
`${Number(stats?.day) || 0}/day`,
`${Number(stats?.week) || 0}/week`,
`${Number(stats?.month) || 0}/month`
];
const suffix = stats?.sampled ? ' (sampled)' : '';
return `${channel} (${frequency}) — active nodes: ${parts.join(', ')}${suffix}.`;
}
/**
* Parse the next-page cursor header from an API response.
*
* @param {*} response Fetch response candidate.
* @returns {string|null} Cursor token for the next page.
*/
export function readNextCursorHeader(response) {
const headers = response && response.headers;
if (!headers || typeof headers.get !== 'function') {
return null;
}
const cursor = headers.get('X-Next-Cursor');
return cursor && String(cursor).trim().length > 0 ? String(cursor).trim() : null;
}
/**
* Fetch an API collection endpoint using keyset cursor pagination.
*
* @param {{
* path: string,
* limit: number,
* maxRows?: number,
* params?: Record<string, string>,
* fetchImpl?: Function
* }} options Request options.
* @returns {Promise<Array<Object>>} Aggregated array of collection rows.
*/
export async function fetchPaginatedCollection({
path,
limit,
maxRows = 5000,
params = {},
fetchImpl = fetch
}) {
const safePath = typeof path === 'string' ? path : '';
if (!safePath) {
return [];
}
const safeLimit = Number.isFinite(limit) && limit > 0 ? Math.floor(limit) : 200;
const safeMaxRows = Number.isFinite(maxRows) && maxRows > 0 ? Math.floor(maxRows) : safeLimit;
const results = [];
let cursor = null;
let pageCount = 0;
while (results.length < safeMaxRows && pageCount < 100) {
const query = new URLSearchParams({ limit: String(safeLimit) });
Object.entries(params || {}).forEach(([key, value]) => {
if (value == null) return;
const text = String(value).trim();
if (!text) return;
query.set(key, text);
});
if (cursor) {
query.set('cursor', cursor);
}
const response = await fetchImpl(`${safePath}?${query.toString()}`, { cache: 'no-store' });
if (!response || !response.ok) {
throw new Error('HTTP ' + (response ? response.status : 'unknown'));
}
const payload = await response.json();
if (!Array.isArray(payload)) {
throw new Error('invalid paginated payload');
}
if (payload.length === 0) {
break;
}
results.push(...payload);
cursor = readNextCursorHeader(response);
pageCount += 1;
if (!cursor) {
break;
}
}
return results.slice(0, safeMaxRows);
}
/**
* Entry point for the interactive dashboard. Wires up event listeners,
* initializes the map, and triggers the first data refresh cycle.
@@ -198,6 +413,7 @@ export function initializeApp(config) {
const TRACE_MAX_AGE_SECONDS = 28 * 24 * 60 * 60;
const SNAPSHOT_LIMIT = SNAPSHOT_WINDOW;
const CHAT_LIMIT = MESSAGE_LIMIT;
const RECENT_COLLECTION_WINDOW_SECONDS = 7 * 24 * 60 * 60;
const CHAT_RECENT_WINDOW_SECONDS = 7 * 24 * 60 * 60;
const REFRESH_MS = config.refreshMs;
const CHAT_ENABLED = Boolean(config.chatEnabled);
@@ -222,6 +438,7 @@ export function initializeApp(config) {
/** @type {ReturnType<typeof setTimeout>|null} */
let refreshTimer = null;
let refreshInfoRequestId = 0;
/**
* Close any open short-info overlays that do not contain the provided anchor.
@@ -2910,6 +3127,14 @@ export function initializeApp(config) {
* @returns {HTMLElement} Chat log element.
*/
function createMessageChatEntry(m) {
let plainText = '';
if (m?.text != null) {
plainText = String(m.text).trim();
}
if (m?.encrypted && plainText === 'GAA=') {
return null;
}
const div = document.createElement('div');
const tsSeconds = resolveTimestampSeconds(
m.rx_time ?? m.rxTime,
@@ -3141,18 +3366,28 @@ export function initializeApp(config) {
}
const getDivider = createDateDividerFactory();
const limitedEntries = entries.slice(Math.max(entries.length - CHAT_LIMIT, 0));
let renderedEntries = 0;
for (const entry of limitedEntries) {
if (!entry || typeof entry.ts !== 'number') {
continue;
}
if (typeof renderEntry !== 'function') {
continue;
}
const node = renderEntry(entry);
if (!node) {
continue;
}
const divider = getDivider(entry.ts);
if (divider) fragment.appendChild(divider);
if (typeof renderEntry === 'function') {
const node = renderEntry(entry);
if (node) {
fragment.appendChild(node);
}
}
fragment.appendChild(node);
renderedEntries += 1;
}
if (renderedEntries === 0 && emptyLabel) {
const empty = document.createElement('p');
empty.className = 'chat-empty';
empty.textContent = emptyLabel;
fragment.appendChild(empty);
}
return fragment;
}
@@ -3448,9 +3683,14 @@ export function initializeApp(config) {
*/
async function fetchNodes(limit = NODE_LIMIT) {
const effectiveLimit = resolveSnapshotLimit(limit, NODE_LIMIT);
const r = await fetch(`/api/nodes?limit=${effectiveLimit}`, { cache: 'no-store' });
if (!r.ok) throw new Error('HTTP ' + r.status);
return r.json();
const maxRows = Math.max(effectiveLimit, effectiveLimit * SNAPSHOT_LIMIT);
const nowSec = Math.floor(Date.now() / 1000);
return fetchPaginatedCollection({
path: '/api/nodes',
limit: effectiveLimit,
maxRows,
params: { since: String(nowSec - RECENT_COLLECTION_WINDOW_SECONDS) }
});
}
/**
@@ -3479,14 +3719,19 @@ export function initializeApp(config) {
async function fetchMessages(limit = MESSAGE_LIMIT, options = {}) {
if (!CHAT_ENABLED) return [];
const safeLimit = normaliseMessageLimit(limit);
const params = new URLSearchParams({ limit: String(safeLimit) });
const nowSec = Math.floor(Date.now() / 1000);
const params = {};
if (options && options.encrypted) {
params.set('encrypted', 'true');
params.encrypted = 'true';
}
const query = params.toString();
const r = await fetch(`/api/messages?${query}`, { cache: 'no-store' });
if (!r.ok) throw new Error('HTTP ' + r.status);
return r.json();
params.since = String(nowSec - CHAT_RECENT_WINDOW_SECONDS);
const maxRows = Math.max(safeLimit, safeLimit * SNAPSHOT_LIMIT);
return fetchPaginatedCollection({
path: '/api/messages',
limit: safeLimit,
maxRows,
params
});
}
/**
@@ -3497,9 +3742,14 @@ export function initializeApp(config) {
*/
async function fetchNeighbors(limit = NODE_LIMIT) {
const effectiveLimit = resolveSnapshotLimit(limit, NODE_LIMIT);
const r = await fetch(`/api/neighbors?limit=${effectiveLimit}`, { cache: 'no-store' });
if (!r.ok) throw new Error('HTTP ' + r.status);
return r.json();
const maxRows = Math.max(effectiveLimit, effectiveLimit * SNAPSHOT_LIMIT);
const nowSec = Math.floor(Date.now() / 1000);
return fetchPaginatedCollection({
path: '/api/neighbors',
limit: effectiveLimit,
maxRows,
params: { since: String(nowSec - RECENT_COLLECTION_WINDOW_SECONDS) }
});
}
/**
@@ -3511,9 +3761,14 @@ export function initializeApp(config) {
async function fetchTraces(limit = TRACE_LIMIT) {
const safeLimit = Number.isFinite(limit) && limit > 0 ? Math.floor(limit) : TRACE_LIMIT;
const effectiveLimit = Math.min(safeLimit, NODE_LIMIT);
const r = await fetch(`/api/traces?limit=${effectiveLimit}`, { cache: 'no-store' });
if (!r.ok) throw new Error('HTTP ' + r.status);
const traces = await r.json();
const maxRows = Math.max(effectiveLimit, effectiveLimit * SNAPSHOT_LIMIT);
const nowSec = Math.floor(Date.now() / 1000);
const traces = await fetchPaginatedCollection({
path: '/api/traces',
limit: effectiveLimit,
maxRows,
params: { since: String(nowSec - TRACE_MAX_AGE_SECONDS) }
});
return filterRecentTraces(traces, TRACE_MAX_AGE_SECONDS);
}
@@ -3525,9 +3780,14 @@ export function initializeApp(config) {
*/
async function fetchTelemetry(limit = NODE_LIMIT) {
const effectiveLimit = resolveSnapshotLimit(limit, NODE_LIMIT);
const r = await fetch(`/api/telemetry?limit=${effectiveLimit}`, { cache: 'no-store' });
if (!r.ok) throw new Error('HTTP ' + r.status);
return r.json();
const maxRows = Math.max(effectiveLimit, effectiveLimit * SNAPSHOT_LIMIT);
const nowSec = Math.floor(Date.now() / 1000);
return fetchPaginatedCollection({
path: '/api/telemetry',
limit: effectiveLimit,
maxRows,
params: { since: String(nowSec - RECENT_COLLECTION_WINDOW_SECONDS) }
});
}
/**
@@ -3538,9 +3798,14 @@ export function initializeApp(config) {
*/
async function fetchPositions(limit = NODE_LIMIT) {
const effectiveLimit = resolveSnapshotLimit(limit, NODE_LIMIT);
const r = await fetch(`/api/positions?limit=${effectiveLimit}`, { cache: 'no-store' });
if (!r.ok) throw new Error('HTTP ' + r.status);
return r.json();
const maxRows = Math.max(effectiveLimit, effectiveLimit * SNAPSHOT_LIMIT);
const nowSec = Math.floor(Date.now() / 1000);
return fetchPaginatedCollection({
path: '/api/positions',
limit: effectiveLimit,
maxRows,
params: { since: String(nowSec - RECENT_COLLECTION_WINDOW_SECONDS) }
});
}
/**
@@ -4377,15 +4642,16 @@ export function initializeApp(config) {
if (!refreshInfo || !isDashboardView) {
return;
}
const windows = [
{ label: 'hour', secs: 3600 },
{ label: 'day', secs: 86400 },
{ label: 'week', secs: 7 * 86400 },
];
const counts = windows.map(w => {
const c = nodes.filter(n => n.last_heard && nowSec - Number(n.last_heard) <= w.secs).length;
return `${c}/${w.label}`;
}).join(', ');
refreshInfo.textContent = `${config.channel} (${config.frequency}) — active nodes: ${counts}.`;
const requestId = ++refreshInfoRequestId;
void fetchActiveNodeStats({ nodes, nowSeconds: nowSec }).then(stats => {
if (requestId !== refreshInfoRequestId) {
return;
}
refreshInfo.textContent = formatActiveNodeStatsText({
channel: config.channel,
frequency: config.frequency,
stats
});
});
}
}
+1
View File
@@ -2056,6 +2056,7 @@ function renderMessages(messages, renderShortHtml, node) {
if (!message || typeof message !== 'object') return null;
const text = stringOrNull(message.text) || stringOrNull(message.emoji);
if (!text) return null;
if (message.encrypted && String(text).trim() === 'GAA=') return null;
const timestamp = formatMessageTimestamp(message.rx_time, message.rx_iso);
const metadata = extractChatMessageMetadata(message);
+1001 -31
View File
File diff suppressed because it is too large Load Diff
+72
View File
@@ -239,6 +239,30 @@ RSpec.describe PotatoMesh::Config do
end
end
describe ".remote_instance_request_timeout" do
it "returns the baked-in request timeout when unset" do
within_env("REMOTE_INSTANCE_REQUEST_TIMEOUT" => nil) do
expect(described_class.remote_instance_request_timeout).to eq(
PotatoMesh::Config::DEFAULT_REMOTE_INSTANCE_REQUEST_TIMEOUT,
)
end
end
it "accepts positive overrides" do
within_env("REMOTE_INSTANCE_REQUEST_TIMEOUT" => "19") do
expect(described_class.remote_instance_request_timeout).to eq(19)
end
end
it "rejects invalid overrides" do
within_env("REMOTE_INSTANCE_REQUEST_TIMEOUT" => "0") do
expect(described_class.remote_instance_request_timeout).to eq(
PotatoMesh::Config::DEFAULT_REMOTE_INSTANCE_REQUEST_TIMEOUT,
)
end
end
end
describe ".federation_max_instances_per_response" do
it "returns the baked-in response limit when unset" do
within_env("FEDERATION_MAX_INSTANCES_PER_RESPONSE" => nil) do
@@ -359,6 +383,54 @@ RSpec.describe PotatoMesh::Config do
end
end
describe ".federation_shutdown_timeout_seconds" do
it "returns the default shutdown timeout when unset" do
within_env("FEDERATION_SHUTDOWN_TIMEOUT" => nil) do
expect(described_class.federation_shutdown_timeout_seconds).to eq(
PotatoMesh::Config::DEFAULT_FEDERATION_SHUTDOWN_TIMEOUT_SECONDS,
)
end
end
it "accepts positive overrides" do
within_env("FEDERATION_SHUTDOWN_TIMEOUT" => "9") do
expect(described_class.federation_shutdown_timeout_seconds).to eq(9)
end
end
it "rejects invalid overrides" do
within_env("FEDERATION_SHUTDOWN_TIMEOUT" => "-1") do
expect(described_class.federation_shutdown_timeout_seconds).to eq(
PotatoMesh::Config::DEFAULT_FEDERATION_SHUTDOWN_TIMEOUT_SECONDS,
)
end
end
end
describe ".federation_crawl_cooldown_seconds" do
it "returns the default crawl cooldown when unset" do
within_env("FEDERATION_CRAWL_COOLDOWN" => nil) do
expect(described_class.federation_crawl_cooldown_seconds).to eq(
PotatoMesh::Config::DEFAULT_FEDERATION_CRAWL_COOLDOWN_SECONDS,
)
end
end
it "accepts positive overrides" do
within_env("FEDERATION_CRAWL_COOLDOWN" => "17") do
expect(described_class.federation_crawl_cooldown_seconds).to eq(17)
end
end
it "rejects invalid overrides" do
within_env("FEDERATION_CRAWL_COOLDOWN" => "0") do
expect(described_class.federation_crawl_cooldown_seconds).to eq(
PotatoMesh::Config::DEFAULT_FEDERATION_CRAWL_COOLDOWN_SECONDS,
)
end
end
end
describe ".db_path" do
it "returns the default path inside the data directory" do
expect(described_class.db_path).to eq(described_class.default_db_path)
+59 -14
View File
@@ -166,20 +166,6 @@ RSpec.describe PotatoMesh::App::Database do
expect(telemetry_columns).to include("rx_time", "battery_level")
end
it "adds decryption metadata columns to existing messages tables" do
SQLite3::Database.new(PotatoMesh::Config.db_path) do |db|
db.execute("CREATE TABLE nodes(node_id TEXT)")
db.execute("CREATE TABLE messages(id INTEGER PRIMARY KEY)")
end
expect(column_names_for("messages")).not_to include("decrypted", "decryption_confidence")
harness_class.ensure_schema_upgrades
message_columns = column_names_for("messages")
expect(message_columns).to include("decrypted", "decryption_confidence")
end
it "creates trace tables when absent" do
SQLite3::Database.new(PotatoMesh::Config.db_path) do |db|
db.execute("CREATE TABLE nodes(node_id TEXT)")
@@ -198,6 +184,65 @@ RSpec.describe PotatoMesh::App::Database do
expect(hop_columns).to include("trace_id", "hop_index", "node_id")
end
it "creates positions and neighbors tables when absent" do
SQLite3::Database.new(PotatoMesh::Config.db_path) do |db|
db.execute("CREATE TABLE nodes(node_id TEXT)")
db.execute("CREATE TABLE messages(id INTEGER PRIMARY KEY)")
db.execute("CREATE TABLE telemetry(id INTEGER PRIMARY KEY, rx_time INTEGER, rx_iso TEXT)")
end
expect(column_names_for("positions")).to be_empty
expect(column_names_for("neighbors")).to be_empty
harness_class.ensure_schema_upgrades
positions_columns = column_names_for("positions")
expect(positions_columns).to include("id", "node_id", "rx_time", "ingestor")
neighbors_columns = column_names_for("neighbors")
expect(neighbors_columns).to include("node_id", "neighbor_id", "rx_time", "ingestor")
end
it "adds ingestor columns to legacy positions neighbors and traces tables" do
SQLite3::Database.new(PotatoMesh::Config.db_path) do |db|
db.execute("CREATE TABLE nodes(node_id TEXT)")
db.execute("CREATE TABLE messages(id INTEGER PRIMARY KEY)")
db.execute("CREATE TABLE telemetry(id INTEGER PRIMARY KEY, rx_time INTEGER, rx_iso TEXT)")
db.execute <<~SQL
CREATE TABLE positions (
id INTEGER PRIMARY KEY,
rx_time INTEGER,
rx_iso TEXT,
node_id TEXT
)
SQL
db.execute <<~SQL
CREATE TABLE neighbors (
node_id TEXT,
neighbor_id TEXT,
rx_time INTEGER
)
SQL
db.execute <<~SQL
CREATE TABLE traces (
id INTEGER PRIMARY KEY,
request_id INTEGER,
src TEXT,
dest TEXT,
rx_time INTEGER,
rx_iso TEXT
)
SQL
db.execute("CREATE TABLE trace_hops(trace_id INTEGER, hop_index INTEGER, node_id TEXT)")
end
harness_class.ensure_schema_upgrades
expect(column_names_for("positions")).to include("ingestor")
expect(column_names_for("neighbors")).to include("ingestor")
expect(column_names_for("traces")).to include("ingestor")
end
it "adds the contact_link column to existing instances tables" do
SQLite3::Database.new(PotatoMesh::Config.db_path) do |db|
db.execute("CREATE TABLE nodes(node_id TEXT)")
+589 -26
View File
@@ -23,6 +23,11 @@ require "uri"
require "socket"
RSpec.describe PotatoMesh::App::Federation do
NODES_API_PATH = "/api/nodes".freeze
STATS_API_PATH = "/api/stats".freeze
FULL_DATA_UNAVAILABLE_REASON = "full data unavailable".freeze
HTTP_CONNECTION_DOUBLE = "Net::HTTPConnection".freeze
subject(:federation_helpers) do
Class.new do
extend PotatoMesh::App::Federation
@@ -57,6 +62,8 @@ RSpec.describe PotatoMesh::App::Federation do
:federation_thread,
:initial_federation_thread,
:federation_worker_pool,
:federation_shutdown_requested,
:federation_shutdown_hook_installed,
).new
end
@@ -77,10 +84,12 @@ RSpec.describe PotatoMesh::App::Federation do
federation_helpers.instance_variable_set(:@remote_instance_verify_callback, nil)
federation_helpers.reset_debug_messages
federation_helpers.reset_warn_messages
federation_helpers.clear_federation_crawl_state!
federation_helpers.shutdown_federation_worker_pool!
end
after do
federation_helpers.clear_federation_crawl_state!
federation_helpers.shutdown_federation_worker_pool!
end
@@ -270,7 +279,7 @@ RSpec.describe PotatoMesh::App::Federation do
let(:response_map) do
mapping = { [seed_domain, "/api/instances"] => [payload_entries, :instances] }
attributes_list.each do |attributes|
mapping[[attributes[:domain], "/api/nodes"]] = [node_payload, :nodes]
mapping[[attributes[:domain], NODES_API_PATH]] = [node_payload, :nodes]
mapping[[attributes[:domain], "/api/instances"]] = [[], :instances]
end
mapping
@@ -287,6 +296,37 @@ RSpec.describe PotatoMesh::App::Federation do
end
end
def configure_remote_node_window(now)
allow(Time).to receive(:now).and_return(now)
allow(PotatoMesh::Config).to receive(:remote_instance_max_node_age).and_return(900)
end
def stats_mapping(now:, stats_response:, full_nodes_response:, window_nodes_response: nil)
recent_cutoff = now.to_i - 900
mapping = { [seed_domain, "/api/instances"] => [payload_entries, :instances] }
attributes_list.each do |attributes|
mapping[[attributes[:domain], STATS_API_PATH]] = stats_response
mapping[[attributes[:domain], NODES_API_PATH]] = full_nodes_response
mapping[[attributes[:domain], "/api/instances"]] = [[], :instances]
next unless window_nodes_response
mapping[[attributes[:domain], "/api/nodes?since=#{recent_cutoff}&limit=1000"]] = window_nodes_response
end
mapping
end
def stub_ingest_fetches(mapping, capture_paths: false)
captured_paths = []
allow(federation_helpers).to receive(:fetch_instance_json) do |host, path|
captured_paths << [host, path] if capture_paths
mapping.fetch([host, path]) { [nil, []] }
end
allow(federation_helpers).to receive(:verify_instance_signature).and_return(true)
allow(federation_helpers).to receive(:validate_remote_nodes).and_return([true, nil])
allow(federation_helpers).to receive(:upsert_instance_record)
captured_paths
end
it "stops processing once the per-response limit is exceeded" do
processed_domains = []
allow(federation_helpers).to receive(:upsert_instance_record) do |_db, attrs, _signature|
@@ -322,38 +362,163 @@ RSpec.describe PotatoMesh::App::Federation do
expect(federation_helpers.debug_messages).to include(a_string_including("crawl limit"))
end
it "requests an expanded recent node window when counting remote activity" do
it "prefers /api/stats when counting remote activity" do
now = Time.at(1_700_000_000)
allow(Time).to receive(:now).and_return(now)
allow(PotatoMesh::Config).to receive(:remote_instance_max_node_age).and_return(900)
recent_cutoff = now.to_i - 900
configure_remote_node_window(now)
mapping = { [seed_domain, "/api/instances"] => [payload_entries, :instances] }
attributes_list.each_with_index do |attributes, index|
mapping[[attributes[:domain], "/api/nodes?since=#{recent_cutoff}&limit=1000"]] = [node_payload, :nodes]
mapping[[attributes[:domain], "/api/nodes"]] = [node_payload, :nodes]
mapping[[attributes[:domain], "/api/instances"]] = [[], :instances]
allow(federation_helpers).to receive(:remote_instance_attributes_from_payload).with(payload_entries[index]).and_return([attributes, "signature-#{index}", nil])
end
captured_paths = []
allow(federation_helpers).to receive(:fetch_instance_json) do |host, path|
captured_paths << [host, path]
mapping.fetch([host, path]) { [nil, []] }
end
allow(federation_helpers).to receive(:verify_instance_signature).and_return(true)
allow(federation_helpers).to receive(:validate_remote_nodes).and_return([true, nil])
allow(federation_helpers).to receive(:upsert_instance_record)
mapping = stats_mapping(
now:,
stats_response: [{ "active_nodes" => { "hour" => 5, "day" => 7, "week" => 9, "month" => 11 }, "sampled" => false }, :stats],
full_nodes_response: [node_payload, :nodes],
)
captured_paths = stub_ingest_fetches(mapping, capture_paths: true)
federation_helpers.ingest_known_instances_from!(db, seed_domain)
expect(captured_paths).to include(
[attributes_list[0][:domain], "/api/nodes?since=#{recent_cutoff}&limit=1000"],
[attributes_list[1][:domain], "/api/nodes?since=#{recent_cutoff}&limit=1000"],
[attributes_list[2][:domain], "/api/nodes?since=#{recent_cutoff}&limit=1000"],
[attributes_list[0][:domain], STATS_API_PATH],
[attributes_list[1][:domain], STATS_API_PATH],
[attributes_list[2][:domain], STATS_API_PATH],
)
expect(captured_paths).to include(
[attributes_list[0][:domain], NODES_API_PATH],
[attributes_list[1][:domain], NODES_API_PATH],
[attributes_list[2][:domain], NODES_API_PATH],
)
expect(attributes_list.map { |attrs| attrs[:nodes_count] }).to all(eq(5))
end
it "prefers recent node window counts when /api/stats is unavailable" do
now = Time.at(1_700_000_000)
configure_remote_node_window(now)
full_nodes_payload = node_payload.take(2)
recent_window_payload = node_payload
recent_path = "/api/nodes?since=#{now.to_i - 900}&limit=1000"
mapping = stats_mapping(
now:,
stats_response: [nil, ["stats unavailable"]],
full_nodes_response: [full_nodes_payload, :nodes],
window_nodes_response: [recent_window_payload, :nodes],
)
captured_paths = stub_ingest_fetches(mapping, capture_paths: true)
federation_helpers.ingest_known_instances_from!(db, seed_domain)
expect(captured_paths).to include(
[attributes_list[0][:domain], STATS_API_PATH],
[attributes_list[1][:domain], STATS_API_PATH],
[attributes_list[2][:domain], STATS_API_PATH],
)
expect(captured_paths).to include(
[attributes_list[0][:domain], NODES_API_PATH],
[attributes_list[1][:domain], NODES_API_PATH],
[attributes_list[2][:domain], NODES_API_PATH],
)
expect(captured_paths).to include(
[attributes_list[0][:domain], recent_path],
[attributes_list[1][:domain], recent_path],
[attributes_list[2][:domain], recent_path],
)
expect(attributes_list.map { |attrs| attrs[:nodes_count] }).to all(eq(recent_window_payload.length))
end
it "falls back to recent node window when full node data is unavailable" do
now = Time.at(1_700_000_000)
configure_remote_node_window(now)
mapping = stats_mapping(
now:,
stats_response: [nil, ["stats unavailable"]],
full_nodes_response: [nil, [FULL_DATA_UNAVAILABLE_REASON]],
window_nodes_response: [node_payload, :nodes],
)
stub_ingest_fetches(mapping)
federation_helpers.ingest_known_instances_from!(db, seed_domain)
expect(attributes_list.map { |attrs| attrs[:nodes_count] }).to all(eq(node_payload.length))
end
it "uses recent node window fallback when stats succeed but full node data is unavailable" do
now = Time.at(1_700_000_000)
configure_remote_node_window(now)
recent_path = "/api/nodes?since=#{now.to_i - 900}&limit=1000"
mapping = stats_mapping(
now:,
stats_response: [{ "active_nodes" => { "hour" => 9, "day" => 10, "week" => 11, "month" => 12 }, "sampled" => false }, :stats],
full_nodes_response: [nil, [FULL_DATA_UNAVAILABLE_REASON]],
window_nodes_response: [node_payload, :nodes],
)
captured_paths = stub_ingest_fetches(mapping, capture_paths: true)
federation_helpers.ingest_known_instances_from!(db, seed_domain)
expect(captured_paths).to include(
[attributes_list[0][:domain], STATS_API_PATH],
[attributes_list[1][:domain], STATS_API_PATH],
[attributes_list[2][:domain], STATS_API_PATH],
)
expect(captured_paths).to include(
[attributes_list[0][:domain], recent_path],
[attributes_list[1][:domain], recent_path],
[attributes_list[2][:domain], recent_path],
)
expect(attributes_list.map { |attrs| attrs[:nodes_count] }).to all(eq(9))
end
it "handles URI metadata from malformed /api/stats payloads without crashing" do
now = Time.at(1_700_000_000)
configure_remote_node_window(now)
mapping = stats_mapping(
now:,
stats_response: [{ "unexpected" => "shape" }, URI.parse("https://ally-0.mesh/api/stats")],
full_nodes_response: [node_payload.take(2), :nodes],
window_nodes_response: [node_payload, :nodes],
)
stub_ingest_fetches(mapping)
expect do
federation_helpers.ingest_known_instances_from!(db, seed_domain)
end.not_to raise_error
expect(attributes_list.map { |attrs| attrs[:nodes_count] }).to all(eq(node_payload.length))
end
it "skips remote entries when both full and window node feeds are unavailable" do
now = Time.at(1_700_000_000)
configure_remote_node_window(now)
recent_path = "/api/nodes?since=#{now.to_i - 900}&limit=1000"
mapping = stats_mapping(
now:,
stats_response: [{ "active_nodes" => { "hour" => 3, "day" => 3, "week" => 3, "month" => 3 }, "sampled" => false }, :stats],
full_nodes_response: [nil, [FULL_DATA_UNAVAILABLE_REASON]],
window_nodes_response: [nil, ["window unavailable"]],
)
captured_paths = stub_ingest_fetches(mapping, capture_paths: true)
upserted = []
allow(federation_helpers).to receive(:upsert_instance_record) do |_db, attrs, _signature|
upserted << attrs
end
federation_helpers.ingest_known_instances_from!(db, seed_domain)
expect(captured_paths).to include(
[attributes_list[0][:domain], NODES_API_PATH],
[attributes_list[1][:domain], NODES_API_PATH],
[attributes_list[2][:domain], NODES_API_PATH],
)
expect(captured_paths).to include(
[attributes_list[0][:domain], recent_path],
[attributes_list[1][:domain], recent_path],
[attributes_list[2][:domain], recent_path],
)
expect(upserted).to be_empty
expect(federation_helpers.warn_messages).to include("Failed to load remote node data")
expect(attributes_list.map { |attrs| attrs[:nodes_count] }).to all(eq(3))
end
end
describe ".upsert_instance_record" do
@@ -549,7 +714,7 @@ RSpec.describe PotatoMesh::App::Federation do
end
it "applies federation headers to instance fetch requests" do
connection = instance_double("Net::HTTPConnection")
connection = instance_double(HTTP_CONNECTION_DOUBLE)
success_response = Net::HTTPOK.new("1.1", "200", "OK")
allow(success_response).to receive(:body).and_return("{}")
allow(success_response).to receive(:code).and_return("200")
@@ -571,13 +736,56 @@ RSpec.describe PotatoMesh::App::Federation do
expect(captured_request["User-Agent"]).to eq(federation_helpers.send(:federation_user_agent_header))
expect(captured_request["Content-Type"]).to be_nil
end
it "wraps non-success HTTP responses" do
connection = instance_double(HTTP_CONNECTION_DOUBLE)
failure_response = Net::HTTPBadGateway.new("1.1", "502", "Bad Gateway")
allow(failure_response).to receive(:code).and_return("502")
allow(http_client).to receive(:start) do |&block|
block.call(connection)
end
allow(connection).to receive(:request).and_return(failure_response)
expect do
federation_helpers.send(:perform_instance_http_request, uri)
end.to raise_error(
PotatoMesh::App::InstanceFetchError,
a_string_including("unexpected response 502"),
)
end
end
describe ".federation_sleep_with_shutdown" do
it "returns false when shutdown is requested during sleep" do
allow(Kernel).to receive(:sleep)
call_count = 0
allow(federation_helpers).to receive(:federation_shutdown_requested?) do
call_count += 1
call_count > 1
end
result = federation_helpers.federation_sleep_with_shutdown(1.0)
expect(result).to be(false)
expect(Kernel).to have_received(:sleep).at_least(:once)
end
it "returns true when the full delay elapses without shutdown" do
allow(Kernel).to receive(:sleep)
allow(federation_helpers).to receive(:federation_shutdown_requested?).and_return(false)
result = federation_helpers.federation_sleep_with_shutdown(0.01)
expect(result).to be(true)
end
end
describe ".announce_instance_to_domain" do
let(:payload) { "{}" }
let(:https_uri) { URI.parse("https://remote.mesh/api/instances") }
let(:http_uri) { URI.parse("http://remote.mesh/api/instances") }
let(:http_connection) { instance_double("Net::HTTPConnection") }
let(:http_connection) { instance_double(HTTP_CONNECTION_DOUBLE) }
let(:success_response) { Net::HTTPOK.new("1.1", "200", "OK") }
before do
@@ -655,6 +863,14 @@ RSpec.describe PotatoMesh::App::Federation do
expect(federation_helpers.ensure_federation_worker_pool!).to be_nil
end
it "returns nil when federation shutdown has been requested" do
allow(federation_helpers).to receive(:federation_enabled?).and_return(true)
federation_helpers.request_federation_shutdown!
expect(federation_helpers.ensure_federation_worker_pool!).to be_nil
expect(federation_helpers.send(:settings).federation_worker_pool).to be_nil
end
it "creates and memoizes the worker pool" do
allow(federation_helpers).to receive(:federation_enabled?).and_return(true)
@@ -667,6 +883,69 @@ RSpec.describe PotatoMesh::App::Federation do
end
end
describe ".ensure_federation_shutdown_hook!" do
it "registers a single at_exit hook when called repeatedly" do
allow(federation_helpers).to receive(:at_exit)
federation_helpers.ensure_federation_shutdown_hook!
federation_helpers.ensure_federation_shutdown_hook!
expect(federation_helpers).to have_received(:at_exit).once
expect(federation_helpers.send(:settings).federation_shutdown_hook_installed).to be(true)
end
it "delegates hook installation from instances to the application class" do
class_with_instance = Class.new do
include PotatoMesh::App::Federation
end
expect(class_with_instance).to receive(:ensure_federation_shutdown_hook!).once
class_with_instance.new.ensure_federation_shutdown_hook!
end
it "uses ivar guard when hook-installed setting is unavailable" do
helper_without_hook_setting = Class.new do
extend PotatoMesh::App::Federation
class << self
def settings
@settings ||= Struct.new(:federation_thread, :initial_federation_thread, :federation_worker_pool, :federation_shutdown_requested).new
end
# No-op in this helper because tests only assert hook registration behavior.
def shutdown_federation_background_work!(timeout: nil); end
end
end
allow(helper_without_hook_setting).to receive(:at_exit)
helper_without_hook_setting.ensure_federation_shutdown_hook!
helper_without_hook_setting.ensure_federation_shutdown_hook!
expect(helper_without_hook_setting).to have_received(:at_exit).once
expect(
helper_without_hook_setting.instance_variable_get(:@federation_shutdown_hook_installed),
).to be(true)
end
end
describe ".stop_federation_thread!" do
it "wakes, joins, and kills a stubborn live thread" do
thread = instance_double(Thread)
allow(thread).to receive(:alive?).and_return(true, true, false)
allow(thread).to receive(:respond_to?).with(:wakeup).and_return(true)
allow(thread).to receive(:wakeup).and_raise(ThreadError, "not asleep")
allow(thread).to receive(:join)
allow(thread).to receive(:kill)
federation_helpers.set(:federation_thread, thread)
federation_helpers.stop_federation_thread!(:federation_thread, timeout: 0.01)
expect(thread).to have_received(:join).with(0.01)
expect(thread).to have_received(:kill)
expect(federation_helpers.send(:settings).federation_thread).to be_nil
end
end
describe ".shutdown_federation_worker_pool!" do
it "logs an error when shutdown fails" do
pool = instance_double(PotatoMesh::App::WorkerPool)
@@ -683,6 +962,10 @@ RSpec.describe PotatoMesh::App::Federation do
describe ".enqueue_federation_crawl" do
let(:pool) { instance_double(PotatoMesh::App::WorkerPool) }
before do
allow(PotatoMesh::Config).to receive(:federation_crawl_cooldown_seconds).and_return(300)
end
it "returns false and logs when the pool is unavailable" do
allow(federation_helpers).to receive(:federation_worker_pool).and_return(nil)
@@ -696,6 +979,17 @@ RSpec.describe PotatoMesh::App::Federation do
expect(federation_helpers.debug_messages.last).to include("Skipped remote instance crawl")
end
it "returns false and logs when the domain is invalid" do
result = federation_helpers.enqueue_federation_crawl(
"https://bad domain",
per_response_limit: 5,
overall_limit: 9,
)
expect(result).to be(false)
expect(federation_helpers.warn_messages.last).to include("Skipped remote instance crawl")
end
it "schedules ingestion work on the pool" do
allow(federation_helpers).to receive(:federation_worker_pool).and_return(pool)
db = instance_double(SQLite3::Database)
@@ -746,6 +1040,29 @@ RSpec.describe PotatoMesh::App::Federation do
expect(result).to be(false)
end
it "does not apply cooldown when scheduling fails due to queue saturation" do
allow(PotatoMesh::Config).to receive(:federation_crawl_cooldown_seconds).and_return(300)
allow(federation_helpers).to receive(:federation_worker_pool).and_return(pool)
allow(pool).to receive(:schedule).and_raise(PotatoMesh::App::WorkerPool::QueueFullError, "full")
first = federation_helpers.enqueue_federation_crawl(
"remote.mesh",
per_response_limit: 1,
overall_limit: 2,
)
second = federation_helpers.enqueue_federation_crawl(
"remote.mesh",
per_response_limit: 1,
overall_limit: 2,
)
expect(first).to be(false)
expect(second).to be(false)
expect(federation_helpers.debug_messages).not_to include(
a_string_including("recent crawl completed"),
)
end
it "logs when the worker pool is shutting down" do
allow(federation_helpers).to receive(:federation_worker_pool).and_return(pool)
allow(pool).to receive(:schedule).and_raise(PotatoMesh::App::WorkerPool::ShutdownError, "closed")
@@ -766,6 +1083,224 @@ RSpec.describe PotatoMesh::App::Federation do
expect(result).to be(false)
end
it "deduplicates crawls while a domain crawl is already in flight" do
db = instance_double(SQLite3::Database)
allow(db).to receive(:close)
captured_job = nil
allow(federation_helpers).to receive(:federation_worker_pool).and_return(pool)
allow(pool).to receive(:schedule) do |&block|
captured_job = block
instance_double(PotatoMesh::App::WorkerPool::Task)
end
allow(federation_helpers).to receive(:open_database).and_return(db)
allow(federation_helpers).to receive(:ingest_known_instances_from!)
first = federation_helpers.enqueue_federation_crawl(
"remote.mesh",
per_response_limit: 5,
overall_limit: 9,
)
second = federation_helpers.enqueue_federation_crawl(
"remote.mesh",
per_response_limit: 5,
overall_limit: 9,
)
expect(first).to be(true)
expect(second).to be(false)
expect(captured_job).not_to be_nil
captured_job.call
expect(db).to have_received(:close)
end
it "releases the crawl slot when opening the database fails" do
allow(federation_helpers).to receive(:federation_crawl_cooldown_seconds).and_return(0)
captured_job = nil
allow(federation_helpers).to receive(:federation_worker_pool).and_return(pool)
allow(pool).to receive(:schedule) do |&block|
captured_job = block
instance_double(PotatoMesh::App::WorkerPool::Task)
end
allow(federation_helpers).to receive(:open_database).and_raise(SQLite3::Exception, "db unavailable")
allow(federation_helpers).to receive(:ingest_known_instances_from!)
first = federation_helpers.enqueue_federation_crawl(
"remote.mesh",
per_response_limit: 5,
overall_limit: 9,
)
expect(first).to be(true)
expect(captured_job).not_to be_nil
expect { captured_job.call }.to raise_error(SQLite3::Exception, "db unavailable")
second = federation_helpers.enqueue_federation_crawl(
"remote.mesh",
per_response_limit: 5,
overall_limit: 9,
)
expect(second).to be(true)
end
it "deduplicates crawls across instance receivers using shared class state" do
helper_class = Class.new do
include PotatoMesh::App::Federation
class << self
attr_accessor :pool
def settings
@settings ||= Struct.new(:federation_shutdown_requested).new(false)
end
def set(key, value)
settings.public_send("#{key}=", value)
end
def federation_worker_pool
pool
end
# No-op to keep the test helper minimal while satisfying federation logging calls.
def debug_log(*); end
# No-op to keep the test helper minimal while satisfying federation logging calls.
def warn_log(*); end
end
def settings
self.class.settings
end
def set(key, value)
self.class.set(key, value)
end
def debug_log(...)
self.class.debug_log(...)
end
def warn_log(...)
self.class.warn_log(...)
end
end
pool_double = instance_double(PotatoMesh::App::WorkerPool)
allow(pool_double).to receive(:schedule).and_return(instance_double(PotatoMesh::App::WorkerPool::Task))
helper_class.pool = pool_double
first_receiver = helper_class.new
second_receiver = helper_class.new
first = first_receiver.enqueue_federation_crawl(
"remote.mesh",
per_response_limit: 1,
overall_limit: 2,
)
second = second_receiver.enqueue_federation_crawl(
"remote.mesh",
per_response_limit: 1,
overall_limit: 2,
)
expect(first).to be(true)
expect(second).to be(false)
expect(pool_double).to have_received(:schedule).once
end
end
describe ".fetch_instance_json" do
it "short-circuits when shutdown has been requested" do
federation_helpers.request_federation_shutdown!
payload, metadata = federation_helpers.fetch_instance_json("remote.mesh", NODES_API_PATH)
expect(payload).to be_nil
expect(metadata).to eq(["federation shutdown requested"])
end
it "stops iterating URI candidates after shutdown is requested mid-loop" do
calls = 0
allow(federation_helpers).to receive(:instance_uri_candidates).and_return([
URI.parse("https://remote.mesh/api/nodes"),
URI.parse("http://remote.mesh/api/nodes"),
])
allow(federation_helpers).to receive(:perform_instance_http_request) do |_uri|
calls += 1
federation_helpers.request_federation_shutdown!
raise PotatoMesh::App::InstanceFetchError, "boom"
end
payload, metadata = federation_helpers.fetch_instance_json("remote.mesh", NODES_API_PATH)
expect(payload).to be_nil
expect(calls).to eq(1)
expect(metadata.first).to include("boom")
end
end
describe ".claim_federation_crawl_slot" do
it "initializes crawl dedupe state safely under concurrent access" do
federation_helpers.instance_variable_set(:@federation_crawl_mutex, nil)
federation_helpers.instance_variable_set(:@federation_crawl_in_flight, nil)
federation_helpers.instance_variable_set(:@federation_crawl_last_completed_at, nil)
federation_helpers.instance_variable_set(:@federation_crawl_init_mutex, nil)
threads = Array.new(12) do
Thread.new do
federation_helpers.initialize_federation_crawl_state!
end
end
threads.each(&:join)
mutex = federation_helpers.instance_variable_get(:@federation_crawl_mutex)
in_flight = federation_helpers.instance_variable_get(:@federation_crawl_in_flight)
last_completed = federation_helpers.instance_variable_get(:@federation_crawl_last_completed_at)
expect(mutex).to be_a(Mutex)
expect(in_flight).to be_a(Set)
expect(last_completed).to be_a(Hash)
expect(in_flight).to be_empty
expect(last_completed).to be_empty
end
it "returns cooldown when the domain completed recently" do
allow(PotatoMesh::Config).to receive(:federation_crawl_cooldown_seconds).and_return(300)
federation_helpers.clear_federation_crawl_state!
federation_helpers.release_federation_crawl_slot("remote.mesh")
result = federation_helpers.claim_federation_crawl_slot("remote.mesh")
expect(result).to eq(:cooldown)
end
end
describe ".shutdown_federation_background_work!" do
it "marks shutdown and clears announcer references" do
initial_thread = instance_double(Thread)
recurring_thread = instance_double(Thread)
pool = instance_double(PotatoMesh::App::WorkerPool)
allow(PotatoMesh::Config).to receive(:federation_shutdown_timeout_seconds).and_return(0.05)
allow(PotatoMesh::Config).to receive(:federation_task_timeout_seconds).and_return(0.05)
[initial_thread, recurring_thread].each do |thread|
allow(thread).to receive(:alive?).and_return(false)
end
allow(pool).to receive(:shutdown)
federation_helpers.set(:initial_federation_thread, initial_thread)
federation_helpers.set(:federation_thread, recurring_thread)
federation_helpers.set(:federation_worker_pool, pool)
federation_helpers.shutdown_federation_background_work!
expect(federation_helpers.federation_shutdown_requested?).to be(true)
expect(federation_helpers.send(:settings).initial_federation_thread).to be_nil
expect(federation_helpers.send(:settings).federation_thread).to be_nil
expect(federation_helpers.send(:settings).federation_worker_pool).to be_nil
end
end
describe ".wait_for_federation_tasks" do
@@ -836,4 +1371,32 @@ RSpec.describe PotatoMesh::App::Federation do
federation_helpers.announce_instance_to_all_domains
end
end
describe ".start_federation_announcer!" do
it "clears shutdown, installs hook, and exits loop when sleep aborts" do
thread_double = instance_double(Thread)
captured = nil
allow(federation_helpers).to receive(:federation_enabled?).and_return(true)
allow(federation_helpers).to receive(:clear_federation_shutdown_request!)
allow(federation_helpers).to receive(:ensure_federation_shutdown_hook!)
allow(federation_helpers).to receive(:federation_sleep_with_shutdown).and_return(false)
allow(Thread).to receive(:new) do |&block|
captured = block
thread_double
end
allow(thread_double).to receive(:respond_to?).with(:name=).and_return(false)
allow(thread_double).to receive(:respond_to?).with(:daemon=).and_return(false)
allow(federation_helpers).to receive(:set)
result = federation_helpers.start_federation_announcer!
expect(result).to eq(thread_double)
expect(captured).to be_a(Proc)
captured.call
expect(federation_helpers).to have_received(:clear_federation_shutdown_request!)
expect(federation_helpers).to have_received(:ensure_federation_shutdown_hook!)
expect(federation_helpers).to have_received(:federation_sleep_with_shutdown)
end
end
end
+1 -21
View File
@@ -143,18 +143,6 @@ RSpec.describe PotatoMesh::App::Meshtastic::Cipher do
expect(text).to eq("Nabend")
end
it "captures a confidence score for decrypted text" do
data = described_class.decrypt_data(
cipher_b64: cipher_b64,
packet_id: packet_id,
from_id: from_id,
psk_b64: psk_b64,
)
expect(data[:text]).to eq("Nabend")
expect(data[:decryption_confidence]).to be_between(0.0, 1.0)
end
it "decrypts the public PSK alias sample payload" do
text = described_class.decrypt_text(
cipher_b64: "otu3OyMrTIUlcaisLVDyAnLW",
@@ -208,7 +196,7 @@ RSpec.describe PotatoMesh::App::Meshtastic::Cipher do
)
expect(text).to be_nil
expect(data).to eq({ portnum: 3, payload: payload, text: nil, decryption_confidence: nil })
expect(data).to eq({ portnum: 3, payload: payload, text: nil })
end
it "normalizes packet ids from numeric strings" do
@@ -289,12 +277,4 @@ RSpec.describe PotatoMesh::App::Meshtastic::Cipher do
expect(data).to be_nil
end
it "scores text confidence higher for longer printable content" do
low = described_class.text_confidence("AC")
high = described_class.text_confidence("This looks like a sentence.")
expect(low).to be < high
expect(high).to be_between(0.0, 1.0)
end
end