iarv/meshview
1
0
Fork 1
mirror of https://github.com/pablorevilla-meshtastic/meshview.git synced 2026-03-04 23:27:46 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use error template for issues with node info page

Browse Source
This commit is contained in:
Steven Conaway
2025-08-14 11:27:25 -07:00
parent 59f7bc73e1
commit 82783b301f
1 changed files with 21 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
meshview/web.py
View File

@@ -268,7 +268,13 @@ async def packet_list(request):
try:
node_id = int(request.match_info["node_id"])
except (KeyError, ValueError):
return web.Response(status=400, text="Invalid or missing node ID")
template = env.get_template("error.html")
rendered = template.render(
error_message="Invalid or missing node ID",
site_config=CONFIG,
SOFTWARE_RELEASE=SOFTWARE_RELEASE,
)
return web.Response(text=rendered, content_type="text/html")
# Parse and validate portnum (optional)
portnum = request.query.get("portnum")
@@ -293,7 +299,13 @@ async def packet_list(request):
has_telemetry = await has_telemetry_task
if node is None:
return web.Response(status=404, text="Node not found")
template = env.get_template("error.html")
rendered = template.render(
error_message="Node not found",
site_config=CONFIG,
SOFTWARE_RELEASE=SOFTWARE_RELEASE,
)
return web.Response(text=rendered, content_type="text/html")
# Render template
template = env.get_template("node.html")
@@ -318,7 +330,13 @@ async def packet_list(request):
except Exception as e:
# Log full traceback for diagnostics
traceback.print_exc()
return web.Response(status=500, text="Internal server error")
template = env.get_template("error.html")
rendered = template.render(
error_message="Internal server error",
site_config=CONFIG,
SOFTWARE_RELEASE=SOFTWARE_RELEASE,
)
return web.Response(text=rendered, content_type="text/html")
@routes.get("/packet_details/{packet_id}")