Merge branch 'main' into fix-settings-redraw

README.md

@@ -33,7 +33,6 @@ By navigating to Settings -> App Settings, you may customize your UI's icons, co
 - `CTRL` + `p` = Hide/show a log of raw received packets.
 - `CTRL` + `t` = With the Node List highlighted, send a traceroute to the selected node 
 - `CTRL` + `d` = With the Channel List hightlighted, archive a chat to reduce UI clutter. Messages will be saved in the db and repopulate if you send or receive a DM from this user.
-- `CTRL` + `d` = With the Note List highlghted, remove a node from your nodedb.
 - `ESC` = Exit out of the Settings Dialogue, or Quit the application if settings are not displayed.
 
 ### Search

contact/ui/control_ui.py

@@ -45,8 +45,10 @@ config_folder = os.path.abspath(config.node_configs_file_path)
 field_mapping, help_text = parse_ini_file(translation_file)
 
 
+
 def display_menu() -> tuple[object, object]:  # curses.window or pad types
 
+
     min_help_window_height = 6
     num_items = len(menu_state.current_menu) + (1 if menu_state.show_save_option else 0)
 
@@ -303,7 +305,6 @@ def settings_menu(stdscr: object, interface: object) -> None:
                         file.write(config_text)
                     logging.info(f"Config file saved to {yaml_file_path}")
                     dialog("Config File Saved:", yaml_file_path)
-                    menu_state.need_redraw = True
                     menu_state.start_index.pop()
                     continue
                 except PermissionError:
@@ -320,7 +321,6 @@ def settings_menu(stdscr: object, interface: object) -> None:
                 # Check if folder exists and is not empty
                 if not os.path.exists(config_folder) or not any(os.listdir(config_folder)):
                     dialog("", " No config files found. Export a config first.")
-                    menu_state.need_redraw = True
                     continue  # Return to menu
 
                 file_list = [f for f in os.listdir(config_folder) if os.path.isfile(os.path.join(config_folder, f))]
@@ -328,7 +328,6 @@ def settings_menu(stdscr: object, interface: object) -> None:
                 # Ensure file_list is not empty before proceeding
                 if not file_list:
                     dialog("", " No config files found. Export a config first.")
-                    menu_state.need_redraw = True
                     continue
 
                 filename = get_list_input("Choose a config file", None, file_list)
@@ -395,6 +394,7 @@ def settings_menu(stdscr: object, interface: object) -> None:
                 menu_state.start_index.pop()
                 menu_state.selected_index = 4
                 continue
+                # menu_state.need_redraw = True
 
             field_info = menu_state.current_menu.get(selected_option)
             if isinstance(field_info, tuple):
@@ -513,27 +513,6 @@ def settings_menu(stdscr: object, interface: object) -> None:
                 menu_state.selected_index = 0
 
         elif key == curses.KEY_LEFT:
-
-            # If we are at the main menu and there are unsaved changes, prompt to save
-            if len(menu_state.menu_path) == 3 and modified_settings:
-
-                current_section = menu_state.menu_path[-1]
-                save_prompt = get_list_input(
-                    f"You have unsaved changes in {current_section}. Save before exiting?",
-                    None,
-                    ["Yes", "No", "Cancel"],
-                    mandatory=True,
-                )
-                if save_prompt == "Cancel":
-                    continue  # Stay in the menu without doing anything
-                elif save_prompt == "Yes":
-                    save_changes(interface, modified_settings, menu_state)
-                    logging.info("Changes Saved")
-
-                modified_settings.clear()
-                menu = rebuild_menu_at_current_path(interface, menu_state)
-                pass
-
             menu_state.need_redraw = True
 
             menu_win.erase()
@@ -545,8 +524,8 @@ def settings_menu(stdscr: object, interface: object) -> None:
             menu_win.refresh()
             help_win.refresh()
 
-            # if len(menu_state.menu_path) < 2:
-            #     modified_settings.clear()
+            if len(menu_state.menu_path) < 2:
+                modified_settings.clear()
 
             # Navigate back to the previous menu
             if len(menu_state.menu_path) > 1:
@@ -563,16 +542,6 @@ def settings_menu(stdscr: object, interface: object) -> None:
             break
 
 
-def rebuild_menu_at_current_path(interface, menu_state):
-    """Rebuild menus from the device and re-point current_menu to the same path."""
-    new_menu = generate_menu_from_protobuf(interface)
-    cur = new_menu["Main Menu"]
-    for step in menu_state.menu_path[1:]:
-        cur = cur.get(step, {})
-    menu_state.current_menu = cur
-    return new_menu
-
-
 def set_region(interface: object) -> None:
     node = interface.getNode("^local")
     device_config = node.localConfig

contact/ui/user_config.py

@@ -75,57 +75,34 @@ def edit_value(key: str, current_value: str) -> str:
     user_input = ""
     input_position = (7, 13)  # Tuple for row and column
     row, col = input_position  # Unpack tuple
-
     while True:
-        if menu_state.need_redraw:
-            curses.update_lines_cols()
-            menu_state.need_redraw = False
-
-            # Re-create the window to fully reset state
-            edit_win = curses.newwin(height, width, start_y, start_x)
-            edit_win.timeout(200)
-            edit_win.bkgd(get_color("background"))
-            edit_win.attrset(get_color("window_frame"))
-            edit_win.border()
-
-            # Redraw static content
-            edit_win.addstr(1, 2, f"Editing {key}", get_color("settings_default", bold=True))
-            edit_win.addstr(3, 2, "Current Value:", get_color("settings_default"))
-            for i, line in enumerate(wrapped_lines[:4]):
-                edit_win.addstr(4 + i, 2, line, get_color("settings_default"))
-            edit_win.addstr(7, 2, "New Value: ", get_color("settings_default"))
-
-        visible_text = user_input[scroll_offset : scroll_offset + input_width]
-        edit_win.addstr(row, col, " " * input_width, get_color("settings_default"))
-        edit_win.addstr(row, col, visible_text, get_color("settings_default"))
+        visible_text = user_input[scroll_offset : scroll_offset + input_width]  # Only show what fits
+        edit_win.addstr(row, col, " " * input_width, get_color("settings_default"))  # Clear previous text
+        edit_win.addstr(row, col, visible_text, get_color("settings_default"))  # Display text
         edit_win.refresh()
 
-        edit_win.move(row, col + min(len(user_input) - scroll_offset, input_width))
+        edit_win.move(row, col + min(len(user_input) - scroll_offset, input_width))  # Adjust cursor position
+        key = edit_win.get_wch()
 
-        try:
-            key = edit_win.get_wch()
-        except curses.error:
-            continue  # window not ready — skip this loop
-
-        if key in (chr(27), curses.KEY_LEFT):
+        if key in (chr(27), curses.KEY_LEFT):  # ESC or Left Arrow
             curses.curs_set(0)
-            return current_value
+            return current_value  # Exit without returning a value
 
         elif key in (chr(curses.KEY_ENTER), chr(10), chr(13)):
             break
 
-        elif key in (curses.KEY_BACKSPACE, chr(127)):
-            if user_input:
+        elif key in (curses.KEY_BACKSPACE, chr(127)):  # Backspace
+            if user_input:  # Only process if there's something to delete
                 user_input = user_input[:-1]
                 if scroll_offset > 0 and len(user_input) < scroll_offset + input_width:
-                    scroll_offset -= 1
+                    scroll_offset -= 1  # Move back if text is shorter than scrolled area
         else:
             if isinstance(key, str):
                 user_input += key
             else:
                 user_input += chr(key)
 
-            if len(user_input) > input_width:
+            if len(user_input) > input_width:  # Scroll if input exceeds visible area
                 scroll_offset += 1
 
     curses.curs_set(0)
@@ -215,7 +192,6 @@ def display_menu() -> tuple[Any, Any, List[str]]:
 def json_editor(stdscr: curses.window, menu_state: Any) -> None:
 
     menu_state.selected_index = 0  # Track the selected option
-    made_changes = False  # Track if any changes were made
 
     script_dir = os.path.dirname(os.path.abspath(__file__))
     parent_dir = os.path.abspath(os.path.join(script_dir, os.pardir))
@@ -242,14 +218,12 @@ def json_editor(stdscr: curses.window, menu_state: Any) -> None:
     menu_state.need_redraw = True
 
     while True:
-        if menu_state.need_redraw:
-            menu_state.need_redraw = False
+        if menu_state.need_redraw == True:
             menu_win, menu_pad, options = display_menu()
             menu_win.refresh()
+            menu_state.need_redraw = False
 
         max_index = len(options) + (1 if menu_state.show_save_option else 0) - 1
-
-        menu_win.timeout(200)
         key = menu_win.getch()
 
         if key == curses.KEY_UP:
@@ -298,14 +272,11 @@ def json_editor(stdscr: curses.window, menu_state: Any) -> None:
 
                 if isinstance(selected_data, list) and len(selected_data) == 2:
                     # Edit color pair
-                    old = selected_data
                     new_value = edit_color_pair(selected_key, selected_data)
                     menu_state.menu_path.pop()
                     menu_state.start_index.pop()
                     menu_state.menu_index.pop()
                     menu_state.current_menu[selected_key] = new_value
-                    if new_value != old:
-                        made_changes = True
 
                 elif isinstance(selected_data, (dict, list)):
                     # Navigate into nested data
@@ -314,15 +285,12 @@ def json_editor(stdscr: curses.window, menu_state: Any) -> None:
 
                 else:
                     # General value editing
-                    old = selected_data
                     new_value = edit_value(selected_key, selected_data)
                     menu_state.menu_path.pop()
                     menu_state.menu_index.pop()
                     menu_state.start_index.pop()
                     menu_state.current_menu[selected_key] = new_value
                     menu_state.need_redraw = True
-                    if new_value != old:
-                        made_changes = True
 
             else:
                 # Save button selected
@@ -354,19 +322,6 @@ def json_editor(stdscr: curses.window, menu_state: Any) -> None:
 
             else:
                 # Exit the editor
-                if made_changes:
-                    save_prompt = get_list_input(
-                        "You have unsaved changes. Save before exiting?",
-                        None,
-                        ["Yes", "No", "Cancel"],
-                        mandatory=True,
-                    )
-                    if save_prompt == "Cancel":
-                        continue  # Stay in the menu without doing anything
-                    elif save_prompt == "Yes":
-                        save_json(file_path, data)
-                        made_changes = False
-
                 menu_win.clear()
                 menu_win.refresh()
 
@@ -383,6 +338,7 @@ def save_json(file_path: str, data: Dict[str, Any]) -> None:
 def main(stdscr: curses.window) -> None:
     from contact.ui.ui_state import MenuState
 
+    menu_state = MenuState()
     if len(menu_state.menu_path) == 0:
         menu_state.menu_path = ["App Settings"]  # Initialize if not set
 

contact/utilities/input_handlers.py

@@ -8,7 +8,6 @@ from contact.ui.colors import get_color
 from contact.ui.nav_utils import move_highlight, draw_arrows, wrap_text
 from contact.ui.dialog import dialog
 from contact.utilities.validation_rules import get_validation_for
-from contact.utilities.singleton import menu_state
 
 
 def invalid_input(window: curses.window, message: str, redraw_func: Optional[callable] = None) -> None:
@@ -54,7 +53,6 @@ def get_text_input(prompt: str, selected_config: str, input_type: str) -> Option
     start_x = (curses.COLS - width) // 2
 
     input_win = curses.newwin(height, width, start_y, start_x)
-    input_win.timeout(200)
     input_win.bkgd(get_color("background"))
     input_win.attrset(get_color("window_frame"))
     input_win.border()
@@ -92,25 +90,15 @@ def get_text_input(prompt: str, selected_config: str, input_type: str) -> Option
     first_line_width = input_width - len(prompt_text)
 
     while True:
-        if menu_state.need_redraw:
-            menu_state.need_redraw = False
-            redraw_input_win()
-
-        try:
-            key = input_win.get_wch()
-        except curses.error:
-            continue
+        key = input_win.get_wch()
 
         if key == chr(27) or key == curses.KEY_LEFT:
             input_win.erase()
             input_win.refresh()
             curses.curs_set(0)
-            menu_state.need_redraw = True
             return None
 
         elif key in (chr(curses.KEY_ENTER), chr(10), chr(13)):
-            menu_state.need_redraw = True
-
             if not user_input.strip():
                 invalid_input(input_win, "Value cannot be empty.", redraw_func=redraw_input_win)
                 continue
@@ -248,11 +236,10 @@ def get_admin_key_input(current_value: List[bytes]) -> Optional[List[str]]:
     start_y = (curses.LINES - height) // 2
     start_x = (curses.COLS - width) // 2
 
-    admin_key_win = curses.newwin(height, width, start_y, start_x)
-    admin_key_win.timeout(200)
-    admin_key_win.bkgd(get_color("background"))
-    admin_key_win.attrset(get_color("window_frame"))
-    admin_key_win.keypad(True)  # Enable keypad for special keys
+    repeated_win = curses.newwin(height, width, start_y, start_x)
+    repeated_win.bkgd(get_color("background"))
+    repeated_win.attrset(get_color("window_frame"))
+    repeated_win.keypad(True)  # Enable keypad for special keys
 
     curses.echo()
     curses.curs_set(1)
@@ -263,39 +250,37 @@ def get_admin_key_input(current_value: List[bytes]) -> Optional[List[str]]:
     invalid_input = ""
 
     while True:
-        admin_key_win.erase()
-        admin_key_win.border()
-        admin_key_win.addstr(1, 2, "Edit up to 3 Admin Keys:", get_color("settings_default", bold=True))
+        repeated_win.erase()
+        repeated_win.border()
+        repeated_win.addstr(1, 2, "Edit up to 3 Admin Keys:", get_color("settings_default", bold=True))
 
         # Display current values, allowing editing
         for i, line in enumerate(user_values):
             prefix = "→ " if i == cursor_pos else "  "  # Highlight the current line
-            admin_key_win.addstr(
+            repeated_win.addstr(
                 3 + i, 2, f"{prefix}Admin Key {i + 1}: ", get_color("settings_default", bold=(i == cursor_pos))
             )
-            admin_key_win.addstr(3 + i, 18, line)  # Align text for easier editing
+            repeated_win.addstr(3 + i, 18, line)  # Align text for easier editing
 
         # Move cursor to the correct position inside the field
         curses.curs_set(1)
-        admin_key_win.move(3 + cursor_pos, 18 + len(user_values[cursor_pos]))  # Position cursor at end of text
+        repeated_win.move(3 + cursor_pos, 18 + len(user_values[cursor_pos]))  # Position cursor at end of text
 
         # Show error message if needed
         if invalid_input:
-            admin_key_win.addstr(7, 2, invalid_input, get_color("settings_default", bold=True))
+            repeated_win.addstr(7, 2, invalid_input, get_color("settings_default", bold=True))
 
-        admin_key_win.refresh()
-        key = admin_key_win.getch()
+        repeated_win.refresh()
+        key = repeated_win.getch()
 
         if key == 27 or key == curses.KEY_LEFT:  # Escape or Left Arrow -> Cancel and return original
-            admin_key_win.erase()
-            admin_key_win.refresh()
+            repeated_win.erase()
+            repeated_win.refresh()
             curses.noecho()
             curses.curs_set(0)
-            menu_state.need_redraw = True
             return None
 
         elif key == ord("\n"):  # Enter key to save and return
-            menu_state.need_redraw = True
             if all(is_valid_base64(val) for val in user_values):  # Ensure all values are valid Base64 and 32 bytes
                 curses.noecho()
                 curses.curs_set(0)
@@ -317,9 +302,6 @@ def get_admin_key_input(current_value: List[bytes]) -> Optional[List[str]]:
                 pass  # Ignore invalid character inputs
 
 
-from contact.utilities.singleton import menu_state  # Required if not already imported
-
-
 def get_repeated_input(current_value: List[str]) -> Optional[str]:
     height = 9
     width = 80
@@ -327,82 +309,71 @@ def get_repeated_input(current_value: List[str]) -> Optional[str]:
     start_x = (curses.COLS - width) // 2
 
     repeated_win = curses.newwin(height, width, start_y, start_x)
-    repeated_win.timeout(200)
     repeated_win.bkgd(get_color("background"))
     repeated_win.attrset(get_color("window_frame"))
-    repeated_win.keypad(True)
+    repeated_win.keypad(True)  # Enable keypad for special keys
 
     curses.echo()
-    curses.curs_set(1)
+    curses.curs_set(1)  #  Show the cursor
 
-    user_values = current_value[:3] + [""] * (3 - len(current_value))  # Always 3 fields
-    cursor_pos = 0
+    # Editable list of values (max 3 values)
+    user_values = current_value[:3]
+    cursor_pos = 0  # Track which value is being edited
     invalid_input = ""
 
-    def redraw():
+    while True:
         repeated_win.erase()
         repeated_win.border()
         repeated_win.addstr(1, 2, "Edit up to 3 Values:", get_color("settings_default", bold=True))
 
+        # Display current values, allowing editing
         for i, line in enumerate(user_values):
-            prefix = "→ " if i == cursor_pos else "  "
+            prefix = "→ " if i == cursor_pos else "  "  # Highlight the current line
             repeated_win.addstr(
                 3 + i, 2, f"{prefix}Value{i + 1}: ", get_color("settings_default", bold=(i == cursor_pos))
             )
-            repeated_win.addstr(3 + i, 18, line[: width - 20])  # Prevent overflow
+            repeated_win.addstr(3 + i, 18, line)
 
+        # Move cursor to the correct position inside the field
+        curses.curs_set(1)
+        repeated_win.move(3 + cursor_pos, 18 + len(user_values[cursor_pos]))  #  Position cursor at end of text
+
+        # Show error message if needed
         if invalid_input:
-            repeated_win.addstr(7, 2, invalid_input[: width - 4], get_color("settings_default", bold=True))
+            repeated_win.addstr(7, 2, invalid_input, get_color("settings_default", bold=True))
 
-        repeated_win.move(3 + cursor_pos, 18 + len(user_values[cursor_pos]))
         repeated_win.refresh()
+        key = repeated_win.getch()
 
-    while True:
-        if menu_state.need_redraw:
-            menu_state.need_redraw = False
-            redraw()
-
-        redraw()
-
-        try:
-            key = repeated_win.get_wch()
-        except curses.error:
-            continue  # ignore timeout or input issues
-
-        if key in (27, curses.KEY_LEFT):  # ESC or Left Arrow
+        if key == 27 or key == curses.KEY_LEFT:  # Escape or Left Arrow -> Cancel and return original
             repeated_win.erase()
             repeated_win.refresh()
             curses.noecho()
             curses.curs_set(0)
-            menu_state.need_redraw = True
             return None
-        elif key in ("\n", curses.KEY_ENTER):
+
+        elif key == ord("\n"):  # Enter key to save and return
             curses.noecho()
             curses.curs_set(0)
-            menu_state.need_redraw = True
-            return ", ".join(user_values).strip()
-        elif key == curses.KEY_UP:
-            cursor_pos = (cursor_pos - 1) % 3
-        elif key == curses.KEY_DOWN:
-            cursor_pos = (cursor_pos + 1) % 3
-        elif key in (curses.KEY_BACKSPACE, 127):
-            user_values[cursor_pos] = user_values[cursor_pos][:-1]
+            return ", ".join(user_values)
+        elif key == curses.KEY_UP:  # Move cursor up
+            cursor_pos = (cursor_pos - 1) % len(user_values)
+        elif key == curses.KEY_DOWN:  # Move cursor down
+            cursor_pos = (cursor_pos + 1) % len(user_values)
+        elif key == curses.KEY_BACKSPACE or key == 127:  # Backspace key
+            if len(user_values[cursor_pos]) > 0:
+                user_values[cursor_pos] = user_values[cursor_pos][:-1]  # Remove last character
         else:
             try:
-                ch = chr(key) if isinstance(key, int) else key
-                if ch.isprintable():
-                    user_values[cursor_pos] += ch
-                    invalid_input = ""
-            except Exception:
-                pass
-
-
-from contact.utilities.singleton import menu_state  # Ensure this is imported
+                user_values[cursor_pos] += chr(key)  # Append valid character input to the selected field
+                invalid_input = ""  # Clear error if user starts fixing input
+            except ValueError:
+                pass  # Ignore invalid character inputs
 
 
 def get_fixed32_input(current_value: int) -> int:
-    original_value = current_value
-    ip_string = str(ipaddress.IPv4Address(current_value))
+    cvalue = current_value
+    current_value = str(ipaddress.IPv4Address(current_value))
     height = 10
     width = 80
     start_y = (curses.LINES - height) // 2
@@ -412,73 +383,54 @@ def get_fixed32_input(current_value: int) -> int:
     fixed32_win.bkgd(get_color("background"))
     fixed32_win.attrset(get_color("window_frame"))
     fixed32_win.keypad(True)
-    fixed32_win.timeout(200)
 
     curses.echo()
     curses.curs_set(1)
     user_input = ""
 
-    def redraw():
+    while True:
         fixed32_win.erase()
         fixed32_win.border()
-        fixed32_win.addstr(1, 2, "Enter an IP address (xxx.xxx.xxx.xxx):", get_color("settings_default", bold=True))
-        fixed32_win.addstr(3, 2, f"Current: {ip_string}", get_color("settings_default"))
-        fixed32_win.addstr(5, 2, f"New value: {user_input}", get_color("settings_default"))
+        fixed32_win.addstr(1, 2, "Enter an IP address (xxx.xxx.xxx.xxx):", curses.A_BOLD)
+        fixed32_win.addstr(3, 2, f"Current: {current_value}")
+        fixed32_win.addstr(5, 2, f"New value: {user_input}")
         fixed32_win.refresh()
 
-    while True:
-        if menu_state.need_redraw:
-            menu_state.need_redraw = False
-            redraw()
+        key = fixed32_win.getch()
 
-        redraw()
-
-        try:
-            key = fixed32_win.get_wch()
-        except curses.error:
-            continue  # ignore timeout
-
-        if key in (27, curses.KEY_LEFT):  # ESC or Left Arrow to cancel
+        if key == 27 or key == curses.KEY_LEFT:  # Escape or Left Arrow to cancel
             fixed32_win.erase()
             fixed32_win.refresh()
             curses.noecho()
             curses.curs_set(0)
-            menu_state.need_redraw = True
-            return original_value
-
-        elif key in ("\n", curses.KEY_ENTER):
+            return cvalue  # Return the current value unchanged
+        elif key == ord("\n"):  # Enter key to validate and save
+            # Validate IP address
             octets = user_input.split(".")
-            menu_state.need_redraw = True
             if len(octets) == 4 and all(octet.isdigit() and 0 <= int(octet) <= 255 for octet in octets):
                 curses.noecho()
                 curses.curs_set(0)
-                return int(ipaddress.ip_address(user_input))
+                fixed32_address = ipaddress.ip_address(user_input)
+                return int(fixed32_address)  # Return the valid IP address
             else:
-                fixed32_win.addstr(7, 2, "Invalid IP address. Try again.", get_color("settings_default", bold=True))
+                fixed32_win.addstr(7, 2, "Invalid IP address. Try again.", curses.A_BOLD | curses.color_pair(5))
                 fixed32_win.refresh()
-                curses.napms(1500)
-                user_input = ""
-
-        elif key in (curses.KEY_BACKSPACE, 127):
+                curses.napms(1500)  # Wait for 1.5 seconds before refreshing
+                user_input = ""  # Clear invalid input
+        elif key == curses.KEY_BACKSPACE or key == 127:  # Backspace key
             user_input = user_input[:-1]
-
         else:
             try:
-                ch = chr(key) if isinstance(key, int) else key
-                if ch.isdigit() or ch == ".":
-                    user_input += ch
-            except Exception:
-                pass  # Ignore unprintable inputs
+                char = chr(key)
+                if char.isdigit() or char == ".":
+                    user_input += char  # Append only valid characters (digits or dots)
+            except ValueError:
+                pass  # Ignore invalid inputs
 
 
-from typing import List, Optional  # ensure Optional is imported
-
-
-def get_list_input(
-    prompt: str, current_option: Optional[str], list_options: List[str], mandatory: bool = False
-) -> Optional[str]:
+def get_list_input(prompt: str, current_option: Optional[str], list_options: List[str]) -> Optional[str]:
     """
-    List selector.
+    Displays a scrollable list of list_options for the user to choose from.
     """
     selected_index = list_options.index(current_option) if current_option in list_options else 0
 
@@ -488,7 +440,6 @@ def get_list_input(
     start_x = (curses.COLS - width) // 2
 
     list_win = curses.newwin(height, width, start_y, start_x)
-    list_win.timeout(200)
     list_win.bkgd(get_color("background"))
     list_win.attrset(get_color("window_frame"))
     list_win.keypad(True)
@@ -496,62 +447,50 @@ def get_list_input(
     list_pad = curses.newpad(len(list_options) + 1, width - 8)
     list_pad.bkgd(get_color("background"))
 
+    # Render header
+    list_win.erase()
+    list_win.border()
+    list_win.addstr(1, 2, prompt, get_color("settings_default", bold=True))
+
+    # Render options on the pad
+    for idx, color in enumerate(list_options):
+        if idx == selected_index:
+            list_pad.addstr(idx, 0, color.ljust(width - 8), get_color("settings_default", reverse=True))
+        else:
+            list_pad.addstr(idx, 0, color.ljust(width - 8), get_color("settings_default"))
+
+    # Initial refresh
+    list_win.refresh()
+    list_pad.refresh(
+        0,
+        0,
+        list_win.getbegyx()[0] + 3,
+        list_win.getbegyx()[1] + 4,
+        list_win.getbegyx()[0] + list_win.getmaxyx()[0] - 2,
+        list_win.getbegyx()[1] + list_win.getmaxyx()[1] - 4,
+    )
+
     max_index = len(list_options) - 1
     visible_height = list_win.getmaxyx()[0] - 5
 
-    def redraw_list_ui():
-        list_win.erase()
-        list_win.border()
-        list_win.addstr(1, 2, prompt, get_color("settings_default", bold=True))
-
-        for idx, item in enumerate(list_options):
-            color = get_color("settings_default", reverse=(idx == selected_index))
-            list_pad.addstr(idx, 0, item.ljust(width - 8), color)
-
-        list_win.refresh()
-        list_pad.refresh(
-            0,
-            0,
-            list_win.getbegyx()[0] + 3,
-            list_win.getbegyx()[1] + 4,
-            list_win.getbegyx()[0] + list_win.getmaxyx()[0] - 2,
-            list_win.getbegyx()[1] + list_win.getmaxyx()[1] - 4,
-        )
-        draw_arrows(list_win, visible_height, max_index, [0], show_save_option=False)
-
-    # Initial draw
-    redraw_list_ui()
+    draw_arrows(list_win, visible_height, max_index, [0], show_save_option=False)  # Initial call to draw arrows
 
     while True:
-        if menu_state.need_redraw:
-            menu_state.need_redraw = False
-            redraw_list_ui()
-
-        try:
-            key = list_win.getch()
-        except curses.error:
-            continue
+        key = list_win.getch()
 
         if key == curses.KEY_UP:
             old_selected_index = selected_index
             selected_index = max(0, selected_index - 1)
             move_highlight(old_selected_index, list_options, list_win, list_pad, selected_index=selected_index)
-
         elif key == curses.KEY_DOWN:
             old_selected_index = selected_index
             selected_index = min(len(list_options) - 1, selected_index + 1)
             move_highlight(old_selected_index, list_options, list_win, list_pad, selected_index=selected_index)
-
-        elif key == ord("\n"):  # Enter
+        elif key == ord("\n"):  # Enter key
             list_win.clear()
             list_win.refresh()
-            menu_state.need_redraw = True
             return list_options[selected_index]
-
-        elif key == 27 or key == curses.KEY_LEFT:  # ESC or Left
-            if mandatory:
-                continue
+        elif key == 27 or key == curses.KEY_LEFT:  # ESC or Left Arrow
             list_win.clear()
             list_win.refresh()
-            menu_state.need_redraw = True
             return current_option