iarv/Remote-Terminal-for-MeshCore
1
0
Fork 1
mirror of https://github.com/jkingsman/Remote-Terminal-for-MeshCore.git synced 2026-05-07 05:45:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix phantom unread badges on convo view

Browse Source
This commit is contained in:
Jack Kingsman
2026-02-10 21:13:44 -08:00
parent 84d39992e2
commit e96b37a263
1 changed files with 20 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/App.tsx
+20 -17
View File
@@ -189,28 +189,31 @@ export function App() {
// Track for unread counts and sorting
trackNewMessage(msg);
const contentKey = getMessageContentKey(msg);
// Dedup: check if we've already seen this content BEFORE marking it seen.
// This must happen before the active/non-active branch so that messages
// first seen in the active conversation are tracked — otherwise a mesh
// duplicate arriving after the user switches away would create a phantom
// unread badge.
const alreadySeen = !msg.outgoing && seenMessageContentRef.current.has(contentKey);
if (!msg.outgoing) {
seenMessageContentRef.current.add(contentKey);
// Limit set size to prevent memory issues
if (seenMessageContentRef.current.size > 1000) {
const keys = Array.from(seenMessageContentRef.current);
seenMessageContentRef.current = new Set(keys.slice(-500));
}
}
// For non-active conversations: update cache and count unreads
if (!isForActiveConversation) {
const contentKey = getMessageContentKey(msg);
// Update message cache (instant restore on switch)
messageCache.addMessage(msg.conversation_key, msg, contentKey);
// Count unread for incoming messages (with deduplication)
if (!msg.outgoing) {
// Skip if we've already seen this message content (prevents duplicate increments
// when the same message arrives via multiple mesh paths)
if (seenMessageContentRef.current.has(contentKey)) {
return;
}
seenMessageContentRef.current.add(contentKey);
// Limit set size to prevent memory issues
if (seenMessageContentRef.current.size > 1000) {
const keys = Array.from(seenMessageContentRef.current);
seenMessageContentRef.current = new Set(keys.slice(-500));
}
// Count unread for incoming messages (skip duplicates from multiple mesh paths)
if (!msg.outgoing && !alreadySeen) {
let stateKey: string | null = null;
if (msg.type === 'CHAN' && msg.conversation_key) {
stateKey = getStateKey('channel', msg.conversation_key);