Compile warnings #885
Assignees
adam (Adam Wojcieszonek)
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: adam/znc#885
Reference in new issue
Block a user
#1 :::
partyline.cpp: In member function ‘virtual CModule::EModRet CPartylineMod::OnNumericMessage(CNumericMessage&)’:
partyline.cpp:209:31: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for (int i = 0; i < Msg.GetParams().size(); ++i) {
~~^~~~~~~~~~~~~~~~~~~~~~~~
#2 ::::
src/main.cpp: In member function ‘virtual bool CSignalHandler::CSignalHandlerMonitorFD::FDsThatTriggered(const std::map<int, short int>&)’:
src/main.cpp:198:54: warning: ignoring return value of ‘ssize_t read(int, void*, size_t)’, declared with attribute warn_unused_result [-Wunused-result]
read(it.first, &sig, sizeof(sig));
^
#3 ::::
In file included from ./include/znc/Client.h:24:0,
from ./include/znc/znc.h:21,
from ./include/znc/IRCNetwork.h:24,
from src/IRCNetwork.cpp:17:
src/IRCNetwork.cpp: In member function ‘bool CIRCNetwork::JoinChan(CChan*)’:
./include/znc/main.h:110:9: warning: nonnull argument ‘this’ compared to NULL [-Wnonnull-compare]
if (macNETWORK != nullptr) {
^
src/IRCNetwork.cpp:993:9: note: in expansion of macro ‘NETWORKMODULECALL’
NETWORKMODULECALL(OnTimerAutoJoin(*pChan), m_pUser, this, nullptr,
^~~~~~~~~~~~~~~~~
./include/znc/main.h:110:9: warning: nonnull argument ‘this’ compared to NULL [-Wnonnull-compare]
if (macNETWORK != nullptr) {
^
src/IRCNetwork.cpp:981:5: note: in expansion of macro ‘NETWORKMODULECALL’
NETWORKMODULECALL(OnJoining(pChan), m_pUser, this, nullptr, &bReturn);
^~~~~~~~~~~~~~~~~
src/IRCNetwork.cpp: In member function ‘void CIRCNetwork::ClientConnected(CClient)’:
./include/znc/main.h:110:9: warning: nonnull argument ‘this’ compared to NULL [-Wnonnull-compare]
if (macNETWORK != nullptr) {
^
src/IRCNetwork.cpp:716:9: note: in expansion of macro ‘NETWORKMODULECALL’
NETWORKMODULECALL(OnPrivBufferPlayMessage(Message), m_pUser, this,
^~~~~~~~~~~~~~~~~
src/IRCNetwork.cpp: In member function ‘bool CIRCNetwork::Connect()’:
./include/znc/main.h:110:9: warning: nonnull argument ‘this’ compared to NULL [-Wnonnull-compare]
if (macNETWORK != nullptr) {
^
src/IRCNetwork.cpp:1296:5: note: in expansion of macro ‘NETWORKMODULECALL’
NETWORKMODULECALL(OnIRCConnecting(pIRCSock), m_pUser, this, nullptr,
^~~~~~~~~~~~~~~~~
#4 ::::
In file included from ./include/znc/Client.h:24:0,
from ./include/znc/znc.h:21,
from ./include/znc/IRCNetwork.h:24,
from src/User.cpp:20:
src/User.cpp: In member function ‘bool CUser::DeleteNetwork(const CString&)’:
./include/znc/main.h:85:9: warning: nonnull argument ‘this’ compared to NULL [-Wnonnull-compare]
if (macUSER != nullptr) {
^
./include/znc/main.h:126:5: note: in expansion of macro ‘_USERMODULECALL’
_USERMODULECALL(macFUNC, macUSER, nullptr, macCLIENT, macEXITER)
^~~~~~~~~~~~~~~
src/User.cpp:550:9: note: in expansion of macro ‘USERMODULECALL’
USERMODULECALL(OnDeleteNetwork(pNetwork), this, nullptr, &bCancel);
^~~~~~~~~~~~~~
src/User.cpp: In member function ‘CIRCNetwork CUser::AddNetwork(const CString&, CString&)’:
./include/znc/main.h:85:9: warning: nonnull argument ‘this’ compared to NULL [-Wnonnull-compare]
if (macUSER != nullptr) {
^
./include/znc/main.h:126:5: note: in expansion of macro ‘_USERMODULECALL’
_USERMODULECALL(macFUNC, macUSER, nullptr, macCLIENT, macEXITER)
^~~~~~~~~~~~~~~
src/User.cpp:518:5: note: in expansion of macro ‘USERMODULECALL’
USERMODULECALL(OnAddNetwork(*pNetwork, sErrorRet), this, nullptr, &bCancel);
^~~~~~~~~~~~~~
on latest Debian Stretch with openssl 1.1.1 - regards
Yeah, known issue... It's harmless but shows those warnings. Wanna contribute a patch?
P.S. we have CMake now, and old ./configure will eventually go away.
v1.7.4 build
WARNINGS ENCOUNTERED DURING BUILD
Building module partyline...
partyline.cpp: In member function ‘virtual CModule::EModRet CPartylineMod::OnNumericMessage(CNumericMessage&)’:
partyline.cpp:209:31: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for (int i = 0; i < Msg.GetParams().size(); ++i) {
Building core object main...
src/main.cpp: In member function ‘virtual bool CSignalHandler::CSignalHandlerMonitorFD::FDsThatTriggered(const std::map<int, short int>&)’:
src/main.cpp:198:54: warning: ignoring return value of ‘ssize_t read(int, void*, size_t)’, declared with attribute warn_unused_result [-Wunused-result]
read(it.first, &sig, sizeof(sig));
^
Building core object Utils...
src/Utils.cpp: In static member function ‘static CString CUtils::FormatTime(const timeval&, const CString&, const CString&)’:
src/Utils.cpp:540:30: warning: ‘uFormatStart’ may be used uninitialized in this function [-Wmaybe-uninitialized]
sFormat2 += sFormat.substr(uLastCopied,
^
src/Utils.cpp:517:9: warning: ‘iDigits’ may be used uninitialized in this function [-Wmaybe-uninitialized]
int iDigits;
^
END WARNINGS ENCOUNTERED
That is all