Add playback buffer support to partyline module (or at least an error message) #4
Assignees
adam (Adam Wojcieszonek)
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: adam/znc#4
Reference in new issue
Block a user
Hi,
One of the main attractions of ZNC for my group is the partyline module. It's usefulness it limited, however, because it does not support the playback buffer.
For example: George sends a /msg to ?Susan, who is not connected to ZNC at the moment. George's message is silently accepted by ZNC, even though Susan will never receive it. When Susan reconnects to ZNC, she has no idea that George was trying talking to her. Not good.
I think adding full support for playback buffer would be ideal.
Less ideal, but still a big step forward in user-friendliness, would be to display an error message when George attempt to /msg ?Susan while she is not connected to ZNC.
Just an idea from an ZNC fan! I can't code it myself, so thanks for considering it.
I asked for this feature before, but i was told that the partyline-module/-code isn't that easy to change to achieve a bufferfunction
If that's the case, adding some kind of error feedback when messaging offline users on the partyline would make it less of a blackhole.
I'm rather wondering why all these issues are being referenced by Issue #94. Anyways, I would love this, either one of these solutions. I'll see if I can code an error into partyline.cpp, but I haven't been doing much coding for rather a long time, and I'm not very good at it. Another solution would be to have logged off users disappear entirely from the partyline.
Edit: try replacing lines 411-422 of partyline.cpp (starts/ends the same) with the code below. New lines are not indented. This should return a 403 numeric and a message that the user is not attached . Also, I would like to recommend that you not use the connected irc server to return the numerics, if that doesn't break rfc or clients, though I left it that way to match the other code.
if (pUser) { if(pUser.isUserAttached()) { for (vector::const_iterator i = pUser->GetNetworks().begin(); i != pUser->GetNetworks().end(); ++i) { CIRCNetwork* pNetwork = *i; pNetwork->PutUser(":?" + m_pUser->GetUserName() + "!" + m_pUser->GetIdent() + "@" + sHost + " " + sCmd + " " + pNetwork->GetIRCNick().GetNick() + " :" + sMessage); } for (vector::const_iterator i = pUser->GetUserClients().begin(); i != pUser->GetUserClients().end(); ++i) { CClient* pClient = *i; pClient->PutClient(":?" + m_pUser->GetUserName() + "!" + m_pUser->GetIdent() + "@" + sHost + " " + sCmd + " " + pClient->GetNick() + " :" + sMessage); } } else { m_pClient->PutClient(":" + GetIRCServer(m_pNetwork) + " 403 " + m_pClient->GetNick() + " " + sTarget + " :znc user: " + sNick + " is not attached."); } } else { m_pClient->PutClient(":" + GetIRCServer(m_pNetwork) + " 403 " + m_pClient->GetNick() + " " + sTarget + " :No such znc user: " + sNick + ""); }Can someone provide a link to an explanation why the it's not possible to log private messages (and therefore partylines)? What would have to be done to change that?
Private messages do come through in the query buffer. If partyline messages should be buffered, where should this go? Which network of the users?
I am new to ZNC so I am not shure if I understand you right. Yes, the partyline channels are on 'no network', but I dont understand why this makes a difference (i would say "just call the network 'localhost' or 'znc'" but that sounds too easy).
Basically the partyline module makes it possible to have 'internal' channels and I would like them to behave like 'normal' channels (or understand why it's not possible). The only other solution I see right now would be using an IRC server listening on localhost instead of the partyline module (which really sounds like overkill).
I just tested it again (using the version in ubuntu packages, so maybe thats an issue):
I am using the savebuff module (which does the playback?) plus the away module to catch private messages.