ZNC strips : from smileys #556

New Issue

2026-10-05T04:29:41+02:00

adam commented

2026-10-05 04:29:41 +02:00

I was wondering when did eyeless smileys become so popular and originally reported this at https://github.com/weechat/weechat/issues/496, but then I opened HexChat which got the same issue so it must be ZNC.

Debian GNU/Linux 7.8 (wheezy)
ZNC 1.7.x-git-266-e546ced - http://znc.in
- IPv6: yes, SSL: yes, DNS: threads, charset: yes

I was wondering when did eyeless smileys become so popular and originally reported this at https://github.com/weechat/weechat/issues/496, but then I opened HexChat which got the same issue so it must be ZNC. - Debian GNU/Linux 7.8 (wheezy) - ZNC 1.7.x-git-266-e546ced - http://znc.in - IPv6: yes, SSL: yes, DNS: threads, charset: yes

adam closed this issue

2026-10-05 04:29:41 +02:00

adam commented

2026-10-05 04:29:42 +02:00

Sorry for the inconvenience. The root cause is the overly generalized message parser that was introduced by #1000. #1031 makes such changes to the CMessage type hierarchy that will make it easier to fix this.

Sorry for the inconvenience. The root cause is the overly generalized message parser that was introduced by #1000. #1031 makes such changes to the CMessage type hierarchy that will make it easier to fix this.

adam commented

2026-10-05 04:29:43 +02:00

Inconvenience? I have just been wondering why eyeless smileys became so fashionable and when I discovered it's a bug in ~~WeeChat~~ ZNC, I don't remember how I have laughed this well 😆

Inconvenience? I have just been wondering why eyeless smileys became so fashionable and when I discovered it's a bug in <s>WeeChat</s> ZNC, I don't remember how I have laughed this well :laughing:

adam commented

2026-10-05 04:29:43 +02:00

We could either make CMessage::ToString()
A) always prefix the last parameter with : regardless of spaces, or
B) take the message type into account.

I've been planning to add EType CMessage::GetType() after #1031, to avoid having to do so much string comparison with CMessage::GetCommand(). That would be nice for option B.

We could either make `CMessage::ToString()` A) always prefix the last parameter with `:` regardless of spaces, or B) take the message type into account. I've been planning to add `EType CMessage::GetType()` after #1031, to avoid having to do so much string comparison with `CMessage::GetCommand()`. That would be nice for option B.

adam commented

2026-10-05 04:29:44 +02:00

C) Prefix the last parameter with : if last parameter starts with :

C) Prefix the last parameter with `:` if last parameter starts with `:`

adam commented

2026-10-05 04:29:45 +02:00

Sounds better )

On Fri, Aug 21, 2015, 21:06 Alexey Sokolov notifications@github.com wrote:

C) Prefix the last parameter with : if last parameter starts with :

—
Reply to this email directly or view it on GitHub
https://github.com/znc/znc/issues/1037#issuecomment-133533079.

Sounds better ) On Fri, Aug 21, 2015, 21:06 Alexey Sokolov notifications@github.com wrote: > C) Prefix the last parameter with : if last parameter starts with : > > — > Reply to this email directly or view it on GitHub > https://github.com/znc/znc/issues/1037#issuecomment-133533079.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: adam/znc#556