The description gets displayed when the service is started and would
output something like "Starting An advanced IRC bouncer". There's
potentially more than one, though, and, thus, the name should at least
be included.
Type=forking should be used as a last resort only. systemd does the
forking itself and, thus, ZNC should be started with the -f switch.
Custom modules compiled for older ZNC can crash ZNC.
Because now ZNC checks for list of available modules on startup in order
to check whether it's installed or not, it can crash right on startup.
Now it outputs nice message about checking for modules before that.
See github issue #172
In HTML one <form> can't be inside another one...
In XHTML it works...
Thanks to skydrome for reporting this.
Also I tried to fix listeners editor, as they used nested forms too...
But it seems that I messed up the whole table.
Let someone more skilled in HTML fix this broken layout.
At least buttons themselves work now.
Only his changes to the core are presented here.
Unfortunately, the skin itself looks ugly on Opera,
and simply doesn't work on Firefox...
Merge branch 'master' into znc-ation
Conflicts:
modules/data/lastseen/tmpl/lastseen_WebadminUser.tmpl
modules/data/webadmin/tmpl/settings.tmpl
Commit b1593238d5 started using the module pointer before the NULL
check. This caused crashes whenever someone (even without a login!) accessed a
web page on znc for a module which didn't exist.
Thanks to J0rd4n` for reporting this to us.
Signed-off-by: Uli Schlachter <psychon@znc.in>
The IMAP RFC allows the server to announce its capabilities before replying to
the LOGIN command. imapauth would misinterpret that as a failed login.
The fix is to only handle lines which contain the tag ("AUTH") used for the
login command.
Thanks to rlpowell for reporting that imapauth doesn't work against
imap.google.com and for testing the fix.
Signed-off-by: Uli Schlachter <psychon@znc.in>
A malicious IRCd could send a WHO reply for a nick which consisted completely
out of prefix characters (thus an empty nick). In this case
std::string::find_first_of() would return std::string::npos. This argument would
make std::string::substr() throw an exception and kill the process.
Signed-off-by: Uli Schlachter <psychon@znc.in>
Wulf C. Krueger