adam/znc
1
0
Fork 0
mirror of https://github.com/znc/znc.git synced 2026-08-07 09:22:55 +02:00
Code Issues Packages Projects Releases Wiki Activity

TDNSTask & CDNSJob: use member intialization lists [-Weffc++] (#270)

Browse Source
This commit is contained in:
J-P Nurmi
2015-03-04 11:00:34 +01:00
parent d16f35facc
commit e1ada6c643
2 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/znc/Socket.h
+4
View File
@@ -138,6 +138,8 @@ private:
friend class CTDNSMonitorFD;
#ifdef HAVE_THREADED_DNS
struct TDNSTask {
TDNSTask() : sHostname(""), iPort(0), sSockName(""), iTimeout(0), bSSL(false), sBindhost(""), pcSock(nullptr), bDoneTarget(false), bDoneBind(false), aiTarget(nullptr), aiBind(nullptr) {}
CString sHostname;
u_short iPort;
CString sSockName;
@@ -153,6 +155,8 @@ private:
};
class CDNSJob : public CJob {
public:
CDNSJob() : sHostname(""), task(nullptr), pManager(nullptr), bBind(false), iRes(0), aiResult(nullptr) {}
CString sHostname;
TDNSTask* task;
CSockManager* pManager;
src/Socket.cpp
-6
View File
@@ -208,8 +208,6 @@ void CSockManager::StartTDNSThread(TDNSTask* task, bool bBind) {
arg->sHostname = sHostname;
arg->task = task;
arg->bBind = bBind;
arg->iRes = 0;
arg->aiResult = nullptr;
arg->pManager = this;
CThreadPool::Get().addJob(arg);
@@ -363,13 +361,9 @@ void CSockManager::Connect(const CString& sHostname, u_short iPort, const CStrin
task->bSSL = bSSL;
task->sBindhost = sBindHost;
task->pcSock = pcSock;
task->aiTarget = nullptr;
task->aiBind = nullptr;
task->bDoneTarget = false;
if (sBindHost.empty()) {
task->bDoneBind = true;
} else {
task->bDoneBind = false;
StartTDNSThread(task, true);
}
StartTDNSThread(task, false);