Apply fixes for IsParting() pull request.

This commit is contained in:
RealKindOne
2026-07-22 01:58:01 -04:00
parent a0d58c8fed
commit d2fc5d550a
3 changed files with 2 additions and 8 deletions
-1
View File
@@ -1204,7 +1204,6 @@ bool CIRCSock::OnPartMessage(CPartMessage& Message) {
}
if (Nick.NickEquals(GetNick())) {
if (pChan) pChan->SetParting(false);
m_pNetwork->DelChan(sChan);
}
+1 -4
View File
@@ -574,9 +574,6 @@ TEST_F(IRCSockTest, PartingFlag) {
CMessage serverPart(":me PART #chan");
m_pTestSock->ReadLine(serverPart.ToString());
// IsParting() should be free
EXPECT_FALSE(m_pTestChan->IsParting());
// Verify channel was deleted
EXPECT_EQ(m_pTestNetwork->FindChan("#chan"), nullptr);
}
@@ -593,7 +590,7 @@ TEST_F(IRCSockTest, PartingFlagOnError) {
CMessage errorMsg(":server 442 me #chan :You're not on that channel");
m_pTestSock->ReadLine(errorMsg.ToString());
// IsParting() should be free
// IsParting() should be cleared
EXPECT_FALSE(m_pTestChan->IsParting());
// Verify channel was deleted
+1 -3
View File
@@ -1368,9 +1368,7 @@ TEST_F(ZNCTest, PartWithError403) {
client.ReadUntil(":nick JOIN :#test");
client.Write("PART #test");
QByteArray partMsg;
ircd.ReadUntilAndGet("PART", partMsg);
EXPECT_THAT(partMsg.toStdString(), HasSubstr("PART #test"));
ircd.ReadUntil("PART #test");
// Server returns 403 error (ERR_NOSUCHCHANNEL) instead of confirming
ircd.Write(":server 403 nick #test :No such channel");