CString should be const& in parameters.

Especially when it's not copied inside the function.
This commit is contained in:
Alexey Sokolov
2011-09-13 01:30:36 +07:00
parent fa7ec788dd
commit c25e24017c
2 changed files with 2 additions and 2 deletions
+1 -1
View File
@@ -464,7 +464,7 @@ void CUser::RemoveNetwork(CIRCNetwork *pNetwork) {
}
}
bool CUser::DeleteNetwork(CString sNetwork) {
bool CUser::DeleteNetwork(const CString& sNetwork) {
CIRCNetwork *pNetwork = FindNetwork(sNetwork);
if (pNetwork) {
+1 -1
View File
@@ -67,7 +67,7 @@ public:
// Networks
CIRCNetwork* AddNetwork(const CString &sNetwork);
bool DeleteNetwork(CString sNetwork);
bool DeleteNetwork(const CString& sNetwork);
bool AddNetwork(CIRCNetwork *pNetwork);
void RemoveNetwork(CIRCNetwork *pNetwork);
CIRCNetwork* FindNetwork(const CString& sNetwork);