#449 - Show filename if the title is not set

This commit is contained in:
Elio Struyf
2022-11-04 09:58:54 +01:00
parent 42fbdf9708
commit c6a4c239a0
2 changed files with 4 additions and 2 deletions
+1
View File
@@ -12,6 +12,7 @@
- [#428](https://github.com/estruyf/vscode-front-matter/issues/428): Improved UX for inserting images to your content
- [#430](https://github.com/estruyf/vscode-front-matter/issues/430): Support for HEXO its `post_asset_folder` setting (image location)
- [#434](https://github.com/estruyf/vscode-front-matter/issues/434): Webview errors are logged in the extension output
- [#449](https://github.com/estruyf/vscode-front-matter/issues/449): Show `filename` if the `title` is not set
### ⚡️ Optimizations
+3 -2
View File
@@ -126,8 +126,9 @@ export class PagesParser {
*/
public static async processPageContent(filePath: string, fileMtime: number, fileName: string, folderTitle: string): Promise<Page | undefined> {
const article = await ArticleHelper.getFrontMatterByPath(filePath);
const articleTitle = article?.data.title || fileName;
if (article?.data.title) {
if (article?.data) {
const wsFolder = Folders.getWorkspaceFolder();
const descriptionField = Settings.get(SETTING_SEO_DESCRIPTION_FIELD) as string || DefaultFields.Description;
@@ -139,7 +140,7 @@ export class PagesParser {
const staticFolder = Folders.getStaticFolderRelativePath();
let escapedTitle = article?.data.title;
let escapedTitle = articleTitle;
if (escapedTitle && typeof escapedTitle !== "string") {
escapedTitle = "<invalid title>";
}