Negotiated path in contacts details is wrongly formatted:
There is a space between each two hex characters (i.e. after each one byte, regardless of the number of bytes used in the hash). All that enclosed in one set of square brachets. No visual where the prefix for one node ends and for the next begins.
For example, when I go to Contacts screen and tap on some contacts where a path has been negotiated, I see that kinds of information: Route: 1 hops [1A 71] (Also note that the plural s in hops is wrong when it is just one!), Route: 1 hops [1A], Route: 0 hops [], Route: 2 hops [1A 71 A2 3F], Route: 6 hops [1A 12 98 ED 10 E5], Route: 3 hops [1A 71 21 3B 3F 0E], Route: 4 hops [1A 12 81 7F], Route: 5 hops [1A 12 79 3F ED],
etc.
I think it should be like Route: 6 hops [1A] [12] [98] [ED] [10] [E5] or Route: 3 hops [1A71] [213B] [3F0E] or Route: 1 hop [1A71] or Route: 1 hop [1A] or Route: 0 hops.
Which device are you using
LilyGO T-Deck Plus
Which Firmware are you using
v0.9.12.3
Regards!
**Describe the bug**
Negotiated path in contacts details is wrongly formatted:
There is a space between each two hex characters (i.e. after each one byte, regardless of the number of bytes used in the hash). All that enclosed in one set of square brachets. No visual where the prefix for one node ends and for the next begins.
For example, when I go to `Contacts` screen and tap on some contacts where a path has been negotiated, I see that kinds of information:
`Route: 1 hops [1A 71]` (Also note that the plural `s` in `hops` is wrong when it is just one!),
`Route: 1 hops [1A]`,
`Route: 0 hops []`,
`Route: 2 hops [1A 71 A2 3F]`,
`Route: 6 hops [1A 12 98 ED 10 E5]`,
`Route: 3 hops [1A 71 21 3B 3F 0E]`,
`Route: 4 hops [1A 12 81 7F]`,
`Route: 5 hops [1A 12 79 3F ED]`,
etc.
I think it should be like
`Route: 6 hops [1A] [12] [98] [ED] [10] [E5]` or
`Route: 3 hops [1A71] [213B] [3F0E]` or
`Route: 1 hop [1A71]` or
`Route: 1 hop [1A]` or
`Route: 0 hops`.
**Which device are you using**
LilyGO T-Deck Plus
**Which Firmware are you using**
v0.9.12.3
Regards!
<!-- github-sync-id:4655255258 -->
Contacts #319: Route on the contact detail screen shows each relay as its own bracket (e.g. Route: 3 hops [1A71] [213B] [3F0E]) instead of one long hex string; correct hop vs hops wording. Hash width (1B/2B/3B) on the list and map follows the encoded path length from heard adverts or stored routes (including 2B/3B zero-hop floods).
### Improved (v0.9.13)
- **Contacts #319:** Route on the contact detail screen shows each relay as its own bracket (e.g. `Route: 3 hops [1A71] [213B] [3F0E]`) instead of one long hex string; correct **hop** vs **hops** wording. Hash width (1B/2B/3B) on the list and map follows the encoded path length from heard adverts or stored routes (including 2B/3B zero-hop floods).
<!-- github-comment-id:4733723772 -->
Now, long paths are cropped and cannot be scrolled.
For a 5 hops contact with 2byte path hash, I just see something like Route: 5 hops [1A71] [213B] [3F0E] [A... [RSTPath] ([RSTPath] is the button to reset the path)
and cannot see the full path.
This still should be addressed.
Regards!
I can confirm, _but_ it needs an enhancement:
Now, long paths are cropped and cannot be scrolled.
For a 5 hops contact with 2byte path hash, I just see something like
`Route: 5 hops [1A71] [213B] [3F0E] [A... [RSTPath]` (`[RSTPath]` is the button to reset the path)
and cannot see the full path.
This still should be addressed.
Regards!
<!-- github-comment-id:6061087956 -->
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Describe the bug
Negotiated path in contacts details is wrongly formatted:
There is a space between each two hex characters (i.e. after each one byte, regardless of the number of bytes used in the hash). All that enclosed in one set of square brachets. No visual where the prefix for one node ends and for the next begins.
For example, when I go to
Contactsscreen and tap on some contacts where a path has been negotiated, I see that kinds of information:Route: 1 hops [1A 71](Also note that the pluralsinhopsis wrong when it is just one!),Route: 1 hops [1A],Route: 0 hops [],Route: 2 hops [1A 71 A2 3F],Route: 6 hops [1A 12 98 ED 10 E5],Route: 3 hops [1A 71 21 3B 3F 0E],Route: 4 hops [1A 12 81 7F],Route: 5 hops [1A 12 79 3F ED],etc.
I think it should be like
Route: 6 hops [1A] [12] [98] [ED] [10] [E5]orRoute: 3 hops [1A71] [213B] [3F0E]orRoute: 1 hop [1A71]orRoute: 1 hop [1A]orRoute: 0 hops.Which device are you using
LilyGO T-Deck Plus
Which Firmware are you using
v0.9.12.3
Regards!
Improved (v0.9.13)
Route: 3 hops [1A71] [213B] [3F0E]) instead of one long hex string; correct hop vs hops wording. Hash width (1B/2B/3B) on the list and map follows the encoded path length from heard adverts or stored routes (including 2B/3B zero-hop floods).I can confirm, but it needs an enhancement:
Now, long paths are cropped and cannot be scrolled.
For a 5 hops contact with 2byte path hash, I just see something like
Route: 5 hops [1A71] [213B] [3F0E] [A... [RSTPath]([RSTPath]is the button to reset the path)and cannot see the full path.
This still should be addressed.
Regards!