adam/meshcore
1
0 Fork 0
mirror of https://github.com/dabeani/meshcoreterm.git synced 2026-11-02 02:55:46 +01:00
Code Issues 97 Packages Projects Releases Wiki Activity

Time is set to time of received message. Always, unconditionally, also when received message has wrong time. | "NTP Status" continues to show "Synced" also when on device clock has been changed. #213

New Issue
Closed
opened 2026-10-27 15:44:13 +01:00 by adam · 2 comments
adam commented 2026-10-27 15:44:13 +01:00
Owner
Copy link
Copy source

Describe the bug

When a message is received, it sets the clock (date and time) to the timestamp of the received message.

This happens also when receiving a room server message or some reply from a repeater (admin login).

Clocks of nodes are sometimes, of room servers and repeaters often, wrong -- leading to a wrong clock setting on the device running MC Term!

Furthermore, in "Mgmt" -> "Date/Time", "NTP Status" stays showing "Synced" even if time has been changed by the mechanics described above, or manual. It should show "not synced" if the last NTP sync was changed by any other means.

Proposed solution

While setting the time and date from a received message is a nice feature, it should be optional and not mandatory.
There should be a new setting unter "Mgmt" -> "Date/Time" saying "sync time from received message", which can be set to "Enabled" or "Disabled".

Which device are you using

LilyGO T-Deck Plus

Which Firmware are you using

v0.9.12

Regards!

**Describe the bug** When a message is received, it sets the clock (date and time) to the timestamp of the received message. This happens also when receiving a room server message or some reply from a repeater (admin login). Clocks of nodes are sometimes, of room servers and repeaters often, wrong -- leading to a wrong clock setting on the device running MC Term! Furthermore, in "Mgmt" -> "Date/Time", "NTP Status" stays showing "Synced" even if time has been changed by the mechanics described above, or manual. It should show "not synced" if the last NTP sync was changed by _any_ other means. **Proposed solution** While setting the time and date from a received message is a nice feature, it should be optional and not mandatory. There should be a new setting unter "Mgmt" -> "Date/Time" saying "sync time from received message", which can be set to "Enabled" or "Disabled". **Which device are you using** LilyGO T-Deck Plus **Which Firmware are you using** v0.9.12 Regards! <!-- github-sync-id:4327890404 -->
adam closed this issue 2026-10-27 15:44:13 +01:00
adam commented 2026-10-27 15:44:14 +01:00
Author
Owner
Copy link
Copy source

fixed in v0.9.12.1:

  • Time sync: stop trusting room-server and repeater-admin traffic as RTC authorities, so room/repeater replies can no longer trigger large local clock jumps (#203, narrowed scope, see #213).
  • Time sync (ui-modern): added a Sync from Msg toggle in Mgmt -> Date/Time (default Disabled) that gates whether received message timestamps are allowed to update the on-device RTC at all, and made the NTP Status row report No response whenever the clock is changed by manual edit or by a non-NTP message-driven sync, so the indicator no longer keeps claiming Synced after such overrides. WebUI mirrors the toggle in Settings -> Date/Time (#213).
fixed in v0.9.12.1: - Time sync: stop trusting room-server and repeater-admin traffic as RTC authorities, so room/repeater replies can no longer trigger large local clock jumps (#203, narrowed scope, see #213). - Time sync (ui-modern): added a `Sync from Msg` toggle in Mgmt -> Date/Time (default Disabled) that gates whether received message timestamps are allowed to update the on-device RTC at all, and made the NTP Status row report `No response` whenever the clock is changed by manual edit or by a non-NTP message-driven sync, so the indicator no longer keeps claiming `Synced` after such overrides. WebUI mirrors the toggle in Settings -> Date/Time (#213). <!-- github-comment-id:4322732530 -->
adam commented 2026-10-27 15:44:14 +01:00
Author
Owner
Copy link
Copy source

This now has been fixed, but the introduced time Sync from Msg does not work ↗ #283.

This now has been fixed, but the introduced time `Sync from Msg` does not work &nearr;&hairsp;#283. <!-- github-comment-id:4604627247 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/meshcore#213