adam/meshcore-hub
1
0
Fork 0
mirror of https://github.com/ipnet-mesh/meshcore-hub.git synced 2026-08-07 17:33:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: n is not defined in observer filter badges

Browse Source 
Commit 37f8d7a re-introduced emoji extraction in observerFilterBadges
after d1a3605 had refactored the iteration variable from `n` (node
object) to `area` (plain string). Three references to n._displayName
and n.public_key were left behind, throwing ReferenceError the moment
any observer had an area tag.

Adverts and Messages pages surface this as a warning badge with the
error message; the early return hides the bug on deployments with no
area-tagged observers.

Replace n.X with area (the iteration variable). Emoji extraction and
label fallback now operate on the area string directly.
This commit is contained in:
Louis King
2026-07-19 19:56:34 +01:00
parent 938028a7a7
commit 65ec669e48
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/meshcore_hub/web/static/js/spa/components.js
+3 -3
View File
@@ -659,12 +659,12 @@ export function observerFilterBadges({ areas, disabled, onToggle, extraClass = '
const title = enabled
? t('common.filter_observer_disable')
: t('common.filter_observer_enable');
const emoji = extractFirstEmoji(n._displayName);
const label = emoji ? (n._displayName.replace(emoji, '').trim() || n._displayName) : n._displayName;
const emoji = extractFirstEmoji(area);
const label = emoji ? (area.replace(emoji, '').trim() || area) : area;
return html`<button type="button"
class="${cls} cursor-pointer"
title=${title}
@click=${() => onToggle(n.public_key)}>${emoji ? html`<span class="mr-1">${emoji}</span>` : nothing}${label}</button>`;
@click=${() => onToggle(area)}>${emoji ? html`<span class="mr-1">${emoji}</span>` : nothing}${label}</button>`;
})}
</div>`;
}