adam/Piwigo
1
0 Fork 0
mirror of https://github.com/Piwigo/Piwigo.git synced 2026-10-30 21:52:00 +01:00
Code Issues 657 Packages Projects Releases Wiki Activity

[2.9.4] users list no longer paginated or filtered #809

New Issue
Closed
opened 2026-10-05 00:18:28 +02:00 by adam · 1 comment
adam commented 2026-10-05 00:18:28 +02:00
Owner
Copy link
Copy source

On Piwigo 2.9.4, compared to 2.9.3, the users list can no longer be filtered and is not paginated. It always shows the complete list of users. If you have 15 users that's not a big problem. If you 20k users, it makes the user manager unusable.

The problem is due to a235a2e229 : the use of "ajax" param instead of "ajaxsource" is the way to go to use the current API of Datatables, but it completely changes the way parameters are sent to admin/user_list_backend.php. Unfortunately, the user list was apparently working fine, I would have prefered it to completely crash: we would have seen the problem before releasing 2.9.4.

On Piwigo 2.9.4, compared to 2.9.3, the users list can no longer be filtered and is not paginated. It always shows the complete list of users. If you have 15 users that's not a big problem. If you 20k users, it makes the user manager unusable. The problem is due to a235a2e2296e515ac67e4e618d2c2e4a4fa58e19 : the use of "ajax" param instead of "ajaxsource" is the way to go to use the current API of Datatables, but it completely changes the way parameters are sent to admin/user_list_backend.php. Unfortunately, the user list was apparently working fine, I would have prefered it to completely crash: we would have seen the problem before releasing 2.9.4. <!-- github-sync-id:343935050 -->
adam closed this issue 2026-10-05 00:18:28 +02:00
adam commented 2026-10-05 00:18:29 +02:00
Author
Owner
Copy link
Copy source

I have decided to revert https://github.com/Piwigo/Piwigo/commit/a235a2e2296e515ac67e4e618d2c2e4a4fa58e19 in https://github.com/Piwigo/Piwigo/commit/ab46632a3210b755915c4ecf50d06b6727b1de16

I've considered the facts:

  • the original issue, described in #748 has only been reproduced by very few users and is most certainly due to a server configuration (we don't know which one)
  • I don't want to switch to GET instead of POST because it will cause huge lines in server log files and I fear the side effects of switching
  • we will cleaning use the ajax function instead of ajaxsource for Piwigo 2.10, see #999
I have decided to revert https://github.com/Piwigo/Piwigo/commit/a235a2e2296e515ac67e4e618d2c2e4a4fa58e19 in https://github.com/Piwigo/Piwigo/commit/ab46632a3210b755915c4ecf50d06b6727b1de16 I've considered the facts: * the original issue, described in #748 has only been reproduced by very few users and is most certainly due to a server configuration (we don't know which one) * I don't want to switch to GET instead of POST because it will cause huge lines in server log files and I fear the side effects of switching * we will cleaning use the `ajax` function instead of `ajaxsource` for Piwigo 2.10, see #999 <!-- github-comment-id:478971201 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/Piwigo#809