adam/Piwigo
1
0 Fork 0
mirror of https://github.com/Piwigo/Piwigo.git synced 2026-11-03 07:22:22 +01:00
Code Issues 657 Packages Projects Releases Wiki Activity

Search in Keyword Manager not working #1148

New Issue
Closed
opened 2026-10-05 00:33:09 +02:00 by adam · 2 comments
adam commented 2026-10-05 00:33:09 +02:00
Owner
Copy link
Copy source

From version 11.0.0 the search for keywords in the keyword manager is no longer possible. The reason for this is a missing "toLowerCase" in the JavaScript function isDataSearched in the file admin/default/js/tags.js

My fixed version:
function isDataSearched(tagObj) {
let name = tagObj.name.toLowerCase();
let stringSearch = $("#search-tag .search-input").val();
if (name.includes(stringSearch.toLowerCase())) {
return true;
} else {
return false;
}
}

I also use the includes function instead of the startWith function. This means that the search pattern is also searched for within the keyword. Find that personally more comfortable.

From version 11.0.0 the search for keywords in the keyword manager is no longer possible. The reason for this is a missing "toLowerCase" in the JavaScript function isDataSearched in the file admin/default/js/tags.js My fixed version: function isDataSearched(tagObj) { let name = tagObj.name.toLowerCase(); let stringSearch = $("#search-tag .search-input").val(); if (name.includes(stringSearch.toLowerCase())) { return true; } else { return false; } } I also use the includes function instead of the startWith function. This means that the search pattern is also searched for within the keyword. Find that personally more comfortable. <!-- github-sync-id:801436416 -->
adam closed this issue 2026-10-05 00:33:09 +02:00
adam commented 2026-10-05 00:33:10 +02:00
Author
Owner
Copy link
Copy source

Oh, yes thanks, that will fix #1315

I agree, includes is better than startsWith here.

Oh, yes thanks, that will fix #1315 I agree, `includes` is better than `startsWith` here. <!-- github-comment-id:773566685 -->
adam commented 2026-10-05 00:33:11 +02:00
Author
Owner
Copy link
Copy source

Thank you, that sounds good

Thank you, that sounds good <!-- github-comment-id:773872767 -->
adam changed title from Search in Keyword Manager not working to Search in Keyword Manager not working 2026-10-27 11:18:18 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/Piwigo#1148