Issue #1167 : Fixes and code cleaning

This commit is contained in:
Zacharie
2020-05-14 10:43:54 +02:00
committed by plegall
parent df46475e1b
commit c4b38d1a41
5 changed files with 27 additions and 14 deletions
+12 -5
View File
@@ -2454,7 +2454,14 @@ SELECT name
return $groupname;
}
function delete_groups($group_ids) {
function delete_groups($group_ids)
{
if (count($group_ids) == 0)
{
trigger_error('There is no group to delete', E_USER_WARNING);
return false;
}
$group_id_string = implode(',', $group_ids);
@@ -2462,7 +2469,7 @@ function delete_groups($group_ids) {
$query = '
DELETE
FROM '. GROUP_ACCESS_TABLE .'
WHERE group_id IN('. $group_id_string .')
WHERE group_id IN ('. $group_id_string .')
;';
pwg_query($query);
@@ -2470,14 +2477,14 @@ DELETE
$query = '
DELETE
FROM '. USER_GROUP_TABLE .'
WHERE group_id IN('. $group_id_string .')
WHERE group_id IN ('. $group_id_string .')
;';
pwg_query($query);
$query = '
SELECT id, name
FROM `'. GROUPS_TABLE .'`
WHERE id IN('. $group_id_string .')
WHERE id IN ('. $group_id_string .')
;';
$group_list = query2array($query, 'id', 'name');
@@ -2487,7 +2494,7 @@ SELECT id, name
$query = '
DELETE
FROM `'. GROUPS_TABLE .'`
WHERE id IN('. $group_id_string .')
WHERE id IN ('. $group_id_string .')
;';
pwg_query($query);
+1 -1
View File
@@ -494,7 +494,7 @@ input:focus + .slider {
border-left:1px solid #e6e6e6;
}
.OrangeBackground{
.GroupBackgroudSelected{
background-color:#ffd7ad!important;
}
+5 -2
View File
@@ -236,7 +236,7 @@ var toogleSelection = function(group_id, toggle) {
groupBox = $("#group-"+group_id);
if (toggle) {
groupBox.find(".Group-checkbox input").attr("checked", true);
groupBox.addClass("OrangeBackground");
groupBox.addClass("GroupBackgroudSelected");
groupBox.find(".icon-users-1").addClass("OrangeIcon");
groupBox.find(".group_number_users").addClass("OrangeFont");
@@ -260,7 +260,7 @@ var toogleSelection = function(group_id, toggle) {
option.appendTo("#MergeOptionsChoices");
} else {
groupBox.find(".Group-checkbox input").attr("checked", false);
groupBox.removeClass("OrangeBackground");
groupBox.removeClass("GroupBackgroudSelected");
groupBox.find(".icon-users-1").removeClass("OrangeIcon");
groupBox.find(".group_number_users").removeClass("OrangeFont");
$(".DeleteGroupList div").each(function () {
@@ -537,6 +537,8 @@ $('.ConfirmMergeButton').on("click", function() {
}))
})
toogleSelection(dest_grp, false)
$(".DeleteGroupList").html("");
$("#MergeOptionsChoices").html("");
$("#group-"+dest_grp + " .group_number_users").html("<i class='icon-spin6 animate-spin'> </i>");
jQuery.ajax({
@@ -593,6 +595,7 @@ $('.ConfirmDeleteButton').on("click", function() {
backgroundDismiss: true,
});
})
});
/*-------
Manage User Part
+1 -1
View File
@@ -508,7 +508,7 @@ input:focus + .slider {
border-left:1px solid #1a1a1a;
}
.OrangeBackground{
.GroupBackgroudSelected{
background-color:#f9852c!important;
}