Commit Graph

216 Commits

Author SHA1 Message Date
Alexey Sokolov 688645413c Fix integration test after switch to libera 2021-06-18 21:20:53 +01:00
Alexey Sokolov e7b6a771c6 Hide password in PASS debug lines without : in trailing param 2021-06-01 21:58:07 +01:00
Alexey Sokolov fd71a69fab Rewrite message parsing using string_view
It's a bit too early yet to require C++17 so the implementation from
BackportCpp (string_view-standalone) is used instead.

Fixes https://crbug.com/oss-fuzz/34413 - slow message parsing on huge
messages. In real word, messages can't be that big, because CSocket
enforces a line length limit.

This can be considered a regression of 1.7.0, because before it, instead
of gathering params into a vector, code was searching 1st word in the
string, then 2nd word, then 3rd word, starting from beginning each time.
It was not very efficient, but the number of passes over the string was
limited.
2021-05-22 09:57:04 +01:00
MAGIC 99687b0f24 Welcome to 2021 2021-01-01 19:37:07 +01:00
Alexey Sokolov 1580140b3b Merge branch 'reorder' 2020-10-04 20:40:45 +01:00
njhanley 99b33eade9 Add MoveChan and SwapChans commands 2020-09-29 19:32:45 -04:00
Alexey Sokolov 47e633b267 Don't load modperl as a python module
Close #1757
2020-09-17 23:08:19 +01:00
njhanley 926d140a47 Respect order of subconfigs in znc.conf 2020-09-03 00:27:15 -04:00
NuclearW cf5472644a Add test for account-tag capability 2020-08-03 14:34:16 -04:00
Alexey Sokolov dff01490ca Merge branch '1.8.x' 2020-05-31 11:49:10 +01:00
Alexey Sokolov 2390ad111b Fix null pointer dereference in echo-message
The bug was introduced while fixing #1705. If a client did not enable
echo-message, and doesn't have a network, it crashes.

Thanks to LunarBNC for reporting this
2020-05-31 11:45:40 +01:00
Alexey Sokolov b3b38956a7 Rewrite how modpython loads modules
'imp' was deprecated since python 3.3.
This removes the undocumented feature of loading python C extension as
ZNC module, but adds a test that python package can be loaded.

Bump python requirements to 3.4
2020-05-23 13:32:50 +01:00
Alexey Sokolov 8717badcfc Try fix flaky ZNCTest.AwayNotify 2020-04-21 23:09:11 +01:00
Alexey Sokolov e801c49740 Test #1715 2020-04-20 20:51:07 +01:00
Alexey Sokolov b1d4cb0ae5 Add test for sasl module 2020-03-29 13:46:59 +01:00
Alexey Sokolov d229761821 Fix echo-message for *status
Close #1705
2020-03-29 08:45:10 +01:00
Alexey Sokolov f3d7922499 Update copyright in files which were missing in the previous update 2020-01-05 11:37:51 +00:00
Alexey Sokolov 34645658ab CMake: stop requiring C compiler 2020-01-05 11:28:49 +00:00
MAGIC 9081aa971d Welcome to 2020 2020-01-02 00:36:05 +01:00
Alexey Sokolov 16c849daac Fix crash when parsing incorrect channel modes sent by server.
Sometimes certain servers don't send a argument for modes which it
declared as ones which need an argument.

No released version is affected.

Close #1684
2019-11-07 08:36:41 +00:00
Alexey Sokolov b8b62a14ab Merge branch '1.7.x' 2019-11-06 08:46:05 +00:00
Alexey Sokolov c106d430eb Fix my recent fix and pass the parameter correctly 2019-11-06 00:00:34 +00:00
Alexey Sokolov 413f0d302f Merge branch '1.7.x' 2019-11-05 21:02:44 +00:00
Alexey Sokolov 961881b032 Build integration test with the same compiler
Fix https://bugs.gentoo.org/699258
2019-11-05 21:01:57 +00:00
Aspen (linudaemon) 95369455fc Rework MODE/RPL_CHANMODEIS handling for trailing args (#1661)
Some servers may send a colon even if the last parameter doesn't need it, currently this leads to issues with permission/mode tracking, as the core doesn't handle the colon properly.

This fix replaces reconstructing the parameter string with just passing a vector of the relevant parameters to CChan::SetModes() and adds overrides for CChan::SetModes() and CChan::ModeChange() that accept the vector instead.

Clean up uses of old CModeMessage::GetModes()
2019-08-08 21:54:49 +01:00
Jonathan Herlin e99cad4c25 Fix crypt module test (#1673) 2019-07-05 20:03:46 +01:00
Alexey Sokolov 0370efe830 Merge branch '1.7.x' 2019-04-19 12:15:14 +01:00
Alexey Sokolov 964747e6b4 Increase znc-buildmod timeout in the test.
For some slow systems 30s is too small.
2019-04-19 12:13:44 +01:00
Alexey Sokolov 8d309bbb3d Merge branch '1.7.x' 2019-03-30 16:17:59 +00:00
Alexey Sokolov 64613bc8b6 Don't crash if user specified invalid encoding.
This is CVE-2019-9917
2019-03-22 00:22:00 +00:00
Alexey Sokolov 0ab205ccfa Merge pull request #1628 from dgw/welcome-to-2019
Welcome to 2019
2019-01-08 22:50:58 +00:00
dgw 8d5427cf9b Welcome to 2019
What are we going to do today, Brain?

The same thing we do every year, Pinky: Update all the copyright
headers!

[Skip CI]
2019-01-01 17:05:05 -06:00
Pierre Gordon 6af027c5dd Normalize methods with 'UserName' to 'Username' 2019-01-01 16:19:27 -05:00
Alexey Sokolov abee9f9bfc Fix a warning in integration test / gmake / znc-buildmod interaction.
It was requested on https://github.com/gentoo/gentoo/pull/8901
2018-06-28 23:57:29 +01:00
Alexey Sokolov ff8b629884 Don't throw from destructor in the integration test 2018-06-20 01:28:46 +01:00
Alexey Sokolov 4b92790562 Fix #1543 for modperl too
While at it, fix a memory leak in NV handling

Add some tests
2018-06-04 22:03:10 +01:00
Alexey Sokolov c6a04023a4 Reformat test 2018-04-04 01:21:09 +01:00
Alexey Sokolov f3ddbccedd Fix unit test after string changes 2018-04-02 12:19:01 +01:00
Alexey Sokolov 1e08e5c702 Move gtest's printer for CString to a place visible to all tests 2018-04-02 12:17:14 +01:00
Alexey Sokolov d8327977ca Add socket test to modperl 2018-03-27 22:49:23 +01:00
Alexey Sokolov 6eaa93f8da Fix python sockets after latest changes.
The issue was triggered by CCoreTranslationMixin being parent of
CZNCSock, and DisableReadLine wasn't found as attribute anymore.

Thanks to obiw4n for report.
2018-03-27 22:26:05 +01:00
Alexey Sokolov 5cb50eccd1 Save channel key on user JOIN even if user was not on the channel yet,
which is the usual case.

Fix #1223
2018-02-14 08:30:21 +00:00
Alexey Sokolov 986bb8dc6d Add test for away-notify and cap-notify
Fix #1360
2018-02-13 21:55:32 +00:00
Alexey Sokolov 70dabc07dc Split integration test file to several files. 2018-02-13 21:25:17 +00:00
Alexey Sokolov e3a1308a04 Make order of EXPECT_EQ more natural, after upgrade to new GTest. 2018-02-13 08:41:53 +00:00
Alexey Sokolov c30e5ef9fd Fix tests for #1402 2018-02-12 09:04:50 +00:00
Alexey Sokolov 5a09a81c35 Fix interaction between crypt and echo-message.
Close #1481
2018-02-11 14:17:51 +00:00
Alexey Sokolov 9ff4127e33 Merge branch 'master' of github.com:znc/znc 2018-02-09 20:41:58 +00:00
Alexey Sokolov 01507188c3 Update googletest to latest version and cleanup integration test.
https://github.com/google/googletest/pull/1439 makes it possible to
remove horrible hacks I wrote before.
2018-02-09 20:40:28 +00:00
Falk Seidel d647eaabc0 Welcome to 2018
The same procedure as last year, Miss Sophie?
The same procedure as every year, James.

[skip ci]
2018-01-19 19:38:58 +00:00