Commit Graph

473 Commits

Author SHA1 Message Date
Alexey Sokolov 676d105347 Workaround gitter for 1.6
It's fixed properly for 1.7 already.
Fix #1321
2016-11-17 23:45:25 +00:00
William Elwood 853dcc211d Fix use of a feature deprecated in OpenSSL 1.1
If OpenSSL 1.1 is configured in such a way that features deprecated in 1.1.0 are not built, then compile errors would result here.
2016-09-13 11:51:13 +01:00
William Elwood 6a5c2c649d Fix use of a feature deprecated in OpenSSL 0.9.8
If OpenSSL 1.1 is configured in such a way that features deprecated in 0.9.8 are not built, then compile errors would result here.
I also noticed a potential memory leak where pRSA was not always freed before early return from this function - fixed by using C++11 unique_ptr.
2016-09-13 11:50:40 +01:00
William Elwood 03775fcdc5 Fix compile errors caused by OpenSSL 1.1 2016-09-12 23:39:19 +01:00
Alexey Sokolov debfdf6c02 Fix build on OS X after fixing build on Cygwin 2016-09-09 00:17:20 +01:00
Alexey Sokolov aff7e25043 Fix cygwin build
(cherry picked from commit f1ef8c79db)
2016-08-13 09:55:00 +01:00
Alexey Sokolov 71cdb81fe8 Don't save ZNC version to config as part of quit message.
Introduce one more string for ExpandString.

Fix #1244
2016-02-18 22:18:08 +00:00
Alexey Sokolov 5d014193b4 Don't require reconnect after changing encoding. 2016-01-09 18:18:44 +00:00
Alexey Sokolov 901ead89d5 Fix 404 when accessing web UI with the prefix, but without ending /
Thanks, txtsd
2015-12-30 16:13:19 +00:00
Alexey Sokolov c8edabb035 Fix memory leak when reading invalid znc.conf
Found by https://scan.coverity.com/
2015-10-30 14:36:01 +00:00
Jos Ahrens 0b32da4ccc Always try to delete an uppercase CTCP response in DelCtcpReply
AddCtcpReply always adds an CTCP response in uppercase, it is only fair we do the same in DelCtcpReply
2015-09-01 21:37:14 +02:00
J-P Nurmi d2c462ae03 Fix yet another startup failure with awaynick & simple_away
The detection whether simple_away is already on the list of loaded
modules failed when the simple_away load line contained arguments.

Close #954
2015-08-29 21:13:52 +02:00
J-P Nurmi 0220979ccf Fix #124: OnChanMsg(): nick doesn't have perms 2015-08-11 23:29:19 +02:00
J-P Nurmi 45183612c8 Fix CClient::GetNickMask()
A regression introduced by cebc093. A potentially empty network
specific bind _host_ should not be used as nick mask _ident_.
2015-08-11 14:06:41 +02:00
J-P Nurmi ad99d5f46e Merge pull request #1013 from DarthGandalf/cap-end
Support "CAP :END"
2015-08-01 12:33:26 +02:00
Alexey Sokolov 89e99bfe35 Support "CAP :END"
Thanks to jaybe for complaining about this.
2015-07-30 22:01:11 +01:00
J-P Nurmi b2c83321ef Fix #1008: Channel keys get saved in a very wrong way 2015-07-27 02:06:21 +02:00
Alexey Sokolov bae8724a16 Fix build after previous commit... 2015-07-07 22:26:56 +01:00
Alexey Sokolov 326040cf08 Fix query buffer size for users who has 0 in default channel buffer size.
Users who upgrade from <=1.4 to 1.6.0 and have configured 0 for channel buffer, were silently not getting any queries while disconnected anymore.
Thanks to jpnurmi for the idea how to bandaid this in 1.6.x branch.
Proper fix will go to 1.7 and will take form of separate settings for channel and query buffers.

See #967
2015-07-07 20:58:56 +01:00
Pavel Djundik 3bc7b820ac Don't print local ip address on 404 page, fixes #944
(cherry picked from commit 01279a4efa)
2015-07-07 20:07:02 +01:00
J-P Nurmi 28393c309b Fix #954: Startup failure when simple_away is loaded after awaynick 2015-04-28 21:36:25 +01:00
Alexey Sokolov 00404b8cbb Revert "Make tables... not so tabular."
This reverts commit 2c3064fb56.
2015-04-18 17:38:56 +01:00
Alexey Sokolov cd1f334f31 Update error message about --datadir
Noone remembers these days that at some point ZNC supported using the
same config directory, but different znc.conf. So now the old message is
just confusing.

However, nowadays many people confuse "/znc foo" in IRC client with
"znc foo" in shell.
2015-04-17 22:56:35 +01:00
Alexey Sokolov 7c64eba693 Last commit broke async auth, e.g. via imapauth. Fix it.
See #946
2015-04-16 20:31:31 +01:00
Alexey Sokolov 0167a827a7 Fix compilation warning 2015-04-16 01:23:57 +01:00
Alexey Sokolov eedcd4c4de Fix rare conflict of HTTP-Basic auth and cookies.
Fix #946
2015-04-16 01:21:57 +01:00
Alexey Sokolov c7b2aea7da Make help non-table more compact. 2015-04-09 21:25:42 +01:00
Alexey Sokolov 2c3064fb56 Make tables... not so tabular.
Fix #743
Fix #914
Close #922
2015-04-09 07:34:00 +01:00
Alexey Sokolov 21834d3aba Improve breadcrumbs in webadmin.
Fix #227
2015-04-06 22:40:55 +01:00
Alexey Sokolov 4596d97502 Remove "-" between "ZNC" and version number.
ZNC 1.6.0 looks better than ZNC - 1.6.0, IMHO
2015-04-06 20:41:57 +01:00
Eli Young 53254173b1 Write config file when channel is removed (#932) 2015-03-31 17:57:30 -07:00
J-P Nurmi 4935ef4d26 Fix compilation warning when HAVE_LIBSSL is not defined
Building core object Socket...
    src/Socket.cpp:30:16: warning: unused function 'ZNC_DefaultCipher' [-Wunused-function]
    static CString ZNC_DefaultCipher() {
                   ^
    1 warning generated.
2015-02-25 09:36:56 +01:00
J-P Nurmi 7345a6ee3a Fix CIRCNetwork::FindChans() and FindQueries() to be case-insensitive
The playback module failed to clear a buffer, because it tried to
clear "NickServ" whereas ZNC had internally stored it has "nickserv".
2015-02-19 08:45:58 +01:00
Uli Schlachter 5f9ad5cc87 SSLVerifyHost: Make some functions static
These functions shouldn't be visible outside of this file. This was caught by
-Werror=missing-declarations.

Signed-off-by: Uli Schlachter <psychon@znc.in>
2015-02-19 08:39:22 +01:00
Uli Schlachter fd34f84bfd ~CThreadPool(): Handle spurious wakeups
From pthread_cond_wait()'s man page:

  When using condition variables there is always a boolean predicate involving
  shared variables associated with each condition wait that is true if the
  thread should proceed. Spurious wakeups from the pthread_cond_wait() or
  pthread_cond_timedwait() functions may occur. Since the return from
  pthread_cond_wait() or pthread_cond_timedwait() does not imply anything about
  the value of this predicate, the predicate should be re-evaluated upon such
  return.

Fix ~CThreadPool() to account for this possibility.

Signed-off-by: Uli Schlachter <psychon@znc.in>
2015-02-19 08:38:28 +01:00
J-P Nurmi 7680421053 Fix #840 - channel hopping/cycling
A regression caused by aed1d61.
2015-02-02 10:41:13 +01:00
Alexey Sokolov d4a36aaa93 Fix crash in znc --version, caused by latest commits.
Fix #838
2015-02-01 15:36:31 +00:00
Alexey Sokolov ff88f24494 Merge branch 'version' 2015-02-01 09:23:41 +00:00
Alexey Sokolov cf6ec5646b Add ZNC to CTCP VERSION reply even if client is connected.
Previously, it replied to CTCP VERSION, but only if no client is connected.

See https://github.com/znc/znc/issues/820#issuecomment-70506203
2015-01-31 10:01:27 +00:00
Alexey Sokolov f9a4507669 Add a global setting whether to show ZNC version or not
Close #820
Close #821
2015-01-30 23:01:06 +00:00
Alexey Sokolov cbbd18cc6b Merge pull request #823 from Zarthus/pass-patch
Tell user to use PASS <username>/<network> instead of just the username.
2015-01-26 23:13:16 +00:00
OGAWA Hirofumi b8dcb5f706 Don't polling to wait the exit of threads in CThreadPool destructor
All values are protected by m_mutex. So we don't need the polling to
wait m_num_threads==0 with wakeups, instead simply use CConditionVariable.
2015-01-25 21:55:42 +09:00
Jos 26e466c677 More detailed instructions on how to connect to ZNC when not yet logged in.
The message now mentions you should configure your client to automatically log you in, and also lets you know how to connect to a specific network.
2015-01-25 10:25:13 +01:00
Jos 35b5525cc1 Tell user to use PASS <username>/<network> instead of just the username.
In versions prior to 1.0, ZNC did not allow multiple networks per user. The string telling users to connect has never been changed after ZNC 1.0, and this fixes just that.
2015-01-24 11:40:51 +01:00
Alexey Sokolov 94f2b4dc97 Don't expose ZNC version in CTCP VERSION.
Thanks to Mikaela for finding this.
See #818
2015-01-18 08:15:34 +00:00
Alexey Sokolov 38353a67d7 Remove message which should be removed before release 2015-01-18 00:00:15 +00:00
J-P Nurmi 045f7752cb savebuff: save & load query buffers - fixes #802
The old internal storage format was:

    ::__:SAVEBUFF:__::<buffer lines>

The new storage format for channels:

    ::__:CHANBUFF:__::<buffer name>
    <buffer lines>

The new storage format for queries:

    ::__:QUERYBUFF:__::<buffer name>
    <buffer lines>

See #802 for details why the storage format had to be changed. Reading
the old storage format is still supported so old saved buffers load as
appropriate.
2015-01-16 21:13:44 +01:00
Alexey Sokolov 600f91f128 Fix implicit context of OnSendTo* hooks
Thanks for markus-j for reporting it
2015-01-11 17:08:00 +00:00
Alexey Sokolov 9166e6ed40 Move Csocket to git submodule 2015-01-03 12:45:12 +00:00
Edoardo Spadolini 507f9b3392 Follow SSL Cipher Server Preference 2015-01-02 23:40:15 +01:00