The CChan constructor makes sure that the channel name begins with a valid
channel prefix. Thus, this could change the name of the resulting channel.
When you edited an irc network which already had a channel "#foo", were
connected to IRC (so ZNC knows which prefixes are valid) and added a channel
"foo", this would lead to a problem:
Webadmin checks and sees that there is no channel "foo" yet. Webadmin creates a
new CChan instance for "foo". The CChan constructor notices that "f" is not a
valid channel prefix and instead calls itself "#foo". Then,
CIRCNetwork::AddChan() would see that this channel already exists, delete the
given channel and return false.
However, webadmin didn't check this result and would continue changing settings
on an already destroyed CChan instance.
Fix this by checking if the channel exists after CChan had its chance to mess
with the channel name. Also handle failures from CIRCNetwork::AddChan().
Fixes#528.
Signed-off-by: Uli Schlachter <psychon@znc.in>
On QuakeNet's ircd you can't unset user mode +x once set. But loading
the Q module will set it immediately, possibly requiring a reconnect
if you don't want to use a cloaked host.
Signed-off-by: Anders Bergh <anders1@gmail.com>
Use case: On QuakeNet you can /msg Q CHANLEV #chan <yourself> +j to
be invited once you authenticate. Anyone known on the channel (mode +k)
is able to set/unset chanlev +j for themselves.
Signed-off-by: Anders Bergh <anders1@gmail.com>
Although most browsers seem to accept relative redirects, it is not
allowed by HTTP/1.1.
This commit changes relative URIs to absolute ones when redirecting.
Prefix links in templates with URIPrefix and add the input field to the
Listener editor.
The URIPrefix is provided as a top-level template variable. All URIs
have been changed to have the prefix prepended.
Autocomplete should be desabled because in default web browsers fill this resoulting "Invalid user settings" message when for example user changes skin.
Apparently StarChat.net uses a very old (?) or obscure NickServ
service that doesn't send any of the more common prompts for ID.
(It also doesn't support nick grouping, more's the pity.)
