5925 Commits

Author SHA1 Message Date
Matt Smith
6203ae64ba Remove the word "either" (#1938)
This is likely there because there are two different paths
depending on if the module was loaded as a network or a user
module. But only one of them is printed here so either does
not make any sense.
2025-03-06 16:44:41 +01:00
Alexey Sokolov
ffcf3aed5f Merge branch 'master' into sasl 2025-03-01 15:32:30 +01:00
Alexey Sokolov
e8c4cda0e6 Fix syntax of the filter
Bug #1937
2025-03-01 14:27:22 +01:00
Alexey Sokolov
4c944344fa CI: disable another python test on mac
See #1937
2025-03-01 10:29:36 +01:00
Alexey Sokolov
2e685e6a1f CI: disable python test on mac
See #1937
2025-03-01 10:13:40 +01:00
Alexey Sokolov
9f8015b8ad Add several more tests to sasl 2025-02-28 20:48:24 +01:00
Alexey Sokolov
db5eeb1626 Merge branch 'master' into sasl 2025-02-25 18:44:52 +00:00
Alexey Sokolov
a85533b15a Merge branch 'master' of github.com:znc/znc 2025-02-25 18:44:25 +00:00
Alexey Sokolov
843b40becc Merge branch 'master' into sasl 2025-02-25 18:42:51 +00:00
Alexey Sokolov
fc0dd1431f fix flaky chghost test 2025-02-25 18:41:02 +00:00
Alexey Sokolov
37457105f3 Support SASL EXTERNAL in certauth 2025-02-24 22:52:47 +00:00
Alexey Sokolov
8778a2bb5d Parse network and client from authzid. Tests will be in future commit 2025-02-24 09:21:30 +00:00
Alexey Sokolov
ed20d489b6 Apply suggestions from code review
Co-authored-by: dgw <dgw@technobabbl.es>
2025-02-23 22:41:01 +01:00
Alexey Sokolov
4f07558a7d Remove a footgun by decreasing the SASL API surface for modules
Even without the bad vtable of mutex inside shared_ptr, if a module
creates a subclass of CAuthBase, but then unloads, we have the same
problem.
2025-02-23 09:25:24 +00:00
Giovanni
ab763a7b99 CMake: use cmake_{push,pop}_check_state() (#1933) 2025-02-23 01:30:48 +01:00
Alexey Sokolov
af21753901 Rename saslplain to saslplainauth for consistency with other auth
modules
2025-02-22 16:03:46 +00:00
Alexey Sokolov
6e9980d67f Various SASL changes 2025-02-22 15:59:52 +00:00
Alexey Sokolov
99a5a52fea fail2ban: Reset the counter upon successful login
This is for SASL: when multiple mechanisms available it's kinda expected
that some of them can fail, e.g. if client attempted EXTERNAL without
providing the cert first.
2025-02-15 00:17:24 +00:00
Alexey Sokolov
4ef64eb4d5 rename next sasl module hook 2025-02-13 21:36:07 +00:00
Alexey Sokolov
c8266aafda Rename new callback, fix build 2025-02-13 21:22:09 +00:00
Alexey Sokolov
22f27b2e88 Fix indentation of SASL code.
This should help understanding what it's trying to do.
2025-02-13 21:03:16 +00:00
Alexey Sokolov
c6ae8d16e5 saslplain: use CZNC::AuthUser()
1. this should work better with modules such as imapauth
2. it fixes a null pointer dereference when the username wasn't found

This module won't work as is yet, and has some other obvious issues with
this approach, but was a good starting point.
2025-02-13 20:56:02 +00:00
Alexey Sokolov
41a0030fdb Merge branch 'master' into sasl
Conflicts:
	include/znc/Client.h
	src/Client.cpp
	src/Modules.cpp
	test/integration/tests/modules.cpp
2025-02-13 20:37:32 +00:00
Peter
44e4b95a20 Welcome to 2025 (#1929) 2025-02-07 23:23:45 +00:00
Alexey Sokolov
dd99d3e950 simplify test 2024-12-29 15:16:27 +00:00
Alexey Sokolov
7c616f10ee Avoid allocating useless vector in a loop
Ref #1924
2024-12-29 15:00:20 +00:00
Alexey Sokolov
579906d686 Don't send emulated chghost-JOIN to channels where the nick wasn't
Fix #1924
2024-12-29 14:54:20 +00:00
Alexey Sokolov
1224d303aa Don't emulate chghost for disabled channels
Bug #1924
2024-12-29 10:12:10 +00:00
dependabot[bot]
bfd731cfc6 Bump docker/build-push-action from 5 to 6 (#1920)
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5 to 6.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](https://github.com/docker/build-push-action/compare/v5...v6)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-01 15:55:41 +00:00
dependabot[bot]
f894af5330 Bump codecov/codecov-action from 3 to 4 (#1903)
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/codecov/codecov-action/compare/v3...v4)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-16 01:28:02 +01:00
dependabot[bot]
309aa787ca Bump actions/upload-artifact from 3 to 4 (#1902)
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-10-16 01:27:36 +01:00
Alexey Sokolov
20c540af7d Make CHGHOST work with detached channels 2024-10-15 17:16:32 +01:00
Alexey Sokolov
b536d0f3c3 Small optimization for message processing
Avoid creating the map for every message
2024-10-15 13:26:20 +01:00
Alexey Sokolov
9dcd44a15f Make code a bit clearer
Reference doesn't help here due to ?: operator, but it makes one think
that it helps
2024-10-15 13:26:20 +01:00
Alexey Sokolov
d49399bbca Implement chghost capability
Interaction with extended-join doesn't yet work correctly, because ZNC
doesn't keep track of everyone's real names
2024-10-15 13:26:20 +01:00
Alexey Sokolov
25b19bb889 modperl: remove given/when
new perl version removes this feature
2024-10-13 21:35:30 +01:00
Alexey Sokolov
a3867d100f unify indents in startup.pl 2024-10-13 21:27:42 +01:00
Alexey Sokolov
fcef28737e CI: update freebsd image 2024-10-13 21:12:59 +01:00
Alexey Sokolov
afefc048d0 Simply disconnect if SASL not available on server
Instead of disabling network

This unavailability could be temporarily

Fix #1918
2024-10-13 19:22:48 +01:00
Alexey Sokolov
9e9d75c4b8 Switch integration test to qt6 (#1916)
Keep using Qt5 for Cygwin and CodeQL

* CI: upgrade ubuntu
2024-09-17 15:24:33 +01:00
Alexey Sokolov
0506e95a74 Merge branch '1.9.x' 2024-07-03 16:16:12 +01:00
Alexey Sokolov
25fa7a514f Return version number to 1.9.x 2024-07-03 16:14:25 +01:00
Alexey Sokolov
ae353acf2f ZNC 1.9.1 znc-1.9.1 2024-07-03 11:19:33 +01:00
Alexey Sokolov
8cbf8d6281 Fix RCE vulnerability in modtcl
Remote attacker could execute arbitrary code embedded into the kick
reason while kicking someone on a channel.

To mitigate this for existing installations, simply unload the modtcl
module for every user, if it's loaded.
Note that only users with admin rights can load modtcl at all.

While at it, also escape the channel name.

Discovered by Johannes Kuhn (DasBrain)

Patch by https://github.com/glguy

CVE-2024-39844
2024-07-01 10:27:49 +01:00
Alexey Sokolov
9372430e2c Merge pull request #1907 from 4G3NT/1.9.x
Fix casing
2024-04-11 08:06:09 +01:00
4G3NT
d6605d199e Fix casing on traffic info table 2024-04-10 22:56:29 -07:00
4G3NT
1e89f7b4ba Fix casing 2024-04-10 22:38:23 -07:00
Alexey Sokolov
82e82f0bf6 Merge branch '1.9.x' 2024-04-09 22:51:50 +01:00
Alexey Sokolov
207eaf4b1e Fix title case of tooltips
Close #1906
2024-04-09 22:49:00 +01:00
4G3NT
8b768593b1 Add a helpful tooltip 2024-04-09 22:47:12 +01:00