iarv/znc
1
0
Fork 0
mirror of https://github.com/znc/znc.git synced 2026-05-07 13:54:47 +02:00
Code Issues Packages Projects Releases Wiki Activity

Make list of languages installed discoverable at runtime.

Browse Source 
Stop hardcoding Russian in webadmin.
Limit the setting in controlpanel to the known languages, because
untrusted language code might lead to some interesting vulnerabilities.
This commit is contained in:
Alexey Sokolov
2017-08-19 18:05:47 +01:00
parent 328461faf1
commit f885699d1a
6 changed files with 65 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/webadmin.cpp
+11 -5
View File
@@ -316,7 +316,11 @@ class CWebAdminMod : public CModule {
pNewUser->SetNoTrafficTimeout(uNoTrafficTimeout);
#ifdef HAVE_I18N
pNewUser->SetLanguage(WebSock.GetParam("language"));
CString sLanguage = WebSock.GetParam("language");
if (CTranslationInfo::GetTranslations().count(sLanguage) == 0) {
sLanguage = "";
}
pNewUser->SetLanguage(sLanguage);
#endif
#ifdef HAVE_ICU
CString sEncodingUtf = WebSock.GetParam("encoding_utf");
@@ -1376,13 +1380,15 @@ class CWebAdminMod : public CModule {
#ifdef HAVE_I18N
Tmpl["HaveI18N"] = "true";
// TODO don't have them hardcoded here
// TODO maybe stop hardcoding English here
CTemplate& l_en = Tmpl.AddRow("LanguageLoop");
l_en["Code"] = "";
l_en["Name"] = "English";
CTemplate& l_ru = Tmpl.AddRow("LanguageLoop");
l_ru["Code"] = "ru-RU";
l_ru["Name"] = "Russian";
for (const auto& it : CTranslationInfo::GetTranslations()) {
CTemplate& lang = Tmpl.AddRow("LanguageLoop");
lang["Code"] = it.first;
lang["Name"] = it.second.sSelfName;
}
#else
Tmpl["HaveI18N"] = "false";
#endif