From 535d28bf3268f6143325ea38854067ac41842c8c Mon Sep 17 00:00:00 2001 From: Mikaela Suomalainen Date: Sun, 13 Sep 2015 15:15:24 +0300 Subject: [PATCH 1/4] route_replies: make the error more clear --- modules/route_replies.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/route_replies.cpp b/modules/route_replies.cpp index 6d44a67b..7a42464c 100644 --- a/modules/route_replies.cpp +++ b/modules/route_replies.cpp @@ -369,7 +369,8 @@ public: // The timer will be deleted after this by the event loop if (!GetNV("silent_timeouts").ToBool()) { - PutModule("This module hit a timeout which is possibly a bug."); + PutModule("This module hit a timeout which is probably a connectivity issue."); + PutModule("However, if you can provide steps to reproduce this issue, please do report a bug."); PutModule("To disable this message, do \"/msg " + GetModNick() + " silent yes\""); PutModule("Last request: " + m_sLastRequest); From f1cc0e44923a87138ff87f5bac62d8c03af8f3ef Mon Sep 17 00:00:00 2001 From: Mikaela Suomalainen Date: Sun, 20 Sep 2015 16:28:50 +0300 Subject: [PATCH 2/4] lastseen & certauth & route_replies: add missing descriptions --- modules/certauth.cpp | 2 +- modules/lastseen.cpp | 2 +- modules/route_replies.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/certauth.cpp b/modules/certauth.cpp index 30448f0b..3e5fe93b 100644 --- a/modules/certauth.cpp +++ b/modules/certauth.cpp @@ -32,7 +32,7 @@ public: "[pubkey]", "If pubkey is not provided will use the current key"); AddCommand("Del", static_cast(&CSSLClientCertMod::HandleDelCommand), "id"); - AddCommand("List", static_cast(&CSSLClientCertMod::HandleListCommand)); + AddCommand("List", static_cast(&CSSLClientCertMod::HandleListCommand),"", "List your public keys"); AddCommand("Show", static_cast(&CSSLClientCertMod::HandleShowCommand), "", "Print your current key"); } diff --git a/modules/lastseen.cpp b/modules/lastseen.cpp index 44055421..3df2d392 100644 --- a/modules/lastseen.cpp +++ b/modules/lastseen.cpp @@ -70,7 +70,7 @@ private: public: MODCONSTRUCTOR(CLastSeenMod) { AddHelpCommand(); - AddCommand("Show", static_cast(&CLastSeenMod::ShowCommand)); + AddCommand("Show", static_cast(&CLastSeenMod::ShowCommand),"", "Shows list of users and when they last logged in"); } virtual ~CLastSeenMod() {} diff --git a/modules/route_replies.cpp b/modules/route_replies.cpp index 6d44a67b..f667a047 100644 --- a/modules/route_replies.cpp +++ b/modules/route_replies.cpp @@ -218,7 +218,7 @@ public: AddHelpCommand(); AddCommand("Silent", static_cast(&CRouteRepliesMod::SilentCommand), - "[yes|no]"); + "[yes|no]", "Decides whether to show the timeout messages or not"); } virtual ~CRouteRepliesMod() { From 3c2ec45d4c11851e5eb8c612972bf3b578ea1cf3 Mon Sep 17 00:00:00 2001 From: J-P Nurmi Date: Sun, 20 Sep 2015 17:30:48 +0200 Subject: [PATCH 3/4] Fix more warnings [-Winconsistent-missing-override] --- modules/bouncedcc.cpp | 2 +- modules/ctcpflood.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/bouncedcc.cpp b/modules/bouncedcc.cpp index c802ebbe..ea207147 100644 --- a/modules/bouncedcc.cpp +++ b/modules/bouncedcc.cpp @@ -33,7 +33,7 @@ public: static unsigned short DCCRequest(const CString& sNick, unsigned long uLongIP, unsigned short uPort, const CString& sFileName, bool bIsChat, CBounceDCCMod* pMod, const CString& sRemoteIP); - void ReadLine(const CString& sData); + void ReadLine(const CString& sData) override; virtual void ReadData(const char* data, size_t len) override; virtual void ReadPaused() override; virtual void Timeout() override; diff --git a/modules/ctcpflood.cpp b/modules/ctcpflood.cpp index e3111366..45e3d142 100644 --- a/modules/ctcpflood.cpp +++ b/modules/ctcpflood.cpp @@ -42,7 +42,7 @@ public: SetArgs(CString(m_iThresholdMsgs) + " " + CString(m_iThresholdSecs)); } - bool OnLoad(const CString& sArgs, CString& sMessage) { + bool OnLoad(const CString& sArgs, CString& sMessage) override { m_iThresholdMsgs = sArgs.Token(0).ToUInt(); m_iThresholdSecs = sArgs.Token(1).ToUInt(); From c8ab811a29198c085228ea7047e23833bdddc4a7 Mon Sep 17 00:00:00 2001 From: Mikaela Suomalainen Date: Sat, 19 Sep 2015 09:59:40 +0300 Subject: [PATCH 4/4] cert: add description for the "info" command --- modules/cert.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/cert.cpp b/modules/cert.cpp index c3e98c00..e1c2a2bc 100644 --- a/modules/cert.cpp +++ b/modules/cert.cpp @@ -46,7 +46,7 @@ public: AddHelpCommand(); AddCommand("delete", static_cast(&CCertMod::Delete), "", "Delete the current certificate"); - AddCommand("info", static_cast(&CCertMod::Info)); + AddCommand("info", static_cast(&CCertMod::Info), "", "Show the current certificate"); } virtual ~CCertMod() {}