iarv/znc
1
0
Fork 0
mirror of https://github.com/znc/znc.git synced 2026-05-04 04:22:37 +02:00
Code Issues Packages Projects Releases Wiki Activity

work around Win32 rename() issue using native API

Browse Source
This commit is contained in:
Ingmar Runge
2014-02-06 18:06:29 +01:00
parent 4e5a45f73e
commit d80e989dba
1 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/FileUtils.cpp
View File

@@ -210,15 +210,9 @@ bool CFile::Move(const CString& sOldFileName, const CString& sNewFileName, bool
return false;
}
#ifdef _WIN32
// Windows (or maybe cygwin?) sometimes fails to rename() file over an existing file
// We don't want to remove the old file before moving new file over, for the case if the following rename() will fail for any reason
CString sTempFile = sNewFileName
+ CUtils::FormatTime(time(NULL), "_%Y%m%d-%H%M%S_", "UTC")
+ CString::RandomString(10).MD5(); // this file shouldn't exist :)
bool result = rename(sNewFileName.c_str(), sTempFile.c_str()) == 0;
result &&= rename(sOldFileName.c_str(), sNewFileName.c_str()) == 0;
result &&= Delete(sTempFile); // ok, renamed the file successfully, it's safe to remove backup of old file now
return result;
// rename() never overwrites files on Windows.
DWORD dFlags = MOVEFILE_WRITE_THROUGH | MOVEFILE_COPY_ALLOWED | MOVEFILE_REPLACE_EXISTING;
return (::MoveFileExA(sOldFileName.c_str(), sNewFileName.c_str(), dFlags) != 0);
#endif
}