iarv/znc
1
0
Fork 0
mirror of https://github.com/znc/znc.git synced 2026-05-04 12:32:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

Change default flood rates to match RFC1459, prevent excess flood problems

Browse Source 
I noticed that the default network flood rates are wrong (for most
networks). It has been very standard since the beginning of IRC to use a
value of 2 seconds per line, with a 10 line head start. Almost all
networks work this way, and if you don't follow, having a lot of
channels or a lot of clients connected to ZNC results in excess flood
disconnections and much frustration for the user.

I think you should make the default value for these 2 and 9 instead of 1
and 4 so that this nasty bug doesn't hit people who will not know how to
debug it. You find these same types of settings built into every IRC
client. 2 and 10 is the standard. 2 and 9 provides a slight buffer so
there is no mistake.

Thanks
-Rubin

Close #1416
This commit is contained in:
Rubin
2017-05-29 01:23:44 -07:00
committed by Alexey Sokolov
parent 10bfece38c
commit 96c92ef8ca
4 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/data/webadmin/tmpl/add_edit_network.tmpl
View File

@@ -135,7 +135,7 @@
<? SETBLOCK FloodInputField_Rate ?>
<input type="number" name="floodrate" min="0.3" step="0.05" id="floodrate"
title="<? FORMAT "The number of seconds per line. After changing this, reconnect ZNC to server." ?>"
<? IF FloodProtection ?> value="<? VAR FloodRate ?>" <? ELSE ?> value="1.00" disabled="disabled" <? ENDIF ?> />
<? IF FloodProtection ?> value="<? VAR FloodRate ?>" <? ELSE ?> value="2.00" disabled="disabled" <? ENDIF ?> />
<? ENDSETBLOCK ?>
<? FORMAT "{1} seconds per line" "FloodInputField_Rate ESC=" ?>
</div>
@@ -145,7 +145,7 @@
<? SETBLOCK FloodInputField_Burst ?>
<input type="number" name="floodburst" min="1" id="floodburst"
title="<? FORMAT "Defines the number of lines, which can be sent immediately. After changing this, reconnect ZNC to server." ?>"
<? IF FloodProtection ?> value="<? VAR FloodBurst ?>" <? ELSE ?> value="4" disabled="disabled" <? ENDIF ?> />
<? IF FloodProtection ?> value="<? VAR FloodBurst ?>" <? ELSE ?> value="9" disabled="disabled" <? ENDIF ?> />
<? ENDSETBLOCK ?>
<? FORMAT "{1} lines can be sent immediately" "FloodInputField_Burst ESC=" ?>
</div>