iarv/znc
1
0
Fork 0
mirror of https://github.com/znc/znc.git synced 2026-05-01 11:02:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

Improve code quality.

Browse Source
This commit is contained in:
Donal Cahill
2015-12-13 12:21:49 +00:00
parent a5540557ac
commit 56c97af14b
2 changed files with 23 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
test/UserTest.cpp
View File

@@ -25,8 +25,6 @@ class UserTest : public ::testing::Test {
};
TEST_F(UserTest, IsHostAllowed) {
CUser* m_pTestUser;
struct hostTest {
CString sTestHost;
CString sIP;
@@ -93,17 +91,11 @@ TEST_F(UserTest, IsHostAllowed) {
{"2001:db8::/32", "2001:db8:8000::", true},
{"2001:db8::/33", "2001:db8:8000::", false},
};
for (int i = 0; i < (int)(sizeof(aHostTests) / sizeof(aHostTests[0]));
++i) {
m_pTestUser = new CUser("user");
hostTest* h = aHostTests + i;
m_pTestUser->AddAllowedHost(h->sTestHost);
CString should = h->bExpectedResult ? "" : " not";
CString error = "Allow-host string \"" + h->sTestHost + "\" should" +
should + " allow host \"" + h->sIP + "\"";
EXPECT_EQ(m_pTestUser->IsHostAllowed(aHostTests[i].sIP),
aHostTests[i].bExpectedResult)
<< error;
delete m_pTestUser;
for (const hostTest& h : aHostTests) {
CUser pTestUser("user");
pTestUser.AddAllowedHost(h.sTestHost);
EXPECT_EQ(h.bExpectedResult, pTestUser.IsHostAllowed(h.sIP))
<< "Allow-host is " << h.sTestHost;
}
}