From 2d1a63291092d26b35ad047fc6d7d6721f8b840c Mon Sep 17 00:00:00 2001 From: Conor O'Gorman Date: Wed, 1 Jan 2014 16:07:25 +0000 Subject: [PATCH 1/2] fix #235, erroric console output, status message overwrite using alternative message style otherwise ncurses/terminal codes for cursor position would seem necessary --- src/Utils.cpp | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/src/Utils.cpp b/src/Utils.cpp index 49c6ea30..cb882a79 100644 --- a/src/Utils.cpp +++ b/src/Utils.cpp @@ -306,7 +306,7 @@ void CUtils::PrintMessage(const CString& sMessage, bool bStrong) { void CUtils::PrintAction(const CString& sMessage) { if (CDebug::StdoutIsTTY()) - fprintf(stdout, "\033[1m\033[34m[\033[32m \033[34m]\033[39m\033[22m %s... ", sMessage.c_str()); + fprintf(stdout, "\033[1m\033[34m[ .. \033[34m]\033[39m\033[22m %s...\n", sMessage.c_str()); else fprintf(stdout, "%s... ", sMessage.c_str()); fflush(stdout); @@ -314,21 +314,12 @@ void CUtils::PrintAction(const CString& sMessage) { void CUtils::PrintStatus(bool bSuccess, const CString& sMessage) { if (CDebug::StdoutIsTTY()) { - if (!sMessage.empty()) { - if (bSuccess) { - fprintf(stdout, "%s", sMessage.c_str()); - } else { - fprintf(stdout, "\033[1m\033[34m[\033[31m %s \033[34m]" - "\033[39m\033[22m", sMessage.c_str()); - } - } - - fprintf(stdout, "\r"); - if (bSuccess) { - fprintf(stdout, "\033[1m\033[34m[\033[32m ok \033[34m]\033[39m\033[22m\n"); + fprintf(stdout, "\033[1m\033[34m[\033[32m ok \033[34m]\033[39m\033[22m"); + fprintf(stdout, " %s\n", sMessage.empty() ? "ok" : sMessage.c_str()); } else { - fprintf(stdout, "\033[1m\033[34m[\033[31m !! \033[34m]\033[39m\033[22m\n"); + fprintf(stdout, "\033[1m\033[34m[\033[31m !! \033[34m]\033[39m\033[22m"); + fprintf(stdout, "\033[1m\033[31m %s\n", sMessage.empty() ? "failed" : sMessage.c_str()); } } else { if (bSuccess) { From dd0ba1def4651ac400e62a0ffa1d2a1921340547 Mon Sep 17 00:00:00 2001 From: Conor O'Gorman Date: Wed, 1 Jan 2014 18:08:31 +0000 Subject: [PATCH 2/2] define terminal control codes for messages, tidy, tweak ok message --- src/Utils.cpp | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/src/Utils.cpp b/src/Utils.cpp index cb882a79..b896733d 100644 --- a/src/Utils.cpp +++ b/src/Utils.cpp @@ -274,9 +274,18 @@ bool CUtils::GetInput(const CString& sPrompt, CString& sRet, const CString& sDef return !sRet.empty(); } +#define BOLD "\033[1m" +#define NORM "\033[22m" + +#define RED "\033[31m" +#define GRN "\033[32m" +#define YEL "\033[33m" +#define BLU "\033[34m" +#define DFL "\033[39m" + void CUtils::PrintError(const CString& sMessage) { if (CDebug::StdoutIsTTY()) - fprintf(stdout, "\033[1m\033[34m[\033[31m ** \033[34m]\033[39m\033[22m %s\n", sMessage.c_str()); + fprintf(stdout, BOLD BLU "[" RED " ** " BLU "]" DFL NORM" %s\n", sMessage.c_str()); else fprintf(stdout, "%s\n", sMessage.c_str()); fflush(stdout); @@ -284,7 +293,7 @@ void CUtils::PrintError(const CString& sMessage) { void CUtils::PrintPrompt(const CString& sMessage) { if (CDebug::StdoutIsTTY()) - fprintf(stdout, "\033[1m\033[34m[\033[33m ?? \033[34m]\033[39m\033[22m %s: ", sMessage.c_str()); + fprintf(stdout, BOLD BLU "[" YEL " ?? " BLU "]" DFL NORM " %s: ", sMessage.c_str()); else fprintf(stdout, "[ ?? ] %s: ", sMessage.c_str()); fflush(stdout); @@ -293,10 +302,10 @@ void CUtils::PrintPrompt(const CString& sMessage) { void CUtils::PrintMessage(const CString& sMessage, bool bStrong) { if (CDebug::StdoutIsTTY()) { if (bStrong) - fprintf(stdout, "\033[1m\033[34m[\033[33m ** \033[34m]\033[39m\033[22m \033[1m%s\033[22m\n", + fprintf(stdout, BOLD BLU "[" YEL " ** " BLU "]" DFL BOLD "%s" NORM "\n", sMessage.c_str()); else - fprintf(stdout, "\033[1m\033[34m[\033[33m ** \033[34m]\033[39m\033[22m %s\n", + fprintf(stdout, BOLD BLU "[" YEL " ** " BLU "]" DFL NORM " %s\n", sMessage.c_str()); } else fprintf(stdout, "%s\n", sMessage.c_str()); @@ -306,7 +315,7 @@ void CUtils::PrintMessage(const CString& sMessage, bool bStrong) { void CUtils::PrintAction(const CString& sMessage) { if (CDebug::StdoutIsTTY()) - fprintf(stdout, "\033[1m\033[34m[ .. \033[34m]\033[39m\033[22m %s...\n", sMessage.c_str()); + fprintf(stdout, BOLD BLU "[ .. " BLU "]" DFL NORM " %s...\n", sMessage.c_str()); else fprintf(stdout, "%s... ", sMessage.c_str()); fflush(stdout); @@ -315,11 +324,11 @@ void CUtils::PrintAction(const CString& sMessage) { void CUtils::PrintStatus(bool bSuccess, const CString& sMessage) { if (CDebug::StdoutIsTTY()) { if (bSuccess) { - fprintf(stdout, "\033[1m\033[34m[\033[32m ok \033[34m]\033[39m\033[22m"); + fprintf(stdout, BOLD BLU "[" GRN " >> " BLU "]" DFL NORM); fprintf(stdout, " %s\n", sMessage.empty() ? "ok" : sMessage.c_str()); } else { - fprintf(stdout, "\033[1m\033[34m[\033[31m !! \033[34m]\033[39m\033[22m"); - fprintf(stdout, "\033[1m\033[31m %s\n", sMessage.empty() ? "failed" : sMessage.c_str()); + fprintf(stdout, BOLD BLU "[" RED " !! " BLU "]" DFL NORM); + fprintf(stdout, BOLD RED " %s" DFL NORM "\n", sMessage.empty() ? "failed" : sMessage.c_str()); } } else { if (bSuccess) {