From 35458af905ca56576c8d4e689559f28996608a37 Mon Sep 17 00:00:00 2001 From: psychon Date: Wed, 4 Feb 2009 16:29:06 +0000 Subject: [PATCH] Make some functions in CHTTPSock pure virtual where it makes sense Or do you seriously expect anyone to set up a http which always replies with 404 File not found errors? git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1372 726aef4b-f618-498e-8847-2d620e286838 --- HTTPSock.cpp | 12 ------------ HTTPSock.h | 4 ++-- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/HTTPSock.cpp b/HTTPSock.cpp index f62f0a9b..93672ed0 100644 --- a/HTTPSock.cpp +++ b/HTTPSock.cpp @@ -283,10 +283,6 @@ const map& CHTTPSock::GetParams() const { return m_msvsParams; } -bool CHTTPSock::OnPageRequest(const CString& sURI, CString& sPageRet) { - return false; -} - bool CHTTPSock::PrintNotFound() { return PrintErrorPage(404, "Not Found", "The requested URL was not found on this server."); } @@ -416,12 +412,4 @@ void CHTTPSock::ReachedMaxBuffer() { Close(); } -Csock* CHTTPSock::GetSockObj(const CString& sHost, unsigned short uPort) { - CHTTPSock* pSock = new CHTTPSock(m_pModule); - pSock->SetSockName("HTTP::CLIENT"); - pSock->SetTimeout(120); - - return pSock; -} - #endif // _MODULES diff --git a/HTTPSock.h b/HTTPSock.h index 39e7693a..e8b25250 100644 --- a/HTTPSock.h +++ b/HTTPSock.h @@ -27,11 +27,11 @@ public: virtual void Timeout(); virtual void Connected(); virtual void Disconnected(); - virtual Csock* GetSockObj(const CString& sHost, unsigned short uPort); + virtual Csock* GetSockObj(const CString& sHost, unsigned short uPort) = 0; // !Csocket derived members // Hooks - virtual bool OnPageRequest(const CString& sURI, CString& sPageRet); + virtual bool OnPageRequest(const CString& sURI, CString& sPageRet) = 0; virtual bool OnLogin(const CString& sUser, const CString& sPass); // !Hooks