iarv/znc
1
0
Fork 0
mirror of https://github.com/znc/znc.git synced 2026-03-28 17:42:41 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add test for #1229 and actually fix it.

Browse Source
This commit is contained in:
Alexey Sokolov
2016-01-09 18:00:47 +00:00
parent 6a87ba3d4f
commit 1f226d2ade
7 changed files with 31 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
test/Integration.cpp
View File

@@ -76,7 +76,7 @@ class IO {
m_readed += chunk;
}
}
void Write(QString s = "", bool new_line = true) {
void Write(QByteArray s = "", bool new_line = true) {
if (!m_device) return;
if (m_verbose) {
std::cout << s.toStdString() << std::flush;
@@ -85,9 +85,10 @@ class IO {
}
}
s += "\n";
{
QTextStream str(m_device);
str << s;
while (!s.isEmpty()) {
auto res = m_device->write(s);
ASSERT_NE(res, -1);
s.remove(0, res);
}
FlushIfCan(m_device);
}
@@ -103,8 +104,7 @@ class IO {
}
private:
// QTextStream doesn't flush QTcpSocket, and QIODevice doesn't have flush()
// at all...
// Need to flush QTcpSocket, and QIODevice doesn't have flush at all...
static void FlushIfCan(QIODevice*) {}
static void FlushIfCan(QTcpSocket* sock) { sock->flush(); }
@@ -469,7 +469,7 @@ TEST_F(ZNCTest, ControlpanelModule) {
auto client = LoginClient();
Z;
const QString request = "PRIVMSG *controlpanel :";
const QByteArray request = "PRIVMSG *controlpanel :";
const QByteArray response = ":*controlpanel!znc@znc.in PRIVMSG nick :";
// TODO: Figure out how to check for "HAVE_ICU" to test encoding.
@@ -1766,6 +1766,11 @@ TEST_F(ZNCTest, Modpython) {
client.Write("PRIVMSG *pyeval :module.GetUser().GetUserName()");
client.ReadUntil("nick :'user'");
Z;
ircd.Write(":server 001 nick :Hello");
ircd.Write(":n!u@h PRIVMSG nick :Hi\xF0, github issue #1229");
// "replacement character"
client.ReadUntil("Hi\xEF\xBF\xBD, github issue");
Z;
}
} // namespace