From 062989595c0df135e6c624ce38fa14e55a5cac1e Mon Sep 17 00:00:00 2001
From: psychon <psychon@726aef4b-f618-498e-8847-2d620e286838>
Date: Wed, 10 Jun 2009 11:40:14 +0000
Subject: [PATCH] Admin: Some minor cleanup

Move some code from GetUser()'s callers into GetUser() itself.


git-svn-id: https://znc.svn.sourceforge.net/svnroot/znc/trunk@1539 726aef4b-f618-498e-8847-2d620e286838
---
 modules/admin.cpp | 51 ++++++++++++++---------------------------------
 1 file changed, 15 insertions(+), 36 deletions(-)

diff --git a/modules/admin.cpp b/modules/admin.cpp
index 7c79e6c9..66dc8f05 100644
--- a/modules/admin.cpp
+++ b/modules/admin.cpp
@@ -108,7 +108,16 @@ class CAdminMod : public CModule {
 	CUser* GetUser(const CString& username) {
 		if (username.Equals("$me"))
 			return m_pUser;
-		return CZNC::Get().FindUser(username);
+		CUser *pUser = CZNC::Get().FindUser(username);
+		if (!pUser) {
+			PutModule("Error: User not found: " + username);
+			return NULL;
+		}
+		if (user != m_pUser && !m_pUser->IsAdmin()) {
+			PutModule("Error: You need to have admin rights to modify other users!");
+			return NULL;
+		}
+		return pUser;
 	}
 
 	void Get(const CString& sLine) {
@@ -124,14 +133,8 @@ class CAdminMod : public CModule {
 		}
 
 		CUser* user = GetUser(username);
-		if (!user) {
-			PutModule("Error: User not found: " + username);
+		if (!user)
 			return;
-		}
-		if (user != m_pUser && !m_pUser->IsAdmin()) {
-			PutModule("Error: You need to have admin rights to modify other users!");
-			return;
-		}
 
 		if (var == "nick")
 			PutModule("Nick = " + user->GetNick());
@@ -179,14 +182,8 @@ class CAdminMod : public CModule {
 		}
 
 		CUser* user = GetUser(username);
-		if (!user) {
-			PutModule("Error: User not found: " + username);
+		if (!user)
 			return;
-		}
-		if (user != m_pUser && !m_pUser->IsAdmin()) {
-			PutModule("Error: You need to have admin rights to modify other users!");
-			return;
-		}
 
 		if (var == "nick") {
 			user->SetNick(value);
@@ -274,14 +271,8 @@ class CAdminMod : public CModule {
 		}
 
 		CUser* user = GetUser(username);
-		if (!user) {
-			PutModule("Error: User not found: " + username);
+		if (!user)
 			return;
-		}
-		if (user != m_pUser && !m_pUser->IsAdmin()) {
-			PutModule("Error: You need to have admin rights to modify other users!");
-			return;
-		}
 
 		CChan* pChan = user->FindChan(chan);
 		if (!pChan) {
@@ -321,14 +312,8 @@ class CAdminMod : public CModule {
 		}
 
 		CUser* user = GetUser(username);
-		if (!user) {
-			PutModule("Error: User not found: " + username);
+		if (!user)
 			return;
-		}
-		if (user != m_pUser && !m_pUser->IsAdmin()) {
-			PutModule("Error: You need to have admin rights to modify other users!");
-			return;
-		}
 
 		CChan* pChan = user->FindChan(chan);
 		if (!pChan) {
@@ -522,14 +507,8 @@ class CAdminMod : public CModule {
 		}
 
 		CUser* user = GetUser(username);
-		if (!user) {
-			PutModule("Error: User not found: " + username);
+		if (!user)
 			return;
-		}
-		if (user != m_pUser && !m_pUser->IsAdmin()) {
-			PutModule("Error: You need to have admin rights to modify other users!");
-			return;
-		}
 
 		user->AddServer(server);
 		PutModule("Added IRC Server: " + server);