From dffa6c87a0d230bfedce46c42c299a286de30731 Mon Sep 17 00:00:00 2001 From: Elio Struyf Date: Tue, 19 Oct 2021 08:45:32 +0200 Subject: [PATCH] Fix for rendering less hooks --- src/panelWebView/components/Collapsible.tsx | 32 +++++++++---------- .../components/Fields/TextField.tsx | 10 +++--- 2 files changed, 21 insertions(+), 21 deletions(-) diff --git a/src/panelWebView/components/Collapsible.tsx b/src/panelWebView/components/Collapsible.tsx index 75522084..c1a07107 100644 --- a/src/panelWebView/components/Collapsible.tsx +++ b/src/panelWebView/components/Collapsible.tsx @@ -14,6 +14,22 @@ export const Collapsible: React.FunctionComponent = ({id, chi const [ isOpen, setIsOpen ] = React.useState(false); const collapseKey = `collapse-${id}`; + useEffect(() => { + const collapsed = window.localStorage.getItem(collapseKey); + if (collapsed === null || collapsed === 'true') { + setIsOpen(true); + updateStorage(true); + } + + window.addEventListener('message', event => { + const message = event.data; + if (message.command === Command.closeSections) { + setIsOpen(false); + updateStorage(false); + } + }); + }, ['']); + const updateStorage = (value: boolean) => { window.localStorage.setItem(collapseKey, value.toString()); } @@ -32,22 +48,6 @@ export const Collapsible: React.FunctionComponent = ({id, chi } } - useEffect(() => { - const collapsed = window.localStorage.getItem(collapseKey); - if (collapsed === null || collapsed === 'true') { - setIsOpen(true); - updateStorage(true); - } - - window.addEventListener('message', event => { - const message = event.data; - if (message.command === Command.closeSections) { - setIsOpen(false); - updateStorage(false); - } - }); - }, ['']); - return (
diff --git a/src/panelWebView/components/Fields/TextField.tsx b/src/panelWebView/components/Fields/TextField.tsx index 3e4f36d3..4a8c66c5 100644 --- a/src/panelWebView/components/Fields/TextField.tsx +++ b/src/panelWebView/components/Fields/TextField.tsx @@ -13,17 +13,17 @@ export interface ITextFieldProps { export const TextField: React.FunctionComponent = ({singleLine, limit, label, value, rows, onChange}: React.PropsWithChildren) => { const [ text, setText ] = React.useState(value); - - const onTextChange = (txtValue: string) => { - setText(txtValue); - onChange(txtValue); - }; React.useEffect(() => { if (text !== value) { setText(value); } }, [ value ]); + + const onTextChange = (txtValue: string) => { + setText(txtValue); + onChange(txtValue); + }; let isValid = true; if (limit && limit !== -1) {