From 5656a48b31e90452bb0fa290b259e4ea156de483 Mon Sep 17 00:00:00 2001 From: Paul Picazo Date: Sat, 13 Dec 2025 22:04:18 -0800 Subject: [PATCH] Refactor SNR calculation in TraceHelper to use snr_register_to_db utility --- repeater/handler_helpers/trace.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/repeater/handler_helpers/trace.py b/repeater/handler_helpers/trace.py index 1f7b425..0a84dbf 100644 --- a/repeater/handler_helpers/trace.py +++ b/repeater/handler_helpers/trace.py @@ -10,6 +10,7 @@ import logging import time from typing import Dict, Any +from pymc_core.hardware.signal_utils import snr_register_to_db from pymc_core.node.handlers.trace import TraceHandler from pymc_core.protocol.constants import MAX_PATH_SIZE, ROUTE_TYPE_DIRECT @@ -115,9 +116,7 @@ class TraceHelper: for i in range(packet.path_len): if i < len(packet.path): snr_val = packet.path[i] - # Convert unsigned byte to signed SNR - snr_signed = snr_val if snr_val < 128 else snr_val - 256 - snr_db = snr_signed / 4.0 + snr_db = snr_register_to_db(snr_val) path_snrs.append(f"{snr_val}({snr_db:.1f}dB)") # Add detailed SNR info if we have the corresponding hash @@ -177,8 +176,7 @@ class TraceHelper: for i in range(packet.path_len): if i < len(packet.path): snr_val = packet.path[i] - snr_signed = snr_val if snr_val < 128 else snr_val - 256 - snr_db = snr_signed / 4.0 + snr_db = snr_register_to_db(snr_val) path_snrs.append(f"{snr_val}({snr_db:.1f}dB)") if i < len(trace_path):