mirror of
https://github.com/l5yth/potato-mesh.git
synced 2026-05-17 23:05:51 +02:00
l5y
03caf391e7
* web: refactor 1/7 data processing * web: close coverage gaps in data_processing submodules Bring every file under lib/potato_mesh/application/data_processing/ to 100% line coverage so codecov/patch passes on the 1/7 refactor PR. The gap was a relocation of pre-existing untested branches; closing them here keeps the subsequent refactor PRs in the series unblocked. * Add unit tests covering canonical sender/recipient overrides, reply_id/emoji updates on existing rows, and the rare INSERT ConstraintException recovery path inside +insert_message+. * Cover the non-canonical reporter and per-neighbour resolution branches in +insert_neighbors+. * Cover the SQLException rescue in +upsert_ingestor+, the fallback_num branch in +touch_node_last_seen+, the limit fallback in +read_json_body+, the unrecognised-type branch in +store_decrypted_payload+, the +power+ telemetry_type fallback, the default-coercion path in +resolve_numeric_metric+, and the numeric/bare-hex paths in +canonical_node_parts+ and +coerce_trace_node_id+. Drop dead code surfaced while pinning behaviour: * +clear_encrypted+ in +insert_message+ has been initialised to +false+ and never reassigned since #633 dropped the decrypted-text override; remove it and the four dependent branches. * The +rescue ArgumentError; nil+ tails in +identity.resolve_node_num+ and +traces.coerce_trace_node_id+ are unreachable because every +Integer(...)+ call inside is guarded by a regex pre-check. Add a comment to the +data_processing.rb+ shim explaining that the +require_relative+ list is ordered by dependency rather than alphabetically, addressing review nit #5.
51 lines
1.8 KiB
Ruby
51 lines
1.8 KiB
Ruby
# Copyright © 2025-26 l5yth & contributors
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
# frozen_string_literal: true
|
|
|
|
module PotatoMesh
|
|
module App
|
|
module DataProcessing
|
|
# Look up the protocol registered by a given ingestor node.
|
|
#
|
|
# @param db [SQLite3::Database] open database handle.
|
|
# @param ingestor_node_id [String, nil] the node_id of the reporting ingestor.
|
|
# @param cache [Hash, nil] optional per-request memoization hash; pass a shared
|
|
# Hash instance across a batch to avoid redundant DB lookups per record.
|
|
# @return [String] protocol string; defaults to "meshtastic" when absent or unknown.
|
|
def resolve_protocol(db, ingestor_node_id, cache: nil)
|
|
return "meshtastic" if ingestor_node_id.nil? || ingestor_node_id.to_s.strip.empty?
|
|
|
|
if cache
|
|
return cache[ingestor_node_id] if cache.key?(ingestor_node_id)
|
|
|
|
result = db.get_first_value(
|
|
"SELECT protocol FROM ingestors WHERE node_id = ? LIMIT 1",
|
|
[ingestor_node_id],
|
|
) || "meshtastic"
|
|
cache[ingestor_node_id] = result
|
|
return result
|
|
end
|
|
|
|
db.get_first_value(
|
|
"SELECT protocol FROM ingestors WHERE node_id = ? LIMIT 1",
|
|
[ingestor_node_id],
|
|
) || "meshtastic"
|
|
end
|
|
|
|
private :resolve_protocol
|
|
end
|
|
end
|
|
end
|