Files
meshcore-stats/tests/html/test_page_context.py
Jorijn Schrijvershof a9f6926104 test: add comprehensive pytest test suite with 95% coverage (#29)
* test: add comprehensive pytest test suite with 95% coverage

Add full unit and integration test coverage for the meshcore-stats project:

- 1020 tests covering all modules (db, charts, html, reports, client, etc.)
- 95.95% code coverage with pytest-cov (95% threshold enforced)
- GitHub Actions CI workflow for automated testing on push/PR
- Proper mocking of external dependencies (meshcore, serial, filesystem)
- SVG snapshot infrastructure for chart regression testing
- Integration tests for collection and rendering pipelines

Test organization:
- tests/charts/: Chart rendering and statistics
- tests/client/: MeshCore client and connection handling
- tests/config/: Environment and configuration parsing
- tests/database/: SQLite operations and migrations
- tests/html/: HTML generation and Jinja templates
- tests/reports/: Report generation and formatting
- tests/retry/: Circuit breaker and retry logic
- tests/unit/: Pure unit tests for utilities
- tests/integration/: End-to-end pipeline tests

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* chore: add test-engineer agent configuration

Add project-local test-engineer agent for pytest test development,
coverage analysis, and test review tasks.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* docs: comprehensive test suite review with 956 tests analyzed

Conducted thorough review of all 956 test cases across 47 test files:

- Unit Tests: 338 tests (battery, metrics, log, telemetry, env, charts, html, reports, formatters)
- Config Tests: 53 tests (env loading, config file parsing)
- Database Tests: 115 tests (init, insert, queries, migrations, maintenance, validation)
- Retry Tests: 59 tests (circuit breaker, async retries, factory)
- Charts Tests: 76 tests (transforms, statistics, timeseries, rendering, I/O)
- HTML Tests: 81 tests (site generation, Jinja2, metrics builders, reports index)
- Reports Tests: 149 tests (location, JSON/TXT formatting, aggregation, counter totals)
- Client Tests: 63 tests (contacts, connection, meshcore availability, commands)
- Integration Tests: 22 tests (reports, collection, rendering pipelines)

Results:
- Overall Pass Rate: 99.7% (953/956)
- 3 tests marked for improvement (empty test bodies in client tests)
- 0 tests requiring fixes

Key findings documented in test_review/tests.md including quality
observations, F.I.R.S.T. principle adherence, and recommendations.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* test: implement snapshot testing for charts and reports

Add comprehensive snapshot testing infrastructure:

SVG Chart Snapshots:
- Deterministic fixtures with fixed timestamps (2024-01-15 12:00:00)
- Tests for gauge/counter metrics in light/dark themes
- Empty chart and single-point edge cases
- Extended normalize_svg_for_snapshot_full() for reproducible comparisons

TXT Report Snapshots:
- Monthly/yearly report snapshots for repeater and companion
- Empty report handling tests
- Tests in tests/reports/test_snapshots.py

Infrastructure:
- tests/snapshots/conftest.py with shared fixtures
- UPDATE_SNAPSHOTS=1 environment variable for regeneration
- scripts/generate_snapshots.py for batch snapshot generation

Run `UPDATE_SNAPSHOTS=1 pytest tests/charts/test_chart_render.py::TestSvgSnapshots`
to generate initial snapshots.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* test: fix SVG normalization and generate initial snapshots

Fix normalize_svg_for_snapshot() to handle:
- clipPath IDs like id="p47c77a2a6e"
- url(#p...) references
- xlink:href="#p..." references
- <dc:date> timestamps

Generated initial snapshot files:
- 7 SVG chart snapshots (gauge, counter, empty, single-point in light/dark)
- 6 TXT report snapshots (monthly/yearly for repeater/companion + empty)

All 13 snapshot tests now pass.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* test: fix SVG normalization to preserve axis rendering

The SVG normalization was replacing all matplotlib-generated IDs with
the same value, causing duplicate IDs that broke SVG rendering:
- Font glyphs, clipPaths, and tick marks all got id="normalized"
- References couldn't resolve to the correct elements
- X and Y axes failed to render in normalized snapshots

Fix uses type-specific prefixes with sequential numbering:
- glyph_N for font glyphs (DejaVuSans-XX patterns)
- clip_N for clipPath definitions (p[0-9a-f]{8,} patterns)
- tick_N for tick marks (m[0-9a-f]{8,} patterns)

This ensures all IDs remain unique while still being deterministic
for snapshot comparison.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* chore: add coverage and pytest artifacts to gitignore

Add .coverage, .coverage.*, htmlcov/, and .pytest_cache/ to prevent
test artifacts from being committed.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* style: fix all ruff lint errors across codebase

- Sort and organize imports (I001)
- Use modern type annotations (X | Y instead of Union, collections.abc)
- Remove unused imports (F401)
- Combine nested if statements (SIM102)
- Use ternary operators where appropriate (SIM108)
- Combine nested with statements (SIM117)
- Use contextlib.suppress instead of try-except-pass (SIM105)
- Add noqa comments for intentional SIM115 violations (file locks)
- Add TYPE_CHECKING import for forward references
- Fix exception chaining (B904)

All 1033 tests pass.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* docs: add TDD workflow and pre-commit requirements to CLAUDE.md

- Add mandatory test-driven development workflow (write tests first)
- Add pre-commit requirements (must run lint and tests before committing)
- Document test organization and running commands
- Document 95% coverage requirement

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: resolve mypy type checking errors with proper structural fixes

- charts.py: Create PeriodConfig dataclass for type-safe period configuration,
  use mdates.date2num() for matplotlib datetime handling, fix x-axis limits
  for single-point charts
- db.py: Add explicit int() conversion with None handling for SQLite returns
- env.py: Add class-level type annotations to Config class
- html.py: Add MetricDisplay TypedDict, fix import order, add proper type
  annotations for table data functions
- meshcore_client.py: Add return type annotation

Update tests to use new dataclass attribute access and regenerate SVG
snapshots. Add mypy step to CLAUDE.md pre-commit requirements.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: cast Jinja2 template.render() to str for mypy

Jinja2's type stubs declare render() as returning Any, but it actually
returns str. Wrap with str() to satisfy mypy's no-any-return check.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* ci: improve workflow security and reliability

- test.yml: Pin all actions by SHA, add concurrency control to cancel
  in-progress runs on rapid pushes
- release-please.yml: Pin action by SHA, add 10-minute timeout
- conftest.py: Fix snapshot_base_time to use explicit UTC timezone for
  consistent behavior across CI and local environments

Regenerate SVG snapshots with UTC-aware timestamps.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: add mypy command to permissions in settings.local.json

* test: add comprehensive script tests with coroutine warning fixes

- Add tests/scripts/ with tests for collect_companion, collect_repeater,
  and render scripts (1135 tests total, 96% coverage)
- Fix unawaited coroutine warnings by using AsyncMock properly for async
  functions and async_context_manager_factory fixture for context managers
- Add --cov=scripts to CI workflow and pyproject.toml coverage config
- Omit scripts/generate_snapshots.py from coverage (dev utility)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* docs: migrate claude setup to codex skills

* feat: migrate dependencies to uv (#31)

* fix: run tests through uv

* test: fix ruff lint issues in tests

Consolidate patch context managers and clean unused imports/variables

Use datetime.UTC in snapshot fixtures

* test: avoid unawaited async mocks in entrypoint tests

* ci: replace codecov with github coverage artifacts

Add junit XML output and coverage summary in job output

Upload HTML and XML coverage artifacts (3.12 only) on every run

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-08 17:16:53 +01:00

225 lines
6.7 KiB
Python

"""Tests for page context building."""
import time
import pytest
from meshmon.html import (
build_page_context,
get_status,
)
class TestGetStatus:
"""Tests for get_status function."""
def test_online_for_recent_data(self):
"""Returns 'online' for data less than 30 minutes old."""
# 10 minutes ago
recent_ts = int(time.time()) - 600
status_class, status_label = get_status(recent_ts)
assert status_class == "online"
def test_stale_for_medium_age_data(self):
"""Returns 'stale' for data 30 minutes to 2 hours old."""
# 1 hour ago
medium_ts = int(time.time()) - 3600
status_class, status_label = get_status(medium_ts)
assert status_class == "stale"
def test_offline_for_old_data(self):
"""Returns 'offline' for data more than 2 hours old."""
# 3 hours ago
old_ts = int(time.time()) - 10800
status_class, status_label = get_status(old_ts)
assert status_class == "offline"
def test_offline_for_very_old_data(self):
"""Returns 'offline' for very old data."""
# 7 days ago
very_old_ts = int(time.time()) - 604800
status_class, status_label = get_status(very_old_ts)
assert status_class == "offline"
def test_offline_for_none(self):
"""Returns 'offline' for None timestamp."""
status_class, status_label = get_status(None)
assert status_class == "offline"
def test_offline_for_zero(self):
"""Returns 'offline' for zero timestamp."""
status_class, status_label = get_status(0)
assert status_class == "offline"
def test_online_for_current_time(self):
"""Returns 'online' for current timestamp."""
now_ts = int(time.time())
status_class, status_label = get_status(now_ts)
assert status_class == "online"
def test_boundary_30_minutes(self):
"""Tests boundary at exactly 30 minutes."""
# Exactly 30 minutes ago
boundary_ts = int(time.time()) - 1800
status_class, _ = get_status(boundary_ts)
# At boundary, could be either online or stale depending on implementation
assert status_class in ["online", "stale"]
def test_boundary_2_hours(self):
"""Tests boundary at exactly 2 hours."""
# Exactly 2 hours ago
boundary_ts = int(time.time()) - 7200
status_class, _ = get_status(boundary_ts)
# At boundary, could be either stale or offline
assert status_class in ["stale", "offline"]
def test_returns_tuple(self):
"""Returns tuple of (status_class, status_label)."""
status = get_status(int(time.time()))
assert isinstance(status, tuple)
assert len(status) == 2
def test_status_label_is_string(self):
"""Status label is a string."""
_, status_label = get_status(int(time.time()))
assert isinstance(status_label, str)
class TestBuildPageContext:
"""Tests for build_page_context function."""
@pytest.fixture
def sample_row(self, sample_repeater_metrics):
"""Create a sample row with timestamp."""
row = sample_repeater_metrics.copy()
row["ts"] = int(time.time()) - 300 # 5 minutes ago
return row
def test_returns_dict(self, configured_env, sample_row):
"""Returns a dictionary."""
context = build_page_context(
role="repeater",
period="day",
row=sample_row,
at_root=True,
)
assert isinstance(context, dict)
def test_includes_role_and_period(self, configured_env, sample_row):
"""Context includes role and period."""
context = build_page_context(
role="repeater",
period="day",
row=sample_row,
at_root=True,
)
assert context.get("role") == "repeater"
assert context.get("period") == "day"
def test_includes_status(self, configured_env, sample_row):
"""Context includes status indicator."""
context = build_page_context(
role="repeater",
period="day",
row=sample_row,
at_root=True,
)
assert "status_class" in context
assert context["status_class"] in ["online", "stale", "offline"]
def test_handles_none_row(self, configured_env):
"""Handles None row gracefully."""
context = build_page_context(
role="repeater",
period="day",
row=None,
at_root=True,
)
assert context.get("status_class") == "offline"
def test_includes_node_name(self, configured_env, sample_row, monkeypatch):
"""Context includes node name from config."""
monkeypatch.setenv("REPEATER_DISPLAY_NAME", "Test Repeater")
import meshmon.env
meshmon.env._config = None
context = build_page_context(
role="repeater",
period="day",
row=sample_row,
at_root=True,
)
assert "node_name" in context
assert context["node_name"] == "Test Repeater"
def test_includes_period(self, configured_env, sample_row):
"""Context includes current period."""
context = build_page_context(
role="repeater",
period="day",
row=sample_row,
at_root=True,
)
assert "period" in context
assert context["period"] == "day"
def test_different_roles(self, configured_env, sample_row, sample_companion_metrics):
"""Context varies by role."""
companion_row = sample_companion_metrics.copy()
companion_row["ts"] = int(time.time()) - 300
repeater_context = build_page_context(
role="repeater",
period="day",
row=sample_row,
at_root=True,
)
companion_context = build_page_context(
role="companion",
period="day",
row=companion_row,
at_root=False,
)
assert repeater_context["role"] == "repeater"
assert companion_context["role"] == "companion"
def test_at_root_affects_css_path(self, configured_env, sample_row):
"""at_root parameter affects CSS path."""
root_context = build_page_context(
role="repeater",
period="day",
row=sample_row,
at_root=True,
)
non_root_context = build_page_context(
role="companion",
period="day",
row=sample_row,
at_root=False,
)
# Non-root pages need relative path to CSS
assert "css_path" in root_context or "at_root" in root_context
assert "css_path" in non_root_context or "at_root" in non_root_context