mirror of
https://github.com/jorijn/meshcore-stats.git
synced 2026-03-28 17:42:55 +01:00
* test: add comprehensive pytest test suite with 95% coverage Add full unit and integration test coverage for the meshcore-stats project: - 1020 tests covering all modules (db, charts, html, reports, client, etc.) - 95.95% code coverage with pytest-cov (95% threshold enforced) - GitHub Actions CI workflow for automated testing on push/PR - Proper mocking of external dependencies (meshcore, serial, filesystem) - SVG snapshot infrastructure for chart regression testing - Integration tests for collection and rendering pipelines Test organization: - tests/charts/: Chart rendering and statistics - tests/client/: MeshCore client and connection handling - tests/config/: Environment and configuration parsing - tests/database/: SQLite operations and migrations - tests/html/: HTML generation and Jinja templates - tests/reports/: Report generation and formatting - tests/retry/: Circuit breaker and retry logic - tests/unit/: Pure unit tests for utilities - tests/integration/: End-to-end pipeline tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: add test-engineer agent configuration Add project-local test-engineer agent for pytest test development, coverage analysis, and test review tasks. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: comprehensive test suite review with 956 tests analyzed Conducted thorough review of all 956 test cases across 47 test files: - Unit Tests: 338 tests (battery, metrics, log, telemetry, env, charts, html, reports, formatters) - Config Tests: 53 tests (env loading, config file parsing) - Database Tests: 115 tests (init, insert, queries, migrations, maintenance, validation) - Retry Tests: 59 tests (circuit breaker, async retries, factory) - Charts Tests: 76 tests (transforms, statistics, timeseries, rendering, I/O) - HTML Tests: 81 tests (site generation, Jinja2, metrics builders, reports index) - Reports Tests: 149 tests (location, JSON/TXT formatting, aggregation, counter totals) - Client Tests: 63 tests (contacts, connection, meshcore availability, commands) - Integration Tests: 22 tests (reports, collection, rendering pipelines) Results: - Overall Pass Rate: 99.7% (953/956) - 3 tests marked for improvement (empty test bodies in client tests) - 0 tests requiring fixes Key findings documented in test_review/tests.md including quality observations, F.I.R.S.T. principle adherence, and recommendations. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test: implement snapshot testing for charts and reports Add comprehensive snapshot testing infrastructure: SVG Chart Snapshots: - Deterministic fixtures with fixed timestamps (2024-01-15 12:00:00) - Tests for gauge/counter metrics in light/dark themes - Empty chart and single-point edge cases - Extended normalize_svg_for_snapshot_full() for reproducible comparisons TXT Report Snapshots: - Monthly/yearly report snapshots for repeater and companion - Empty report handling tests - Tests in tests/reports/test_snapshots.py Infrastructure: - tests/snapshots/conftest.py with shared fixtures - UPDATE_SNAPSHOTS=1 environment variable for regeneration - scripts/generate_snapshots.py for batch snapshot generation Run `UPDATE_SNAPSHOTS=1 pytest tests/charts/test_chart_render.py::TestSvgSnapshots` to generate initial snapshots. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test: fix SVG normalization and generate initial snapshots Fix normalize_svg_for_snapshot() to handle: - clipPath IDs like id="p47c77a2a6e" - url(#p...) references - xlink:href="#p..." references - <dc:date> timestamps Generated initial snapshot files: - 7 SVG chart snapshots (gauge, counter, empty, single-point in light/dark) - 6 TXT report snapshots (monthly/yearly for repeater/companion + empty) All 13 snapshot tests now pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * test: fix SVG normalization to preserve axis rendering The SVG normalization was replacing all matplotlib-generated IDs with the same value, causing duplicate IDs that broke SVG rendering: - Font glyphs, clipPaths, and tick marks all got id="normalized" - References couldn't resolve to the correct elements - X and Y axes failed to render in normalized snapshots Fix uses type-specific prefixes with sequential numbering: - glyph_N for font glyphs (DejaVuSans-XX patterns) - clip_N for clipPath definitions (p[0-9a-f]{8,} patterns) - tick_N for tick marks (m[0-9a-f]{8,} patterns) This ensures all IDs remain unique while still being deterministic for snapshot comparison. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: add coverage and pytest artifacts to gitignore Add .coverage, .coverage.*, htmlcov/, and .pytest_cache/ to prevent test artifacts from being committed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * style: fix all ruff lint errors across codebase - Sort and organize imports (I001) - Use modern type annotations (X | Y instead of Union, collections.abc) - Remove unused imports (F401) - Combine nested if statements (SIM102) - Use ternary operators where appropriate (SIM108) - Combine nested with statements (SIM117) - Use contextlib.suppress instead of try-except-pass (SIM105) - Add noqa comments for intentional SIM115 violations (file locks) - Add TYPE_CHECKING import for forward references - Fix exception chaining (B904) All 1033 tests pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: add TDD workflow and pre-commit requirements to CLAUDE.md - Add mandatory test-driven development workflow (write tests first) - Add pre-commit requirements (must run lint and tests before committing) - Document test organization and running commands - Document 95% coverage requirement 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: resolve mypy type checking errors with proper structural fixes - charts.py: Create PeriodConfig dataclass for type-safe period configuration, use mdates.date2num() for matplotlib datetime handling, fix x-axis limits for single-point charts - db.py: Add explicit int() conversion with None handling for SQLite returns - env.py: Add class-level type annotations to Config class - html.py: Add MetricDisplay TypedDict, fix import order, add proper type annotations for table data functions - meshcore_client.py: Add return type annotation Update tests to use new dataclass attribute access and regenerate SVG snapshots. Add mypy step to CLAUDE.md pre-commit requirements. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: cast Jinja2 template.render() to str for mypy Jinja2's type stubs declare render() as returning Any, but it actually returns str. Wrap with str() to satisfy mypy's no-any-return check. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * ci: improve workflow security and reliability - test.yml: Pin all actions by SHA, add concurrency control to cancel in-progress runs on rapid pushes - release-please.yml: Pin action by SHA, add 10-minute timeout - conftest.py: Fix snapshot_base_time to use explicit UTC timezone for consistent behavior across CI and local environments Regenerate SVG snapshots with UTC-aware timestamps. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: add mypy command to permissions in settings.local.json * test: add comprehensive script tests with coroutine warning fixes - Add tests/scripts/ with tests for collect_companion, collect_repeater, and render scripts (1135 tests total, 96% coverage) - Fix unawaited coroutine warnings by using AsyncMock properly for async functions and async_context_manager_factory fixture for context managers - Add --cov=scripts to CI workflow and pyproject.toml coverage config - Omit scripts/generate_snapshots.py from coverage (dev utility) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: migrate claude setup to codex skills * feat: migrate dependencies to uv (#31) * fix: run tests through uv * test: fix ruff lint issues in tests Consolidate patch context managers and clean unused imports/variables Use datetime.UTC in snapshot fixtures * test: avoid unawaited async mocks in entrypoint tests * ci: replace codecov with github coverage artifacts Add junit XML output and coverage summary in job output Upload HTML and XML coverage artifacts (3.12 only) on every run --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
229 lines
7.0 KiB
Python
229 lines
7.0 KiB
Python
"""Tests for run_command function."""
|
|
|
|
from unittest.mock import MagicMock
|
|
|
|
import pytest
|
|
|
|
from meshmon.meshcore_client import run_command
|
|
|
|
from .conftest import make_mock_event
|
|
|
|
|
|
class TestRunCommandSuccess:
|
|
"""Tests for successful command execution."""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_returns_success_tuple(self, mock_meshcore_client, monkeypatch):
|
|
"""Returns (True, event_type, payload, None) on success."""
|
|
monkeypatch.setattr("meshmon.meshcore_client.MESHCORE_AVAILABLE", True)
|
|
|
|
event = make_mock_event("SELF_INFO", {"bat": 3850})
|
|
|
|
async def cmd():
|
|
return event
|
|
|
|
success, event_type, payload, error = await run_command(
|
|
mock_meshcore_client, cmd(), "test"
|
|
)
|
|
|
|
assert success is True
|
|
assert event_type == "SELF_INFO"
|
|
assert payload == {"bat": 3850}
|
|
assert error is None
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_extracts_payload_dict(self, mock_meshcore_client, monkeypatch):
|
|
"""Extracts payload when it's a dict."""
|
|
monkeypatch.setattr("meshmon.meshcore_client.MESHCORE_AVAILABLE", True)
|
|
|
|
payload_data = {"voltage": 3.85, "uptime": 86400}
|
|
event = make_mock_event("SELF_INFO", payload_data)
|
|
|
|
async def cmd():
|
|
return event
|
|
|
|
success, _, payload, _ = await run_command(
|
|
mock_meshcore_client, cmd(), "test"
|
|
)
|
|
|
|
assert payload == payload_data
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_converts_object_payload(self, mock_meshcore_client, monkeypatch):
|
|
"""Converts object payload to dict."""
|
|
monkeypatch.setattr("meshmon.meshcore_client.MESHCORE_AVAILABLE", True)
|
|
|
|
# Create object-like payload using a simple class with instance attributes
|
|
# vars() only returns instance attributes, not class attributes
|
|
class ObjPayload:
|
|
def __init__(self):
|
|
self.voltage = 3.85
|
|
|
|
obj_payload = ObjPayload()
|
|
|
|
event = make_mock_event("SELF_INFO", payload=obj_payload)
|
|
|
|
async def cmd():
|
|
return event
|
|
|
|
success, _, payload, _ = await run_command(
|
|
mock_meshcore_client, cmd(), "test"
|
|
)
|
|
|
|
assert "voltage" in payload
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_converts_namedtuple_payload(self, mock_meshcore_client, monkeypatch):
|
|
"""Converts namedtuple payload to dict."""
|
|
monkeypatch.setattr("meshmon.meshcore_client.MESHCORE_AVAILABLE", True)
|
|
|
|
from collections import namedtuple
|
|
Payload = namedtuple("Payload", ["voltage", "uptime"])
|
|
nt_payload = Payload(voltage=3.85, uptime=86400)
|
|
|
|
event = make_mock_event("SELF_INFO")
|
|
event.payload = nt_payload
|
|
|
|
async def cmd():
|
|
return event
|
|
|
|
success, _, payload, _ = await run_command(
|
|
mock_meshcore_client, cmd(), "test"
|
|
)
|
|
|
|
assert payload["voltage"] == 3.85
|
|
assert payload["uptime"] == 86400
|
|
|
|
|
|
class TestRunCommandFailure:
|
|
"""Tests for command failure scenarios."""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_returns_failure_when_unavailable(self, mock_meshcore_client, monkeypatch):
|
|
"""Returns failure when meshcore not available."""
|
|
monkeypatch.setattr("meshmon.meshcore_client.MESHCORE_AVAILABLE", False)
|
|
|
|
async def cmd():
|
|
return None
|
|
|
|
# Create the coroutine
|
|
cmd_coro = cmd()
|
|
|
|
success, event_type, payload, error = await run_command(
|
|
mock_meshcore_client, cmd_coro, "test"
|
|
)
|
|
|
|
# Close the coroutine to prevent "never awaited" warning
|
|
# since run_command returns early when MESHCORE_AVAILABLE=False
|
|
cmd_coro.close()
|
|
|
|
assert success is False
|
|
assert "not available" in error
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_returns_failure_on_none_event(self, mock_meshcore_client, monkeypatch):
|
|
"""Returns failure when no event received."""
|
|
monkeypatch.setattr("meshmon.meshcore_client.MESHCORE_AVAILABLE", True)
|
|
|
|
async def cmd():
|
|
return None
|
|
|
|
success, _, _, error = await run_command(
|
|
mock_meshcore_client, cmd(), "test"
|
|
)
|
|
|
|
assert success is False
|
|
assert "No response" in error
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_returns_failure_on_error_event(self, mock_meshcore_client, monkeypatch):
|
|
"""Returns failure on ERROR event type."""
|
|
monkeypatch.setattr("meshmon.meshcore_client.MESHCORE_AVAILABLE", True)
|
|
|
|
# Set up EventType mock
|
|
mock_event_type = MagicMock()
|
|
mock_event_type.ERROR = "ERROR"
|
|
monkeypatch.setattr("meshmon.meshcore_client.EventType", mock_event_type)
|
|
|
|
event = MagicMock()
|
|
event.type = mock_event_type.ERROR
|
|
event.payload = "Command failed"
|
|
|
|
async def cmd():
|
|
return event
|
|
|
|
success, event_type, payload, error = await run_command(
|
|
mock_meshcore_client, cmd(), "test"
|
|
)
|
|
|
|
assert success is False
|
|
assert error is not None
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_returns_failure_on_timeout(self, mock_meshcore_client, monkeypatch):
|
|
"""Returns failure on timeout."""
|
|
monkeypatch.setattr("meshmon.meshcore_client.MESHCORE_AVAILABLE", True)
|
|
|
|
async def cmd():
|
|
raise TimeoutError()
|
|
|
|
success, _, _, error = await run_command(
|
|
mock_meshcore_client, cmd(), "test"
|
|
)
|
|
|
|
assert success is False
|
|
assert "Timeout" in error
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_returns_failure_on_exception(self, mock_meshcore_client, monkeypatch):
|
|
"""Returns failure on general exception."""
|
|
monkeypatch.setattr("meshmon.meshcore_client.MESHCORE_AVAILABLE", True)
|
|
|
|
async def cmd():
|
|
raise RuntimeError("Connection lost")
|
|
|
|
success, _, _, error = await run_command(
|
|
mock_meshcore_client, cmd(), "test"
|
|
)
|
|
|
|
assert success is False
|
|
assert "Connection lost" in error
|
|
|
|
|
|
class TestRunCommandEventTypeParsing:
|
|
"""Tests for event type name extraction."""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_extracts_type_name_attribute(self, mock_meshcore_client, monkeypatch):
|
|
"""Extracts event type from .type.name attribute."""
|
|
monkeypatch.setattr("meshmon.meshcore_client.MESHCORE_AVAILABLE", True)
|
|
|
|
event = make_mock_event("CUSTOM_EVENT", {})
|
|
|
|
async def cmd():
|
|
return event
|
|
|
|
_, event_type, _, _ = await run_command(
|
|
mock_meshcore_client, cmd(), "test"
|
|
)
|
|
|
|
assert event_type == "CUSTOM_EVENT"
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_falls_back_to_str_type(self, mock_meshcore_client, monkeypatch):
|
|
"""Falls back to str(type) when no .name."""
|
|
monkeypatch.setattr("meshmon.meshcore_client.MESHCORE_AVAILABLE", True)
|
|
|
|
event = MagicMock()
|
|
event.type = "STRING_TYPE"
|
|
event.payload = {}
|
|
|
|
async def cmd():
|
|
return event
|
|
|
|
_, event_type, _, _ = await run_command(
|
|
mock_meshcore_client, cmd(), "test"
|
|
)
|
|
|
|
assert event_type == "STRING_TYPE"
|