mirror of
https://github.com/jkingsman/Remote-Terminal-for-MeshCore.git
synced 2026-03-28 17:43:05 +01:00
671 lines
25 KiB
Python
671 lines
25 KiB
Python
"""Tests for bot triggering on outgoing messages sent via the messages router."""
|
|
|
|
import asyncio
|
|
import time
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
from fastapi import HTTPException
|
|
from meshcore import EventType
|
|
|
|
from app.models import (
|
|
SendChannelMessageRequest,
|
|
SendDirectMessageRequest,
|
|
)
|
|
from app.radio import radio_manager
|
|
from app.repository import (
|
|
ChannelRepository,
|
|
ContactRepository,
|
|
MessageRepository,
|
|
)
|
|
from app.routers.messages import (
|
|
resend_channel_message,
|
|
send_channel_message,
|
|
send_direct_message,
|
|
)
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _reset_radio_state():
|
|
"""Save/restore radio_manager state so tests don't leak."""
|
|
prev = radio_manager._meshcore
|
|
prev_lock = radio_manager._operation_lock
|
|
yield
|
|
radio_manager._meshcore = prev
|
|
radio_manager._operation_lock = prev_lock
|
|
|
|
|
|
def _make_radio_result(payload=None):
|
|
"""Create a mock radio command result."""
|
|
result = MagicMock()
|
|
result.type = EventType.MSG_SENT
|
|
result.payload = payload or {}
|
|
return result
|
|
|
|
|
|
def _make_mc(name="TestNode"):
|
|
"""Create a mock MeshCore connection."""
|
|
mc = MagicMock()
|
|
mc.self_info = {"name": name}
|
|
mc.commands = MagicMock()
|
|
mc.commands.send_msg = AsyncMock(return_value=_make_radio_result())
|
|
mc.commands.send_chan_msg = AsyncMock(return_value=_make_radio_result())
|
|
mc.commands.add_contact = AsyncMock(return_value=_make_radio_result())
|
|
mc.commands.set_channel = AsyncMock(return_value=_make_radio_result())
|
|
mc.get_contact_by_key_prefix = MagicMock(return_value=None)
|
|
return mc
|
|
|
|
|
|
async def _insert_contact(public_key, name="Alice"):
|
|
"""Insert a contact into the test database."""
|
|
await ContactRepository.upsert(
|
|
{
|
|
"public_key": public_key,
|
|
"name": name,
|
|
"type": 0,
|
|
"flags": 0,
|
|
"last_path": None,
|
|
"last_path_len": -1,
|
|
"last_advert": None,
|
|
"lat": None,
|
|
"lon": None,
|
|
"last_seen": None,
|
|
"on_radio": False,
|
|
"last_contacted": None,
|
|
}
|
|
)
|
|
|
|
|
|
class TestOutgoingDMBotTrigger:
|
|
"""Test that sending a DM triggers bots with is_outgoing=True."""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_send_dm_triggers_bot(self, test_db):
|
|
"""Sending a DM creates a background task to run bots."""
|
|
mc = _make_mc()
|
|
pub_key = "ab" * 32
|
|
await _insert_contact(pub_key, "Alice")
|
|
|
|
with (
|
|
patch("app.routers.messages.require_connected", return_value=mc),
|
|
patch.object(radio_manager, "_meshcore", mc),
|
|
patch("app.bot.run_bot_for_message", new=AsyncMock()) as mock_bot,
|
|
):
|
|
request = SendDirectMessageRequest(destination=pub_key, text="!lasttime Alice")
|
|
await send_direct_message(request)
|
|
|
|
# Let the background task run
|
|
await asyncio.sleep(0)
|
|
|
|
mock_bot.assert_called_once()
|
|
call_kwargs = mock_bot.call_args[1]
|
|
assert call_kwargs["message_text"] == "!lasttime Alice"
|
|
assert call_kwargs["is_dm"] is True
|
|
assert call_kwargs["is_outgoing"] is True
|
|
assert call_kwargs["sender_key"] == pub_key
|
|
assert call_kwargs["channel_key"] is None
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_send_dm_bot_does_not_block_response(self, test_db):
|
|
"""Bot trigger runs in background and doesn't delay the message response."""
|
|
mc = _make_mc()
|
|
pub_key = "ab" * 32
|
|
await _insert_contact(pub_key, "Alice")
|
|
|
|
# Bot that would take a long time
|
|
async def _slow(**kw):
|
|
await asyncio.sleep(10)
|
|
|
|
slow_bot = AsyncMock(side_effect=_slow)
|
|
|
|
with (
|
|
patch("app.routers.messages.require_connected", return_value=mc),
|
|
patch.object(radio_manager, "_meshcore", mc),
|
|
patch("app.bot.run_bot_for_message", new=slow_bot),
|
|
):
|
|
request = SendDirectMessageRequest(destination=pub_key, text="Hello")
|
|
# This should return immediately, not wait 10 seconds
|
|
message = await send_direct_message(request)
|
|
assert message.text == "Hello"
|
|
assert message.outgoing is True
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_send_dm_passes_no_sender_name(self, test_db):
|
|
"""Outgoing DMs pass sender_name=None (we are the sender)."""
|
|
mc = _make_mc()
|
|
pub_key = "cd" * 32
|
|
await _insert_contact(pub_key, "Bob")
|
|
|
|
with (
|
|
patch("app.routers.messages.require_connected", return_value=mc),
|
|
patch.object(radio_manager, "_meshcore", mc),
|
|
patch("app.bot.run_bot_for_message", new=AsyncMock()) as mock_bot,
|
|
):
|
|
request = SendDirectMessageRequest(destination=pub_key, text="test")
|
|
await send_direct_message(request)
|
|
await asyncio.sleep(0)
|
|
|
|
call_kwargs = mock_bot.call_args[1]
|
|
assert call_kwargs["sender_name"] is None
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_send_dm_ambiguous_prefix_returns_409(self, test_db):
|
|
"""Ambiguous destination prefix should fail instead of selecting a random contact."""
|
|
mc = _make_mc()
|
|
|
|
# Insert two contacts that share the prefix "abc123"
|
|
await _insert_contact("abc123" + "00" * 29, "ContactA")
|
|
await _insert_contact("abc123" + "ff" * 29, "ContactB")
|
|
|
|
with patch("app.routers.messages.require_connected", return_value=mc):
|
|
with pytest.raises(HTTPException) as exc_info:
|
|
await send_direct_message(
|
|
SendDirectMessageRequest(destination="abc123", text="Hello")
|
|
)
|
|
|
|
assert exc_info.value.status_code == 409
|
|
assert "ambiguous" in exc_info.value.detail.lower()
|
|
|
|
|
|
class TestOutgoingChannelBotTrigger:
|
|
"""Test that sending a channel message triggers bots with is_outgoing=True."""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_send_channel_msg_triggers_bot(self, test_db):
|
|
"""Sending a channel message creates a background task to run bots."""
|
|
mc = _make_mc(name="MyNode")
|
|
chan_key = "aa" * 16
|
|
await ChannelRepository.upsert(key=chan_key, name="#general")
|
|
|
|
with (
|
|
patch("app.routers.messages.require_connected", return_value=mc),
|
|
patch.object(radio_manager, "_meshcore", mc),
|
|
patch("app.decoder.calculate_channel_hash", return_value="abcd"),
|
|
patch("app.bot.run_bot_for_message", new=AsyncMock()) as mock_bot,
|
|
):
|
|
request = SendChannelMessageRequest(channel_key=chan_key, text="!lasttime5 someone")
|
|
await send_channel_message(request)
|
|
await asyncio.sleep(0)
|
|
|
|
mock_bot.assert_called_once()
|
|
call_kwargs = mock_bot.call_args[1]
|
|
assert call_kwargs["message_text"] == "!lasttime5 someone"
|
|
assert call_kwargs["is_dm"] is False
|
|
assert call_kwargs["is_outgoing"] is True
|
|
assert call_kwargs["channel_key"] == chan_key.upper()
|
|
assert call_kwargs["channel_name"] == "#general"
|
|
assert call_kwargs["sender_name"] == "MyNode"
|
|
assert call_kwargs["sender_key"] is None
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_send_channel_msg_no_radio_name(self, test_db):
|
|
"""When radio has no name, sender_name is None."""
|
|
mc = _make_mc(name="")
|
|
chan_key = "bb" * 16
|
|
await ChannelRepository.upsert(key=chan_key, name="#test")
|
|
|
|
with (
|
|
patch("app.routers.messages.require_connected", return_value=mc),
|
|
patch.object(radio_manager, "_meshcore", mc),
|
|
patch("app.decoder.calculate_channel_hash", return_value="abcd"),
|
|
patch("app.bot.run_bot_for_message", new=AsyncMock()) as mock_bot,
|
|
):
|
|
request = SendChannelMessageRequest(channel_key=chan_key, text="hello")
|
|
await send_channel_message(request)
|
|
await asyncio.sleep(0)
|
|
|
|
call_kwargs = mock_bot.call_args[1]
|
|
assert call_kwargs["sender_name"] is None
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_send_channel_msg_bot_does_not_block_response(self, test_db):
|
|
"""Bot trigger runs in background and doesn't delay the message response."""
|
|
mc = _make_mc(name="MyNode")
|
|
chan_key = "cc" * 16
|
|
await ChannelRepository.upsert(key=chan_key, name="#slow")
|
|
|
|
async def _slow(**kw):
|
|
await asyncio.sleep(10)
|
|
|
|
slow_bot = AsyncMock(side_effect=_slow)
|
|
|
|
with (
|
|
patch("app.routers.messages.require_connected", return_value=mc),
|
|
patch.object(radio_manager, "_meshcore", mc),
|
|
patch("app.decoder.calculate_channel_hash", return_value="abcd"),
|
|
patch("app.bot.run_bot_for_message", new=slow_bot),
|
|
):
|
|
request = SendChannelMessageRequest(channel_key=chan_key, text="test")
|
|
message = await send_channel_message(request)
|
|
assert message.outgoing is True
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_send_channel_msg_response_includes_current_ack_count(self, test_db):
|
|
"""Send response reflects latest DB ack count at response time."""
|
|
mc = _make_mc(name="MyNode")
|
|
chan_key = "ff" * 16
|
|
await ChannelRepository.upsert(key=chan_key, name="#acked")
|
|
|
|
with (
|
|
patch("app.routers.messages.require_connected", return_value=mc),
|
|
patch.object(radio_manager, "_meshcore", mc),
|
|
patch("app.decoder.calculate_channel_hash", return_value="abcd"),
|
|
patch("app.bot.run_bot_for_message", new=AsyncMock()),
|
|
):
|
|
request = SendChannelMessageRequest(channel_key=chan_key, text="acked now")
|
|
message = await send_channel_message(request)
|
|
|
|
# Fresh message has acked=0
|
|
assert message.id is not None
|
|
assert message.acked == 0
|
|
|
|
|
|
class TestResendChannelMessage:
|
|
"""Test the user-triggered resend endpoint."""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_resend_within_window_succeeds(self, test_db):
|
|
"""Resend within 30-second window sends with same timestamp bytes."""
|
|
mc = _make_mc(name="MyNode")
|
|
chan_key = "aa" * 16
|
|
await ChannelRepository.upsert(key=chan_key, name="#resend")
|
|
|
|
now = int(time.time()) - 10 # 10 seconds ago
|
|
msg_id = await MessageRepository.create(
|
|
msg_type="CHAN",
|
|
text="MyNode: hello",
|
|
conversation_key=chan_key.upper(),
|
|
sender_timestamp=now,
|
|
received_at=now,
|
|
outgoing=True,
|
|
)
|
|
assert msg_id is not None
|
|
|
|
with (
|
|
patch("app.routers.messages.require_connected", return_value=mc),
|
|
patch.object(radio_manager, "_meshcore", mc),
|
|
):
|
|
result = await resend_channel_message(msg_id, new_timestamp=False)
|
|
|
|
assert result["status"] == "ok"
|
|
assert result["message_id"] == msg_id
|
|
|
|
# Verify radio was called with correct timestamp bytes
|
|
mc.commands.send_chan_msg.assert_awaited_once()
|
|
call_kwargs = mc.commands.send_chan_msg.await_args.kwargs
|
|
assert call_kwargs["timestamp"] == now.to_bytes(4, "little")
|
|
assert call_kwargs["msg"] == "hello" # Sender prefix stripped
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_resend_outside_window_returns_400(self, test_db):
|
|
"""Resend after 30-second window fails."""
|
|
mc = _make_mc(name="MyNode")
|
|
chan_key = "bb" * 16
|
|
await ChannelRepository.upsert(key=chan_key, name="#old")
|
|
|
|
old_ts = int(time.time()) - 60 # 60 seconds ago
|
|
msg_id = await MessageRepository.create(
|
|
msg_type="CHAN",
|
|
text="MyNode: old message",
|
|
conversation_key=chan_key.upper(),
|
|
sender_timestamp=old_ts,
|
|
received_at=old_ts,
|
|
outgoing=True,
|
|
)
|
|
assert msg_id is not None
|
|
|
|
with (
|
|
patch("app.routers.messages.require_connected", return_value=mc),
|
|
pytest.raises(HTTPException) as exc_info,
|
|
):
|
|
await resend_channel_message(msg_id, new_timestamp=False)
|
|
|
|
assert exc_info.value.status_code == 400
|
|
assert "expired" in exc_info.value.detail.lower()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_resend_new_timestamp_collision_returns_original_id(self, test_db):
|
|
"""When new-timestamp resend collides (same second), return original ID gracefully."""
|
|
mc = _make_mc(name="MyNode")
|
|
chan_key = "dd" * 16
|
|
await ChannelRepository.upsert(key=chan_key, name="#collision")
|
|
|
|
now = int(time.time())
|
|
msg_id = await MessageRepository.create(
|
|
msg_type="CHAN",
|
|
text="MyNode: duplicate",
|
|
conversation_key=chan_key.upper(),
|
|
sender_timestamp=now,
|
|
received_at=now,
|
|
outgoing=True,
|
|
)
|
|
assert msg_id is not None
|
|
|
|
with (
|
|
patch("app.routers.messages.require_connected", return_value=mc),
|
|
patch.object(radio_manager, "_meshcore", mc),
|
|
patch("app.routers.messages.broadcast_event"),
|
|
patch("app.routers.messages.time") as mock_time,
|
|
):
|
|
# Force the same second so MessageRepository.create returns None (duplicate)
|
|
mock_time.time.return_value = float(now)
|
|
result = await resend_channel_message(msg_id, new_timestamp=True)
|
|
|
|
# Should succeed gracefully, returning the original message ID
|
|
assert result["status"] == "ok"
|
|
assert result["message_id"] == msg_id
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_resend_non_outgoing_returns_400(self, test_db):
|
|
"""Resend of incoming message fails."""
|
|
mc = _make_mc(name="MyNode")
|
|
chan_key = "cc" * 16
|
|
await ChannelRepository.upsert(key=chan_key, name="#incoming")
|
|
|
|
now = int(time.time())
|
|
msg_id = await MessageRepository.create(
|
|
msg_type="CHAN",
|
|
text="SomeUser: incoming",
|
|
conversation_key=chan_key.upper(),
|
|
sender_timestamp=now,
|
|
received_at=now,
|
|
outgoing=False,
|
|
)
|
|
assert msg_id is not None
|
|
|
|
with (
|
|
patch("app.routers.messages.require_connected", return_value=mc),
|
|
pytest.raises(HTTPException) as exc_info,
|
|
):
|
|
await resend_channel_message(msg_id, new_timestamp=False)
|
|
|
|
assert exc_info.value.status_code == 400
|
|
assert "outgoing" in exc_info.value.detail.lower()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_resend_dm_returns_400(self, test_db):
|
|
"""Resend of DM message fails."""
|
|
mc = _make_mc(name="MyNode")
|
|
pub_key = "dd" * 32
|
|
|
|
now = int(time.time())
|
|
msg_id = await MessageRepository.create(
|
|
msg_type="PRIV",
|
|
text="hello dm",
|
|
conversation_key=pub_key,
|
|
sender_timestamp=now,
|
|
received_at=now,
|
|
outgoing=True,
|
|
)
|
|
assert msg_id is not None
|
|
|
|
with (
|
|
patch("app.routers.messages.require_connected", return_value=mc),
|
|
pytest.raises(HTTPException) as exc_info,
|
|
):
|
|
await resend_channel_message(msg_id, new_timestamp=False)
|
|
|
|
assert exc_info.value.status_code == 400
|
|
assert "channel" in exc_info.value.detail.lower()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_resend_nonexistent_returns_404(self, test_db):
|
|
"""Resend of nonexistent message fails."""
|
|
mc = _make_mc(name="MyNode")
|
|
|
|
with (
|
|
patch("app.routers.messages.require_connected", return_value=mc),
|
|
pytest.raises(HTTPException) as exc_info,
|
|
):
|
|
await resend_channel_message(999999, new_timestamp=False)
|
|
|
|
assert exc_info.value.status_code == 404
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_resend_strips_sender_prefix(self, test_db):
|
|
"""Resend strips the sender prefix before sending to radio."""
|
|
mc = _make_mc(name="MyNode")
|
|
chan_key = "ee" * 16
|
|
await ChannelRepository.upsert(key=chan_key, name="#strip")
|
|
|
|
now = int(time.time()) - 5
|
|
msg_id = await MessageRepository.create(
|
|
msg_type="CHAN",
|
|
text="MyNode: hello world",
|
|
conversation_key=chan_key.upper(),
|
|
sender_timestamp=now,
|
|
received_at=now,
|
|
outgoing=True,
|
|
)
|
|
assert msg_id is not None
|
|
|
|
with (
|
|
patch("app.routers.messages.require_connected", return_value=mc),
|
|
patch.object(radio_manager, "_meshcore", mc),
|
|
):
|
|
await resend_channel_message(msg_id, new_timestamp=False)
|
|
|
|
call_kwargs = mc.commands.send_chan_msg.await_args.kwargs
|
|
assert call_kwargs["msg"] == "hello world"
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_resend_new_timestamp_skips_window(self, test_db):
|
|
"""new_timestamp=True succeeds even when the 30s window has expired."""
|
|
mc = _make_mc(name="MyNode")
|
|
chan_key = "dd" * 16
|
|
await ChannelRepository.upsert(key=chan_key, name="#old")
|
|
|
|
old_ts = int(time.time()) - 60 # 60 seconds ago — outside byte-perfect window
|
|
msg_id = await MessageRepository.create(
|
|
msg_type="CHAN",
|
|
text="MyNode: old message",
|
|
conversation_key=chan_key.upper(),
|
|
sender_timestamp=old_ts,
|
|
received_at=old_ts,
|
|
outgoing=True,
|
|
)
|
|
assert msg_id is not None
|
|
|
|
with (
|
|
patch("app.routers.messages.require_connected", return_value=mc),
|
|
patch.object(radio_manager, "_meshcore", mc),
|
|
patch("app.routers.messages.broadcast_event"),
|
|
):
|
|
result = await resend_channel_message(msg_id, new_timestamp=True)
|
|
|
|
assert result["status"] == "ok"
|
|
# Should return a NEW message id, not the original
|
|
assert result["message_id"] != msg_id
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_resend_new_timestamp_creates_new_message(self, test_db):
|
|
"""new_timestamp=True creates a new DB row with a different sender_timestamp."""
|
|
mc = _make_mc(name="MyNode")
|
|
chan_key = "dd" * 16
|
|
await ChannelRepository.upsert(key=chan_key, name="#new")
|
|
|
|
old_ts = int(time.time()) - 10
|
|
msg_id = await MessageRepository.create(
|
|
msg_type="CHAN",
|
|
text="MyNode: test",
|
|
conversation_key=chan_key.upper(),
|
|
sender_timestamp=old_ts,
|
|
received_at=old_ts,
|
|
outgoing=True,
|
|
)
|
|
assert msg_id is not None
|
|
|
|
with (
|
|
patch("app.routers.messages.require_connected", return_value=mc),
|
|
patch.object(radio_manager, "_meshcore", mc),
|
|
patch("app.routers.messages.broadcast_event"),
|
|
):
|
|
result = await resend_channel_message(msg_id, new_timestamp=True)
|
|
|
|
new_msg_id = result["message_id"]
|
|
new_msg = await MessageRepository.get_by_id(new_msg_id)
|
|
original_msg = await MessageRepository.get_by_id(msg_id)
|
|
|
|
assert new_msg is not None
|
|
assert original_msg is not None
|
|
assert new_msg.sender_timestamp != original_msg.sender_timestamp
|
|
assert new_msg.text == original_msg.text
|
|
assert new_msg.outgoing is True
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_resend_new_timestamp_broadcasts_message(self, test_db):
|
|
"""new_timestamp=True broadcasts the new message via WebSocket."""
|
|
mc = _make_mc(name="MyNode")
|
|
chan_key = "dd" * 16
|
|
await ChannelRepository.upsert(key=chan_key, name="#broadcast")
|
|
|
|
old_ts = int(time.time()) - 5
|
|
msg_id = await MessageRepository.create(
|
|
msg_type="CHAN",
|
|
text="MyNode: broadcast test",
|
|
conversation_key=chan_key.upper(),
|
|
sender_timestamp=old_ts,
|
|
received_at=old_ts,
|
|
outgoing=True,
|
|
)
|
|
assert msg_id is not None
|
|
|
|
with (
|
|
patch("app.routers.messages.require_connected", return_value=mc),
|
|
patch.object(radio_manager, "_meshcore", mc),
|
|
patch("app.routers.messages.broadcast_event") as mock_broadcast,
|
|
):
|
|
result = await resend_channel_message(msg_id, new_timestamp=True)
|
|
|
|
mock_broadcast.assert_called_once()
|
|
event_type, event_data = mock_broadcast.call_args.args
|
|
assert event_type == "message"
|
|
assert event_data["id"] == result["message_id"]
|
|
assert event_data["outgoing"] is True
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_resend_byte_perfect_still_enforces_window(self, test_db):
|
|
"""Default (byte-perfect) resend still enforces the 30s window."""
|
|
mc = _make_mc(name="MyNode")
|
|
chan_key = "dd" * 16
|
|
await ChannelRepository.upsert(key=chan_key, name="#window")
|
|
|
|
old_ts = int(time.time()) - 60
|
|
msg_id = await MessageRepository.create(
|
|
msg_type="CHAN",
|
|
text="MyNode: expired",
|
|
conversation_key=chan_key.upper(),
|
|
sender_timestamp=old_ts,
|
|
received_at=old_ts,
|
|
outgoing=True,
|
|
)
|
|
assert msg_id is not None
|
|
|
|
with (
|
|
patch("app.routers.messages.require_connected", return_value=mc),
|
|
pytest.raises(HTTPException) as exc_info,
|
|
):
|
|
await resend_channel_message(msg_id, new_timestamp=False)
|
|
|
|
assert exc_info.value.status_code == 400
|
|
assert "expired" in exc_info.value.detail.lower()
|
|
|
|
|
|
class TestConcurrentChannelSends:
|
|
"""Test that concurrent channel sends are serialized by the radio operation lock.
|
|
|
|
The send_channel_message endpoint uses set_channel (slot 0) then send_chan_msg.
|
|
Concurrent sends must be serialized so two messages don't clobber the same
|
|
temporary radio slot.
|
|
"""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_concurrent_sends_to_different_channels_both_succeed(self, test_db):
|
|
"""Two concurrent send_channel_message calls to different channels
|
|
should both succeed — the radio_operation lock serializes them."""
|
|
mc = _make_mc(name="TestNode")
|
|
chan_key_a = "aa" * 16
|
|
chan_key_b = "bb" * 16
|
|
await ChannelRepository.upsert(key=chan_key_a, name="#alpha")
|
|
await ChannelRepository.upsert(key=chan_key_b, name="#bravo")
|
|
|
|
with (
|
|
patch("app.routers.messages.require_connected", return_value=mc),
|
|
patch.object(radio_manager, "_meshcore", mc),
|
|
patch("app.routers.messages.broadcast_event"),
|
|
):
|
|
results = await asyncio.gather(
|
|
send_channel_message(
|
|
SendChannelMessageRequest(channel_key=chan_key_a, text="Hello alpha")
|
|
),
|
|
send_channel_message(
|
|
SendChannelMessageRequest(channel_key=chan_key_b, text="Hello bravo")
|
|
),
|
|
)
|
|
|
|
# Both should have returned Message objects with distinct IDs
|
|
assert results[0].id != results[1].id
|
|
assert results[0].conversation_key == chan_key_a.upper()
|
|
assert results[1].conversation_key == chan_key_b.upper()
|
|
|
|
# set_channel should have been called twice (once per send, serialized)
|
|
assert mc.commands.set_channel.await_count == 2
|
|
|
|
# send_chan_msg should have been called twice
|
|
assert mc.commands.send_chan_msg.await_count == 2
|
|
|
|
# Both messages should be in DB
|
|
msgs_a = await MessageRepository.get_all(
|
|
msg_type="CHAN", conversation_key=chan_key_a.upper(), limit=10
|
|
)
|
|
msgs_b = await MessageRepository.get_all(
|
|
msg_type="CHAN", conversation_key=chan_key_b.upper(), limit=10
|
|
)
|
|
assert len(msgs_a) == 1
|
|
assert len(msgs_b) == 1
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_concurrent_sends_to_same_channel_both_succeed(self, test_db):
|
|
"""Two concurrent sends to the same channel should both succeed
|
|
with distinct timestamps (serialized, no slot clobber)."""
|
|
mc = _make_mc(name="TestNode")
|
|
chan_key = "cc" * 16
|
|
await ChannelRepository.upsert(key=chan_key, name="#charlie")
|
|
|
|
call_count = 0
|
|
|
|
# Mock time to return incrementing seconds so the two messages
|
|
# get distinct sender_timestamps (avoiding same-second collision).
|
|
original_time = time.time
|
|
|
|
def advancing_time():
|
|
nonlocal call_count
|
|
call_count += 1
|
|
return original_time() + call_count
|
|
|
|
with (
|
|
patch("app.routers.messages.require_connected", return_value=mc),
|
|
patch.object(radio_manager, "_meshcore", mc),
|
|
patch("app.routers.messages.broadcast_event"),
|
|
patch("app.routers.messages.time") as mock_time,
|
|
):
|
|
mock_time.time = advancing_time
|
|
results = await asyncio.gather(
|
|
send_channel_message(
|
|
SendChannelMessageRequest(channel_key=chan_key, text="Message one")
|
|
),
|
|
send_channel_message(
|
|
SendChannelMessageRequest(channel_key=chan_key, text="Message two")
|
|
),
|
|
)
|
|
|
|
assert results[0].id != results[1].id
|
|
texts = {results[0].text, results[1].text}
|
|
assert "TestNode: Message one" in texts
|
|
assert "TestNode: Message two" in texts
|
|
|
|
msgs = await MessageRepository.get_all(
|
|
msg_type="CHAN", conversation_key=chan_key.upper(), limit=10
|
|
)
|
|
assert len(msgs) == 2
|