Compare commits

..

106 Commits

Author SHA1 Message Date
Jack Kingsman 8ee08ff44a Updating changelog + build for 3.6.2 2026-03-29 19:55:49 -07:00
Jack Kingsman 6d9ea552bd Provide multi-platform docker builds. Closes #119. 2026-03-29 19:34:51 -07:00
Jack Kingsman 2cd71bf086 Fix linting 2026-03-29 19:09:36 -07:00
Jack Kingsman 08d55dec72 Show last error status on integrations. Closes #122. 2026-03-29 18:47:17 -07:00
Jack Kingsman 20532f70a3 Allow map uploader to follow redirects. Closes #123. 2026-03-29 18:15:10 -07:00
Jack Kingsman 659370e1eb Don't cast SNR/RSSI to string. Closes #121. 2026-03-29 18:02:59 -07:00
Jack Kingsman 7151cf3846 Be much, much clearer about room server ops. Closes #78. 2026-03-27 13:01:34 -07:00
Jack Kingsman 6e5256acce Be more flexible about radio offload. Closes #118. 2026-03-27 12:49:01 -07:00
Jack Kingsman 7d27567ae9 Merge pull request #109 from jkingsman/fix-room-server-ordering
Order room server messages by sender timestamp, not packet-receipt time
2026-03-27 10:18:21 -07:00
Jack Kingsman 5f0d042252 Fix time rendering unit issue 2026-03-26 21:32:23 -07:00
Jack Kingsman 6f68dfc609 Deal with non-existent hashes better 2026-03-26 20:36:13 -07:00
Jack Kingsman a32ddda79d Cut down bloat in unreads endpoint 2026-03-26 20:36:04 -07:00
Jack Kingsman ac6a5774af Updating changelog + build for 3.6.1 2026-03-26 19:14:44 -07:00
Jack Kingsman b12e612596 Merge pull request #117 from jkingsman/settings-scroll-fix. Closes #112
More content-paint patchy patchy bs
2026-03-26 18:27:55 -07:00
Jack Kingsman d1499ad75f Merge pull request #116 from kizniche/feat-int-mc-map-auto-uploader
Add automatic mesh map upload (integration/fanout module). Closes #108. Thank you!!
2026-03-26 18:08:34 -07:00
jkingsman 79d5e69ee0 Format + lint 2026-03-26 17:59:59 -07:00
jkingsman 498770bd88 More content-paint patchy patchy bs 2026-03-26 17:30:40 -07:00
jkingsman 1405df6039 Beef up some noopy tests 2026-03-26 17:22:42 -07:00
jkingsman ac5e71d6f2 Validate geofence radius to be positive 2026-03-26 17:20:13 -07:00
jkingsman 650a24a68c Centralize duplicated crypto code 2026-03-26 17:18:28 -07:00
Kizniche 53f122e503 formatting changes to satisfy check 2026-03-26 20:08:42 -04:00
Jack Kingsman bf0533807a Rich install script. Closes #111 2026-03-26 17:04:12 -07:00
jkingsman 094058bad7 Tweak install script 2026-03-26 16:59:53 -07:00
Kizniche efeb047116 Switching to using radio lat/lon, rename Community MQTT to Community Sharing, update AGENTS_fanout.md 2026-03-26 19:55:30 -04:00
jkingsman 88c99e0983 Add note in readme 2026-03-26 16:50:48 -07:00
jkingsman 983a37f68f Idempotentify and remove the explicit setup instructions in the advanced readme 2026-03-26 16:46:27 -07:00
jkingsman bea3495b79 Improve coverage around desktop notifications. Closes #115. 2026-03-26 16:39:38 -07:00
jkingsman 54c24c50d3 Clarify MQTT error logs when persistent 2026-03-26 13:39:08 -07:00
Kizniche b7972f50a8 Fix issues identified in failing checks 2026-03-25 19:06:33 -04:00
Kizniche bab1693c82 Fix freq and BW values, add geofence calc to dry run log 2026-03-25 18:39:27 -04:00
Kyle Gabriel f93844a01b Merge branch 'jkingsman:main' into feat-int-mc-map-auto-uploader 2026-03-25 14:40:59 -04:00
jkingsman 26b740fe3c Fix lint 2026-03-25 08:57:43 -07:00
jkingsman b0f5930e01 Swipe away 2026-03-25 08:46:50 -07:00
jkingsman 5b05fdefa1 Change room finder to be channels not rooms 2026-03-25 08:34:21 -07:00
jkingsman b63153b3a1 Initial swipe work 2026-03-25 08:32:06 -07:00
Jack Kingsman 3c5a832bef Merge pull request #113 from an0key/main
Update Sidebar.tsx
2026-03-25 08:19:04 -07:00
jkingsman fd8bc4b56a First draft of install script 2026-03-25 08:09:55 -07:00
Luke 2d943dedc5 Update Sidebar.tsx 2026-03-25 15:09:32 +00:00
Jack Kingsman 137f41970d Fix some places where we used vh instead of dvh for modal sizing 2026-03-24 21:07:20 -07:00
Jack Kingsman c833f1036b Test scroll fix for mobile browsers 2026-03-24 21:05:29 -07:00
Kyle Gabriel e15e6d83f7 Merge branch 'jkingsman:main' into feat-int-mc-map-auto-uploader 2026-03-24 19:55:14 -04:00
jkingsman 4ead2ffcde Add prebuilt frontend fetch script. Closes #110. 2026-03-24 16:42:49 -07:00
Kizniche f9ca35b3ae Switch from block list to allow list, add test to ensure certain nodes are skipped, fix test 2026-03-24 19:41:25 -04:00
Kizniche 7c4a244e05 Add geofence option 2026-03-24 19:41:25 -04:00
Kyle 6eab75ec7e Add Map Upload Integration and tests 2026-03-24 19:41:18 -04:00
jkingsman caf4bf4eff Fix linting 2026-03-24 16:32:19 -07:00
jkingsman 74e1f49db8 Show hop map in a larger modal. Closes #102. 2026-03-24 16:14:43 -07:00
jkingsman 95c874e643 Order room server messages by sender timestamp, not arrival-at-our-radio timestamp 2026-03-24 15:55:28 -07:00
Jack Kingsman 3b28ebfa49 Fix e2e tests 2026-03-24 14:51:29 -07:00
jkingsman d36c63f6b1 Complete room -> channel rename 2026-03-24 14:02:43 -07:00
jkingsman e8a4f5c349 Make a better integration/fanout selector 2026-03-24 13:48:50 -07:00
jkingsman b022aea71f Adjust phrasing on new-chat modal, and remove the unusable existing-contact scren. Closes #105. 2026-03-24 10:02:39 -07:00
jkingsman 5225a1c766 Don't be so eager on the quality gate 2026-03-24 09:59:37 -07:00
Jack Kingsman 41400c0528 Change page title and favicon for unreads. Green for favorite group chats, red for unread mentions or DMs. Closes #100 WOOOO 2026-03-23 21:36:54 -07:00
Jack Kingsman 07928d930c Clarify phrasing around bot system 2026-03-23 19:32:45 -07:00
Jack Kingsman 26742d0c88 Merge pull request #103 from jkingsman/bot-safety
Bot safety
2026-03-23 18:44:50 -07:00
Jack Kingsman 8b73bef30b More styling 2026-03-23 18:42:09 -07:00
Jack Kingsman 4b583fe337 Rephrasing and add env vars to docker compose 2026-03-23 18:36:55 -07:00
Jack Kingsman e6e7267eb1 Fix mobile modal 2026-03-23 18:33:37 -07:00
Jack Kingsman 36eeeae64d Protect against uncheck race condition 2026-03-23 18:27:42 -07:00
Jack Kingsman 7c988ae3d0 Initial bot safety warning pass 2026-03-23 15:16:04 -07:00
Jack Kingsman 1a0c4833d5 Enrich the error text for notification blockage and mention http/s issues 2026-03-23 09:12:17 -07:00
Jack Kingsman 84c500d018 Add clearer warning on frontend fetching invalid backend 2026-03-22 23:32:52 -07:00
Jack Kingsman 1960a16fb0 Add note about CORS + Basic auth 2026-03-22 23:28:33 -07:00
Jack Kingsman 3580aeda5a Updating changelog + build for 3.6.0 2026-03-22 22:14:55 -07:00
Jack Kingsman bb97b983bb Add room activity to stats view 2026-03-22 22:13:40 -07:00
Jack Kingsman da31b67d54 Add on-receive packet analyzer for canonical copy. Closes #97. 2026-03-22 21:34:41 -07:00
Jack Kingsman d840159f9c Update meshcore_py and remove monkeypatch for serial frame start detection. 2026-03-22 11:06:24 -07:00
Jack Kingsman 9de4158a6c Monkeypatch the meshcore_py lib for frame-start handling 2026-03-21 22:46:59 -07:00
Jack Kingsman 1e21644d74 Swap repeaters and room servers for better ordering, and the less common contact type at the bottom 2026-03-21 13:15:18 -07:00
Jack Kingsman df0ed8452b Add BYOPacket analyzer. Closes #98. 2026-03-20 21:57:07 -07:00
Jack Kingsman d4a5f0f728 Scroll in room server control pane. Closes #99. 2026-03-20 19:43:55 -07:00
Jack Kingsman 3e2c48457d Be more compact about the room server controls 2026-03-20 18:16:29 -07:00
Jack Kingsman d4f518df0c Retry e2e tests one before failing 2026-03-19 21:57:03 -07:00
Jack Kingsman 5213c8c84c Updating changelog + build for 3.5.0 2026-03-19 21:53:45 -07:00
Jack Kingsman 33c2b0c948 Be better about identity resolution for stats view 2026-03-19 21:42:39 -07:00
Jack Kingsman b021a4a8ac Fix e2e tests for contact stuff 2026-03-19 21:39:18 -07:00
Jack Kingsman c74fdec10b Add database information to debug endpoint 2026-03-19 21:17:23 -07:00
Jack Kingsman cf314e02ff Be cleaner about message cache dedupe after trimming inactive convos 2026-03-19 21:03:20 -07:00
Jack Kingsman 8ae600d010 Docs updates 2026-03-19 20:58:49 -07:00
Jack Kingsman fdd82e1f77 Clean up orphaned contact child rows and add foreign key enforcement 2026-03-19 20:56:36 -07:00
Jack Kingsman 9d129260fd Fix up the header collapse to be less terrible 2026-03-19 20:53:24 -07:00
Jack Kingsman 2b80760696 Add DB entry for outgoing inside the radio lock (didn't we just do the opposite?) 2026-03-19 20:43:35 -07:00
Jack Kingsman c2655c1809 Add basic room server support. Closes #78.
Allow basic room server usage
2026-03-19 20:28:44 -07:00
Jack Kingsman cee7103ec6 Don't log on missed login ack and don't make standalone contacts for repeater users 2026-03-19 20:26:10 -07:00
Jack Kingsman d05312c157 Add password-remember + warning on save 2026-03-19 20:10:59 -07:00
Jack Kingsman 5b166c4b66 Add room server 2026-03-19 19:22:40 -07:00
Jack Kingsman dbe2915635 Use metric by default 2026-03-19 17:56:04 -07:00
Jack Kingsman 2337d7b592 Remove Apprise duplicate names. Closes #88. 2026-03-19 17:44:51 -07:00
Jack Kingsman 62080424bb Multi-ack. Closes #81. 2026-03-19 17:30:34 -07:00
Jack Kingsman 1ae76848fe Improve test coverage 2026-03-19 17:19:35 -07:00
Jack Kingsman 45ed430580 Allow favorites to be sorted. Closes #91. 2026-03-19 17:05:34 -07:00
Jack Kingsman 5f8ce16855 Fix spacing around byte display on packet detail. Closes #93. 2026-03-19 16:58:27 -07:00
Jack Kingsman b79249c4a0 Add more realistic hop stats display 2026-03-19 16:49:06 -07:00
Jack Kingsman 85d1a940dc Update meshcore for three byte path failures 2026-03-19 09:57:06 -07:00
Jack Kingsman b85d451e26 Add packet feed clickable packet inspection. Closes #75 again. 2026-03-19 09:49:14 -07:00
Jack Kingsman 41a297c944 GIVE ME SMOOTS. Closes #87. 2026-03-18 22:43:34 -07:00
Jack Kingsman 41d64d86d4 Expand docker version testing coverage. Closes #84. 2026-03-18 22:09:44 -07:00
Jack Kingsman bd336e3ee2 Add fancy metrics view for packet feed. Closes #75. 2026-03-18 22:01:10 -07:00
Jack Kingsman cf585cdf87 Unread DMs are always red. Closes #86. 2026-03-18 21:05:40 -07:00
Jack Kingsman 417a583696 Use proper version formatting. Closes #70. 2026-03-18 20:50:56 -07:00
Jack Kingsman 541dba6a75 Fix migration to not import historical advert path 2026-03-19 03:45:51 +00:00
Jack Kingsman 720b8be64f Add e2e test 2026-03-19 03:45:51 +00:00
Jack Kingsman 2b5083e889 Doc updates 2026-03-19 03:45:51 +00:00
Jack Kingsman 5975006cf7 Dupe code cleanup 2026-03-19 03:45:51 +00:00
Jack Kingsman 69e09378f5 Pass 1 on PATH integration 2026-03-19 03:45:51 +00:00
168 changed files with 12941 additions and 1726 deletions
+10 -8
View File
@@ -165,7 +165,8 @@ MeshCore firmware can encode path hops as 1-byte, 2-byte, or 3-byte identifiers.
Direct-message send behavior intentionally mirrors the firmware/library `send_msg_with_retry(...)` flow: Direct-message send behavior intentionally mirrors the firmware/library `send_msg_with_retry(...)` flow:
- We push the contact's effective route to the radio via `add_contact(...)` before sending. - We push the contact's effective route to the radio via `add_contact(...)` before sending.
- Non-final attempts use the effective route (`override > direct > flood`). - If the initial `MSG_SENT` result includes an expected ACK code, background retries are armed.
- Non-final retry attempts use the effective route (`override > direct > flood`).
- Retry timing follows the radio's `suggested_timeout`. - Retry timing follows the radio's `suggested_timeout`.
- The final retry is sent as flood by resetting the path on the radio first, even if an override or direct route exists. - The final retry is sent as flood by resetting the path on the radio first, even if an override or direct route exists.
- Path math is always hop-count based; hop bytes are interpreted using the stored `path_hash_mode`. - Path math is always hop-count based; hop bytes are interpreted using the stored `path_hash_mode`.
@@ -174,7 +175,7 @@ Direct-message send behavior intentionally mirrors the firmware/library `send_ms
**Direct messages**: Expected ACK code is tracked. When ACK event arrives, message marked as acked. **Direct messages**: Expected ACK code is tracked. When ACK event arrives, message marked as acked.
Outgoing DMs send once immediately, then may retry up to 2 more times in the background if still unacked. Retry timing follows the radio's `suggested_timeout` from `PACKET_MSG_SENT`, and the final retry is sent as flood even when a routing override is configured. DM ACK state is terminal on first ACK: sibling retry ACK codes are cleared so one DM should not accumulate multiple delivery confirmations from different retry attempts. Outgoing DMs send once immediately, then may retry up to 2 more times in the background only when the initial `MSG_SENT` result includes an expected ACK code and the message remains unacked. Retry timing follows the radio's `suggested_timeout` from `PACKET_MSG_SENT`, and the final retry is sent as flood even when a routing override is configured. DM ACK state is terminal on first ACK: sibling retry ACK codes are cleared so one DM should not accumulate multiple delivery confirmations from different retry attempts.
ACKs are not a contact-route source. They drive message delivery state and may appear in analytics/detail surfaces, but they do not update `direct_path*` or otherwise influence route selection for future sends. ACKs are not a contact-route source. They drive message delivery state and may appear in analytics/detail surfaces, but they do not update `direct_path*` or otherwise influence route selection for future sends.
@@ -295,9 +296,9 @@ cd frontend
npm run test:run npm run test:run
``` ```
### Before Completing Changes ### Before Completing Major Changes
**Always run `./scripts/all_quality.sh` before finishing any changes that have modified code or tests.** It is the standard repo gate: autofix first, then type checks, tests, and the standard frontend build. This is not necessary for docs-only changes. **Run `./scripts/all_quality.sh` before finishing major changes that have modified code or tests.** It is the standard repo gate: autofix first, then type checks, tests, and the standard frontend build. This is not necessary for docs-only changes. For minor changes (like wording, color, spacing, etc.), wait until prompted to run the quality gate.
## API Summary ## API Summary
@@ -307,8 +308,8 @@ All endpoints are prefixed with `/api` (e.g., `/api/health`).
|--------|----------|-------------| |--------|----------|-------------|
| GET | `/api/health` | Connection status, fanout statuses, bots_disabled flag | | GET | `/api/health` | Connection status, fanout statuses, bots_disabled flag |
| GET | `/api/debug` | Support snapshot: recent logs, live radio probe, contact/channel drift audit, and running version/git info | | GET | `/api/debug` | Support snapshot: recent logs, live radio probe, contact/channel drift audit, and running version/git info |
| GET | `/api/radio/config` | Radio configuration, including `path_hash_mode`, `path_hash_mode_supported`, and whether adverts include current node location | | GET | `/api/radio/config` | Radio configuration, including `path_hash_mode`, `path_hash_mode_supported`, advert-location on/off, and `multi_acks_enabled` |
| PATCH | `/api/radio/config` | Update name, location, advert-location on/off, radio params, and `path_hash_mode` when supported | | PATCH | `/api/radio/config` | Update name, location, advert-location on/off, `multi_acks_enabled`, radio params, and `path_hash_mode` when supported |
| PUT | `/api/radio/private-key` | Import private key to radio | | PUT | `/api/radio/private-key` | Import private key to radio |
| POST | `/api/radio/advertise` | Send advertisement (`mode`: `flood` or `zero_hop`, default `flood`) | | POST | `/api/radio/advertise` | Send advertisement (`mode`: `flood` or `zero_hop`, default `flood`) |
| POST | `/api/radio/discover` | Run a short mesh discovery sweep for nearby repeaters/sensors | | POST | `/api/radio/discover` | Run a short mesh discovery sweep for nearby repeaters/sensors |
@@ -324,6 +325,7 @@ All endpoints are prefixed with `/api` (e.g., `/api/health`).
| POST | `/api/contacts/{public_key}/command` | Send CLI command to repeater | | POST | `/api/contacts/{public_key}/command` | Send CLI command to repeater |
| POST | `/api/contacts/{public_key}/routing-override` | Set or clear a forced routing override | | POST | `/api/contacts/{public_key}/routing-override` | Set or clear a forced routing override |
| POST | `/api/contacts/{public_key}/trace` | Trace route to contact | | POST | `/api/contacts/{public_key}/trace` | Trace route to contact |
| POST | `/api/contacts/{public_key}/path-discovery` | Discover forward/return paths and persist the learned direct route |
| POST | `/api/contacts/{public_key}/repeater/login` | Log in to a repeater | | POST | `/api/contacts/{public_key}/repeater/login` | Log in to a repeater |
| POST | `/api/contacts/{public_key}/repeater/status` | Fetch repeater status telemetry | | POST | `/api/contacts/{public_key}/repeater/status` | Fetch repeater status telemetry |
| POST | `/api/contacts/{public_key}/repeater/lpp-telemetry` | Fetch CayenneLPP sensor data | | POST | `/api/contacts/{public_key}/repeater/lpp-telemetry` | Fetch CayenneLPP sensor data |
@@ -348,7 +350,7 @@ All endpoints are prefixed with `/api` (e.g., `/api/health`).
| GET | `/api/packets/undecrypted/count` | Count of undecrypted packets | | GET | `/api/packets/undecrypted/count` | Count of undecrypted packets |
| POST | `/api/packets/decrypt/historical` | Decrypt stored packets | | POST | `/api/packets/decrypt/historical` | Decrypt stored packets |
| POST | `/api/packets/maintenance` | Delete old packets and vacuum | | POST | `/api/packets/maintenance` | Delete old packets and vacuum |
| GET | `/api/read-state/unreads` | Server-computed unread counts, mentions, last message times | | GET | `/api/read-state/unreads` | Server-computed unread counts, mentions, last message times, and `last_read_ats` boundaries |
| POST | `/api/read-state/mark-all-read` | Mark all conversations as read | | POST | `/api/read-state/mark-all-read` | Mark all conversations as read |
| GET | `/api/settings` | Get app settings | | GET | `/api/settings` | Get app settings |
| PATCH | `/api/settings` | Update app settings | | PATCH | `/api/settings` | Update app settings |
@@ -398,7 +400,7 @@ Read state (`last_read_at`) is tracked **server-side** for consistency across de
- Stored as Unix timestamp in `contacts.last_read_at` and `channels.last_read_at` - Stored as Unix timestamp in `contacts.last_read_at` and `channels.last_read_at`
- Updated via `POST /api/contacts/{public_key}/mark-read` and `POST /api/channels/{key}/mark-read` - Updated via `POST /api/contacts/{public_key}/mark-read` and `POST /api/channels/{key}/mark-read`
- Bulk update via `POST /api/read-state/mark-all-read` - Bulk update via `POST /api/read-state/mark-all-read`
- Aggregated counts via `GET /api/read-state/unreads` (server-side computation) - Aggregated counts via `GET /api/read-state/unreads` (server-side computation of counts, mention flags, `last_message_times`, and `last_read_ats`)
**State Tracking Keys (Frontend)**: Generated by `getStateKey()` for message times (sidebar sorting): **State Tracking Keys (Frontend)**: Generated by `getStateKey()` for message times (sidebar sorting):
- Channels: `channel-{channel_key}` - Channels: `channel-{channel_key}`
+58
View File
@@ -1,3 +1,61 @@
## [3.6.2] - 2026-03-29
Feature: Be more flexible about timing and volume of full contact offload
Feature: Improve room server and repeater ops to be much more clearer about auth status
Feature: Show last error status on integrations
Feature: Push multi-platform docker builds
Bugfix: Fix advert interval time unit display
Bugfix: Don't cast RSSI/SNR to string for community MQTT
Bugfix: Map uploader follows redirect
Misc: Thin out unnecessary cruft in unreads endpoint
Misc: Fall back gracefully if linked to an unknown contact
## [3.6.1] - 2026-03-26
Feature: MeshCore Map integration
Feature: Add warning screen about bots
Feature: Favicon reflects unread message state
Feature: Show hop map in larger modal
Feature: Add prebuilt frontend install script
Feature: Add clean service installer script
Feature: Swipe in to show menu
Bugfix: Invalid backend API path serves error, not fallback index
Bugfix: Fix some spacing/page height issues
Misc: Misc. bugfixes and performance and test improvements
## [3.6.0] - 2026-03-22
Feature: Add incoming-packet analytics
Feature: BYOPacket for analysis
Feature: Add room activity to stats view
Bugfix: Handle Heltec v3 serial noise
Misc: Swap repeaters and room servers for better ordering
## [3.5.0] - 2026-03-19
Feature: Add room server alpha support
Feature: Add option to force-reset node clock when it's too far ahead
Feature: DMs auto-retry before resorting to flood
Feature: Add impulse zero-hop advert
Feature: Utilize PATH packets to correctly source a contact's route
Feature: Metrics view on raw packet pane
Feature: Metric, Imperial, and Smoots are now selectable for distance display
Feature: Allow favorites to be sorted
Feature: Add multi-ack support
Feature: Password-remember checkbox on repeaters + room servers
Bugfix: Serialize radio disconnect in a lock
Bugfix: Fix contact bar layout issues
Bugfix: Fix sidebar ordering for contacts by advert recency
Bugfix: Fix version reporting in community MQTT
Bugfix: Fix Apprise duplicate names
Bugfix: Be better about identity resolution in the stats pane
Misc: Docs, test, and performance enhancements
Misc: Don't prompt "Are you sure" when leaving an unedited interation
Misc: Log node time on startup
Misc: Improve community MQTT error bubble-up
Misc: Unread DMs always have a red unread counter
Misc: Improve information in the debug view to show DB status
## [3.4.1] - 2026-03-16 ## [3.4.1] - 2026-03-16
Bugfix: Improve handling of version information on prebuilt bundles Bugfix: Improve handling of version information on prebuilt bundles
+34 -1
View File
@@ -330,7 +330,7 @@ THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
</details> </details>
### meshcore (2.2.29) — MIT ### meshcore (2.3.2) — MIT
<details> <details>
<summary>Full license text</summary> <summary>Full license text</summary>
@@ -1592,6 +1592,39 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
</details> </details>
### react-swipeable (7.0.2) — MIT
<details>
<summary>Full license text</summary>
```
The MIT License (MIT)
Copyright (C) 2014-2022 Josh Perez
Copyright (C) 2014-2022 Brian Emil Hartz
Copyright (C) 2022 Formidable Labs, Inc.
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.
```
</details>
### sonner (2.0.7) — MIT ### sonner (2.0.7) — MIT
<details> <details>
+17 -4
View File
@@ -7,7 +7,7 @@ Backend server + browser interface for MeshCore mesh radio networks. Connect you
* Run multiple Python bots that can analyze messages and respond to DMs and channels * Run multiple Python bots that can analyze messages and respond to DMs and channels
* Monitor unlimited contacts and channels (radio limits don't apply -- packets are decrypted server-side) * Monitor unlimited contacts and channels (radio limits don't apply -- packets are decrypted server-side)
* Access your radio remotely over your network or VPN * Access your radio remotely over your network or VPN
* Search for hashtag room names for channels you don't have keys for yet * Search for hashtag channel names for channels you don't have keys for yet
* Forward packets to MQTT, LetsMesh, MeshRank, SQS, Apprise, etc. * Forward packets to MQTT, LetsMesh, MeshRank, SQS, Apprise, etc.
* Use the more recent 1.14 firmwares which support multibyte pathing * Use the more recent 1.14 firmwares which support multibyte pathing
* Visualize the mesh as a map or node set, view repeater stats, and more! * Visualize the mesh as a map or node set, view repeater stats, and more!
@@ -41,8 +41,6 @@ If you plan to contribute, read [CONTRIBUTING.md](CONTRIBUTING.md).
- [UV](https://astral.sh/uv) package manager: `curl -LsSf https://astral.sh/uv/install.sh | sh` - [UV](https://astral.sh/uv) package manager: `curl -LsSf https://astral.sh/uv/install.sh | sh`
- MeshCore radio connected via USB serial, TCP, or BLE - MeshCore radio connected via USB serial, TCP, or BLE
If you are on a low-resource system and do not want to build the frontend locally, download the release zip named `remoteterm-prebuilt-frontend-vX.X.X-<short hash>.zip`. That bundle includes `frontend/prebuilt`, so you can run the app without doing a frontend build from source.
<details> <details>
<summary>Finding your serial port</summary> <summary>Finding your serial port</summary>
@@ -97,6 +95,8 @@ Access the app at http://localhost:8000.
Source checkouts expect a normal frontend build in `frontend/dist`. Source checkouts expect a normal frontend build in `frontend/dist`.
On Linux, if you want this installed as a persistent `systemd` service that starts on boot and restarts automatically on failure, run `bash scripts/install_service.sh` from the repo root.
## Path 1.5: Use The Prebuilt Release Zip ## Path 1.5: Use The Prebuilt Release Zip
Release zips can be found as an asset within the [releases listed here](https://github.com/jkingsman/Remote-Terminal-for-MeshCore/releases). This can be beneficial on resource constrained systems that cannot cope with the RAM-hungry frontend build process. Release zips can be found as an asset within the [releases listed here](https://github.com/jkingsman/Remote-Terminal-for-MeshCore/releases). This can be beneficial on resource constrained systems that cannot cope with the RAM-hungry frontend build process.
@@ -111,10 +111,14 @@ uv run uvicorn app.main:app --host 0.0.0.0 --port 8000
The release bundle includes `frontend/prebuilt`, so it does not require a local frontend build. The release bundle includes `frontend/prebuilt`, so it does not require a local frontend build.
Alternatively, if you have already cloned the repo, you can fetch just the prebuilt frontend into your working tree without downloading the full release zip via `python3 scripts/fetch_prebuilt_frontend.py`.
## Path 2: Docker ## Path 2: Docker
> **Warning:** Docker has had reports intermittent issues with serial event subscriptions. The native method above is more reliable. > **Warning:** Docker has had reports intermittent issues with serial event subscriptions. The native method above is more reliable.
Local Docker builds are architecture-native by default. On Apple Silicon Macs and ARM64 Linux hosts such as Raspberry Pi, `docker compose build` / `docker compose up --build` will produce an ARM64 image unless you override the platform.
Edit `docker-compose.yaml` to set a serial device for passthrough, or uncomment your transport (serial or TCP). Then: Edit `docker-compose.yaml` to set a serial device for passthrough, or uncomment your transport (serial or TCP). Then:
```bash ```bash
@@ -146,6 +150,15 @@ docker compose pull
docker compose up -d docker compose up -d
``` ```
Published Docker tags are intended to be multi-arch (`linux/amd64` and `linux/arm64`). If you are building and publishing manually, use Docker Buildx:
```bash
docker buildx build \
--platform linux/amd64,linux/arm64 \
-t jkingsman/remoteterm-meshcore:latest \
--push .
```
The container runs as root by default for maximum serial passthrough compatibility across host setups. On Linux, if you switch between native and Docker runs, `./data` can end up root-owned. If you do not need that serial compatibility behavior, you can enable the optional `user: "${UID:-1000}:${GID:-1000}"` line in `docker-compose.yaml` to keep ownership aligned with your host user. The container runs as root by default for maximum serial passthrough compatibility across host setups. On Linux, if you switch between native and Docker runs, `./data` can end up root-owned. If you do not need that serial compatibility behavior, you can enable the optional `user: "${UID:-1000}:${GID:-1000}"` line in `docker-compose.yaml` to keep ownership aligned with your host user.
To stop: To stop:
@@ -192,7 +205,7 @@ $env:MESHCORE_SERIAL_PORT="COM8" # or your COM port
uv run uvicorn app.main:app --host 0.0.0.0 --port 8000 uv run uvicorn app.main:app --host 0.0.0.0 --port 8000
``` ```
If you enable Basic Auth, protect the app with HTTPS. HTTP Basic credentials are not safe on plain HTTP. If you enable Basic Auth, protect the app with HTTPS. HTTP Basic credentials are not safe on plain HTTP. Also note that the app's permissive CORS policy is a deliberate trusted-network tradeoff, so cross-origin browser JavaScript is not a reliable way to use that Basic Auth gate.
## Where To Go Next ## Where To Go Next
+24 -46
View File
@@ -21,7 +21,7 @@ If the audit finds a mismatch, you'll see an error in the application UI and you
## HTTPS ## HTTPS
WebGPU room-finding requires a secure context when you are not on `localhost`. WebGPU channel-finding requires a secure context when you are not on `localhost`.
Generate a local cert and start the backend with TLS: Generate a local cert and start the backend with TLS:
@@ -46,59 +46,37 @@ Accept the browser warning, or use [mkcert](https://github.com/FiloSottile/mkcer
## Systemd Service ## Systemd Service
Assumes you are running from `/opt/remoteterm`; adjust paths if you deploy elsewhere. Two paths are available depending on your comfort level with Linux system administration.
### Simple install (recommended for most users)
On Linux systems, this is the recommended installation method if you want RemoteTerm set up as a persistent systemd service that starts automatically on boot and restarts automatically if it crashes. Run the installer script from the repo root. It runs as your current user, installs from wherever you cloned the repo, and prints a quick-reference cheatsheet when done — no separate service account or path juggling required.
```bash ```bash
# Create service user bash scripts/install_service.sh
sudo useradd -r -m -s /bin/false remoteterm
# Install to /opt/remoteterm
sudo mkdir -p /opt/remoteterm
sudo cp -r . /opt/remoteterm/
sudo chown -R remoteterm:remoteterm /opt/remoteterm
# Install dependencies
cd /opt/remoteterm
sudo -u remoteterm uv venv
sudo -u remoteterm uv sync
# If deploying from a source checkout, build the frontend first
sudo -u remoteterm bash -lc 'cd /opt/remoteterm/frontend && npm install && npm run build'
# If deploying from the release zip artifact, frontend/prebuilt is already present
``` ```
Create `/etc/systemd/system/remoteterm.service` with: The script interactively asks which transport to use (serial auto-detect, serial with explicit port, TCP, or BLE), whether to build the frontend locally or download a prebuilt copy, whether to enable the bot system, and whether to set up HTTP Basic Auth. It handles dependency installation (`uv sync`), validates `node`/`npm` for local builds, adds your user to the `dialout` group if needed, writes the systemd unit file, and enables the service. After installation, normal operations work without any `sudo -u` gymnastics:
```ini You can also rerun the script later to change transport, bot, or auth settings. If the service is already running, the installer stops it, rewrites the unit file, reloads systemd, and starts it again with the new configuration.
[Unit]
Description=RemoteTerm for MeshCore
After=network.target
[Service]
Type=simple
User=remoteterm
Group=remoteterm
WorkingDirectory=/opt/remoteterm
ExecStart=/opt/remoteterm/.venv/bin/uvicorn app.main:app --host 0.0.0.0 --port 8000
Restart=always
RestartSec=5
Environment=MESHCORE_DATABASE_PATH=/opt/remoteterm/data/meshcore.db
# Uncomment and set if auto-detection doesn't work:
# Environment=MESHCORE_SERIAL_PORT=/dev/ttyUSB0
SupplementaryGroups=dialout
[Install]
WantedBy=multi-user.target
```
Then install and start it:
```bash ```bash
sudo systemctl daemon-reload # Update to latest and restart
sudo systemctl enable --now remoteterm cd /path/to/repo
sudo systemctl status remoteterm git pull
uv sync
cd frontend && npm install && npm run build && cd ..
sudo systemctl restart remoteterm
# Refresh prebuilt frontend only (skips local build)
python3 scripts/fetch_prebuilt_frontend.py
sudo systemctl restart remoteterm
# View live logs
sudo journalctl -u remoteterm -f sudo journalctl -u remoteterm -f
# Service control
sudo systemctl start|stop|restart|status remoteterm
``` ```
## Debug Logging And Bug Reports ## Debug Logging And Bug Reports
+8 -7
View File
@@ -101,7 +101,7 @@ app/
- Packet `path_len` values are hop counts, not byte counts. - Packet `path_len` values are hop counts, not byte counts.
- Hop width comes from the packet or radio `path_hash_mode`: `0` = 1-byte, `1` = 2-byte, `2` = 3-byte. - Hop width comes from the packet or radio `path_hash_mode`: `0` = 1-byte, `1` = 2-byte, `2` = 3-byte.
- Channel slot count comes from firmware-reported `DEVICE_INFO.max_channels`; do not hardcode `40` when scanning/offloading channel slots. - Channel slot count comes from firmware-reported `DEVICE_INFO.max_channels`; do not hardcode `40` when scanning/offloading channel slots.
- Channel sends use a session-local LRU slot cache after startup channel offload clears the radio. Repeated sends to the same room reuse the loaded slot; new rooms fill free slots up to the discovered channel capacity, then evict the least recently used cached room. - Channel sends use a session-local LRU slot cache after startup channel offload clears the radio. Repeated sends to the same channel reuse the loaded slot; new channels fill free slots up to the discovered channel capacity, then evict the least recently used cached channel.
- TCP radios do not reuse cached slot contents. For TCP, channel sends still force `set_channel(...)` before every send because this backend does not have exclusive device access. - TCP radios do not reuse cached slot contents. For TCP, channel sends still force `set_channel(...)` before every send because this backend does not have exclusive device access.
- `MESHCORE_FORCE_CHANNEL_SLOT_RECONFIGURE=true` disables slot reuse on all transports and forces the old always-`set_channel(...)` behavior before every channel send. - `MESHCORE_FORCE_CHANNEL_SLOT_RECONFIGURE=true` disables slot reuse on all transports and forces the old always-`set_channel(...)` behavior before every channel send.
- Contacts persist canonical direct-route fields (`direct_path`, `direct_path_len`, `direct_path_hash_mode`) so contact sync and outbound DM routing reuse the exact stored hop width instead of inferring from path bytes. - Contacts persist canonical direct-route fields (`direct_path`, `direct_path_len`, `direct_path_hash_mode`) so contact sync and outbound DM routing reuse the exact stored hop width instead of inferring from path bytes.
@@ -113,16 +113,16 @@ app/
### Read/unread state ### Read/unread state
- Server is source of truth (`contacts.last_read_at`, `channels.last_read_at`). - Server is source of truth (`contacts.last_read_at`, `channels.last_read_at`).
- `GET /api/read-state/unreads` returns counts, mention flags, and `last_message_times`. - `GET /api/read-state/unreads` returns counts, mention flags, `last_message_times`, and `last_read_ats`.
### DM ingest + ACKs ### DM ingest + ACKs
- `services/dm_ingest.py` is the one place that should decide fallback-context resolution, DM dedup/reconciliation, and packet-linked vs. content-based storage behavior. - `services/dm_ingest.py` is the one place that should decide fallback-context resolution, DM dedup/reconciliation, and packet-linked vs. content-based storage behavior.
- `CONTACT_MSG_RECV` is a fallback path, not a parallel source of truth. If you change DM storage behavior, trace both `event_handlers.py` and `packet_processor.py`. - `CONTACT_MSG_RECV` is a fallback path, not a parallel source of truth. If you change DM storage behavior, trace both `event_handlers.py` and `packet_processor.py`.
- DM ACK tracking is an in-memory pending/buffered map in `services/dm_ack_tracker.py`, with periodic expiry from `radio_sync.py`. - DM ACK tracking is an in-memory pending/buffered map in `services/dm_ack_tracker.py`, with periodic expiry from `radio_sync.py`.
- Outgoing DMs send once inline, store/broadcast immediately after the first successful `MSG_SENT`, then may retry up to 2 more times in the background if still unacked. - Outgoing DMs send once inline, store/broadcast immediately after the first successful `MSG_SENT`, then may retry up to 2 more times in the background only when the initial `MSG_SENT` result includes an expected ACK code and the message remains unacked.
- DM retry timing follows the firmware-provided `suggested_timeout` from `PACKET_MSG_SENT`; do not replace it with a fixed app timeout unless you intentionally want more aggressive duplicate-prone retries. - DM retry timing follows the firmware-provided `suggested_timeout` from `PACKET_MSG_SENT`; do not replace it with a fixed app timeout unless you intentionally want more aggressive duplicate-prone retries.
- Direct-message send behavior is intended to emulate `meshcore_py.commands.send_msg_with_retry(...)`: stage the effective contact route on the radio, send, wait for ACK, and on the final retry force flood via `reset_path(...)`. - Direct-message send behavior is intended to emulate `meshcore_py.commands.send_msg_with_retry(...)` when the radio provides an expected ACK code: stage the effective contact route on the radio, send, wait for ACK, and on the final retry force flood via `reset_path(...)`.
- Non-final DM attempts use the contact's effective route (`override > direct > flood`). The final retry is intentionally sent as flood even when a routing override exists. - Non-final DM attempts use the contact's effective route (`override > direct > flood`). The final retry is intentionally sent as flood even when a routing override exists.
- DM ACK state is terminal on first ACK. Retry attempts may register multiple expected ACK codes for the same message, but sibling pending codes are cleared once one ACK wins so a DM should not accrue multiple delivery confirmations from retries. - DM ACK state is terminal on first ACK. Retry attempts may register multiple expected ACK codes for the same message, but sibling pending codes are cleared once one ACK wins so a DM should not accrue multiple delivery confirmations from retries.
- ACKs are delivery state, not routing state. Bundled ACKs inside PATH packets still satisfy pending DM sends, but ACK history does not feed contact route learning. - ACKs are delivery state, not routing state. Bundled ACKs inside PATH packets still satisfy pending DM sends, but ACK history does not feed contact route learning.
@@ -169,8 +169,8 @@ app/
- `GET /debug` — support snapshot with recent logs, live radio probe, slot/contact audits, and version/git info - `GET /debug` — support snapshot with recent logs, live radio probe, slot/contact audits, and version/git info
### Radio ### Radio
- `GET /radio/config` — includes `path_hash_mode`, `path_hash_mode_supported`, and advert-location on/off - `GET /radio/config` — includes `path_hash_mode`, `path_hash_mode_supported`, advert-location on/off, and `multi_acks_enabled`
- `PATCH /radio/config` — may update `path_hash_mode` (`0..2`) when firmware supports it - `PATCH /radio/config` — may update `path_hash_mode` (`0..2`) when firmware supports it, and `multi_acks_enabled`
- `PUT /radio/private-key` - `PUT /radio/private-key`
- `POST /radio/advertise` — manual advert send; request body may set `mode` to `flood` or `zero_hop` (defaults to `flood`) - `POST /radio/advertise` — manual advert send; request body may set `mode` to `flood` or `zero_hop` (defaults to `flood`)
- `POST /radio/discover` — short mesh discovery sweep for nearby repeaters/sensors - `POST /radio/discover` — short mesh discovery sweep for nearby repeaters/sensors
@@ -188,6 +188,7 @@ app/
- `POST /contacts/{public_key}/command` - `POST /contacts/{public_key}/command`
- `POST /contacts/{public_key}/routing-override` - `POST /contacts/{public_key}/routing-override`
- `POST /contacts/{public_key}/trace` - `POST /contacts/{public_key}/trace`
- `POST /contacts/{public_key}/path-discovery` — discover forward/return paths, persist the learned direct route, and sync it back to the radio best-effort
- `POST /contacts/{public_key}/repeater/login` - `POST /contacts/{public_key}/repeater/login`
- `POST /contacts/{public_key}/repeater/status` - `POST /contacts/{public_key}/repeater/status`
- `POST /contacts/{public_key}/repeater/lpp-telemetry` - `POST /contacts/{public_key}/repeater/lpp-telemetry`
@@ -219,7 +220,7 @@ app/
- `POST /packets/maintenance` - `POST /packets/maintenance`
### Read state ### Read state
- `GET /read-state/unreads` - `GET /read-state/unreads` — counts, mention flags, `last_message_times`, and `last_read_ats`
- `POST /read-state/mark-all-read` - `POST /read-state/mark-all-read`
### Settings ### Settings
+17
View File
@@ -58,6 +58,15 @@ class DecryptedDirectMessage:
message: str message: str
dest_hash: str # First byte of destination pubkey as hex dest_hash: str # First byte of destination pubkey as hex
src_hash: str # First byte of sender pubkey as hex src_hash: str # First byte of sender pubkey as hex
signed_sender_prefix: str | None = None
@property
def txt_type(self) -> int:
return self.flags >> 2
@property
def attempt(self) -> int:
return self.flags & 0x03
@dataclass @dataclass
@@ -498,6 +507,13 @@ def decrypt_direct_message(payload: bytes, shared_secret: bytes) -> DecryptedDir
# Extract message text (UTF-8, null-padded) # Extract message text (UTF-8, null-padded)
message_bytes = decrypted[5:] message_bytes = decrypted[5:]
signed_sender_prefix: str | None = None
txt_type = flags >> 2
if txt_type == 2:
if len(message_bytes) < 4:
return None
signed_sender_prefix = message_bytes[:4].hex()
message_bytes = message_bytes[4:]
try: try:
message_text = message_bytes.decode("utf-8") message_text = message_bytes.decode("utf-8")
# Truncate at first null terminator (consistent with channel message handling) # Truncate at first null terminator (consistent with channel message handling)
@@ -513,6 +529,7 @@ def decrypt_direct_message(payload: bytes, shared_secret: bytes) -> DecryptedDir
message=message_text, message=message_text,
dest_hash=dest_hash, dest_hash=dest_hash,
src_hash=src_hash, src_hash=src_hash,
signed_sender_prefix=signed_sender_prefix,
) )
+22 -4
View File
@@ -4,7 +4,7 @@ from typing import TYPE_CHECKING
from meshcore import EventType from meshcore import EventType
from app.models import Contact, ContactUpsert from app.models import CONTACT_TYPE_ROOM, Contact, ContactUpsert
from app.packet_processor import process_raw_packet from app.packet_processor import process_raw_packet
from app.repository import ( from app.repository import (
ContactRepository, ContactRepository,
@@ -17,6 +17,7 @@ from app.services.contact_reconciliation import (
from app.services.dm_ack_apply import apply_dm_ack_code from app.services.dm_ack_apply import apply_dm_ack_code
from app.services.dm_ingest import ( from app.services.dm_ingest import (
ingest_fallback_direct_message, ingest_fallback_direct_message,
resolve_direct_message_sender_metadata,
resolve_fallback_direct_message_context, resolve_fallback_direct_message_context,
) )
from app.websocket import broadcast_event from app.websocket import broadcast_event
@@ -87,6 +88,23 @@ async def on_contact_message(event: "Event") -> None:
sender_timestamp = ts if ts is not None else received_at sender_timestamp = ts if ts is not None else received_at
path = payload.get("path") path = payload.get("path")
path_len = payload.get("path_len") path_len = payload.get("path_len")
sender_name = context.sender_name
sender_key = context.sender_key
signature = payload.get("signature")
if (
context.contact is not None
and context.contact.type == CONTACT_TYPE_ROOM
and txt_type == 2
and isinstance(signature, str)
and signature
):
sender_name, sender_key = await resolve_direct_message_sender_metadata(
sender_public_key=signature,
received_at=received_at,
broadcast_fn=broadcast_event,
contact_repository=ContactRepository,
log=logger,
)
message = await ingest_fallback_direct_message( message = await ingest_fallback_direct_message(
conversation_key=context.conversation_key, conversation_key=context.conversation_key,
text=payload.get("text", ""), text=payload.get("text", ""),
@@ -95,9 +113,9 @@ async def on_contact_message(event: "Event") -> None:
path=path, path=path,
path_len=path_len, path_len=path_len,
txt_type=txt_type, txt_type=txt_type,
signature=payload.get("signature"), signature=signature,
sender_name=context.sender_name, sender_name=sender_name,
sender_key=context.sender_key, sender_key=sender_key,
broadcast_fn=broadcast_event, broadcast_fn=broadcast_event,
update_last_contacted_key=context.contact.public_key.lower() if context.contact else None, update_last_contacted_key=context.contact.public_key.lower() if context.contact else None,
) )
+1
View File
@@ -44,6 +44,7 @@ class MessageAckedPayload(TypedDict):
message_id: int message_id: int
ack_count: int ack_count: int
paths: NotRequired[list[MessagePath]] paths: NotRequired[list[MessagePath]]
packet_id: NotRequired[int | None]
class ToastPayload(TypedDict): class ToastPayload(TypedDict):
+16
View File
@@ -65,6 +65,7 @@ Wraps bot code execution via `app/fanout/bot_exec.py`. Config blob:
- `code` — Python bot function source code - `code` — Python bot function source code
- Executes in a thread pool with timeout and semaphore concurrency control - Executes in a thread pool with timeout and semaphore concurrency control
- Rate-limits outgoing messages for repeater compatibility - Rate-limits outgoing messages for repeater compatibility
- Channel `message_text` passed to bot code is normalized for human readability by stripping a leading `"{sender_name}: "` prefix when it matches the payload sender.
### webhook (webhook.py) ### webhook (webhook.py)
HTTP webhook delivery. Config blob: HTTP webhook delivery. Config blob:
@@ -78,6 +79,7 @@ Push notifications via Apprise library. Config blob:
- `urls` — newline-separated Apprise notification service URLs - `urls` — newline-separated Apprise notification service URLs
- `preserve_identity` — suppress Discord webhook name/avatar override - `preserve_identity` — suppress Discord webhook name/avatar override
- `include_path` — include routing path in notification body - `include_path` — include routing path in notification body
- Channel notifications normalize stored message text by stripping a leading `"{sender_name}: "` prefix when it matches the payload sender so alerts do not duplicate the name.
### sqs (sqs.py) ### sqs (sqs.py)
Amazon SQS delivery. Config blob: Amazon SQS delivery. Config blob:
@@ -87,6 +89,19 @@ Amazon SQS delivery. Config blob:
- Publishes a JSON envelope of the form `{"event_type":"message"|"raw_packet","data":...}` - Publishes a JSON envelope of the form `{"event_type":"message"|"raw_packet","data":...}`
- Supports both decoded messages and raw packets via normal scope selection - Supports both decoded messages and raw packets via normal scope selection
### map_upload (map_upload.py)
Uploads heard repeater and room-server advertisements to map.meshcore.dev. Config blob:
- `api_url` (optional, default `""`) — upload endpoint; empty falls back to the public map.meshcore.dev API
- `dry_run` (bool, default `true`) — when true, logs the payload at INFO level without sending
- `geofence_enabled` (bool, default `false`) — when true, only uploads nodes within `geofence_radius_km` of the radio's own configured lat/lon
- `geofence_radius_km` (float, default `0`) — filter radius in kilometres
Geofence notes:
- The reference center is always the radio's own `adv_lat`/`adv_lon` from `radio_runtime.meshcore.self_info`, read **live at upload time** — no lat/lon is stored in the fanout config itself.
- If the radio's lat/lon is `(0, 0)` or the radio is not connected, the geofence check is silently skipped so uploads continue normally until coordinates are configured.
- Requires the radio to have `ENABLE_PRIVATE_KEY_EXPORT=1` firmware to sign uploads.
- Scope is always `{"messages": "none", "raw_packets": "all"}` — only raw RF packets are processed.
## Adding a New Integration Type ## Adding a New Integration Type
### Step-by-step checklist ### Step-by-step checklist
@@ -289,6 +304,7 @@ Migrations:
- `app/fanout/webhook.py` — Webhook fanout module - `app/fanout/webhook.py` — Webhook fanout module
- `app/fanout/apprise_mod.py` — Apprise fanout module - `app/fanout/apprise_mod.py` — Apprise fanout module
- `app/fanout/sqs.py` — Amazon SQS fanout module - `app/fanout/sqs.py` — Amazon SQS fanout module
- `app/fanout/map_upload.py` — Map Upload fanout module
- `app/repository/fanout.py` — Database CRUD - `app/repository/fanout.py` — Database CRUD
- `app/routers/fanout.py` — REST API - `app/routers/fanout.py` — REST API
- `app/websocket.py``broadcast_event()` dispatches to fanout - `app/websocket.py``broadcast_event()` dispatches to fanout
+5 -6
View File
@@ -6,7 +6,7 @@ import asyncio
import logging import logging
from urllib.parse import parse_qsl, urlencode, urlsplit, urlunsplit from urllib.parse import parse_qsl, urlencode, urlsplit, urlunsplit
from app.fanout.base import FanoutModule from app.fanout.base import FanoutModule, get_fanout_message_text
from app.path_utils import split_path_hex from app.path_utils import split_path_hex
logger = logging.getLogger(__name__) logger = logging.getLogger(__name__)
@@ -39,7 +39,7 @@ def _normalize_discord_url(url: str) -> str:
def _format_body(data: dict, *, include_path: bool) -> str: def _format_body(data: dict, *, include_path: bool) -> str:
"""Build a human-readable notification body from message data.""" """Build a human-readable notification body from message data."""
msg_type = data.get("type", "") msg_type = data.get("type", "")
text = data.get("text", "") text = get_fanout_message_text(data)
sender_name = data.get("sender_name") or "Unknown" sender_name = data.get("sender_name") or "Unknown"
via = "" via = ""
@@ -95,7 +95,6 @@ class AppriseModule(FanoutModule):
def __init__(self, config_id: str, config: dict, *, name: str = "") -> None: def __init__(self, config_id: str, config: dict, *, name: str = "") -> None:
super().__init__(config_id, config, name=name) super().__init__(config_id, config, name=name)
self._last_error: str | None = None
async def on_message(self, data: dict) -> None: async def on_message(self, data: dict) -> None:
# Skip outgoing messages — only notify on incoming # Skip outgoing messages — only notify on incoming
@@ -114,17 +113,17 @@ class AppriseModule(FanoutModule):
success = await asyncio.to_thread( success = await asyncio.to_thread(
_send_sync, urls, body, preserve_identity=preserve_identity _send_sync, urls, body, preserve_identity=preserve_identity
) )
self._last_error = None if success else "Apprise notify returned failure" self._set_last_error(None if success else "Apprise notify returned failure")
if not success: if not success:
logger.warning("Apprise notification failed for module %s", self.config_id) logger.warning("Apprise notification failed for module %s", self.config_id)
except Exception as exc: except Exception as exc:
self._last_error = str(exc) self._set_last_error(str(exc))
logger.exception("Apprise send error for module %s", self.config_id) logger.exception("Apprise send error for module %s", self.config_id)
@property @property
def status(self) -> str: def status(self) -> str:
if not self.config.get("urls", "").strip(): if not self.config.get("urls", "").strip():
return "disconnected" return "disconnected"
if self._last_error: if self.last_error:
return "error" return "error"
return "connected" return "connected"
+48
View File
@@ -3,6 +3,14 @@
from __future__ import annotations from __future__ import annotations
def _broadcast_fanout_health() -> None:
"""Push updated fanout status to connected frontend clients."""
from app.services.radio_runtime import radio_runtime as radio_manager
from app.websocket import broadcast_health
broadcast_health(radio_manager.is_connected, radio_manager.connection_info)
class FanoutModule: class FanoutModule:
"""Base class for all fanout integrations. """Base class for all fanout integrations.
@@ -16,6 +24,7 @@ class FanoutModule:
self.config_id = config_id self.config_id = config_id
self.config = config self.config = config
self.name = name self.name = name
self._last_error: str | None = None
async def start(self) -> None: async def start(self) -> None:
"""Start the module (e.g. connect to broker). Override for persistent connections.""" """Start the module (e.g. connect to broker). Override for persistent connections."""
@@ -33,3 +42,42 @@ class FanoutModule:
def status(self) -> str: def status(self) -> str:
"""Return 'connected', 'disconnected', or 'error'.""" """Return 'connected', 'disconnected', or 'error'."""
raise NotImplementedError raise NotImplementedError
@property
def last_error(self) -> str | None:
"""Return the most recent retained operator-facing error, if any."""
return self._last_error
def _set_last_error(self, value: str | None) -> None:
"""Update the retained error and broadcast health when it changes."""
if self._last_error == value:
return
self._last_error = value
_broadcast_fanout_health()
def get_fanout_message_text(data: dict) -> str:
"""Return the best human-readable message body for fanout consumers.
Channel messages are stored with the rendered sender label embedded in the
text (for example ``"Alice: hello"``). Human-facing integrations that also
carry ``sender_name`` should strip that duplicated prefix when it matches
the payload sender exactly.
"""
text = data.get("text", "")
if not isinstance(text, str):
return ""
if data.get("type") != "CHAN":
return text
sender_name = data.get("sender_name")
if not isinstance(sender_name, str) or not sender_name:
return text
prefix, separator, remainder = text.partition(": ")
if separator and prefix == sender_name:
return remainder
return text
+11 -33
View File
@@ -20,9 +20,9 @@ from datetime import datetime
from typing import Any, Protocol from typing import Any, Protocol
import aiomqtt import aiomqtt
import nacl.bindings
from app.fanout.mqtt_base import BaseMqttPublisher from app.fanout.mqtt_base import BaseMqttPublisher
from app.keystore import ed25519_sign_expanded
from app.path_utils import parse_packet_envelope, split_path_hex from app.path_utils import parse_packet_envelope, split_path_hex
from app.version_info import get_app_build_info from app.version_info import get_app_build_info
@@ -40,9 +40,6 @@ _TOKEN_RENEWAL_THRESHOLD = _TOKEN_LIFETIME - 3600 # 23 hours
_STATS_REFRESH_INTERVAL = 300 # 5 minutes _STATS_REFRESH_INTERVAL = 300 # 5 minutes
_STATS_MIN_CACHE_SECS = 60 # Don't re-fetch stats within 60s _STATS_MIN_CACHE_SECS = 60 # Don't re-fetch stats within 60s
# Ed25519 group order
_L = 2**252 + 27742317777372353535851937790883648493
# Route type mapping: bottom 2 bits of first byte # Route type mapping: bottom 2 bits of first byte
_ROUTE_MAP = {0: "F", 1: "F", 2: "D", 3: "T"} _ROUTE_MAP = {0: "F", 1: "F", 2: "D", 3: "T"}
@@ -69,28 +66,6 @@ def _base64url_encode(data: bytes) -> str:
return base64.urlsafe_b64encode(data).rstrip(b"=").decode("ascii") return base64.urlsafe_b64encode(data).rstrip(b"=").decode("ascii")
def _ed25519_sign_expanded(
message: bytes, scalar: bytes, prefix: bytes, public_key: bytes
) -> bytes:
"""Sign a message using MeshCore's expanded Ed25519 key format.
MeshCore stores 64-byte "orlp" format keys: scalar(32) || prefix(32).
Standard Ed25519 libraries expect seed format and would re-SHA-512 the key.
This performs the signing manually using the already-expanded key material.
Port of meshcore-packet-capture's ed25519_sign_with_expanded_key().
"""
# r = SHA-512(prefix || message) mod L
r = int.from_bytes(hashlib.sha512(prefix + message).digest(), "little") % _L
# R = r * B (base point multiplication)
R = nacl.bindings.crypto_scalarmult_ed25519_base_noclamp(r.to_bytes(32, "little"))
# k = SHA-512(R || public_key || message) mod L
k = int.from_bytes(hashlib.sha512(R + public_key + message).digest(), "little") % _L
# s = (r + k * scalar) mod L
s = (r + k * int.from_bytes(scalar, "little")) % _L
return R + s.to_bytes(32, "little")
def _generate_jwt_token( def _generate_jwt_token(
private_key: bytes, private_key: bytes,
public_key: bytes, public_key: bytes,
@@ -115,7 +90,7 @@ def _generate_jwt_token(
"exp": now + _TOKEN_LIFETIME, "exp": now + _TOKEN_LIFETIME,
"aud": audience, "aud": audience,
"owner": pubkey_hex, "owner": pubkey_hex,
"client": _CLIENT_ID, "client": _get_client_version(),
} }
if email: if email:
payload["email"] = email payload["email"] = email
@@ -127,7 +102,7 @@ def _generate_jwt_token(
scalar = private_key[:32] scalar = private_key[:32]
prefix = private_key[32:] prefix = private_key[32:]
signature = _ed25519_sign_expanded(signing_input, scalar, prefix, public_key) signature = ed25519_sign_expanded(signing_input, scalar, prefix, public_key)
return f"{header_b64}.{payload_b64}.{signature.hex()}" return f"{header_b64}.{payload_b64}.{signature.hex()}"
@@ -200,11 +175,12 @@ def _format_raw_packet(data: dict[str, Any], device_name: str, public_key_hex: s
current_time = datetime.now() current_time = datetime.now()
ts_str = current_time.isoformat() ts_str = current_time.isoformat()
# SNR/RSSI are always strings in reference output. # Keep numeric telemetry numeric so downstream analyzers can ingest it.
# Preserve the existing "Unknown" fallback for missing values.
snr_val = data.get("snr") snr_val = data.get("snr")
rssi_val = data.get("rssi") rssi_val = data.get("rssi")
snr = str(snr_val) if snr_val is not None else "Unknown" snr: float | str = float(snr_val) if snr_val is not None else "Unknown"
rssi = str(rssi_val) if rssi_val is not None else "Unknown" rssi: int | str = int(rssi_val) if rssi_val is not None else "Unknown"
packet_hash = _calculate_packet_hash(raw_bytes) packet_hash = _calculate_packet_hash(raw_bytes)
@@ -260,8 +236,10 @@ def _build_radio_info() -> str:
def _get_client_version() -> str: def _get_client_version() -> str:
"""Return the app version string for community MQTT payloads.""" """Return the canonical client/version identifier for community MQTT."""
return get_app_build_info().version build = get_app_build_info()
commit_hash = build.commit_hash or "unknown"
return f"{_CLIENT_ID}/{build.version}-{commit_hash}"
class CommunityMqttPublisher(BaseMqttPublisher): class CommunityMqttPublisher(BaseMqttPublisher):
+108 -13
View File
@@ -15,12 +15,21 @@ _DISPATCH_TIMEOUT_SECONDS = 30.0
_MODULE_TYPES: dict[str, type] = {} _MODULE_TYPES: dict[str, type] = {}
def _format_error_detail(exc: Exception) -> str:
"""Return a short operator-facing error string."""
message = str(exc).strip()
if message:
return f"{type(exc).__name__}: {message}"
return type(exc).__name__
def _register_module_types() -> None: def _register_module_types() -> None:
"""Lazily populate the type registry to avoid circular imports.""" """Lazily populate the type registry to avoid circular imports."""
if _MODULE_TYPES: if _MODULE_TYPES:
return return
from app.fanout.apprise_mod import AppriseModule from app.fanout.apprise_mod import AppriseModule
from app.fanout.bot import BotModule from app.fanout.bot import BotModule
from app.fanout.map_upload import MapUploadModule
from app.fanout.mqtt_community import MqttCommunityModule from app.fanout.mqtt_community import MqttCommunityModule
from app.fanout.mqtt_private import MqttPrivateModule from app.fanout.mqtt_private import MqttPrivateModule
from app.fanout.sqs import SqsModule from app.fanout.sqs import SqsModule
@@ -32,6 +41,7 @@ def _register_module_types() -> None:
_MODULE_TYPES["webhook"] = WebhookModule _MODULE_TYPES["webhook"] = WebhookModule
_MODULE_TYPES["apprise"] = AppriseModule _MODULE_TYPES["apprise"] = AppriseModule
_MODULE_TYPES["sqs"] = SqsModule _MODULE_TYPES["sqs"] = SqsModule
_MODULE_TYPES["map_upload"] = MapUploadModule
def _matches_filter(filter_value: Any, key: str) -> bool: def _matches_filter(filter_value: Any, key: str) -> bool:
@@ -82,6 +92,38 @@ class FanoutManager:
def __init__(self) -> None: def __init__(self) -> None:
self._modules: dict[str, tuple[FanoutModule, dict]] = {} # id -> (module, scope) self._modules: dict[str, tuple[FanoutModule, dict]] = {} # id -> (module, scope)
self._restart_locks: dict[str, asyncio.Lock] = {} self._restart_locks: dict[str, asyncio.Lock] = {}
self._bots_disabled_until_restart = False
self._module_errors: dict[str, str] = {}
def _broadcast_health_update(self) -> None:
from app.services.radio_runtime import radio_runtime as radio_manager
from app.websocket import broadcast_health
broadcast_health(radio_manager.is_connected, radio_manager.connection_info)
def _set_module_error(self, config_id: str, error: str) -> None:
if self._module_errors.get(config_id) == error:
return
self._module_errors[config_id] = error
self._broadcast_health_update()
def _clear_module_error(self, config_id: str) -> None:
if self._module_errors.pop(config_id, None) is not None:
self._broadcast_health_update()
def get_bots_disabled_source(self) -> str | None:
"""Return why bot modules are unavailable, if at all."""
from app.config import settings as server_settings
if server_settings.disable_bots:
return "env"
if self._bots_disabled_until_restart:
return "until_restart"
return None
def bots_disabled_effective(self) -> bool:
"""Return True when bot modules should be treated as unavailable."""
return self.get_bots_disabled_source() is not None
async def load_from_db(self) -> None: async def load_from_db(self) -> None:
"""Read enabled fanout_configs and instantiate modules.""" """Read enabled fanout_configs and instantiate modules."""
@@ -99,13 +141,14 @@ class FanoutManager:
config_blob = cfg["config"] config_blob = cfg["config"]
scope = cfg["scope"] scope = cfg["scope"]
# Skip bot modules when bots are disabled server-wide # Skip bot modules when bots are disabled server-wide or until restart.
if config_type == "bot": if config_type == "bot" and self.bots_disabled_effective():
from app.config import settings as server_settings logger.info(
"Skipping bot module %s (bots disabled: %s)",
if server_settings.disable_bots: config_id,
logger.info("Skipping bot module %s (bots disabled by server config)", config_id) self.get_bots_disabled_source(),
return )
return
cls = _MODULE_TYPES.get(config_type) cls = _MODULE_TYPES.get(config_type)
if cls is None: if cls is None:
@@ -116,11 +159,13 @@ class FanoutManager:
module = cls(config_id, config_blob, name=cfg.get("name", "")) module = cls(config_id, config_blob, name=cfg.get("name", ""))
await module.start() await module.start()
self._modules[config_id] = (module, scope) self._modules[config_id] = (module, scope)
self._clear_module_error(config_id)
logger.info( logger.info(
"Started fanout module %s (type=%s)", cfg.get("name", config_id), config_type "Started fanout module %s (type=%s)", cfg.get("name", config_id), config_type
) )
except Exception: except Exception as exc:
logger.exception("Failed to start fanout module %s", config_id) logger.exception("Failed to start fanout module %s", config_id)
self._set_module_error(config_id, _format_error_detail(exc))
async def reload_config(self, config_id: str) -> None: async def reload_config(self, config_id: str) -> None:
"""Stop old module (if any) and start updated config.""" """Stop old module (if any) and start updated config."""
@@ -144,6 +189,7 @@ class FanoutManager:
await module.stop() await module.stop()
except Exception: except Exception:
logger.exception("Error stopping fanout module %s", config_id) logger.exception("Error stopping fanout module %s", config_id)
self._clear_module_error(config_id)
async def _dispatch_matching( async def _dispatch_matching(
self, self,
@@ -173,7 +219,10 @@ class FanoutManager:
try: try:
handler = getattr(module, handler_name) handler = getattr(module, handler_name)
await asyncio.wait_for(handler(data), timeout=_DISPATCH_TIMEOUT_SECONDS) await asyncio.wait_for(handler(data), timeout=_DISPATCH_TIMEOUT_SECONDS)
self._clear_module_error(config_id)
except asyncio.TimeoutError: except asyncio.TimeoutError:
timeout_error = f"{handler_name} timed out after {_DISPATCH_TIMEOUT_SECONDS:.1f}s"
self._set_module_error(config_id, timeout_error)
logger.error( logger.error(
"Fanout %s %s timed out after %.1fs; restarting module", "Fanout %s %s timed out after %.1fs; restarting module",
config_id, config_id,
@@ -181,7 +230,8 @@ class FanoutManager:
_DISPATCH_TIMEOUT_SECONDS, _DISPATCH_TIMEOUT_SECONDS,
) )
await self._restart_module(config_id, module) await self._restart_module(config_id, module)
except Exception: except Exception as exc:
self._set_module_error(config_id, _format_error_detail(exc))
logger.exception("Fanout %s %s error", config_id, log_label) logger.exception("Fanout %s %s error", config_id, log_label)
async def _restart_module(self, config_id: str, module: FanoutModule) -> None: async def _restart_module(self, config_id: str, module: FanoutModule) -> None:
@@ -197,6 +247,10 @@ class FanoutManager:
except Exception: except Exception:
logger.exception("Failed to restart timed-out fanout module %s", config_id) logger.exception("Failed to restart timed-out fanout module %s", config_id)
self._modules.pop(config_id, None) self._modules.pop(config_id, None)
self._set_module_error(
config_id,
"Module restart failed after timeout",
)
async def broadcast_message(self, data: dict) -> None: async def broadcast_message(self, data: dict) -> None:
"""Dispatch a decoded message to modules whose scope matches.""" """Dispatch a decoded message to modules whose scope matches."""
@@ -225,21 +279,62 @@ class FanoutManager:
logger.exception("Error stopping fanout module %s", config_id) logger.exception("Error stopping fanout module %s", config_id)
self._modules.clear() self._modules.clear()
self._restart_locks.clear() self._restart_locks.clear()
self._module_errors.clear()
def get_statuses(self) -> dict[str, dict[str, str]]: def get_statuses(self) -> dict[str, dict[str, str | None]]:
"""Return status info for each active module.""" """Return status info for each active module."""
from app.repository.fanout import _configs_cache from app.repository.fanout import _configs_cache
result: dict[str, dict[str, str]] = {} result: dict[str, dict[str, str | None]] = {}
for config_id, (module, _) in self._modules.items(): all_ids = set(_configs_cache) | set(self._modules) | set(self._module_errors)
for config_id in all_ids:
info = _configs_cache.get(config_id, {}) info = _configs_cache.get(config_id, {})
if info.get("enabled") is False:
continue
module_entry = self._modules.get(config_id)
module = module_entry[0] if module_entry is not None else None
last_error = module.last_error if module is not None else None
status = module.status if module is not None else "error"
manager_error = self._module_errors.get(config_id)
if manager_error is not None:
status = "error"
last_error = manager_error
elif last_error is not None and status != "error":
status = "error"
if module is None and last_error is None:
continue
result[config_id] = { result[config_id] = {
"name": info.get("name", config_id), "name": info.get("name", config_id),
"type": info.get("type", "unknown"), "type": info.get("type", "unknown"),
"status": module.status, "status": status,
"last_error": last_error,
} }
return result return result
async def disable_bots_until_restart(self) -> str:
"""Stop active bot modules and prevent them from starting again until restart."""
source = self.get_bots_disabled_source()
if source == "env":
return source
self._bots_disabled_until_restart = True
from app.repository.fanout import _configs_cache
bot_ids = [
config_id
for config_id in list(self._modules)
if _configs_cache.get(config_id, {}).get("type") == "bot"
]
for config_id in bot_ids:
await self.remove_config(config_id)
return "until_restart"
# Module-level singleton # Module-level singleton
fanout_manager = FanoutManager() fanout_manager = FanoutManager()
+322
View File
@@ -0,0 +1,322 @@
"""Fanout module for uploading heard advert packets to map.meshcore.dev.
Mirrors the logic of the standalone map.meshcore.dev-uploader project:
- Listens on raw RF packets via on_raw
- Filters for ADVERT packets, only processes repeaters (role 2) and rooms (role 3)
- Skips nodes with no valid location (lat/lon None)
- Applies per-pubkey rate-limiting (1-hour window, matching the uploader)
- Signs the upload request with the radio's own Ed25519 private key
- POSTs to the map API (or logs in dry-run mode)
Dry-run mode (default: True) logs the full would-be payload at INFO level
without making any HTTP requests. Disable it only after verifying the log
output looks correct — in particular the radio params (freq/bw/sf/cr) and
the raw hex link.
Config keys
-----------
api_url : str, default ""
Upload endpoint. Empty string falls back to the public map.meshcore.dev API.
dry_run : bool, default True
When True, log the payload at INFO level instead of sending it.
geofence_enabled : bool, default False
When True, only upload nodes whose location falls within geofence_radius_km of
the radio's own configured latitude/longitude (read live from the radio at upload
time — no lat/lon is stored in this config). When the radio's lat/lon is not set
(0, 0) or unavailable, the geofence check is silently skipped so uploads continue
normally until coordinates are configured.
geofence_radius_km : float, default 0.0
Radius of the geofence in kilometres. Nodes further than this distance
from the radio's own position are skipped.
"""
from __future__ import annotations
import hashlib
import json
import logging
import math
import httpx
from app.decoder import parse_advertisement, parse_packet
from app.fanout.base import FanoutModule
from app.keystore import ed25519_sign_expanded, get_private_key, get_public_key
from app.services.radio_runtime import radio_runtime
logger = logging.getLogger(__name__)
_DEFAULT_API_URL = "https://map.meshcore.dev/api/v1/uploader/node"
# Re-upload guard: skip re-uploading a pubkey seen within this window (AU parity)
_REUPLOAD_SECONDS = 3600
# Only upload repeaters (2) and rooms (3). Any other role — including future
# roles not yet defined — is rejected. An allowlist is used rather than a
# blocklist so that new roles cannot accidentally start populating the map.
_ALLOWED_DEVICE_ROLES = {2, 3}
def _get_radio_params() -> dict:
"""Read radio frequency parameters from the connected radio's self_info.
The Python meshcore library returns radio_freq in MHz (e.g. 910.525) and
radio_bw in kHz (e.g. 62.5). These are exactly the units the map API
expects, matching what the JS reference uploader produces after its own
/1000 division on raw integer values. No further scaling is applied here.
"""
try:
mc = radio_runtime.meshcore
if not mc:
return {"freq": 0, "cr": 0, "sf": 0, "bw": 0}
info = mc.self_info
if not isinstance(info, dict):
return {"freq": 0, "cr": 0, "sf": 0, "bw": 0}
freq = info.get("radio_freq", 0) or 0
bw = info.get("radio_bw", 0) or 0
sf = info.get("radio_sf", 0) or 0
cr = info.get("radio_cr", 0) or 0
return {
"freq": freq,
"cr": cr,
"sf": sf,
"bw": bw,
}
except Exception as exc:
logger.debug("MapUpload: could not read radio params: %s", exc)
return {"freq": 0, "cr": 0, "sf": 0, "bw": 0}
_ROLE_NAMES: dict[int, str] = {2: "repeater", 3: "room"}
def _haversine_km(lat1: float, lon1: float, lat2: float, lon2: float) -> float:
"""Return the great-circle distance in kilometres between two lat/lon points."""
r = 6371.0
phi1, phi2 = math.radians(lat1), math.radians(lat2)
dphi = math.radians(lat2 - lat1)
dlam = math.radians(lon2 - lon1)
a = math.sin(dphi / 2) ** 2 + math.cos(phi1) * math.cos(phi2) * math.sin(dlam / 2) ** 2
return 2 * r * math.asin(math.sqrt(a))
class MapUploadModule(FanoutModule):
"""Uploads heard ADVERT packets to the MeshCore community map."""
def __init__(self, config_id: str, config: dict, *, name: str = "") -> None:
super().__init__(config_id, config, name=name)
self._client: httpx.AsyncClient | None = None
# Per-pubkey rate limiting: pubkey_hex -> last_uploaded_advert_timestamp
self._seen: dict[str, int] = {}
async def start(self) -> None:
self._client = httpx.AsyncClient(
timeout=httpx.Timeout(15.0),
follow_redirects=True,
)
self._last_error = None
self._seen.clear()
async def stop(self) -> None:
if self._client:
await self._client.aclose()
self._client = None
self._last_error = None
async def on_raw(self, data: dict) -> None:
if data.get("payload_type") != "ADVERT":
return
raw_hex = data.get("data", "")
if not raw_hex:
return
try:
raw_bytes = bytes.fromhex(raw_hex)
except ValueError:
return
packet_info = parse_packet(raw_bytes)
if packet_info is None:
return
advert = parse_advertisement(packet_info.payload, raw_packet=raw_bytes)
if advert is None:
return
# TODO: advert Ed25519 signature verification is skipped here.
# The radio has already validated the packet before passing it to RT,
# so re-verification is redundant in practice. If added, verify that
# nacl.bindings.crypto_sign_open(sig + (pubkey_bytes || timestamp_bytes),
# advert.public_key_bytes) succeeds before proceeding.
# Only process repeaters (2) and rooms (3) — any other role is rejected
if advert.device_role not in _ALLOWED_DEVICE_ROLES:
return
# Skip nodes with no valid location — the decoder already nulls out
# impossible values, so None means either no location flag or bad coords.
if advert.lat is None or advert.lon is None:
logger.debug(
"MapUpload: skipping %s — no valid location",
advert.public_key[:12],
)
return
pubkey = advert.public_key.lower()
# Rate-limit: skip if this pubkey's timestamp hasn't advanced enough
last_seen = self._seen.get(pubkey)
if last_seen is not None:
if last_seen >= advert.timestamp:
logger.debug(
"MapUpload: skipping %s — possible replay (last=%d, advert=%d)",
pubkey[:12],
last_seen,
advert.timestamp,
)
return
if advert.timestamp < last_seen + _REUPLOAD_SECONDS:
logger.debug(
"MapUpload: skipping %s — within 1-hr rate-limit window (delta=%ds)",
pubkey[:12],
advert.timestamp - last_seen,
)
return
await self._upload(
pubkey, advert.timestamp, advert.device_role, raw_hex, advert.lat, advert.lon
)
async def _upload(
self,
pubkey: str,
advert_timestamp: int,
device_role: int,
raw_hex: str,
lat: float,
lon: float,
) -> None:
# Geofence check: if enabled, skip nodes outside the configured radius.
# The reference center is the radio's own lat/lon read live from self_info —
# no coordinates are stored in the fanout config. If the radio lat/lon is
# (0, 0) or unavailable the check is skipped transparently so uploads
# continue normally until the operator sets coordinates in radio settings.
geofence_dist_km: float | None = None
if self.config.get("geofence_enabled"):
try:
mc = radio_runtime.meshcore
sinfo = mc.self_info if mc else None
fence_lat = float((sinfo or {}).get("adv_lat", 0) or 0)
fence_lon = float((sinfo or {}).get("adv_lon", 0) or 0)
except Exception as exc:
logger.debug("MapUpload: could not read radio lat/lon for geofence: %s", exc)
fence_lat = 0.0
fence_lon = 0.0
if fence_lat == 0.0 and fence_lon == 0.0:
logger.debug(
"MapUpload: geofence skipped for %s — radio lat/lon not configured",
pubkey[:12],
)
else:
fence_radius_km = float(self.config.get("geofence_radius_km", 0) or 0)
geofence_dist_km = _haversine_km(fence_lat, fence_lon, lat, lon)
if geofence_dist_km > fence_radius_km:
logger.debug(
"MapUpload: skipping %s — outside geofence (%.2f km > %.2f km)",
pubkey[:12],
geofence_dist_km,
fence_radius_km,
)
return
private_key = get_private_key()
public_key = get_public_key()
if private_key is None or public_key is None:
logger.warning(
"MapUpload: private key not available — cannot sign upload for %s. "
"Ensure radio firmware has ENABLE_PRIVATE_KEY_EXPORT=1.",
pubkey[:12],
)
return
api_url = str(self.config.get("api_url", "") or _DEFAULT_API_URL).strip()
dry_run = bool(self.config.get("dry_run", True))
role_name = _ROLE_NAMES.get(device_role, f"role={device_role}")
params = _get_radio_params()
upload_data = {
"params": params,
"links": [f"meshcore://{raw_hex}"],
}
# Sign: SHA-256 the compact JSON, then Ed25519-sign the hash
json_str = json.dumps(upload_data, separators=(",", ":"))
data_hash = hashlib.sha256(json_str.encode()).digest()
scalar = private_key[:32]
prefix_bytes = private_key[32:]
signature = ed25519_sign_expanded(data_hash, scalar, prefix_bytes, public_key)
request_payload = {
"data": json_str,
"signature": signature.hex(),
"publicKey": public_key.hex(),
}
if dry_run:
geofence_note = (
f" | geofence: {geofence_dist_km:.2f} km from observer"
if geofence_dist_km is not None
else ""
)
logger.info(
"MapUpload [DRY RUN] %s (%s)%s → would POST to %s\n payload: %s",
pubkey[:12],
role_name,
geofence_note,
api_url,
json.dumps(request_payload, separators=(",", ":")),
)
# Still update _seen so rate-limiting works during dry-run testing
self._seen[pubkey] = advert_timestamp
return
if not self._client:
return
try:
resp = await self._client.post(
api_url,
content=json.dumps(request_payload, separators=(",", ":")),
headers={"Content-Type": "application/json"},
)
resp.raise_for_status()
self._seen[pubkey] = advert_timestamp
self._set_last_error(None)
logger.info(
"MapUpload: uploaded %s (%s) → HTTP %d",
pubkey[:12],
role_name,
resp.status_code,
)
except httpx.HTTPStatusError as exc:
self._set_last_error(f"HTTP {exc.response.status_code}")
logger.warning(
"MapUpload: server returned %d for %s: %s",
exc.response.status_code,
pubkey[:12],
exc.response.text[:200],
)
except httpx.RequestError as exc:
self._set_last_error(str(exc))
logger.warning("MapUpload: request error for %s: %s", pubkey[:12], exc)
@property
def status(self) -> str:
if self._client is None:
return "disconnected"
if self.last_error:
return "error"
return "connected"
+21 -2
View File
@@ -23,6 +23,14 @@ logger = logging.getLogger(__name__)
_BACKOFF_MIN = 5 _BACKOFF_MIN = 5
def _format_error_detail(exc: Exception) -> str:
"""Return a short operator-facing error string."""
message = str(exc).strip()
if message:
return message
return type(exc).__name__
def _broadcast_health() -> None: def _broadcast_health() -> None:
"""Push updated health (including MQTT status) to all WS clients.""" """Push updated health (including MQTT status) to all WS clients."""
from app.services.radio_runtime import radio_runtime as radio_manager from app.services.radio_runtime import radio_runtime as radio_manager
@@ -55,6 +63,7 @@ class BaseMqttPublisher(ABC):
self._version_event: asyncio.Event = asyncio.Event() self._version_event: asyncio.Event = asyncio.Event()
self.connected: bool = False self.connected: bool = False
self.integration_name: str = "" self.integration_name: str = ""
self._last_error: str | None = None
def set_integration_name(self, name: str) -> None: def set_integration_name(self, name: str) -> None:
"""Attach the configured fanout-module name for operator-facing logs.""" """Attach the configured fanout-module name for operator-facing logs."""
@@ -66,11 +75,17 @@ class BaseMqttPublisher(ABC):
return f"{self._log_prefix} [{self.integration_name}]" return f"{self._log_prefix} [{self.integration_name}]"
return self._log_prefix return self._log_prefix
@property
def last_error(self) -> str | None:
"""Return the most recent retained connection/publish error."""
return self._last_error
# ── Lifecycle ────────────────────────────────────────────────────── # ── Lifecycle ──────────────────────────────────────────────────────
async def start(self, settings: object) -> None: async def start(self, settings: object) -> None:
"""Start the background connection loop.""" """Start the background connection loop."""
self._settings = settings self._settings = settings
self._last_error = None
self._settings_version += 1 self._settings_version += 1
self._version_event.set() self._version_event.set()
if self._task is None or self._task.done(): if self._task is None or self._task.done():
@@ -87,6 +102,7 @@ class BaseMqttPublisher(ABC):
self._task = None self._task = None
self._client = None self._client = None
self.connected = False self.connected = False
self._last_error = None
async def restart(self, settings: object) -> None: async def restart(self, settings: object) -> None:
"""Called when settings change — stop + start.""" """Called when settings change — stop + start."""
@@ -102,13 +118,14 @@ class BaseMqttPublisher(ABC):
except Exception as e: except Exception as e:
logger.warning( logger.warning(
"%s publish failed on %s. This is usually transient network noise; " "%s publish failed on %s. This is usually transient network noise; "
"if it self-resolves and reconnects, it is generally not a concern: %s", "if it self-resolves and reconnects, it is generally not a concern. Persistent errors may indicate a problem with your network connection or MQTT broker. Original error: %s",
self._integration_label(), self._integration_label(),
topic, topic,
e, e,
exc_info=True, exc_info=True,
) )
self.connected = False self.connected = False
self._last_error = _format_error_detail(e)
# Wake the connection loop so it exits the wait and reconnects # Wake the connection loop so it exits the wait and reconnects
self._settings_version += 1 self._settings_version += 1
self._version_event.set() self._version_event.set()
@@ -198,6 +215,7 @@ class BaseMqttPublisher(ABC):
async with aiomqtt.Client(**client_kwargs) as client: async with aiomqtt.Client(**client_kwargs) as client:
self._client = client self._client = client
self.connected = True self.connected = True
self._last_error = None
backoff = _BACKOFF_MIN backoff = _BACKOFF_MIN
title, detail = self._on_connected(settings) title, detail = self._on_connected(settings)
@@ -232,6 +250,7 @@ class BaseMqttPublisher(ABC):
except Exception as e: except Exception as e:
self.connected = False self.connected = False
self._client = None self._client = None
self._last_error = _format_error_detail(e)
title, detail = self._on_error() title, detail = self._on_error()
broadcast_error(title, detail) broadcast_error(title, detail)
@@ -239,7 +258,7 @@ class BaseMqttPublisher(ABC):
logger.warning( logger.warning(
"%s connection error. This is usually transient network noise; " "%s connection error. This is usually transient network noise; "
"if it self-resolves, it is generally not a concern: %s " "if it self-resolves, it is generally not a concern: %s "
"(reconnecting in %ds)", "(reconnecting in %ds). If this error persists, check your network connection and MQTT broker status.",
self._integration_label(), self._integration_label(),
e, e,
backoff, backoff,
+6
View File
@@ -98,9 +98,15 @@ class MqttCommunityModule(FanoutModule):
@property @property
def status(self) -> str: def status(self) -> str:
if self._publisher._is_configured(): if self._publisher._is_configured():
if self._publisher.last_error:
return "error"
return "connected" if self._publisher.connected else "disconnected" return "connected" if self._publisher.connected else "disconnected"
return "disconnected" return "disconnected"
@property
def last_error(self) -> str | None:
return self._publisher.last_error
async def _publish_community_packet( async def _publish_community_packet(
publisher: CommunityMqttPublisher, publisher: CommunityMqttPublisher,
+6
View File
@@ -59,4 +59,10 @@ class MqttPrivateModule(FanoutModule):
def status(self) -> str: def status(self) -> str:
if not self.config.get("broker_host"): if not self.config.get("broker_host"):
return "disconnected" return "disconnected"
if self._publisher.last_error:
return "error"
return "connected" if self._publisher.connected else "disconnected" return "connected" if self._publisher.connected else "disconnected"
@property
def last_error(self) -> str | None:
return self._publisher.last_error
+4 -5
View File
@@ -84,7 +84,6 @@ class SqsModule(FanoutModule):
def __init__(self, config_id: str, config: dict, *, name: str = "") -> None: def __init__(self, config_id: str, config: dict, *, name: str = "") -> None:
super().__init__(config_id, config, name=name) super().__init__(config_id, config, name=name)
self._client = None self._client = None
self._last_error: str | None = None
async def start(self) -> None: async def start(self) -> None:
kwargs: dict[str, str] = {} kwargs: dict[str, str] = {}
@@ -147,18 +146,18 @@ class SqsModule(FanoutModule):
try: try:
await asyncio.to_thread(partial(self._client.send_message, **request_kwargs)) await asyncio.to_thread(partial(self._client.send_message, **request_kwargs))
self._last_error = None self._set_last_error(None)
except (ClientError, BotoCoreError) as exc: except (ClientError, BotoCoreError) as exc:
self._last_error = str(exc) self._set_last_error(str(exc))
logger.warning("SQS %s send error: %s", self.config_id, exc) logger.warning("SQS %s send error: %s", self.config_id, exc)
except Exception as exc: except Exception as exc:
self._last_error = str(exc) self._set_last_error(str(exc))
logger.exception("Unexpected SQS send error for %s", self.config_id) logger.exception("Unexpected SQS send error for %s", self.config_id)
@property @property
def status(self) -> str: def status(self) -> str:
if not str(self.config.get("queue_url", "")).strip(): if not str(self.config.get("queue_url", "")).strip():
return "disconnected" return "disconnected"
if self._last_error: if self.last_error:
return "error" return "error"
return "connected" return "connected"
+4 -5
View File
@@ -20,7 +20,6 @@ class WebhookModule(FanoutModule):
def __init__(self, config_id: str, config: dict, *, name: str = "") -> None: def __init__(self, config_id: str, config: dict, *, name: str = "") -> None:
super().__init__(config_id, config, name=name) super().__init__(config_id, config, name=name)
self._client: httpx.AsyncClient | None = None self._client: httpx.AsyncClient | None = None
self._last_error: str | None = None
async def start(self) -> None: async def start(self) -> None:
self._client = httpx.AsyncClient(timeout=httpx.Timeout(10.0)) self._client = httpx.AsyncClient(timeout=httpx.Timeout(10.0))
@@ -62,9 +61,9 @@ class WebhookModule(FanoutModule):
try: try:
resp = await self._client.request(method, url, content=body_bytes, headers=headers) resp = await self._client.request(method, url, content=body_bytes, headers=headers)
resp.raise_for_status() resp.raise_for_status()
self._last_error = None self._set_last_error(None)
except httpx.HTTPStatusError as exc: except httpx.HTTPStatusError as exc:
self._last_error = f"HTTP {exc.response.status_code}" self._set_last_error(f"HTTP {exc.response.status_code}")
logger.warning( logger.warning(
"Webhook %s returned %s for %s", "Webhook %s returned %s for %s",
self.config_id, self.config_id,
@@ -72,13 +71,13 @@ class WebhookModule(FanoutModule):
url, url,
) )
except httpx.RequestError as exc: except httpx.RequestError as exc:
self._last_error = str(exc) self._set_last_error(str(exc))
logger.warning("Webhook %s request error: %s", self.config_id, exc) logger.warning("Webhook %s request error: %s", self.config_id, exc)
@property @property
def status(self) -> str: def status(self) -> str:
if not self.config.get("url"): if not self.config.get("url"):
return "disconnected" return "disconnected"
if self._last_error: if self.last_error:
return "error" return "error"
return "connected" return "connected"
+12
View File
@@ -139,6 +139,18 @@ def register_frontend_static_routes(app: FastAPI, frontend_dir: Path) -> bool:
@app.get("/{path:path}") @app.get("/{path:path}")
async def serve_frontend(path: str): async def serve_frontend(path: str):
"""Serve frontend files, falling back to index.html for SPA routing.""" """Serve frontend files, falling back to index.html for SPA routing."""
if path == "api" or path.startswith("api/"):
return JSONResponse(
status_code=404,
content={
"detail": (
"API endpoint not found. If you are seeing this in response to a "
"frontend request, you may be running a newer frontend with an older "
"backend or vice versa. A full update is suggested."
)
},
)
file_path = (frontend_dir / path).resolve() file_path = (frontend_dir / path).resolve()
try: try:
file_path.relative_to(frontend_dir) file_path.relative_to(frontend_dir)
+24 -1
View File
@@ -1,14 +1,18 @@
""" """
Ephemeral keystore for storing sensitive keys in memory. Ephemeral keystore for storing sensitive keys in memory, plus the Ed25519
signing primitive used by fanout modules that need to sign requests with the
radio's own key.
The private key is stored in memory only and is never persisted to disk. The private key is stored in memory only and is never persisted to disk.
It's exported from the radio on startup and reconnect, then used for It's exported from the radio on startup and reconnect, then used for
server-side decryption of direct messages. server-side decryption of direct messages.
""" """
import hashlib
import logging import logging
from typing import TYPE_CHECKING from typing import TYPE_CHECKING
import nacl.bindings
from meshcore import EventType from meshcore import EventType
from app.decoder import derive_public_key from app.decoder import derive_public_key
@@ -25,11 +29,30 @@ NO_EVENT_RECEIVED_GUIDANCE = (
"issue commands to the radio." "issue commands to the radio."
) )
# Ed25519 group order (L) — used in the expanded signing primitive below
_L = 2**252 + 27742317777372353535851937790883648493
# In-memory storage for the private key and derived public key # In-memory storage for the private key and derived public key
_private_key: bytes | None = None _private_key: bytes | None = None
_public_key: bytes | None = None _public_key: bytes | None = None
def ed25519_sign_expanded(message: bytes, scalar: bytes, prefix: bytes, public_key: bytes) -> bytes:
"""Sign a message using MeshCore's expanded Ed25519 key format.
MeshCore stores 64-byte keys as scalar(32) || prefix(32). Standard
Ed25519 libraries expect seed format and would re-SHA-512 the key, so we
perform the signing manually using the already-expanded key material.
Port of meshcore-packet-capture's ed25519_sign_with_expanded_key().
"""
r = int.from_bytes(hashlib.sha512(prefix + message).digest(), "little") % _L
R = nacl.bindings.crypto_scalarmult_ed25519_base_noclamp(r.to_bytes(32, "little"))
k = int.from_bytes(hashlib.sha512(R + public_key + message).digest(), "little") % _L
s = (r + k * int.from_bytes(scalar, "little")) % _L
return R + s.to_bytes(32, "little")
def clear_keys() -> None: def clear_keys() -> None:
"""Clear any stored private/public key material from memory.""" """Clear any stored private/public key material from memory."""
global _private_key, _public_key global _private_key, _public_key
+4
View File
@@ -17,6 +17,7 @@ from app.frontend_static import (
) )
from app.radio import RadioDisconnectedError from app.radio import RadioDisconnectedError
from app.radio_sync import ( from app.radio_sync import (
stop_background_contact_reconciliation,
stop_message_polling, stop_message_polling,
stop_periodic_advert, stop_periodic_advert,
stop_periodic_sync, stop_periodic_sync,
@@ -32,6 +33,7 @@ from app.routers import (
radio, radio,
read_state, read_state,
repeaters, repeaters,
rooms,
settings, settings,
statistics, statistics,
ws, ws,
@@ -94,6 +96,7 @@ async def lifespan(app: FastAPI):
pass pass
await fanout_manager.stop_all() await fanout_manager.stop_all()
await radio_manager.stop_connection_monitor() await radio_manager.stop_connection_monitor()
await stop_background_contact_reconciliation()
await stop_message_polling() await stop_message_polling()
await stop_periodic_advert() await stop_periodic_advert()
await stop_periodic_sync() await stop_periodic_sync()
@@ -134,6 +137,7 @@ app.include_router(fanout.router, prefix="/api")
app.include_router(radio.router, prefix="/api") app.include_router(radio.router, prefix="/api")
app.include_router(contacts.router, prefix="/api") app.include_router(contacts.router, prefix="/api")
app.include_router(repeaters.router, prefix="/api") app.include_router(repeaters.router, prefix="/api")
app.include_router(rooms.router, prefix="/api")
app.include_router(channels.router, prefix="/api") app.include_router(channels.router, prefix="/api")
app.include_router(messages.router, prefix="/api") app.include_router(messages.router, prefix="/api")
app.include_router(packets.router, prefix="/api") app.include_router(packets.router, prefix="/api")
+95
View File
@@ -353,6 +353,13 @@ async def run_migrations(conn: aiosqlite.Connection) -> int:
await set_version(conn, 45) await set_version(conn, 45)
applied += 1 applied += 1
# Migration 46: Clean orphaned contact child rows left by old prefix promotion
if version < 46:
logger.info("Applying migration 46: clean orphaned contact child rows")
await _migrate_046_cleanup_orphaned_contact_child_rows(conn)
await set_version(conn, 46)
applied += 1
if applied > 0: if applied > 0:
logger.info( logger.info(
"Applied %d migration(s), schema now at version %d", applied, await get_version(conn) "Applied %d migration(s), schema now at version %d", applied, await get_version(conn)
@@ -2773,3 +2780,91 @@ async def _migrate_045_rebuild_contacts_direct_route_columns(conn: aiosqlite.Con
await conn.execute("DROP TABLE contacts") await conn.execute("DROP TABLE contacts")
await conn.execute("ALTER TABLE contacts_new RENAME TO contacts") await conn.execute("ALTER TABLE contacts_new RENAME TO contacts")
await conn.commit() await conn.commit()
async def _migrate_046_cleanup_orphaned_contact_child_rows(conn: aiosqlite.Connection) -> None:
"""Move uniquely resolvable orphan contact child rows onto full contacts, drop the rest."""
existing_tables_cursor = await conn.execute("SELECT name FROM sqlite_master WHERE type='table'")
existing_tables = {row[0] for row in await existing_tables_cursor.fetchall()}
if "contacts" not in existing_tables:
await conn.commit()
return
child_tables = [
table
for table in ("contact_name_history", "contact_advert_paths")
if table in existing_tables
]
if not child_tables:
await conn.commit()
return
orphan_keys: set[str] = set()
for table in child_tables:
cursor = await conn.execute(
f"""
SELECT DISTINCT child.public_key
FROM {table} child
LEFT JOIN contacts c ON c.public_key = child.public_key
WHERE c.public_key IS NULL
"""
)
orphan_keys.update(row[0] for row in await cursor.fetchall())
for orphan_key in sorted(orphan_keys, key=len, reverse=True):
match_cursor = await conn.execute(
"""
SELECT public_key
FROM contacts
WHERE length(public_key) = 64
AND public_key LIKE ? || '%'
ORDER BY public_key
""",
(orphan_key.lower(),),
)
matches = [row[0] for row in await match_cursor.fetchall()]
resolved_key = matches[0] if len(matches) == 1 else None
if resolved_key is not None:
if "contact_name_history" in child_tables:
await conn.execute(
"""
INSERT INTO contact_name_history (public_key, name, first_seen, last_seen)
SELECT ?, name, first_seen, last_seen
FROM contact_name_history
WHERE public_key = ?
ON CONFLICT(public_key, name) DO UPDATE SET
first_seen = MIN(contact_name_history.first_seen, excluded.first_seen),
last_seen = MAX(contact_name_history.last_seen, excluded.last_seen)
""",
(resolved_key, orphan_key),
)
if "contact_advert_paths" in child_tables:
await conn.execute(
"""
INSERT INTO contact_advert_paths
(public_key, path_hex, path_len, first_seen, last_seen, heard_count)
SELECT ?, path_hex, path_len, first_seen, last_seen, heard_count
FROM contact_advert_paths
WHERE public_key = ?
ON CONFLICT(public_key, path_hex, path_len) DO UPDATE SET
first_seen = MIN(contact_advert_paths.first_seen, excluded.first_seen),
last_seen = MAX(contact_advert_paths.last_seen, excluded.last_seen),
heard_count = contact_advert_paths.heard_count + excluded.heard_count
""",
(resolved_key, orphan_key),
)
if "contact_name_history" in child_tables:
await conn.execute(
"DELETE FROM contact_name_history WHERE public_key = ?",
(orphan_key,),
)
if "contact_advert_paths" in child_tables:
await conn.execute(
"DELETE FROM contact_advert_paths WHERE public_key = ?",
(orphan_key,),
)
await conn.commit()
+22 -1
View File
@@ -231,6 +231,7 @@ class ContactRoutingOverrideRequest(BaseModel):
# Contact type constants # Contact type constants
CONTACT_TYPE_REPEATER = 2 CONTACT_TYPE_REPEATER = 2
CONTACT_TYPE_ROOM = 3
class ContactAdvertPath(BaseModel): class ContactAdvertPath(BaseModel):
@@ -265,7 +266,7 @@ class ContactNameHistory(BaseModel):
class ContactActiveRoom(BaseModel): class ContactActiveRoom(BaseModel):
"""A channel/room where a contact has been active.""" """A channel where a contact has been active."""
channel_key: str channel_key: str
channel_name: str channel_name: str
@@ -412,6 +413,10 @@ class Message(BaseModel):
acked: int = 0 acked: int = 0
sender_name: str | None = None sender_name: str | None = None
channel_name: str | None = None channel_name: str | None = None
packet_id: int | None = Field(
default=None,
description="Representative raw packet row ID when archival raw bytes exist",
)
class MessagesAroundResponse(BaseModel): class MessagesAroundResponse(BaseModel):
@@ -457,6 +462,21 @@ class RawPacketBroadcast(BaseModel):
decrypted_info: RawPacketDecryptedInfo | None = None decrypted_info: RawPacketDecryptedInfo | None = None
class RawPacketDetail(BaseModel):
"""Stored raw-packet detail returned by the packet API."""
id: int
timestamp: int
data: str = Field(description="Hex-encoded packet data")
payload_type: str = Field(description="Packet type name (e.g. GROUP_TEXT, ADVERT)")
snr: float | None = Field(default=None, description="Signal-to-noise ratio in dB if available")
rssi: int | None = Field(
default=None, description="Received signal strength in dBm if available"
)
decrypted: bool = False
decrypted_info: RawPacketDecryptedInfo | None = None
class SendMessageRequest(BaseModel): class SendMessageRequest(BaseModel):
text: str = Field(min_length=1) text: str = Field(min_length=1)
@@ -813,4 +833,5 @@ class StatisticsResponse(BaseModel):
total_outgoing: int total_outgoing: int
contacts_heard: ContactActivityCounts contacts_heard: ContactActivityCounts
repeaters_heard: ContactActivityCounts repeaters_heard: ContactActivityCounts
known_channels_active: ContactActivityCounts
path_hash_width_24h: PathHashWidthStats path_hash_width_24h: PathHashWidthStats
+3
View File
@@ -548,11 +548,14 @@ class RadioManager:
async def disconnect(self) -> None: async def disconnect(self) -> None:
"""Disconnect from the radio.""" """Disconnect from the radio."""
from app.radio_sync import stop_background_contact_reconciliation
clear_keys() clear_keys()
self._reset_reconnect_error_broadcasts() self._reset_reconnect_error_broadcasts()
if self._meshcore is None: if self._meshcore is None:
return return
await stop_background_contact_reconciliation()
await self._acquire_operation_lock("disconnect", blocking=True) await self._acquire_operation_lock("disconnect", blocking=True)
try: try:
mc = self._meshcore mc = self._meshcore
+275 -31
View File
@@ -166,6 +166,9 @@ async def pause_polling():
# Background task handle # Background task handle
_sync_task: asyncio.Task | None = None _sync_task: asyncio.Task | None = None
# Startup/background contact reconciliation task handle
_contact_reconcile_task: asyncio.Task | None = None
# Periodic maintenance check interval in seconds (5 minutes) # Periodic maintenance check interval in seconds (5 minutes)
SYNC_INTERVAL = 300 SYNC_INTERVAL = 300
@@ -266,30 +269,7 @@ async def sync_and_offload_contacts(mc: MeshCore) -> dict:
remove_result = await mc.commands.remove_contact(contact_data) remove_result = await mc.commands.remove_contact(contact_data)
if remove_result.type == EventType.OK: if remove_result.type == EventType.OK:
removed += 1 removed += 1
_evict_removed_contact_from_library_cache(mc, public_key)
# LIBRARY INTERNAL FIXUP: The MeshCore library's
# commands.remove_contact() sends the remove command over
# the wire but does NOT update the library's in-memory
# contact cache (mc._contacts). This is a gap in the
# library — there's no public API to clear a single
# contact from the cache, and the library only refreshes
# it on a full get_contacts() call.
#
# Why this matters: sync_recent_contacts_to_radio() uses
# mc.get_contact_by_key_prefix() to check whether a
# contact is already loaded on the radio. That method
# searches mc._contacts. If we don't evict the removed
# contact from the cache here, get_contact_by_key_prefix()
# will still find it and skip the add_contact() call —
# meaning contacts never get loaded back onto the radio
# after offload. The result: no DM ACKs, degraded routing
# for potentially minutes until the next periodic sync
# refreshes the cache from the (now-empty) radio.
#
# We access mc._contacts directly because the library
# exposes it as a read-only property (mc.contacts) with
# no removal API. The dict is keyed by public_key string.
mc._contacts.pop(public_key, None)
else: else:
logger.warning( logger.warning(
"Failed to remove contact %s: %s", public_key[:12], remove_result.payload "Failed to remove contact %s: %s", public_key[:12], remove_result.payload
@@ -461,28 +441,28 @@ async def ensure_default_channels() -> None:
async def sync_and_offload_all(mc: MeshCore) -> dict: async def sync_and_offload_all(mc: MeshCore) -> dict:
"""Sync and offload both contacts and channels, then ensure defaults exist.""" """Run fast startup sync, then background contact reconcile."""
logger.info("Starting full radio sync and offload") logger.info("Starting full radio sync and offload")
# Contact on_radio is legacy/stale metadata. Clear it during the offload/reload # Contact on_radio is legacy/stale metadata. Clear it during the offload/reload
# cycle so old rows stop claiming radio residency we do not actively track. # cycle so old rows stop claiming radio residency we do not actively track.
await ContactRepository.clear_on_radio_except([]) await ContactRepository.clear_on_radio_except([])
contacts_result = await sync_and_offload_contacts(mc) contacts_result = await sync_contacts_from_radio(mc)
channels_result = await sync_and_offload_channels(mc) channels_result = await sync_and_offload_channels(mc)
# Ensure default channels exist # Ensure default channels exist
await ensure_default_channels() await ensure_default_channels()
# Reload favorites plus a working-set fill back onto the radio immediately. start_background_contact_reconciliation(
# Pass mc directly since the caller already holds the radio operation lock initial_radio_contacts=contacts_result.get("radio_contacts", {}),
# (asyncio.Lock is not reentrant). expected_mc=mc,
reload_result = await sync_recent_contacts_to_radio(force=True, mc=mc) )
return { return {
"contacts": contacts_result, "contacts": contacts_result,
"channels": channels_result, "channels": channels_result,
"reloaded": reload_result, "contact_reconcile_started": True,
} }
@@ -1036,6 +1016,270 @@ async def stop_periodic_sync():
# Throttling for contact sync to radio # Throttling for contact sync to radio
_last_contact_sync: float = 0.0 _last_contact_sync: float = 0.0
CONTACT_SYNC_THROTTLE_SECONDS = 30 # Don't sync more than once per 30 seconds CONTACT_SYNC_THROTTLE_SECONDS = 30 # Don't sync more than once per 30 seconds
CONTACT_RECONCILE_BATCH_SIZE = 2
CONTACT_RECONCILE_YIELD_SECONDS = 0.05
def _evict_removed_contact_from_library_cache(mc: MeshCore, public_key: str) -> None:
"""Keep the library's contact cache consistent after a successful removal."""
# LIBRARY INTERNAL FIXUP: The MeshCore library's remove_contact() sends the
# remove command over the wire but does NOT update the library's in-memory
# contact cache (mc._contacts). This is a gap in the library — there's no
# public API to clear a single contact from the cache, and the library only
# refreshes it on a full get_contacts() call.
#
# Why this matters: contact sync and targeted ensure/load paths use
# mc.get_contact_by_key_prefix() to check whether a contact is already
# loaded on the radio. That method searches mc._contacts. If we don't evict
# the removed contact from the cache here, later syncs will still find it
# and skip add_contact() calls, leaving the radio without the contact even
# though the app thinks it is resident.
mc._contacts.pop(public_key, None)
def _normalize_radio_contacts_payload(contacts: dict | None) -> dict[str, dict]:
"""Return radio contacts keyed by normalized lowercase full public key."""
normalized: dict[str, dict] = {}
for public_key, contact_data in (contacts or {}).items():
normalized[str(public_key).lower()] = contact_data
return normalized
async def sync_contacts_from_radio(mc: MeshCore) -> dict:
"""Pull contacts from the radio and persist them to the database without removing them."""
synced = 0
try:
result = await mc.commands.get_contacts()
if result is None or result.type == EventType.ERROR:
logger.error(
"Failed to get contacts from radio: %s. "
"If you see this repeatedly, the radio may be visible on the "
"serial/TCP/BLE port but not responding to commands. Check for "
"another process with the serial port open (other RemoteTerm "
"instances, serial monitors, etc.), verify the firmware is "
"up-to-date and in client mode (not repeater), or try a "
"power cycle.",
result,
)
return {"synced": 0, "radio_contacts": {}, "error": str(result)}
contacts = _normalize_radio_contacts_payload(result.payload)
logger.info("Found %d contacts on radio", len(contacts))
for public_key, contact_data in contacts.items():
await ContactRepository.upsert(
ContactUpsert.from_radio_dict(public_key, contact_data, on_radio=False)
)
asyncio.create_task(
_reconcile_contact_messages_background(
public_key,
contact_data.get("adv_name"),
)
)
synced += 1
logger.info("Synced %d contacts from radio snapshot", synced)
return {"synced": synced, "radio_contacts": contacts}
except Exception as e:
logger.error("Error during contact snapshot sync: %s", e)
return {"synced": synced, "radio_contacts": {}, "error": str(e)}
async def _reconcile_radio_contacts_in_background(
*,
initial_radio_contacts: dict[str, dict],
expected_mc: MeshCore,
) -> None:
"""Converge radio contacts toward the desired favorites+recents working set."""
radio_contacts = dict(initial_radio_contacts)
removed = 0
loaded = 0
failed = 0
try:
while True:
if not radio_manager.is_connected or radio_manager.meshcore is not expected_mc:
logger.info("Stopping background contact reconcile: radio transport changed")
break
selected_contacts = await get_contacts_selected_for_radio_sync()
desired_contacts = {
contact.public_key.lower(): contact
for contact in selected_contacts
if len(contact.public_key) >= 64
}
removable_keys = [key for key in radio_contacts if key not in desired_contacts]
missing_contacts = [
contact for key, contact in desired_contacts.items() if key not in radio_contacts
]
if not removable_keys and not missing_contacts:
logger.info(
"Background contact reconcile complete: %d contacts on radio working set",
len(radio_contacts),
)
break
progressed = False
try:
async with radio_manager.radio_operation(
"background_contact_reconcile",
blocking=False,
) as mc:
if mc is not expected_mc:
logger.info(
"Stopping background contact reconcile: radio transport changed"
)
break
budget = CONTACT_RECONCILE_BATCH_SIZE
selected_contacts = await get_contacts_selected_for_radio_sync()
desired_contacts = {
contact.public_key.lower(): contact
for contact in selected_contacts
if len(contact.public_key) >= 64
}
for public_key in list(radio_contacts):
if budget <= 0:
break
if public_key in desired_contacts:
continue
remove_payload = (
mc.get_contact_by_key_prefix(public_key[:12])
or radio_contacts.get(public_key)
or {"public_key": public_key}
)
try:
remove_result = await mc.commands.remove_contact(remove_payload)
except Exception as exc:
failed += 1
budget -= 1
logger.warning(
"Error removing contact %s during background reconcile: %s",
public_key[:12],
exc,
)
continue
budget -= 1
if remove_result.type == EventType.OK:
radio_contacts.pop(public_key, None)
_evict_removed_contact_from_library_cache(mc, public_key)
removed += 1
progressed = True
else:
failed += 1
logger.warning(
"Failed to remove contact %s during background reconcile: %s",
public_key[:12],
remove_result.payload,
)
if budget > 0:
for public_key, contact in desired_contacts.items():
if budget <= 0:
break
if public_key in radio_contacts:
continue
if mc.get_contact_by_key_prefix(public_key[:12]):
radio_contacts[public_key] = {"public_key": public_key}
continue
try:
add_payload = contact.to_radio_dict()
add_result = await mc.commands.add_contact(add_payload)
except Exception as exc:
failed += 1
budget -= 1
logger.warning(
"Error adding contact %s during background reconcile: %s",
public_key[:12],
exc,
exc_info=True,
)
continue
budget -= 1
if add_result.type == EventType.OK:
radio_contacts[public_key] = add_payload
loaded += 1
progressed = True
else:
failed += 1
reason = add_result.payload
hint = ""
if reason is None:
hint = (
" (no response from radio — if this repeats, check for "
"serial port contention from another process or try a "
"power cycle)"
)
logger.warning(
"Failed to add contact %s during background reconcile: %s%s",
public_key[:12],
reason,
hint,
)
except RadioOperationBusyError:
logger.debug("Background contact reconcile yielding: radio busy")
await asyncio.sleep(CONTACT_RECONCILE_YIELD_SECONDS)
if not progressed:
continue
except asyncio.CancelledError:
logger.info("Background contact reconcile task cancelled")
raise
except Exception as exc:
logger.error("Background contact reconcile failed: %s", exc, exc_info=True)
finally:
if removed > 0 or loaded > 0 or failed > 0:
logger.info(
"Background contact reconcile summary: removed %d, loaded %d, failed %d",
removed,
loaded,
failed,
)
def start_background_contact_reconciliation(
*,
initial_radio_contacts: dict[str, dict],
expected_mc: MeshCore,
) -> None:
"""Start or replace the background contact reconcile task for the current radio."""
global _contact_reconcile_task
if _contact_reconcile_task is not None and not _contact_reconcile_task.done():
_contact_reconcile_task.cancel()
_contact_reconcile_task = asyncio.create_task(
_reconcile_radio_contacts_in_background(
initial_radio_contacts=initial_radio_contacts,
expected_mc=expected_mc,
)
)
logger.info(
"Started background contact reconcile for %d radio contact(s)",
len(initial_radio_contacts),
)
async def stop_background_contact_reconciliation() -> None:
"""Stop the background contact reconcile task."""
global _contact_reconcile_task
if _contact_reconcile_task and not _contact_reconcile_task.done():
_contact_reconcile_task.cancel()
try:
await _contact_reconcile_task
except asyncio.CancelledError:
pass
_contact_reconcile_task = None
async def get_contacts_selected_for_radio_sync() -> list[Contact]: async def get_contacts_selected_for_radio_sync() -> list[Contact]:
+39
View File
@@ -431,6 +431,43 @@ class ContactRepository:
Returns the placeholder public keys that were merged into the full key. Returns the placeholder public keys that were merged into the full key.
""" """
async def migrate_child_rows(old_key: str, new_key: str) -> None:
await db.conn.execute(
"""
INSERT INTO contact_name_history (public_key, name, first_seen, last_seen)
SELECT ?, name, first_seen, last_seen
FROM contact_name_history
WHERE public_key = ?
ON CONFLICT(public_key, name) DO UPDATE SET
first_seen = MIN(contact_name_history.first_seen, excluded.first_seen),
last_seen = MAX(contact_name_history.last_seen, excluded.last_seen)
""",
(new_key, old_key),
)
await db.conn.execute(
"""
INSERT INTO contact_advert_paths
(public_key, path_hex, path_len, first_seen, last_seen, heard_count)
SELECT ?, path_hex, path_len, first_seen, last_seen, heard_count
FROM contact_advert_paths
WHERE public_key = ?
ON CONFLICT(public_key, path_hex, path_len) DO UPDATE SET
first_seen = MIN(contact_advert_paths.first_seen, excluded.first_seen),
last_seen = MAX(contact_advert_paths.last_seen, excluded.last_seen),
heard_count = contact_advert_paths.heard_count + excluded.heard_count
""",
(new_key, old_key),
)
await db.conn.execute(
"DELETE FROM contact_name_history WHERE public_key = ?",
(old_key,),
)
await db.conn.execute(
"DELETE FROM contact_advert_paths WHERE public_key = ?",
(old_key,),
)
normalized_full_key = full_key.lower() normalized_full_key = full_key.lower()
cursor = await db.conn.execute( cursor = await db.conn.execute(
""" """
@@ -467,6 +504,8 @@ class ContactRepository:
if (match_row["match_count"] if match_row is not None else 0) != 1: if (match_row["match_count"] if match_row is not None else 0) != 1:
continue continue
await migrate_child_rows(old_key, normalized_full_key)
if full_exists: if full_exists:
await db.conn.execute( await db.conn.execute(
""" """
+34 -6
View File
@@ -331,6 +331,12 @@ class MessageRepository:
@staticmethod @staticmethod
def _row_to_message(row: Any) -> Message: def _row_to_message(row: Any) -> Message:
"""Convert a database row to a Message model.""" """Convert a database row to a Message model."""
packet_id = None
if hasattr(row, "keys"):
row_keys = row.keys()
if "packet_id" in row_keys:
packet_id = row["packet_id"]
return Message( return Message(
id=row["id"], id=row["id"],
type=row["type"], type=row["type"],
@@ -345,6 +351,14 @@ class MessageRepository:
outgoing=bool(row["outgoing"]), outgoing=bool(row["outgoing"]),
acked=row["acked"], acked=row["acked"],
sender_name=row["sender_name"], sender_name=row["sender_name"],
packet_id=packet_id,
)
@staticmethod
def _message_select(message_alias: str = "messages") -> str:
return (
f"{message_alias}.*, "
f"(SELECT MIN(id) FROM raw_packets WHERE message_id = {message_alias}.id) AS packet_id"
) )
@staticmethod @staticmethod
@@ -363,7 +377,7 @@ class MessageRepository:
) -> list[Message]: ) -> list[Message]:
search_query = MessageRepository._parse_search_query(q) if q else None search_query = MessageRepository._parse_search_query(q) if q else None
query = ( query = (
"SELECT messages.* FROM messages " f"SELECT {MessageRepository._message_select('messages')} FROM messages "
"LEFT JOIN contacts ON messages.type = 'PRIV' " "LEFT JOIN contacts ON messages.type = 'PRIV' "
"AND LOWER(messages.conversation_key) = LOWER(contacts.public_key) " "AND LOWER(messages.conversation_key) = LOWER(contacts.public_key) "
"LEFT JOIN channels ON messages.type = 'CHAN' " "LEFT JOIN channels ON messages.type = 'CHAN' "
@@ -470,7 +484,8 @@ class MessageRepository:
# 1. Get the target message (must satisfy filters if provided) # 1. Get the target message (must satisfy filters if provided)
target_cursor = await db.conn.execute( target_cursor = await db.conn.execute(
f"SELECT * FROM messages WHERE id = ? AND {where_sql}", f"SELECT {MessageRepository._message_select('messages')} "
f"FROM messages WHERE id = ? AND {where_sql}",
(message_id, *base_params), (message_id, *base_params),
) )
target_row = await target_cursor.fetchone() target_row = await target_cursor.fetchone()
@@ -481,7 +496,7 @@ class MessageRepository:
# 2. Get context_size+1 messages before target (DESC) # 2. Get context_size+1 messages before target (DESC)
before_query = f""" before_query = f"""
SELECT * FROM messages WHERE {where_sql} SELECT {MessageRepository._message_select("messages")} FROM messages WHERE {where_sql}
AND (received_at < ? OR (received_at = ? AND id < ?)) AND (received_at < ? OR (received_at = ? AND id < ?))
ORDER BY received_at DESC, id DESC LIMIT ? ORDER BY received_at DESC, id DESC LIMIT ?
""" """
@@ -500,7 +515,7 @@ class MessageRepository:
# 3. Get context_size+1 messages after target (ASC) # 3. Get context_size+1 messages after target (ASC)
after_query = f""" after_query = f"""
SELECT * FROM messages WHERE {where_sql} SELECT {MessageRepository._message_select("messages")} FROM messages WHERE {where_sql}
AND (received_at > ? OR (received_at = ? AND id > ?)) AND (received_at > ? OR (received_at = ? AND id > ?))
ORDER BY received_at ASC, id ASC LIMIT ? ORDER BY received_at ASC, id ASC LIMIT ?
""" """
@@ -545,7 +560,7 @@ class MessageRepository:
async def get_by_id(message_id: int) -> "Message | None": async def get_by_id(message_id: int) -> "Message | None":
"""Look up a message by its ID.""" """Look up a message by its ID."""
cursor = await db.conn.execute( cursor = await db.conn.execute(
"SELECT * FROM messages WHERE id = ?", f"SELECT {MessageRepository._message_select('messages')} FROM messages WHERE id = ?",
(message_id,), (message_id,),
) )
row = await cursor.fetchone() row = await cursor.fetchone()
@@ -554,6 +569,12 @@ class MessageRepository:
return MessageRepository._row_to_message(row) return MessageRepository._row_to_message(row)
@staticmethod
async def delete_by_id(message_id: int) -> None:
"""Delete a message row by ID."""
await db.conn.execute("DELETE FROM messages WHERE id = ?", (message_id,))
await db.conn.commit()
@staticmethod @staticmethod
async def get_by_content( async def get_by_content(
msg_type: str, msg_type: str,
@@ -564,7 +585,9 @@ class MessageRepository:
) -> "Message | None": ) -> "Message | None":
"""Look up a message by its unique content fields.""" """Look up a message by its unique content fields."""
query = """ query = """
SELECT * FROM messages SELECT messages.*,
(SELECT MIN(id) FROM raw_packets WHERE message_id = messages.id) AS packet_id
FROM messages
WHERE type = ? AND conversation_key = ? AND text = ? WHERE type = ? AND conversation_key = ? AND text = ?
AND (sender_timestamp = ? OR (sender_timestamp IS NULL AND ? IS NULL)) AND (sender_timestamp = ? OR (sender_timestamp IS NULL AND ? IS NULL))
""" """
@@ -700,6 +723,11 @@ class MessageRepository:
state_key = f"{prefix}-{row['conversation_key']}" state_key = f"{prefix}-{row['conversation_key']}"
last_message_times[state_key] = row["last_message_time"] last_message_times[state_key] = row["last_message_time"]
# Only include last_read_ats for conversations that actually have messages.
# Without this filter, every contact heard via advertisement (even without
# any DMs) bloats the payload — 391KB down to ~46KB on a typical database.
last_read_ats = {k: v for k, v in last_read_ats.items() if k in last_message_times}
return { return {
"counts": counts, "counts": counts,
"mentions": mention_flags, "mentions": mention_flags,
+12
View File
@@ -121,6 +121,18 @@ class RawPacketRepository:
return None return None
return row["message_id"] return row["message_id"]
@staticmethod
async def get_by_id(packet_id: int) -> tuple[int, bytes, int, int | None] | None:
"""Return a raw packet row as (id, data, timestamp, message_id)."""
cursor = await db.conn.execute(
"SELECT id, data, timestamp, message_id FROM raw_packets WHERE id = ?",
(packet_id,),
)
row = await cursor.fetchone()
if not row:
return None
return (row["id"], bytes(row["data"]), row["timestamp"], row["message_id"])
@staticmethod @staticmethod
async def prune_old_undecrypted(max_age_days: int) -> int: async def prune_old_undecrypted(max_age_days: int) -> int:
"""Delete undecrypted packets older than max_age_days. Returns count deleted.""" """Delete undecrypted packets older than max_age_days. Returns count deleted."""
+26
View File
@@ -270,6 +270,30 @@ class StatisticsRepository:
"last_week": row["last_week"] or 0, "last_week": row["last_week"] or 0,
} }
@staticmethod
async def _known_channels_active() -> dict[str, int]:
"""Count distinct known channel keys with channel traffic in each time window."""
now = int(time.time())
cursor = await db.conn.execute(
"""
SELECT
COUNT(DISTINCT CASE WHEN m.received_at >= ? THEN m.conversation_key END) AS last_hour,
COUNT(DISTINCT CASE WHEN m.received_at >= ? THEN m.conversation_key END) AS last_24_hours,
COUNT(DISTINCT CASE WHEN m.received_at >= ? THEN m.conversation_key END) AS last_week
FROM messages m
INNER JOIN channels c ON UPPER(m.conversation_key) = UPPER(c.key)
WHERE m.type = 'CHAN'
""",
(now - SECONDS_1H, now - SECONDS_24H, now - SECONDS_7D),
)
row = await cursor.fetchone()
assert row is not None
return {
"last_hour": row["last_hour"] or 0,
"last_24_hours": row["last_24_hours"] or 0,
"last_week": row["last_week"] or 0,
}
@staticmethod @staticmethod
async def _path_hash_width_24h() -> dict[str, int | float]: async def _path_hash_width_24h() -> dict[str, int | float]:
"""Count parsed raw packets from the last 24h by hop hash width.""" """Count parsed raw packets from the last 24h by hop hash width."""
@@ -396,6 +420,7 @@ class StatisticsRepository:
# Activity windows # Activity windows
contacts_heard = await StatisticsRepository._activity_counts(contact_type=2, exclude=True) contacts_heard = await StatisticsRepository._activity_counts(contact_type=2, exclude=True)
repeaters_heard = await StatisticsRepository._activity_counts(contact_type=2) repeaters_heard = await StatisticsRepository._activity_counts(contact_type=2)
known_channels_active = await StatisticsRepository._known_channels_active()
path_hash_width_24h = await StatisticsRepository._path_hash_width_24h() path_hash_width_24h = await StatisticsRepository._path_hash_width_24h()
return { return {
@@ -411,5 +436,6 @@ class StatisticsRepository:
"total_outgoing": total_outgoing, "total_outgoing": total_outgoing,
"contacts_heard": contacts_heard, "contacts_heard": contacts_heard,
"repeaters_heard": repeaters_heard, "repeaters_heard": repeaters_heard,
"known_channels_active": known_channels_active,
"path_hash_width_24h": path_hash_width_24h, "path_hash_width_24h": path_hash_width_24h,
} }
+1 -1
View File
@@ -71,7 +71,7 @@ async def create_channel(request: CreateChannelRequest) -> Channel:
requested_name = request.name requested_name = request.name
is_hashtag = requested_name.startswith("#") is_hashtag = requested_name.startswith("#")
# Reserve the canonical Public room so it cannot drift to another key, # Reserve the canonical Public channel so it cannot drift to another key,
# and the well-known Public key cannot be renamed to something else. # and the well-known Public key cannot be renamed to something else.
if is_public_channel_name(requested_name): if is_public_channel_name(requested_name):
if request.key: if request.key:
+18 -1
View File
@@ -10,7 +10,7 @@ from pydantic import BaseModel, Field
from app.config import get_recent_log_lines, settings from app.config import get_recent_log_lines, settings
from app.radio_sync import get_contacts_selected_for_radio_sync, get_radio_channel_limit from app.radio_sync import get_contacts_selected_for_radio_sync, get_radio_channel_limit
from app.repository import MessageRepository from app.repository import MessageRepository, StatisticsRepository
from app.routers.health import HealthResponse, build_health_data from app.routers.health import HealthResponse, build_health_data
from app.services.radio_runtime import radio_runtime from app.services.radio_runtime import radio_runtime
from app.version_info import get_app_build_info, git_output from app.version_info import get_app_build_info, git_output
@@ -78,6 +78,7 @@ class DebugChannelAudit(BaseModel):
class DebugRadioProbe(BaseModel): class DebugRadioProbe(BaseModel):
performed: bool performed: bool
errors: list[str] = Field(default_factory=list) errors: list[str] = Field(default_factory=list)
multi_acks_enabled: bool | None = None
self_info: dict[str, Any] | None = None self_info: dict[str, Any] | None = None
device_info: dict[str, Any] | None = None device_info: dict[str, Any] | None = None
stats_core: dict[str, Any] | None = None stats_core: dict[str, Any] | None = None
@@ -86,11 +87,18 @@ class DebugRadioProbe(BaseModel):
channels: DebugChannelAudit | None = None channels: DebugChannelAudit | None = None
class DebugDatabaseInfo(BaseModel):
total_dms: int
total_channel_messages: int
total_outgoing: int
class DebugSnapshotResponse(BaseModel): class DebugSnapshotResponse(BaseModel):
captured_at: str captured_at: str
application: DebugApplicationInfo application: DebugApplicationInfo
health: HealthResponse health: HealthResponse
runtime: DebugRuntimeInfo runtime: DebugRuntimeInfo
database: DebugDatabaseInfo
radio_probe: DebugRadioProbe radio_probe: DebugRadioProbe
logs: list[str] logs: list[str]
@@ -234,6 +242,9 @@ async def _probe_radio() -> DebugRadioProbe:
return DebugRadioProbe( return DebugRadioProbe(
performed=True, performed=True,
errors=errors, errors=errors,
multi_acks_enabled=bool(mc.self_info.get("multi_acks", 0))
if mc.self_info is not None
else None,
self_info=dict(mc.self_info or {}), self_info=dict(mc.self_info or {}),
device_info=device_info, device_info=device_info,
stats_core=stats_core, stats_core=stats_core,
@@ -254,6 +265,7 @@ async def _probe_radio() -> DebugRadioProbe:
async def debug_support_snapshot() -> DebugSnapshotResponse: async def debug_support_snapshot() -> DebugSnapshotResponse:
"""Return a support/debug snapshot with recent logs and live radio state.""" """Return a support/debug snapshot with recent logs and live radio state."""
health_data = await build_health_data(radio_runtime.is_connected, radio_runtime.connection_info) health_data = await build_health_data(radio_runtime.is_connected, radio_runtime.connection_info)
statistics = await StatisticsRepository.get_all()
radio_probe = await _probe_radio() radio_probe = await _probe_radio()
channels_with_incoming_messages = ( channels_with_incoming_messages = (
await MessageRepository.count_channels_with_incoming_messages() await MessageRepository.count_channels_with_incoming_messages()
@@ -278,6 +290,11 @@ async def debug_support_snapshot() -> DebugSnapshotResponse:
"force_channel_slot_reconfigure": settings.force_channel_slot_reconfigure, "force_channel_slot_reconfigure": settings.force_channel_slot_reconfigure,
}, },
), ),
database=DebugDatabaseInfo(
total_dms=statistics["total_dms"],
total_channel_messages=statistics["total_channel_messages"],
total_outgoing=statistics["total_outgoing"],
),
radio_probe=radio_probe, radio_probe=radio_probe,
logs=[*LOG_COPY_BOUNDARY_PREFIX, *get_recent_log_lines(limit=1000)], logs=[*LOG_COPY_BOUNDARY_PREFIX, *get_recent_log_lines(limit=1000)],
) )
+60 -12
View File
@@ -9,14 +9,14 @@ import string
from fastapi import APIRouter, HTTPException from fastapi import APIRouter, HTTPException
from pydantic import BaseModel, Field from pydantic import BaseModel, Field
from app.config import settings as server_settings
from app.fanout.bot_exec import _analyze_bot_signature from app.fanout.bot_exec import _analyze_bot_signature
from app.fanout.manager import fanout_manager
from app.repository.fanout import FanoutConfigRepository from app.repository.fanout import FanoutConfigRepository
logger = logging.getLogger(__name__) logger = logging.getLogger(__name__)
router = APIRouter(prefix="/fanout", tags=["fanout"]) router = APIRouter(prefix="/fanout", tags=["fanout"])
_VALID_TYPES = {"mqtt_private", "mqtt_community", "bot", "webhook", "apprise", "sqs"} _VALID_TYPES = {"mqtt_private", "mqtt_community", "bot", "webhook", "apprise", "sqs", "map_upload"}
_IATA_RE = re.compile(r"^[A-Z]{3}$") _IATA_RE = re.compile(r"^[A-Z]{3}$")
_DEFAULT_COMMUNITY_MQTT_TOPIC_TEMPLATE = "meshcore/{IATA}/{PUBLIC_KEY}/packets" _DEFAULT_COMMUNITY_MQTT_TOPIC_TEMPLATE = "meshcore/{IATA}/{PUBLIC_KEY}/packets"
@@ -94,6 +94,8 @@ def _validate_and_normalize_config(config_type: str, config: dict) -> dict:
_validate_apprise_config(normalized) _validate_apprise_config(normalized)
elif config_type == "sqs": elif config_type == "sqs":
_validate_sqs_config(normalized) _validate_sqs_config(normalized)
elif config_type == "map_upload":
_validate_map_upload_config(normalized)
return normalized return normalized
@@ -295,10 +297,33 @@ def _validate_sqs_config(config: dict) -> None:
) )
def _validate_map_upload_config(config: dict) -> None:
"""Validate and normalize map_upload config blob."""
api_url = str(config.get("api_url", "")).strip()
if api_url and not api_url.startswith(("http://", "https://")):
raise HTTPException(
status_code=400,
detail="api_url must start with http:// or https://",
)
# Persist the cleaned value (empty string means use the module default)
config["api_url"] = api_url
config["dry_run"] = bool(config.get("dry_run", True))
config["geofence_enabled"] = bool(config.get("geofence_enabled", False))
try:
radius = float(config.get("geofence_radius_km", 0) or 0)
except (TypeError, ValueError):
raise HTTPException(status_code=400, detail="geofence_radius_km must be a number") from None
if radius < 0:
raise HTTPException(status_code=400, detail="geofence_radius_km must be >= 0")
config["geofence_radius_km"] = radius
def _enforce_scope(config_type: str, scope: dict) -> dict: def _enforce_scope(config_type: str, scope: dict) -> dict:
"""Enforce type-specific scope constraints. Returns normalized scope.""" """Enforce type-specific scope constraints. Returns normalized scope."""
if config_type == "mqtt_community": if config_type == "mqtt_community":
return {"messages": "none", "raw_packets": "all"} return {"messages": "none", "raw_packets": "all"}
if config_type == "map_upload":
return {"messages": "none", "raw_packets": "all"}
if config_type == "bot": if config_type == "bot":
return {"messages": "all", "raw_packets": "none"} return {"messages": "all", "raw_packets": "none"}
if config_type in ("webhook", "apprise"): if config_type in ("webhook", "apprise"):
@@ -325,6 +350,15 @@ def _enforce_scope(config_type: str, scope: dict) -> dict:
return {"messages": messages, "raw_packets": raw_packets} return {"messages": messages, "raw_packets": raw_packets}
def _bot_system_disabled_detail() -> str | None:
source = fanout_manager.get_bots_disabled_source()
if source == "env":
return "Bot system disabled by server configuration (MESHCORE_DISABLE_BOTS)"
if source == "until_restart":
return "Bot system disabled until the server restarts"
return None
@router.get("") @router.get("")
async def list_fanout_configs() -> list[dict]: async def list_fanout_configs() -> list[dict]:
"""List all fanout configs.""" """List all fanout configs."""
@@ -340,8 +374,10 @@ async def create_fanout_config(body: FanoutConfigCreate) -> dict:
detail=f"Invalid type '{body.type}'. Must be one of: {', '.join(sorted(_VALID_TYPES))}", detail=f"Invalid type '{body.type}'. Must be one of: {', '.join(sorted(_VALID_TYPES))}",
) )
if body.type == "bot" and server_settings.disable_bots: if body.type == "bot":
raise HTTPException(status_code=403, detail="Bot system disabled by server configuration") disabled_detail = _bot_system_disabled_detail()
if disabled_detail:
raise HTTPException(status_code=403, detail=disabled_detail)
normalized_config = _validate_and_normalize_config(body.type, body.config) normalized_config = _validate_and_normalize_config(body.type, body.config)
scope = _enforce_scope(body.type, body.scope) scope = _enforce_scope(body.type, body.scope)
@@ -356,8 +392,6 @@ async def create_fanout_config(body: FanoutConfigCreate) -> dict:
# Start the module if enabled # Start the module if enabled
if cfg["enabled"]: if cfg["enabled"]:
from app.fanout.manager import fanout_manager
await fanout_manager.reload_config(cfg["id"]) await fanout_manager.reload_config(cfg["id"])
logger.info("Created fanout config %s (type=%s, name=%s)", cfg["id"], body.type, body.name) logger.info("Created fanout config %s (type=%s, name=%s)", cfg["id"], body.type, body.name)
@@ -371,8 +405,10 @@ async def update_fanout_config(config_id: str, body: FanoutConfigUpdate) -> dict
if existing is None: if existing is None:
raise HTTPException(status_code=404, detail="Fanout config not found") raise HTTPException(status_code=404, detail="Fanout config not found")
if existing["type"] == "bot" and server_settings.disable_bots: if existing["type"] == "bot":
raise HTTPException(status_code=403, detail="Bot system disabled by server configuration") disabled_detail = _bot_system_disabled_detail()
if disabled_detail:
raise HTTPException(status_code=403, detail=disabled_detail)
kwargs = {} kwargs = {}
if body.name is not None: if body.name is not None:
@@ -390,8 +426,6 @@ async def update_fanout_config(config_id: str, body: FanoutConfigUpdate) -> dict
raise HTTPException(status_code=404, detail="Fanout config not found") raise HTTPException(status_code=404, detail="Fanout config not found")
# Reload the module to pick up changes # Reload the module to pick up changes
from app.fanout.manager import fanout_manager
await fanout_manager.reload_config(config_id) await fanout_manager.reload_config(config_id)
logger.info("Updated fanout config %s", config_id) logger.info("Updated fanout config %s", config_id)
@@ -406,10 +440,24 @@ async def delete_fanout_config(config_id: str) -> dict:
raise HTTPException(status_code=404, detail="Fanout config not found") raise HTTPException(status_code=404, detail="Fanout config not found")
# Stop the module first # Stop the module first
from app.fanout.manager import fanout_manager
await fanout_manager.remove_config(config_id) await fanout_manager.remove_config(config_id)
await FanoutConfigRepository.delete(config_id) await FanoutConfigRepository.delete(config_id)
logger.info("Deleted fanout config %s", config_id) logger.info("Deleted fanout config %s", config_id)
return {"deleted": True} return {"deleted": True}
@router.post("/bots/disable-until-restart")
async def disable_bots_until_restart() -> dict:
"""Stop active bot modules and prevent them from running again until restart."""
source = await fanout_manager.disable_bots_until_restart()
from app.services.radio_runtime import radio_runtime as radio_manager
from app.websocket import broadcast_health
broadcast_health(radio_manager.is_connected, radio_manager.connection_info)
return {
"status": "ok",
"bots_disabled": True,
"bots_disabled_source": source,
}
+24 -4
View File
@@ -1,8 +1,8 @@
import os import os
from typing import Any from typing import Any, Literal
from fastapi import APIRouter from fastapi import APIRouter
from pydantic import BaseModel from pydantic import BaseModel, Field
from app.config import settings from app.config import settings
from app.repository import RawPacketRepository from app.repository import RawPacketRepository
@@ -25,6 +25,13 @@ class AppInfoResponse(BaseModel):
commit_hash: str | None = None commit_hash: str | None = None
class FanoutStatusResponse(BaseModel):
name: str
type: str
status: str
last_error: str | None = None
class HealthResponse(BaseModel): class HealthResponse(BaseModel):
status: str status: str
radio_connected: bool radio_connected: bool
@@ -35,8 +42,10 @@ class HealthResponse(BaseModel):
radio_device_info: RadioDeviceInfoResponse | None = None radio_device_info: RadioDeviceInfoResponse | None = None
database_size_mb: float database_size_mb: float
oldest_undecrypted_timestamp: int | None oldest_undecrypted_timestamp: int | None
fanout_statuses: dict[str, dict[str, str]] = {} fanout_statuses: dict[str, FanoutStatusResponse] = Field(default_factory=dict)
bots_disabled: bool = False bots_disabled: bool = False
bots_disabled_source: Literal["env", "until_restart"] | None = None
basic_auth_enabled: bool = False
def _clean_optional_str(value: object) -> str | None: def _clean_optional_str(value: object) -> str | None:
@@ -46,6 +55,11 @@ def _clean_optional_str(value: object) -> str | None:
return cleaned or None return cleaned or None
def _read_optional_bool_setting(name: str) -> bool:
value = getattr(settings, name, False)
return value if isinstance(value, bool) else False
async def build_health_data(radio_connected: bool, connection_info: str | None) -> dict: async def build_health_data(radio_connected: bool, connection_info: str | None) -> dict:
"""Build the health status payload used by REST endpoint and WebSocket broadcasts.""" """Build the health status payload used by REST endpoint and WebSocket broadcasts."""
app_build_info = get_app_build_info() app_build_info = get_app_build_info()
@@ -64,10 +78,14 @@ async def build_health_data(radio_connected: bool, connection_info: str | None)
# Fanout module statuses # Fanout module statuses
fanout_statuses: dict[str, Any] = {} fanout_statuses: dict[str, Any] = {}
bots_disabled_source = "env" if _read_optional_bool_setting("disable_bots") else None
try: try:
from app.fanout.manager import fanout_manager from app.fanout.manager import fanout_manager
fanout_statuses = fanout_manager.get_statuses() fanout_statuses = fanout_manager.get_statuses()
manager_bots_disabled_source = fanout_manager.get_bots_disabled_source()
if manager_bots_disabled_source is not None:
bots_disabled_source = manager_bots_disabled_source
except Exception: except Exception:
pass pass
@@ -118,7 +136,9 @@ async def build_health_data(radio_connected: bool, connection_info: str | None)
"database_size_mb": db_size_mb, "database_size_mb": db_size_mb,
"oldest_undecrypted_timestamp": oldest_ts, "oldest_undecrypted_timestamp": oldest_ts,
"fanout_statuses": fanout_statuses, "fanout_statuses": fanout_statuses,
"bots_disabled": settings.disable_bots, "bots_disabled": bots_disabled_source is not None,
"bots_disabled_source": bots_disabled_source,
"basic_auth_enabled": _read_optional_bool_setting("basic_auth_enabled"),
} }
+41 -1
View File
@@ -8,8 +8,9 @@ from pydantic import BaseModel, Field
from app.database import db from app.database import db
from app.decoder import parse_packet, try_decrypt_packet_with_channel_key from app.decoder import parse_packet, try_decrypt_packet_with_channel_key
from app.models import RawPacketDecryptedInfo, RawPacketDetail
from app.packet_processor import create_message_from_decrypted, run_historical_dm_decryption from app.packet_processor import create_message_from_decrypted, run_historical_dm_decryption
from app.repository import ChannelRepository, RawPacketRepository from app.repository import ChannelRepository, MessageRepository, RawPacketRepository
from app.websocket import broadcast_success from app.websocket import broadcast_success
logger = logging.getLogger(__name__) logger = logging.getLogger(__name__)
@@ -102,6 +103,45 @@ async def get_undecrypted_count() -> dict:
return {"count": count} return {"count": count}
@router.get("/{packet_id}", response_model=RawPacketDetail)
async def get_raw_packet(packet_id: int) -> RawPacketDetail:
"""Fetch one stored raw packet by row ID for on-demand inspection."""
packet_row = await RawPacketRepository.get_by_id(packet_id)
if packet_row is None:
raise HTTPException(status_code=404, detail="Raw packet not found")
stored_packet_id, packet_data, packet_timestamp, message_id = packet_row
packet_info = parse_packet(packet_data)
payload_type_name = packet_info.payload_type.name if packet_info else "Unknown"
decrypted_info: RawPacketDecryptedInfo | None = None
if message_id is not None:
message = await MessageRepository.get_by_id(message_id)
if message is not None:
if message.type == "CHAN":
channel = await ChannelRepository.get_by_key(message.conversation_key)
decrypted_info = RawPacketDecryptedInfo(
channel_name=channel.name if channel else None,
sender=message.sender_name,
channel_key=message.conversation_key,
contact_key=message.sender_key,
)
else:
decrypted_info = RawPacketDecryptedInfo(
sender=message.sender_name,
contact_key=message.conversation_key,
)
return RawPacketDetail(
id=stored_packet_id,
timestamp=packet_timestamp,
data=packet_data.hex(),
payload_type=payload_type_name,
decrypted=message_id is not None,
decrypted_info=decrypted_info,
)
@router.post("/decrypt/historical", response_model=DecryptResult) @router.post("/decrypt/historical", response_model=DecryptResult)
async def decrypt_historical_packets( async def decrypt_historical_packets(
request: DecryptRequest, background_tasks: BackgroundTasks, response: Response request: DecryptRequest, background_tasks: BackgroundTasks, response: Response
+9
View File
@@ -81,6 +81,10 @@ class RadioConfigResponse(BaseModel):
default="current", default="current",
description="Whether adverts include the node's current location state", description="Whether adverts include the node's current location state",
) )
multi_acks_enabled: bool = Field(
default=False,
description="Whether the radio sends an extra direct ACK transmission",
)
class RadioConfigUpdate(BaseModel): class RadioConfigUpdate(BaseModel):
@@ -99,6 +103,10 @@ class RadioConfigUpdate(BaseModel):
default=None, default=None,
description="Whether adverts include the node's current location state", description="Whether adverts include the node's current location state",
) )
multi_acks_enabled: bool | None = Field(
default=None,
description="Whether the radio sends an extra direct ACK transmission",
)
class PrivateKeyUpdate(BaseModel): class PrivateKeyUpdate(BaseModel):
@@ -222,6 +230,7 @@ async def get_radio_config() -> RadioConfigResponse:
path_hash_mode=radio_manager.path_hash_mode, path_hash_mode=radio_manager.path_hash_mode,
path_hash_mode_supported=radio_manager.path_hash_mode_supported, path_hash_mode_supported=radio_manager.path_hash_mode_supported,
advert_location_source=advert_location_source, advert_location_source=advert_location_source,
multi_acks_enabled=bool(info.get("multi_acks", 0)),
) )
+25 -234
View File
@@ -1,6 +1,5 @@
import asyncio import asyncio
import logging import logging
import time
from typing import TYPE_CHECKING from typing import TYPE_CHECKING
from fastapi import APIRouter, HTTPException from fastapi import APIRouter, HTTPException
@@ -28,6 +27,14 @@ from app.models import (
) )
from app.repository import ContactRepository from app.repository import ContactRepository
from app.routers.contacts import _ensure_on_radio, _resolve_contact_or_404 from app.routers.contacts import _ensure_on_radio, _resolve_contact_or_404
from app.routers.server_control import (
_monotonic,
batch_cli_fetch,
extract_response_text,
prepare_authenticated_contact_connection,
require_server_capable_contact,
send_contact_cli_command,
)
from app.services.radio_runtime import radio_runtime as radio_manager from app.services.radio_runtime import radio_runtime as radio_manager
if TYPE_CHECKING: if TYPE_CHECKING:
@@ -43,39 +50,11 @@ ACL_PERMISSION_NAMES = {
3: "Admin", 3: "Admin",
} }
router = APIRouter(prefix="/contacts", tags=["repeaters"]) router = APIRouter(prefix="/contacts", tags=["repeaters"])
REPEATER_LOGIN_RESPONSE_TIMEOUT_SECONDS = 5.0 REPEATER_LOGIN_RESPONSE_TIMEOUT_SECONDS = 5.0
REPEATER_LOGIN_REJECTED_MESSAGE = (
"The repeater replied but did not confirm this login. "
"Existing access may still allow some repeater operations, but admin actions may fail."
)
REPEATER_LOGIN_SEND_FAILED_MESSAGE = (
"The login request could not be sent to the repeater. "
"The dashboard is still available, but repeater operations may fail until a login succeeds."
)
REPEATER_LOGIN_TIMEOUT_MESSAGE = (
"No login confirmation was heard from the repeater. "
"On current repeater firmware, that can mean the password was wrong, "
"blank-password login was not allowed by the ACL, or the reply was missed in transit. "
"The dashboard is still available; try logging in again if admin actions fail."
)
def _monotonic() -> float:
"""Wrapper around time.monotonic() for testability.
Patching time.monotonic directly breaks the asyncio event loop which also
uses it. This indirection allows tests to control the clock safely.
"""
return time.monotonic()
def _extract_response_text(event) -> str: def _extract_response_text(event) -> str:
"""Extract text from a CLI response event, stripping the firmware '> ' prefix.""" return extract_response_text(event)
text = event.payload.get("text", str(event.payload))
if text.startswith("> "):
text = text[2:]
return text
async def _fetch_repeater_response( async def _fetch_repeater_response(
@@ -83,21 +62,6 @@ async def _fetch_repeater_response(
target_pubkey_prefix: str, target_pubkey_prefix: str,
timeout: float = 20.0, timeout: float = 20.0,
) -> "Event | None": ) -> "Event | None":
"""Fetch a CLI response from a specific repeater via a validated get_msg() loop.
Calls get_msg() repeatedly until a matching CLI response (txt_type=1) from the
target repeater arrives or the wall-clock deadline expires. Unrelated messages
are safe to skip meshcore's event dispatcher already delivers them to the
normal subscription handlers (on_contact_message, etc.) when get_msg() returns.
Args:
mc: MeshCore instance
target_pubkey_prefix: 12-char hex prefix of the repeater's public key
timeout: Wall-clock seconds before giving up
Returns:
The matching Event, or None if no response arrived before the deadline.
"""
deadline = _monotonic() + timeout deadline = _monotonic() + timeout
while _monotonic() < deadline: while _monotonic() < deadline:
@@ -105,13 +69,12 @@ async def _fetch_repeater_response(
result = await mc.commands.get_msg(timeout=2.0) result = await mc.commands.get_msg(timeout=2.0)
except asyncio.TimeoutError: except asyncio.TimeoutError:
continue continue
except Exception as e: except Exception as exc:
logger.debug("get_msg() exception: %s", e) logger.debug("get_msg() exception: %s", exc)
await asyncio.sleep(1.0) await asyncio.sleep(1.0)
continue continue
if result.type == EventType.NO_MORE_MSGS: if result.type == EventType.NO_MORE_MSGS:
# No messages queued yet — wait and retry
await asyncio.sleep(1.0) await asyncio.sleep(1.0)
continue continue
@@ -125,8 +88,6 @@ async def _fetch_repeater_response(
txt_type = result.payload.get("txt_type", 0) txt_type = result.payload.get("txt_type", 0)
if msg_prefix == target_pubkey_prefix and txt_type == 1: if msg_prefix == target_pubkey_prefix and txt_type == 1:
return result return result
# Not our target — already dispatched to subscribers by meshcore,
# so just continue draining the queue.
logger.debug( logger.debug(
"Skipping non-target message (from=%s, txt_type=%d) while waiting for %s", "Skipping non-target message (from=%s, txt_type=%d) while waiting for %s",
msg_prefix, msg_prefix,
@@ -136,7 +97,6 @@ async def _fetch_repeater_response(
continue continue
if result.type == EventType.CHANNEL_MSG_RECV: if result.type == EventType.CHANNEL_MSG_RECV:
# Already dispatched to subscribers by meshcore; skip.
logger.debug( logger.debug(
"Skipping channel message (channel_idx=%s) during repeater fetch", "Skipping channel message (channel_idx=%s) during repeater fetch",
result.payload.get("channel_idx"), result.payload.get("channel_idx"),
@@ -150,87 +110,13 @@ async def _fetch_repeater_response(
async def prepare_repeater_connection(mc, contact: Contact, password: str) -> RepeaterLoginResponse: async def prepare_repeater_connection(mc, contact: Contact, password: str) -> RepeaterLoginResponse:
"""Prepare connection to a repeater by adding to radio and attempting login. return await prepare_authenticated_contact_connection(
mc,
Args: contact,
mc: MeshCore instance password,
contact: The repeater contact label="repeater",
password: Password for login (empty string for no password) response_timeout=REPEATER_LOGIN_RESPONSE_TIMEOUT_SECONDS,
"""
pubkey_prefix = contact.public_key[:12].lower()
loop = asyncio.get_running_loop()
login_future = loop.create_future()
def _resolve_login(event_type: EventType, message: str | None = None) -> None:
if login_future.done():
return
login_future.set_result(
RepeaterLoginResponse(
status="ok" if event_type == EventType.LOGIN_SUCCESS else "error",
authenticated=event_type == EventType.LOGIN_SUCCESS,
message=message,
)
)
success_subscription = mc.subscribe(
EventType.LOGIN_SUCCESS,
lambda _event: _resolve_login(EventType.LOGIN_SUCCESS),
attribute_filters={"pubkey_prefix": pubkey_prefix},
) )
failed_subscription = mc.subscribe(
EventType.LOGIN_FAILED,
lambda _event: _resolve_login(
EventType.LOGIN_FAILED,
REPEATER_LOGIN_REJECTED_MESSAGE,
),
attribute_filters={"pubkey_prefix": pubkey_prefix},
)
# Add contact to radio with path from DB (non-fatal — contact may already be loaded)
try:
logger.info("Adding repeater %s to radio", contact.public_key[:12])
await _ensure_on_radio(mc, contact)
logger.info("Sending login to repeater %s", contact.public_key[:12])
login_result = await mc.commands.send_login(contact.public_key, password)
if login_result.type == EventType.ERROR:
return RepeaterLoginResponse(
status="error",
authenticated=False,
message=f"{REPEATER_LOGIN_SEND_FAILED_MESSAGE} ({login_result.payload})",
)
try:
return await asyncio.wait_for(
login_future,
timeout=REPEATER_LOGIN_RESPONSE_TIMEOUT_SECONDS,
)
except asyncio.TimeoutError:
logger.warning(
"No login response from repeater %s within %.1fs",
contact.public_key[:12],
REPEATER_LOGIN_RESPONSE_TIMEOUT_SECONDS,
)
return RepeaterLoginResponse(
status="timeout",
authenticated=False,
message=REPEATER_LOGIN_TIMEOUT_MESSAGE,
)
except HTTPException as exc:
logger.warning(
"Repeater login setup failed for %s: %s",
contact.public_key[:12],
exc.detail,
)
return RepeaterLoginResponse(
status="error",
authenticated=False,
message=f"{REPEATER_LOGIN_SEND_FAILED_MESSAGE} ({exc.detail})",
)
finally:
success_subscription.unsubscribe()
failed_subscription.unsubscribe()
def _require_repeater(contact: Contact) -> None: def _require_repeater(contact: Contact) -> None:
@@ -403,43 +289,7 @@ async def _batch_cli_fetch(
operation_name: str, operation_name: str,
commands: list[tuple[str, str]], commands: list[tuple[str, str]],
) -> dict[str, str | None]: ) -> dict[str, str | None]:
"""Send a batch of CLI commands to a repeater and collect responses. return await batch_cli_fetch(contact, operation_name, commands)
Opens a radio operation with polling paused and auto-fetch suspended (since
we call get_msg() directly via _fetch_repeater_response), adds the contact
to the radio for routing, then sends each command sequentially with a 1-second
gap between them.
Returns a dict mapping field names to response strings (or None on timeout).
"""
results: dict[str, str | None] = {field: None for _, field in commands}
async with radio_manager.radio_operation(
operation_name,
pause_polling=True,
suspend_auto_fetch=True,
) as mc:
await _ensure_on_radio(mc, contact)
await asyncio.sleep(1.0)
for i, (cmd, field) in enumerate(commands):
if i > 0:
await asyncio.sleep(1.0)
send_result = await mc.commands.send_cmd(contact.public_key, cmd)
if send_result.type == EventType.ERROR:
logger.debug("Command '%s' send error: %s", cmd, send_result.payload)
continue
response_event = await _fetch_repeater_response(
mc, contact.public_key[:12], timeout=10.0
)
if response_event is not None:
results[field] = _extract_response_text(response_event)
else:
logger.warning("No response for command '%s' (%s)", cmd, field)
return results
@router.post("/{public_key}/repeater/node-info", response_model=RepeaterNodeInfoResponse) @router.post("/{public_key}/repeater/node-info", response_model=RepeaterNodeInfoResponse)
@@ -524,72 +374,13 @@ async def repeater_owner_info(public_key: str) -> RepeaterOwnerInfoResponse:
@router.post("/{public_key}/command", response_model=CommandResponse) @router.post("/{public_key}/command", response_model=CommandResponse)
async def send_repeater_command(public_key: str, request: CommandRequest) -> CommandResponse: async def send_repeater_command(public_key: str, request: CommandRequest) -> CommandResponse:
"""Send a CLI command to a repeater. """Send a CLI command to a repeater or room server."""
The contact must be a repeater (type=2). The user must have already logged in
via the repeater/login endpoint. This endpoint ensures the contact is on the
radio before sending commands (the repeater remembers ACL permissions after login).
Common commands:
- get name, set name <value>
- get tx, set tx <dbm>
- get radio, set radio <freq,bw,sf,cr>
- tempradio <freq,bw,sf,cr,minutes>
- setperm <pubkey> <permission> (0=guest, 1=read-only, 2=read-write, 3=admin)
- clock, clock sync, time <epoch_seconds>
- reboot
- ver
"""
require_connected() require_connected()
# Get contact from database
contact = await _resolve_contact_or_404(public_key) contact = await _resolve_contact_or_404(public_key)
_require_repeater(contact) require_server_capable_contact(contact)
return await send_contact_cli_command(
async with radio_manager.radio_operation( contact,
"send_repeater_command", request.command,
pause_polling=True, operation_name="send_repeater_command",
suspend_auto_fetch=True, )
) as mc:
# Add contact to radio with path from DB (non-fatal — contact may already be loaded)
logger.info("Adding repeater %s to radio", contact.public_key[:12])
await _ensure_on_radio(mc, contact)
await asyncio.sleep(1.0)
# Send the command
logger.info("Sending command to repeater %s: %s", contact.public_key[:12], request.command)
send_result = await mc.commands.send_cmd(contact.public_key, request.command)
if send_result.type == EventType.ERROR:
raise HTTPException(
status_code=500, detail=f"Failed to send command: {send_result.payload}"
)
# Wait for response using validated fetch loop
response_event = await _fetch_repeater_response(mc, contact.public_key[:12])
if response_event is None:
logger.warning(
"No response from repeater %s for command: %s",
contact.public_key[:12],
request.command,
)
return CommandResponse(
command=request.command,
response="(no response - command may have been processed)",
)
# CONTACT_MSG_RECV payloads use sender_timestamp in meshcore.
response_text = _extract_response_text(response_event)
sender_timestamp = response_event.payload.get(
"sender_timestamp",
response_event.payload.get("timestamp"),
)
logger.info("Received response from %s: %s", contact.public_key[:12], response_text)
return CommandResponse(
command=request.command,
response=response_text,
sender_timestamp=sender_timestamp,
)
+145
View File
@@ -0,0 +1,145 @@
from fastapi import APIRouter, HTTPException
from app.dependencies import require_connected
from app.models import (
CONTACT_TYPE_ROOM,
AclEntry,
LppSensor,
RepeaterAclResponse,
RepeaterLoginRequest,
RepeaterLoginResponse,
RepeaterLppTelemetryResponse,
RepeaterStatusResponse,
)
from app.routers.contacts import _ensure_on_radio, _resolve_contact_or_404
from app.routers.server_control import (
prepare_authenticated_contact_connection,
require_server_capable_contact,
)
from app.services.radio_runtime import radio_runtime as radio_manager
router = APIRouter(prefix="/contacts", tags=["rooms"])
def _require_room(contact) -> None:
require_server_capable_contact(contact, allowed_types=(CONTACT_TYPE_ROOM,))
@router.post("/{public_key}/room/login", response_model=RepeaterLoginResponse)
async def room_login(public_key: str, request: RepeaterLoginRequest) -> RepeaterLoginResponse:
"""Attempt room-server login and report whether auth was confirmed."""
require_connected()
contact = await _resolve_contact_or_404(public_key)
_require_room(contact)
async with radio_manager.radio_operation(
"room_login",
pause_polling=True,
suspend_auto_fetch=True,
) as mc:
return await prepare_authenticated_contact_connection(
mc,
contact,
request.password,
label="room server",
)
@router.post("/{public_key}/room/status", response_model=RepeaterStatusResponse)
async def room_status(public_key: str) -> RepeaterStatusResponse:
"""Fetch status telemetry from a room server."""
require_connected()
contact = await _resolve_contact_or_404(public_key)
_require_room(contact)
async with radio_manager.radio_operation(
"room_status", pause_polling=True, suspend_auto_fetch=True
) as mc:
await _ensure_on_radio(mc, contact)
status = await mc.commands.req_status_sync(contact.public_key, timeout=10, min_timeout=5)
if status is None:
raise HTTPException(status_code=504, detail="No status response from room server")
return RepeaterStatusResponse(
battery_volts=status.get("bat", 0) / 1000.0,
tx_queue_len=status.get("tx_queue_len", 0),
noise_floor_dbm=status.get("noise_floor", 0),
last_rssi_dbm=status.get("last_rssi", 0),
last_snr_db=status.get("last_snr", 0.0),
packets_received=status.get("nb_recv", 0),
packets_sent=status.get("nb_sent", 0),
airtime_seconds=status.get("airtime", 0),
rx_airtime_seconds=status.get("rx_airtime", 0),
uptime_seconds=status.get("uptime", 0),
sent_flood=status.get("sent_flood", 0),
sent_direct=status.get("sent_direct", 0),
recv_flood=status.get("recv_flood", 0),
recv_direct=status.get("recv_direct", 0),
flood_dups=status.get("flood_dups", 0),
direct_dups=status.get("direct_dups", 0),
full_events=status.get("full_evts", 0),
)
@router.post("/{public_key}/room/lpp-telemetry", response_model=RepeaterLppTelemetryResponse)
async def room_lpp_telemetry(public_key: str) -> RepeaterLppTelemetryResponse:
"""Fetch CayenneLPP telemetry from a room server."""
require_connected()
contact = await _resolve_contact_or_404(public_key)
_require_room(contact)
async with radio_manager.radio_operation(
"room_lpp_telemetry", pause_polling=True, suspend_auto_fetch=True
) as mc:
await _ensure_on_radio(mc, contact)
telemetry = await mc.commands.req_telemetry_sync(
contact.public_key, timeout=10, min_timeout=5
)
if telemetry is None:
raise HTTPException(status_code=504, detail="No telemetry response from room server")
sensors = [
LppSensor(
channel=entry.get("channel", 0),
type_name=str(entry.get("type", "unknown")),
value=entry.get("value", 0),
)
for entry in telemetry
]
return RepeaterLppTelemetryResponse(sensors=sensors)
@router.post("/{public_key}/room/acl", response_model=RepeaterAclResponse)
async def room_acl(public_key: str) -> RepeaterAclResponse:
"""Fetch ACL entries from a room server."""
require_connected()
contact = await _resolve_contact_or_404(public_key)
_require_room(contact)
async with radio_manager.radio_operation(
"room_acl", pause_polling=True, suspend_auto_fetch=True
) as mc:
await _ensure_on_radio(mc, contact)
acl_data = await mc.commands.req_acl_sync(contact.public_key, timeout=10, min_timeout=5)
acl_entries = []
if acl_data and isinstance(acl_data, list):
from app.repository import ContactRepository
from app.routers.repeaters import ACL_PERMISSION_NAMES
for entry in acl_data:
pubkey_prefix = entry.get("key", "")
perm = entry.get("perm", 0)
resolved_contact = await ContactRepository.get_by_key_prefix(pubkey_prefix)
acl_entries.append(
AclEntry(
pubkey_prefix=pubkey_prefix,
name=resolved_contact.name if resolved_contact else None,
permission=perm,
permission_name=ACL_PERMISSION_NAMES.get(perm, f"Unknown({perm})"),
)
)
return RepeaterAclResponse(acl=acl_entries)
+317
View File
@@ -0,0 +1,317 @@
import asyncio
import logging
import time
from typing import TYPE_CHECKING
from fastapi import HTTPException
from meshcore import EventType
from app.models import (
CONTACT_TYPE_REPEATER,
CONTACT_TYPE_ROOM,
CommandResponse,
Contact,
RepeaterLoginResponse,
)
from app.routers.contacts import _ensure_on_radio
from app.services.radio_runtime import radio_runtime as radio_manager
if TYPE_CHECKING:
from meshcore.events import Event
logger = logging.getLogger(__name__)
SERVER_LOGIN_RESPONSE_TIMEOUT_SECONDS = 5.0
def _monotonic() -> float:
"""Wrapper around time.monotonic() for testability."""
return time.monotonic()
def get_server_contact_label(contact: Contact) -> str:
"""Return a user-facing label for server-capable contacts."""
if contact.type == CONTACT_TYPE_REPEATER:
return "repeater"
if contact.type == CONTACT_TYPE_ROOM:
return "room server"
return "server"
def require_server_capable_contact(
contact: Contact,
*,
allowed_types: tuple[int, ...] = (CONTACT_TYPE_REPEATER, CONTACT_TYPE_ROOM),
) -> None:
"""Raise 400 if the contact does not support server control/login features."""
if contact.type not in allowed_types:
expected = ", ".join(str(value) for value in allowed_types)
raise HTTPException(
status_code=400,
detail=f"Contact is not a supported server contact (type={contact.type}, expected one of {expected})",
)
def _login_rejected_message(label: str) -> str:
return (
f"The {label} replied but did not confirm this login. "
f"Existing access may still allow some {label} operations, but privileged actions may fail."
)
def _login_send_failed_message(label: str) -> str:
return (
f"The login request could not be sent to the {label}. "
f"You're free to attempt interaction; try logging in again if authenticated actions fail."
)
def _login_timeout_message(label: str) -> str:
return (
f"No login confirmation was heard from the {label}. "
"That can mean the password was wrong or the reply was missed in transit. "
"You're free to attempt interaction; try logging in again if authenticated actions fail."
)
def extract_response_text(event) -> str:
"""Extract text from a CLI response event, stripping the firmware '> ' prefix."""
text = event.payload.get("text", str(event.payload))
if text.startswith("> "):
text = text[2:]
return text
async def fetch_contact_cli_response(
mc,
target_pubkey_prefix: str,
timeout: float = 20.0,
) -> "Event | None":
"""Fetch a CLI response from a specific contact via a validated get_msg() loop."""
deadline = _monotonic() + timeout
while _monotonic() < deadline:
try:
result = await mc.commands.get_msg(timeout=2.0)
except asyncio.TimeoutError:
continue
except Exception as exc:
logger.debug("get_msg() exception: %s", exc)
await asyncio.sleep(1.0)
continue
if result.type == EventType.NO_MORE_MSGS:
await asyncio.sleep(1.0)
continue
if result.type == EventType.ERROR:
logger.debug("get_msg() error: %s", result.payload)
await asyncio.sleep(1.0)
continue
if result.type == EventType.CONTACT_MSG_RECV:
msg_prefix = result.payload.get("pubkey_prefix", "")
txt_type = result.payload.get("txt_type", 0)
if msg_prefix == target_pubkey_prefix and txt_type == 1:
return result
logger.debug(
"Skipping non-target message (from=%s, txt_type=%d) while waiting for %s",
msg_prefix,
txt_type,
target_pubkey_prefix,
)
continue
if result.type == EventType.CHANNEL_MSG_RECV:
logger.debug(
"Skipping channel message (channel_idx=%s) during CLI fetch",
result.payload.get("channel_idx"),
)
continue
logger.debug("Unexpected event type %s during CLI fetch, skipping", result.type)
logger.warning("No CLI response from contact %s within %.1fs", target_pubkey_prefix, timeout)
return None
async def prepare_authenticated_contact_connection(
mc,
contact: Contact,
password: str,
*,
label: str | None = None,
response_timeout: float = SERVER_LOGIN_RESPONSE_TIMEOUT_SECONDS,
) -> RepeaterLoginResponse:
"""Prepare connection to a server-capable contact by adding it to the radio and logging in."""
pubkey_prefix = contact.public_key[:12].lower()
contact_label = label or get_server_contact_label(contact)
loop = asyncio.get_running_loop()
login_future = loop.create_future()
def _resolve_login(event_type: EventType, message: str | None = None) -> None:
if login_future.done():
return
login_future.set_result(
RepeaterLoginResponse(
status="ok" if event_type == EventType.LOGIN_SUCCESS else "error",
authenticated=event_type == EventType.LOGIN_SUCCESS,
message=message,
)
)
success_subscription = mc.subscribe(
EventType.LOGIN_SUCCESS,
lambda _event: _resolve_login(EventType.LOGIN_SUCCESS),
attribute_filters={"pubkey_prefix": pubkey_prefix},
)
failed_subscription = mc.subscribe(
EventType.LOGIN_FAILED,
lambda _event: _resolve_login(
EventType.LOGIN_FAILED,
_login_rejected_message(contact_label),
),
attribute_filters={"pubkey_prefix": pubkey_prefix},
)
try:
logger.info("Adding %s %s to radio", contact_label, contact.public_key[:12])
await _ensure_on_radio(mc, contact)
logger.info("Sending login to %s %s", contact_label, contact.public_key[:12])
login_result = await mc.commands.send_login(contact.public_key, password)
if login_result.type == EventType.ERROR:
return RepeaterLoginResponse(
status="error",
authenticated=False,
message=f"{_login_send_failed_message(contact_label)} ({login_result.payload})",
)
try:
return await asyncio.wait_for(
login_future,
timeout=response_timeout,
)
except asyncio.TimeoutError:
logger.warning(
"No login response from %s %s within %.1fs",
contact_label,
contact.public_key[:12],
response_timeout,
)
return RepeaterLoginResponse(
status="timeout",
authenticated=False,
message=_login_timeout_message(contact_label),
)
except HTTPException as exc:
logger.warning(
"%s login setup failed for %s: %s",
contact_label.capitalize(),
contact.public_key[:12],
exc.detail,
)
return RepeaterLoginResponse(
status="error",
authenticated=False,
message=f"{_login_send_failed_message(contact_label)} ({exc.detail})",
)
finally:
success_subscription.unsubscribe()
failed_subscription.unsubscribe()
async def batch_cli_fetch(
contact: Contact,
operation_name: str,
commands: list[tuple[str, str]],
) -> dict[str, str | None]:
"""Send a batch of CLI commands to a server-capable contact and collect responses."""
results: dict[str, str | None] = {field: None for _, field in commands}
async with radio_manager.radio_operation(
operation_name,
pause_polling=True,
suspend_auto_fetch=True,
) as mc:
await _ensure_on_radio(mc, contact)
await asyncio.sleep(1.0)
for index, (cmd, field) in enumerate(commands):
if index > 0:
await asyncio.sleep(1.0)
send_result = await mc.commands.send_cmd(contact.public_key, cmd)
if send_result.type == EventType.ERROR:
logger.debug("Command '%s' send error: %s", cmd, send_result.payload)
continue
response_event = await fetch_contact_cli_response(
mc, contact.public_key[:12], timeout=10.0
)
if response_event is not None:
results[field] = extract_response_text(response_event)
else:
logger.warning("No response for command '%s' (%s)", cmd, field)
return results
async def send_contact_cli_command(
contact: Contact,
command: str,
*,
operation_name: str,
) -> CommandResponse:
"""Send a CLI command to a server-capable contact and return the text response."""
label = get_server_contact_label(contact)
async with radio_manager.radio_operation(
operation_name,
pause_polling=True,
suspend_auto_fetch=True,
) as mc:
logger.info("Adding %s %s to radio", label, contact.public_key[:12])
await _ensure_on_radio(mc, contact)
await asyncio.sleep(1.0)
logger.info("Sending command to %s %s: %s", label, contact.public_key[:12], command)
send_result = await mc.commands.send_cmd(contact.public_key, command)
if send_result.type == EventType.ERROR:
raise HTTPException(
status_code=500, detail=f"Failed to send command: {send_result.payload}"
)
response_event = await fetch_contact_cli_response(mc, contact.public_key[:12])
if response_event is None:
logger.warning(
"No response from %s %s for command: %s",
label,
contact.public_key[:12],
command,
)
return CommandResponse(
command=command,
response="(no response - command may have been processed)",
)
response_text = extract_response_text(response_event)
sender_timestamp = response_event.payload.get(
"sender_timestamp",
response_event.payload.get("timestamp"),
)
logger.info(
"Received response from %s %s: %s",
label,
contact.public_key[:12],
response_text,
)
return CommandResponse(
command=command,
response=response_text,
sender_timestamp=sender_timestamp,
)
+56 -5
View File
@@ -5,7 +5,7 @@ from collections.abc import Callable
from dataclasses import dataclass from dataclasses import dataclass
from typing import TYPE_CHECKING, Any from typing import TYPE_CHECKING, Any
from app.models import CONTACT_TYPE_REPEATER, Contact, ContactUpsert, Message from app.models import CONTACT_TYPE_REPEATER, CONTACT_TYPE_ROOM, Contact, ContactUpsert, Message
from app.repository import ( from app.repository import (
AmbiguousPublicKeyPrefixError, AmbiguousPublicKeyPrefixError,
ContactRepository, ContactRepository,
@@ -106,6 +106,35 @@ async def resolve_fallback_direct_message_context(
) )
async def resolve_direct_message_sender_metadata(
*,
sender_public_key: str,
received_at: int,
broadcast_fn: BroadcastFn,
contact_repository=ContactRepository,
log: logging.Logger | None = None,
) -> tuple[str | None, str | None]:
"""Resolve sender attribution for direct-message variants such as room-server posts."""
normalized_sender = sender_public_key.lower()
try:
contact = await contact_repository.get_by_key_or_prefix(normalized_sender)
except AmbiguousPublicKeyPrefixError:
(log or logger).warning(
"Sender prefix '%s' is ambiguous; preserving prefix-only attribution",
sender_public_key,
)
contact = None
if contact is not None:
await claim_prefix_messages_for_contact(
public_key=contact.public_key.lower(), log=log or logger
)
return contact.name, contact.public_key.lower()
return None, normalized_sender or None
async def _store_direct_message( async def _store_direct_message(
*, *,
packet_id: int | None, packet_id: int | None,
@@ -209,6 +238,7 @@ async def _store_direct_message(
sender_key=sender_key, sender_key=sender_key,
outgoing=outgoing, outgoing=outgoing,
sender_name=sender_name, sender_name=sender_name,
packet_id=packet_id,
) )
broadcast_message(message=message, broadcast_fn=broadcast_fn, realtime=realtime) broadcast_message(message=message, broadcast_fn=broadcast_fn, realtime=realtime)
@@ -237,8 +267,19 @@ async def ingest_decrypted_direct_message(
contact_repository=ContactRepository, contact_repository=ContactRepository,
) -> Message | None: ) -> Message | None:
conversation_key = their_public_key.lower() conversation_key = their_public_key.lower()
if not outgoing and decrypted.txt_type == 1:
logger.debug(
"Skipping CLI response from %s (txt_type=1): %s",
conversation_key[:12],
(decrypted.message or "")[:50],
)
return None
contact = await contact_repository.get_by_key(conversation_key) contact = await contact_repository.get_by_key(conversation_key)
sender_name: str | None = None sender_name: str | None = None
sender_key: str | None = conversation_key if not outgoing else None
signature: str | None = None
if contact is not None: if contact is not None:
conversation_key, skip_storage = await _prepare_resolved_contact(contact, log=logger) conversation_key, skip_storage = await _prepare_resolved_contact(contact, log=logger)
if skip_storage: if skip_storage:
@@ -249,7 +290,17 @@ async def ingest_decrypted_direct_message(
) )
return None return None
if not outgoing: if not outgoing:
sender_name = contact.name if contact.type == CONTACT_TYPE_ROOM and decrypted.signed_sender_prefix:
sender_name, sender_key = await resolve_direct_message_sender_metadata(
sender_public_key=decrypted.signed_sender_prefix,
received_at=received_at or int(time.time()),
broadcast_fn=broadcast_fn,
contact_repository=contact_repository,
log=logger,
)
signature = decrypted.signed_sender_prefix
else:
sender_name = contact.name
received = received_at or int(time.time()) received = received_at or int(time.time())
message = await _store_direct_message( message = await _store_direct_message(
@@ -261,10 +312,10 @@ async def ingest_decrypted_direct_message(
path=path, path=path,
path_len=path_len, path_len=path_len,
outgoing=outgoing, outgoing=outgoing,
txt_type=0, txt_type=decrypted.txt_type,
signature=None, signature=signature,
sender_name=sender_name, sender_name=sender_name,
sender_key=conversation_key if not outgoing else None, sender_key=sender_key,
realtime=realtime, realtime=realtime,
broadcast_fn=broadcast_fn, broadcast_fn=broadcast_fn,
update_last_contacted_key=conversation_key, update_last_contacted_key=conversation_key,
+64 -46
View File
@@ -13,7 +13,8 @@ from app.region_scope import normalize_region_scope
from app.repository import AppSettingsRepository, ContactRepository, MessageRepository from app.repository import AppSettingsRepository, ContactRepository, MessageRepository
from app.services import dm_ack_tracker from app.services import dm_ack_tracker
from app.services.messages import ( from app.services.messages import (
build_message_model, broadcast_message,
build_stored_outgoing_channel_message,
create_outgoing_channel_message, create_outgoing_channel_message,
create_outgoing_direct_message, create_outgoing_direct_message,
increment_ack_and_broadcast, increment_ack_and_broadcast,
@@ -586,6 +587,23 @@ async def send_channel_message_to_channel(
requested_timestamp=sent_at, requested_timestamp=sent_at,
) )
timestamp_bytes = sender_timestamp.to_bytes(4, "little") timestamp_bytes = sender_timestamp.to_bytes(4, "little")
outgoing_message = await create_outgoing_channel_message(
conversation_key=channel_key_upper,
text=text_with_sender,
sender_timestamp=sender_timestamp,
received_at=sent_at,
sender_name=radio_name or None,
sender_key=our_public_key,
channel_name=channel.name,
broadcast_fn=broadcast_fn,
broadcast=False,
message_repository=message_repository,
)
if outgoing_message is None:
raise HTTPException(
status_code=500,
detail="Failed to store outgoing message - unexpected duplicate",
)
result = await send_channel_message_with_effective_scope( result = await send_channel_message_with_effective_scope(
mc=mc, mc=mc,
@@ -611,23 +629,11 @@ async def send_channel_message_to_channel(
raise HTTPException( raise HTTPException(
status_code=500, detail=f"Failed to send message: {result.payload}" status_code=500, detail=f"Failed to send message: {result.payload}"
) )
except Exception:
outgoing_message = await create_outgoing_channel_message( if outgoing_message is not None:
conversation_key=channel_key_upper, await message_repository.delete_by_id(outgoing_message.id)
text=text_with_sender, outgoing_message = None
sender_timestamp=sender_timestamp, raise
received_at=sent_at,
sender_name=radio_name or None,
sender_key=our_public_key,
channel_name=channel.name,
broadcast_fn=broadcast_fn,
message_repository=message_repository,
)
if outgoing_message is None:
raise HTTPException(
status_code=500,
detail="Failed to store outgoing message - unexpected duplicate",
)
finally: finally:
if sender_timestamp is not None: if sender_timestamp is not None:
await release_outgoing_sender_timestamp( await release_outgoing_sender_timestamp(
@@ -640,22 +646,19 @@ async def send_channel_message_to_channel(
if sent_at is None or sender_timestamp is None or outgoing_message is None: if sent_at is None or sender_timestamp is None or outgoing_message is None:
raise HTTPException(status_code=500, detail="Failed to store outgoing message") raise HTTPException(status_code=500, detail="Failed to store outgoing message")
message_id = outgoing_message.id outgoing_message = await build_stored_outgoing_channel_message(
acked_count, paths = await message_repository.get_ack_and_paths(message_id) message_id=outgoing_message.id,
return build_message_model(
message_id=message_id,
msg_type="CHAN",
conversation_key=channel_key_upper, conversation_key=channel_key_upper,
text=text_with_sender, text=text_with_sender,
sender_timestamp=sender_timestamp, sender_timestamp=sender_timestamp,
received_at=sent_at, received_at=sent_at,
paths=paths,
outgoing=True,
acked=acked_count,
sender_name=radio_name or None, sender_name=radio_name or None,
sender_key=our_public_key, sender_key=our_public_key,
channel_name=channel.name, channel_name=channel.name,
message_repository=message_repository,
) )
broadcast_message(message=outgoing_message, broadcast_fn=broadcast_fn)
return outgoing_message
async def resend_channel_message_record( async def resend_channel_message_record(
@@ -705,6 +708,23 @@ async def resend_channel_message_record(
requested_timestamp=sent_at, requested_timestamp=sent_at,
) )
timestamp_bytes = sender_timestamp.to_bytes(4, "little") timestamp_bytes = sender_timestamp.to_bytes(4, "little")
new_message = await create_outgoing_channel_message(
conversation_key=message.conversation_key,
text=message.text,
sender_timestamp=sender_timestamp,
received_at=sent_at,
sender_name=radio_name or None,
sender_key=resend_public_key,
channel_name=channel.name,
broadcast_fn=broadcast_fn,
broadcast=False,
message_repository=message_repository,
)
if new_message is None:
raise HTTPException(
status_code=500,
detail="Failed to store resent message - unexpected duplicate",
)
result = await send_channel_message_with_effective_scope( result = await send_channel_message_with_effective_scope(
mc=mc, mc=mc,
@@ -729,26 +749,11 @@ async def resend_channel_message_record(
status_code=500, status_code=500,
detail=f"Failed to resend message: {result.payload}", detail=f"Failed to resend message: {result.payload}",
) )
except Exception:
if new_timestamp: if new_message is not None:
if sent_at is None: await message_repository.delete_by_id(new_message.id)
raise HTTPException(status_code=500, detail="Failed to assign resend timestamp") new_message = None
new_message = await create_outgoing_channel_message( raise
conversation_key=message.conversation_key,
text=message.text,
sender_timestamp=sender_timestamp,
received_at=sent_at,
sender_name=radio_name or None,
sender_key=resend_public_key,
channel_name=channel.name,
broadcast_fn=broadcast_fn,
message_repository=message_repository,
)
if new_message is None:
raise HTTPException(
status_code=500,
detail="Failed to store resent message - unexpected duplicate",
)
finally: finally:
if new_timestamp and sent_at is not None: if new_timestamp and sent_at is not None:
await release_outgoing_sender_timestamp( await release_outgoing_sender_timestamp(
@@ -762,6 +767,19 @@ async def resend_channel_message_record(
if sent_at is None or new_message is None: if sent_at is None or new_message is None:
raise HTTPException(status_code=500, detail="Failed to assign resend timestamp") raise HTTPException(status_code=500, detail="Failed to assign resend timestamp")
new_message = await build_stored_outgoing_channel_message(
message_id=new_message.id,
conversation_key=message.conversation_key,
text=message.text,
sender_timestamp=sender_timestamp,
received_at=sent_at,
sender_name=radio_name or None,
sender_key=resend_public_key,
channel_name=channel.name,
message_repository=message_repository,
)
broadcast_message(message=new_message, broadcast_fn=broadcast_fn)
logger.info( logger.info(
"Resent channel message %d as new message %d to %s", "Resent channel message %d as new message %d to %s",
message.id, message.id,
+45 -5
View File
@@ -62,6 +62,7 @@ def build_message_model(
acked: int = 0, acked: int = 0,
sender_name: str | None = None, sender_name: str | None = None,
channel_name: str | None = None, channel_name: str | None = None,
packet_id: int | None = None,
) -> Message: ) -> Message:
"""Build a Message model with the canonical backend payload shape.""" """Build a Message model with the canonical backend payload shape."""
return Message( return Message(
@@ -79,6 +80,7 @@ def build_message_model(
acked=acked, acked=acked,
sender_name=sender_name, sender_name=sender_name,
channel_name=channel_name, channel_name=channel_name,
packet_id=packet_id,
) )
@@ -96,11 +98,42 @@ def broadcast_message(
broadcast_fn("message", payload, realtime=realtime) broadcast_fn("message", payload, realtime=realtime)
async def build_stored_outgoing_channel_message(
*,
message_id: int,
conversation_key: str,
text: str,
sender_timestamp: int,
received_at: int,
sender_name: str | None,
sender_key: str | None,
channel_name: str | None,
message_repository=MessageRepository,
) -> Message:
"""Build the current payload for a stored outgoing channel message."""
acked_count, paths = await message_repository.get_ack_and_paths(message_id)
return build_message_model(
message_id=message_id,
msg_type="CHAN",
conversation_key=conversation_key,
text=text,
sender_timestamp=sender_timestamp,
received_at=received_at,
paths=paths,
outgoing=True,
acked=acked_count,
sender_name=sender_name,
sender_key=sender_key,
channel_name=channel_name,
)
def broadcast_message_acked( def broadcast_message_acked(
*, *,
message_id: int, message_id: int,
ack_count: int, ack_count: int,
paths: list[MessagePath] | None, paths: list[MessagePath] | None,
packet_id: int | None,
broadcast_fn: BroadcastFn, broadcast_fn: BroadcastFn,
) -> None: ) -> None:
"""Broadcast a message_acked payload.""" """Broadcast a message_acked payload."""
@@ -110,6 +143,7 @@ def broadcast_message_acked(
"message_id": message_id, "message_id": message_id,
"ack_count": ack_count, "ack_count": ack_count,
"paths": [path.model_dump() for path in paths] if paths else [], "paths": [path.model_dump() for path in paths] if paths else [],
"packet_id": packet_id,
}, },
) )
@@ -152,11 +186,16 @@ async def reconcile_duplicate_message(
else: else:
ack_count = existing_msg.acked ack_count = existing_msg.acked
representative_packet_id = (
existing_msg.packet_id if existing_msg.packet_id is not None else packet_id
)
if existing_msg.outgoing or path is not None: if existing_msg.outgoing or path is not None:
broadcast_message_acked( broadcast_message_acked(
message_id=existing_msg.id, message_id=existing_msg.id,
ack_count=ack_count, ack_count=ack_count,
paths=paths, paths=paths,
packet_id=representative_packet_id,
broadcast_fn=broadcast_fn, broadcast_fn=broadcast_fn,
) )
@@ -277,6 +316,7 @@ async def create_message_from_decrypted(
sender_name=sender, sender_name=sender,
sender_key=resolved_sender_key, sender_key=resolved_sender_key,
channel_name=channel_name, channel_name=channel_name,
packet_id=packet_id,
), ),
broadcast_fn=broadcast_fn, broadcast_fn=broadcast_fn,
realtime=realtime, realtime=realtime,
@@ -428,6 +468,7 @@ async def create_outgoing_channel_message(
sender_key: str | None, sender_key: str | None,
channel_name: str | None, channel_name: str | None,
broadcast_fn: BroadcastFn, broadcast_fn: BroadcastFn,
broadcast: bool = True,
message_repository=MessageRepository, message_repository=MessageRepository,
) -> Message | None: ) -> Message | None:
"""Store and broadcast an outgoing channel message.""" """Store and broadcast an outgoing channel message."""
@@ -444,18 +485,17 @@ async def create_outgoing_channel_message(
if msg_id is None: if msg_id is None:
return None return None
message = build_message_model( message = await build_stored_outgoing_channel_message(
message_id=msg_id, message_id=msg_id,
msg_type="CHAN",
conversation_key=conversation_key, conversation_key=conversation_key,
text=text, text=text,
sender_timestamp=sender_timestamp, sender_timestamp=sender_timestamp,
received_at=received_at, received_at=received_at,
outgoing=True,
acked=0,
sender_name=sender_name, sender_name=sender_name,
sender_key=sender_key, sender_key=sender_key,
channel_name=channel_name, channel_name=channel_name,
message_repository=message_repository,
) )
broadcast_message(message=message, broadcast_fn=broadcast_fn) if broadcast:
broadcast_message(message=message, broadcast_fn=broadcast_fn)
return message return message
+7
View File
@@ -44,6 +44,13 @@ async def apply_radio_config_update(
f"Failed to set advert location policy: {result.payload}" f"Failed to set advert location policy: {result.payload}"
) )
if update.multi_acks_enabled is not None:
multi_acks = 1 if update.multi_acks_enabled else 0
logger.info("Setting multi ACKs to %d", multi_acks)
result = await mc.commands.set_multi_acks(multi_acks)
if result is not None and result.type == EventType.ERROR:
raise RadioCommandRejectedError(f"Failed to set multi ACKs: {result.payload}")
if update.name is not None: if update.name is not None:
logger.info("Setting radio name to %s", update.name) logger.info("Setting radio name to %s", update.name)
await mc.commands.set_name(update.name) await mc.commands.set_name(update.name)
+5 -2
View File
@@ -18,15 +18,18 @@ services:
environment: environment:
MESHCORE_DATABASE_PATH: data/meshcore.db MESHCORE_DATABASE_PATH: data/meshcore.db
# Radio connection -- optional if you map just a single serial device above, as the app will autodetect # Radio connection -- optional if you map just a single serial device above, as the app will autodetect
# Serial (USB) # Serial (USB)
# MESHCORE_SERIAL_PORT: /dev/ttyUSB0 # MESHCORE_SERIAL_PORT: /dev/ttyUSB0
# MESHCORE_SERIAL_BAUDRATE: 115200 # MESHCORE_SERIAL_BAUDRATE: 115200
# TCP # TCP
# MESHCORE_TCP_HOST: 192.168.1.100 # MESHCORE_TCP_HOST: 192.168.1.100
# MESHCORE_TCP_PORT: 4000 # MESHCORE_TCP_PORT: 4000
# Security
# MESHCORE_DISABLE_BOTS: "true"
# MESHCORE_BASIC_AUTH_USERNAME: changeme
# MESHCORE_BASIC_AUTH_PASSWORD: changeme
# Logging # Logging
# MESHCORE_LOG_LEVEL: INFO # MESHCORE_LOG_LEVEL: INFO
restart: unless-stopped restart: unless-stopped
+8 -4
View File
@@ -198,9 +198,9 @@ High-level state is delegated to hooks:
- `useContactsAndChannels`: contact/channel lists, creation, deletion - `useContactsAndChannels`: contact/channel lists, creation, deletion
- `useConversationRouter`: URL hash → active conversation routing - `useConversationRouter`: URL hash → active conversation routing
- `useConversationNavigation`: search target, conversation selection reset, and info-pane state - `useConversationNavigation`: search target, conversation selection reset, and info-pane state
- `useConversationActions`: send/resend/trace/block handlers and channel override updates - `useConversationActions`: send/resend/trace/path-discovery/block handlers and channel override updates
- `useConversationMessages`: conversation switch loading, embedded conversation-scoped cache, jump-target loading, pagination, dedup/update helpers, reconnect reconciliation, and pending ACK buffering - `useConversationMessages`: conversation switch loading, embedded conversation-scoped cache, jump-target loading, pagination, dedup/update helpers, reconnect reconciliation, and pending ACK buffering
- `useUnreadCounts`: unread counters, mention tracking, recent-sort timestamps - `useUnreadCounts`: unread counters, mention tracking, recent-sort timestamps, and server `last_read_ats` boundaries
- `useRealtimeAppState`: typed WS event application, reconnect recovery, cache/unread coordination - `useRealtimeAppState`: typed WS event application, reconnect recovery, cache/unread coordination
- `useRepeaterDashboard`: repeater dashboard state (login, pane data/retries, console, actions) - `useRepeaterDashboard`: repeater dashboard state (login, pane data/retries, console, actions)
@@ -245,10 +245,12 @@ High-level state is delegated to hooks:
- `id`: backend storage row identity (payload-level dedup) - `id`: backend storage row identity (payload-level dedup)
- `observation_id`: realtime per-arrival identity (session fidelity) - `observation_id`: realtime per-arrival identity (session fidelity)
- Packet feed/visualizer render keys and dedup logic should use `observation_id` (fallback to `id` only for older payloads). - Packet feed/visualizer render keys and dedup logic should use `observation_id` (fallback to `id` only for older payloads).
- The dedicated raw packet feed view now includes a frontend-only stats drawer. It tracks a separate lightweight per-observation session history for charts/rankings, so its windows are not limited by the visible packet list cap. Coverage messaging should stay honest when detailed in-memory stats history has been trimmed or the selected window predates the current browser session.
### Radio settings behavior ### Radio settings behavior
- `SettingsRadioSection.tsx` surfaces `path_hash_mode` only when `config.path_hash_mode_supported` is true. - `SettingsRadioSection.tsx` surfaces `path_hash_mode` only when `config.path_hash_mode_supported` is true.
- `SettingsRadioSection.tsx` also exposes `multi_acks_enabled` as a checkbox for the radio's extra direct-ACK transmission behavior.
- Advert-location control is intentionally only `off` vs `include node location`. Companion-radio firmware does not reliably distinguish saved coordinates from live GPS in this path. - Advert-location control is intentionally only `off` vs `include node location`. Companion-radio firmware does not reliably distinguish saved coordinates from live GPS in this path.
- The advert action is mode-aware: the radio settings section exposes both flood and zero-hop manual advert buttons, both routed through the same `onAdvertise(mode)` seam. - The advert action is mode-aware: the radio settings section exposes both flood and zero-hop manual advert buttons, both routed through the same `onAdvertise(mode)` seam.
- Mesh discovery in the radio section is limited to node classes that currently answer discovery control-data requests in firmware: repeaters and sensors. - Mesh discovery in the radio section is limited to node classes that currently answer discovery control-data requests in firmware: repeaters and sensors.
@@ -329,6 +331,8 @@ Note: MQTT, bot, and community MQTT settings were migrated to the `fanout_config
`RawPacket.decrypted_info` includes `channel_key` and `contact_key` for MQTT topic routing. `RawPacket.decrypted_info` includes `channel_key` and `contact_key` for MQTT topic routing.
`UnreadCounts` includes `counts`, `mentions`, `last_message_times`, and `last_read_ats`. The unread-boundary/jump-to-unread behavior uses the server-provided `last_read_ats` map keyed by `getStateKey(...)`.
## Contact Info Pane ## Contact Info Pane
Clicking a contact's avatar in `ChatHeader` or `MessageList` opens a `ContactInfoPane` sheet (right drawer) showing comprehensive contact details fetched from `GET /api/contacts/analytics` using either `?public_key=...` or `?name=...`: Clicking a contact's avatar in `ChatHeader` or `MessageList` opens a `ContactInfoPane` sheet (right drawer) showing comprehensive contact details fetched from `GET /api/contacts/analytics` using either `?public_key=...` or `?name=...`:
@@ -423,9 +427,9 @@ PYTHONPATH=. uv run pytest tests/ -v
## Errata & Known Non-Issues ## Errata & Known Non-Issues
### Contacts rollup uses mention styling for unread DMs ### Contacts use mention styling for unread DMs
This is intentional. In the sidebar section headers, unread direct messages are treated as mention-equivalent, so the Contacts rollup uses the highlighted mention-style badge for any unread DM. Row-level mention detection remains separate; this note is only about the section summary styling. This is intentional. In the sidebar, unread direct messages for actual contact conversations are treated as mention-equivalent for badge styling. That means both the Contacts section header and contact unread badges themselves use the highlighted mention-style colors for unread DMs, including when those contacts appear in Favorites. Repeaters do not inherit this rule, and channel badges still use mention styling only for real `@[name]` mentions.
### RawPacketList always scrolls to bottom ### RawPacketList always scrolls to bottom
+1 -1
View File
@@ -9,8 +9,8 @@
<meta name="theme-color" content="#111419" /> <meta name="theme-color" content="#111419" />
<meta name="description" content="Web interface for MeshCore mesh radio networks. Send and receive messages, manage contacts and channels, and configure your radio." /> <meta name="description" content="Web interface for MeshCore mesh radio networks. Send and receive messages, manage contacts and channels, and configure your radio." />
<title>RemoteTerm for MeshCore</title> <title>RemoteTerm for MeshCore</title>
<link rel="icon" type="image/png" href="/favicon-96x96.png" sizes="96x96" />
<link rel="icon" type="image/svg+xml" href="/favicon.svg" /> <link rel="icon" type="image/svg+xml" href="/favicon.svg" />
<link rel="icon" type="image/png" href="/favicon-96x96.png" sizes="96x96" />
<link rel="shortcut icon" href="/favicon.ico" /> <link rel="shortcut icon" href="/favicon.ico" />
<link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png" /> <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png" />
<link rel="manifest" href="/site.webmanifest" /> <link rel="manifest" href="/site.webmanifest" />
+12 -2
View File
@@ -1,12 +1,12 @@
{ {
"name": "remoteterm-meshcore-frontend", "name": "remoteterm-meshcore-frontend",
"version": "2.7.9", "version": "3.6.1",
"lockfileVersion": 3, "lockfileVersion": 3,
"requires": true, "requires": true,
"packages": { "packages": {
"": { "": {
"name": "remoteterm-meshcore-frontend", "name": "remoteterm-meshcore-frontend",
"version": "2.7.9", "version": "3.6.1",
"dependencies": { "dependencies": {
"@codemirror/lang-python": "^6.2.1", "@codemirror/lang-python": "^6.2.1",
"@codemirror/theme-one-dark": "^6.1.3", "@codemirror/theme-one-dark": "^6.1.3",
@@ -29,6 +29,7 @@
"react": "^18.3.1", "react": "^18.3.1",
"react-dom": "^18.3.1", "react-dom": "^18.3.1",
"react-leaflet": "^4.2.1", "react-leaflet": "^4.2.1",
"react-swipeable": "^7.0.2",
"sonner": "^2.0.7", "sonner": "^2.0.7",
"tailwind-merge": "^3.4.0", "tailwind-merge": "^3.4.0",
"tailwindcss-animate": "^1.0.7", "tailwindcss-animate": "^1.0.7",
@@ -5695,6 +5696,15 @@
} }
} }
}, },
"node_modules/react-swipeable": {
"version": "7.0.2",
"resolved": "https://registry.npmjs.org/react-swipeable/-/react-swipeable-7.0.2.tgz",
"integrity": "sha512-v1Qx1l+aC2fdxKa9aKJiaU/ZxmJ5o98RMoFwUqAAzVWUcxgfHFXDDruCKXhw6zIYXm6V64JiHgP9f6mlME5l8w==",
"license": "MIT",
"peerDependencies": {
"react": "^16.8.3 || ^17 || ^18 || ^19.0.0 || ^19.0.0-rc"
}
},
"node_modules/read-cache": { "node_modules/read-cache": {
"version": "1.0.0", "version": "1.0.0",
"resolved": "https://registry.npmjs.org/read-cache/-/read-cache-1.0.0.tgz", "resolved": "https://registry.npmjs.org/read-cache/-/read-cache-1.0.0.tgz",
+2 -1
View File
@@ -1,7 +1,7 @@
{ {
"name": "remoteterm-meshcore-frontend", "name": "remoteterm-meshcore-frontend",
"private": true, "private": true,
"version": "3.4.1", "version": "3.6.2",
"type": "module", "type": "module",
"scripts": { "scripts": {
"dev": "vite", "dev": "vite",
@@ -37,6 +37,7 @@
"react": "^18.3.1", "react": "^18.3.1",
"react-dom": "^18.3.1", "react-dom": "^18.3.1",
"react-leaflet": "^4.2.1", "react-leaflet": "^4.2.1",
"react-swipeable": "^7.0.2",
"sonner": "^2.0.7", "sonner": "^2.0.7",
"tailwind-merge": "^3.4.0", "tailwind-merge": "^3.4.0",
"tailwindcss-animate": "^1.0.7", "tailwindcss-animate": "^1.0.7",
+55 -28
View File
@@ -1,4 +1,4 @@
import { useEffect, useCallback, useRef, useState } from 'react'; import { useEffect, useCallback, useRef, useState, useMemo } from 'react';
import { api } from './api'; import { api } from './api';
import { takePrefetchOrFetch } from './prefetch'; import { takePrefetchOrFetch } from './prefetch';
import { useWebSocket } from './useWebSocket'; import { useWebSocket } from './useWebSocket';
@@ -14,12 +14,17 @@ import {
useConversationNavigation, useConversationNavigation,
useRealtimeAppState, useRealtimeAppState,
useBrowserNotifications, useBrowserNotifications,
useFaviconBadge,
useUnreadTitle,
useRawPacketStatsSession,
} from './hooks'; } from './hooks';
import { AppShell } from './components/AppShell'; import { AppShell } from './components/AppShell';
import type { MessageInputHandle } from './components/MessageInput'; import type { MessageInputHandle } from './components/MessageInput';
import { DistanceUnitProvider } from './contexts/DistanceUnitContext';
import { messageContainsMention } from './utils/messageParser'; import { messageContainsMention } from './utils/messageParser';
import { getStateKey } from './utils/conversationState'; import { getStateKey } from './utils/conversationState';
import type { Conversation, Message, RawPacket } from './types'; import type { Conversation, Message, RawPacket } from './types';
import { CONTACT_TYPE_ROOM } from './types';
interface ChannelUnreadMarker { interface ChannelUnreadMarker {
channelId: string; channelId: string;
@@ -81,6 +86,7 @@ export function App() {
toggleConversationNotifications, toggleConversationNotifications,
notifyIncomingMessage, notifyIncomingMessage,
} = useBrowserNotifications(); } = useBrowserNotifications();
const { rawPacketStatsSession, recordRawPacketObservation } = useRawPacketStatsSession();
const { const {
showNewMessage, showNewMessage,
showSettings, showSettings,
@@ -89,10 +95,12 @@ export function App() {
showCracker, showCracker,
crackerRunning, crackerRunning,
localLabel, localLabel,
distanceUnit,
setSettingsSection, setSettingsSection,
setSidebarOpen, setSidebarOpen,
setCrackerRunning, setCrackerRunning,
setLocalLabel, setLocalLabel,
setDistanceUnit,
handleCloseSettingsView, handleCloseSettingsView,
handleToggleSettingsView, handleToggleSettingsView,
handleOpenNewMessage, handleOpenNewMessage,
@@ -244,6 +252,21 @@ export function App() {
} = useConversationMessages(activeConversation, targetMessageId); } = useConversationMessages(activeConversation, targetMessageId);
removeConversationMessagesRef.current = removeConversationMessages; removeConversationMessagesRef.current = removeConversationMessages;
// Room servers replay stored history as a burst of DMs, all arriving with similar received_at
// but spanning a wide range of sender_timestamps. Sort by sender_timestamp for room contacts
// so the display reflects the original send order rather than our radio's receipt order.
const activeContactIsRoom =
activeConversation?.type === 'contact' &&
contacts.find((c) => c.public_key === activeConversation.id)?.type === CONTACT_TYPE_ROOM;
const sortedMessages = useMemo(() => {
if (!activeContactIsRoom || messages.length === 0) return messages;
return [...messages].sort((a, b) => {
const aTs = a.sender_timestamp ?? a.received_at;
const bTs = b.sender_timestamp ?? b.received_at;
return aTs !== bTs ? aTs - bTs : a.id - b.id;
});
}, [activeContactIsRoom, messages]);
const { const {
unreadCounts, unreadCounts,
mentions, mentions,
@@ -254,6 +277,8 @@ export function App() {
markAllRead, markAllRead,
refreshUnreads, refreshUnreads,
} = useUnreadCounts(channels, contacts, activeConversation); } = useUnreadCounts(channels, contacts, activeConversation);
useFaviconBadge(unreadCounts, mentions, favorites);
useUnreadTitle(unreadCounts, favorites);
useEffect(() => { useEffect(() => {
if (activeConversation?.type !== 'channel') { if (activeConversation?.type !== 'channel') {
@@ -331,6 +356,7 @@ export function App() {
removeConversationMessages, removeConversationMessages,
receiveMessageAck, receiveMessageAck,
notifyIncomingMessage, notifyIncomingMessage,
recordRawPacketObservation,
}); });
const handleVisibilityPolicyChanged = useCallback(() => { const handleVisibilityPolicyChanged = useCallback(() => {
clearConversationMessages(); clearConversationMessages();
@@ -413,10 +439,11 @@ export function App() {
contacts, contacts,
channels, channels,
rawPackets, rawPackets,
rawPacketStatsSession,
config, config,
health, health,
favorites, favorites,
messages, messages: sortedMessages,
messagesLoading, messagesLoading,
loadingOlder, loadingOlder,
hasOlderMessages, hasOlderMessages,
@@ -495,9 +522,7 @@ export function App() {
onChannelCreate: handleCreateCrackedChannel, onChannelCreate: handleCreateCrackedChannel,
}; };
const newMessageModalProps = { const newMessageModalProps = {
contacts,
undecryptedCount, undecryptedCount,
onSelectConversation: handleSelectConversationWithTargetReset,
onCreateContact: handleCreateContact, onCreateContact: handleCreateContact,
onCreateChannel: handleCreateChannel, onCreateChannel: handleCreateChannel,
onCreateHashtagChannel: handleCreateHashtagChannel, onCreateHashtagChannel: handleCreateHashtagChannel,
@@ -560,29 +585,31 @@ export function App() {
setContactsLoaded, setContactsLoaded,
]); ]);
return ( return (
<AppShell <DistanceUnitProvider distanceUnit={distanceUnit} setDistanceUnit={setDistanceUnit}>
localLabel={localLabel} <AppShell
showNewMessage={showNewMessage} localLabel={localLabel}
showSettings={showSettings} showNewMessage={showNewMessage}
settingsSection={settingsSection} showSettings={showSettings}
sidebarOpen={sidebarOpen} settingsSection={settingsSection}
showCracker={showCracker} sidebarOpen={sidebarOpen}
onSettingsSectionChange={setSettingsSection} showCracker={showCracker}
onSidebarOpenChange={setSidebarOpen} onSettingsSectionChange={setSettingsSection}
onCrackerRunningChange={setCrackerRunning} onSidebarOpenChange={setSidebarOpen}
onToggleSettingsView={handleToggleSettingsView} onCrackerRunningChange={setCrackerRunning}
onCloseSettingsView={handleCloseSettingsView} onToggleSettingsView={handleToggleSettingsView}
onCloseNewMessage={handleCloseNewMessage} onCloseSettingsView={handleCloseSettingsView}
onLocalLabelChange={setLocalLabel} onCloseNewMessage={handleCloseNewMessage}
statusProps={statusProps} onLocalLabelChange={setLocalLabel}
sidebarProps={sidebarProps} statusProps={statusProps}
conversationPaneProps={conversationPaneProps} sidebarProps={sidebarProps}
searchProps={searchProps} conversationPaneProps={conversationPaneProps}
settingsProps={settingsProps} searchProps={searchProps}
crackerProps={crackerProps} settingsProps={settingsProps}
newMessageModalProps={newMessageModalProps} crackerProps={crackerProps}
contactInfoPaneProps={contactInfoPaneProps} newMessageModalProps={newMessageModalProps}
channelInfoPaneProps={channelInfoPaneProps} contactInfoPaneProps={contactInfoPaneProps}
/> channelInfoPaneProps={channelInfoPaneProps}
/>
</DistanceUnitProvider>
); );
} }
+27
View File
@@ -15,6 +15,7 @@ import type {
MessagesAroundResponse, MessagesAroundResponse,
MigratePreferencesRequest, MigratePreferencesRequest,
MigratePreferencesResponse, MigratePreferencesResponse,
RawPacket,
RadioAdvertMode, RadioAdvertMode,
RadioConfig, RadioConfig,
RadioConfigUpdate, RadioConfigUpdate,
@@ -247,6 +248,7 @@ export const api = {
), ),
// Packets // Packets
getPacket: (packetId: number) => fetchJson<RawPacket>(`/packets/${packetId}`),
getUndecryptedPacketCount: () => fetchJson<{ count: number }>('/packets/undecrypted/count'), getUndecryptedPacketCount: () => fetchJson<{ count: number }>('/packets/undecrypted/count'),
decryptHistoricalPackets: (params: { decryptHistoricalPackets: (params: {
key_type: 'channel' | 'contact'; key_type: 'channel' | 'contact';
@@ -341,6 +343,14 @@ export const api = {
fetchJson<{ deleted: boolean }>(`/fanout/${id}`, { fetchJson<{ deleted: boolean }>(`/fanout/${id}`, {
method: 'DELETE', method: 'DELETE',
}), }),
disableBotsUntilRestart: () =>
fetchJson<{
status: string;
bots_disabled: boolean;
bots_disabled_source: 'env' | 'until_restart';
}>('/fanout/bots/disable-until-restart', {
method: 'POST',
}),
// Statistics // Statistics
getStatistics: () => fetchJson<StatisticsResponse>('/statistics'), getStatistics: () => fetchJson<StatisticsResponse>('/statistics'),
@@ -383,4 +393,21 @@ export const api = {
fetchJson<RepeaterLppTelemetryResponse>(`/contacts/${publicKey}/repeater/lpp-telemetry`, { fetchJson<RepeaterLppTelemetryResponse>(`/contacts/${publicKey}/repeater/lpp-telemetry`, {
method: 'POST', method: 'POST',
}), }),
roomLogin: (publicKey: string, password: string) =>
fetchJson<RepeaterLoginResponse>(`/contacts/${publicKey}/room/login`, {
method: 'POST',
body: JSON.stringify({ password }),
}),
roomStatus: (publicKey: string) =>
fetchJson<RepeaterStatusResponse>(`/contacts/${publicKey}/room/status`, {
method: 'POST',
}),
roomAcl: (publicKey: string) =>
fetchJson<RepeaterAclResponse>(`/contacts/${publicKey}/room/acl`, {
method: 'POST',
}),
roomLppTelemetry: (publicKey: string) =>
fetchJson<RepeaterLppTelemetryResponse>(`/contacts/${publicKey}/room/lpp-telemetry`, {
method: 'POST',
}),
}; };
+25 -6
View File
@@ -1,4 +1,5 @@
import { lazy, Suspense, useRef, type ComponentProps } from 'react'; import { lazy, Suspense, useRef, type ComponentProps } from 'react';
import { useSwipeable } from 'react-swipeable';
import { StatusBar } from './StatusBar'; import { StatusBar } from './StatusBar';
import { Sidebar } from './Sidebar'; import { Sidebar } from './Sidebar';
@@ -6,6 +7,7 @@ import { ConversationPane } from './ConversationPane';
import { NewMessageModal } from './NewMessageModal'; import { NewMessageModal } from './NewMessageModal';
import { ContactInfoPane } from './ContactInfoPane'; import { ContactInfoPane } from './ContactInfoPane';
import { ChannelInfoPane } from './ChannelInfoPane'; import { ChannelInfoPane } from './ChannelInfoPane';
import { SecurityWarningModal } from './SecurityWarningModal';
import { Toaster } from './ui/sonner'; import { Toaster } from './ui/sonner';
import { Sheet, SheetContent, SheetDescription, SheetHeader, SheetTitle } from './ui/sheet'; import { Sheet, SheetContent, SheetDescription, SheetHeader, SheetTitle } from './ui/sheet';
import { import {
@@ -88,6 +90,24 @@ export function AppShell({
contactInfoPaneProps, contactInfoPaneProps,
channelInfoPaneProps, channelInfoPaneProps,
}: AppShellProps) { }: AppShellProps) {
const swipeHandlers = useSwipeable({
onSwipedRight: ({ initial }) => {
if (initial[0] < 30 && !sidebarOpen && window.innerWidth < 768) {
onSidebarOpenChange(true);
}
},
trackTouch: true,
trackMouse: false,
preventScrollOnSwipe: true,
});
const closeSwipeHandlers = useSwipeable({
onSwipedLeft: () => onSidebarOpenChange(false),
trackTouch: true,
trackMouse: false,
preventScrollOnSwipe: false,
});
const searchMounted = useRef(false); const searchMounted = useRef(false);
if (conversationPaneProps.activeConversation?.type === 'search') { if (conversationPaneProps.activeConversation?.type === 'search') {
searchMounted.current = true; searchMounted.current = true;
@@ -152,7 +172,7 @@ export function AppShell({
); );
return ( return (
<div className="flex flex-col h-full"> <div className="flex flex-col h-full" {...swipeHandlers}>
<a <a
href="#main-content" href="#main-content"
className="sr-only focus:not-sr-only focus:absolute focus:z-50 focus:p-2 focus:bg-primary focus:text-primary-foreground" className="sr-only focus:not-sr-only focus:absolute focus:z-50 focus:p-2 focus:bg-primary focus:text-primary-foreground"
@@ -195,7 +215,9 @@ export function AppShell({
<SheetTitle>Navigation</SheetTitle> <SheetTitle>Navigation</SheetTitle>
<SheetDescription>Sidebar navigation</SheetDescription> <SheetDescription>Sidebar navigation</SheetDescription>
</SheetHeader> </SheetHeader>
<div className="flex-1 overflow-hidden">{activeSidebarContent}</div> <div className="flex-1 overflow-hidden" {...closeSwipeHandlers}>
{activeSidebarContent}
</div>
</SheetContent> </SheetContent>
</Sheet> </Sheet>
@@ -283,12 +305,9 @@ export function AppShell({
{...newMessageModalProps} {...newMessageModalProps}
open={showNewMessage} open={showNewMessage}
onClose={onCloseNewMessage} onClose={onCloseNewMessage}
onSelectConversation={(conv) => {
newMessageModalProps.onSelectConversation(conv);
onCloseNewMessage();
}}
/> />
<SecurityWarningModal health={statusProps.health} />
<ContactInfoPane {...contactInfoPaneProps} /> <ContactInfoPane {...contactInfoPaneProps} />
<ChannelInfoPane {...channelInfoPaneProps} /> <ChannelInfoPane {...channelInfoPaneProps} />
<Toaster position="top-right" /> <Toaster position="top-right" />
@@ -45,8 +45,8 @@ export function ChannelFloodScopeOverrideModal({
<DialogHeader> <DialogHeader>
<DialogTitle>Regional Override</DialogTitle> <DialogTitle>Regional Override</DialogTitle>
<DialogDescription> <DialogDescription>
Room-level regional routing temporarily changes the radio flood scope before send and Channel-level regional routing temporarily changes the radio flood scope before send and
restores it after. This can noticeably slow room sends. restores it after. This can noticeably slow channel sends.
</DialogDescription> </DialogDescription>
</DialogHeader> </DialogHeader>
+97 -81
View File
@@ -9,6 +9,7 @@ import { handleKeyboardActivate } from '../utils/a11y';
import { isPublicChannelKey } from '../utils/publicChannel'; import { isPublicChannelKey } from '../utils/publicChannel';
import { stripRegionScopePrefix } from '../utils/regionScope'; import { stripRegionScopePrefix } from '../utils/regionScope';
import { isPrefixOnlyContact } from '../utils/pubkey'; import { isPrefixOnlyContact } from '../utils/pubkey';
import { cn } from '../lib/utils';
import { ContactAvatar } from './ContactAvatar'; import { ContactAvatar } from './ContactAvatar';
import { ContactStatusInfo } from './ContactStatusInfo'; import { ContactStatusInfo } from './ContactStatusInfo';
import type { import type {
@@ -19,6 +20,7 @@ import type {
PathDiscoveryResponse, PathDiscoveryResponse,
RadioConfig, RadioConfig,
} from '../types'; } from '../types';
import { CONTACT_TYPE_ROOM } from '../types';
interface ChatHeaderProps { interface ChatHeaderProps {
conversation: Conversation; conversation: Conversation;
@@ -84,6 +86,7 @@ export function ChatHeader({
conversation.type === 'contact' conversation.type === 'contact'
? contacts.find((contact) => contact.public_key === conversation.id) ? contacts.find((contact) => contact.public_key === conversation.id)
: null; : null;
const activeContactIsRoomServer = activeContact?.type === CONTACT_TYPE_ROOM;
const activeContactIsPrefixOnly = activeContact const activeContactIsPrefixOnly = activeContact
? isPrefixOnlyContact(activeContact.public_key) ? isPrefixOnlyContact(activeContact.public_key)
: false; : false;
@@ -116,8 +119,15 @@ export function ChatHeader({
}; };
return ( return (
<header className="conversation-header flex justify-between items-start px-4 py-2.5 border-b border-border gap-2"> <header
<span className="flex min-w-0 flex-1 items-start gap-2"> className={cn(
'conversation-header grid items-start gap-x-2 gap-y-0.5 border-b border-border px-4 py-2.5',
conversation.type === 'contact' && activeContact
? 'grid-cols-[minmax(0,1fr)_auto] min-[1100px]:grid-cols-[minmax(0,1fr)_auto_auto]'
: 'grid-cols-[minmax(0,1fr)_auto]'
)}
>
<span className="flex min-w-0 items-start gap-2">
{conversation.type === 'contact' && onOpenContactInfo && ( {conversation.type === 'contact' && onOpenContactInfo && (
<button <button
type="button" type="button"
@@ -135,16 +145,31 @@ export function ChatHeader({
/> />
</button> </button>
)} )}
<span className="grid min-w-0 flex-1 grid-cols-1 gap-y-0.5 min-[1200px]:grid-cols-[minmax(0,1fr)_auto] min-[1200px]:items-baseline min-[1200px]:gap-x-2"> <span className="flex min-w-0 flex-1 flex-col">
<span className="flex min-w-0 items-baseline gap-2 whitespace-nowrap"> <span className="flex min-w-0 flex-wrap items-baseline gap-x-2 gap-y-0.5">
<h2 className="min-w-0 shrink font-semibold text-base"> <span className="flex min-w-0 flex-1 items-baseline gap-2 whitespace-nowrap">
{titleClickable ? ( <h2 className="min-w-0 flex-shrink font-semibold text-base">
<button {titleClickable ? (
type="button" <button
className="flex min-w-0 shrink items-center gap-1.5 text-left hover:text-primary transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring rounded-sm" type="button"
aria-label={`View info for ${conversation.name}`} className="flex max-w-full min-w-0 items-center gap-1.5 overflow-hidden rounded-sm text-left transition-colors hover:text-primary focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring"
onClick={handleOpenConversationInfo} aria-label={`View info for ${conversation.name}`}
> onClick={handleOpenConversationInfo}
>
<span className="truncate">
{conversation.type === 'channel' &&
!conversation.name.startsWith('#') &&
activeChannel?.is_hashtag
? '#'
: ''}
{conversation.name}
</span>
<Info
className="h-3.5 w-3.5 flex-shrink-0 text-muted-foreground/80"
aria-hidden="true"
/>
</button>
) : (
<span className="truncate"> <span className="truncate">
{conversation.type === 'channel' && {conversation.type === 'channel' &&
!conversation.name.startsWith('#') && !conversation.name.startsWith('#') &&
@@ -153,84 +178,75 @@ export function ChatHeader({
: ''} : ''}
{conversation.name} {conversation.name}
</span> </span>
<Info )}
className="h-3.5 w-3.5 flex-shrink-0 text-muted-foreground/80" </h2>
aria-hidden="true" {isPrivateChannel && !showKey ? (
/> <button
className="min-w-0 flex-shrink text-[11px] font-mono text-muted-foreground transition-colors hover:text-primary"
onClick={(e) => {
e.stopPropagation();
setShowKey(true);
}}
title="Reveal channel key"
>
Show Key
</button> </button>
) : ( ) : (
<span className="truncate"> <span
{conversation.type === 'channel' && className="min-w-0 flex-1 truncate font-mono text-[11px] text-muted-foreground transition-colors hover:text-primary"
!conversation.name.startsWith('#') && role="button"
activeChannel?.is_hashtag tabIndex={0}
? '#' onKeyDown={handleKeyboardActivate}
: ''} onClick={(e) => {
{conversation.name} e.stopPropagation();
navigator.clipboard.writeText(conversation.id);
toast.success(
conversation.type === 'channel'
? 'Channel key copied!'
: 'Contact key copied!'
);
}}
title="Click to copy"
aria-label={
conversation.type === 'channel' ? 'Copy channel key' : 'Copy contact key'
}
>
{conversation.type === 'channel'
? conversation.id.toLowerCase()
: conversation.id}
</span> </span>
)} )}
</h2> </span>
{isPrivateChannel && !showKey ? ( {conversation.type === 'channel' && activeFloodScopeDisplay && (
<button <button
className="min-w-0 flex-shrink text-[11px] font-mono text-muted-foreground transition-colors hover:text-primary" className="mt-0.5 flex basis-full items-center gap-1 text-left sm:hidden"
onClick={(e) => { onClick={handleEditFloodScopeOverride}
e.stopPropagation(); title="Set regional override"
setShowKey(true); aria-label="Set regional override"
}}
title="Reveal channel key"
> >
Show Key <Globe2
className="h-3.5 w-3.5 flex-shrink-0 text-[hsl(var(--region-override))]"
aria-hidden="true"
/>
<span className="min-w-0 truncate text-[11px] font-medium text-[hsl(var(--region-override))]">
{activeFloodScopeDisplay}
</span>
</button> </button>
) : (
<span
className="min-w-0 flex-1 truncate font-mono text-[11px] text-muted-foreground transition-colors hover:text-primary"
role="button"
tabIndex={0}
onKeyDown={handleKeyboardActivate}
onClick={(e) => {
e.stopPropagation();
navigator.clipboard.writeText(conversation.id);
toast.success(
conversation.type === 'channel' ? 'Room key copied!' : 'Contact key copied!'
);
}}
title="Click to copy"
aria-label={
conversation.type === 'channel' ? 'Copy channel key' : 'Copy contact key'
}
>
{conversation.type === 'channel' ? conversation.id.toLowerCase() : conversation.id}
</span>
)} )}
</span> </span>
{conversation.type === 'contact' && activeContact && (
<span className="min-w-0 text-[11px] text-muted-foreground min-[1200px]:justify-self-end">
<ContactStatusInfo
contact={activeContact}
ourLat={config?.lat ?? null}
ourLon={config?.lon ?? null}
/>
</span>
)}
{conversation.type === 'channel' && activeFloodScopeDisplay && (
<button
className="mt-0.5 flex items-center gap-1 text-left sm:hidden"
onClick={handleEditFloodScopeOverride}
title="Set regional override"
aria-label="Set regional override"
>
<Globe2
className="h-3.5 w-3.5 flex-shrink-0 text-[hsl(var(--region-override))]"
aria-hidden="true"
/>
<span className="min-w-0 truncate text-[11px] font-medium text-[hsl(var(--region-override))]">
{activeFloodScopeDisplay}
</span>
</button>
)}
</span> </span>
</span> </span>
<div className="flex items-center justify-end gap-0.5 flex-shrink-0"> {conversation.type === 'contact' && activeContact && (
{conversation.type === 'contact' && ( <div className="col-span-2 row-start-2 min-w-0 text-[11px] text-muted-foreground min-[1100px]:col-span-1 min-[1100px]:col-start-2 min-[1100px]:row-start-1">
<ContactStatusInfo
contact={activeContact}
ourLat={config?.lat ?? null}
ourLon={config?.lon ?? null}
/>
</div>
)}
<div className="flex items-center justify-end gap-0.5">
{conversation.type === 'contact' && !activeContactIsRoomServer && (
<button <button
className="p-1 rounded hover:bg-accent text-lg leading-none transition-colors disabled:cursor-not-allowed disabled:opacity-50 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring" className="p-1 rounded hover:bg-accent text-lg leading-none transition-colors disabled:cursor-not-allowed disabled:opacity-50 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring"
onClick={() => setPathDiscoveryOpen(true)} onClick={() => setPathDiscoveryOpen(true)}
@@ -245,7 +261,7 @@ export function ChatHeader({
<Route className="h-4 w-4 text-muted-foreground" aria-hidden="true" /> <Route className="h-4 w-4 text-muted-foreground" aria-hidden="true" />
</button> </button>
)} )}
{conversation.type === 'contact' && ( {conversation.type === 'contact' && !activeContactIsRoomServer && (
<button <button
className="p-1 rounded hover:bg-accent text-lg leading-none transition-colors disabled:cursor-not-allowed disabled:opacity-50 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring" className="p-1 rounded hover:bg-accent text-lg leading-none transition-colors disabled:cursor-not-allowed disabled:opacity-50 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring"
onClick={onTrace} onClick={onTrace}
@@ -260,7 +276,7 @@ export function ChatHeader({
<DirectTraceIcon className="h-4 w-4 text-muted-foreground" /> <DirectTraceIcon className="h-4 w-4 text-muted-foreground" />
</button> </button>
)} )}
{notificationsSupported && ( {notificationsSupported && !activeContactIsRoomServer && (
<button <button
className="flex items-center gap-1 rounded px-1 py-1 hover:bg-accent text-lg leading-none transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring" className="flex items-center gap-1 rounded px-1 py-1 hover:bg-accent text-lg leading-none transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring"
onClick={onToggleNotifications} onClick={onToggleNotifications}
+20 -18
View File
@@ -24,6 +24,7 @@ import { handleKeyboardActivate } from '../utils/a11y';
import { ContactAvatar } from './ContactAvatar'; import { ContactAvatar } from './ContactAvatar';
import { Sheet, SheetContent, SheetDescription, SheetHeader, SheetTitle } from './ui/sheet'; import { Sheet, SheetContent, SheetDescription, SheetHeader, SheetTitle } from './ui/sheet';
import { toast } from './ui/sonner'; import { toast } from './ui/sonner';
import { useDistanceUnit } from '../contexts/DistanceUnitContext';
import type { import type {
Contact, Contact,
ContactActiveRoom, ContactActiveRoom,
@@ -82,6 +83,7 @@ export function ContactInfoPane({
onToggleBlockedKey, onToggleBlockedKey,
onToggleBlockedName, onToggleBlockedName,
}: ContactInfoPaneProps) { }: ContactInfoPaneProps) {
const { distanceUnit } = useDistanceUnit();
const isNameOnly = contactKey?.startsWith('name:') ?? false; const isNameOnly = contactKey?.startsWith('name:') ?? false;
const nameOnlyValue = isNameOnly && contactKey ? contactKey.slice(5) : null; const nameOnlyValue = isNameOnly && contactKey ? contactKey.slice(5) : null;
@@ -240,8 +242,8 @@ export function ContactInfoPane({
<ActivityChartsSection analytics={analytics} /> <ActivityChartsSection analytics={analytics} />
<MostActiveRoomsSection <MostActiveChannelsSection
rooms={analytics?.most_active_rooms ?? []} channels={analytics?.most_active_rooms ?? []}
onNavigateToChannel={onNavigateToChannel} onNavigateToChannel={onNavigateToChannel}
/> />
</div> </div>
@@ -315,7 +317,7 @@ export function ContactInfoPane({
<InfoItem label="Last Contacted" value={formatTime(contact.last_contacted)} /> <InfoItem label="Last Contacted" value={formatTime(contact.last_contacted)} />
)} )}
{distFromUs !== null && ( {distFromUs !== null && (
<InfoItem label="Distance" value={formatDistance(distFromUs)} /> <InfoItem label="Distance" value={formatDistance(distFromUs, distanceUnit)} />
)} )}
{effectiveRoute && ( {effectiveRoute && (
<InfoItem <InfoItem
@@ -513,8 +515,8 @@ export function ContactInfoPane({
<ActivityChartsSection analytics={analytics} /> <ActivityChartsSection analytics={analytics} />
<MostActiveRoomsSection <MostActiveChannelsSection
rooms={analytics?.most_active_rooms ?? []} channels={analytics?.most_active_rooms ?? []}
onNavigateToChannel={onNavigateToChannel} onNavigateToChannel={onNavigateToChannel}
/> />
</div> </div>
@@ -586,23 +588,23 @@ function MessageStatsSection({
); );
} }
function MostActiveRoomsSection({ function MostActiveChannelsSection({
rooms, channels,
onNavigateToChannel, onNavigateToChannel,
}: { }: {
rooms: ContactActiveRoom[]; channels: ContactActiveRoom[];
onNavigateToChannel?: (channelKey: string) => void; onNavigateToChannel?: (channelKey: string) => void;
}) { }) {
if (rooms.length === 0) { if (channels.length === 0) {
return null; return null;
} }
return ( return (
<div className="px-5 py-3 border-b border-border"> <div className="px-5 py-3 border-b border-border">
<SectionLabel>Most Active Rooms</SectionLabel> <SectionLabel>Most Active Channels</SectionLabel>
<div className="space-y-1"> <div className="space-y-1">
{rooms.map((room) => ( {channels.map((channel) => (
<div key={room.channel_key} className="flex justify-between items-center text-sm"> <div key={channel.channel_key} className="flex justify-between items-center text-sm">
<span <span
className={ className={
onNavigateToChannel onNavigateToChannel
@@ -612,15 +614,15 @@ function MostActiveRoomsSection({
role={onNavigateToChannel ? 'button' : undefined} role={onNavigateToChannel ? 'button' : undefined}
tabIndex={onNavigateToChannel ? 0 : undefined} tabIndex={onNavigateToChannel ? 0 : undefined}
onKeyDown={onNavigateToChannel ? handleKeyboardActivate : undefined} onKeyDown={onNavigateToChannel ? handleKeyboardActivate : undefined}
onClick={() => onNavigateToChannel?.(room.channel_key)} onClick={() => onNavigateToChannel?.(channel.channel_key)}
> >
{room.channel_name.startsWith('#') || isPublicChannelKey(room.channel_key) {channel.channel_name.startsWith('#') || isPublicChannelKey(channel.channel_key)
? room.channel_name ? channel.channel_name
: `#${room.channel_name}`} : `#${channel.channel_name}`}
</span> </span>
<span className="text-xs text-muted-foreground flex-shrink-0 ml-2"> <span className="text-xs text-muted-foreground flex-shrink-0 ml-2">
{room.message_count.toLocaleString()} msg {channel.message_count.toLocaleString()} msg
{room.message_count !== 1 ? 's' : ''} {channel.message_count !== 1 ? 's' : ''}
</span> </span>
</div> </div>
))} ))}
@@ -11,6 +11,7 @@ import {
import { getMapFocusHash } from '../utils/urlHash'; import { getMapFocusHash } from '../utils/urlHash';
import { handleKeyboardActivate } from '../utils/a11y'; import { handleKeyboardActivate } from '../utils/a11y';
import type { Contact } from '../types'; import type { Contact } from '../types';
import { useDistanceUnit } from '../contexts/DistanceUnitContext';
import { ContactRoutingOverrideModal } from './ContactRoutingOverrideModal'; import { ContactRoutingOverrideModal } from './ContactRoutingOverrideModal';
interface ContactStatusInfoProps { interface ContactStatusInfoProps {
@@ -24,6 +25,7 @@ interface ContactStatusInfoProps {
* shared between ChatHeader and RepeaterDashboard. * shared between ChatHeader and RepeaterDashboard.
*/ */
export function ContactStatusInfo({ contact, ourLat, ourLon }: ContactStatusInfoProps) { export function ContactStatusInfo({ contact, ourLat, ourLon }: ContactStatusInfoProps) {
const { distanceUnit } = useDistanceUnit();
const [routingModalOpen, setRoutingModalOpen] = useState(false); const [routingModalOpen, setRoutingModalOpen] = useState(false);
const parts: ReactNode[] = []; const parts: ReactNode[] = [];
const effectiveRoute = getEffectiveContactRoute(contact); const effectiveRoute = getEffectiveContactRoute(contact);
@@ -74,7 +76,7 @@ export function ContactStatusInfo({ contact, ourLat, ourLon }: ContactStatusInfo
> >
{contact.lat!.toFixed(3)}, {contact.lon!.toFixed(3)} {contact.lat!.toFixed(3)}, {contact.lon!.toFixed(3)}
</span> </span>
{distFromUs !== null && ` (${formatDistance(distFromUs)})`} {distFromUs !== null && ` (${formatDistance(distFromUs, distanceUnit)})`}
</span> </span>
); );
} }
+56 -41
View File
@@ -1,9 +1,10 @@
import { lazy, Suspense, useMemo, type Ref } from 'react'; import { lazy, Suspense, useEffect, useMemo, useState, type Ref } from 'react';
import { ChatHeader } from './ChatHeader'; import { ChatHeader } from './ChatHeader';
import { MessageInput, type MessageInputHandle } from './MessageInput'; import { MessageInput, type MessageInputHandle } from './MessageInput';
import { MessageList } from './MessageList'; import { MessageList } from './MessageList';
import { RawPacketList } from './RawPacketList'; import { RawPacketFeedView } from './RawPacketFeedView';
import { RoomServerPanel } from './RoomServerPanel';
import type { import type {
Channel, Channel,
Contact, Contact,
@@ -15,7 +16,8 @@ import type {
RawPacket, RawPacket,
RadioConfig, RadioConfig,
} from '../types'; } from '../types';
import { CONTACT_TYPE_REPEATER } from '../types'; import type { RawPacketStatsSessionState } from '../utils/rawPacketStats';
import { CONTACT_TYPE_REPEATER, CONTACT_TYPE_ROOM } from '../types';
import { isPrefixOnlyContact, isUnknownFullKeyContact } from '../utils/pubkey'; import { isPrefixOnlyContact, isUnknownFullKeyContact } from '../utils/pubkey';
const RepeaterDashboard = lazy(() => const RepeaterDashboard = lazy(() =>
@@ -31,6 +33,7 @@ interface ConversationPaneProps {
contacts: Contact[]; contacts: Contact[];
channels: Channel[]; channels: Channel[];
rawPackets: RawPacket[]; rawPackets: RawPacket[];
rawPacketStatsSession: RawPacketStatsSessionState;
config: RadioConfig | null; config: RadioConfig | null;
health: HealthStatus | null; health: HealthStatus | null;
notificationsSupported: boolean; notificationsSupported: boolean;
@@ -95,6 +98,7 @@ export function ConversationPane({
contacts, contacts,
channels, channels,
rawPackets, rawPackets,
rawPacketStatsSession,
config, config,
health, health,
notificationsSupported, notificationsSupported,
@@ -128,6 +132,7 @@ export function ConversationPane({
onSendMessage, onSendMessage,
onToggleNotifications, onToggleNotifications,
}: ConversationPaneProps) { }: ConversationPaneProps) {
const [roomAuthenticated, setRoomAuthenticated] = useState(false);
const activeContactIsRepeater = useMemo(() => { const activeContactIsRepeater = useMemo(() => {
if (!activeConversation || activeConversation.type !== 'contact') return false; if (!activeConversation || activeConversation.type !== 'contact') return false;
const contact = contacts.find((candidate) => candidate.public_key === activeConversation.id); const contact = contacts.find((candidate) => candidate.public_key === activeConversation.id);
@@ -137,6 +142,10 @@ export function ConversationPane({
if (!activeConversation || activeConversation.type !== 'contact') return null; if (!activeConversation || activeConversation.type !== 'contact') return null;
return contacts.find((candidate) => candidate.public_key === activeConversation.id) ?? null; return contacts.find((candidate) => candidate.public_key === activeConversation.id) ?? null;
}, [activeConversation, contacts]); }, [activeConversation, contacts]);
const activeContactIsRoom = activeContact?.type === CONTACT_TYPE_ROOM;
useEffect(() => {
setRoomAuthenticated(false);
}, [activeConversation?.id]);
const isPrefixOnlyActiveContact = activeContact const isPrefixOnlyActiveContact = activeContact
? isPrefixOnlyContact(activeContact.public_key) ? isPrefixOnlyContact(activeContact.public_key)
: false; : false;
@@ -178,14 +187,12 @@ export function ConversationPane({
if (activeConversation.type === 'raw') { if (activeConversation.type === 'raw') {
return ( return (
<> <RawPacketFeedView
<h2 className="flex justify-between items-center px-4 py-2.5 border-b border-border font-semibold text-base"> packets={rawPackets}
Raw Packet Feed rawPacketStatsSession={rawPacketStatsSession}
</h2> contacts={contacts}
<div className="flex-1 overflow-hidden"> channels={channels}
<RawPacketList packets={rawPackets} /> />
</div>
</>
); );
} }
@@ -217,6 +224,8 @@ export function ConversationPane({
); );
} }
const showRoomChat = !activeContactIsRoom || roomAuthenticated;
return ( return (
<> <>
<ChatHeader <ChatHeader
@@ -244,35 +253,41 @@ export function ConversationPane({
{activeConversation.type === 'contact' && isUnknownFullKeyActiveContact && ( {activeConversation.type === 'contact' && isUnknownFullKeyActiveContact && (
<ContactResolutionBanner variant="unknown-full-key" /> <ContactResolutionBanner variant="unknown-full-key" />
)} )}
<MessageList {activeContactIsRoom && activeContact && (
key={activeConversation.id} <RoomServerPanel contact={activeContact} onAuthenticatedChange={setRoomAuthenticated} />
messages={messages} )}
contacts={contacts} {showRoomChat && (
loading={messagesLoading} <MessageList
loadingOlder={loadingOlder} key={activeConversation.id}
hasOlderMessages={hasOlderMessages} messages={messages}
unreadMarkerLastReadAt={ contacts={contacts}
activeConversation.type === 'channel' ? unreadMarkerLastReadAt : undefined channels={channels}
} loading={messagesLoading}
onDismissUnreadMarker={ loadingOlder={loadingOlder}
activeConversation.type === 'channel' ? onDismissUnreadMarker : undefined hasOlderMessages={hasOlderMessages}
} unreadMarkerLastReadAt={
onSenderClick={activeConversation.type === 'channel' ? onSenderClick : undefined} activeConversation.type === 'channel' ? unreadMarkerLastReadAt : undefined
onLoadOlder={onLoadOlder} }
onResendChannelMessage={ onDismissUnreadMarker={
activeConversation.type === 'channel' ? onResendChannelMessage : undefined activeConversation.type === 'channel' ? onDismissUnreadMarker : undefined
} }
radioName={config?.name} onSenderClick={activeConversation.type === 'channel' ? onSenderClick : undefined}
config={config} onLoadOlder={onLoadOlder}
onOpenContactInfo={onOpenContactInfo} onResendChannelMessage={
targetMessageId={targetMessageId} activeConversation.type === 'channel' ? onResendChannelMessage : undefined
onTargetReached={onTargetReached} }
hasNewerMessages={hasNewerMessages} radioName={config?.name}
loadingNewer={loadingNewer} config={config}
onLoadNewer={onLoadNewer} onOpenContactInfo={onOpenContactInfo}
onJumpToBottom={onJumpToBottom} targetMessageId={targetMessageId}
/> onTargetReached={onTargetReached}
{activeConversation.type === 'contact' && isPrefixOnlyActiveContact ? null : ( hasNewerMessages={hasNewerMessages}
loadingNewer={loadingNewer}
onLoadNewer={onLoadNewer}
onJumpToBottom={onJumpToBottom}
/>
)}
{showRoomChat && !(activeConversation.type === 'contact' && isPrefixOnlyActiveContact) ? (
<MessageInput <MessageInput
ref={messageInputRef} ref={messageInputRef}
onSend={onSendMessage} onSend={onSendMessage}
@@ -285,7 +300,7 @@ export function ConversationPane({
: `Message ${activeConversation.name}...` : `Message ${activeConversation.name}...`
} }
/> />
)} ) : null}
</> </>
); );
} }
+20 -19
View File
@@ -7,8 +7,8 @@ import { toast } from './ui/sonner';
import { cn } from '@/lib/utils'; import { cn } from '@/lib/utils';
import { extractPacketPayloadHex } from '../utils/pathUtils'; import { extractPacketPayloadHex } from '../utils/pathUtils';
interface CrackedRoom { interface CrackedChannel {
roomName: string; channelName: string;
key: string; key: string;
packetId: number; packetId: number;
message: string; message: string;
@@ -45,7 +45,7 @@ export function CrackerPanel({
const [twoWordMode, setTwoWordMode] = useState(false); const [twoWordMode, setTwoWordMode] = useState(false);
const [progress, setProgress] = useState<ProgressReport | null>(null); const [progress, setProgress] = useState<ProgressReport | null>(null);
const [queue, setQueue] = useState<Map<number, QueueItem>>(new Map()); const [queue, setQueue] = useState<Map<number, QueueItem>>(new Map());
const [crackedRooms, setCrackedRooms] = useState<CrackedRoom[]>([]); const [crackedChannels, setCrackedChannels] = useState<CrackedChannel[]>([]);
const [wordlistLoaded, setWordlistLoaded] = useState(false); const [wordlistLoaded, setWordlistLoaded] = useState(false);
const [gpuAvailable, setGpuAvailable] = useState<boolean | null>(null); const [gpuAvailable, setGpuAvailable] = useState<boolean | null>(null);
const [undecryptedPacketCount, setUndecryptedPacketCount] = useState<number | null>(null); const [undecryptedPacketCount, setUndecryptedPacketCount] = useState<number | null>(null);
@@ -325,14 +325,14 @@ export function CrackerPanel({
return updated; return updated;
}); });
const newRoom: CrackedRoom = { const newCracked: CrackedChannel = {
roomName: result.roomName, channelName: result.roomName,
key: result.key, key: result.key,
packetId: nextId!, packetId: nextId!,
message: result.decryptedMessage || '', message: result.decryptedMessage || '',
crackedAt: Date.now(), crackedAt: Date.now(),
}; };
setCrackedRooms((prev) => [...prev, newRoom]); setCrackedChannels((prev) => [...prev, newCracked]);
// Auto-add channel if not already exists // Auto-add channel if not already exists
const keyUpper = result.key.toUpperCase(); const keyUpper = result.key.toUpperCase();
@@ -505,7 +505,7 @@ export function CrackerPanel({
? 'GPU Not Available' ? 'GPU Not Available'
: !wordlistLoaded : !wordlistLoaded
? 'Loading dictionary...' ? 'Loading dictionary...'
: 'Find Rooms'} : 'Find Channels'}
</button> </button>
{/* Status */} {/* Status */}
@@ -580,20 +580,20 @@ export function CrackerPanel({
</div> </div>
)} )}
{/* Cracked rooms list */} {/* Cracked channels list */}
{crackedRooms.length > 0 && ( {crackedChannels.length > 0 && (
<div> <div>
<div className="text-xs text-muted-foreground mb-1">Cracked Rooms:</div> <div className="text-xs text-muted-foreground mb-1">Cracked Channels:</div>
<div className="space-y-1"> <div className="space-y-1">
{crackedRooms.map((room, i) => ( {crackedChannels.map((channel, i) => (
<div <div
key={i} key={i}
className="text-sm bg-success/10 border border-success/20 rounded px-2 py-1" className="text-sm bg-success/10 border border-success/20 rounded px-2 py-1"
> >
<span className="text-success font-medium">#{room.roomName}</span> <span className="text-success font-medium">#{channel.channelName}</span>
<span className="text-muted-foreground ml-2 text-xs"> <span className="text-muted-foreground ml-2 text-xs">
"{room.message.slice(0, 50)} "{channel.message.slice(0, 50)}
{room.message.length > 50 ? '...' : ''}" {channel.message.length > 50 ? '...' : ''}"
</span> </span>
</div> </div>
))} ))}
@@ -604,16 +604,17 @@ export function CrackerPanel({
<hr className="border-border" /> <hr className="border-border" />
<p className="text-sm text-muted-foreground leading-relaxed"> <p className="text-sm text-muted-foreground leading-relaxed">
For unknown-keyed GroupText packets, this will attempt to dictionary attack, then brute For unknown-keyed GroupText packets, this will attempt to dictionary attack, then brute
force payloads as they arrive, testing room names up to the specified length to discover force payloads as they arrive, testing channel names up to the specified length to discover
active rooms on the local mesh (GroupText packets may not be hashtag messages; we have no active channels on the local mesh (GroupText packets may not be hashtag messages; we have no
way of knowing but try as if they are). way of knowing but try as if they are).
<strong> Retry failed at n+1</strong> will let the cracker return to the failed queue and <strong> Retry failed at n+1</strong> will let the cracker return to the failed queue and
pick up messages it couldn't crack, attempting them at one longer length. pick up messages it couldn't crack, attempting them at one longer length.
<strong> Try word pairs</strong> will also try every combination of two dictionary words <strong> Try word pairs</strong> will also try every combination of two dictionary words
concatenated together (e.g. "hello" + "world" = "#helloworld") after the single-word concatenated together (e.g. "hello" + "world" = "#helloworld") after the single-word
dictionary pass; this can substantially increase search time. dictionary pass; this can substantially increase search time and also result in
<strong> Decrypt historical</strong> will run an async job on any room name it finds to see false-positives.
if any historically captured packets will decrypt with that key. <strong> Decrypt historical</strong> will run an async job on any channel name it finds to
see if any historically captured packets will decrypt with that key.
<strong> Turbo mode</strong> will push your GPU to the max (target dispatch time of 10s) and <strong> Turbo mode</strong> will push your GPU to the max (target dispatch time of 10s) and
may allow accelerated cracking and/or system instability. may allow accelerated cracking and/or system instability.
</p> </p>
+148 -16
View File
@@ -8,19 +8,23 @@ import {
useState, useState,
type ReactNode, type ReactNode,
} from 'react'; } from 'react';
import type { Contact, Message, MessagePath, RadioConfig } from '../types'; import type { Channel, Contact, Message, MessagePath, RadioConfig, RawPacket } from '../types';
import { CONTACT_TYPE_REPEATER } from '../types'; import { CONTACT_TYPE_REPEATER, CONTACT_TYPE_ROOM } from '../types';
import { api } from '../api';
import { formatTime, parseSenderFromText } from '../utils/messageParser'; import { formatTime, parseSenderFromText } from '../utils/messageParser';
import { formatHopCounts, type SenderInfo } from '../utils/pathUtils'; import { formatHopCounts, type SenderInfo } from '../utils/pathUtils';
import { getDirectContactRoute } from '../utils/pathUtils'; import { getDirectContactRoute } from '../utils/pathUtils';
import { ContactAvatar } from './ContactAvatar'; import { ContactAvatar } from './ContactAvatar';
import { PathModal } from './PathModal'; import { PathModal } from './PathModal';
import { RawPacketInspectorDialog } from './RawPacketDetailModal';
import { toast } from './ui/sonner';
import { handleKeyboardActivate } from '../utils/a11y'; import { handleKeyboardActivate } from '../utils/a11y';
import { cn } from '@/lib/utils'; import { cn } from '@/lib/utils';
interface MessageListProps { interface MessageListProps {
messages: Message[]; messages: Message[];
contacts: Contact[]; contacts: Contact[];
channels?: Channel[];
loading: boolean; loading: boolean;
loadingOlder?: boolean; loadingOlder?: boolean;
hasOlderMessages?: boolean; hasOlderMessages?: boolean;
@@ -153,6 +157,8 @@ function HopCountBadge({ paths, onClick, variant }: HopCountBadgeProps) {
const RESEND_WINDOW_SECONDS = 30; const RESEND_WINDOW_SECONDS = 30;
const CORRUPT_SENDER_LABEL = '<No name -- corrupt packet?>'; const CORRUPT_SENDER_LABEL = '<No name -- corrupt packet?>';
const ANALYZE_PACKET_NOTICE =
'This analyzer shows one stored full packet copy only. When multiple receives have identical payloads, the backend deduplicates them to a single stored packet and appends any additional receive paths onto the message path history instead of storing multiple full packet copies.';
function hasUnexpectedControlChars(text: string): boolean { function hasUnexpectedControlChars(text: string): boolean {
for (const char of text) { for (const char of text) {
@@ -173,6 +179,7 @@ function hasUnexpectedControlChars(text: string): boolean {
export function MessageList({ export function MessageList({
messages, messages,
contacts, contacts,
channels = [],
loading, loading,
loadingOlder = false, loadingOlder = false,
hasOlderMessages = false, hasOlderMessages = false,
@@ -199,10 +206,18 @@ export function MessageList({
paths: MessagePath[]; paths: MessagePath[];
senderInfo: SenderInfo; senderInfo: SenderInfo;
messageId?: number; messageId?: number;
packetId?: number | null;
isOutgoingChan?: boolean; isOutgoingChan?: boolean;
} | null>(null); } | null>(null);
const [resendableIds, setResendableIds] = useState<Set<number>>(new Set()); const [resendableIds, setResendableIds] = useState<Set<number>>(new Set());
const resendTimersRef = useRef<Map<number, ReturnType<typeof setTimeout>>>(new Map()); const resendTimersRef = useRef<Map<number, ReturnType<typeof setTimeout>>>(new Map());
const packetCacheRef = useRef<Map<number, RawPacket>>(new Map());
const [packetInspectorSource, setPacketInspectorSource] = useState<
| { kind: 'packet'; packet: RawPacket }
| { kind: 'loading'; message: string }
| { kind: 'unavailable'; message: string }
| null
>(null);
const [highlightedMessageId, setHighlightedMessageId] = useState<number | null>(null); const [highlightedMessageId, setHighlightedMessageId] = useState<number | null>(null);
const [showJumpToUnread, setShowJumpToUnread] = useState(false); const [showJumpToUnread, setShowJumpToUnread] = useState(false);
const [jumpToUnreadDismissed, setJumpToUnreadDismissed] = useState(false); const [jumpToUnreadDismissed, setJumpToUnreadDismissed] = useState(false);
@@ -221,6 +236,43 @@ export function MessageList({
// Track conversation key to detect when entire message set changes // Track conversation key to detect when entire message set changes
const prevConvKeyRef = useRef<string | null>(null); const prevConvKeyRef = useRef<string | null>(null);
const handleAnalyzePacket = useCallback(async (message: Message) => {
if (message.packet_id == null) {
setPacketInspectorSource({
kind: 'unavailable',
message:
'No archival raw packet is available for this message, so packet analysis cannot be shown.',
});
return;
}
const cached = packetCacheRef.current.get(message.packet_id);
if (cached) {
setPacketInspectorSource({ kind: 'packet', packet: cached });
return;
}
setPacketInspectorSource({ kind: 'loading', message: 'Loading packet analysis...' });
try {
const packet = await api.getPacket(message.packet_id);
packetCacheRef.current.set(message.packet_id, packet);
setPacketInspectorSource({ kind: 'packet', packet });
} catch (error) {
const description = error instanceof Error ? error.message : 'Unknown error';
const isMissing = error instanceof Error && /not found/i.test(error.message);
if (!isMissing) {
toast.error('Failed to load raw packet', { description });
}
setPacketInspectorSource({
kind: 'unavailable',
message: isMissing
? 'The archival raw packet for this message is no longer available. It may have been purged from Settings > Database, so only the stored message and merged route history remain.'
: `Could not load the archival raw packet for this message: ${description}`,
});
}
}, []);
// Handle scroll position AFTER render // Handle scroll position AFTER render
useLayoutEffect(() => { useLayoutEffect(() => {
if (!listRef.current) return; if (!listRef.current) return;
@@ -500,6 +552,33 @@ export function MessageList({
contact: Contact | null, contact: Contact | null,
parsedSender: string | null parsedSender: string | null
): SenderInfo => { ): SenderInfo => {
if (
msg.type === 'PRIV' &&
contact?.type === CONTACT_TYPE_ROOM &&
(msg.sender_key || msg.sender_name)
) {
const authorContact =
(msg.sender_key
? contacts.find((candidate) => candidate.public_key === msg.sender_key)
: null) || (msg.sender_name ? getContactByName(msg.sender_name) : null);
if (authorContact) {
const directRoute = getDirectContactRoute(authorContact);
return {
name: authorContact.name || msg.sender_name || authorContact.public_key.slice(0, 12),
publicKeyOrPrefix: authorContact.public_key,
lat: authorContact.lat,
lon: authorContact.lon,
pathHashMode: directRoute?.path_hash_mode ?? null,
};
}
return {
name: msg.sender_name || msg.sender_key || 'Unknown',
publicKeyOrPrefix: msg.sender_key || '',
lat: null,
lon: null,
pathHashMode: null,
};
}
if (msg.type === 'PRIV' && contact) { if (msg.type === 'PRIV' && contact) {
const directRoute = getDirectContactRoute(contact); const directRoute = getDirectContactRoute(contact);
return { return {
@@ -584,6 +663,8 @@ export function MessageList({
isCorruptChannelMessage: boolean isCorruptChannelMessage: boolean
): string => { ): string => {
if (msg.outgoing) return '__outgoing__'; if (msg.outgoing) return '__outgoing__';
if (msg.type === 'PRIV' && msg.sender_key) return `key:${msg.sender_key}`;
if (msg.type === 'PRIV' && senderName) return `name:${senderName}`;
if (msg.type === 'PRIV' && msg.conversation_key) return msg.conversation_key; if (msg.type === 'PRIV' && msg.conversation_key) return msg.conversation_key;
if (msg.sender_key) return `key:${msg.sender_key}`; if (msg.sender_key) return `key:${msg.sender_key}`;
if (senderName) return `name:${senderName}`; if (senderName) return `name:${senderName}`;
@@ -612,18 +693,24 @@ export function MessageList({
// For DMs, look up contact; for channel messages, use parsed sender // For DMs, look up contact; for channel messages, use parsed sender
const contact = msg.type === 'PRIV' ? getContact(msg.conversation_key) : null; const contact = msg.type === 'PRIV' ? getContact(msg.conversation_key) : null;
const isRepeater = contact?.type === CONTACT_TYPE_REPEATER; const isRepeater = contact?.type === CONTACT_TYPE_REPEATER;
const isRoomServer = contact?.type === CONTACT_TYPE_ROOM;
// Skip sender parsing for repeater messages (CLI responses often have colons) // Skip sender parsing for repeater messages (CLI responses often have colons)
const { sender, content } = isRepeater const { sender, content } =
? { sender: null, content: msg.text } isRepeater || (isRoomServer && msg.type === 'PRIV')
: parseSenderFromText(msg.text); ? { sender: null, content: msg.text }
: parseSenderFromText(msg.text);
const directSenderName =
msg.type === 'PRIV' && isRoomServer ? msg.sender_name || null : null;
const channelSenderName = msg.type === 'CHAN' ? msg.sender_name || sender : null; const channelSenderName = msg.type === 'CHAN' ? msg.sender_name || sender : null;
const channelSenderContact = const channelSenderContact =
msg.type === 'CHAN' && channelSenderName ? getContactByName(channelSenderName) : null; msg.type === 'CHAN' && channelSenderName ? getContactByName(channelSenderName) : null;
const isCorruptChannelMessage = isCorruptUnnamedChannelMessage(msg, sender); const isCorruptChannelMessage = isCorruptUnnamedChannelMessage(msg, sender);
const displaySender = msg.outgoing const displaySender = msg.outgoing
? 'You' ? 'You'
: contact?.name || : directSenderName ||
(isRoomServer && msg.sender_key ? msg.sender_key.slice(0, 8) : null) ||
contact?.name ||
channelSenderName || channelSenderName ||
(isCorruptChannelMessage (isCorruptChannelMessage
? CORRUPT_SENDER_LABEL ? CORRUPT_SENDER_LABEL
@@ -636,15 +723,22 @@ export function MessageList({
displaySender !== CORRUPT_SENDER_LABEL; displaySender !== CORRUPT_SENDER_LABEL;
// Determine if we should show avatar (first message in a chunk from same sender) // Determine if we should show avatar (first message in a chunk from same sender)
const currentSenderKey = getSenderKey(msg, channelSenderName, isCorruptChannelMessage); const currentSenderKey = getSenderKey(
msg,
directSenderName || channelSenderName,
isCorruptChannelMessage
);
const prevMsg = sortedMessages[index - 1]; const prevMsg = sortedMessages[index - 1];
const prevParsedSender = prevMsg ? parseSenderFromText(prevMsg.text).sender : null; const prevParsedSender = prevMsg ? parseSenderFromText(prevMsg.text).sender : null;
const prevSenderKey = prevMsg const prevSenderKey = prevMsg
? getSenderKey( ? getSenderKey(
prevMsg, prevMsg,
prevMsg.type === 'CHAN' prevMsg.type === 'PRIV' &&
? prevMsg.sender_name || prevParsedSender getContact(prevMsg.conversation_key)?.type === CONTACT_TYPE_ROOM
: prevParsedSender, ? prevMsg.sender_name
: prevMsg.type === 'CHAN'
? prevMsg.sender_name || prevParsedSender
: prevParsedSender,
isCorruptUnnamedChannelMessage(prevMsg, prevParsedSender) isCorruptUnnamedChannelMessage(prevMsg, prevParsedSender)
) )
: null; : null;
@@ -658,9 +752,14 @@ export function MessageList({
let avatarVariant: 'default' | 'corrupt' = 'default'; let avatarVariant: 'default' | 'corrupt' = 'default';
if (!msg.outgoing) { if (!msg.outgoing) {
if (msg.type === 'PRIV' && msg.conversation_key) { if (msg.type === 'PRIV' && msg.conversation_key) {
// DM: use conversation_key (sender's public key) if (isRoomServer) {
avatarName = contact?.name || null; avatarName = directSenderName;
avatarKey = msg.conversation_key; avatarKey =
msg.sender_key || (avatarName ? `name:${avatarName}` : msg.conversation_key);
} else {
avatarName = contact?.name || null;
avatarKey = msg.conversation_key;
}
} else if (isCorruptChannelMessage) { } else if (isCorruptChannelMessage) {
avatarName = CORRUPT_SENDER_LABEL; avatarName = CORRUPT_SENDER_LABEL;
avatarKey = `corrupt:${msg.id}`; avatarKey = `corrupt:${msg.id}`;
@@ -725,7 +824,12 @@ export function MessageList({
type="button" type="button"
className="avatar-action-button rounded-full border-none bg-transparent p-0 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring" className="avatar-action-button rounded-full border-none bg-transparent p-0 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring"
aria-label={avatarActionLabel} aria-label={avatarActionLabel}
onClick={() => onOpenContactInfo(avatarKey, msg.type === 'CHAN')} onClick={() =>
onOpenContactInfo(
avatarKey,
msg.type === 'CHAN' || (msg.type === 'PRIV' && isRoomServer)
)
}
> >
<ContactAvatar <ContactAvatar
name={avatarName} name={avatarName}
@@ -780,7 +884,9 @@ export function MessageList({
onClick={() => onClick={() =>
setSelectedPath({ setSelectedPath({
paths: msg.paths!, paths: msg.paths!,
senderInfo: getSenderInfo(msg, contact, sender), senderInfo: getSenderInfo(msg, contact, directSenderName || sender),
messageId: msg.id,
packetId: msg.packet_id,
}) })
} }
/> />
@@ -806,7 +912,9 @@ export function MessageList({
onClick={() => onClick={() =>
setSelectedPath({ setSelectedPath({
paths: msg.paths!, paths: msg.paths!,
senderInfo: getSenderInfo(msg, contact, sender), senderInfo: getSenderInfo(msg, contact, directSenderName || sender),
messageId: msg.id,
packetId: msg.packet_id,
}) })
} }
/> />
@@ -827,6 +935,7 @@ export function MessageList({
paths: msg.paths!, paths: msg.paths!,
senderInfo: selfSenderInfo, senderInfo: selfSenderInfo,
messageId: msg.id, messageId: msg.id,
packetId: msg.packet_id,
isOutgoingChan: msg.type === 'CHAN' && !!onResendChannelMessage, isOutgoingChan: msg.type === 'CHAN' && !!onResendChannelMessage,
}); });
}} }}
@@ -848,6 +957,7 @@ export function MessageList({
paths: [], paths: [],
senderInfo: selfSenderInfo, senderInfo: selfSenderInfo,
messageId: msg.id, messageId: msg.id,
packetId: msg.packet_id,
isOutgoingChan: true, isOutgoingChan: true,
}); });
}} }}
@@ -945,9 +1055,31 @@ export function MessageList({
contacts={contacts} contacts={contacts}
config={config ?? null} config={config ?? null}
messageId={selectedPath.messageId} messageId={selectedPath.messageId}
packetId={selectedPath.packetId}
isOutgoingChan={selectedPath.isOutgoingChan} isOutgoingChan={selectedPath.isOutgoingChan}
isResendable={isSelectedMessageResendable} isResendable={isSelectedMessageResendable}
onResend={onResendChannelMessage} onResend={onResendChannelMessage}
onAnalyzePacket={
selectedPath.packetId != null
? () => {
const message = messages.find((entry) => entry.id === selectedPath.messageId);
if (message) {
void handleAnalyzePacket(message);
}
}
: undefined
}
/>
)}
{packetInspectorSource && (
<RawPacketInspectorDialog
open={packetInspectorSource !== null}
onOpenChange={(isOpen) => !isOpen && setPacketInspectorSource(null)}
channels={channels}
source={packetInspectorSource}
title="Analyze Packet"
description="On-demand raw packet analysis for a message-backed archival packet."
notice={ANALYZE_PACKET_NOTICE}
/> />
)} )}
</div> </div>
+26 -76
View File
@@ -1,7 +1,5 @@
import { useState, useRef } from 'react'; import { useState, useRef } from 'react';
import { Dice5 } from 'lucide-react'; import { Dice5 } from 'lucide-react';
import type { Contact, Conversation } from '../types';
import { getContactDisplayName } from '../utils/pubkey';
import { import {
Dialog, Dialog,
DialogContent, DialogContent,
@@ -17,14 +15,12 @@ import { Checkbox } from './ui/checkbox';
import { Button } from './ui/button'; import { Button } from './ui/button';
import { toast } from './ui/sonner'; import { toast } from './ui/sonner';
type Tab = 'existing' | 'new-contact' | 'new-room' | 'hashtag'; type Tab = 'new-contact' | 'new-channel' | 'hashtag';
interface NewMessageModalProps { interface NewMessageModalProps {
open: boolean; open: boolean;
contacts: Contact[];
undecryptedCount: number; undecryptedCount: number;
onClose: () => void; onClose: () => void;
onSelectConversation: (conversation: Conversation) => void;
onCreateContact: (name: string, publicKey: string, tryHistorical: boolean) => Promise<void>; onCreateContact: (name: string, publicKey: string, tryHistorical: boolean) => Promise<void>;
onCreateChannel: (name: string, key: string, tryHistorical: boolean) => Promise<void>; onCreateChannel: (name: string, key: string, tryHistorical: boolean) => Promise<void>;
onCreateHashtagChannel: (name: string, tryHistorical: boolean) => Promise<void>; onCreateHashtagChannel: (name: string, tryHistorical: boolean) => Promise<void>;
@@ -32,18 +28,16 @@ interface NewMessageModalProps {
export function NewMessageModal({ export function NewMessageModal({
open, open,
contacts,
undecryptedCount, undecryptedCount,
onClose, onClose,
onSelectConversation,
onCreateContact, onCreateContact,
onCreateChannel, onCreateChannel,
onCreateHashtagChannel, onCreateHashtagChannel,
}: NewMessageModalProps) { }: NewMessageModalProps) {
const [tab, setTab] = useState<Tab>('existing'); const [tab, setTab] = useState<Tab>('new-contact');
const [name, setName] = useState(''); const [name, setName] = useState('');
const [contactKey, setContactKey] = useState(''); const [contactKey, setContactKey] = useState('');
const [roomKey, setRoomKey] = useState(''); const [channelKey, setChannelKey] = useState('');
const [tryHistorical, setTryHistorical] = useState(false); const [tryHistorical, setTryHistorical] = useState(false);
const [permitCapitals, setPermitCapitals] = useState(false); const [permitCapitals, setPermitCapitals] = useState(false);
const [error, setError] = useState(''); const [error, setError] = useState('');
@@ -53,7 +47,7 @@ export function NewMessageModal({
const resetForm = () => { const resetForm = () => {
setName(''); setName('');
setContactKey(''); setContactKey('');
setRoomKey(''); setChannelKey('');
setTryHistorical(false); setTryHistorical(false);
setPermitCapitals(false); setPermitCapitals(false);
setError(''); setError('');
@@ -71,12 +65,12 @@ export function NewMessageModal({
} }
// handleCreateContact sets activeConversation with the backend-normalized key // handleCreateContact sets activeConversation with the backend-normalized key
await onCreateContact(name.trim(), contactKey.trim(), tryHistorical); await onCreateContact(name.trim(), contactKey.trim(), tryHistorical);
} else if (tab === 'new-room') { } else if (tab === 'new-channel') {
if (!name.trim() || !roomKey.trim()) { if (!name.trim() || !channelKey.trim()) {
setError('Room name and key are required'); setError('Channel name and key are required');
return; return;
} }
await onCreateChannel(name.trim(), roomKey.trim(), tryHistorical); await onCreateChannel(name.trim(), channelKey.trim(), tryHistorical);
} else if (tab === 'hashtag') { } else if (tab === 'hashtag') {
const channelName = name.trim(); const channelName = name.trim();
const validationError = validateHashtagName(channelName); const validationError = validateHashtagName(channelName);
@@ -136,7 +130,7 @@ export function NewMessageModal({
} }
}; };
const showHistoricalOption = tab !== 'existing' && undecryptedCount > 0; const showHistoricalOption = undecryptedCount > 0;
return ( return (
<Dialog <Dialog
@@ -152,9 +146,8 @@ export function NewMessageModal({
<DialogHeader> <DialogHeader>
<DialogTitle>New Conversation</DialogTitle> <DialogTitle>New Conversation</DialogTitle>
<DialogDescription className="sr-only"> <DialogDescription className="sr-only">
{tab === 'existing' && 'Select an existing contact to start a conversation'}
{tab === 'new-contact' && 'Add a new contact by entering their name and public key'} {tab === 'new-contact' && 'Add a new contact by entering their name and public key'}
{tab === 'new-room' && 'Create a private room with a shared encryption key'} {tab === 'new-channel' && 'Create a private channel with a shared encryption key'}
{tab === 'hashtag' && 'Join a public hashtag channel'} {tab === 'hashtag' && 'Join a public hashtag channel'}
</DialogDescription> </DialogDescription>
</DialogHeader> </DialogHeader>
@@ -167,53 +160,12 @@ export function NewMessageModal({
}} }}
className="w-full" className="w-full"
> >
<TabsList className="grid w-full grid-cols-4"> <TabsList className="grid w-full grid-cols-3">
<TabsTrigger value="existing">Existing</TabsTrigger>
<TabsTrigger value="new-contact">Contact</TabsTrigger> <TabsTrigger value="new-contact">Contact</TabsTrigger>
<TabsTrigger value="new-room">Room</TabsTrigger> <TabsTrigger value="new-channel">Private Channel</TabsTrigger>
<TabsTrigger value="hashtag">Hashtag</TabsTrigger> <TabsTrigger value="hashtag">Hashtag Channel</TabsTrigger>
</TabsList> </TabsList>
<TabsContent value="existing" className="mt-4">
<div className="max-h-[300px] overflow-y-auto rounded-md border">
{contacts.filter((contact) => contact.public_key.length === 64).length === 0 ? (
<div className="p-4 text-center text-muted-foreground">No contacts available</div>
) : (
contacts
.filter((contact) => contact.public_key.length === 64)
.map((contact) => (
<div
key={contact.public_key}
className="cursor-pointer px-4 py-2 hover:bg-accent focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-inset"
role="button"
tabIndex={0}
onKeyDown={(e) => {
if (e.key === 'Enter' || e.key === ' ') {
e.preventDefault();
(e.currentTarget as HTMLElement).click();
}
}}
onClick={() => {
onSelectConversation({
type: 'contact',
id: contact.public_key,
name: getContactDisplayName(
contact.name,
contact.public_key,
contact.last_advert
),
});
resetForm();
onClose();
}}
>
{getContactDisplayName(contact.name, contact.public_key, contact.last_advert)}
</div>
))
)}
</div>
</TabsContent>
<TabsContent value="new-contact" className="mt-4 space-y-4"> <TabsContent value="new-contact" className="mt-4 space-y-4">
<div className="space-y-2"> <div className="space-y-2">
<Label htmlFor="contact-name">Name</Label> <Label htmlFor="contact-name">Name</Label>
@@ -235,23 +187,23 @@ export function NewMessageModal({
</div> </div>
</TabsContent> </TabsContent>
<TabsContent value="new-room" className="mt-4 space-y-4"> <TabsContent value="new-channel" className="mt-4 space-y-4">
<div className="space-y-2"> <div className="space-y-2">
<Label htmlFor="room-name">Room Name</Label> <Label htmlFor="channel-name">Channel Name</Label>
<Input <Input
id="room-name" id="channel-name"
value={name} value={name}
onChange={(e) => setName(e.target.value)} onChange={(e) => setName(e.target.value)}
placeholder="Room name" placeholder="Channel name"
/> />
</div> </div>
<div className="space-y-2"> <div className="space-y-2">
<Label htmlFor="room-key">Room Key</Label> <Label htmlFor="channel-key">Channel Key</Label>
<div className="flex gap-2"> <div className="flex gap-2">
<Input <Input
id="room-key" id="channel-key"
value={roomKey} value={channelKey}
onChange={(e) => setRoomKey(e.target.value)} onChange={(e) => setChannelKey(e.target.value)}
placeholder="Pre-shared key (hex)" placeholder="Pre-shared key (hex)"
className="flex-1" className="flex-1"
/> />
@@ -265,7 +217,7 @@ export function NewMessageModal({
const hex = Array.from(bytes) const hex = Array.from(bytes)
.map((b) => b.toString(16).padStart(2, '0')) .map((b) => b.toString(16).padStart(2, '0'))
.join(''); .join('');
setRoomKey(hex); setChannelKey(hex);
}} }}
title="Generate random key" title="Generate random key"
aria-label="Generate random key" aria-label="Generate random key"
@@ -299,7 +251,7 @@ export function NewMessageModal({
onChange={(e) => setPermitCapitals(e.target.checked)} onChange={(e) => setPermitCapitals(e.target.checked)}
className="w-4 h-4 rounded border-input accent-primary" className="w-4 h-4 rounded border-input accent-primary"
/> />
<span className="text-sm">Permit capitals in room key derivation</span> <span className="text-sm">Permit capitals in channel key derivation</span>
</label> </label>
<p className="text-xs text-muted-foreground pl-7"> <p className="text-xs text-muted-foreground pl-7">
Not recommended; most companions normalize to lowercase Not recommended; most companions normalize to lowercase
@@ -353,11 +305,9 @@ export function NewMessageModal({
{loading ? 'Creating...' : 'Create & Add Another'} {loading ? 'Creating...' : 'Create & Add Another'}
</Button> </Button>
)} )}
{tab !== 'existing' && ( <Button onClick={handleCreate} disabled={loading}>
<Button onClick={handleCreate} disabled={loading}> {loading ? 'Creating...' : 'Create'}
{loading ? 'Creating...' : 'Create'} </Button>
</Button>
)}
</DialogFooter> </DialogFooter>
</DialogContent> </DialogContent>
</Dialog> </Dialog>
+92 -55
View File
@@ -14,6 +14,8 @@ import {
} from '../utils/pathUtils'; } from '../utils/pathUtils';
import { formatTime } from '../utils/messageParser'; import { formatTime } from '../utils/messageParser';
import { getMapFocusHash } from '../utils/urlHash'; import { getMapFocusHash } from '../utils/urlHash';
import { useDistanceUnit } from '../contexts/DistanceUnitContext';
import type { DistanceUnit } from '../utils/distanceUnits';
const PathRouteMap = lazy(() => const PathRouteMap = lazy(() =>
import('./PathRouteMap').then((m) => ({ default: m.PathRouteMap })) import('./PathRouteMap').then((m) => ({ default: m.PathRouteMap }))
@@ -27,9 +29,11 @@ interface PathModalProps {
contacts: Contact[]; contacts: Contact[];
config: RadioConfig | null; config: RadioConfig | null;
messageId?: number; messageId?: number;
packetId?: number | null;
isOutgoingChan?: boolean; isOutgoingChan?: boolean;
isResendable?: boolean; isResendable?: boolean;
onResend?: (messageId: number, newTimestamp?: boolean) => void; onResend?: (messageId: number, newTimestamp?: boolean) => void;
onAnalyzePacket?: () => void;
} }
export function PathModal({ export function PathModal({
@@ -40,13 +44,17 @@ export function PathModal({
contacts, contacts,
config, config,
messageId, messageId,
packetId,
isOutgoingChan, isOutgoingChan,
isResendable, isResendable,
onResend, onResend,
onAnalyzePacket,
}: PathModalProps) { }: PathModalProps) {
const [expandedMaps, setExpandedMaps] = useState<Set<number>>(new Set()); const { distanceUnit } = useDistanceUnit();
const [mapModalIndex, setMapModalIndex] = useState<number | null>(null);
const hasResendActions = isOutgoingChan && messageId !== undefined && onResend; const hasResendActions = isOutgoingChan && messageId !== undefined && onResend;
const hasPaths = paths.length > 0; const hasPaths = paths.length > 0;
const showAnalyzePacket = hasPaths && packetId != null && onAnalyzePacket;
// Resolve all paths // Resolve all paths
const resolvedPaths = hasPaths const resolvedPaths = hasPaths
@@ -60,7 +68,7 @@ export function PathModal({
return ( return (
<Dialog open={open} onOpenChange={(isOpen) => !isOpen && onClose()}> <Dialog open={open} onOpenChange={(isOpen) => !isOpen && onClose()}>
<DialogContent className="max-w-md max-h-[80vh] flex flex-col"> <DialogContent className="max-w-md max-h-[80dvh] flex flex-col">
<DialogHeader> <DialogHeader>
<DialogTitle> <DialogTitle>
{hasPaths {hasPaths
@@ -87,6 +95,12 @@ export function PathModal({
{hasPaths && ( {hasPaths && (
<div className="flex-1 overflow-y-auto py-2 space-y-4"> <div className="flex-1 overflow-y-auto py-2 space-y-4">
{showAnalyzePacket ? (
<Button type="button" variant="outline" className="w-full" onClick={onAnalyzePacket}>
Analyze Packet
</Button>
) : null}
{/* Raw path summary */} {/* Raw path summary */}
<div className="text-sm"> <div className="text-sm">
{paths.map((p, index) => { {paths.map((p, index) => {
@@ -120,61 +134,75 @@ export function PathModal({
resolvedPaths[0].resolved.sender.lon, resolvedPaths[0].resolved.sender.lon,
resolvedPaths[0].resolved.receiver.lat, resolvedPaths[0].resolved.receiver.lat,
resolvedPaths[0].resolved.receiver.lon resolvedPaths[0].resolved.receiver.lon
)! )!,
distanceUnit
)} )}
</span> </span>
</div> </div>
)} )}
{resolvedPaths.map((pathData, index) => { {resolvedPaths.map((pathData, index) => (
const mapExpanded = expandedMaps.has(index); <div key={index}>
const toggleMap = () => <div className="flex items-center justify-between mb-2 pb-1 border-b border-border">
setExpandedMaps((prev) => { {!hasSinglePath ? (
const next = new Set(prev); <div className="text-sm text-foreground/70 font-semibold">
if (next.has(index)) next.delete(index); Path {index + 1}{' '}
else next.add(index); <span className="font-normal text-muted-foreground">
return next; received {formatTime(pathData.received_at)}
}); </span>
return (
<div key={index}>
<div className="flex items-center justify-between mb-2 pb-1 border-b border-border">
{!hasSinglePath ? (
<div className="text-sm text-foreground/70 font-semibold">
Path {index + 1}{' '}
<span className="font-normal text-muted-foreground">
received {formatTime(pathData.received_at)}
</span>
</div>
) : (
<div />
)}
<button
onClick={toggleMap}
aria-expanded={mapExpanded}
className="text-xs text-primary hover:underline cursor-pointer shrink-0 ml-2"
>
{mapExpanded ? 'Hide map' : 'Map route'}
</button>
</div>
{mapExpanded && (
<div className="mb-2">
<Suspense
fallback={
<div
className="rounded border border-border bg-muted/30 animate-pulse"
style={{ height: 220 }}
/>
}
>
<PathRouteMap resolved={pathData.resolved} senderInfo={senderInfo} />
</Suspense>
</div> </div>
) : (
<div />
)} )}
<PathVisualization resolved={pathData.resolved} senderInfo={senderInfo} /> <button
onClick={() => setMapModalIndex(index)}
className="text-xs text-primary hover:underline cursor-pointer shrink-0 ml-2"
>
Map route
</button>
</div> </div>
); <PathVisualization
})} resolved={pathData.resolved}
senderInfo={senderInfo}
distanceUnit={distanceUnit}
/>
</div>
))}
{/* Map modal — opens when a "Map route" button is clicked */}
<Dialog
open={mapModalIndex !== null}
onOpenChange={(open) => !open && setMapModalIndex(null)}
>
<DialogContent className="sm:max-w-2xl">
<DialogHeader>
<DialogTitle>
{mapModalIndex !== null && !hasSinglePath
? `Path ${mapModalIndex + 1} Route Map`
: 'Route Map'}
</DialogTitle>
<DialogDescription>
Map of known node locations along this message route.
</DialogDescription>
</DialogHeader>
{mapModalIndex !== null && (
<Suspense
fallback={
<div
className="rounded border border-border bg-muted/30 animate-pulse"
style={{ height: 400 }}
/>
}
>
<PathRouteMap
resolved={resolvedPaths[mapModalIndex].resolved}
senderInfo={senderInfo}
height={400}
/>
</Suspense>
)}
</DialogContent>
</Dialog>
</div> </div>
)} )}
@@ -227,9 +255,10 @@ export function PathModal({
interface PathVisualizationProps { interface PathVisualizationProps {
resolved: ResolvedPath; resolved: ResolvedPath;
senderInfo: SenderInfo; senderInfo: SenderInfo;
distanceUnit: DistanceUnit;
} }
function PathVisualization({ resolved, senderInfo }: PathVisualizationProps) { function PathVisualization({ resolved, senderInfo, distanceUnit }: PathVisualizationProps) {
// Track previous location for each hop to calculate distances // Track previous location for each hop to calculate distances
// Returns null if previous hop was ambiguous or has invalid location // Returns null if previous hop was ambiguous or has invalid location
const getPrevLocation = (hopIndex: number): { lat: number | null; lon: number | null } | null => { const getPrevLocation = (hopIndex: number): { lat: number | null; lon: number | null } | null => {
@@ -264,6 +293,7 @@ function PathVisualization({ resolved, senderInfo }: PathVisualizationProps) {
name={resolved.sender.name} name={resolved.sender.name}
prefix={resolved.sender.prefix} prefix={resolved.sender.prefix}
distance={null} distance={null}
distanceUnit={distanceUnit}
isFirst isFirst
lat={resolved.sender.lat} lat={resolved.sender.lat}
lon={resolved.sender.lon} lon={resolved.sender.lon}
@@ -277,6 +307,7 @@ function PathVisualization({ resolved, senderInfo }: PathVisualizationProps) {
hop={hop} hop={hop}
hopNumber={index + 1} hopNumber={index + 1}
prevLocation={getPrevLocation(index)} prevLocation={getPrevLocation(index)}
distanceUnit={distanceUnit}
/> />
))} ))}
@@ -286,6 +317,7 @@ function PathVisualization({ resolved, senderInfo }: PathVisualizationProps) {
name={resolved.receiver.name} name={resolved.receiver.name}
prefix={resolved.receiver.prefix} prefix={resolved.receiver.prefix}
distance={calculateReceiverDistance(resolved)} distance={calculateReceiverDistance(resolved)}
distanceUnit={distanceUnit}
isLast isLast
lat={resolved.receiver.lat} lat={resolved.receiver.lat}
lon={resolved.receiver.lon} lon={resolved.receiver.lon}
@@ -300,7 +332,7 @@ function PathVisualization({ resolved, senderInfo }: PathVisualizationProps) {
</span> </span>
<span className="text-sm font-medium"> <span className="text-sm font-medium">
{resolved.hasGaps ? '>' : ''} {resolved.hasGaps ? '>' : ''}
{formatDistance(resolved.totalDistances[0])} {formatDistance(resolved.totalDistances[0], distanceUnit)}
</span> </span>
</div> </div>
)} )}
@@ -313,6 +345,7 @@ interface PathNodeProps {
name: string; name: string;
prefix: string; prefix: string;
distance: number | null; distance: number | null;
distanceUnit: DistanceUnit;
isFirst?: boolean; isFirst?: boolean;
isLast?: boolean; isLast?: boolean;
/** Optional coordinates for map link */ /** Optional coordinates for map link */
@@ -327,6 +360,7 @@ function PathNode({
name, name,
prefix, prefix,
distance, distance,
distanceUnit,
isFirst, isFirst,
isLast, isLast,
lat, lat,
@@ -353,7 +387,9 @@ function PathNode({
<div className="font-medium truncate"> <div className="font-medium truncate">
{name} {name}
{distance !== null && ( {distance !== null && (
<span className="text-xs text-muted-foreground ml-1">- {formatDistance(distance)}</span> <span className="text-xs text-muted-foreground ml-1">
- {formatDistance(distance, distanceUnit)}
</span>
)} )}
{hasLocation && <CoordinateLink lat={lat!} lon={lon!} publicKey={publicKey!} />} {hasLocation && <CoordinateLink lat={lat!} lon={lon!} publicKey={publicKey!} />}
</div> </div>
@@ -366,9 +402,10 @@ interface HopNodeProps {
hop: PathHop; hop: PathHop;
hopNumber: number; hopNumber: number;
prevLocation: { lat: number | null; lon: number | null } | null; prevLocation: { lat: number | null; lon: number | null } | null;
distanceUnit: DistanceUnit;
} }
function HopNode({ hop, hopNumber, prevLocation }: HopNodeProps) { function HopNode({ hop, hopNumber, prevLocation, distanceUnit }: HopNodeProps) {
const isAmbiguous = hop.matches.length > 1; const isAmbiguous = hop.matches.length > 1;
const isUnknown = hop.matches.length === 0; const isUnknown = hop.matches.length === 0;
@@ -417,7 +454,7 @@ function HopNode({ hop, hopNumber, prevLocation }: HopNodeProps) {
{contact.name || contact.public_key.slice(0, 12)} {contact.name || contact.public_key.slice(0, 12)}
{dist !== null && ( {dist !== null && (
<span className="text-xs text-muted-foreground ml-1"> <span className="text-xs text-muted-foreground ml-1">
- {formatDistance(dist)} - {formatDistance(dist, distanceUnit)}
</span> </span>
)} )}
{hasLocation && ( {hasLocation && (
@@ -436,7 +473,7 @@ function HopNode({ hop, hopNumber, prevLocation }: HopNodeProps) {
{hop.matches[0].name || hop.matches[0].public_key.slice(0, 12)} {hop.matches[0].name || hop.matches[0].public_key.slice(0, 12)}
{hop.distanceFromPrev !== null && ( {hop.distanceFromPrev !== null && (
<span className="text-xs text-muted-foreground ml-1"> <span className="text-xs text-muted-foreground ml-1">
- {formatDistance(hop.distanceFromPrev)} - {formatDistance(hop.distanceFromPrev, distanceUnit)}
</span> </span>
)} )}
{isValidLocation(hop.matches[0].lat, hop.matches[0].lon) && ( {isValidLocation(hop.matches[0].lat, hop.matches[0].lon) && (
+9 -2
View File
@@ -8,6 +8,7 @@ import type { ResolvedPath, SenderInfo } from '../utils/pathUtils';
interface PathRouteMapProps { interface PathRouteMapProps {
resolved: ResolvedPath; resolved: ResolvedPath;
senderInfo: SenderInfo; senderInfo: SenderInfo;
height?: number;
} }
// Colors for hop markers (indexed by hop number - 1) // Colors for hop markers (indexed by hop number - 1)
@@ -82,7 +83,7 @@ function RouteMapBounds({ points }: { points: [number, number][] }) {
return null; return null;
} }
export function PathRouteMap({ resolved, senderInfo }: PathRouteMapProps) { export function PathRouteMap({ resolved, senderInfo, height = 220 }: PathRouteMapProps) {
const points = collectPoints(resolved); const points = collectPoints(resolved);
const hasAnyGps = points.length > 0; const hasAnyGps = points.length > 0;
@@ -117,7 +118,7 @@ export function PathRouteMap({ resolved, senderInfo }: PathRouteMapProps) {
className="rounded border border-border overflow-hidden" className="rounded border border-border overflow-hidden"
role="img" role="img"
aria-label="Map showing message route between nodes" aria-label="Map showing message route between nodes"
style={{ height: 220 }} style={{ height }}
> >
<MapContainer <MapContainer
center={center} center={center}
@@ -138,6 +139,8 @@ export function PathRouteMap({ resolved, senderInfo }: PathRouteMapProps) {
icon={makeIcon('S', SENDER_COLOR)} icon={makeIcon('S', SENDER_COLOR)}
> >
<Tooltip direction="top" offset={[0, -14]}> <Tooltip direction="top" offset={[0, -14]}>
<span className="font-mono">{resolved.sender.prefix}</span>
{' · '}
{senderInfo.name || 'Sender'} {senderInfo.name || 'Sender'}
</Tooltip> </Tooltip>
</Marker> </Marker>
@@ -154,6 +157,8 @@ export function PathRouteMap({ resolved, senderInfo }: PathRouteMapProps) {
icon={makeIcon(String(hopIdx + 1), getHopColor(hopIdx))} icon={makeIcon(String(hopIdx + 1), getHopColor(hopIdx))}
> >
<Tooltip direction="top" offset={[0, -14]}> <Tooltip direction="top" offset={[0, -14]}>
<span className="font-mono">{hop.prefix}</span>
{' · '}
{m.name || m.public_key.slice(0, 12)} {m.name || m.public_key.slice(0, 12)}
</Tooltip> </Tooltip>
</Marker> </Marker>
@@ -167,6 +172,8 @@ export function PathRouteMap({ resolved, senderInfo }: PathRouteMapProps) {
icon={makeIcon('R', RECEIVER_COLOR)} icon={makeIcon('R', RECEIVER_COLOR)}
> >
<Tooltip direction="top" offset={[0, -14]}> <Tooltip direction="top" offset={[0, -14]}>
<span className="font-mono">{resolved.receiver.prefix}</span>
{' · '}
{resolved.receiver.name || 'Receiver'} {resolved.receiver.name || 'Receiver'}
</Tooltip> </Tooltip>
</Marker> </Marker>
@@ -0,0 +1,820 @@
import { useEffect, useMemo, useState, type ReactNode } from 'react';
import { ChannelCrypto, PayloadType } from '@michaelhart/meshcore-decoder';
import type { Channel, RawPacket } from '../types';
import { cn } from '@/lib/utils';
import {
createDecoderOptions,
inspectRawPacketWithOptions,
type PacketByteField,
} from '../utils/rawPacketInspector';
import { toast } from './ui/sonner';
import { Button } from './ui/button';
import { Dialog, DialogContent, DialogDescription, DialogHeader, DialogTitle } from './ui/dialog';
interface RawPacketDetailModalProps {
packet: RawPacket | null;
channels: Channel[];
onClose: () => void;
}
type RawPacketInspectorDialogSource =
| {
kind: 'packet';
packet: RawPacket;
}
| {
kind: 'paste';
}
| {
kind: 'loading';
message: string;
}
| {
kind: 'unavailable';
message: string;
};
interface RawPacketInspectorDialogProps {
open: boolean;
onOpenChange: (open: boolean) => void;
channels: Channel[];
source: RawPacketInspectorDialogSource;
title: string;
description: string;
notice?: ReactNode;
}
interface RawPacketInspectionPanelProps {
packet: RawPacket;
channels: Channel[];
}
interface FieldPaletteEntry {
box: string;
boxActive: string;
hex: string;
hexActive: string;
}
interface GroupTextResolutionCandidate {
key: string;
name: string;
hash: string;
}
const FIELD_PALETTE: FieldPaletteEntry[] = [
{
box: 'border-sky-500/30 bg-sky-500/10',
boxActive: 'border-sky-600 bg-sky-500/20 shadow-sm shadow-sky-500/20',
hex: 'bg-sky-500/20 ring-1 ring-inset ring-sky-500/35',
hexActive: 'bg-sky-500/40 ring-1 ring-inset ring-sky-600/70',
},
{
box: 'border-emerald-500/30 bg-emerald-500/10',
boxActive: 'border-emerald-600 bg-emerald-500/20 shadow-sm shadow-emerald-500/20',
hex: 'bg-emerald-500/20 ring-1 ring-inset ring-emerald-500/35',
hexActive: 'bg-emerald-500/40 ring-1 ring-inset ring-emerald-600/70',
},
{
box: 'border-amber-500/30 bg-amber-500/10',
boxActive: 'border-amber-600 bg-amber-500/20 shadow-sm shadow-amber-500/20',
hex: 'bg-amber-500/20 ring-1 ring-inset ring-amber-500/35',
hexActive: 'bg-amber-500/40 ring-1 ring-inset ring-amber-600/70',
},
{
box: 'border-rose-500/30 bg-rose-500/10',
boxActive: 'border-rose-600 bg-rose-500/20 shadow-sm shadow-rose-500/20',
hex: 'bg-rose-500/20 ring-1 ring-inset ring-rose-500/35',
hexActive: 'bg-rose-500/40 ring-1 ring-inset ring-rose-600/70',
},
{
box: 'border-violet-500/30 bg-violet-500/10',
boxActive: 'border-violet-600 bg-violet-500/20 shadow-sm shadow-violet-500/20',
hex: 'bg-violet-500/20 ring-1 ring-inset ring-violet-500/35',
hexActive: 'bg-violet-500/40 ring-1 ring-inset ring-violet-600/70',
},
{
box: 'border-cyan-500/30 bg-cyan-500/10',
boxActive: 'border-cyan-600 bg-cyan-500/20 shadow-sm shadow-cyan-500/20',
hex: 'bg-cyan-500/20 ring-1 ring-inset ring-cyan-500/35',
hexActive: 'bg-cyan-500/40 ring-1 ring-inset ring-cyan-600/70',
},
{
box: 'border-lime-500/30 bg-lime-500/10',
boxActive: 'border-lime-600 bg-lime-500/20 shadow-sm shadow-lime-500/20',
hex: 'bg-lime-500/20 ring-1 ring-inset ring-lime-500/35',
hexActive: 'bg-lime-500/40 ring-1 ring-inset ring-lime-600/70',
},
{
box: 'border-fuchsia-500/30 bg-fuchsia-500/10',
boxActive: 'border-fuchsia-600 bg-fuchsia-500/20 shadow-sm shadow-fuchsia-500/20',
hex: 'bg-fuchsia-500/20 ring-1 ring-inset ring-fuchsia-500/35',
hexActive: 'bg-fuchsia-500/40 ring-1 ring-inset ring-fuchsia-600/70',
},
];
function formatTimestamp(timestamp: number): string {
return new Date(timestamp * 1000).toLocaleString([], {
year: 'numeric',
month: 'short',
day: 'numeric',
hour: '2-digit',
minute: '2-digit',
second: '2-digit',
});
}
function formatSignal(packet: RawPacket): string {
const parts: string[] = [];
if (packet.rssi !== null) {
parts.push(`${packet.rssi} dBm RSSI`);
}
if (packet.snr !== null) {
parts.push(`${packet.snr.toFixed(1)} dB SNR`);
}
return parts.length > 0 ? parts.join(' · ') : 'No signal sample';
}
function formatByteRange(field: PacketByteField): string {
if (field.absoluteStartByte === field.absoluteEndByte) {
return `Byte ${field.absoluteStartByte}`;
}
return `Bytes ${field.absoluteStartByte}-${field.absoluteEndByte}`;
}
function formatPathMode(hashSize: number | undefined, hopCount: number): string {
if (hopCount === 0) {
return 'No path hops';
}
if (!hashSize) {
return `${hopCount} hop${hopCount === 1 ? '' : 's'}`;
}
return `${hopCount} hop${hopCount === 1 ? '' : 's'} · ${hashSize} byte hash${hashSize === 1 ? '' : 'es'}`;
}
function buildGroupTextResolutionCandidates(channels: Channel[]): GroupTextResolutionCandidate[] {
return channels.map((channel) => ({
key: channel.key,
name: channel.name,
hash: ChannelCrypto.calculateChannelHash(channel.key).toUpperCase(),
}));
}
function resolveGroupTextChannelName(
payload: {
channelHash?: string;
cipherMac?: string;
ciphertext?: string;
decrypted?: { message?: string };
},
candidates: GroupTextResolutionCandidate[]
): string | null {
if (!payload.channelHash) {
return null;
}
const hashMatches = candidates.filter(
(candidate) => candidate.hash === payload.channelHash?.toUpperCase()
);
if (hashMatches.length === 1) {
return hashMatches[0].name;
}
if (
hashMatches.length <= 1 ||
!payload.cipherMac ||
!payload.ciphertext ||
!payload.decrypted?.message
) {
return null;
}
const decryptMatches = hashMatches.filter(
(candidate) =>
ChannelCrypto.decryptGroupTextMessage(payload.ciphertext!, payload.cipherMac!, candidate.key)
.success
);
return decryptMatches.length === 1 ? decryptMatches[0].name : null;
}
function packetShowsDecryptedState(
packet: RawPacket,
inspection: ReturnType<typeof inspectRawPacketWithOptions>
): boolean {
const payload = inspection.decoded?.payload.decoded as { decrypted?: unknown } | null | undefined;
return packet.decrypted || Boolean(packet.decrypted_info) || Boolean(payload?.decrypted);
}
function getPacketContext(
packet: RawPacket,
inspection: ReturnType<typeof inspectRawPacketWithOptions>,
groupTextCandidates: GroupTextResolutionCandidate[]
) {
const fallbackSender = packet.decrypted_info?.sender ?? null;
const fallbackChannel = packet.decrypted_info?.channel_name ?? null;
if (!inspection.decoded?.payload.decoded) {
if (!fallbackSender && !fallbackChannel) {
return null;
}
return {
title: fallbackChannel ? 'Channel' : 'Context',
primary: fallbackChannel ?? 'Sender metadata available',
secondary: fallbackSender ? `Sender: ${fallbackSender}` : null,
};
}
if (inspection.decoded.payloadType === PayloadType.GroupText) {
const payload = inspection.decoded.payload.decoded as {
channelHash?: string;
cipherMac?: string;
ciphertext?: string;
decrypted?: { sender?: string; message?: string };
};
const channelName =
fallbackChannel ?? resolveGroupTextChannelName(payload, groupTextCandidates);
return {
title: 'Channel',
primary:
channelName ?? (payload.channelHash ? `Channel hash ${payload.channelHash}` : 'GroupText'),
secondary: payload.decrypted?.sender
? `Sender: ${payload.decrypted.sender}`
: fallbackSender
? `Sender: ${fallbackSender}`
: null,
};
}
if (fallbackSender) {
return {
title: 'Context',
primary: fallbackSender,
secondary: null,
};
}
return null;
}
function buildDisplayFields(inspection: ReturnType<typeof inspectRawPacketWithOptions>) {
return [
...inspection.packetFields.filter((field) => field.name !== 'Payload'),
...inspection.payloadFields,
];
}
function buildFieldColorMap(fields: PacketByteField[]) {
return new Map(
fields.map((field, index) => [field.id, FIELD_PALETTE[index % FIELD_PALETTE.length]])
);
}
function buildByteOwners(totalBytes: number, fields: PacketByteField[]) {
const owners = new Array<string | null>(totalBytes).fill(null);
for (const field of fields) {
for (let index = field.absoluteStartByte; index <= field.absoluteEndByte; index += 1) {
if (index >= 0 && index < owners.length) {
owners[index] = field.id;
}
}
}
return owners;
}
function buildByteRuns(bytes: string[], owners: Array<string | null>) {
const runs: Array<{ fieldId: string | null; text: string }> = [];
for (let index = 0; index < bytes.length; index += 1) {
const fieldId = owners[index];
const lastRun = runs[runs.length - 1];
if (lastRun && lastRun.fieldId === fieldId) {
lastRun.text += ` ${bytes[index]}`;
continue;
}
runs.push({
fieldId,
text: bytes[index],
});
}
return runs;
}
function CompactMetaCard({
label,
primary,
secondary,
}: {
label: string;
primary: string;
secondary?: string | null;
}) {
return (
<div className="rounded-lg border border-border/70 bg-card/70 p-2.5">
<div className="text-[10px] uppercase tracking-[0.18em] text-muted-foreground">{label}</div>
<div className="mt-1 text-sm font-medium leading-tight text-foreground">{primary}</div>
{secondary ? (
<div className="mt-1 text-xs leading-tight text-muted-foreground">{secondary}</div>
) : null}
</div>
);
}
function FullPacketHex({
packetHex,
fields,
colorMap,
hoveredFieldId,
onHoverField,
}: {
packetHex: string;
fields: PacketByteField[];
colorMap: Map<string, FieldPaletteEntry>;
hoveredFieldId: string | null;
onHoverField: (fieldId: string | null) => void;
}) {
const normalized = packetHex.toUpperCase();
const bytes = useMemo(() => normalized.match(/.{1,2}/g) ?? [], [normalized]);
const byteOwners = useMemo(() => buildByteOwners(bytes.length, fields), [bytes.length, fields]);
const byteRuns = useMemo(() => buildByteRuns(bytes, byteOwners), [byteOwners, bytes]);
return (
<div className="font-mono text-[15px] leading-7 text-foreground">
{byteRuns.map((run, index) => {
const fieldId = run.fieldId;
const palette = fieldId ? colorMap.get(fieldId) : null;
const active = fieldId !== null && hoveredFieldId === fieldId;
return (
<span key={`${fieldId ?? 'plain'}-${index}`}>
<span
onMouseEnter={() => onHoverField(fieldId)}
onMouseLeave={() => onHoverField(null)}
className={cn(
'inline rounded-sm px-0.5 py-0.5 transition-colors',
palette ? (active ? palette.hexActive : palette.hex) : ''
)}
>
{run.text}
</span>
{index < byteRuns.length - 1 ? ' ' : ''}
</span>
);
})}
</div>
);
}
function renderFieldValue(field: PacketByteField) {
if (field.name !== 'Path Data') {
return field.value.toUpperCase();
}
const parts = field.value
.toUpperCase()
.split(' → ')
.filter((part) => part.length > 0);
if (parts.length <= 1) {
return field.value.toUpperCase();
}
return (
<span className="inline-flex flex-wrap justify-start gap-x-1 sm:justify-end">
{parts.map((part, index) => {
const isLast = index === parts.length - 1;
return (
<span key={`${field.id}-${part}-${index}`} className="whitespace-nowrap">
{isLast ? part : `${part}`}
</span>
);
})}
</span>
);
}
function normalizePacketHex(input: string): string {
return input.replace(/\s+/g, '').toUpperCase();
}
function validatePacketHex(input: string): string | null {
if (!input) {
return 'Paste a packet hex string to analyze.';
}
if (!/^[0-9A-F]+$/.test(input)) {
return 'Packet hex may only contain 0-9 and A-F characters.';
}
if (input.length % 2 !== 0) {
return 'Packet hex must contain an even number of characters.';
}
return null;
}
function buildPastedRawPacket(packetHex: string): RawPacket {
return {
id: -1,
timestamp: Math.floor(Date.now() / 1000),
data: packetHex,
payload_type: 'Unknown',
snr: null,
rssi: null,
decrypted: false,
decrypted_info: null,
};
}
function FieldBox({
field,
palette,
active,
onHoverField,
}: {
field: PacketByteField;
palette: FieldPaletteEntry;
active: boolean;
onHoverField: (fieldId: string | null) => void;
}) {
return (
<div
onMouseEnter={() => onHoverField(field.id)}
onMouseLeave={() => onHoverField(null)}
className={cn(
'rounded-lg border p-2.5 transition-colors',
active ? palette.boxActive : palette.box
)}
>
<div className="flex flex-col items-start gap-2 sm:flex-row sm:justify-between">
<div className="min-w-0">
<div className="text-base font-semibold leading-tight text-foreground">{field.name}</div>
<div className="mt-0.5 text-[11px] text-muted-foreground">{formatByteRange(field)}</div>
</div>
<div
className={cn(
'w-full font-mono text-sm leading-5 text-foreground sm:max-w-[14rem] sm:text-right',
field.name === 'Path Data' ? 'break-normal' : 'break-all'
)}
>
{renderFieldValue(field)}
</div>
</div>
<div className="mt-2 whitespace-pre-wrap text-sm leading-5 text-foreground">
{field.description}
</div>
{field.decryptedMessage ? (
<div className="mt-2 rounded border border-border/50 bg-background/40 p-2">
<div className="text-[10px] uppercase tracking-[0.16em] text-muted-foreground">
{field.name === 'Ciphertext' ? 'Plaintext' : 'Decoded value'}
</div>
<PlaintextContent text={field.decryptedMessage} />
</div>
) : null}
{field.headerBreakdown ? (
<div className="mt-2 space-y-1.5">
<div className="font-mono text-xs tracking-[0.16em] text-muted-foreground">
{field.headerBreakdown.fullBinary}
</div>
{field.headerBreakdown.fields.map((part) => (
<div
key={`${field.id}-${part.bits}-${part.field}`}
className="rounded border border-border/50 bg-background/40 p-2"
>
<div className="flex items-start justify-between gap-2">
<div>
<div className="text-sm font-medium leading-tight text-foreground">
{part.field}
</div>
<div className="mt-0.5 text-[11px] text-muted-foreground">Bits {part.bits}</div>
</div>
<div className="text-right">
<div className="font-mono text-sm text-foreground">{part.binary}</div>
<div className="mt-0.5 text-[11px] text-muted-foreground">{part.value}</div>
</div>
</div>
</div>
))}
</div>
) : null}
</div>
);
}
function PlaintextContent({ text }: { text: string }) {
const lines = text.split('\n');
return (
<div className="mt-1 space-y-1 text-sm leading-5 text-foreground">
{lines.map((line, index) => {
const separatorIndex = line.indexOf(': ');
if (separatorIndex === -1) {
return (
<div key={`${line}-${index}`} className="font-mono">
{line}
</div>
);
}
const label = line.slice(0, separatorIndex + 1);
const value = line.slice(separatorIndex + 2);
return (
<div key={`${line}-${index}`}>
<span>{label} </span>
<span className="font-mono">{value}</span>
</div>
);
})}
</div>
);
}
function FieldSection({
title,
fields,
colorMap,
hoveredFieldId,
onHoverField,
}: {
title: string;
fields: PacketByteField[];
colorMap: Map<string, FieldPaletteEntry>;
hoveredFieldId: string | null;
onHoverField: (fieldId: string | null) => void;
}) {
return (
<section className="rounded-lg border border-border/70 bg-card/70 p-3">
<div className="mb-2 text-sm font-semibold text-foreground">{title}</div>
{fields.length === 0 ? (
<div className="text-sm text-muted-foreground">No decoded fields available.</div>
) : (
<div className="grid gap-2">
{fields.map((field) => (
<FieldBox
key={field.id}
field={field}
palette={colorMap.get(field.id) ?? FIELD_PALETTE[0]}
active={hoveredFieldId === field.id}
onHoverField={onHoverField}
/>
))}
</div>
)}
</section>
);
}
export function RawPacketInspectionPanel({ packet, channels }: RawPacketInspectionPanelProps) {
const decoderOptions = useMemo(() => createDecoderOptions(channels), [channels]);
const groupTextCandidates = useMemo(
() => buildGroupTextResolutionCandidates(channels),
[channels]
);
const inspection = useMemo(
() => inspectRawPacketWithOptions(packet, decoderOptions),
[decoderOptions, packet]
);
const [hoveredFieldId, setHoveredFieldId] = useState<string | null>(null);
const packetDisplayFields = useMemo(
() => inspection.packetFields.filter((field) => field.name !== 'Payload'),
[inspection]
);
const fullPacketFields = useMemo(() => buildDisplayFields(inspection), [inspection]);
const colorMap = useMemo(() => buildFieldColorMap(fullPacketFields), [fullPacketFields]);
const packetContext = useMemo(
() => getPacketContext(packet, inspection, groupTextCandidates),
[groupTextCandidates, inspection, packet]
);
const packetIsDecrypted = useMemo(
() => packetShowsDecryptedState(packet, inspection),
[inspection, packet]
);
return (
<div className="min-h-0 flex-1 overflow-y-auto p-3">
<div className="grid gap-2 lg:grid-cols-[minmax(0,1.45fr)_minmax(0,1fr)]">
<section className="rounded-lg border border-border/70 bg-card/70 p-3">
<div className="flex flex-wrap items-start justify-between gap-2">
<div className="min-w-0">
<div className="text-[10px] uppercase tracking-[0.18em] text-muted-foreground">
Summary
</div>
<div className="mt-1 text-base font-semibold leading-tight text-foreground">
{inspection.summary.summary}
</div>
</div>
<div className="shrink-0 text-xs text-muted-foreground">
{formatTimestamp(packet.timestamp)}
</div>
</div>
{packetContext ? (
<div className="mt-2 rounded-md border border-border/60 bg-background/35 px-2.5 py-2">
<div className="text-[10px] uppercase tracking-[0.18em] text-muted-foreground">
{packetContext.title}
</div>
<div className="mt-1 text-sm font-medium leading-tight text-foreground">
{packetContext.primary}
</div>
{packetContext.secondary ? (
<div className="mt-1 text-xs leading-tight text-muted-foreground">
{packetContext.secondary}
</div>
) : null}
</div>
) : null}
</section>
<section className="grid gap-2 sm:grid-cols-3 lg:grid-cols-1 xl:grid-cols-3">
<CompactMetaCard
label="Packet"
primary={`${packet.data.length / 2} bytes · ${packetIsDecrypted ? 'Decrypted' : 'Encrypted'}`}
secondary={`Storage #${packet.id}${packet.observation_id !== undefined ? ` · Observation #${packet.observation_id}` : ''}`}
/>
<CompactMetaCard
label="Transport"
primary={`${inspection.routeTypeName} · ${inspection.payloadTypeName}`}
secondary={`${inspection.payloadVersionName} · ${formatPathMode(inspection.decoded?.pathHashSize, inspection.pathTokens.length)}`}
/>
<CompactMetaCard
label="Signal"
primary={formatSignal(packet)}
secondary={packetContext ? null : undefined}
/>
</section>
</div>
{inspection.validationErrors.length > 0 ? (
<div className="mt-3 rounded-lg border border-warning/40 bg-warning/10 p-2.5">
<div className="text-sm font-semibold text-foreground">Validation notes</div>
<div className="mt-1.5 space-y-1 text-sm text-foreground">
{inspection.validationErrors.map((error) => (
<div key={error}>{error}</div>
))}
</div>
</div>
) : null}
<div className="mt-3 rounded-lg border border-border/70 bg-card/70 p-3">
<div className="flex items-center justify-between gap-3">
<div className="text-xl font-semibold text-foreground">Full packet hex</div>
<Button
type="button"
variant="outline"
size="sm"
onClick={() => {
navigator.clipboard.writeText(packet.data);
toast.success('Packet hex copied!');
}}
>
Copy
</Button>
</div>
<div className="mt-2.5">
<FullPacketHex
packetHex={packet.data}
fields={fullPacketFields}
colorMap={colorMap}
hoveredFieldId={hoveredFieldId}
onHoverField={setHoveredFieldId}
/>
</div>
</div>
<div className="mt-3 grid gap-3 xl:grid-cols-[minmax(0,0.85fr)_minmax(0,1.15fr)]">
<FieldSection
title="Packet fields"
fields={packetDisplayFields}
colorMap={colorMap}
hoveredFieldId={hoveredFieldId}
onHoverField={setHoveredFieldId}
/>
<FieldSection
title="Payload fields"
fields={inspection.payloadFields}
colorMap={colorMap}
hoveredFieldId={hoveredFieldId}
onHoverField={setHoveredFieldId}
/>
</div>
</div>
);
}
export function RawPacketInspectorDialog({
open,
onOpenChange,
channels,
source,
title,
description,
notice,
}: RawPacketInspectorDialogProps) {
const [packetInput, setPacketInput] = useState('');
useEffect(() => {
if (!open || source.kind !== 'paste') {
setPacketInput('');
}
}, [open, source.kind]);
const normalizedPacketInput = useMemo(() => normalizePacketHex(packetInput), [packetInput]);
const packetInputError = useMemo(
() => (normalizedPacketInput.length > 0 ? validatePacketHex(normalizedPacketInput) : null),
[normalizedPacketInput]
);
const analyzedPacket = useMemo(
() =>
normalizedPacketInput.length > 0 && packetInputError === null
? buildPastedRawPacket(normalizedPacketInput)
: null,
[normalizedPacketInput, packetInputError]
);
let body: ReactNode;
if (source.kind === 'packet') {
body = <RawPacketInspectionPanel packet={source.packet} channels={channels} />;
} else if (source.kind === 'paste') {
body = (
<>
<div className="border-b border-border px-4 py-3 pr-14">
<div className="flex flex-col gap-3">
<label className="text-sm font-medium text-foreground" htmlFor="raw-packet-input">
Packet Hex
</label>
<textarea
id="raw-packet-input"
value={packetInput}
onChange={(event) => setPacketInput(event.target.value)}
placeholder="Paste raw packet hex here..."
className="min-h-14 w-full rounded-md border border-input bg-background px-3 py-2 font-mono text-sm text-foreground outline-none transition-colors focus-visible:ring-2 focus-visible:ring-ring"
spellCheck={false}
/>
{packetInputError ? (
<div className="text-sm text-destructive">{packetInputError}</div>
) : null}
</div>
</div>
{analyzedPacket ? (
<RawPacketInspectionPanel packet={analyzedPacket} channels={channels} />
) : (
<div className="flex flex-1 items-center justify-center p-6 text-sm text-muted-foreground">
Paste a packet above to inspect it.
</div>
)}
</>
);
} else if (source.kind === 'loading') {
body = (
<div className="flex flex-1 items-center justify-center p-6 text-sm text-muted-foreground">
{source.message}
</div>
);
} else {
body = (
<div className="flex flex-1 items-center justify-center p-6">
<div className="max-w-xl rounded-lg border border-warning/40 bg-warning/10 p-4 text-sm text-foreground">
{source.message}
</div>
</div>
);
}
return (
<Dialog open={open} onOpenChange={onOpenChange}>
<DialogContent className="flex h-[92dvh] max-w-[min(96vw,82rem)] flex-col gap-0 overflow-hidden p-0">
<DialogHeader className="border-b border-border px-5 py-3">
<DialogTitle>{title}</DialogTitle>
<DialogDescription className="sr-only">{description}</DialogDescription>
</DialogHeader>
{notice ? (
<div className="border-b border-border px-3 py-3 text-sm text-foreground">
<div className="rounded-md border border-destructive/40 bg-destructive/10 px-3 py-2 text-destructive">
{notice}
</div>
</div>
) : null}
{body}
</DialogContent>
</Dialog>
);
}
export function RawPacketDetailModal({ packet, channels, onClose }: RawPacketDetailModalProps) {
if (!packet) {
return null;
}
return (
<RawPacketInspectorDialog
open={packet !== null}
onOpenChange={(isOpen) => !isOpen && onClose()}
channels={channels}
source={{ kind: 'packet', packet }}
title="Packet Details"
description="Detailed byte and field breakdown for the selected raw packet."
/>
);
}
@@ -0,0 +1,637 @@
import { useEffect, useMemo, useState } from 'react';
import { ChevronLeft, ChevronRight } from 'lucide-react';
import { RawPacketList } from './RawPacketList';
import { RawPacketInspectorDialog } from './RawPacketDetailModal';
import { Button } from './ui/button';
import type { Channel, Contact, RawPacket } from '../types';
import {
RAW_PACKET_STATS_WINDOWS,
buildRawPacketStatsSnapshot,
type NeighborStat,
type PacketTimelineBin,
type RankedPacketStat,
type RawPacketStatsSessionState,
type RawPacketStatsWindow,
} from '../utils/rawPacketStats';
import { getContactDisplayName } from '../utils/pubkey';
import { cn } from '@/lib/utils';
interface RawPacketFeedViewProps {
packets: RawPacket[];
rawPacketStatsSession: RawPacketStatsSessionState;
contacts: Contact[];
channels: Channel[];
}
const WINDOW_LABELS: Record<RawPacketStatsWindow, string> = {
'1m': '1 min',
'5m': '5 min',
'10m': '10 min',
'30m': '30 min',
session: 'Session',
};
const TIMELINE_COLORS = [
'bg-sky-500/80',
'bg-emerald-500/80',
'bg-amber-500/80',
'bg-rose-500/80',
'bg-violet-500/80',
];
function formatTimestamp(timestampMs: number): string {
return new Date(timestampMs).toLocaleString([], {
month: 'short',
day: 'numeric',
hour: '2-digit',
minute: '2-digit',
second: '2-digit',
});
}
function formatDuration(seconds: number): string {
if (seconds < 60) {
return `${Math.max(1, Math.round(seconds))} sec`;
}
if (seconds < 3600) {
const minutes = Math.floor(seconds / 60);
const remainder = Math.round(seconds % 60);
return remainder > 0 ? `${minutes}m ${remainder}s` : `${minutes}m`;
}
const hours = Math.floor(seconds / 3600);
const minutes = Math.round((seconds % 3600) / 60);
return minutes > 0 ? `${hours}h ${minutes}m` : `${hours}h`;
}
function formatRate(value: number): string {
if (value >= 100) return value.toFixed(0);
if (value >= 10) return value.toFixed(1);
return value.toFixed(2);
}
function formatPercent(value: number): string {
return `${Math.round(value * 100)}%`;
}
function formatRssi(value: number | null): string {
return value === null ? '-' : `${Math.round(value)} dBm`;
}
function normalizeResolvableSourceKey(sourceKey: string): string {
return sourceKey.startsWith('hash1:') ? sourceKey.slice(6) : sourceKey;
}
function resolveContact(sourceKey: string | null, contacts: Contact[]): Contact | null {
if (!sourceKey || sourceKey.startsWith('name:')) {
return null;
}
const normalizedSourceKey = normalizeResolvableSourceKey(sourceKey).toLowerCase();
const matches = contacts.filter((contact) =>
contact.public_key.toLowerCase().startsWith(normalizedSourceKey)
);
if (matches.length !== 1) {
return null;
}
return matches[0];
}
function resolveContactLabel(sourceKey: string | null, contacts: Contact[]): string | null {
const contact = resolveContact(sourceKey, contacts);
if (!contact) {
return null;
}
return getContactDisplayName(contact.name, contact.public_key, contact.last_advert);
}
function resolveNeighbor(item: NeighborStat, contacts: Contact[]): NeighborStat {
return {
...item,
label: resolveContactLabel(item.key, contacts) ?? item.label,
};
}
function mergeResolvedNeighbors(items: NeighborStat[], contacts: Contact[]): NeighborStat[] {
const merged = new Map<string, NeighborStat>();
for (const item of items) {
const contact = resolveContact(item.key, contacts);
const canonicalKey = contact?.public_key ?? item.key;
const resolvedLabel =
contact != null
? getContactDisplayName(contact.name, contact.public_key, contact.last_advert)
: item.label;
const existing = merged.get(canonicalKey);
if (!existing) {
merged.set(canonicalKey, {
...item,
key: canonicalKey,
label: resolvedLabel,
});
continue;
}
existing.count += item.count;
existing.lastSeen = Math.max(existing.lastSeen, item.lastSeen);
existing.bestRssi =
existing.bestRssi === null
? item.bestRssi
: item.bestRssi === null
? existing.bestRssi
: Math.max(existing.bestRssi, item.bestRssi);
existing.label = resolvedLabel;
}
return Array.from(merged.values());
}
function isNeighborIdentityResolvable(item: NeighborStat, contacts: Contact[]): boolean {
if (item.key.startsWith('name:')) {
return true;
}
return resolveContact(item.key, contacts) !== null;
}
function formatStrongestPacketDetail(
stats: ReturnType<typeof buildRawPacketStatsSnapshot>,
contacts: Contact[]
): string | undefined {
if (!stats.strongestPacketPayloadType) {
return undefined;
}
const resolvedLabel =
resolveContactLabel(stats.strongestPacketSourceKey, contacts) ??
stats.strongestPacketSourceLabel;
if (resolvedLabel) {
return `${resolvedLabel} · ${stats.strongestPacketPayloadType}`;
}
if (stats.strongestPacketPayloadType === 'GroupText') {
return '<unknown sender> · GroupText';
}
return stats.strongestPacketPayloadType;
}
function getCoverageMessage(
stats: ReturnType<typeof buildRawPacketStatsSnapshot>,
session: RawPacketStatsSessionState
): { tone: 'default' | 'warning'; message: string } {
if (session.trimmedObservationCount > 0 && stats.window === 'session') {
return {
tone: 'warning',
message: `Detailed session history was trimmed after ${session.totalObservedPackets.toLocaleString()} observations.`,
};
}
if (!stats.windowFullyCovered) {
return {
tone: 'warning',
message: `This window is only covered for ${formatDuration(stats.coverageSeconds)} of frontend-collected history.`,
};
}
return {
tone: 'default',
message: `Tracking ${session.observations.length.toLocaleString()} detailed observations from this browser session.`,
};
}
function StatTile({ label, value, detail }: { label: string; value: string; detail?: string }) {
return (
<div className="break-inside-avoid rounded-lg border border-border/70 bg-card/80 p-3">
<div className="text-[11px] uppercase tracking-wide text-muted-foreground">{label}</div>
<div className="mt-1 text-xl font-semibold tabular-nums text-foreground">{value}</div>
{detail ? <div className="mt-1 text-xs text-muted-foreground">{detail}</div> : null}
</div>
);
}
function RankedBars({
title,
items,
emptyLabel,
formatter,
}: {
title: string;
items: RankedPacketStat[];
emptyLabel: string;
formatter?: (item: RankedPacketStat) => string;
}) {
const maxCount = Math.max(...items.map((item) => item.count), 1);
return (
<section className="mb-4 break-inside-avoid rounded-lg border border-border/70 bg-card/70 p-3">
<h3 className="text-sm font-semibold text-foreground">{title}</h3>
{items.length === 0 ? (
<p className="mt-3 text-sm text-muted-foreground">{emptyLabel}</p>
) : (
<div className="mt-3 space-y-2">
{items.map((item) => (
<div key={item.label}>
<div className="mb-1 flex items-center justify-between gap-3 text-xs">
<span className="truncate text-foreground">{item.label}</span>
<span className="shrink-0 tabular-nums text-muted-foreground">
{formatter
? formatter(item)
: `${item.count.toLocaleString()} · ${formatPercent(item.share)}`}
</span>
</div>
<div className="h-2 overflow-hidden rounded-full bg-muted">
<div
className="h-full rounded-full bg-primary/80"
style={{ width: `${(item.count / maxCount) * 100}%` }}
/>
</div>
</div>
))}
</div>
)}
</section>
);
}
function NeighborList({
title,
items,
emptyLabel,
mode,
contacts,
}: {
title: string;
items: NeighborStat[];
emptyLabel: string;
mode: 'heard' | 'signal' | 'recent';
contacts: Contact[];
}) {
const mergedItems = mergeResolvedNeighbors(items, contacts);
const sortedItems = [...mergedItems].sort((a, b) => {
if (mode === 'heard') {
return b.count - a.count || b.lastSeen - a.lastSeen || a.label.localeCompare(b.label);
}
if (mode === 'signal') {
return (
(b.bestRssi ?? Number.NEGATIVE_INFINITY) - (a.bestRssi ?? Number.NEGATIVE_INFINITY) ||
b.count - a.count ||
a.label.localeCompare(b.label)
);
}
return b.lastSeen - a.lastSeen || b.count - a.count || a.label.localeCompare(b.label);
});
return (
<section className="mb-4 break-inside-avoid rounded-lg border border-border/70 bg-card/70 p-3">
<h3 className="text-sm font-semibold text-foreground">{title}</h3>
{sortedItems.length === 0 ? (
<p className="mt-3 text-sm text-muted-foreground">{emptyLabel}</p>
) : (
<div className="mt-3 space-y-2">
{sortedItems.map((item) => (
<div
key={item.key}
className="flex items-center justify-between gap-3 rounded-md bg-background/70 px-2 py-1.5"
>
<div className="min-w-0">
<div className="truncate text-sm text-foreground">{item.label}</div>
<div className="text-xs text-muted-foreground">
{mode === 'heard'
? `${item.count.toLocaleString()} packets`
: mode === 'signal'
? `${formatRssi(item.bestRssi)} best`
: `Last seen ${new Date(item.lastSeen * 1000).toLocaleTimeString([], { hour: '2-digit', minute: '2-digit' })}`}
</div>
{!isNeighborIdentityResolvable(item, contacts) ? (
<div className="text-[11px] text-warning">Identity not resolvable</div>
) : null}
</div>
{mode !== 'signal' ? (
<div className="shrink-0 text-xs tabular-nums text-muted-foreground">
{mode === 'recent' ? formatRssi(item.bestRssi) : formatRssi(item.bestRssi)}
</div>
) : null}
</div>
))}
</div>
)}
</section>
);
}
function TimelineChart({ bins }: { bins: PacketTimelineBin[] }) {
const maxTotal = Math.max(...bins.map((bin) => bin.total), 1);
const typeOrder = Array.from(new Set(bins.flatMap((bin) => Object.keys(bin.countsByType)))).slice(
0,
TIMELINE_COLORS.length
);
return (
<section className="mb-4 break-inside-avoid rounded-lg border border-border/70 bg-card/70 p-3">
<div className="flex items-center justify-between gap-3">
<h3 className="text-sm font-semibold text-foreground">Traffic Timeline</h3>
<div className="flex flex-wrap justify-end gap-2 text-[11px] text-muted-foreground">
{typeOrder.map((type, index) => (
<span key={type} className="inline-flex items-center gap-1">
<span className={cn('h-2 w-2 rounded-full', TIMELINE_COLORS[index])} />
<span>{type}</span>
</span>
))}
</div>
</div>
<div className="mt-3 flex items-start gap-1">
{bins.map((bin, index) => (
<div
key={`${bin.label}-${index}`}
className="flex min-w-0 flex-1 flex-col items-center gap-1"
>
<div className="flex h-24 w-full items-end overflow-hidden rounded-sm bg-muted/60">
<div className="flex h-full w-full flex-col justify-end">
{typeOrder.map((type, index) => {
const count = bin.countsByType[type] ?? 0;
if (count === 0) return null;
return (
<div
key={type}
className={cn('w-full', TIMELINE_COLORS[index])}
style={{
height: `${(count / maxTotal) * 100}%`,
}}
title={`${bin.label}: ${type} ${count.toLocaleString()}`}
/>
);
})}
</div>
</div>
<div className="text-[10px] text-muted-foreground">{bin.label}</div>
</div>
))}
</div>
</section>
);
}
export function RawPacketFeedView({
packets,
rawPacketStatsSession,
contacts,
channels,
}: RawPacketFeedViewProps) {
const [statsOpen, setStatsOpen] = useState(() =>
typeof window !== 'undefined' && typeof window.matchMedia === 'function'
? window.matchMedia('(min-width: 768px)').matches
: false
);
const [selectedWindow, setSelectedWindow] = useState<RawPacketStatsWindow>('10m');
const [nowSec, setNowSec] = useState(() => Math.floor(Date.now() / 1000));
const [selectedPacket, setSelectedPacket] = useState<RawPacket | null>(null);
const [analyzeModalOpen, setAnalyzeModalOpen] = useState(false);
useEffect(() => {
const interval = window.setInterval(() => {
setNowSec(Math.floor(Date.now() / 1000));
}, 30000);
return () => window.clearInterval(interval);
}, []);
useEffect(() => {
setNowSec(Math.floor(Date.now() / 1000));
}, [packets, rawPacketStatsSession]);
const stats = useMemo(
() => buildRawPacketStatsSnapshot(rawPacketStatsSession, selectedWindow, nowSec),
[nowSec, rawPacketStatsSession, selectedWindow]
);
const coverageMessage = getCoverageMessage(stats, rawPacketStatsSession);
const strongestPacketDetail = useMemo(
() => formatStrongestPacketDetail(stats, contacts),
[contacts, stats]
);
const strongestNeighbors = useMemo(
() => stats.strongestNeighbors.map((item) => resolveNeighbor(item, contacts)),
[contacts, stats.strongestNeighbors]
);
const mostActiveNeighbors = useMemo(
() => stats.mostActiveNeighbors.map((item) => resolveNeighbor(item, contacts)),
[contacts, stats.mostActiveNeighbors]
);
const newestNeighbors = useMemo(
() => stats.newestNeighbors.map((item) => resolveNeighbor(item, contacts)),
[contacts, stats.newestNeighbors]
);
return (
<>
<div className="flex items-center justify-between gap-3 border-b border-border px-4 py-2.5">
<div>
<h2 className="font-semibold text-base text-foreground">Raw Packet Feed</h2>
<p className="text-xs text-muted-foreground">
Collecting stats since {formatTimestamp(rawPacketStatsSession.sessionStartedAt)}
</p>
</div>
<div className="flex items-center gap-2">
<Button
type="button"
variant="outline"
size="sm"
onClick={() => setAnalyzeModalOpen(true)}
>
Analyze Packet
</Button>
<Button
type="button"
variant="outline"
size="sm"
onClick={() => setStatsOpen((current) => !current)}
aria-expanded={statsOpen}
>
{statsOpen ? <ChevronRight className="h-4 w-4" /> : <ChevronLeft className="h-4 w-4" />}
{statsOpen ? 'Hide Stats' : 'Show Stats'}
</Button>
</div>
</div>
<div className="flex min-h-0 flex-1 flex-col md:flex-row">
<div className={cn('min-h-0 min-w-0 flex-1', statsOpen && 'md:border-r md:border-border')}>
<RawPacketList packets={packets} channels={channels} onPacketClick={setSelectedPacket} />
</div>
<aside
className={cn(
'shrink-0 overflow-hidden border-t border-border transition-all duration-300 md:border-l md:border-t-0',
statsOpen
? 'max-h-[42rem] md:max-h-none md:w-1/2 md:min-w-[30rem]'
: 'max-h-0 md:w-0 md:min-w-0 border-transparent'
)}
>
{statsOpen ? (
<div className="h-full overflow-y-auto bg-background p-4 [contain:layout_paint]">
<div className="break-inside-avoid rounded-lg border border-border/70 bg-card/70 p-3">
<div className="flex flex-wrap items-center justify-between gap-3">
<div>
<div className="text-[11px] uppercase tracking-wide text-muted-foreground">
Coverage
</div>
<div
className={cn(
'mt-1 text-sm',
coverageMessage.tone === 'warning'
? 'text-warning'
: 'text-muted-foreground'
)}
>
{coverageMessage.message}
</div>
</div>
<label className="flex items-center gap-2 text-sm text-foreground">
<span className="text-muted-foreground">Window</span>
<select
value={selectedWindow}
onChange={(event) =>
setSelectedWindow(event.target.value as RawPacketStatsWindow)
}
className="rounded-md border border-input bg-background px-2 py-1 text-sm"
aria-label="Stats window"
>
{RAW_PACKET_STATS_WINDOWS.map((option) => (
<option key={option} value={option}>
{WINDOW_LABELS[option]}
</option>
))}
</select>
</label>
</div>
<div className="mt-2 text-xs text-muted-foreground">
{stats.packetCount.toLocaleString()} packets in{' '}
{WINDOW_LABELS[selectedWindow].toLowerCase()} window
{' · '}
{rawPacketStatsSession.totalObservedPackets.toLocaleString()} observed this
session
</div>
</div>
<div className="mt-4 grid grid-cols-2 gap-3 md:grid-cols-3">
<StatTile
label="Packets / min"
value={formatRate(stats.packetsPerMinute)}
detail={`${stats.packetCount.toLocaleString()} total in window`}
/>
<StatTile
label="Unique Sources"
value={stats.uniqueSources.toLocaleString()}
detail="Distinct identified senders"
/>
<StatTile
label="Decrypt Rate"
value={formatPercent(stats.decryptRate)}
detail={`${stats.decryptedCount.toLocaleString()} decrypted / ${stats.undecryptedCount.toLocaleString()} locked`}
/>
<StatTile
label="Path Diversity"
value={stats.distinctPaths.toLocaleString()}
detail={`${formatPercent(stats.pathBearingRate)} path-bearing packets`}
/>
<StatTile
label="Best RSSI"
value={formatRssi(stats.bestRssi)}
detail={strongestPacketDetail ?? 'No signal sample in window'}
/>
<StatTile
label="Median RSSI"
value={formatRssi(stats.medianRssi)}
detail={
stats.averageRssi === null
? 'No signal sample in window'
: `Average ${formatRssi(stats.averageRssi)}`
}
/>
</div>
<div className="mt-4">
<TimelineChart bins={stats.timeline} />
</div>
<div className="md:columns-2 md:gap-4">
<RankedBars
title="Packet Types"
items={stats.payloadBreakdown}
emptyLabel="No packets in this window yet."
/>
<RankedBars
title="Route Mix"
items={stats.routeBreakdown}
emptyLabel="No packets in this window yet."
/>
<RankedBars
title="Hop Profile"
items={stats.hopProfile}
emptyLabel="No packets in this window yet."
/>
<RankedBars
title="Hop Byte Width"
items={stats.hopByteWidthProfile}
emptyLabel="No packets in this window yet."
/>
<RankedBars
title="Signal Distribution"
items={stats.rssiBuckets}
emptyLabel="No RSSI samples in this window yet."
/>
<NeighborList
title="Most-Heard Neighbors"
items={mostActiveNeighbors}
emptyLabel="No sender identities resolved in this window yet."
mode="heard"
contacts={contacts}
/>
<NeighborList
title="Strongest Recent Neighbors"
items={strongestNeighbors}
emptyLabel="No RSSI-tagged neighbors in this window yet."
mode="signal"
contacts={contacts}
/>
<NeighborList
title="Newest Heard Neighbors"
items={newestNeighbors}
emptyLabel="No newly identified neighbors in this window yet."
mode="recent"
contacts={contacts}
/>
</div>
</div>
) : null}
</aside>
</div>
<RawPacketInspectorDialog
open={selectedPacket !== null}
onOpenChange={(isOpen) => !isOpen && setSelectedPacket(null)}
channels={channels}
source={
selectedPacket
? { kind: 'packet', packet: selectedPacket }
: { kind: 'loading', message: 'Loading packet...' }
}
title="Packet Details"
description="Detailed byte and field breakdown for the selected raw packet."
/>
<RawPacketInspectorDialog
open={analyzeModalOpen}
onOpenChange={setAnalyzeModalOpen}
channels={channels}
source={{ kind: 'paste' }}
title="Analyze Packet"
description="Paste and inspect a raw packet hex string."
/>
</>
);
}
+74 -173
View File
@@ -1,11 +1,13 @@
import { useEffect, useRef, useMemo } from 'react'; import { useEffect, useRef, useMemo } from 'react';
import { MeshCoreDecoder, PayloadType, Utils } from '@michaelhart/meshcore-decoder'; import type { Channel, RawPacket } from '../types';
import type { RawPacket } from '../types';
import { getRawPacketObservationKey } from '../utils/rawPacketIdentity'; import { getRawPacketObservationKey } from '../utils/rawPacketIdentity';
import { createDecoderOptions, decodePacketSummary } from '../utils/rawPacketInspector';
import { cn } from '@/lib/utils'; import { cn } from '@/lib/utils';
interface RawPacketListProps { interface RawPacketListProps {
packets: RawPacket[]; packets: RawPacket[];
channels?: Channel[];
onPacketClick?: (packet: RawPacket) => void;
} }
function formatTime(timestamp: number): string { function formatTime(timestamp: number): string {
@@ -24,132 +26,6 @@ function formatSignalInfo(packet: RawPacket): string {
return parts.join(' | '); return parts.join(' | ');
} }
// Decrypted info from the packet (validated by backend)
interface DecryptedInfo {
channel_name: string | null;
sender: string | null;
}
// Decode a packet and generate a human-readable summary
// Uses backend's decrypted_info when available (validated), falls back to decoder
function decodePacketSummary(
hexData: string,
decryptedInfo: DecryptedInfo | null
): {
summary: string;
routeType: string;
details?: string;
} {
try {
const decoded = MeshCoreDecoder.decode(hexData);
if (!decoded.isValid) {
return { summary: 'Invalid packet', routeType: 'Unknown' };
}
const routeType = Utils.getRouteTypeName(decoded.routeType);
const payloadTypeName = Utils.getPayloadTypeName(decoded.payloadType);
const tracePayload =
decoded.payloadType === PayloadType.Trace && decoded.payload.decoded
? (decoded.payload.decoded as { pathHashes?: string[] })
: null;
const pathTokens = tracePayload?.pathHashes || decoded.path || [];
// Build path string if available
const pathStr = pathTokens.length > 0 ? ` via ${pathTokens.join('-')}` : '';
// Generate summary based on payload type
let summary = payloadTypeName;
let details: string | undefined;
switch (decoded.payloadType) {
case PayloadType.TextMessage: {
const payload = decoded.payload.decoded as {
destinationHash?: string;
sourceHash?: string;
} | null;
if (payload?.sourceHash && payload?.destinationHash) {
summary = `DM from ${payload.sourceHash} to ${payload.destinationHash}${pathStr}`;
} else {
summary = `DM${pathStr}`;
}
break;
}
case PayloadType.GroupText: {
const payload = decoded.payload.decoded as {
channelHash?: string;
} | null;
// Use backend's validated decrypted_info when available
if (decryptedInfo?.channel_name) {
if (decryptedInfo.sender) {
summary = `GT from ${decryptedInfo.sender} in ${decryptedInfo.channel_name}${pathStr}`;
} else {
summary = `GT in ${decryptedInfo.channel_name}${pathStr}`;
}
} else if (payload?.channelHash) {
// Fallback to showing channel hash when not decrypted
summary = `GT ch:${payload.channelHash}${pathStr}`;
} else {
summary = `GroupText${pathStr}`;
}
break;
}
case PayloadType.Advert: {
const payload = decoded.payload.decoded as {
publicKey?: string;
appData?: { name?: string; deviceRole?: number };
} | null;
if (payload?.appData?.name) {
const role =
payload.appData.deviceRole !== undefined
? Utils.getDeviceRoleName(payload.appData.deviceRole)
: '';
summary = `Advert: ${payload.appData.name}${role ? ` (${role})` : ''}${pathStr}`;
} else if (payload?.publicKey) {
summary = `Advert: ${payload.publicKey.slice(0, 8)}...${pathStr}`;
} else {
summary = `Advert${pathStr}`;
}
break;
}
case PayloadType.Ack: {
summary = `ACK${pathStr}`;
break;
}
case PayloadType.Request: {
summary = `Request${pathStr}`;
break;
}
case PayloadType.Response: {
summary = `Response${pathStr}`;
break;
}
case PayloadType.Trace: {
summary = `Trace${pathStr}`;
break;
}
case PayloadType.Path: {
summary = `Path${pathStr}`;
break;
}
default:
summary = `${payloadTypeName}${pathStr}`;
}
return { summary, routeType, details };
} catch {
return { summary: 'Decode error', routeType: 'Unknown' };
}
}
// Get route type badge color // Get route type badge color
function getRouteTypeColor(routeType: string): string { function getRouteTypeColor(routeType: string): string {
switch (routeType) { switch (routeType) {
@@ -182,16 +58,17 @@ function getRouteTypeLabel(routeType: string): string {
} }
} }
export function RawPacketList({ packets }: RawPacketListProps) { export function RawPacketList({ packets, channels, onPacketClick }: RawPacketListProps) {
const listRef = useRef<HTMLDivElement>(null); const listRef = useRef<HTMLDivElement>(null);
const decoderOptions = useMemo(() => createDecoderOptions(channels), [channels]);
// Decode all packets (memoized to avoid re-decoding on every render) // Decode all packets (memoized to avoid re-decoding on every render)
const decodedPackets = useMemo(() => { const decodedPackets = useMemo(() => {
return packets.map((packet) => ({ return packets.map((packet) => ({
packet, packet,
decoded: decodePacketSummary(packet.data, packet.decrypted_info), decoded: decodePacketSummary(packet, decoderOptions),
})); }));
}, [packets]); }, [decoderOptions, packets]);
// Sort packets by timestamp ascending (oldest first) // Sort packets by timestamp ascending (oldest first)
const sortedPackets = useMemo( const sortedPackets = useMemo(
@@ -218,54 +95,78 @@ export function RawPacketList({ packets }: RawPacketListProps) {
className="h-full overflow-y-auto p-4 flex flex-col gap-2 [contain:layout_paint]" className="h-full overflow-y-auto p-4 flex flex-col gap-2 [contain:layout_paint]"
ref={listRef} ref={listRef}
> >
{sortedPackets.map(({ packet, decoded }) => ( {sortedPackets.map(({ packet, decoded }) => {
<div const cardContent = (
key={getRawPacketObservationKey(packet)} <>
className="py-2 px-3 bg-card rounded-md border border-border/50" <div className="flex items-center gap-2">
> {/* Route type badge */}
<div className="flex items-center gap-2"> <span
{/* Route type badge */} className={`text-[10px] font-mono px-1.5 py-0.5 rounded ${getRouteTypeColor(decoded.routeType)}`}
<span title={decoded.routeType}
className={`text-[10px] font-mono px-1.5 py-0.5 rounded ${getRouteTypeColor(decoded.routeType)}`} >
title={decoded.routeType} {getRouteTypeLabel(decoded.routeType)}
> </span>
{getRouteTypeLabel(decoded.routeType)}
</span>
{/* Encryption status */} {/* Encryption status */}
{!packet.decrypted && ( {!packet.decrypted && (
<> <>
<span aria-hidden="true">🔒</span> <span aria-hidden="true">🔒</span>
<span className="sr-only">Encrypted</span> <span className="sr-only">Encrypted</span>
</> </>
)}
{/* Summary */}
<span
className={cn('text-[13px]', packet.decrypted ? 'text-primary' : 'text-foreground')}
>
{decoded.summary}
</span>
{/* Time */}
<span className="text-muted-foreground ml-auto text-[12px] tabular-nums">
{formatTime(packet.timestamp)}
</span>
</div>
{/* Signal info */}
{(packet.snr !== null || packet.rssi !== null) && (
<div className="text-[11px] text-muted-foreground mt-0.5 tabular-nums">
{formatSignalInfo(packet)}
</div>
)} )}
{/* Summary */} {/* Raw hex data (always visible) */}
<span <div className="font-mono text-[10px] break-all text-muted-foreground mt-1.5 p-1.5 bg-background/60 rounded">
className={cn('text-[13px]', packet.decrypted ? 'text-primary' : 'text-foreground')} {packet.data.toUpperCase()}
>
{decoded.summary}
</span>
{/* Time */}
<span className="text-muted-foreground ml-auto text-[12px] tabular-nums">
{formatTime(packet.timestamp)}
</span>
</div>
{/* Signal info */}
{(packet.snr !== null || packet.rssi !== null) && (
<div className="text-[11px] text-muted-foreground mt-0.5 tabular-nums">
{formatSignalInfo(packet)}
</div> </div>
)} </>
);
{/* Raw hex data (always visible) */} const className = cn(
<div className="font-mono text-[10px] break-all text-muted-foreground mt-1.5 p-1.5 bg-background/60 rounded"> 'rounded-md border border-border/50 bg-card px-3 py-2 text-left',
{packet.data.toUpperCase()} onPacketClick &&
'cursor-pointer transition-colors hover:bg-accent/40 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring'
);
if (onPacketClick) {
return (
<button
key={getRawPacketObservationKey(packet)}
type="button"
onClick={() => onPacketClick(packet)}
className={className}
>
{cardContent}
</button>
);
}
return (
<div key={getRawPacketObservationKey(packet)} className={className}>
{cardContent}
</div> </div>
</div> );
))} })}
</div> </div>
); );
} }
+43 -10
View File
@@ -5,12 +5,15 @@ import { Button } from './ui/button';
import { Bell, Route, Star, Trash2 } from 'lucide-react'; import { Bell, Route, Star, Trash2 } from 'lucide-react';
import { DirectTraceIcon } from './DirectTraceIcon'; import { DirectTraceIcon } from './DirectTraceIcon';
import { RepeaterLogin } from './RepeaterLogin'; import { RepeaterLogin } from './RepeaterLogin';
import { ServerLoginStatusBanner } from './ServerLoginStatusBanner';
import { useRememberedServerPassword } from '../hooks/useRememberedServerPassword';
import { useRepeaterDashboard } from '../hooks/useRepeaterDashboard'; import { useRepeaterDashboard } from '../hooks/useRepeaterDashboard';
import { isFavorite } from '../utils/favorites'; import { isFavorite } from '../utils/favorites';
import { handleKeyboardActivate } from '../utils/a11y'; import { handleKeyboardActivate } from '../utils/a11y';
import { isValidLocation } from '../utils/pathUtils'; import { isValidLocation } from '../utils/pathUtils';
import { ContactStatusInfo } from './ContactStatusInfo'; import { ContactStatusInfo } from './ContactStatusInfo';
import type { Contact, Conversation, Favorite, PathDiscoveryResponse } from '../types'; import type { Contact, Conversation, Favorite, PathDiscoveryResponse } from '../types';
import { cn } from '../lib/utils';
import { TelemetryPane } from './repeater/RepeaterTelemetryPane'; import { TelemetryPane } from './repeater/RepeaterTelemetryPane';
import { NeighborsPane } from './repeater/RepeaterNeighborsPane'; import { NeighborsPane } from './repeater/RepeaterNeighborsPane';
import { AclPane } from './repeater/RepeaterAclPane'; import { AclPane } from './repeater/RepeaterAclPane';
@@ -67,6 +70,7 @@ export function RepeaterDashboard({
loggedIn, loggedIn,
loginLoading, loginLoading,
loginError, loginError,
lastLoginAttempt,
paneData, paneData,
paneStates, paneStates,
consoleHistory, consoleHistory,
@@ -81,8 +85,18 @@ export function RepeaterDashboard({
rebootRepeater, rebootRepeater,
syncClock, syncClock,
} = useRepeaterDashboard(conversation, { hasAdvertLocation }); } = useRepeaterDashboard(conversation, { hasAdvertLocation });
const { password, setPassword, rememberPassword, setRememberPassword, persistAfterLogin } =
useRememberedServerPassword('repeater', conversation.id);
const isFav = isFavorite(favorites, 'contact', conversation.id); const isFav = isFavorite(favorites, 'contact', conversation.id);
const handleRepeaterLogin = async (nextPassword: string) => {
await login(nextPassword);
persistAfterLogin(nextPassword);
};
const handleRepeaterGuestLogin = async () => {
await loginAsGuest();
persistAfterLogin('');
};
// Loading all panes indicator // Loading all panes indicator
const anyLoading = Object.values(paneStates).some((s) => s.loading); const anyLoading = Object.values(paneStates).some((s) => s.loading);
@@ -90,8 +104,15 @@ export function RepeaterDashboard({
return ( return (
<div className="flex-1 flex flex-col min-h-0"> <div className="flex-1 flex flex-col min-h-0">
{/* Header */} {/* Header */}
<header className="flex justify-between items-start px-4 py-2.5 border-b border-border gap-2"> <header
<span className="flex min-w-0 flex-1 flex-col"> className={cn(
'grid items-start gap-x-2 gap-y-0.5 border-b border-border px-4 py-2.5',
contact
? 'grid-cols-[minmax(0,1fr)_auto] min-[1100px]:grid-cols-[minmax(0,1fr)_auto_auto]'
: 'grid-cols-[minmax(0,1fr)_auto]'
)}
>
<span className="flex min-w-0 flex-col">
<span className="flex min-w-0 flex-wrap items-baseline gap-x-2 gap-y-0.5"> <span className="flex min-w-0 flex-wrap items-baseline gap-x-2 gap-y-0.5">
<span className="flex min-w-0 flex-1 items-baseline gap-2"> <span className="flex min-w-0 flex-1 items-baseline gap-2">
<span className="min-w-0 flex-shrink truncate font-semibold text-base"> <span className="min-w-0 flex-shrink truncate font-semibold text-base">
@@ -111,14 +132,14 @@ export function RepeaterDashboard({
{conversation.id} {conversation.id}
</span> </span>
</span> </span>
{contact && (
<span className="min-w-0 flex-none text-[11px] text-muted-foreground max-sm:basis-full">
<ContactStatusInfo contact={contact} ourLat={radioLat} ourLon={radioLon} />
</span>
)}
</span> </span>
</span> </span>
<div className="flex items-center gap-0.5 flex-shrink-0"> {contact && (
<div className="col-span-2 row-start-2 min-w-0 text-[11px] text-muted-foreground min-[1100px]:col-span-1 min-[1100px]:col-start-2 min-[1100px]:row-start-1">
<ContactStatusInfo contact={contact} ourLat={radioLat} ourLon={radioLon} />
</div>
)}
<div className="flex items-center gap-0.5">
{loggedIn && ( {loggedIn && (
<Button <Button
variant="outline" variant="outline"
@@ -221,11 +242,23 @@ export function RepeaterDashboard({
repeaterName={conversation.name} repeaterName={conversation.name}
loading={loginLoading} loading={loginLoading}
error={loginError} error={loginError}
onLogin={login} password={password}
onLoginAsGuest={loginAsGuest} onPasswordChange={setPassword}
rememberPassword={rememberPassword}
onRememberPasswordChange={setRememberPassword}
onLogin={handleRepeaterLogin}
onLoginAsGuest={handleRepeaterGuestLogin}
/> />
) : ( ) : (
<div className="space-y-4"> <div className="space-y-4">
<ServerLoginStatusBanner
attempt={lastLoginAttempt}
loading={loginLoading}
canRetryPassword={password.trim().length > 0}
onRetryPassword={() => handleRepeaterLogin(password)}
onRetryBlank={handleRepeaterGuestLogin}
blankRetryLabel="Retry Existing-Access Login"
/>
{/* Top row: Telemetry + Radio Settings | Node Info + Neighbors */} {/* Top row: Telemetry + Radio Settings | Node Info + Neighbors */}
<div className="grid grid-cols-1 gap-4 md:grid-cols-2 md:items-stretch"> <div className="grid grid-cols-1 gap-4 md:grid-cols-2 md:items-stretch">
<div className="flex flex-col gap-4"> <div className="flex flex-col gap-4">
+44 -8
View File
@@ -1,24 +1,39 @@
import { useState, useCallback, type FormEvent } from 'react'; import { useCallback, type FormEvent } from 'react';
import { Input } from './ui/input'; import { Input } from './ui/input';
import { Button } from './ui/button'; import { Button } from './ui/button';
import { Checkbox } from './ui/checkbox';
interface RepeaterLoginProps { interface RepeaterLoginProps {
repeaterName: string; repeaterName: string;
loading: boolean; loading: boolean;
error: string | null; error: string | null;
password: string;
onPasswordChange: (password: string) => void;
rememberPassword: boolean;
onRememberPasswordChange: (checked: boolean) => void;
onLogin: (password: string) => Promise<void>; onLogin: (password: string) => Promise<void>;
onLoginAsGuest: () => Promise<void>; onLoginAsGuest: () => Promise<void>;
description?: string;
passwordPlaceholder?: string;
loginLabel?: string;
guestLabel?: string;
} }
export function RepeaterLogin({ export function RepeaterLogin({
repeaterName, repeaterName,
loading, loading,
error, error,
password,
onPasswordChange,
rememberPassword,
onRememberPasswordChange,
onLogin, onLogin,
onLoginAsGuest, onLoginAsGuest,
description = 'Log in to access repeater dashboard',
passwordPlaceholder = 'Repeater password...',
loginLabel = 'Login with Password',
guestLabel = 'Login as Guest / ACLs',
}: RepeaterLoginProps) { }: RepeaterLoginProps) {
const [password, setPassword] = useState('');
const handleSubmit = useCallback( const handleSubmit = useCallback(
async (e: FormEvent) => { async (e: FormEvent) => {
e.preventDefault(); e.preventDefault();
@@ -33,7 +48,7 @@ export function RepeaterLogin({
<div className="w-full max-w-sm space-y-6"> <div className="w-full max-w-sm space-y-6">
<div className="text-center space-y-1"> <div className="text-center space-y-1">
<h2 className="text-lg font-semibold">{repeaterName}</h2> <h2 className="text-lg font-semibold">{repeaterName}</h2>
<p className="text-sm text-muted-foreground">Log in to access repeater dashboard</p> <p className="text-sm text-muted-foreground">{description}</p>
</div> </div>
<form onSubmit={handleSubmit} className="space-y-4" autoComplete="off"> <form onSubmit={handleSubmit} className="space-y-4" autoComplete="off">
@@ -45,13 +60,34 @@ export function RepeaterLogin({
data-1p-ignore="true" data-1p-ignore="true"
data-bwignore="true" data-bwignore="true"
value={password} value={password}
onChange={(e) => setPassword(e.target.value)} onChange={(e) => onPasswordChange(e.target.value)}
placeholder="Repeater password..." placeholder={passwordPlaceholder}
aria-label="Repeater password" aria-label="Repeater password"
disabled={loading} disabled={loading}
autoFocus autoFocus
/> />
<label
htmlFor="remember-server-password"
className="flex items-center gap-2 text-sm text-muted-foreground"
>
<Checkbox
id="remember-server-password"
checked={rememberPassword}
disabled={loading}
onCheckedChange={(checked) => onRememberPasswordChange(checked === true)}
/>
<span>Remember password</span>
</label>
{rememberPassword && (
<p className="text-xs text-muted-foreground">
Passwords are stored unencrypted in local browser storage for this domain. It is
highly recommended to login via ACLs after your first successful login; saving the
password is not recommended.
</p>
)}
{error && ( {error && (
<p className="text-sm text-destructive text-center" role="alert"> <p className="text-sm text-destructive text-center" role="alert">
{error} {error}
@@ -60,7 +96,7 @@ export function RepeaterLogin({
<div className="flex flex-col gap-2"> <div className="flex flex-col gap-2">
<Button type="submit" disabled={loading} className="w-full"> <Button type="submit" disabled={loading} className="w-full">
{loading ? 'Logging in...' : 'Login with Password'} {loading ? 'Logging in...' : loginLabel}
</Button> </Button>
<Button <Button
type="button" type="button"
@@ -69,7 +105,7 @@ export function RepeaterLogin({
className="w-full" className="w-full"
onClick={onLoginAsGuest} onClick={onLoginAsGuest}
> >
Login as Guest / ACLs {guestLabel}
</Button> </Button>
</div> </div>
</form> </form>
+357
View File
@@ -0,0 +1,357 @@
import { useCallback, useEffect, useMemo, useState } from 'react';
import { api } from '../api';
import { toast } from './ui/sonner';
import { Button } from './ui/button';
import { Sheet, SheetContent, SheetDescription, SheetHeader, SheetTitle } from './ui/sheet';
import type {
Contact,
PaneState,
RepeaterAclResponse,
RepeaterLppTelemetryResponse,
RepeaterStatusResponse,
} from '../types';
import { TelemetryPane } from './repeater/RepeaterTelemetryPane';
import { AclPane } from './repeater/RepeaterAclPane';
import { LppTelemetryPane } from './repeater/RepeaterLppTelemetryPane';
import { ConsolePane } from './repeater/RepeaterConsolePane';
import { RepeaterLogin } from './RepeaterLogin';
import { ServerLoginStatusBanner } from './ServerLoginStatusBanner';
import { useRememberedServerPassword } from '../hooks/useRememberedServerPassword';
import {
buildServerLoginAttemptFromError,
buildServerLoginAttemptFromResponse,
type ServerLoginAttemptState,
} from '../utils/serverLoginState';
interface RoomServerPanelProps {
contact: Contact;
onAuthenticatedChange?: (authenticated: boolean) => void;
}
type RoomPaneKey = 'status' | 'acl' | 'lppTelemetry';
type RoomPaneData = {
status: RepeaterStatusResponse | null;
acl: RepeaterAclResponse | null;
lppTelemetry: RepeaterLppTelemetryResponse | null;
};
type RoomPaneStates = Record<RoomPaneKey, PaneState>;
type ConsoleEntry = {
command: string;
response: string;
timestamp: number;
outgoing: boolean;
};
const INITIAL_PANE_STATE: PaneState = {
loading: false,
attempt: 0,
error: null,
fetched_at: null,
};
function createInitialPaneStates(): RoomPaneStates {
return {
status: { ...INITIAL_PANE_STATE },
acl: { ...INITIAL_PANE_STATE },
lppTelemetry: { ...INITIAL_PANE_STATE },
};
}
export function RoomServerPanel({ contact, onAuthenticatedChange }: RoomServerPanelProps) {
const { password, setPassword, rememberPassword, setRememberPassword, persistAfterLogin } =
useRememberedServerPassword('room', contact.public_key);
const [loginLoading, setLoginLoading] = useState(false);
const [loginError, setLoginError] = useState<string | null>(null);
const [authenticated, setAuthenticated] = useState(false);
const [lastLoginAttempt, setLastLoginAttempt] = useState<ServerLoginAttemptState | null>(null);
const [advancedOpen, setAdvancedOpen] = useState(false);
const [paneData, setPaneData] = useState<RoomPaneData>({
status: null,
acl: null,
lppTelemetry: null,
});
const [paneStates, setPaneStates] = useState<RoomPaneStates>(createInitialPaneStates);
const [consoleHistory, setConsoleHistory] = useState<ConsoleEntry[]>([]);
const [consoleLoading, setConsoleLoading] = useState(false);
useEffect(() => {
setLoginLoading(false);
setLoginError(null);
setAuthenticated(false);
setLastLoginAttempt(null);
setAdvancedOpen(false);
setPaneData({
status: null,
acl: null,
lppTelemetry: null,
});
setPaneStates(createInitialPaneStates());
setConsoleHistory([]);
setConsoleLoading(false);
}, [contact.public_key]);
useEffect(() => {
onAuthenticatedChange?.(authenticated);
}, [authenticated, onAuthenticatedChange]);
const refreshPane = useCallback(
async <K extends RoomPaneKey>(pane: K, loader: () => Promise<RoomPaneData[K]>) => {
setPaneStates((prev) => ({
...prev,
[pane]: {
...prev[pane],
loading: true,
attempt: prev[pane].attempt + 1,
error: null,
},
}));
try {
const data = await loader();
setPaneData((prev) => ({ ...prev, [pane]: data }));
setPaneStates((prev) => ({
...prev,
[pane]: {
loading: false,
attempt: prev[pane].attempt,
error: null,
fetched_at: Date.now(),
},
}));
} catch (err) {
setPaneStates((prev) => ({
...prev,
[pane]: {
...prev[pane],
loading: false,
error: err instanceof Error ? err.message : 'Unknown error',
},
}));
}
},
[]
);
const performLogin = useCallback(
async (nextPassword: string, method: 'password' | 'blank') => {
if (loginLoading) return;
setLoginLoading(true);
setLoginError(null);
try {
const result = await api.roomLogin(contact.public_key, nextPassword);
setLastLoginAttempt(buildServerLoginAttemptFromResponse(method, result, 'room server'));
setAuthenticated(true);
if (result.authenticated) {
toast.success('Login confirmed by the room server.');
} else {
toast.warning("Couldn't confirm room login", {
description:
result.message ??
'No confirmation came back from the room server. You can still open tools and try again.',
});
}
} catch (err) {
const message = err instanceof Error ? err.message : 'Unknown error';
setLastLoginAttempt(buildServerLoginAttemptFromError(method, message, 'room server'));
setAuthenticated(true);
setLoginError(message);
toast.error('Room login request failed', {
description: `${message}. You can still open tools and retry the login from here.`,
});
} finally {
setLoginLoading(false);
}
},
[contact.public_key, loginLoading]
);
const handleLogin = useCallback(
async (nextPassword: string) => {
await performLogin(nextPassword, 'password');
persistAfterLogin(nextPassword);
},
[performLogin, persistAfterLogin]
);
const handleLoginAsGuest = useCallback(async () => {
await performLogin('', 'blank');
persistAfterLogin('');
}, [performLogin, persistAfterLogin]);
const handleConsoleCommand = useCallback(
async (command: string) => {
setConsoleLoading(true);
const timestamp = Date.now();
setConsoleHistory((prev) => [
...prev,
{ command, response: command, timestamp, outgoing: true },
]);
try {
const response = await api.sendRepeaterCommand(contact.public_key, command);
setConsoleHistory((prev) => [
...prev,
{
command,
response: response.response,
timestamp: Date.now(),
outgoing: false,
},
]);
} catch (err) {
const message = err instanceof Error ? err.message : 'Unknown error';
setConsoleHistory((prev) => [
...prev,
{
command,
response: `(error) ${message}`,
timestamp: Date.now(),
outgoing: false,
},
]);
} finally {
setConsoleLoading(false);
}
},
[contact.public_key]
);
const panelTitle = useMemo(() => contact.name || contact.public_key.slice(0, 12), [contact]);
const showLoginFailureState =
lastLoginAttempt !== null && lastLoginAttempt.outcome !== 'confirmed';
if (!authenticated) {
return (
<div className="flex-1 overflow-y-auto p-4">
<div className="mx-auto flex w-full max-w-sm flex-col gap-4">
<div className="rounded-md border border-warning/30 bg-warning/10 px-4 py-3 text-sm text-warning">
Room server access is experimental and in public alpha. Please report any issues on{' '}
<a
href="https://github.com/jkingsman/Remote-Terminal-for-MeshCore/issues"
target="_blank"
rel="noreferrer"
className="font-medium underline underline-offset-2 hover:text-warning/80"
>
GitHub
</a>
.
</div>
<RepeaterLogin
repeaterName={panelTitle}
loading={loginLoading}
error={loginError}
password={password}
onPasswordChange={setPassword}
rememberPassword={rememberPassword}
onRememberPasswordChange={setRememberPassword}
onLogin={handleLogin}
onLoginAsGuest={handleLoginAsGuest}
description="Log in with the room password or use ACL/guest access to enter this room server"
passwordPlaceholder="Room server password..."
guestLabel="Login with Existing Access / Guest"
/>
</div>
</div>
);
}
return (
<section className="border-b border-border bg-muted/20 px-4 py-3">
<div className="space-y-3">
{showLoginFailureState ? (
<ServerLoginStatusBanner
attempt={lastLoginAttempt}
loading={loginLoading}
canRetryPassword={password.trim().length > 0}
onRetryPassword={() => handleLogin(password)}
onRetryBlank={handleLoginAsGuest}
blankRetryLabel="Retry Existing-Access Login"
showRetryActions={false}
/>
) : null}
<div className="flex flex-wrap items-center justify-between gap-2">
{showLoginFailureState ? (
<div className="flex flex-wrap gap-2">
<Button
type="button"
variant="outline"
size="sm"
onClick={() => void handleLogin(password)}
disabled={loginLoading || password.trim().length === 0}
>
Retry Password Login
</Button>
<Button
type="button"
variant="outline"
size="sm"
onClick={handleLoginAsGuest}
disabled={loginLoading}
>
Retry Existing-Access Login
</Button>
</div>
) : (
<div />
)}
<Button
type="button"
variant="outline"
size="sm"
onClick={() => setAdvancedOpen((prev) => !prev)}
>
{advancedOpen ? 'Hide Tools' : 'Show Tools'}
</Button>
</div>
</div>
<Sheet open={advancedOpen} onOpenChange={setAdvancedOpen}>
<SheetContent side="right" className="w-full sm:max-w-4xl p-0 flex flex-col">
<SheetHeader className="sr-only">
<SheetTitle>Room Server Tools</SheetTitle>
<SheetDescription>
Room server telemetry, ACL tools, sensor data, and CLI console
</SheetDescription>
</SheetHeader>
<div className="border-b border-border px-4 py-3 pr-14">
<div className="flex flex-col gap-3 sm:flex-row sm:items-center sm:justify-between">
<div className="min-w-0">
<h2 className="truncate text-base font-semibold">Room Server Tools</h2>
<p className="text-sm text-muted-foreground">{panelTitle}</p>
</div>
</div>
</div>
<div className="flex-1 overflow-y-auto p-4">
<div className="grid gap-3 xl:grid-cols-2">
<TelemetryPane
data={paneData.status}
state={paneStates.status}
onRefresh={() => refreshPane('status', () => api.roomStatus(contact.public_key))}
/>
<AclPane
data={paneData.acl}
state={paneStates.acl}
onRefresh={() => refreshPane('acl', () => api.roomAcl(contact.public_key))}
/>
<LppTelemetryPane
data={paneData.lppTelemetry}
state={paneStates.lppTelemetry}
onRefresh={() =>
refreshPane('lppTelemetry', () => api.roomLppTelemetry(contact.public_key))
}
/>
<ConsolePane
history={consoleHistory}
loading={consoleLoading}
onSend={handleConsoleCommand}
/>
</div>
</div>
</SheetContent>
</Sheet>
</section>
);
}
@@ -0,0 +1,181 @@
import { useEffect, useState } from 'react';
import { AlertTriangle } from 'lucide-react';
import { api } from '../api';
import type { HealthStatus } from '../types';
import { Button } from './ui/button';
import { Checkbox } from './ui/checkbox';
import { Dialog, DialogContent, DialogDescription, DialogHeader, DialogTitle } from './ui/dialog';
import { toast } from './ui/sonner';
const STORAGE_KEY = 'meshcore_security_warning_acknowledged';
function readAcknowledgedState(): boolean {
if (typeof window === 'undefined') {
return false;
}
try {
return window.localStorage.getItem(STORAGE_KEY) === 'true';
} catch {
return false;
}
}
function writeAcknowledgedState(): void {
if (typeof window === 'undefined') {
return;
}
try {
window.localStorage.setItem(STORAGE_KEY, 'true');
} catch {
// Best effort only; the warning will continue to show if localStorage is unavailable.
}
}
interface SecurityWarningModalProps {
health: HealthStatus | null;
}
export function SecurityWarningModal({ health }: SecurityWarningModalProps) {
const [acknowledged, setAcknowledged] = useState(readAcknowledgedState);
const [confirmedRisk, setConfirmedRisk] = useState(false);
const [disablingBots, setDisablingBots] = useState(false);
const [botsDisabledLocally, setBotsDisabledLocally] = useState(false);
const shouldWarn =
health !== null &&
health.bots_disabled !== true &&
health.basic_auth_enabled !== true &&
!botsDisabledLocally &&
!acknowledged;
useEffect(() => {
if (!shouldWarn) {
setConfirmedRisk(false);
}
}, [shouldWarn]);
useEffect(() => {
if (health?.bots_disabled !== true) {
setBotsDisabledLocally(false);
}
}, [health?.bots_disabled, health?.bots_disabled_source]);
if (!shouldWarn) {
return null;
}
return (
<Dialog open>
<DialogContent
hideCloseButton
className="w-[calc(100vw-1rem)] max-w-[42rem] gap-5 overflow-y-auto px-4 py-5 max-h-[calc(100dvh-2rem)] sm:w-full sm:max-h-[min(85dvh,48rem)] sm:px-6"
onEscapeKeyDown={(event) => event.preventDefault()}
onInteractOutside={(event) => event.preventDefault()}
>
<DialogHeader className="space-y-0 text-left">
<div className="flex items-center gap-3">
<div className="inline-flex h-11 w-11 shrink-0 items-center justify-center rounded-full border border-destructive/30 bg-destructive/10 text-destructive">
<AlertTriangle className="h-5 w-5" aria-hidden="true" />
</div>
<DialogTitle className="leading-tight">
Unprotected bot execution is enabled
</DialogTitle>
</div>
</DialogHeader>
<hr className="border-border" />
<div className="space-y-3 break-words text-sm leading-6 text-muted-foreground">
<DialogDescription>
Bots are not disabled, and app-wide Basic Auth is not configured.
</DialogDescription>
<p>
Without one of those protections, or another access-control layer in front of
RemoteTerm, anyone on your local network who can reach this app can run Python code on
the computer hosting this instance via the bot system.
</p>
<p className="font-semibold text-foreground">
This is only safe on protected or isolated networks with appropriate access control. If
your network is untrusted or later compromised, this setup may expose the host system to
arbitrary code execution.
</p>
<p>
To reduce that risk, run the server with environment variables to either disable bots
with{' '}
<code className="break-all rounded bg-muted px-1 py-0.5 text-foreground">
MESHCORE_DISABLE_BOTS=true
</code>{' '}
or enable the built-in login with{' '}
<code className="break-all rounded bg-muted px-1 py-0.5 text-foreground">
MESHCORE_BASIC_AUTH_USERNAME
</code>{' '}
/{' '}
<code className="break-all rounded bg-muted px-1 py-0.5 text-foreground">
MESHCORE_BASIC_AUTH_PASSWORD
</code>
. Another external auth or access-control system is also acceptable.
</p>
<p>
If you just want a temporary safety measure while you learn the system, you can use the
button below to disable bots until the server restarts. That is only a temporary guard;
permanent protection through Basic Auth or env-based bot disablement is still
encouraged.
</p>
</div>
<div className="space-y-2">
<Button
type="button"
className="h-auto w-full whitespace-normal py-3 text-center"
disabled={disablingBots}
onClick={async () => {
setDisablingBots(true);
try {
await api.disableBotsUntilRestart();
setBotsDisabledLocally(true);
toast.success('Bots disabled until restart');
} catch (err) {
toast.error('Failed to disable bots', {
description: err instanceof Error ? err.message : undefined,
});
} finally {
setDisablingBots(false);
}
}}
>
{disablingBots ? 'Disabling Bots...' : 'Disable Bots Until Server Restart'}
</Button>
</div>
<div className="space-y-3 rounded-md border border-input bg-muted/20 p-4">
<label className="flex items-start gap-3">
<Checkbox
checked={confirmedRisk}
onCheckedChange={(checked) => setConfirmedRisk(checked === true)}
aria-label="Acknowledge bot security risk"
className="mt-0.5"
/>
<span className="text-sm leading-6 text-foreground">
I understand that continuing with my existing security setup may put me at risk on
untrusted networks or if my home network is compromised.
</span>
</label>
<Button
type="button"
className="h-auto w-full whitespace-normal py-3 text-center"
variant="outline"
disabled={!confirmedRisk || disablingBots}
onClick={() => {
writeAcknowledgedState();
setAcknowledged(true);
}}
>
Do Not Warn Me On This Device Again
</Button>
</div>
</DialogContent>
</Dialog>
);
}
@@ -0,0 +1,76 @@
import { Button } from './ui/button';
import type { ServerLoginAttemptState } from '../utils/serverLoginState';
import { getServerLoginAttemptTone } from '../utils/serverLoginState';
import { cn } from '../lib/utils';
interface ServerLoginStatusBannerProps {
attempt: ServerLoginAttemptState | null;
loading: boolean;
canRetryPassword: boolean;
onRetryPassword: () => Promise<void> | void;
onRetryBlank: () => Promise<void> | void;
passwordRetryLabel?: string;
blankRetryLabel?: string;
showRetryActions?: boolean;
}
export function ServerLoginStatusBanner({
attempt,
loading,
canRetryPassword,
onRetryPassword,
onRetryBlank,
passwordRetryLabel = 'Retry Password Login',
blankRetryLabel = 'Retry Existing-Access Login',
showRetryActions = true,
}: ServerLoginStatusBannerProps) {
if (attempt?.outcome === 'confirmed') {
return null;
}
const tone = getServerLoginAttemptTone(attempt);
const shouldShowActions = showRetryActions;
const toneClassName =
tone === 'success'
? 'border-success/30 bg-success/10 text-success'
: tone === 'warning'
? 'border-warning/30 bg-warning/10 text-warning'
: tone === 'destructive'
? 'border-destructive/30 bg-destructive/10 text-destructive'
: 'border-border bg-muted/40 text-foreground';
return (
<div className={cn('rounded-md border px-4 py-3', toneClassName)}>
<div className="flex flex-col gap-3 sm:flex-row sm:items-start sm:justify-between">
<div className="min-w-0 space-y-1">
<p className="text-sm font-medium">
{attempt?.summary ?? 'No server login attempt has been recorded in this view yet.'}
</p>
{attempt?.details && <p className="text-xs opacity-90">{attempt.details}</p>}
</div>
{shouldShowActions ? (
<div className="flex flex-wrap gap-2">
<Button
type="button"
variant="outline"
size="sm"
onClick={() => void onRetryPassword()}
disabled={loading || !canRetryPassword}
>
{passwordRetryLabel}
</Button>
<Button
type="button"
variant="outline"
size="sm"
onClick={() => void onRetryBlank()}
disabled={loading}
>
{blankRetryLabel}
</Button>
</div>
) : null}
</div>
</div>
);
}
+2 -2
View File
@@ -147,8 +147,8 @@ export function SettingsModal(props: SettingsModalProps) {
: 'mx-auto w-full max-w-[800px] space-y-4 border-t border-input p-4'; : 'mx-auto w-full max-w-[800px] space-y-4 border-t border-input p-4';
const settingsContainerClass = externalDesktopSidebarMode const settingsContainerClass = externalDesktopSidebarMode
? 'w-full h-full overflow-y-auto' ? 'w-full h-full min-w-0 overflow-x-hidden overflow-y-auto [contain:layout_paint]'
: 'w-full h-full overflow-y-auto space-y-3'; : 'w-full h-full min-w-0 overflow-x-hidden overflow-y-auto space-y-3 [contain:layout_paint]';
const sectionButtonClasses = const sectionButtonClasses =
'w-full flex items-center justify-between px-4 py-3 text-left hover:bg-muted/40 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-inset'; 'w-full flex items-center justify-between px-4 py-3 text-left hover:bg-muted/40 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-inset';
+190 -103
View File
@@ -13,6 +13,7 @@ import {
X, X,
} from 'lucide-react'; } from 'lucide-react';
import { import {
CONTACT_TYPE_ROOM,
CONTACT_TYPE_REPEATER, CONTACT_TYPE_REPEATER,
type Contact, type Contact,
type Channel, type Channel,
@@ -57,6 +58,7 @@ type CollapseState = {
favorites: boolean; favorites: boolean;
channels: boolean; channels: boolean;
contacts: boolean; contacts: boolean;
rooms: boolean;
repeaters: boolean; repeaters: boolean;
}; };
@@ -67,6 +69,7 @@ const DEFAULT_COLLAPSE_STATE: CollapseState = {
favorites: false, favorites: false,
channels: false, channels: false,
contacts: false, contacts: false,
rooms: false,
repeaters: false, repeaters: false,
}; };
@@ -80,6 +83,7 @@ function loadCollapsedState(): CollapseState {
favorites: parsed.favorites ?? DEFAULT_COLLAPSE_STATE.favorites, favorites: parsed.favorites ?? DEFAULT_COLLAPSE_STATE.favorites,
channels: parsed.channels ?? DEFAULT_COLLAPSE_STATE.channels, channels: parsed.channels ?? DEFAULT_COLLAPSE_STATE.channels,
contacts: parsed.contacts ?? DEFAULT_COLLAPSE_STATE.contacts, contacts: parsed.contacts ?? DEFAULT_COLLAPSE_STATE.contacts,
rooms: parsed.rooms ?? DEFAULT_COLLAPSE_STATE.rooms,
repeaters: parsed.repeaters ?? DEFAULT_COLLAPSE_STATE.repeaters, repeaters: parsed.repeaters ?? DEFAULT_COLLAPSE_STATE.repeaters,
}; };
} catch { } catch {
@@ -157,6 +161,7 @@ export function Sidebar({
const [favoritesCollapsed, setFavoritesCollapsed] = useState(initialCollapsedState.favorites); const [favoritesCollapsed, setFavoritesCollapsed] = useState(initialCollapsedState.favorites);
const [channelsCollapsed, setChannelsCollapsed] = useState(initialCollapsedState.channels); const [channelsCollapsed, setChannelsCollapsed] = useState(initialCollapsedState.channels);
const [contactsCollapsed, setContactsCollapsed] = useState(initialCollapsedState.contacts); const [contactsCollapsed, setContactsCollapsed] = useState(initialCollapsedState.contacts);
const [roomsCollapsed, setRoomsCollapsed] = useState(initialCollapsedState.rooms);
const [repeatersCollapsed, setRepeatersCollapsed] = useState(initialCollapsedState.repeaters); const [repeatersCollapsed, setRepeatersCollapsed] = useState(initialCollapsedState.repeaters);
const collapseSnapshotRef = useRef<CollapseState | null>(null); const collapseSnapshotRef = useRef<CollapseState | null>(null);
const sectionSortSourceRef = useRef(initialSectionSortState.source); const sectionSortSourceRef = useRef(initialSectionSortState.source);
@@ -314,16 +319,61 @@ export function Sidebar({
[getContactHeardTime] [getContactHeardTime]
); );
const getFavoriteItemName = useCallback(
(item: FavoriteItem) =>
item.type === 'channel'
? item.channel.name
: getContactDisplayName(
item.contact.name,
item.contact.public_key,
item.contact.last_advert
),
[]
);
const sortFavoriteItemsByOrder = useCallback(
(items: FavoriteItem[], order: SortOrder) =>
[...items].sort((a, b) => {
if (order === 'recent') {
const timeA =
a.type === 'channel'
? getLastMessageTime('channel', a.channel.key)
: getContactRecentTime(a.contact);
const timeB =
b.type === 'channel'
? getLastMessageTime('channel', b.channel.key)
: getContactRecentTime(b.contact);
if (timeA && timeB) return timeB - timeA;
if (timeA && !timeB) return -1;
if (!timeA && timeB) return 1;
}
return getFavoriteItemName(a).localeCompare(getFavoriteItemName(b));
}),
[getContactRecentTime, getFavoriteItemName, getLastMessageTime]
);
// Split non-repeater contacts and repeater contacts into separate sorted lists // Split non-repeater contacts and repeater contacts into separate sorted lists
const sortedNonRepeaterContacts = useMemo( const sortedNonRepeaterContacts = useMemo(
() => () =>
sortContactsByOrder( sortContactsByOrder(
uniqueContacts.filter((c) => c.type !== CONTACT_TYPE_REPEATER), uniqueContacts.filter(
(c) => c.type !== CONTACT_TYPE_REPEATER && c.type !== CONTACT_TYPE_ROOM
),
sectionSortOrders.contacts sectionSortOrders.contacts
), ),
[uniqueContacts, sectionSortOrders.contacts, sortContactsByOrder] [uniqueContacts, sectionSortOrders.contacts, sortContactsByOrder]
); );
const sortedRooms = useMemo(
() =>
sortContactsByOrder(
uniqueContacts.filter((c) => c.type === CONTACT_TYPE_ROOM),
sectionSortOrders.rooms
),
[uniqueContacts, sectionSortOrders.rooms, sortContactsByOrder]
);
const sortedRepeaters = useMemo( const sortedRepeaters = useMemo(
() => () =>
sortRepeatersByOrder( sortRepeatersByOrder(
@@ -358,6 +408,17 @@ export function Sidebar({
[sortedNonRepeaterContacts, query] [sortedNonRepeaterContacts, query]
); );
const filteredRooms = useMemo(
() =>
query
? sortedRooms.filter(
(c) =>
c.name?.toLowerCase().includes(query) || c.public_key.toLowerCase().includes(query)
)
: sortedRooms,
[sortedRooms, query]
);
const filteredRepeaters = useMemo( const filteredRepeaters = useMemo(
() => () =>
query query
@@ -378,6 +439,7 @@ export function Sidebar({
favorites: favoritesCollapsed, favorites: favoritesCollapsed,
channels: channelsCollapsed, channels: channelsCollapsed,
contacts: contactsCollapsed, contacts: contactsCollapsed,
rooms: roomsCollapsed,
repeaters: repeatersCollapsed, repeaters: repeatersCollapsed,
}; };
} }
@@ -387,12 +449,14 @@ export function Sidebar({
favoritesCollapsed || favoritesCollapsed ||
channelsCollapsed || channelsCollapsed ||
contactsCollapsed || contactsCollapsed ||
roomsCollapsed ||
repeatersCollapsed repeatersCollapsed
) { ) {
setToolsCollapsed(false); setToolsCollapsed(false);
setFavoritesCollapsed(false); setFavoritesCollapsed(false);
setChannelsCollapsed(false); setChannelsCollapsed(false);
setContactsCollapsed(false); setContactsCollapsed(false);
setRoomsCollapsed(false);
setRepeatersCollapsed(false); setRepeatersCollapsed(false);
} }
return; return;
@@ -405,6 +469,7 @@ export function Sidebar({
setFavoritesCollapsed(prev.favorites); setFavoritesCollapsed(prev.favorites);
setChannelsCollapsed(prev.channels); setChannelsCollapsed(prev.channels);
setContactsCollapsed(prev.contacts); setContactsCollapsed(prev.contacts);
setRoomsCollapsed(prev.rooms);
setRepeatersCollapsed(prev.repeaters); setRepeatersCollapsed(prev.repeaters);
} }
}, [ }, [
@@ -413,6 +478,7 @@ export function Sidebar({
favoritesCollapsed, favoritesCollapsed,
channelsCollapsed, channelsCollapsed,
contactsCollapsed, contactsCollapsed,
roomsCollapsed,
repeatersCollapsed, repeatersCollapsed,
]); ]);
@@ -424,6 +490,7 @@ export function Sidebar({
favorites: favoritesCollapsed, favorites: favoritesCollapsed,
channels: channelsCollapsed, channels: channelsCollapsed,
contacts: contactsCollapsed, contacts: contactsCollapsed,
rooms: roomsCollapsed,
repeaters: repeatersCollapsed, repeaters: repeatersCollapsed,
}; };
@@ -438,62 +505,56 @@ export function Sidebar({
favoritesCollapsed, favoritesCollapsed,
channelsCollapsed, channelsCollapsed,
contactsCollapsed, contactsCollapsed,
roomsCollapsed,
repeatersCollapsed, repeatersCollapsed,
]); ]);
// Separate favorites from regular items, and build combined favorites list // Separate favorites from regular items, and build combined favorites list
const { favoriteItems, nonFavoriteChannels, nonFavoriteContacts, nonFavoriteRepeaters } = const {
useMemo(() => { favoriteItems,
const favChannels = filteredChannels.filter((c) => isFavorite(favorites, 'channel', c.key)); nonFavoriteChannels,
const favContacts = [...filteredNonRepeaterContacts, ...filteredRepeaters].filter((c) => nonFavoriteContacts,
isFavorite(favorites, 'contact', c.public_key) nonFavoriteRooms,
); nonFavoriteRepeaters,
const nonFavChannels = filteredChannels.filter( } = useMemo(() => {
(c) => !isFavorite(favorites, 'channel', c.key) const favChannels = filteredChannels.filter((c) => isFavorite(favorites, 'channel', c.key));
); const favContacts = [
const nonFavContacts = filteredNonRepeaterContacts.filter( ...filteredNonRepeaterContacts,
(c) => !isFavorite(favorites, 'contact', c.public_key) ...filteredRooms,
); ...filteredRepeaters,
const nonFavRepeaters = filteredRepeaters.filter( ].filter((c) => isFavorite(favorites, 'contact', c.public_key));
(c) => !isFavorite(favorites, 'contact', c.public_key) const nonFavChannels = filteredChannels.filter((c) => !isFavorite(favorites, 'channel', c.key));
); const nonFavContacts = filteredNonRepeaterContacts.filter(
(c) => !isFavorite(favorites, 'contact', c.public_key)
);
const nonFavRooms = filteredRooms.filter(
(c) => !isFavorite(favorites, 'contact', c.public_key)
);
const nonFavRepeaters = filteredRepeaters.filter(
(c) => !isFavorite(favorites, 'contact', c.public_key)
);
const items: FavoriteItem[] = [ const items: FavoriteItem[] = [
...favChannels.map((channel) => ({ type: 'channel' as const, channel })), ...favChannels.map((channel) => ({ type: 'channel' as const, channel })),
...favContacts.map((contact) => ({ type: 'contact' as const, contact })), ...favContacts.map((contact) => ({ type: 'contact' as const, contact })),
].sort((a, b) => { ];
const timeA =
a.type === 'channel'
? getLastMessageTime('channel', a.channel.key)
: getContactRecentTime(a.contact);
const timeB =
b.type === 'channel'
? getLastMessageTime('channel', b.channel.key)
: getContactRecentTime(b.contact);
if (timeA && timeB) return timeB - timeA;
if (timeA && !timeB) return -1;
if (!timeA && timeB) return 1;
const nameA =
a.type === 'channel' ? a.channel.name : a.contact.name || a.contact.public_key;
const nameB =
b.type === 'channel' ? b.channel.name : b.contact.name || b.contact.public_key;
return nameA.localeCompare(nameB);
});
return { return {
favoriteItems: items, favoriteItems: sortFavoriteItemsByOrder(items, sectionSortOrders.favorites),
nonFavoriteChannels: nonFavChannels, nonFavoriteChannels: nonFavChannels,
nonFavoriteContacts: nonFavContacts, nonFavoriteContacts: nonFavContacts,
nonFavoriteRepeaters: nonFavRepeaters, nonFavoriteRooms: nonFavRooms,
}; nonFavoriteRepeaters: nonFavRepeaters,
}, [ };
filteredChannels, }, [
filteredNonRepeaterContacts, filteredChannels,
filteredRepeaters, filteredNonRepeaterContacts,
favorites, filteredRooms,
getContactRecentTime, filteredRepeaters,
getLastMessageTime, favorites,
]); sectionSortOrders.favorites,
sortFavoriteItemsByOrder,
]);
const buildChannelRow = (channel: Channel, keyPrefix: string): ConversationRow => ({ const buildChannelRow = (channel: Channel, keyPrefix: string): ConversationRow => ({
key: `${keyPrefix}-${channel.key}`, key: `${keyPrefix}-${channel.key}`,
@@ -517,57 +578,65 @@ export function Sidebar({
contact, contact,
}); });
const renderConversationRow = (row: ConversationRow) => ( const renderConversationRow = (row: ConversationRow) => {
<div const highlightUnread =
key={row.key} row.isMention ||
className={cn( (row.type === 'contact' &&
'px-3 py-2 cursor-pointer flex items-center gap-2 border-l-2 border-transparent hover:bg-accent transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring', row.contact?.type !== CONTACT_TYPE_REPEATER &&
isActive(row.type, row.id) && 'bg-accent border-l-primary', row.unreadCount > 0);
row.unreadCount > 0 && '[&_.name]:font-semibold [&_.name]:text-foreground'
)} return (
role="button" <div
tabIndex={0} key={row.key}
aria-current={isActive(row.type, row.id) ? 'page' : undefined} className={cn(
onKeyDown={handleKeyboardActivate} 'px-3 py-2 cursor-pointer flex items-center gap-2 border-l-2 border-transparent hover:bg-accent transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring',
onClick={() => isActive(row.type, row.id) && 'bg-accent border-l-primary',
handleSelectConversation({ row.unreadCount > 0 && '[&_.name]:font-semibold [&_.name]:text-foreground'
type: row.type,
id: row.id,
name: row.name,
})
}
>
{row.type === 'contact' && row.contact && (
<ContactAvatar
name={row.contact.name}
publicKey={row.contact.public_key}
size={24}
contactType={row.contact.type}
/>
)}
<span className="name flex-1 truncate text-[13px]">{row.name}</span>
<span className="ml-auto flex items-center gap-1">
{row.notificationsEnabled && (
<span aria-label="Notifications enabled" title="Notifications enabled">
<Bell className="h-3.5 w-3.5 text-muted-foreground" />
</span>
)} )}
{row.unreadCount > 0 && ( role="button"
<span tabIndex={0}
className={cn( aria-current={isActive(row.type, row.id) ? 'page' : undefined}
'text-[10px] font-semibold px-1.5 py-0.5 rounded-full min-w-[18px] text-center', onKeyDown={handleKeyboardActivate}
row.isMention onClick={() =>
? 'bg-badge-mention text-badge-mention-foreground' handleSelectConversation({
: 'bg-badge-unread/90 text-badge-unread-foreground' type: row.type,
)} id: row.id,
aria-label={`${row.unreadCount} unread message${row.unreadCount !== 1 ? 's' : ''}`} name: row.name,
> })
{row.unreadCount} }
</span> >
{row.type === 'contact' && row.contact && (
<ContactAvatar
name={row.contact.name}
publicKey={row.contact.public_key}
size={24}
contactType={row.contact.type}
/>
)} )}
</span> <span className="name flex-1 truncate text-[13px]">{row.name}</span>
</div> <span className="ml-auto flex items-center gap-1">
); {row.notificationsEnabled && (
<span aria-label="Notifications enabled" title="Notifications enabled">
<Bell className="h-3.5 w-3.5 text-muted-foreground" />
</span>
)}
{row.unreadCount > 0 && (
<span
className={cn(
'text-[10px] font-semibold px-1.5 py-0.5 rounded-full min-w-[18px] text-center',
highlightUnread
? 'bg-badge-mention text-badge-mention-foreground'
: 'bg-badge-unread/90 text-badge-unread-foreground'
)}
aria-label={`${row.unreadCount} unread message${row.unreadCount !== 1 ? 's' : ''}`}
>
{row.unreadCount}
</span>
)}
</span>
</div>
);
};
const renderSidebarActionRow = ({ const renderSidebarActionRow = ({
key, key,
@@ -613,11 +682,13 @@ export function Sidebar({
); );
const channelRows = nonFavoriteChannels.map((channel) => buildChannelRow(channel, 'chan')); const channelRows = nonFavoriteChannels.map((channel) => buildChannelRow(channel, 'chan'));
const contactRows = nonFavoriteContacts.map((contact) => buildContactRow(contact, 'contact')); const contactRows = nonFavoriteContacts.map((contact) => buildContactRow(contact, 'contact'));
const roomRows = nonFavoriteRooms.map((contact) => buildContactRow(contact, 'room'));
const repeaterRows = nonFavoriteRepeaters.map((contact) => buildContactRow(contact, 'repeater')); const repeaterRows = nonFavoriteRepeaters.map((contact) => buildContactRow(contact, 'repeater'));
const favoritesUnreadCount = getSectionUnreadCount(favoriteRows); const favoritesUnreadCount = getSectionUnreadCount(favoriteRows);
const channelsUnreadCount = getSectionUnreadCount(channelRows); const channelsUnreadCount = getSectionUnreadCount(channelRows);
const contactsUnreadCount = getSectionUnreadCount(contactRows); const contactsUnreadCount = getSectionUnreadCount(contactRows);
const roomsUnreadCount = getSectionUnreadCount(roomRows);
const repeatersUnreadCount = getSectionUnreadCount(repeaterRows); const repeatersUnreadCount = getSectionUnreadCount(repeaterRows);
const favoritesHasMention = sectionHasMention(favoriteRows); const favoritesHasMention = sectionHasMention(favoriteRows);
const channelsHasMention = sectionHasMention(channelRows); const channelsHasMention = sectionHasMention(channelRows);
@@ -677,7 +748,7 @@ export function Sidebar({
icon: <LockOpen className="h-4 w-4" />, icon: <LockOpen className="h-4 w-4" />,
label: ( label: (
<> <>
{showCracker ? 'Hide' : 'Show'} Room Finder {showCracker ? 'Hide' : 'Show'} Channel Finder
<span <span
className={cn( className={cn(
'ml-1 text-[11px]', 'ml-1 text-[11px]',
@@ -773,7 +844,7 @@ export function Sidebar({
<div className="relative min-w-0 flex-1"> <div className="relative min-w-0 flex-1">
<Input <Input
type="text" type="text"
placeholder="Search rooms/contacts..." placeholder="Search channels/contacts..."
aria-label="Search conversations" aria-label="Search conversations"
value={searchQuery} value={searchQuery}
onChange={(e) => setSearchQuery(e.target.value)} onChange={(e) => setSearchQuery(e.target.value)}
@@ -833,7 +904,7 @@ export function Sidebar({
'Favorites', 'Favorites',
favoritesCollapsed, favoritesCollapsed,
() => setFavoritesCollapsed((prev) => !prev), () => setFavoritesCollapsed((prev) => !prev),
null, 'favorites',
favoritesUnreadCount, favoritesUnreadCount,
favoritesHasMention favoritesHasMention
)} )}
@@ -889,8 +960,24 @@ export function Sidebar({
</> </>
)} )}
{/* Room Servers */}
{nonFavoriteRooms.length > 0 && (
<>
{renderSectionHeader(
'Room Servers',
roomsCollapsed,
() => setRoomsCollapsed((prev) => !prev),
'rooms',
roomsUnreadCount,
roomsUnreadCount > 0
)}
{(isSearching || !roomsCollapsed) && roomRows.map((row) => renderConversationRow(row))}
</>
)}
{/* Empty state */} {/* Empty state */}
{nonFavoriteContacts.length === 0 && {nonFavoriteContacts.length === 0 &&
nonFavoriteRooms.length === 0 &&
nonFavoriteChannels.length === 0 && nonFavoriteChannels.length === 0 &&
nonFavoriteRepeaters.length === 0 && nonFavoriteRepeaters.length === 0 &&
favoriteItems.length === 0 && ( favoriteItems.length === 0 && (
@@ -2,6 +2,7 @@ import { useMemo, lazy, Suspense } from 'react';
import { cn } from '@/lib/utils'; import { cn } from '@/lib/utils';
import { RepeaterPane, NotFetched, formatDuration } from './repeaterPaneShared'; import { RepeaterPane, NotFetched, formatDuration } from './repeaterPaneShared';
import { isValidLocation, calculateDistance, formatDistance } from '../../utils/pathUtils'; import { isValidLocation, calculateDistance, formatDistance } from '../../utils/pathUtils';
import { useDistanceUnit } from '../../contexts/DistanceUnitContext';
import type { import type {
Contact, Contact,
RepeaterNeighborsResponse, RepeaterNeighborsResponse,
@@ -35,6 +36,7 @@ export function NeighborsPane({
nodeInfoState: PaneState; nodeInfoState: PaneState;
repeaterName: string | null; repeaterName: string | null;
}) { }) {
const { distanceUnit } = useDistanceUnit();
const advertLat = repeaterContact?.lat ?? null; const advertLat = repeaterContact?.lat ?? null;
const advertLon = repeaterContact?.lon ?? null; const advertLon = repeaterContact?.lon ?? null;
@@ -93,7 +95,7 @@ export function NeighborsPane({
if (hasValidRepeaterGps && isValidLocation(nLat, nLon)) { if (hasValidRepeaterGps && isValidLocation(nLat, nLon)) {
const distKm = calculateDistance(positionSource.lat, positionSource.lon, nLat, nLon); const distKm = calculateDistance(positionSource.lat, positionSource.lon, nLat, nLon);
if (distKm != null) { if (distKm != null) {
dist = formatDistance(distKm); dist = formatDistance(distKm, distanceUnit);
anyDist = true; anyDist = true;
} }
} }
@@ -111,7 +113,7 @@ export function NeighborsPane({
sorted: enriched, sorted: enriched,
hasDistances: anyDist, hasDistances: anyDist,
}; };
}, [contacts, data, hasValidRepeaterGps, positionSource.lat, positionSource.lon]); }, [contacts, data, distanceUnit, hasValidRepeaterGps, positionSource.lat, positionSource.lon]);
return ( return (
<RepeaterPane <RepeaterPane
@@ -112,7 +112,10 @@ export function RadioSettingsPane({
<NotFetched /> <NotFetched />
) : ( ) : (
<div> <div>
<KvRow label="Local Advert" value={formatAdvertInterval(advertData.advert_interval)} /> <KvRow
label="Local Advert"
value={formatAdvertInterval(advertData.advert_interval, 'minutes')}
/>
<KvRow <KvRow
label="Flood Advert" label="Flood Advert"
value={formatAdvertInterval(advertData.flood_advert_interval)} value={formatAdvertInterval(advertData.flood_advert_interval)}
@@ -76,11 +76,19 @@ export function formatClockDrift(
return { text: parts.join(''), isLarge: false }; return { text: parts.join(''), isLarge: false };
} }
export function formatAdvertInterval(val: string | null): string { export function formatAdvertInterval(
val: string | null,
unit: 'minutes' | 'hours' = 'hours'
): string {
if (val == null) return '—'; if (val == null) return '—';
const trimmed = val.trim(); const trimmed = val.trim();
if (trimmed === '0') return '<disabled>'; if (trimmed === '0') return '<disabled>';
return `${trimmed}h`; if (unit === 'hours') return `${trimmed}h`;
const mins = parseInt(trimmed, 10);
if (isNaN(mins)) return trimmed;
if (mins >= 60 && mins % 60 === 0) return `${mins / 60}h`;
if (mins >= 60) return `${Math.floor(mins / 60)}h${mins % 60}m`;
return `${mins}m`;
} }
function formatFetchedRelative(fetchedAt: number): string { function formatFetchedRelative(fetchedAt: number): string {
@@ -173,8 +173,8 @@ export function SettingsDatabaseSection({
Deletes archival copies of raw packet bytes for messages that are already decrypted and Deletes archival copies of raw packet bytes for messages that are already decrypted and
visible in your chat history.{' '} visible in your chat history.{' '}
<em className="text-muted-foreground/80"> <em className="text-muted-foreground/80">
This will not affect any displayed messages or app functionality, nor impact your This will not affect any displayed messages or your ability to do historical decryption,
ability to do historical decryption. but it will remove packet-analysis availability for those historical messages.
</em>{' '} </em>{' '}
The raw bytes are only useful for manual packet analysis. The raw bytes are only useful for manual packet analysis.
</p> </p>
@@ -1,8 +1,17 @@
import { useState, useEffect, useCallback, useRef, lazy, Suspense } from 'react'; import { useState, useEffect, useCallback, useMemo, useRef, lazy, Suspense } from 'react';
import { ChevronDown, Info } from 'lucide-react';
import { Input } from '../ui/input'; import { Input } from '../ui/input';
import { Label } from '../ui/label'; import { Label } from '../ui/label';
import { Button } from '../ui/button'; import { Button } from '../ui/button';
import { Separator } from '../ui/separator'; import { Separator } from '../ui/separator';
import {
Dialog,
DialogContent,
DialogDescription,
DialogFooter,
DialogHeader,
DialogTitle,
} from '../ui/dialog';
import { toast } from '../ui/sonner'; import { toast } from '../ui/sonner';
import { cn } from '@/lib/utils'; import { cn } from '@/lib/utils';
import { api } from '../../api'; import { api } from '../../api';
@@ -14,22 +23,14 @@ const BotCodeEditor = lazy(() =>
const TYPE_LABELS: Record<string, string> = { const TYPE_LABELS: Record<string, string> = {
mqtt_private: 'Private MQTT', mqtt_private: 'Private MQTT',
mqtt_community: 'Community MQTT', mqtt_community: 'Community Sharing',
bot: 'Bot', bot: 'Python Bot',
webhook: 'Webhook', webhook: 'Webhook',
apprise: 'Apprise', apprise: 'Apprise',
sqs: 'Amazon SQS', sqs: 'Amazon SQS',
map_upload: 'Map Upload',
}; };
const LIST_TYPE_OPTIONS = [
{ value: 'mqtt_private', label: 'Private MQTT' },
{ value: 'mqtt_community', label: 'Community MQTT' },
{ value: 'bot', label: 'Bot' },
{ value: 'webhook', label: 'Webhook' },
{ value: 'apprise', label: 'Apprise' },
{ value: 'sqs', label: 'Amazon SQS' },
];
const DEFAULT_COMMUNITY_PACKET_TOPIC_TEMPLATE = 'meshcore/{IATA}/{PUBLIC_KEY}/packets'; const DEFAULT_COMMUNITY_PACKET_TOPIC_TEMPLATE = 'meshcore/{IATA}/{PUBLIC_KEY}/packets';
const DEFAULT_COMMUNITY_BROKER_HOST = 'mqtt-us-v1.letsmesh.net'; const DEFAULT_COMMUNITY_BROKER_HOST = 'mqtt-us-v1.letsmesh.net';
const DEFAULT_COMMUNITY_BROKER_HOST_EU = 'mqtt-eu-v1.letsmesh.net'; const DEFAULT_COMMUNITY_BROKER_HOST_EU = 'mqtt-eu-v1.letsmesh.net';
@@ -42,30 +43,6 @@ const DEFAULT_MESHRANK_TRANSPORT = 'tcp';
const DEFAULT_MESHRANK_AUTH_MODE = 'none'; const DEFAULT_MESHRANK_AUTH_MODE = 'none';
const DEFAULT_MESHRANK_IATA = 'XYZ'; const DEFAULT_MESHRANK_IATA = 'XYZ';
const CREATE_TYPE_OPTIONS = [
{ value: 'mqtt_private', label: 'Private MQTT' },
{ value: 'mqtt_community_meshrank', label: 'MeshRank' },
{ value: 'mqtt_community_letsmesh_us', label: 'LetsMesh (US)' },
{ value: 'mqtt_community_letsmesh_eu', label: 'LetsMesh (EU)' },
{ value: 'mqtt_community', label: 'Community MQTT/meshcoretomqtt' },
{ value: 'bot', label: 'Bot' },
{ value: 'webhook', label: 'Webhook' },
{ value: 'apprise', label: 'Apprise' },
{ value: 'sqs', label: 'Amazon SQS' },
] as const;
type DraftType = (typeof CREATE_TYPE_OPTIONS)[number]['value'];
type DraftRecipe = {
savedType: string;
detailLabel: string;
defaultName: string;
defaults: {
config: Record<string, unknown>;
scope: Record<string, unknown>;
};
};
function createCommunityConfigDefaults( function createCommunityConfigDefaults(
overrides: Partial<Record<string, unknown>> = {} overrides: Partial<Record<string, unknown>> = {}
): Record<string, unknown> { ): Record<string, unknown> {
@@ -122,11 +99,42 @@ const DEFAULT_BOT_CODE = `def bot(**kwargs) -> str | list[str] | None:
return "[BOT] Plong!" return "[BOT] Plong!"
return None`; return None`;
const DRAFT_RECIPES: Record<DraftType, DraftRecipe> = { type DraftType =
mqtt_private: { | 'mqtt_private'
| 'mqtt_community'
| 'mqtt_community_meshrank'
| 'mqtt_community_letsmesh_us'
| 'mqtt_community_letsmesh_eu'
| 'webhook'
| 'apprise'
| 'sqs'
| 'bot'
| 'map_upload';
type CreateIntegrationDefinition = {
value: DraftType;
savedType: string;
label: string;
section: string;
description: string;
defaultName: string;
nameMode: 'counted' | 'fixed';
defaults: {
config: Record<string, unknown>;
scope: Record<string, unknown>;
};
};
const CREATE_INTEGRATION_DEFINITIONS: readonly CreateIntegrationDefinition[] = [
{
value: 'mqtt_private',
savedType: 'mqtt_private', savedType: 'mqtt_private',
detailLabel: 'Private MQTT', label: 'Private MQTT',
section: 'Bulk Forwarding',
description:
'Customizable-scope forwarding of all or some messages to an MQTT broker of your choosing, in raw and/or decrypted form.',
defaultName: 'Private MQTT', defaultName: 'Private MQTT',
nameMode: 'counted',
defaults: { defaults: {
config: { config: {
broker_host: '', broker_host: '',
@@ -140,10 +148,29 @@ const DRAFT_RECIPES: Record<DraftType, DraftRecipe> = {
scope: { messages: 'all', raw_packets: 'all' }, scope: { messages: 'all', raw_packets: 'all' },
}, },
}, },
mqtt_community_meshrank: { {
value: 'mqtt_community',
savedType: 'mqtt_community', savedType: 'mqtt_community',
detailLabel: 'MeshRank', label: 'Community MQTT/meshcoretomqtt',
section: 'Community Sharing',
description:
'MeshcoreToMQTT-compatible raw-packet feed publishing, compatible with community aggregators (in other words, make your companion radio also serve as an observer node). Superset of other Community MQTT presets.',
defaultName: 'Community MQTT',
nameMode: 'counted',
defaults: {
config: createCommunityConfigDefaults(),
scope: { messages: 'none', raw_packets: 'all' },
},
},
{
value: 'mqtt_community_meshrank',
savedType: 'mqtt_community',
label: 'MeshRank',
section: 'Community Sharing',
description:
'A community MQTT config preconfigured for MeshRank, requiring only the provided topic from your MeshRank configuration. A subset of the primary Community MQTT/meshcoretomqtt configuration; you are free to edit all configuration after creation.',
defaultName: 'MeshRank', defaultName: 'MeshRank',
nameMode: 'fixed',
defaults: { defaults: {
config: createCommunityConfigDefaults({ config: createCommunityConfigDefaults({
broker_host: DEFAULT_MESHRANK_BROKER_HOST, broker_host: DEFAULT_MESHRANK_BROKER_HOST,
@@ -158,10 +185,15 @@ const DRAFT_RECIPES: Record<DraftType, DraftRecipe> = {
scope: { messages: 'none', raw_packets: 'all' }, scope: { messages: 'none', raw_packets: 'all' },
}, },
}, },
mqtt_community_letsmesh_us: { {
value: 'mqtt_community_letsmesh_us',
savedType: 'mqtt_community', savedType: 'mqtt_community',
detailLabel: 'LetsMesh (US)', label: 'LetsMesh (US)',
section: 'Community Sharing',
description:
'A community MQTT config preconfigured for the LetsMesh US-ingest endpoint, requiring only your email and IATA region code. Good to use with an additional EU configuration for redundancy. A subset of the primary Community MQTT/meshcoretomqtt configuration; you are free to edit all configuration after creation.',
defaultName: 'LetsMesh (US)', defaultName: 'LetsMesh (US)',
nameMode: 'fixed',
defaults: { defaults: {
config: createCommunityConfigDefaults({ config: createCommunityConfigDefaults({
broker_host: DEFAULT_COMMUNITY_BROKER_HOST, broker_host: DEFAULT_COMMUNITY_BROKER_HOST,
@@ -170,10 +202,15 @@ const DRAFT_RECIPES: Record<DraftType, DraftRecipe> = {
scope: { messages: 'none', raw_packets: 'all' }, scope: { messages: 'none', raw_packets: 'all' },
}, },
}, },
mqtt_community_letsmesh_eu: { {
value: 'mqtt_community_letsmesh_eu',
savedType: 'mqtt_community', savedType: 'mqtt_community',
detailLabel: 'LetsMesh (EU)', label: 'LetsMesh (EU)',
section: 'Community Sharing',
description:
'A community MQTT config preconfigured for the LetsMesh EU-ingest endpoint, requiring only your email and IATA region code. Good to use with an additional US configuration for redundancy. A subset of the primary Community MQTT/meshcoretomqtt configuration; you are free to edit all configuration after creation.',
defaultName: 'LetsMesh (EU)', defaultName: 'LetsMesh (EU)',
nameMode: 'fixed',
defaults: { defaults: {
config: createCommunityConfigDefaults({ config: createCommunityConfigDefaults({
broker_host: DEFAULT_COMMUNITY_BROKER_HOST_EU, broker_host: DEFAULT_COMMUNITY_BROKER_HOST_EU,
@@ -182,30 +219,15 @@ const DRAFT_RECIPES: Record<DraftType, DraftRecipe> = {
scope: { messages: 'none', raw_packets: 'all' }, scope: { messages: 'none', raw_packets: 'all' },
}, },
}, },
mqtt_community: { {
savedType: 'mqtt_community', value: 'webhook',
detailLabel: 'Community MQTT/meshcoretomqtt',
defaultName: 'Community MQTT',
defaults: {
config: createCommunityConfigDefaults(),
scope: { messages: 'none', raw_packets: 'all' },
},
},
bot: {
savedType: 'bot',
detailLabel: 'Bot',
defaultName: 'Bot',
defaults: {
config: {
code: DEFAULT_BOT_CODE,
},
scope: { messages: 'all', raw_packets: 'none' },
},
},
webhook: {
savedType: 'webhook', savedType: 'webhook',
detailLabel: 'Webhook', label: 'Webhook',
section: 'Automation',
description:
'Generic webhook for decrypted channel/DM messages with customizable verb, method, and optional HMAC signature.',
defaultName: 'Webhook', defaultName: 'Webhook',
nameMode: 'counted',
defaults: { defaults: {
config: { config: {
url: '', url: '',
@@ -217,10 +239,15 @@ const DRAFT_RECIPES: Record<DraftType, DraftRecipe> = {
scope: { messages: 'all', raw_packets: 'none' }, scope: { messages: 'all', raw_packets: 'none' },
}, },
}, },
apprise: { {
value: 'apprise',
savedType: 'apprise', savedType: 'apprise',
detailLabel: 'Apprise', label: 'Apprise',
section: 'Automation',
description:
'A wide-ranging generic fanout, capable of forwarding decrypted channel/DM messages to Discord, Telegram, email, SMS, and many others.',
defaultName: 'Apprise', defaultName: 'Apprise',
nameMode: 'counted',
defaults: { defaults: {
config: { config: {
urls: '', urls: '',
@@ -230,10 +257,14 @@ const DRAFT_RECIPES: Record<DraftType, DraftRecipe> = {
scope: { messages: 'all', raw_packets: 'none' }, scope: { messages: 'all', raw_packets: 'none' },
}, },
}, },
sqs: { {
value: 'sqs',
savedType: 'sqs', savedType: 'sqs',
detailLabel: 'Amazon SQS', label: 'Amazon SQS',
section: 'Bulk Forwarding',
description: 'Send full or scope-customized raw or decrypted packets to an SQS',
defaultName: 'Amazon SQS', defaultName: 'Amazon SQS',
nameMode: 'counted',
defaults: { defaults: {
config: { config: {
queue_url: '', queue_url: '',
@@ -246,15 +277,58 @@ const DRAFT_RECIPES: Record<DraftType, DraftRecipe> = {
scope: { messages: 'all', raw_packets: 'none' }, scope: { messages: 'all', raw_packets: 'none' },
}, },
}, },
}; {
value: 'bot',
savedType: 'bot',
label: 'Python Bot',
section: 'Automation',
description:
'A simple, Python-based interface for basic bots that can respond to DM and channel messages.',
defaultName: 'Bot',
nameMode: 'counted',
defaults: {
config: {
code: DEFAULT_BOT_CODE,
},
scope: { messages: 'all', raw_packets: 'none' },
},
},
{
value: 'map_upload',
savedType: 'map_upload',
label: 'Map Upload',
section: 'Community Sharing',
description:
'Upload repeaters and room servers to map.meshcore.dev or a compatible map API endpoint.',
defaultName: 'Map Upload',
nameMode: 'counted',
defaults: {
config: {
api_url: '',
dry_run: true,
},
scope: { messages: 'none', raw_packets: 'all' },
},
},
];
const CREATE_INTEGRATION_DEFINITIONS_BY_VALUE = Object.fromEntries(
CREATE_INTEGRATION_DEFINITIONS.map((definition) => [definition.value, definition])
) as Record<DraftType, CreateIntegrationDefinition>;
function isDraftType(value: string): value is DraftType { function isDraftType(value: string): value is DraftType {
return value in DRAFT_RECIPES; return value in CREATE_INTEGRATION_DEFINITIONS_BY_VALUE;
}
function getCreateIntegrationDefinition(draftType: DraftType) {
return CREATE_INTEGRATION_DEFINITIONS_BY_VALUE[draftType];
} }
function normalizeDraftName(draftType: DraftType, name: string, configs: FanoutConfig[]) { function normalizeDraftName(draftType: DraftType, name: string, configs: FanoutConfig[]) {
const recipe = DRAFT_RECIPES[draftType]; const definition = getCreateIntegrationDefinition(draftType);
return name || getDefaultIntegrationName(recipe.savedType, configs); if (name) return name;
if (definition.nameMode === 'fixed') return definition.defaultName;
return getDefaultIntegrationName(definition.savedType, configs);
} }
function normalizeDraftConfig(draftType: DraftType, config: Record<string, unknown>) { function normalizeDraftConfig(draftType: DraftType, config: Record<string, unknown>) {
@@ -305,22 +379,160 @@ function normalizeDraftConfig(draftType: DraftType, config: Record<string, unkno
} }
function normalizeDraftScope(draftType: DraftType, scope: Record<string, unknown>) { function normalizeDraftScope(draftType: DraftType, scope: Record<string, unknown>) {
if (draftType.startsWith('mqtt_community_')) { if (getCreateIntegrationDefinition(draftType).savedType === 'mqtt_community') {
return { messages: 'none', raw_packets: 'all' }; return { messages: 'none', raw_packets: 'all' };
} }
return scope; return scope;
} }
function cloneDraftDefaults(draftType: DraftType) { function cloneDraftDefaults(draftType: DraftType) {
const recipe = DRAFT_RECIPES[draftType]; const recipe = getCreateIntegrationDefinition(draftType);
return { return {
config: structuredClone(recipe.defaults.config), config: structuredClone(recipe.defaults.config),
scope: structuredClone(recipe.defaults.scope), scope: structuredClone(recipe.defaults.scope),
}; };
} }
function CreateIntegrationDialog({
open,
options,
selectedType,
onOpenChange,
onSelect,
onCreate,
}: {
open: boolean;
options: readonly CreateIntegrationDefinition[];
selectedType: DraftType | null;
onOpenChange: (open: boolean) => void;
onSelect: (type: DraftType) => void;
onCreate: () => void;
}) {
const selectedOption =
options.find((option) => option.value === selectedType) ?? options[0] ?? null;
const listRef = useRef<HTMLDivElement | null>(null);
const [showScrollHint, setShowScrollHint] = useState(false);
const updateScrollHint = useCallback(() => {
const container = listRef.current;
if (!container) {
setShowScrollHint(false);
return;
}
setShowScrollHint(container.scrollTop + container.clientHeight < container.scrollHeight - 8);
}, []);
useEffect(() => {
if (!open) return;
const frame = window.requestAnimationFrame(updateScrollHint);
window.addEventListener('resize', updateScrollHint);
return () => {
window.cancelAnimationFrame(frame);
window.removeEventListener('resize', updateScrollHint);
};
}, [open, options, updateScrollHint]);
const sectionedOptions = [...new Set(options.map((o) => o.section))]
.map((section) => ({
section,
options: options.filter((option) => option.section === section),
}))
.filter((group) => group.options.length > 0);
return (
<Dialog open={open} onOpenChange={onOpenChange}>
<DialogContent
aria-describedby={undefined}
hideCloseButton
className="flex max-h-[calc(100dvh-2rem)] w-[96vw] max-w-[960px] flex-col overflow-hidden p-0 sm:rounded-xl"
>
<DialogHeader className="border-b border-border px-5 py-4">
<DialogTitle>Create Integration</DialogTitle>
</DialogHeader>
<div className="grid min-h-0 flex-1 grid-cols-1 overflow-hidden md:grid-cols-[240px_minmax(0,1fr)]">
<div className="relative border-b border-border bg-muted/20 md:border-b-0 md:border-r">
<div
ref={listRef}
onScroll={updateScrollHint}
className="max-h-56 overflow-y-auto p-2 md:max-h-[420px]"
>
<div className="space-y-4">
{sectionedOptions.map((group) => (
<div key={group.section} className="space-y-1.5">
<div className="px-2 text-[11px] font-semibold uppercase tracking-[0.12em] text-muted-foreground">
{group.section}
</div>
{group.options.map((option) => {
const selected = option.value === selectedOption?.value;
return (
<button
key={option.value}
type="button"
className={cn(
'w-full rounded-md border px-3 py-2 text-left transition-colors',
selected
? 'border-primary bg-accent text-foreground'
: 'border-transparent bg-transparent hover:bg-accent/70'
)}
aria-pressed={selected}
onClick={() => onSelect(option.value)}
>
<div className="text-sm font-medium">{option.label}</div>
</button>
);
})}
</div>
))}
</div>
</div>
{showScrollHint && (
<div className="pointer-events-none absolute inset-x-0 bottom-0 flex justify-center bg-gradient-to-t from-background via-background/85 to-transparent px-4 pb-2 pt-8">
<div className="rounded-full border border-border/80 bg-background/95 px-2 py-1 text-muted-foreground shadow-sm">
<ChevronDown className="h-4 w-4" aria-hidden="true" />
</div>
</div>
)}
</div>
<div className="min-h-0 space-y-4 overflow-y-auto px-5 py-5 md:min-h-[280px] md:max-h-[420px]">
{selectedOption ? (
<>
<div className="space-y-1.5">
<div className="text-xs font-semibold uppercase tracking-[0.12em] text-muted-foreground">
{selectedOption.section}
</div>
<h3 className="text-lg font-semibold">{selectedOption.label}</h3>
</div>
<p className="text-sm leading-6 text-muted-foreground">
{selectedOption.description}
</p>
</>
) : (
<div className="flex h-full items-center justify-center text-sm text-muted-foreground">
No integration types are currently available.
</div>
)}
</div>
</div>
<DialogFooter className="gap-2 border-t border-border px-5 py-4 sm:justify-end">
<Button variant="outline" onClick={() => onOpenChange(false)}>
Close
</Button>
<Button onClick={onCreate} disabled={!selectedOption}>
Create
</Button>
</DialogFooter>
</DialogContent>
</Dialog>
);
}
function getDetailTypeLabel(detailType: string) { function getDetailTypeLabel(detailType: string) {
if (isDraftType(detailType)) return DRAFT_RECIPES[detailType].detailLabel; if (isDraftType(detailType)) return getCreateIntegrationDefinition(detailType).label;
return TYPE_LABELS[detailType] || detailType; return TYPE_LABELS[detailType] || detailType;
} }
@@ -380,7 +592,9 @@ function getDefaultIntegrationName(type: string, configs: FanoutConfig[]) {
function getStatusLabel(status: string | undefined, type?: string) { function getStatusLabel(status: string | undefined, type?: string) {
if (status === 'connected') if (status === 'connected')
return type === 'bot' || type === 'webhook' || type === 'apprise' ? 'Active' : 'Connected'; return type === 'bot' || type === 'webhook' || type === 'apprise' || type === 'map_upload'
? 'Active'
: 'Connected';
if (status === 'error') return 'Error'; if (status === 'error') return 'Error';
if (status === 'disconnected') return 'Disconnected'; if (status === 'disconnected') return 'Disconnected';
return 'Inactive'; return 'Inactive';
@@ -873,6 +1087,152 @@ function BotConfigEditor({
); );
} }
function MapUploadConfigEditor({
config,
onChange,
}: {
config: Record<string, unknown>;
onChange: (config: Record<string, unknown>) => void;
}) {
const isDryRun = config.dry_run !== false;
const [radioLat, setRadioLat] = useState<number | null>(null);
const [radioLon, setRadioLon] = useState<number | null>(null);
useEffect(() => {
api
.getRadioConfig()
.then((rc) => {
setRadioLat(rc.lat ?? 0);
setRadioLon(rc.lon ?? 0);
})
.catch(() => {
setRadioLat(0);
setRadioLon(0);
});
}, []);
const radioLatLonConfigured =
radioLat !== null && radioLon !== null && !(radioLat === 0 && radioLon === 0);
return (
<div className="space-y-3">
<p className="text-xs text-muted-foreground">
Automatically upload heard repeater and room server advertisements to{' '}
<a
href="https://map.meshcore.dev"
target="_blank"
rel="noopener noreferrer"
className="underline hover:text-foreground"
>
map.meshcore.dev
</a>
. Requires the radio&apos;s private key to be available (firmware must have{' '}
<code>ENABLE_PRIVATE_KEY_EXPORT=1</code>). Only raw RF packets are shared &mdash; never
decrypted messages.
</p>
<div className="rounded-md border border-warning/50 bg-warning/10 px-3 py-2 text-xs text-warning">
<strong>Dry Run is {isDryRun ? 'ON' : 'OFF'}.</strong>{' '}
{isDryRun
? 'No uploads will be sent. Check the backend logs to verify the payload looks correct before enabling live sends.'
: 'Live uploads are enabled. Each advert is rate-limited to once per hour per node.'}
</div>
<label className="flex items-center gap-3 cursor-pointer">
<input
type="checkbox"
checked={isDryRun}
onChange={(e) => onChange({ ...config, dry_run: e.target.checked })}
className="h-4 w-4 rounded border-border"
/>
<div>
<span className="text-sm font-medium">Dry Run (log only, no uploads)</span>
<p className="text-xs text-muted-foreground">
When enabled, upload payloads are logged at INFO level but not sent. Disable once you
have confirmed the logged output looks correct.
</p>
</div>
</label>
<Separator />
<div className="space-y-2">
<Label htmlFor="fanout-map-api-url">API URL (optional)</Label>
<Input
id="fanout-map-api-url"
type="url"
placeholder="https://map.meshcore.dev/api/v1/uploader/node"
value={(config.api_url as string) || ''}
onChange={(e) => onChange({ ...config, api_url: e.target.value })}
/>
<p className="text-xs text-muted-foreground">
Leave blank to use the default <code>map.meshcore.dev</code> endpoint.
</p>
</div>
<Separator />
<label className="flex items-center gap-3 cursor-pointer">
<input
type="checkbox"
checked={!!config.geofence_enabled}
onChange={(e) => onChange({ ...config, geofence_enabled: e.target.checked })}
className="h-4 w-4 rounded border-border"
/>
<div>
<span className="text-sm font-medium">Enable Geofence</span>
<p className="text-xs text-muted-foreground">
Only upload nodes whose location falls within the configured radius of your radio&apos;s
own position. Helps exclude nodes with false or spoofed coordinates. Uses the
latitude/longitude set in Radio Settings.
</p>
</div>
</label>
{!!config.geofence_enabled && (
<div className="space-y-3 pl-7">
{!radioLatLonConfigured && (
<div className="rounded-md border border-warning/50 bg-warning/10 px-3 py-2 text-xs text-warning">
Your radio does not currently have a latitude/longitude configured. Geofencing will be
silently skipped until coordinates are set in{' '}
<strong>Settings &rarr; Radio &rarr; Location</strong>.
</div>
)}
{radioLatLonConfigured && (
<p className="text-xs text-muted-foreground">
Using radio position{' '}
<code>
{radioLat?.toFixed(5)}, {radioLon?.toFixed(5)}
</code>{' '}
as the geofence center. Update coordinates in Radio Settings to move the center.
</p>
)}
<div className="space-y-2">
<Label htmlFor="fanout-map-geofence-radius">Radius (km)</Label>
<Input
id="fanout-map-geofence-radius"
type="number"
min="0"
step="any"
placeholder="e.g. 100"
value={(config.geofence_radius_km as number | undefined) ?? ''}
onChange={(e) =>
onChange({
...config,
geofence_radius_km: e.target.value === '' ? 0 : parseFloat(e.target.value),
})
}
/>
<p className="text-xs text-muted-foreground">
Nodes further than this distance from your radio&apos;s position will not be uploaded.
</p>
</div>
</div>
)}
</div>
);
}
type ScopeMode = 'all' | 'none' | 'only' | 'except'; type ScopeMode = 'all' | 'none' | 'only' | 'except';
function getScopeMode(value: unknown): ScopeMode { function getScopeMode(value: unknown): ScopeMode {
@@ -1499,9 +1859,13 @@ export function SettingsFanoutSection({
const [editName, setEditName] = useState(''); const [editName, setEditName] = useState('');
const [inlineEditingId, setInlineEditingId] = useState<string | null>(null); const [inlineEditingId, setInlineEditingId] = useState<string | null>(null);
const [inlineEditName, setInlineEditName] = useState(''); const [inlineEditName, setInlineEditName] = useState('');
const [addMenuOpen, setAddMenuOpen] = useState(false); const [createDialogOpen, setCreateDialogOpen] = useState(false);
const [selectedCreateType, setSelectedCreateType] = useState<DraftType | null>(null);
const [errorDialogState, setErrorDialogState] = useState<{
integrationName: string;
error: string;
} | null>(null);
const [busy, setBusy] = useState(false); const [busy, setBusy] = useState(false);
const addMenuRef = useRef<HTMLDivElement | null>(null);
const loadConfigs = useCallback(async () => { const loadConfigs = useCallback(async () => {
try { try {
@@ -1516,18 +1880,28 @@ export function SettingsFanoutSection({
loadConfigs(); loadConfigs();
}, [loadConfigs]); }, [loadConfigs]);
const availableCreateOptions = useMemo(
() =>
CREATE_INTEGRATION_DEFINITIONS.filter(
(definition) => definition.savedType !== 'bot' || !health?.bots_disabled
),
[health?.bots_disabled]
);
useEffect(() => { useEffect(() => {
if (!addMenuOpen) return; if (!createDialogOpen) return;
if (availableCreateOptions.length === 0) {
const handlePointerDown = (event: MouseEvent) => { setSelectedCreateType(null);
if (!addMenuRef.current?.contains(event.target as Node)) { return;
setAddMenuOpen(false); }
} if (
}; selectedCreateType &&
availableCreateOptions.some((option) => option.value === selectedCreateType)
document.addEventListener('mousedown', handlePointerDown); ) {
return () => document.removeEventListener('mousedown', handlePointerDown); return;
}, [addMenuOpen]); }
setSelectedCreateType(availableCreateOptions[0].value);
}, [createDialogOpen, availableCreateOptions, selectedCreateType]);
const handleToggleEnabled = async (cfg: FanoutConfig) => { const handleToggleEnabled = async (cfg: FanoutConfig) => {
try { try {
@@ -1541,7 +1915,7 @@ export function SettingsFanoutSection({
}; };
const handleEdit = (cfg: FanoutConfig) => { const handleEdit = (cfg: FanoutConfig) => {
setAddMenuOpen(false); setCreateDialogOpen(false);
setInlineEditingId(null); setInlineEditingId(null);
setInlineEditName(''); setInlineEditName('');
setDraftType(null); setDraftType(null);
@@ -1552,7 +1926,7 @@ export function SettingsFanoutSection({
}; };
const handleStartInlineEdit = (cfg: FanoutConfig) => { const handleStartInlineEdit = (cfg: FanoutConfig) => {
setAddMenuOpen(false); setCreateDialogOpen(false);
setInlineEditingId(cfg.id); setInlineEditingId(cfg.id);
setInlineEditName(cfg.name); setInlineEditName(cfg.name);
}; };
@@ -1611,7 +1985,7 @@ export function SettingsFanoutSection({
setBusy(true); setBusy(true);
try { try {
if (currentDraftType) { if (currentDraftType) {
const recipe = DRAFT_RECIPES[currentDraftType]; const recipe = getCreateIntegrationDefinition(currentDraftType);
await api.createFanoutConfig({ await api.createFanoutConfig({
type: recipe.savedType, type: recipe.savedType,
name: normalizeDraftName(currentDraftType, editName.trim(), configs), name: normalizeDraftName(currentDraftType, editName.trim(), configs),
@@ -1663,18 +2037,16 @@ export function SettingsFanoutSection({
} }
}; };
const handleAddCreate = async (type: string) => { const handleAddCreate = (type: DraftType) => {
if (!isDraftType(type)) return; const definition = getCreateIntegrationDefinition(type);
const defaults = cloneDraftDefaults(type); const defaults = cloneDraftDefaults(type);
setAddMenuOpen(false); setCreateDialogOpen(false);
setEditingId(null); setEditingId(null);
setDraftType(type); setDraftType(type);
setEditName( setEditName(
type === 'mqtt_community_meshrank' || definition.nameMode === 'fixed'
type === 'mqtt_community_letsmesh_us' || ? definition.defaultName
type === 'mqtt_community_letsmesh_eu' : getDefaultIntegrationName(definition.savedType, configs)
? DRAFT_RECIPES[type].defaultName
: getDefaultIntegrationName(DRAFT_RECIPES[type].savedType, configs)
); );
setEditConfig(defaults.config); setEditConfig(defaults.config);
setEditScope(defaults.scope); setEditScope(defaults.scope);
@@ -1683,13 +2055,15 @@ export function SettingsFanoutSection({
const editingConfig = editingId ? configs.find((c) => c.id === editingId) : null; const editingConfig = editingId ? configs.find((c) => c.id === editingId) : null;
const detailType = draftType ?? editingConfig?.type ?? null; const detailType = draftType ?? editingConfig?.type ?? null;
const isDraft = draftType !== null; const isDraft = draftType !== null;
const configGroups = LIST_TYPE_OPTIONS.map((opt) => ({ const configGroups = Object.entries(TYPE_LABELS)
type: opt.value, .map(([type, label]) => ({
label: opt.label, type,
configs: configs label,
.filter((cfg) => cfg.type === opt.value) configs: configs
.sort((a, b) => a.name.localeCompare(b.name, undefined, { sensitivity: 'base' })), .filter((cfg) => cfg.type === type)
})).filter((group) => group.configs.length > 0); .sort((a, b) => a.name.localeCompare(b.name, undefined, { sensitivity: 'base' })),
}))
.filter((group) => group.configs.length > 0);
// Detail view // Detail view
if (detailType) { if (detailType) {
@@ -1779,6 +2153,10 @@ export function SettingsFanoutSection({
/> />
)} )}
{detailType === 'map_upload' && (
<MapUploadConfigEditor config={editConfig} onChange={setEditConfig} />
)}
<Separator /> <Separator />
<div className="flex gap-2"> <div className="flex gap-2">
@@ -1817,42 +2195,53 @@ export function SettingsFanoutSection({
{health?.bots_disabled && ( {health?.bots_disabled && (
<div className="rounded-md border border-destructive/50 bg-destructive/10 px-4 py-3 text-sm text-destructive"> <div className="rounded-md border border-destructive/50 bg-destructive/10 px-4 py-3 text-sm text-destructive">
Bot system is disabled by server configuration (MESHCORE_DISABLE_BOTS). Bot integrations {health.bots_disabled_source === 'until_restart'
cannot be created or modified. ? 'Bot system is disabled until the server restarts. Bot integrations cannot run, be created, or be modified right now.'
: 'Bot system is disabled by server configuration (MESHCORE_DISABLE_BOTS). Bot integrations cannot run, be created, or be modified.'}
</div> </div>
)} )}
<div className="relative inline-block" ref={addMenuRef}> <Button type="button" size="sm" onClick={() => setCreateDialogOpen(true)}>
<Button Add Integration
type="button" </Button>
size="sm"
aria-haspopup="menu" <CreateIntegrationDialog
aria-expanded={addMenuOpen} open={createDialogOpen}
onClick={() => setAddMenuOpen((open) => !open)} options={availableCreateOptions}
> selectedType={selectedCreateType}
Add Integration onOpenChange={setCreateDialogOpen}
</Button> onSelect={setSelectedCreateType}
{addMenuOpen && ( onCreate={() => {
<div if (selectedCreateType) {
role="menu" handleAddCreate(selectedCreateType);
className="absolute left-0 top-full z-10 mt-2 min-w-72 rounded-md border border-input bg-background p-1 shadow-md" }
> }}
{CREATE_TYPE_OPTIONS.filter((opt) => opt.value !== 'bot' || !health?.bots_disabled).map( />
(opt) => (
<button <Dialog
key={opt.value} open={errorDialogState !== null}
type="button" onOpenChange={(open) => {
role="menuitem" if (!open) {
className="flex w-full rounded-sm px-3 py-2 text-left text-sm hover:bg-muted" setErrorDialogState(null);
onClick={() => handleAddCreate(opt.value)} }
> }}
{opt.label} >
</button> <DialogContent className="sm:max-w-md">
) <DialogHeader className="border-b border-border px-5 py-4">
)} <DialogTitle>
{errorDialogState ? `${errorDialogState.integrationName} Error` : 'Integration Error'}
</DialogTitle>
<DialogDescription>
Most recent backend error retained for this integration.
</DialogDescription>
</DialogHeader>
<div className="px-5 py-4 text-sm text-muted-foreground">
<p className="whitespace-pre-wrap break-words font-mono text-foreground">
{errorDialogState?.error}
</p>
</div> </div>
)} </DialogContent>
</div> </Dialog>
{configGroups.length > 0 && ( {configGroups.length > 0 && (
<div className="columns-1 gap-4 md:columns-2"> <div className="columns-1 gap-4 md:columns-2">
@@ -1867,6 +2256,7 @@ export function SettingsFanoutSection({
{group.configs.map((cfg) => { {group.configs.map((cfg) => {
const statusEntry = health?.fanout_statuses?.[cfg.id]; const statusEntry = health?.fanout_statuses?.[cfg.id];
const status = cfg.enabled ? statusEntry?.status : undefined; const status = cfg.enabled ? statusEntry?.status : undefined;
const lastError = cfg.enabled ? statusEntry?.last_error : null;
const communityConfig = cfg.config as Record<string, unknown>; const communityConfig = cfg.config as Record<string, unknown>;
return ( return (
<div <div
@@ -1933,6 +2323,25 @@ export function SettingsFanoutSection({
{cfg.enabled ? getStatusLabel(status, cfg.type) : 'Disabled'} {cfg.enabled ? getStatusLabel(status, cfg.type) : 'Disabled'}
</span> </span>
{lastError && (
<Button
type="button"
variant="ghost"
size="sm"
className="h-6 w-6 px-0"
onClick={() =>
setErrorDialogState({
integrationName: cfg.name,
error: lastError,
})
}
aria-label={`View error details for ${cfg.name}`}
title="View latest error"
>
<Info className="h-3.5 w-3.5" aria-hidden="true" />
</Button>
)}
<Button <Button
type="button" type="button"
variant="ghost" variant="ghost"
@@ -11,6 +11,12 @@ import {
} from '../../utils/lastViewedConversation'; } from '../../utils/lastViewedConversation';
import { ThemeSelector } from './ThemeSelector'; import { ThemeSelector } from './ThemeSelector';
import { getLocalLabel, setLocalLabel, type LocalLabel } from '../../utils/localLabel'; import { getLocalLabel, setLocalLabel, type LocalLabel } from '../../utils/localLabel';
import {
DISTANCE_UNIT_LABELS,
DISTANCE_UNITS,
setSavedDistanceUnit,
} from '../../utils/distanceUnits';
import { useDistanceUnit } from '../../contexts/DistanceUnitContext';
export function SettingsLocalSection({ export function SettingsLocalSection({
onLocalLabelChange, onLocalLabelChange,
@@ -19,6 +25,7 @@ export function SettingsLocalSection({
onLocalLabelChange?: (label: LocalLabel) => void; onLocalLabelChange?: (label: LocalLabel) => void;
className?: string; className?: string;
}) { }) {
const { distanceUnit, setDistanceUnit } = useDistanceUnit();
const [reopenLastConversation, setReopenLastConversation] = useState( const [reopenLastConversation, setReopenLastConversation] = useState(
getReopenLastConversationEnabled getReopenLastConversationEnabled
); );
@@ -82,6 +89,31 @@ export function SettingsLocalSection({
<Separator /> <Separator />
<div className="space-y-3">
<Label htmlFor="distance-units">Distance Units</Label>
<select
id="distance-units"
value={distanceUnit}
onChange={(event) => {
const nextUnit = event.target.value as (typeof DISTANCE_UNITS)[number];
setSavedDistanceUnit(nextUnit);
setDistanceUnit(nextUnit);
}}
className="w-full rounded-md border border-input bg-background px-3 py-2 text-sm"
>
{DISTANCE_UNITS.map((unit) => (
<option key={unit} value={unit}>
{DISTANCE_UNIT_LABELS[unit]}
</option>
))}
</select>
<p className="text-xs text-muted-foreground">
Controls how distances are shown throughout the app.
</p>
</div>
<Separator />
<label className="flex items-center gap-3 cursor-pointer"> <label className="flex items-center gap-3 cursor-pointer">
<input <input
type="checkbox" type="checkbox"
@@ -5,6 +5,7 @@ import { Label } from '../ui/label';
import { Button } from '../ui/button'; import { Button } from '../ui/button';
import { Separator } from '../ui/separator'; import { Separator } from '../ui/separator';
import { toast } from '../ui/sonner'; import { toast } from '../ui/sonner';
import { Checkbox } from '../ui/checkbox';
import { RADIO_PRESETS } from '../../utils/radioPresets'; import { RADIO_PRESETS } from '../../utils/radioPresets';
import { stripRegionScopePrefix } from '../../utils/regionScope'; import { stripRegionScopePrefix } from '../../utils/regionScope';
import type { import type {
@@ -64,6 +65,7 @@ export function SettingsRadioSection({
const [cr, setCr] = useState(''); const [cr, setCr] = useState('');
const [pathHashMode, setPathHashMode] = useState('0'); const [pathHashMode, setPathHashMode] = useState('0');
const [advertLocationSource, setAdvertLocationSource] = useState<'off' | 'current'>('current'); const [advertLocationSource, setAdvertLocationSource] = useState<'off' | 'current'>('current');
const [multiAcksEnabled, setMultiAcksEnabled] = useState(false);
const [gettingLocation, setGettingLocation] = useState(false); const [gettingLocation, setGettingLocation] = useState(false);
const [busy, setBusy] = useState(false); const [busy, setBusy] = useState(false);
const [rebooting, setRebooting] = useState(false); const [rebooting, setRebooting] = useState(false);
@@ -98,6 +100,7 @@ export function SettingsRadioSection({
setCr(String(config.radio.cr)); setCr(String(config.radio.cr));
setPathHashMode(String(config.path_hash_mode)); setPathHashMode(String(config.path_hash_mode));
setAdvertLocationSource(config.advert_location_source ?? 'current'); setAdvertLocationSource(config.advert_location_source ?? 'current');
setMultiAcksEnabled(config.multi_acks_enabled ?? false);
}, [config]); }, [config]);
useEffect(() => { useEffect(() => {
@@ -190,6 +193,9 @@ export function SettingsRadioSection({
...(advertLocationSource !== (config.advert_location_source ?? 'current') ...(advertLocationSource !== (config.advert_location_source ?? 'current')
? { advert_location_source: advertLocationSource } ? { advert_location_source: advertLocationSource }
: {}), : {}),
...(multiAcksEnabled !== (config.multi_acks_enabled ?? false)
? { multi_acks_enabled: multiAcksEnabled }
: {}),
radio: { radio: {
freq: parsedFreq, freq: parsedFreq,
bw: parsedBw, bw: parsedBw,
@@ -579,6 +585,24 @@ export function SettingsRadioSection({
library. library.
</p> </p>
</div> </div>
<div className="space-y-2">
<div className="flex items-start gap-3 rounded-md border border-border/60 p-3">
<Checkbox
id="multi-acks-enabled"
checked={multiAcksEnabled}
onCheckedChange={(checked) => setMultiAcksEnabled(checked === true)}
className="mt-0.5"
/>
<div className="space-y-1">
<Label htmlFor="multi-acks-enabled">Extra Direct ACK Transmission</Label>
<p className="text-xs text-muted-foreground">
When enabled, the radio sends one extra direct ACK transmission before the normal
ACK for received direct messages. This is a firmware-level receive behavior, not a
RemoteTerm retry setting.
</p>
</div>
</div>
</div>
</div> </div>
{config.path_hash_mode_supported && ( {config.path_hash_mode_supported && (
@@ -164,6 +164,12 @@ export function SettingsStatisticsSection({ className }: { className?: string })
<td className="text-right py-1">{stats.repeaters_heard.last_24_hours}</td> <td className="text-right py-1">{stats.repeaters_heard.last_24_hours}</td>
<td className="text-right py-1">{stats.repeaters_heard.last_week}</td> <td className="text-right py-1">{stats.repeaters_heard.last_week}</td>
</tr> </tr>
<tr>
<td className="py-1">Known-channels active</td>
<td className="text-right py-1">{stats.known_channels_active.last_hour}</td>
<td className="text-right py-1">{stats.known_channels_active.last_24_hours}</td>
<td className="text-right py-1">{stats.known_channels_active.last_week}</td>
</tr>
</tbody> </tbody>
</table> </table>
</div> </div>
+14 -6
View File
@@ -29,10 +29,16 @@ const DialogOverlay = React.forwardRef<
)); ));
DialogOverlay.displayName = DialogPrimitive.Overlay.displayName; DialogOverlay.displayName = DialogPrimitive.Overlay.displayName;
interface DialogContentProps extends React.ComponentPropsWithoutRef<
typeof DialogPrimitive.Content
> {
hideCloseButton?: boolean;
}
const DialogContent = React.forwardRef< const DialogContent = React.forwardRef<
React.ElementRef<typeof DialogPrimitive.Content>, React.ElementRef<typeof DialogPrimitive.Content>,
React.ComponentPropsWithoutRef<typeof DialogPrimitive.Content> DialogContentProps
>(({ className, children, ...props }, ref) => ( >(({ className, children, hideCloseButton = false, ...props }, ref) => (
<DialogPortal> <DialogPortal>
<DialogOverlay /> <DialogOverlay />
<DialogPrimitive.Content <DialogPrimitive.Content
@@ -44,10 +50,12 @@ const DialogContent = React.forwardRef<
{...props} {...props}
> >
{children} {children}
<DialogPrimitive.Close className="absolute right-4 top-4 rounded-sm opacity-70 ring-offset-background transition-opacity hover:opacity-100 focus:outline-none focus:ring-2 focus:ring-ring focus:ring-offset-2 disabled:pointer-events-none data-[state=open]:bg-accent data-[state=open]:text-muted-foreground"> {!hideCloseButton && (
<X className="h-4 w-4" /> <DialogPrimitive.Close className="absolute right-4 top-4 rounded-sm opacity-70 ring-offset-background transition-opacity hover:opacity-100 focus:outline-none focus:ring-2 focus:ring-ring focus:ring-offset-2 disabled:pointer-events-none data-[state=open]:bg-accent data-[state=open]:text-muted-foreground">
<span className="sr-only">Close</span> <X className="h-4 w-4" />
</DialogPrimitive.Close> <span className="sr-only">Close</span>
</DialogPrimitive.Close>
)}
</DialogPrimitive.Content> </DialogPrimitive.Content>
</DialogPortal> </DialogPortal>
)); ));
@@ -0,0 +1,31 @@
import { createContext, useContext, type ReactNode } from 'react';
import type { DistanceUnit } from '../utils/distanceUnits';
interface DistanceUnitContextValue {
distanceUnit: DistanceUnit;
setDistanceUnit: (unit: DistanceUnit) => void;
}
const noop = () => {};
const DistanceUnitContext = createContext<DistanceUnitContextValue>({
distanceUnit: 'metric',
setDistanceUnit: noop,
});
export function DistanceUnitProvider({
distanceUnit,
setDistanceUnit,
children,
}: DistanceUnitContextValue & { children: ReactNode }) {
return (
<DistanceUnitContext.Provider value={{ distanceUnit, setDistanceUnit }}>
{children}
</DistanceUnitContext.Provider>
);
}
export function useDistanceUnit() {
return useContext(DistanceUnitContext);
}
+2
View File
@@ -10,3 +10,5 @@ export { useRealtimeAppState } from './useRealtimeAppState';
export { useConversationActions } from './useConversationActions'; export { useConversationActions } from './useConversationActions';
export { useConversationNavigation } from './useConversationNavigation'; export { useConversationNavigation } from './useConversationNavigation';
export { useBrowserNotifications } from './useBrowserNotifications'; export { useBrowserNotifications } from './useBrowserNotifications';
export { useFaviconBadge, useUnreadTitle } from './useFaviconBadge';
export { useRawPacketStatsSession } from './useRawPacketStatsSession';
+6
View File
@@ -1,6 +1,7 @@
import { startTransition, useCallback, useEffect, useRef, useState } from 'react'; import { startTransition, useCallback, useEffect, useRef, useState } from 'react';
import { getLocalLabel, type LocalLabel } from '../utils/localLabel'; import { getLocalLabel, type LocalLabel } from '../utils/localLabel';
import { getSavedDistanceUnit, type DistanceUnit } from '../utils/distanceUnits';
import type { SettingsSection } from '../components/settings/settingsConstants'; import type { SettingsSection } from '../components/settings/settingsConstants';
import { parseHashSettingsSection, updateSettingsHash } from '../utils/urlHash'; import { parseHashSettingsSection, updateSettingsHash } from '../utils/urlHash';
@@ -12,10 +13,12 @@ interface UseAppShellResult {
showCracker: boolean; showCracker: boolean;
crackerRunning: boolean; crackerRunning: boolean;
localLabel: LocalLabel; localLabel: LocalLabel;
distanceUnit: DistanceUnit;
setSettingsSection: (section: SettingsSection) => void; setSettingsSection: (section: SettingsSection) => void;
setSidebarOpen: (open: boolean) => void; setSidebarOpen: (open: boolean) => void;
setCrackerRunning: (running: boolean) => void; setCrackerRunning: (running: boolean) => void;
setLocalLabel: (label: LocalLabel) => void; setLocalLabel: (label: LocalLabel) => void;
setDistanceUnit: (unit: DistanceUnit) => void;
handleCloseSettingsView: () => void; handleCloseSettingsView: () => void;
handleToggleSettingsView: () => void; handleToggleSettingsView: () => void;
handleOpenNewMessage: () => void; handleOpenNewMessage: () => void;
@@ -34,6 +37,7 @@ export function useAppShell(): UseAppShellResult {
const [showCracker, setShowCracker] = useState(false); const [showCracker, setShowCracker] = useState(false);
const [crackerRunning, setCrackerRunning] = useState(false); const [crackerRunning, setCrackerRunning] = useState(false);
const [localLabel, setLocalLabel] = useState(getLocalLabel); const [localLabel, setLocalLabel] = useState(getLocalLabel);
const [distanceUnit, setDistanceUnit] = useState(getSavedDistanceUnit);
const previousHashRef = useRef(''); const previousHashRef = useRef('');
useEffect(() => { useEffect(() => {
@@ -87,10 +91,12 @@ export function useAppShell(): UseAppShellResult {
showCracker, showCracker,
crackerRunning, crackerRunning,
localLabel, localLabel,
distanceUnit,
setSettingsSection, setSettingsSection,
setSidebarOpen, setSidebarOpen,
setCrackerRunning, setCrackerRunning,
setLocalLabel, setLocalLabel,
setDistanceUnit,
handleCloseSettingsView, handleCloseSettingsView,
handleToggleSettingsView, handleToggleSettingsView,
handleOpenNewMessage, handleOpenNewMessage,
+65 -8
View File
@@ -9,6 +9,17 @@ const NOTIFICATION_ICON_PATH = '/favicon-256x256.png';
type NotificationPermissionState = NotificationPermission | 'unsupported'; type NotificationPermissionState = NotificationPermission | 'unsupported';
type ConversationNotificationMap = Record<string, boolean>; type ConversationNotificationMap = Record<string, boolean>;
interface NotificationEnableToastInfo {
level: 'success' | 'warning';
title: string;
description?: string;
}
interface NotificationEnvironment {
protocol: string;
isSecureContext: boolean;
}
function getConversationNotificationKey(type: 'channel' | 'contact', id: string): string { function getConversationNotificationKey(type: 'channel' | 'contact', id: string): string {
return getStateKey(type, id); return getStateKey(type, id);
} }
@@ -92,6 +103,40 @@ function buildMessageNotificationHash(message: Message): string | null {
return null; return null;
} }
export function getNotificationEnableToastInfo(
environment?: Partial<NotificationEnvironment>
): NotificationEnableToastInfo {
if (typeof window === 'undefined') {
return { level: 'success', title: 'Notifications enabled' };
}
const protocol = environment?.protocol ?? window.location.protocol;
const isSecureContext = environment?.isSecureContext ?? window.isSecureContext;
if (protocol === 'http:') {
return {
level: 'warning',
title: 'Notifications enabled with warning',
description:
'Desktop notifications are on for this conversation, but you are using HTTP instead of HTTPS. Notifications will likely not work reliably.',
};
}
// Best-effort heuristic only. Browsers do not expose certificate trust details
// directly to page JS, so an HTTPS page that is not a secure context is the
// closest signal we have for an untrusted/self-signed setup.
if (protocol === 'https:' && !isSecureContext) {
return {
level: 'warning',
title: 'Notifications enabled with warning',
description:
'Desktop notifications are on for this conversation, but your HTTPS connection is untrusted, such as a self-signed certificate. Notification delivery may be inconsistent depending on your browser.',
};
}
return { level: 'success', title: 'Notifications enabled' };
}
export function useBrowserNotifications() { export function useBrowserNotifications() {
const [permission, setPermission] = useState<NotificationPermissionState>(getInitialPermission); const [permission, setPermission] = useState<NotificationPermissionState>(getInitialPermission);
const [enabledByConversation, setEnabledByConversation] = const [enabledByConversation, setEnabledByConversation] =
@@ -118,20 +163,23 @@ export function useBrowserNotifications() {
writeStoredEnabledMap(next); writeStoredEnabledMap(next);
return next; return next;
}); });
toast.success(`${label} notifications disabled`); toast.success('Notifications disabled', {
description: `Desktop notifications are off for ${label}.`,
});
return; return;
} }
if (permission === 'unsupported') { if (permission === 'unsupported') {
toast.error('Browser notifications unavailable', { toast.error('Notifications unavailable', {
description: 'This browser does not support desktop notifications.', description: 'This browser does not support desktop notifications.',
}); });
return; return;
} }
if (permission === 'denied') { if (permission === 'denied') {
toast.error('Browser notifications blocked', { toast.error('Notifications blocked', {
description: 'Allow notifications in your browser settings, then try again.', description:
'Desktop notifications are blocked by your browser. Allow notifications in browser settings, then try again. Non-HTTPS or untrusted HTTPS origins may also prevent notifications from working reliably.',
}); });
return; return;
} }
@@ -153,15 +201,24 @@ export function useBrowserNotifications() {
icon: NOTIFICATION_ICON_PATH, icon: NOTIFICATION_ICON_PATH,
tag: `meshcore-notification-preview-${conversationKey}`, tag: `meshcore-notification-preview-${conversationKey}`,
}); });
toast.success(`${label} notifications enabled`); const toastInfo = getNotificationEnableToastInfo();
if (toastInfo.level === 'warning') {
toast.warning(toastInfo.title, {
description: toastInfo.description,
});
} else {
toast.success(toastInfo.title, {
description: `Desktop notifications are on for ${label}.`,
});
}
return; return;
} }
toast.error('Browser notifications not enabled', { toast.error('Notifications not enabled', {
description: description:
nextPermission === 'denied' nextPermission === 'denied'
? 'Permission was denied by the browser.' ? 'Desktop notifications were denied by your browser. Allow notifications in browser settings, then try again.'
: 'Permission request was dismissed.', : 'The browser permission request was dismissed.',
}); });
}, },
[enabledByConversation, permission] [enabledByConversation, permission]
+86 -40
View File
@@ -21,6 +21,24 @@ interface InternalCachedConversationEntry extends CachedConversationEntry {
export class ConversationMessageCache { export class ConversationMessageCache {
private readonly cache = new Map<string, InternalCachedConversationEntry>(); private readonly cache = new Map<string, InternalCachedConversationEntry>();
private normalizeEntry(entry: CachedConversationEntry): InternalCachedConversationEntry {
let messages = entry.messages;
let hasOlderMessages = entry.hasOlderMessages;
if (messages.length > MAX_MESSAGES_PER_ENTRY) {
messages = [...messages]
.sort((a, b) => b.received_at - a.received_at)
.slice(0, MAX_MESSAGES_PER_ENTRY);
hasOlderMessages = true;
}
return {
messages,
hasOlderMessages,
contentKeys: new Set(messages.map((message) => getMessageContentKey(message))),
};
}
get(id: string): CachedConversationEntry | undefined { get(id: string): CachedConversationEntry | undefined {
const entry = this.cache.get(id); const entry = this.cache.get(id);
if (!entry) return undefined; if (!entry) return undefined;
@@ -33,17 +51,7 @@ export class ConversationMessageCache {
} }
set(id: string, entry: CachedConversationEntry): void { set(id: string, entry: CachedConversationEntry): void {
const contentKeys = new Set(entry.messages.map((message) => getMessageContentKey(message))); const internalEntry = this.normalizeEntry(entry);
if (entry.messages.length > MAX_MESSAGES_PER_ENTRY) {
const trimmed = [...entry.messages]
.sort((a, b) => b.received_at - a.received_at)
.slice(0, MAX_MESSAGES_PER_ENTRY);
entry = { ...entry, messages: trimmed, hasOlderMessages: true };
}
const internalEntry: InternalCachedConversationEntry = {
...entry,
contentKeys,
};
this.cache.delete(id); this.cache.delete(id);
this.cache.set(id, internalEntry); this.cache.set(id, internalEntry);
if (this.cache.size > MAX_CACHED_CONVERSATIONS) { if (this.cache.size > MAX_CACHED_CONVERSATIONS) {
@@ -69,19 +77,21 @@ export class ConversationMessageCache {
} }
if (entry.contentKeys.has(contentKey)) return false; if (entry.contentKeys.has(contentKey)) return false;
if (entry.messages.some((message) => message.id === msg.id)) return false; if (entry.messages.some((message) => message.id === msg.id)) return false;
entry.contentKeys.add(contentKey); const nextEntry = this.normalizeEntry({
entry.messages = [...entry.messages, msg]; messages: [...entry.messages, msg],
if (entry.messages.length > MAX_MESSAGES_PER_ENTRY) { hasOlderMessages: entry.hasOlderMessages,
entry.messages = [...entry.messages] });
.sort((a, b) => b.received_at - a.received_at)
.slice(0, MAX_MESSAGES_PER_ENTRY);
}
this.cache.delete(id); this.cache.delete(id);
this.cache.set(id, entry); this.cache.set(id, nextEntry);
return true; return true;
} }
updateAck(messageId: number, ackCount: number, paths?: MessagePath[]): void { updateAck(
messageId: number,
ackCount: number,
paths?: MessagePath[],
packetId?: number | null
): void {
for (const entry of this.cache.values()) { for (const entry of this.cache.values()) {
const index = entry.messages.findIndex((message) => message.id === messageId); const index = entry.messages.findIndex((message) => message.id === messageId);
if (index < 0) continue; if (index < 0) continue;
@@ -91,6 +101,7 @@ export class ConversationMessageCache {
...current, ...current,
acked: Math.max(current.acked, ackCount), acked: Math.max(current.acked, ackCount),
...(paths !== undefined && paths.length >= (current.paths?.length ?? 0) && { paths }), ...(paths !== undefined && paths.length >= (current.paths?.length ?? 0) && { paths }),
...(packetId !== undefined && { packet_id: packetId }),
}; };
entry.messages = updated; entry.messages = updated;
return; return;
@@ -123,11 +134,13 @@ export class ConversationMessageCache {
} }
this.cache.delete(oldId); this.cache.delete(oldId);
this.cache.set(newId, { this.cache.set(
messages: mergedMessages, newId,
hasOlderMessages: newEntry.hasOlderMessages || oldEntry.hasOlderMessages, this.normalizeEntry({
contentKeys: new Set([...newEntry.contentKeys, ...oldEntry.contentKeys]), messages: mergedMessages,
}); hasOlderMessages: newEntry.hasOlderMessages || oldEntry.hasOlderMessages,
})
);
} }
clear(): void { clear(): void {
@@ -139,12 +152,16 @@ export function reconcileConversationMessages(
current: Message[], current: Message[],
fetched: Message[] fetched: Message[]
): Message[] | null { ): Message[] | null {
const currentById = new Map<number, { acked: number; pathsLen: number; text: string }>(); const currentById = new Map<
number,
{ acked: number; pathsLen: number; text: string; packetId: number | null | undefined }
>();
for (const message of current) { for (const message of current) {
currentById.set(message.id, { currentById.set(message.id, {
acked: message.acked, acked: message.acked,
pathsLen: message.paths?.length ?? 0, pathsLen: message.paths?.length ?? 0,
text: message.text, text: message.text,
packetId: message.packet_id,
}); });
} }
@@ -155,7 +172,8 @@ export function reconcileConversationMessages(
!currentMessage || !currentMessage ||
currentMessage.acked !== message.acked || currentMessage.acked !== message.acked ||
currentMessage.pathsLen !== (message.paths?.length ?? 0) || currentMessage.pathsLen !== (message.paths?.length ?? 0) ||
currentMessage.text !== message.text currentMessage.text !== message.text ||
currentMessage.packetId !== message.packet_id
) { ) {
needsUpdate = true; needsUpdate = true;
break; break;
@@ -173,17 +191,20 @@ export const conversationMessageCache = new ConversationMessageCache();
interface PendingAckUpdate { interface PendingAckUpdate {
ackCount: number; ackCount: number;
paths?: MessagePath[]; paths?: MessagePath[];
packetId?: number | null;
} }
export function mergePendingAck( export function mergePendingAck(
existing: PendingAckUpdate | undefined, existing: PendingAckUpdate | undefined,
ackCount: number, ackCount: number,
paths?: MessagePath[] paths?: MessagePath[],
packetId?: number | null
): PendingAckUpdate { ): PendingAckUpdate {
if (!existing) { if (!existing) {
return { return {
ackCount, ackCount,
...(paths !== undefined && { paths }), ...(paths !== undefined && { paths }),
...(packetId !== undefined && { packetId }),
}; };
} }
@@ -192,6 +213,9 @@ export function mergePendingAck(
ackCount, ackCount,
...(paths !== undefined && { paths }), ...(paths !== undefined && { paths }),
...(paths === undefined && existing.paths !== undefined && { paths: existing.paths }), ...(paths === undefined && existing.paths !== undefined && { paths: existing.paths }),
...(packetId !== undefined && { packetId }),
...(packetId === undefined &&
existing.packetId !== undefined && { packetId: existing.packetId }),
}; };
} }
@@ -199,16 +223,31 @@ export function mergePendingAck(
return existing; return existing;
} }
const packetIdChanged = packetId !== undefined && packetId !== existing.packetId;
if (paths === undefined) { if (paths === undefined) {
return existing; if (!packetIdChanged) {
return existing;
}
return {
...existing,
packetId,
};
} }
const existingPathCount = existing.paths?.length ?? -1; const existingPathCount = existing.paths?.length ?? -1;
if (paths.length >= existingPathCount) { if (paths.length >= existingPathCount) {
return { ackCount, paths }; return { ackCount, paths, ...(packetId !== undefined && { packetId }) };
} }
return existing; if (!packetIdChanged) {
return existing;
}
return {
...existing,
packetId,
};
} }
interface UseConversationMessagesResult { interface UseConversationMessagesResult {
@@ -223,7 +262,12 @@ interface UseConversationMessagesResult {
jumpToBottom: () => void; jumpToBottom: () => void;
reloadCurrentConversation: () => void; reloadCurrentConversation: () => void;
observeMessage: (msg: Message) => { added: boolean; activeConversation: boolean }; observeMessage: (msg: Message) => { added: boolean; activeConversation: boolean };
receiveMessageAck: (messageId: number, ackCount: number, paths?: MessagePath[]) => void; receiveMessageAck: (
messageId: number,
ackCount: number,
paths?: MessagePath[],
packetId?: number | null
) => void;
reconcileOnReconnect: () => void; reconcileOnReconnect: () => void;
renameConversationMessages: (oldId: string, newId: string) => void; renameConversationMessages: (oldId: string, newId: string) => void;
removeConversationMessages: (conversationId: string) => void; removeConversationMessages: (conversationId: string) => void;
@@ -284,9 +328,9 @@ export function useConversationMessages(
const pendingAcksRef = useRef<Map<number, PendingAckUpdate>>(new Map()); const pendingAcksRef = useRef<Map<number, PendingAckUpdate>>(new Map());
const setPendingAck = useCallback( const setPendingAck = useCallback(
(messageId: number, ackCount: number, paths?: MessagePath[]) => { (messageId: number, ackCount: number, paths?: MessagePath[], packetId?: number | null) => {
const existing = pendingAcksRef.current.get(messageId); const existing = pendingAcksRef.current.get(messageId);
const merged = mergePendingAck(existing, ackCount, paths); const merged = mergePendingAck(existing, ackCount, paths, packetId);
// Update insertion order so most recent updates remain in the buffer longest. // Update insertion order so most recent updates remain in the buffer longest.
pendingAcksRef.current.delete(messageId); pendingAcksRef.current.delete(messageId);
@@ -312,6 +356,7 @@ export function useConversationMessages(
...msg, ...msg,
acked: Math.max(msg.acked, pending.ackCount), acked: Math.max(msg.acked, pending.ackCount),
...(pending.paths !== undefined && { paths: pending.paths }), ...(pending.paths !== undefined && { paths: pending.paths }),
...(pending.packetId !== undefined && { packet_id: pending.packetId }),
}; };
}, []); }, []);
const [messages, setMessages] = useState<Message[]>([]); const [messages, setMessages] = useState<Message[]>([]);
@@ -775,10 +820,10 @@ export function useConversationMessages(
// Update a message's ack count and paths // Update a message's ack count and paths
const updateMessageAck = useCallback( const updateMessageAck = useCallback(
(messageId: number, ackCount: number, paths?: MessagePath[]) => { (messageId: number, ackCount: number, paths?: MessagePath[], packetId?: number | null) => {
const hasMessageLoaded = messagesRef.current.some((m) => m.id === messageId); const hasMessageLoaded = messagesRef.current.some((m) => m.id === messageId);
if (!hasMessageLoaded) { if (!hasMessageLoaded) {
setPendingAck(messageId, ackCount, paths); setPendingAck(messageId, ackCount, paths, packetId);
return; return;
} }
@@ -800,10 +845,11 @@ export function useConversationMessages(
...current, ...current,
acked: nextAck, acked: nextAck,
...(paths !== undefined && { paths: nextPaths }), ...(paths !== undefined && { paths: nextPaths }),
...(packetId !== undefined && { packet_id: packetId }),
}; };
return updated; return updated;
} }
setPendingAck(messageId, ackCount, paths); setPendingAck(messageId, ackCount, paths, packetId);
return prev; return prev;
}); });
}, },
@@ -811,9 +857,9 @@ export function useConversationMessages(
); );
const receiveMessageAck = useCallback( const receiveMessageAck = useCallback(
(messageId: number, ackCount: number, paths?: MessagePath[]) => { (messageId: number, ackCount: number, paths?: MessagePath[], packetId?: number | null) => {
updateMessageAck(messageId, ackCount, paths); updateMessageAck(messageId, ackCount, paths, packetId);
conversationMessageCache.updateAck(messageId, ackCount, paths); conversationMessageCache.updateAck(messageId, ackCount, paths, packetId);
}, },
[updateMessageAck] [updateMessageAck]
); );
@@ -13,6 +13,7 @@ import {
} from '../utils/lastViewedConversation'; } from '../utils/lastViewedConversation';
import { findPublicChannel } from '../utils/publicChannel'; import { findPublicChannel } from '../utils/publicChannel';
import { getContactDisplayName } from '../utils/pubkey'; import { getContactDisplayName } from '../utils/pubkey';
import { toast } from '../components/ui/sonner';
import type { Channel, Contact, Conversation } from '../types'; import type { Channel, Contact, Conversation } from '../types';
interface UseConversationRouterArgs { interface UseConversationRouterArgs {
@@ -137,6 +138,11 @@ export function useConversationRouter({
// No hash or unresolvable — default to Public // No hash or unresolvable — default to Public
const publicConversation = getPublicChannelConversation(); const publicConversation = getPublicChannelConversation();
if (publicConversation) { if (publicConversation) {
if (hashConv?.type === 'channel') {
const token =
hashConv.name.length > 16 ? hashConv.name.substring(0, 16) + '…' : hashConv.name;
toast.error(`Channel not found: ${token}`);
}
setActiveConversationState(publicConversation); setActiveConversationState(publicConversation);
hasSetDefaultConversation.current = true; hasSetDefaultConversation.current = true;
} }
@@ -162,6 +168,9 @@ export function useConversationRouter({
} }
// Contact hash didn't match — fall back to Public if channels loaded. // Contact hash didn't match — fall back to Public if channels loaded.
const token =
hashConv.name.length > 16 ? hashConv.name.substring(0, 16) + '…' : hashConv.name;
toast.error(`Contact not found: ${token}`);
const publicConversation = getPublicChannelConversation(); const publicConversation = getPublicChannelConversation();
if (publicConversation) { if (publicConversation) {
setActiveConversationState(publicConversation); setActiveConversationState(publicConversation);
+196
View File
@@ -0,0 +1,196 @@
import { useEffect, useMemo, useRef } from 'react';
import type { Favorite } from '../types';
import { getStateKey } from '../utils/conversationState';
const APP_TITLE = 'RemoteTerm for MeshCore';
const UNREAD_APP_TITLE = 'RemoteTerm';
const BASE_FAVICON_PATH = '/favicon.svg';
const GREEN_BADGE_FILL = '#16a34a';
const RED_BADGE_FILL = '#dc2626';
const BADGE_CENTER = 750;
const BADGE_OUTER_RADIUS = 220;
const BADGE_INNER_RADIUS = 180;
let baseFaviconSvgPromise: Promise<string> | null = null;
export type FaviconBadgeState = 'none' | 'green' | 'red';
function getUnreadDirectMessageCount(unreadCounts: Record<string, number>): number {
return Object.entries(unreadCounts).reduce(
(sum, [stateKey, count]) => sum + (stateKey.startsWith('contact-') ? count : 0),
0
);
}
function getUnreadFavoriteChannelCount(
unreadCounts: Record<string, number>,
favorites: Favorite[]
): number {
return favorites.reduce(
(sum, favorite) =>
sum +
(favorite.type === 'channel' ? unreadCounts[getStateKey('channel', favorite.id)] || 0 : 0),
0
);
}
export function getTotalUnreadCount(unreadCounts: Record<string, number>): number {
return Object.values(unreadCounts).reduce((sum, count) => sum + count, 0);
}
export function getFavoriteUnreadCount(
unreadCounts: Record<string, number>,
favorites: Favorite[]
): number {
return favorites.reduce((sum, favorite) => {
const stateKey = getStateKey(favorite.type, favorite.id);
return sum + (unreadCounts[stateKey] || 0);
}, 0);
}
export function getUnreadTitle(
unreadCounts: Record<string, number>,
favorites: Favorite[]
): string {
const unreadCount = getFavoriteUnreadCount(unreadCounts, favorites);
if (unreadCount <= 0) {
return APP_TITLE;
}
const label = unreadCount > 99 ? '99+' : String(unreadCount);
return `(${label}) ${UNREAD_APP_TITLE}`;
}
export function deriveFaviconBadgeState(
unreadCounts: Record<string, number>,
mentions: Record<string, boolean>,
favorites: Favorite[]
): FaviconBadgeState {
if (Object.values(mentions).some(Boolean) || getUnreadDirectMessageCount(unreadCounts) > 0) {
return 'red';
}
if (getUnreadFavoriteChannelCount(unreadCounts, favorites) > 0) {
return 'green';
}
return 'none';
}
export function buildBadgedFaviconSvg(baseSvg: string, badgeFill: string): string {
const closingTagIndex = baseSvg.lastIndexOf('</svg>');
if (closingTagIndex === -1) {
return baseSvg;
}
const badge = `
<circle cx="${BADGE_CENTER}" cy="${BADGE_CENTER}" r="${BADGE_OUTER_RADIUS}" fill="#ffffff"/>
<circle cx="${BADGE_CENTER}" cy="${BADGE_CENTER}" r="${BADGE_INNER_RADIUS}" fill="${badgeFill}"/>
`;
return `${baseSvg.slice(0, closingTagIndex)}${badge}</svg>`;
}
async function loadBaseFaviconSvg(): Promise<string> {
if (!baseFaviconSvgPromise) {
baseFaviconSvgPromise = fetch(BASE_FAVICON_PATH, { cache: 'force-cache' })
.then(async (response) => {
if (!response.ok) {
throw new Error(`Failed to load favicon SVG: ${response.status}`);
}
return response.text();
})
.catch((error) => {
baseFaviconSvgPromise = null;
throw error;
});
}
return baseFaviconSvgPromise;
}
function upsertFaviconLinks(rel: 'icon' | 'shortcut icon', href: string): void {
const links = Array.from(document.head.querySelectorAll<HTMLLinkElement>(`link[rel="${rel}"]`));
const targets = links.length > 0 ? links : [document.createElement('link')];
for (const link of targets) {
if (!link.parentNode) {
link.rel = rel;
document.head.appendChild(link);
}
link.type = 'image/svg+xml';
link.href = href;
}
}
function applyFaviconHref(href: string): void {
upsertFaviconLinks('icon', href);
upsertFaviconLinks('shortcut icon', href);
}
export function useUnreadTitle(unreadCounts: Record<string, number>, favorites: Favorite[]): void {
const title = useMemo(() => getUnreadTitle(unreadCounts, favorites), [favorites, unreadCounts]);
useEffect(() => {
document.title = title;
return () => {
document.title = APP_TITLE;
};
}, [title]);
}
export function useFaviconBadge(
unreadCounts: Record<string, number>,
mentions: Record<string, boolean>,
favorites: Favorite[]
): void {
const objectUrlRef = useRef<string | null>(null);
const badgeState = useMemo(
() => deriveFaviconBadgeState(unreadCounts, mentions, favorites),
[favorites, mentions, unreadCounts]
);
useEffect(() => {
if (objectUrlRef.current) {
URL.revokeObjectURL(objectUrlRef.current);
objectUrlRef.current = null;
}
if (badgeState === 'none') {
applyFaviconHref(BASE_FAVICON_PATH);
return;
}
const badgeFill = badgeState === 'red' ? RED_BADGE_FILL : GREEN_BADGE_FILL;
let cancelled = false;
void loadBaseFaviconSvg()
.then((baseSvg) => {
if (cancelled) {
return;
}
const objectUrl = URL.createObjectURL(
new Blob([buildBadgedFaviconSvg(baseSvg, badgeFill)], {
type: 'image/svg+xml',
})
);
objectUrlRef.current = objectUrl;
applyFaviconHref(objectUrl);
})
.catch(() => {
if (!cancelled) {
applyFaviconHref(BASE_FAVICON_PATH);
}
});
return () => {
cancelled = true;
if (objectUrlRef.current) {
URL.revokeObjectURL(objectUrlRef.current);
objectUrlRef.current = null;
}
};
}, [badgeState]);
}
@@ -0,0 +1,52 @@
import { useCallback, useState } from 'react';
import type { RawPacket } from '../types';
import {
MAX_RAW_PACKET_STATS_OBSERVATIONS,
summarizeRawPacketForStats,
type RawPacketStatsSessionState,
} from '../utils/rawPacketStats';
export function useRawPacketStatsSession() {
const [session, setSession] = useState<RawPacketStatsSessionState>(() => ({
sessionStartedAt: Date.now(),
totalObservedPackets: 0,
trimmedObservationCount: 0,
observations: [],
}));
const recordRawPacketObservation = useCallback((packet: RawPacket) => {
setSession((prev) => {
const observation = summarizeRawPacketForStats(packet);
if (
prev.observations.some(
(candidate) => candidate.observationKey === observation.observationKey
)
) {
return prev;
}
const observations = [...prev.observations, observation];
if (observations.length <= MAX_RAW_PACKET_STATS_OBSERVATIONS) {
return {
...prev,
totalObservedPackets: prev.totalObservedPackets + 1,
observations,
};
}
const overflow = observations.length - MAX_RAW_PACKET_STATS_OBSERVATIONS;
return {
...prev,
totalObservedPackets: prev.totalObservedPackets + 1,
trimmedObservationCount: prev.trimmedObservationCount + overflow,
observations: observations.slice(overflow),
};
});
}, []);
return {
rawPacketStatsSession: session,
recordRawPacketObservation,
};
}
+17 -3
View File
@@ -48,8 +48,14 @@ interface UseRealtimeAppStateArgs {
setActiveConversation: (conv: Conversation | null) => void; setActiveConversation: (conv: Conversation | null) => void;
renameConversationMessages: (oldId: string, newId: string) => void; renameConversationMessages: (oldId: string, newId: string) => void;
removeConversationMessages: (conversationId: string) => void; removeConversationMessages: (conversationId: string) => void;
receiveMessageAck: (messageId: number, ackCount: number, paths?: MessagePath[]) => void; receiveMessageAck: (
messageId: number,
ackCount: number,
paths?: MessagePath[],
packetId?: number | null
) => void;
notifyIncomingMessage?: (msg: Message) => void; notifyIncomingMessage?: (msg: Message) => void;
recordRawPacketObservation?: (packet: RawPacket) => void;
maxRawPackets?: number; maxRawPackets?: number;
} }
@@ -97,6 +103,7 @@ export function useRealtimeAppState({
removeConversationMessages, removeConversationMessages,
receiveMessageAck, receiveMessageAck,
notifyIncomingMessage, notifyIncomingMessage,
recordRawPacketObservation,
maxRawPackets = 500, maxRawPackets = 500,
}: UseRealtimeAppStateArgs): UseWebSocketOptions { }: UseRealtimeAppStateArgs): UseWebSocketOptions {
const mergeChannelIntoList = useCallback( const mergeChannelIntoList = useCallback(
@@ -241,10 +248,16 @@ export function useRealtimeAppState({
} }
}, },
onRawPacket: (packet: RawPacket) => { onRawPacket: (packet: RawPacket) => {
recordRawPacketObservation?.(packet);
setRawPackets((prev) => appendRawPacketUnique(prev, packet, maxRawPackets)); setRawPackets((prev) => appendRawPacketUnique(prev, packet, maxRawPackets));
}, },
onMessageAcked: (messageId: number, ackCount: number, paths?: MessagePath[]) => { onMessageAcked: (
receiveMessageAck(messageId, ackCount, paths); messageId: number,
ackCount: number,
paths?: MessagePath[],
packetId?: number | null
) => {
receiveMessageAck(messageId, ackCount, paths, packetId);
}, },
}), }),
[ [
@@ -261,6 +274,7 @@ export function useRealtimeAppState({
pendingDeleteFallbackRef, pendingDeleteFallbackRef,
prevHealthRef, prevHealthRef,
recordMessageEvent, recordMessageEvent,
recordRawPacketObservation,
receiveMessageAck, receiveMessageAck,
observeMessage, observeMessage,
refreshUnreads, refreshUnreads,
@@ -0,0 +1,89 @@
import { useCallback, useEffect, useMemo, useState } from 'react';
type ServerLoginKind = 'repeater' | 'room';
type StoredPassword = {
password: string;
};
const STORAGE_KEY_PREFIX = 'remoteterm-server-password';
const inMemoryPasswords = new Map<string, StoredPassword>();
function getStorageKey(kind: ServerLoginKind, publicKey: string): string {
return `${STORAGE_KEY_PREFIX}:${kind}:${publicKey}`;
}
function loadStoredPassword(kind: ServerLoginKind, publicKey: string): StoredPassword | null {
try {
const raw = localStorage.getItem(getStorageKey(kind, publicKey));
if (!raw) return null;
const parsed = JSON.parse(raw) as Partial<StoredPassword>;
if (typeof parsed.password !== 'string' || parsed.password.length === 0) {
return null;
}
return { password: parsed.password };
} catch {
return null;
}
}
export function useRememberedServerPassword(kind: ServerLoginKind, publicKey: string) {
const storageKey = useMemo(() => getStorageKey(kind, publicKey), [kind, publicKey]);
const [password, setPassword] = useState('');
const [rememberPassword, setRememberPassword] = useState(false);
useEffect(() => {
const stored = loadStoredPassword(kind, publicKey);
if (stored) {
setPassword(stored.password);
setRememberPassword(true);
return;
}
const inMemoryStored = inMemoryPasswords.get(storageKey);
if (inMemoryStored) {
setPassword(inMemoryStored.password);
setRememberPassword(false);
return;
}
setPassword('');
setRememberPassword(false);
}, [kind, publicKey, storageKey]);
const persistAfterLogin = useCallback(
(submittedPassword: string) => {
const trimmedPassword = submittedPassword.trim();
if (!trimmedPassword) {
return;
}
inMemoryPasswords.set(storageKey, { password: trimmedPassword });
if (!rememberPassword) {
try {
localStorage.removeItem(storageKey);
} catch {
// localStorage may be unavailable
}
} else {
try {
localStorage.setItem(storageKey, JSON.stringify({ password: trimmedPassword }));
} catch {
// localStorage may be unavailable
}
}
setPassword(trimmedPassword);
},
[rememberPassword, storageKey]
);
return {
password,
setPassword,
rememberPassword,
setRememberPassword,
persistAfterLogin,
};
}
+26 -1
View File
@@ -15,6 +15,11 @@ import type {
RepeaterLppTelemetryResponse, RepeaterLppTelemetryResponse,
CommandResponse, CommandResponse,
} from '../types'; } from '../types';
import {
buildServerLoginAttemptFromError,
buildServerLoginAttemptFromResponse,
type ServerLoginAttemptState,
} from '../utils/serverLoginState';
const MAX_RETRIES = 3; const MAX_RETRIES = 3;
const RETRY_DELAY_MS = 2000; const RETRY_DELAY_MS = 2000;
@@ -41,6 +46,7 @@ interface PaneData {
interface RepeaterDashboardCacheEntry { interface RepeaterDashboardCacheEntry {
loggedIn: boolean; loggedIn: boolean;
loginError: string | null; loginError: string | null;
lastLoginAttempt: ServerLoginAttemptState | null;
paneData: PaneData; paneData: PaneData;
paneStates: Record<PaneName, PaneState>; paneStates: Record<PaneName, PaneState>;
consoleHistory: ConsoleEntry[]; consoleHistory: ConsoleEntry[];
@@ -119,6 +125,7 @@ function getCachedState(publicKey: string | null): RepeaterDashboardCacheEntry |
return { return {
loggedIn: cached.loggedIn, loggedIn: cached.loggedIn,
loginError: cached.loginError, loginError: cached.loginError,
lastLoginAttempt: cached.lastLoginAttempt,
paneData: clonePaneData(cached.paneData), paneData: clonePaneData(cached.paneData),
paneStates: normalizePaneStates(cached.paneStates), paneStates: normalizePaneStates(cached.paneStates),
consoleHistory: cloneConsoleHistory(cached.consoleHistory), consoleHistory: cloneConsoleHistory(cached.consoleHistory),
@@ -130,6 +137,7 @@ function cacheState(publicKey: string, entry: RepeaterDashboardCacheEntry) {
repeaterDashboardCache.set(publicKey, { repeaterDashboardCache.set(publicKey, {
loggedIn: entry.loggedIn, loggedIn: entry.loggedIn,
loginError: entry.loginError, loginError: entry.loginError,
lastLoginAttempt: entry.lastLoginAttempt,
paneData: clonePaneData(entry.paneData), paneData: clonePaneData(entry.paneData),
paneStates: normalizePaneStates(entry.paneStates), paneStates: normalizePaneStates(entry.paneStates),
consoleHistory: cloneConsoleHistory(entry.consoleHistory), consoleHistory: cloneConsoleHistory(entry.consoleHistory),
@@ -173,6 +181,7 @@ export interface UseRepeaterDashboardResult {
loggedIn: boolean; loggedIn: boolean;
loginLoading: boolean; loginLoading: boolean;
loginError: string | null; loginError: string | null;
lastLoginAttempt: ServerLoginAttemptState | null;
paneData: PaneData; paneData: PaneData;
paneStates: Record<PaneName, PaneState>; paneStates: Record<PaneName, PaneState>;
consoleHistory: ConsoleEntry[]; consoleHistory: ConsoleEntry[];
@@ -203,6 +212,9 @@ export function useRepeaterDashboard(
const [loggedIn, setLoggedIn] = useState(cachedState?.loggedIn ?? false); const [loggedIn, setLoggedIn] = useState(cachedState?.loggedIn ?? false);
const [loginLoading, setLoginLoading] = useState(false); const [loginLoading, setLoginLoading] = useState(false);
const [loginError, setLoginError] = useState<string | null>(cachedState?.loginError ?? null); const [loginError, setLoginError] = useState<string | null>(cachedState?.loginError ?? null);
const [lastLoginAttempt, setLastLoginAttempt] = useState<ServerLoginAttemptState | null>(
cachedState?.lastLoginAttempt ?? null
);
const [paneData, setPaneData] = useState<PaneData>( const [paneData, setPaneData] = useState<PaneData>(
cachedState?.paneData ?? createInitialPaneData cachedState?.paneData ?? createInitialPaneData
@@ -243,11 +255,20 @@ export function useRepeaterDashboard(
cacheState(conversationId, { cacheState(conversationId, {
loggedIn, loggedIn,
loginError, loginError,
lastLoginAttempt,
paneData, paneData,
paneStates, paneStates,
consoleHistory, consoleHistory,
}); });
}, [consoleHistory, conversationId, loggedIn, loginError, paneData, paneStates]); }, [
consoleHistory,
conversationId,
loggedIn,
loginError,
lastLoginAttempt,
paneData,
paneStates,
]);
useEffect(() => { useEffect(() => {
paneDataRef.current = paneData; paneDataRef.current = paneData;
@@ -267,12 +288,14 @@ export function useRepeaterDashboard(
const publicKey = getPublicKey(); const publicKey = getPublicKey();
if (!publicKey) return; if (!publicKey) return;
const conversationId = publicKey; const conversationId = publicKey;
const method = password.trim().length > 0 ? 'password' : 'blank';
setLoginLoading(true); setLoginLoading(true);
setLoginError(null); setLoginError(null);
try { try {
const result = await api.repeaterLogin(publicKey, password); const result = await api.repeaterLogin(publicKey, password);
if (activeIdRef.current !== conversationId) return; if (activeIdRef.current !== conversationId) return;
setLastLoginAttempt(buildServerLoginAttemptFromResponse(method, result, 'repeater'));
setLoggedIn(true); setLoggedIn(true);
if (!result.authenticated) { if (!result.authenticated) {
const msg = result.message ?? 'Repeater login was not confirmed'; const msg = result.message ?? 'Repeater login was not confirmed';
@@ -282,6 +305,7 @@ export function useRepeaterDashboard(
} catch (err) { } catch (err) {
if (activeIdRef.current !== conversationId) return; if (activeIdRef.current !== conversationId) return;
const msg = err instanceof Error ? err.message : 'Login failed'; const msg = err instanceof Error ? err.message : 'Login failed';
setLastLoginAttempt(buildServerLoginAttemptFromError(method, msg, 'repeater'));
setLoggedIn(true); setLoggedIn(true);
setLoginError(msg); setLoginError(msg);
toast.error('Login request failed', { toast.error('Login request failed', {
@@ -475,6 +499,7 @@ export function useRepeaterDashboard(
loggedIn, loggedIn,
loginLoading, loginLoading,
loginError, loginError,
lastLoginAttempt,
paneData, paneData,
paneStates, paneStates,
consoleHistory, consoleHistory,
@@ -3,6 +3,7 @@ import { describe, expect, it, vi } from 'vitest';
import { ChatHeader } from '../components/ChatHeader'; import { ChatHeader } from '../components/ChatHeader';
import type { Channel, Contact, Conversation, Favorite, PathDiscoveryResponse } from '../types'; import type { Channel, Contact, Conversation, Favorite, PathDiscoveryResponse } from '../types';
import { CONTACT_TYPE_ROOM } from '../types';
import { PUBLIC_CHANNEL_KEY } from '../utils/publicChannel'; import { PUBLIC_CHANNEL_KEY } from '../utils/publicChannel';
function makeChannel(key: string, name: string, isHashtag: boolean): Channel { function makeChannel(key: string, name: string, isHashtag: boolean): Channel {
@@ -170,6 +171,38 @@ describe('ChatHeader key visibility', () => {
expect(onToggleNotifications).toHaveBeenCalledTimes(1); expect(onToggleNotifications).toHaveBeenCalledTimes(1);
}); });
it('hides trace and notification controls for room-server contacts', () => {
const pubKey = '41'.repeat(32);
const contact: Contact = {
public_key: pubKey,
name: 'Ops Board',
type: CONTACT_TYPE_ROOM,
flags: 0,
direct_path: null,
direct_path_len: -1,
direct_path_hash_mode: -1,
last_advert: null,
lat: null,
lon: null,
last_seen: null,
on_radio: false,
last_contacted: null,
last_read_at: null,
first_seen: null,
};
const conversation: Conversation = { type: 'contact', id: pubKey, name: 'Ops Board' };
render(
<ChatHeader {...baseProps} conversation={conversation} channels={[]} contacts={[contact]} />
);
expect(screen.queryByRole('button', { name: 'Path Discovery' })).not.toBeInTheDocument();
expect(screen.queryByRole('button', { name: 'Direct Trace' })).not.toBeInTheDocument();
expect(
screen.queryByRole('button', { name: 'Enable notifications for this conversation' })
).not.toBeInTheDocument();
});
it('hides the delete button for the canonical Public channel', () => { it('hides the delete button for the canonical Public channel', () => {
const channel = makeChannel(PUBLIC_CHANNEL_KEY, 'Public', false); const channel = makeChannel(PUBLIC_CHANNEL_KEY, 'Public', false);
const conversation: Conversation = { type: 'channel', id: PUBLIC_CHANNEL_KEY, name: 'Public' }; const conversation: Conversation = { type: 'channel', id: PUBLIC_CHANNEL_KEY, name: 'Public' };
+8 -1
View File
@@ -1,6 +1,6 @@
import { describe, it, expect } from 'vitest'; import { describe, it, expect } from 'vitest';
import { getContactAvatar } from '../utils/contactAvatar'; import { getContactAvatar } from '../utils/contactAvatar';
import { CONTACT_TYPE_REPEATER } from '../types'; import { CONTACT_TYPE_REPEATER, CONTACT_TYPE_ROOM } from '../types';
describe('getContactAvatar', () => { describe('getContactAvatar', () => {
it('returns complete avatar info', () => { it('returns complete avatar info', () => {
@@ -30,6 +30,13 @@ describe('getContactAvatar', () => {
expect(avatar1.background).toBe(avatar2.background); expect(avatar1.background).toBe(avatar2.background);
}); });
it('returns room avatar for type=3', () => {
const avatar = getContactAvatar('Ops Board', 'abc123def456', CONTACT_TYPE_ROOM);
expect(avatar.text).toBe('🛖');
expect(avatar.background).toBe('#6b4f2a');
expect(avatar.textColor).toBe('#ffffff');
});
it('non-repeater types use normal avatar', () => { it('non-repeater types use normal avatar', () => {
const avatar0 = getContactAvatar('John', 'abc123', 0); const avatar0 = getContactAvatar('John', 'abc123', 0);
const avatar1 = getContactAvatar('John', 'abc123', 1); const avatar1 = getContactAvatar('John', 'abc123', 1);
+2 -2
View File
@@ -150,7 +150,7 @@ describe('ContactInfoPane', () => {
}); });
}); });
it('loads name-only channel stats and most active rooms', async () => { it('loads name-only channel stats and most active channels', async () => {
getContactAnalytics.mockResolvedValue( getContactAnalytics.mockResolvedValue(
createAnalytics(null, { createAnalytics(null, {
lookup_type: 'name', lookup_type: 'name',
@@ -188,7 +188,7 @@ describe('ContactInfoPane', () => {
expect(screen.getByText('Name First In Use')).toBeInTheDocument(); expect(screen.getByText('Name First In Use')).toBeInTheDocument();
expect(screen.getByText('Messages Per Hour')).toBeInTheDocument(); expect(screen.getByText('Messages Per Hour')).toBeInTheDocument();
expect(screen.getByText('Messages Per Week')).toBeInTheDocument(); expect(screen.getByText('Messages Per Week')).toBeInTheDocument();
expect(screen.getByText('Most Active Rooms')).toBeInTheDocument(); expect(screen.getByText('Most Active Channels')).toBeInTheDocument();
expect(screen.getByText('#ops')).toBeInTheDocument(); expect(screen.getByText('#ops')).toBeInTheDocument();
expect( expect(
screen.getByText(/Name-only analytics include channel messages only/i) screen.getByText(/Name-only analytics include channel messages only/i)
+73 -1
View File
@@ -1,5 +1,5 @@
import React from 'react'; import React from 'react';
import { render, screen, waitFor } from '@testing-library/react'; import { fireEvent, render, screen, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest'; import { beforeEach, describe, expect, it, vi } from 'vitest';
import { ConversationPane } from '../components/ConversationPane'; import { ConversationPane } from '../components/ConversationPane';
@@ -12,6 +12,7 @@ import type {
Message, Message,
RadioConfig, RadioConfig,
} from '../types'; } from '../types';
import type { RawPacketStatsSessionState } from '../utils/rawPacketStats';
const mocks = vi.hoisted(() => ({ const mocks = vi.hoisted(() => ({
messageList: vi.fn(() => <div data-testid="message-list" />), messageList: vi.fn(() => <div data-testid="message-list" />),
@@ -40,6 +41,21 @@ vi.mock('../components/RepeaterDashboard', () => ({
RepeaterDashboard: () => <div data-testid="repeater-dashboard" />, RepeaterDashboard: () => <div data-testid="repeater-dashboard" />,
})); }));
vi.mock('../components/RoomServerPanel', () => ({
RoomServerPanel: ({
onAuthenticatedChange,
}: {
onAuthenticatedChange?: (value: boolean) => void;
}) => (
<div>
<div data-testid="room-server-panel" />
<button type="button" onClick={() => onAuthenticatedChange?.(true)}>
Authenticate room
</button>
</div>
),
}));
vi.mock('../components/MapView', () => ({ vi.mock('../components/MapView', () => ({
MapView: () => <div data-testid="map-view" />, MapView: () => <div data-testid="map-view" />,
})); }));
@@ -95,12 +111,20 @@ const message: Message = {
sender_name: null, sender_name: null,
}; };
const rawPacketStatsSession: RawPacketStatsSessionState = {
sessionStartedAt: 1_700_000_000_000,
totalObservedPackets: 0,
trimmedObservationCount: 0,
observations: [],
};
function createProps(overrides: Partial<React.ComponentProps<typeof ConversationPane>> = {}) { function createProps(overrides: Partial<React.ComponentProps<typeof ConversationPane>> = {}) {
return { return {
activeConversation: null as Conversation | null, activeConversation: null as Conversation | null,
contacts: [] as Contact[], contacts: [] as Contact[],
channels: [channel], channels: [channel],
rawPackets: [], rawPackets: [],
rawPacketStatsSession,
config, config,
health, health,
notificationsSupported: true, notificationsSupported: true,
@@ -207,6 +231,54 @@ describe('ConversationPane', () => {
}); });
}); });
it('gates room chat behind room login controls until authenticated', async () => {
render(
<ConversationPane
{...createProps({
activeConversation: {
type: 'contact',
id: 'cc'.repeat(32),
name: 'Ops Board',
},
contacts: [
{
public_key: 'cc'.repeat(32),
name: 'Ops Board',
type: 3,
flags: 0,
direct_path: null,
direct_path_len: -1,
direct_path_hash_mode: -1,
last_advert: null,
lat: null,
lon: null,
last_seen: null,
on_radio: false,
last_contacted: null,
last_read_at: null,
first_seen: null,
},
],
})}
/>
);
await waitFor(() => {
expect(screen.getByTestId('room-server-panel')).toBeInTheDocument();
expect(screen.getByTestId('chat-header')).toBeInTheDocument();
});
expect(screen.queryByTestId('message-list')).not.toBeInTheDocument();
expect(screen.queryByTestId('message-input')).not.toBeInTheDocument();
fireEvent.click(screen.getByRole('button', { name: 'Authenticate room' }));
await waitFor(() => {
expect(screen.getByTestId('message-list')).toBeInTheDocument();
expect(screen.getByTestId('message-input')).toBeInTheDocument();
});
});
it('passes unread marker props to MessageList only for channel conversations', async () => { it('passes unread marker props to MessageList only for channel conversations', async () => {
render( render(
<ConversationPane <ConversationPane
+32
View File
@@ -0,0 +1,32 @@
import { beforeEach, describe, expect, it } from 'vitest';
import {
DISTANCE_UNIT_KEY,
getSavedDistanceUnit,
setSavedDistanceUnit,
} from '../utils/distanceUnits';
describe('distanceUnits utilities', () => {
beforeEach(() => {
localStorage.clear();
});
it('defaults to metric when unset', () => {
expect(getSavedDistanceUnit()).toBe('metric');
});
it('returns the stored unit when valid', () => {
localStorage.setItem(DISTANCE_UNIT_KEY, 'metric');
expect(getSavedDistanceUnit()).toBe('metric');
});
it('falls back to metric for invalid stored values', () => {
localStorage.setItem(DISTANCE_UNIT_KEY, 'parsecs');
expect(getSavedDistanceUnit()).toBe('metric');
});
it('stores the selected distance unit', () => {
setSavedDistanceUnit('smoots');
expect(localStorage.getItem(DISTANCE_UNIT_KEY)).toBe('smoots');
});
});
+205 -100
View File
@@ -12,6 +12,7 @@ vi.mock('../api', () => ({
deleteFanoutConfig: vi.fn(), deleteFanoutConfig: vi.fn(),
getChannels: vi.fn(), getChannels: vi.fn(),
getContacts: vi.fn(), getContacts: vi.fn(),
getRadioConfig: vi.fn(),
}, },
})); }));
@@ -67,44 +68,110 @@ function renderSectionWithRefresh(
); );
} }
function startsWithAccessibleName(name: string) {
const escaped = name.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
return new RegExp(`^${escaped}(?:\\s|$)`);
}
async function openCreateIntegrationDialog() {
await waitFor(() => {
expect(screen.getByRole('button', { name: 'Add Integration' })).toBeInTheDocument();
});
fireEvent.click(screen.getByRole('button', { name: 'Add Integration' }));
return screen.findByRole('dialog', { name: 'Create Integration' });
}
function selectCreateIntegration(name: string) {
const dialog = screen.getByRole('dialog', { name: 'Create Integration' });
fireEvent.click(within(dialog).getByRole('button', { name: startsWithAccessibleName(name) }));
}
function confirmCreateIntegration() {
const dialog = screen.getByRole('dialog', { name: 'Create Integration' });
fireEvent.click(within(dialog).getByRole('button', { name: 'Create' }));
}
beforeEach(() => { beforeEach(() => {
vi.clearAllMocks(); vi.clearAllMocks();
vi.spyOn(window, 'confirm').mockReturnValue(true); vi.spyOn(window, 'confirm').mockReturnValue(true);
mockedApi.getFanoutConfigs.mockResolvedValue([]); mockedApi.getFanoutConfigs.mockResolvedValue([]);
mockedApi.getChannels.mockResolvedValue([]); mockedApi.getChannels.mockResolvedValue([]);
mockedApi.getContacts.mockResolvedValue([]); mockedApi.getContacts.mockResolvedValue([]);
mockedApi.getRadioConfig.mockResolvedValue({
public_key: 'aa'.repeat(32),
name: 'TestNode',
lat: 0,
lon: 0,
tx_power: 17,
max_tx_power: 22,
radio: { freq: 910.525, bw: 62.5, sf: 7, cr: 5 },
path_hash_mode: 0,
path_hash_mode_supported: false,
});
}); });
describe('SettingsFanoutSection', () => { describe('SettingsFanoutSection', () => {
it('shows add integration menu with all integration types', async () => { it('shows add integration dialog with all integration types', async () => {
renderSection(); renderSection();
await waitFor(() => { const dialog = await openCreateIntegrationDialog();
expect(screen.getByRole('button', { name: 'Add Integration' })).toBeInTheDocument();
});
fireEvent.click(screen.getByRole('button', { name: 'Add Integration' })); const optionButtons = within(dialog)
.getAllByRole('button')
expect(screen.getByRole('menuitem', { name: 'Private MQTT' })).toBeInTheDocument(); .filter((button) => button.hasAttribute('aria-pressed'));
expect(screen.getByRole('menuitem', { name: 'MeshRank' })).toBeInTheDocument(); expect(optionButtons).toHaveLength(10);
expect(screen.getByRole('menuitem', { name: 'LetsMesh (US)' })).toBeInTheDocument(); expect(within(dialog).getByRole('button', { name: 'Close' })).toBeInTheDocument();
expect(screen.getByRole('menuitem', { name: 'LetsMesh (EU)' })).toBeInTheDocument(); expect(within(dialog).getByRole('button', { name: 'Create' })).toBeInTheDocument();
expect( expect(
screen.getByRole('menuitem', { name: 'Community MQTT/meshcoretomqtt' }) within(dialog).getByRole('button', { name: startsWithAccessibleName('Private MQTT') })
).toBeInTheDocument(); ).toBeInTheDocument();
expect(screen.getByRole('menuitem', { name: 'Webhook' })).toBeInTheDocument(); expect(
expect(screen.getByRole('menuitem', { name: 'Apprise' })).toBeInTheDocument(); within(dialog).getByRole('button', { name: startsWithAccessibleName('MeshRank') })
expect(screen.getByRole('menuitem', { name: 'Amazon SQS' })).toBeInTheDocument(); ).toBeInTheDocument();
expect(screen.getByRole('menuitem', { name: 'Bot' })).toBeInTheDocument(); expect(
within(dialog).getByRole('button', { name: startsWithAccessibleName('LetsMesh (US)') })
).toBeInTheDocument();
expect(
within(dialog).getByRole('button', { name: startsWithAccessibleName('LetsMesh (EU)') })
).toBeInTheDocument();
expect(
within(dialog).getByRole('button', {
name: startsWithAccessibleName('Community MQTT/meshcoretomqtt'),
})
).toBeInTheDocument();
expect(
within(dialog).getByRole('button', { name: startsWithAccessibleName('Webhook') })
).toBeInTheDocument();
expect(
within(dialog).getByRole('button', { name: startsWithAccessibleName('Apprise') })
).toBeInTheDocument();
expect(
within(dialog).getByRole('button', { name: startsWithAccessibleName('Amazon SQS') })
).toBeInTheDocument();
expect(
within(dialog).getByRole('button', { name: startsWithAccessibleName('Python Bot') })
).toBeInTheDocument();
expect(
within(dialog).getByRole('button', { name: startsWithAccessibleName('Map Upload') })
).toBeInTheDocument();
expect(within(dialog).getByRole('heading', { level: 3 })).toBeInTheDocument();
const genericCommunityIndex = optionButtons.findIndex((button) =>
button.textContent?.startsWith('Community MQTT/meshcoretomqtt')
);
const meshRankIndex = optionButtons.findIndex((button) =>
button.textContent?.startsWith('MeshRank')
);
expect(genericCommunityIndex).toBeGreaterThan(-1);
expect(meshRankIndex).toBeGreaterThan(-1);
expect(genericCommunityIndex).toBeLessThan(meshRankIndex);
}); });
it('shows bot option in add integration menu when bots are enabled', async () => { it('shows bot option in add integration dialog when bots are enabled', async () => {
renderSection(); renderSection();
await waitFor(() => { const dialog = await openCreateIntegrationDialog();
expect(screen.getByRole('button', { name: 'Add Integration' })).toBeInTheDocument(); expect(
}); within(dialog).getByRole('button', { name: startsWithAccessibleName('Python Bot') })
).toBeInTheDocument();
fireEvent.click(screen.getByRole('button', { name: 'Add Integration' }));
expect(screen.getByRole('menuitem', { name: 'Bot' })).toBeInTheDocument();
}); });
it('shows bots disabled banner when bots_disabled', async () => { it('shows bots disabled banner when bots_disabled', async () => {
@@ -114,14 +181,21 @@ describe('SettingsFanoutSection', () => {
}); });
}); });
it('hides bot option from add integration menu when bots_disabled', async () => { it('shows restart-scoped bots disabled messaging when disabled until restart', async () => {
renderSection({ health: { ...baseHealth, bots_disabled: true } }); renderSection({
await waitFor(() => { health: { ...baseHealth, bots_disabled: true, bots_disabled_source: 'until_restart' },
expect(screen.getByRole('button', { name: 'Add Integration' })).toBeInTheDocument();
}); });
await waitFor(() => {
expect(screen.getByText(/disabled until the server restarts/i)).toBeInTheDocument();
});
});
fireEvent.click(screen.getByRole('button', { name: 'Add Integration' })); it('hides bot option from add integration dialog when bots_disabled', async () => {
expect(screen.queryByRole('menuitem', { name: 'Bot' })).not.toBeInTheDocument(); renderSection({ health: { ...baseHealth, bots_disabled: true } });
const dialog = await openCreateIntegrationDialog();
expect(
within(dialog).queryByRole('button', { name: startsWithAccessibleName('Python Bot') })
).not.toBeInTheDocument();
}); });
it('lists existing configs after load', async () => { it('lists existing configs after load', async () => {
@@ -132,6 +206,56 @@ describe('SettingsFanoutSection', () => {
}); });
}); });
it('shows an error info button and dialog when the integration has a retained error', async () => {
mockedApi.getFanoutConfigs.mockResolvedValue([webhookConfig]);
renderSection({
health: {
...baseHealth,
fanout_statuses: {
'wh-1': {
name: 'Test Hook',
type: 'webhook',
status: 'error',
last_error: 'HTTP 500',
},
},
},
});
await waitFor(() => {
expect(screen.getByText('Test Hook')).toBeInTheDocument();
});
fireEvent.click(screen.getByRole('button', { name: 'View error details for Test Hook' }));
expect(screen.getByRole('dialog', { name: 'Test Hook Error' })).toBeInTheDocument();
expect(screen.getByText('HTTP 500')).toBeInTheDocument();
});
it('does not show an error info button when the integration has no retained error', async () => {
mockedApi.getFanoutConfigs.mockResolvedValue([webhookConfig]);
renderSection({
health: {
...baseHealth,
fanout_statuses: {
'wh-1': {
name: 'Test Hook',
type: 'webhook',
status: 'connected',
},
},
},
});
await waitFor(() => {
expect(screen.getByText('Test Hook')).toBeInTheDocument();
});
expect(
screen.queryByRole('button', { name: 'View error details for Test Hook' })
).not.toBeInTheDocument();
});
it('navigates to edit view when clicking edit', async () => { it('navigates to edit view when clicking edit', async () => {
mockedApi.getFanoutConfigs.mockResolvedValue([webhookConfig]); mockedApi.getFanoutConfigs.mockResolvedValue([webhookConfig]);
renderSection(); renderSection();
@@ -296,12 +420,9 @@ describe('SettingsFanoutSection', () => {
it('navigates to create view when clicking add button', async () => { it('navigates to create view when clicking add button', async () => {
renderSection(); renderSection();
await waitFor(() => { await openCreateIntegrationDialog();
expect(screen.getByRole('button', { name: 'Add Integration' })).toBeInTheDocument(); selectCreateIntegration('Webhook');
}); confirmCreateIntegration();
fireEvent.click(screen.getByRole('button', { name: 'Add Integration' }));
fireEvent.click(screen.getByRole('menuitem', { name: 'Webhook' }));
await waitFor(() => { await waitFor(() => {
expect(screen.getByText('← Back to list')).toBeInTheDocument(); expect(screen.getByText('← Back to list')).toBeInTheDocument();
@@ -315,12 +436,9 @@ describe('SettingsFanoutSection', () => {
it('new SQS draft shows queue url fields and sensible defaults', async () => { it('new SQS draft shows queue url fields and sensible defaults', async () => {
renderSection(); renderSection();
await waitFor(() => { await openCreateIntegrationDialog();
expect(screen.getByRole('button', { name: 'Add Integration' })).toBeInTheDocument(); selectCreateIntegration('Amazon SQS');
}); confirmCreateIntegration();
fireEvent.click(screen.getByRole('button', { name: 'Add Integration' }));
fireEvent.click(screen.getByRole('menuitem', { name: 'Amazon SQS' }));
await waitFor(() => { await waitFor(() => {
expect(screen.getByText('← Back to list')).toBeInTheDocument(); expect(screen.getByText('← Back to list')).toBeInTheDocument();
@@ -332,12 +450,9 @@ describe('SettingsFanoutSection', () => {
it('backing out of a new draft does not create an integration', async () => { it('backing out of a new draft does not create an integration', async () => {
renderSection(); renderSection();
await waitFor(() => { await openCreateIntegrationDialog();
expect(screen.getByRole('button', { name: 'Add Integration' })).toBeInTheDocument(); selectCreateIntegration('Webhook');
}); confirmCreateIntegration();
fireEvent.click(screen.getByRole('button', { name: 'Add Integration' }));
fireEvent.click(screen.getByRole('menuitem', { name: 'Webhook' }));
await waitFor(() => expect(screen.getByText('← Back to list')).toBeInTheDocument()); await waitFor(() => expect(screen.getByText('← Back to list')).toBeInTheDocument());
fireEvent.click(screen.getByText('← Back to list')); fireEvent.click(screen.getByText('← Back to list'));
@@ -411,12 +526,9 @@ describe('SettingsFanoutSection', () => {
mockedApi.getFanoutConfigs.mockResolvedValueOnce([]).mockResolvedValueOnce([createdWebhook]); mockedApi.getFanoutConfigs.mockResolvedValueOnce([]).mockResolvedValueOnce([createdWebhook]);
renderSection(); renderSection();
await waitFor(() => await openCreateIntegrationDialog();
expect(screen.getByRole('button', { name: 'Add Integration' })).toBeInTheDocument() selectCreateIntegration('Webhook');
); confirmCreateIntegration();
fireEvent.click(screen.getByRole('button', { name: 'Add Integration' }));
fireEvent.click(screen.getByRole('menuitem', { name: 'Webhook' }));
await waitFor(() => expect(screen.getByText('← Back to list')).toBeInTheDocument()); await waitFor(() => expect(screen.getByText('← Back to list')).toBeInTheDocument());
fireEvent.click(screen.getByRole('button', { name: 'Save as Disabled' })); fireEvent.click(screen.getByRole('button', { name: 'Save as Disabled' }));
@@ -444,8 +556,9 @@ describe('SettingsFanoutSection', () => {
renderSection(); renderSection();
await waitFor(() => expect(screen.getByText('Test Hook')).toBeInTheDocument()); await waitFor(() => expect(screen.getByText('Test Hook')).toBeInTheDocument());
fireEvent.click(screen.getByRole('button', { name: 'Add Integration' })); await openCreateIntegrationDialog();
fireEvent.click(screen.getByRole('menuitem', { name: 'Webhook' })); selectCreateIntegration('Webhook');
confirmCreateIntegration();
await waitFor(() => expect(screen.getByLabelText('Name')).toHaveValue('Webhook #3')); await waitFor(() => expect(screen.getByLabelText('Name')).toHaveValue('Webhook #3'));
}); });
@@ -647,21 +760,21 @@ describe('SettingsFanoutSection', () => {
mockedApi.getFanoutConfigs.mockResolvedValue([communityConfig]); mockedApi.getFanoutConfigs.mockResolvedValue([communityConfig]);
renderSection(); renderSection();
await waitFor(() => const group = await screen.findByRole('group', { name: 'Integration Community Feed' });
expect(screen.getByText('Broker: mqtt-us-v1.letsmesh.net:443')).toBeInTheDocument() expect(
); within(group).getByText(
expect(screen.getByText('mesh2mqtt/{IATA}/node/{PUBLIC_KEY}')).toBeInTheDocument(); (_, element) => element?.textContent === 'Broker: mqtt-us-v1.letsmesh.net:443'
)
).toBeInTheDocument();
expect(within(group).getByText('mesh2mqtt/{IATA}/node/{PUBLIC_KEY}')).toBeInTheDocument();
expect(screen.queryByText('Region: LAX')).not.toBeInTheDocument(); expect(screen.queryByText('Region: LAX')).not.toBeInTheDocument();
}); });
it('MeshRank preset pre-fills the broker settings and asks for the topic template', async () => { it('MeshRank preset pre-fills the broker settings and asks for the topic template', async () => {
renderSection(); renderSection();
await waitFor(() => await openCreateIntegrationDialog();
expect(screen.getByRole('button', { name: 'Add Integration' })).toBeInTheDocument() selectCreateIntegration('MeshRank');
); confirmCreateIntegration();
fireEvent.click(screen.getByRole('button', { name: 'Add Integration' }));
fireEvent.click(screen.getByRole('menuitem', { name: 'MeshRank' }));
await waitFor(() => expect(screen.getByText('← Back to list')).toBeInTheDocument()); await waitFor(() => expect(screen.getByText('← Back to list')).toBeInTheDocument());
@@ -698,12 +811,9 @@ describe('SettingsFanoutSection', () => {
mockedApi.getFanoutConfigs.mockResolvedValueOnce([]).mockResolvedValueOnce([createdConfig]); mockedApi.getFanoutConfigs.mockResolvedValueOnce([]).mockResolvedValueOnce([createdConfig]);
renderSection(); renderSection();
await waitFor(() => await openCreateIntegrationDialog();
expect(screen.getByRole('button', { name: 'Add Integration' })).toBeInTheDocument() selectCreateIntegration('MeshRank');
); confirmCreateIntegration();
fireEvent.click(screen.getByRole('button', { name: 'Add Integration' }));
fireEvent.click(screen.getByRole('menuitem', { name: 'MeshRank' }));
await waitFor(() => expect(screen.getByText('← Back to list')).toBeInTheDocument()); await waitFor(() => expect(screen.getByText('← Back to list')).toBeInTheDocument());
fireEvent.change(screen.getByLabelText('Packet Topic Template'), { fireEvent.change(screen.getByLabelText('Packet Topic Template'), {
@@ -765,12 +875,9 @@ describe('SettingsFanoutSection', () => {
mockedApi.getFanoutConfigs.mockResolvedValueOnce([]).mockResolvedValueOnce([createdConfig]); mockedApi.getFanoutConfigs.mockResolvedValueOnce([]).mockResolvedValueOnce([createdConfig]);
renderSection(); renderSection();
await waitFor(() => await openCreateIntegrationDialog();
expect(screen.getByRole('button', { name: 'Add Integration' })).toBeInTheDocument() selectCreateIntegration('LetsMesh (US)');
); confirmCreateIntegration();
fireEvent.click(screen.getByRole('button', { name: 'Add Integration' }));
fireEvent.click(screen.getByRole('menuitem', { name: 'LetsMesh (US)' }));
await waitFor(() => expect(screen.getByText('← Back to list')).toBeInTheDocument()); await waitFor(() => expect(screen.getByText('← Back to list')).toBeInTheDocument());
expect(screen.getByLabelText('Name')).toHaveValue('LetsMesh (US)'); expect(screen.getByLabelText('Name')).toHaveValue('LetsMesh (US)');
@@ -833,12 +940,9 @@ describe('SettingsFanoutSection', () => {
mockedApi.getFanoutConfigs.mockResolvedValueOnce([]).mockResolvedValueOnce([createdConfig]); mockedApi.getFanoutConfigs.mockResolvedValueOnce([]).mockResolvedValueOnce([createdConfig]);
renderSection(); renderSection();
await waitFor(() => await openCreateIntegrationDialog();
expect(screen.getByRole('button', { name: 'Add Integration' })).toBeInTheDocument() selectCreateIntegration('LetsMesh (EU)');
); confirmCreateIntegration();
fireEvent.click(screen.getByRole('button', { name: 'Add Integration' }));
fireEvent.click(screen.getByRole('menuitem', { name: 'LetsMesh (EU)' }));
await waitFor(() => expect(screen.getByText('← Back to list')).toBeInTheDocument()); await waitFor(() => expect(screen.getByText('← Back to list')).toBeInTheDocument());
fireEvent.change(screen.getByLabelText('Email'), { target: { value: 'user@example.com' } }); fireEvent.change(screen.getByLabelText('Email'), { target: { value: 'user@example.com' } });
@@ -871,16 +975,13 @@ describe('SettingsFanoutSection', () => {
it('generic Community MQTT entry still opens the full editor', async () => { it('generic Community MQTT entry still opens the full editor', async () => {
renderSection(); renderSection();
await waitFor(() => await openCreateIntegrationDialog();
expect(screen.getByRole('button', { name: 'Add Integration' })).toBeInTheDocument() selectCreateIntegration('Community MQTT/meshcoretomqtt');
); confirmCreateIntegration();
fireEvent.click(screen.getByRole('button', { name: 'Add Integration' }));
fireEvent.click(screen.getByRole('menuitem', { name: 'Community MQTT/meshcoretomqtt' }));
await waitFor(() => expect(screen.getByText('← Back to list')).toBeInTheDocument()); await waitFor(() => expect(screen.getByText('← Back to list')).toBeInTheDocument());
expect(screen.getByLabelText('Name')).toHaveValue('Community MQTT #1'); expect(screen.getByLabelText('Name')).toHaveValue('Community Sharing #1');
expect(screen.getByLabelText('Broker Host')).toBeInTheDocument(); expect(screen.getByLabelText('Broker Host')).toBeInTheDocument();
expect(screen.getByLabelText('Authentication')).toBeInTheDocument(); expect(screen.getByLabelText('Authentication')).toBeInTheDocument();
expect(screen.getByLabelText('Packet Topic Template')).toBeInTheDocument(); expect(screen.getByLabelText('Packet Topic Template')).toBeInTheDocument();
@@ -900,9 +1001,12 @@ describe('SettingsFanoutSection', () => {
mockedApi.getFanoutConfigs.mockResolvedValue([privateConfig]); mockedApi.getFanoutConfigs.mockResolvedValue([privateConfig]);
renderSection(); renderSection();
await waitFor(() => expect(screen.getByText('Broker: broker.local:1883')).toBeInTheDocument()); const group = await screen.findByRole('group', { name: 'Integration Private Broker' });
expect( expect(
screen.getByText('meshcore/dm:<pubkey>, meshcore/gm:<channel>, meshcore/raw/...') within(group).getByText((_, element) => element?.textContent === 'Broker: broker.local:1883')
).toBeInTheDocument();
expect(
within(group).getByText('meshcore/dm:<pubkey>, meshcore/gm:<channel>, meshcore/raw/...')
).toBeInTheDocument(); ).toBeInTheDocument();
}); });
@@ -920,7 +1024,8 @@ describe('SettingsFanoutSection', () => {
mockedApi.getFanoutConfigs.mockResolvedValue([config]); mockedApi.getFanoutConfigs.mockResolvedValue([config]);
renderSection(); renderSection();
await waitFor(() => expect(screen.getByText('https://example.com/hook')).toBeInTheDocument()); const group = await screen.findByRole('group', { name: 'Integration Webhook Feed' });
expect(within(group).getByText('https://example.com/hook')).toBeInTheDocument();
}); });
it('apprise list shows compact target summary', async () => { it('apprise list shows compact target summary', async () => {
@@ -941,9 +1046,10 @@ describe('SettingsFanoutSection', () => {
mockedApi.getFanoutConfigs.mockResolvedValue([config]); mockedApi.getFanoutConfigs.mockResolvedValue([config]);
renderSection(); renderSection();
await waitFor(() => const group = await screen.findByRole('group', { name: 'Integration Apprise Feed' });
expect(screen.getByText(/discord:\/\/abc, mailto:\/\/one@example.com/)).toBeInTheDocument() expect(
); within(group).getByText(/discord:\/\/abc, mailto:\/\/one@example.com/)
).toBeInTheDocument();
}); });
it('sqs list shows queue url summary', async () => { it('sqs list shows queue url summary', async () => {
@@ -963,11 +1069,10 @@ describe('SettingsFanoutSection', () => {
mockedApi.getFanoutConfigs.mockResolvedValue([config]); mockedApi.getFanoutConfigs.mockResolvedValue([config]);
renderSection(); renderSection();
await waitFor(() => const group = await screen.findByRole('group', { name: 'Integration Queue Feed' });
expect( expect(
screen.getByText('https://sqs.us-east-1.amazonaws.com/123456789012/mesh-events') within(group).getByText('https://sqs.us-east-1.amazonaws.com/123456789012/mesh-events')
).toBeInTheDocument() ).toBeInTheDocument();
);
}); });
it('groups integrations by type and sorts entries alphabetically within each group', async () => { it('groups integrations by type and sorts entries alphabetically within each group', async () => {
+8 -11
View File
@@ -167,17 +167,15 @@ describe('Integration: Duplicate Message Handling', () => {
}); });
}); });
describe('Integration: No phantom unreads from mesh echoes (hitlist #8 regression)', () => { describe('Integration: Trimmed cache entries can reappear (hitlist #7 regression)', () => {
it('does not increment unread when a mesh echo arrives after many unique messages', () => { it('increments unread when an evicted inactive-conversation message arrives again', () => {
const state = createMockState(); const state = createMockState();
const convKey = 'channel_busy'; const convKey = 'channel_busy';
// Deliver 1001 unique messages — exceeding the old global // Deliver enough unique messages to evict msg-0 from the inactive
// seenMessageContentRef prune threshold (1000→500). Under the old // conversation cache. Once it falls out of that window, a later arrival
// dual-set design the global set would drop msg-0's key during pruning, // with the same content should be allowed back in instead of being
// so a later mesh echo of msg-0 would pass the global check and // suppressed forever by a stale content key.
// phantom-increment unread. With the fix, messageCache's per-conversation
// Cached messages remain the source of truth for inactive-conversation dedup.
const MESSAGE_COUNT = 1001; const MESSAGE_COUNT = 1001;
for (let i = 0; i < MESSAGE_COUNT; i++) { for (let i = 0; i < MESSAGE_COUNT; i++) {
const msg: Message = { const msg: Message = {
@@ -219,9 +217,8 @@ describe('Integration: No phantom unreads from mesh echoes (hitlist #8 regressio
}; };
const result = handleMessageEvent(state, echo, 'other_active_conv'); const result = handleMessageEvent(state, echo, 'other_active_conv');
// Must NOT increment unread — the echo is a duplicate expect(result.unreadIncremented).toBe(true);
expect(result.unreadIncremented).toBe(false); expect(state.unreadCounts[stateKey]).toBe(MESSAGE_COUNT + 1);
expect(state.unreadCounts[stateKey]).toBe(MESSAGE_COUNT);
}); });
}); });
+70
View File
@@ -214,6 +214,76 @@ describe('messageCache', () => {
expect(entry!.messages.some((m) => m.id === 0)).toBe(false); expect(entry!.messages.some((m) => m.id === 0)).toBe(false);
}); });
it('allows a trimmed-out message to be re-added after set() trimming', () => {
const messages = Array.from({ length: MAX_MESSAGES_PER_ENTRY + 1 }, (_, i) =>
createMessage({
id: i,
text: `message-${i}`,
received_at: 1700000000 + i,
sender_timestamp: 1700000000 + i,
})
);
messageCache.set('conv1', createEntry(messages));
const trimmedOut = createMessage({
id: 10_000,
text: 'message-0',
received_at: 1800000000,
sender_timestamp: 1700000000,
});
expect(messageCache.addMessage('conv1', trimmedOut)).toBe(true);
const entry = messageCache.get('conv1');
expect(entry!.messages.some((m) => m.id === 10_000)).toBe(true);
});
it('allows a trimmed-out message to be re-added after addMessage() trimming', () => {
const messages = Array.from({ length: MAX_MESSAGES_PER_ENTRY - 1 }, (_, i) =>
createMessage({
id: i,
text: `message-${i}`,
received_at: 1700000000 + i,
sender_timestamp: 1700000000 + i,
})
);
messageCache.set('conv1', createEntry(messages));
expect(
messageCache.addMessage(
'conv1',
createMessage({
id: MAX_MESSAGES_PER_ENTRY,
text: 'newest-a',
received_at: 1800000000,
sender_timestamp: 1800000000,
})
)
).toBe(true);
expect(
messageCache.addMessage(
'conv1',
createMessage({
id: MAX_MESSAGES_PER_ENTRY + 1,
text: 'newest-b',
received_at: 1800000001,
sender_timestamp: 1800000001,
})
)
).toBe(true);
const readdedTrimmedMessage = createMessage({
id: 10_001,
text: 'message-0',
received_at: 1900000000,
sender_timestamp: 1700000000,
});
expect(messageCache.addMessage('conv1', readdedTrimmedMessage)).toBe(true);
const entry = messageCache.get('conv1');
expect(entry!.messages.some((m) => m.id === 10_001)).toBe(true);
});
it('auto-creates a minimal entry for never-visited conversations and returns true', () => { it('auto-creates a minimal entry for never-visited conversations and returns true', () => {
const msg = createMessage({ id: 10, text: 'First contact' }); const msg = createMessage({ id: 10, text: 'First contact' });
const result = messageCache.addMessage('new_conv', msg); const result = messageCache.addMessage('new_conv', msg);

Some files were not shown because too many files have changed in this diff Show More