From 444c653878acc9186ff03e0a8cf7583473ed2fbc Mon Sep 17 00:00:00 2001
From: plegall <plg@piwigo.org>
Date: Wed, 5 May 2021 16:59:54 +0200
Subject: [PATCH] fixes #1368 user with "guest" status get refused connection

---
 include/functions_user.inc.php | 25 ++++++++++++++++++++++---
 1 file changed, 22 insertions(+), 3 deletions(-)

diff --git a/include/functions_user.inc.php b/include/functions_user.inc.php
index a7b4ac910..f20ae33d3 100644
--- a/include/functions_user.inc.php
+++ b/include/functions_user.inc.php
@@ -1134,9 +1134,28 @@ SELECT '.$conf['user_fields']['id'].' AS id,
 
   if ($user_found)
   {
-    log_user($row['id'], $remember_me);
-    trigger_notify('login_success', stripslashes($username));
-    return true;
+    // if user status is "guest" then she should not be granted to log in.
+    // The user may not exist in the user_infos table, so we consider it's a "normal" user by default
+    $status = 'normal';
+
+    $query = '
+SELECT
+    *
+  FROM '.USER_INFOS_TABLE.'
+  WHERE user_id = '.$row['id'].'
+;';
+    $result = pwg_query($query);
+    while ($user_infos_row = pwg_db_fetch_assoc($result))
+    {
+      $status = $user_infos_row['status'];
+    }
+
+    if ('guest' != $status)
+    {
+      log_user($row['id'], $remember_me);
+      trigger_notify('login_success', stripslashes($username));
+      return true;
+    }
   }
   trigger_notify('login_failure', stripslashes($username));
   return false;