iarv/Piwigo
1
0
Fork 0
mirror of https://github.com/Piwigo/Piwigo.git synced 2026-03-28 17:42:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

fixes #871, CVE-2018-7722 strip tags on methods pwg.categories.add, pwg.categories.setInfo, pwg.images.setInfo

Browse Source 
Adding pwg_token would be a better solution but would break remote applications (like the iOS app)
This commit is contained in:
plegall
2018-07-06 18:29:41 +02:00
parent bef09018fb
commit 23fa4c1a73
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
include/ws_functions/pwg.categories.php
View File

@@ -565,11 +565,12 @@ function ws_categories_add($params, &$service)
if (!empty($params['comment']))
{
$options['comment'] = $params['comment'];
// TODO do not strip tags if pwg_token is provided (and valid)
$options['comment'] = strip_tags($params['comment']);
}
$creation_output = create_virtual_category(
$params['name'],
strip_tags($params['name']), // TODO do not strip tags if pwg_token is provided (and valid)
$params['parent'],
$options
);
@@ -634,7 +635,8 @@ SELECT *
if (isset($params[$key]))
{
$perform_update = true;
$update[$key] = $params[$key];
// TODO do not strip tags if pwg_token is provided (and valid)
$update[$key] = strip_tags($params[$key]);
}
}

3
include/ws_functions/pwg.images.php
View File

@@ -1648,6 +1648,9 @@ SELECT *
$params[$key] = strip_tags($params[$key], '<b><strong><em><i>');
}
// TODO do not strip tags if pwg_token is provided (and valid)
$params[$key] = strip_tags($params[$key]);
if ('fill_if_empty' == $params['single_value_mode'])
{
if (empty($image_row[$key]))