Wolf480pl 80f9baf0a6 Fix memory leak and null dereference in CZNC::LoadUsers ...

Before this commit, when pUser->SetBeingDeleted(true) is executed,
pUser is an empty unique_ptr, because release() was already called
on it. Therefore, pUser->SetBeingDeleted is unidefined behaviour.

Also, AddUser only takes ownership of the passed user pointer if it
succeeds. In case of a failure, it's the caller's responsibility to
delete the user.

Fix this by keeping a raw pointer to the user, and handling it
accordingly when AddUser fails.

I have no idea whether SetBeingDeleted is necessary there, leaving it
just in case.

Maybe it would be better if we could change the semantics of
AddUser to always take ownership of the pointer,
or even take unique_ptr, but I have no idea how to adapt Python
bindings in modpython to such change.

2018-07-25 17:25:38 +02:00

..

po

Update translations from Crowdin for nl_NL

2018-07-18 14:36:36 +00:00

Buffer.cpp

Welcome to 2018

2018-01-19 19:38:58 +00:00

Chan.cpp

More translateable strings, #1354

2018-03-25 22:57:05 +01:00

Client.cpp

Better cleanup lines coming from network.

2018-07-14 07:08:50 +01:00

ClientCommand.cpp

More translateable strings (#1354)

2018-03-26 23:51:31 +01:00

CMakeLists.txt

Reflect absense of ABI in cygwin DLL name

2018-03-12 00:05:10 +00:00

Config.cpp

Don't let attackers inject rogue values into znc.conf

2018-07-14 07:05:57 +01:00

FileUtils.cpp

Stop creating files with odd permissions.

2018-02-09 22:25:06 +00:00

HTTPSock.cpp

Welcome to 2018

2018-01-19 19:38:58 +00:00

IRCNetwork.cpp

Revert "transperancy: Make the user aware that DEBUG mode is enabled."

2018-06-18 00:41:18 +01:00

IRCSock.cpp

Better cleanup lines coming from network.

2018-07-14 07:08:50 +01:00

Listener.cpp

Welcome to 2018

2018-01-19 19:38:58 +00:00

main.cpp

Welcome to 2018

2018-01-19 19:38:58 +00:00

MD5.cpp

clang-format: switch tabs to spaces

2015-12-07 00:53:30 +00:00

Message.cpp

Replace the deprecated overload of CMessage::GetParam

2018-06-01 22:22:44 +01:00

Modules.cpp

Fix error message about wrong module type.

2018-05-28 21:21:29 +01:00

Nick.cpp

Make chan modes and permissions to be char instead of unsigned char.

2018-02-10 15:55:55 +00:00

Query.cpp

Welcome to 2018

2018-01-19 19:38:58 +00:00

Server.cpp

Welcome to 2018

2018-01-19 19:38:58 +00:00

SHA256.cpp

clang-format: switch tabs to spaces

2015-12-07 00:53:30 +00:00

Socket.cpp

More translateable strings (#1354)

2018-04-01 12:06:29 +01:00

SSLVerifyHost.cpp

Support IP while verifying SSL certificates

2018-04-02 11:35:45 +01:00

Template.cpp

Welcome to 2018

2018-01-19 19:38:58 +00:00

Threads.cpp

Welcome to 2018

2018-01-19 19:38:58 +00:00

Translation.cpp

Welcome to 2018

2018-01-19 19:38:58 +00:00

User.cpp

Fix language selector. It didn't work.

2018-05-07 16:14:16 +01:00

Utils.cpp

Fix build without SSL support

2018-06-10 21:09:07 +01:00

version.cpp.in

Welcome to 2018

2018-01-19 19:38:58 +00:00

WebModules.cpp

Don't let web skin name ../../../../ access files outside of usual skins directories.

2018-07-14 07:09:26 +01:00

znc.cpp

Fix memory leak and null dereference in CZNC::LoadUsers

2018-07-25 17:25:38 +02:00

ZNCDebug.cpp

Welcome to 2018

2018-01-19 19:38:58 +00:00

ZNCString.cpp

Welcome to 2018

2018-01-19 19:38:58 +00:00