DelPort doesnt check if there is only 1 active port remaining #996

New Issue

2026-10-05T04:57:38+02:00

adam commented

2026-10-05 04:57:38 +02:00

Via IRC messages is possible to completely remove all listening ports.

In the code, here, should be there an other "IF", checking if the number of listeners is = 1; in that case it should give back error, telling to add first another port before to remove the last available port.

https://github.com/znc/znc/blob/9cd36055166164d359a34c0af835e597e558cc59/src/ClientCommand.cpp#L1718-L1723

Via IRC messages is possible to completely remove all listening ports. In the code, [here](https://github.com/znc/znc/blob/9cd36055166164d359a34c0af835e597e558cc59/src/ClientCommand.cpp#L1719), should be there an other "IF", checking if the number of listeners is = 1; in that case it should give back error, telling to add first another port before to remove the **last** available port. https://github.com/znc/znc/blob/9cd36055166164d359a34c0af835e597e558cc59/src/ClientCommand.cpp#L1718-L1723

adam commented

2026-10-05 04:57:39 +02:00

The if should be to check if it's the current active port, because that one should never be able to be deleted (which is already the case in webadmin iirc)

The if should be to check if it's the current active port, because that one should never be able to be deleted (which is already the case in webadmin iirc)

adam commented

2026-10-05 04:57:40 +02:00

This is mostly by design. It should be possible to e.g. switch SSL on on the port without adding a new port with different number: delport, then addport. Of course, there's a potential to disconnect after delport, which would make ZNC not accessible anymore.

Webadmin does have this check, because all HTTP connections are independent (we always use Connection: close header, and even without it, we can't rely on browser to not close the connection between requests), so deleting the port from there would result in a weird error instead of the "success page"

This is mostly by design. It should be possible to e.g. switch SSL on on the port without adding a new port with different number: delport, then addport. Of course, there's a potential to disconnect after delport, which would make ZNC not accessible anymore. Webadmin does have this check, because all HTTP connections are independent (we always use `Connection: close` header, and even without it, we can't rely on browser to not close the connection between requests), so deleting the port from there would result in a weird error instead of the "success page"

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: adam/znc#996