adam/znc
1
0 Fork 0
mirror of https://github.com/znc/znc.git synced 2026-10-31 01:32:02 +01:00
Code Issues 362 Packages Projects Releases Wiki Activity

ZNC accepts NICK with no parameter from the client #985

New Issue
Open
opened 2026-10-05 04:57:07 +02:00 by adam · 0 comments
adam commented 2026-10-05 04:57:07 +02:00
Owner
Copy link
Copy source

This was noted by neverwas on IRC. ZNC does not seem to validate the parameters to the NICK or USER command. This can cause problems if the client sends a nickname that contains spaces, an empty string or no parameter at all.

The latter situation causes ZNC 1.8.2 to send back invalid output that looks like this:

:questers-rest.andriocelos.net 001 :Welcome to the QuestersRest IRC Network Andrio!Andrio@127.0.0.1
:questers-rest.andriocelos.net 002 :Your host is questers-rest.andriocelos.net, running version InspIRCd-3
:questers-rest.andriocelos.net 003 :This server was created 18:35:56 May 15 2021
:questers-rest.andriocelos.net 004 questers-rest.andriocelos.net InspIRCd-3 BDILNORSTWcdghikorswxz ACDFHILMNOPRSTXYZbcdeiklmnoprstvz :FHILXYZbdeklov
:questers-rest.andriocelos.net 005 ACCEPT=30 AWAYLEN=200 BOT=B CALLERID=g CASEMAPPING=ascii CHANLIMIT=#:20 CHANMODES=IXZbe,k,FHLdl,ACDMNOPRSTcimnprstz CHANNELLEN=64 CHANTYPES=# ELIST=CMNTU ESILENCE=CcdiNnPpTtx EXCEPTS=e :are supported by this server
:questers-rest.andriocelos.net 005 EXTBAN=,ACNORSTUacmrz HOSTLEN=64 INVEX=I KEYLEN=32 KICKLEN=255 LINELEN=512 MAXLIST=I:100,X:100,b:100,e:100 MAXTARGETS=20 MODES=20 MONITOR=30 NAMELEN=128 NAMESX NETWORK=QuestersRest :are supported by this server
:questers-rest.andriocelos.net 005 NICKLEN=16 OVERRIDE PREFIX=(Yov)!@+ SAFELIST SILENCE=32 STATUSMSG=!@+ TOPICLEN=307 UHNAMES USERIP USERLEN=10 USERMODES=,,s,BDILNORSTWcdghikorwxz WHOX :are supported by this server
:questers-rest.andriocelos.net 251 :There are 1 users and 0 invisible on 2 servers
:questers-rest.andriocelos.net 254 2 :channels formed
:questers-rest.andriocelos.net 255 :I have 1 clients and 1 servers
:questers-rest.andriocelos.net 265 :Current local users: 1  Max: 3
:questers-rest.andriocelos.net 266 :Current global users: 1  Max: 3
:!Andrio@questers-rest.andriocelos.net NICK :Andrio
:questers-rest.andriocelos.net 375 Andrio :questers-rest.andriocelos.net message of the day

NICK without parameters or with an invalid nickname should probably not be accepted.

This was noted by neverwas on IRC. ZNC does not seem to validate the parameters to the `NICK` or `USER` command. This can cause problems if the client sends a nickname that contains spaces, an empty string or no parameter at all. The latter situation causes ZNC 1.8.2 to send back invalid output that looks like this: ``` :questers-rest.andriocelos.net 001 :Welcome to the QuestersRest IRC Network Andrio!Andrio@127.0.0.1 :questers-rest.andriocelos.net 002 :Your host is questers-rest.andriocelos.net, running version InspIRCd-3 :questers-rest.andriocelos.net 003 :This server was created 18:35:56 May 15 2021 :questers-rest.andriocelos.net 004 questers-rest.andriocelos.net InspIRCd-3 BDILNORSTWcdghikorswxz ACDFHILMNOPRSTXYZbcdeiklmnoprstvz :FHILXYZbdeklov :questers-rest.andriocelos.net 005 ACCEPT=30 AWAYLEN=200 BOT=B CALLERID=g CASEMAPPING=ascii CHANLIMIT=#:20 CHANMODES=IXZbe,k,FHLdl,ACDMNOPRSTcimnprstz CHANNELLEN=64 CHANTYPES=# ELIST=CMNTU ESILENCE=CcdiNnPpTtx EXCEPTS=e :are supported by this server :questers-rest.andriocelos.net 005 EXTBAN=,ACNORSTUacmrz HOSTLEN=64 INVEX=I KEYLEN=32 KICKLEN=255 LINELEN=512 MAXLIST=I:100,X:100,b:100,e:100 MAXTARGETS=20 MODES=20 MONITOR=30 NAMELEN=128 NAMESX NETWORK=QuestersRest :are supported by this server :questers-rest.andriocelos.net 005 NICKLEN=16 OVERRIDE PREFIX=(Yov)!@+ SAFELIST SILENCE=32 STATUSMSG=!@+ TOPICLEN=307 UHNAMES USERIP USERLEN=10 USERMODES=,,s,BDILNORSTWcdghikorwxz WHOX :are supported by this server :questers-rest.andriocelos.net 251 :There are 1 users and 0 invisible on 2 servers :questers-rest.andriocelos.net 254 2 :channels formed :questers-rest.andriocelos.net 255 :I have 1 clients and 1 servers :questers-rest.andriocelos.net 265 :Current local users: 1 Max: 3 :questers-rest.andriocelos.net 266 :Current global users: 1 Max: 3 :!Andrio@questers-rest.andriocelos.net NICK :Andrio :questers-rest.andriocelos.net 375 Andrio :questers-rest.andriocelos.net message of the day ``` `NICK` without parameters or with an invalid nickname should probably not be accepted. <!-- github-sync-id:911232949 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/znc#985