adam/znc
1
0 Fork 0
mirror of https://github.com/znc/znc.git synced 2026-11-03 02:42:21 +01:00
Code Issues 362 Packages Projects Releases Wiki Activity

ZNC erroneously replies to CTCP NOTICE messages to channels. #889

New Issue
Closed
opened 2026-10-05 04:50:57 +02:00 by adam · 1 comment
adam commented 2026-10-05 04:50:57 +02:00
Owner
Copy link
Copy source

It seems that a CTCP NOTICE message to a channel, such as a KVIrc user changing their avatar, is treated the same as if it were a PRIVMSG, so ZNC is sending a configured response if there is one and not passing it on to the client. This seems to be erroneous: the NOTICE message should not be replied to automatically like this.

https://github.com/znc/znc/blob/b52fecc42d5c1d354c55d0c90eecd49051d4ab34/src/IRCSock.cpp#L428-L434

(For normal private CTCP messages, the following lines deal with NOTICE replies:)

https://github.com/znc/znc/blob/b52fecc42d5c1d354c55d0c90eecd49051d4ab34/src/IRCSock.cpp#L420-L422

It seems that a CTCP `NOTICE` message to a channel, such as a KVIrc user changing their avatar, is treated the same as if it were a `PRIVMSG`, so ZNC is sending a configured response if there is one and not passing it on to the client. This seems to be erroneous: the `NOTICE` message should not be replied to automatically like this. https://github.com/znc/znc/blob/b52fecc42d5c1d354c55d0c90eecd49051d4ab34/src/IRCSock.cpp#L428-L434 (For normal private CTCP messages, the following lines deal with `NOTICE` replies:) https://github.com/znc/znc/blob/b52fecc42d5c1d354c55d0c90eecd49051d4ab34/src/IRCSock.cpp#L420-L422 <!-- github-sync-id:393759157 -->
adam closed this issue 2026-10-05 04:50:57 +02:00
adam commented 2026-10-05 04:50:58 +02:00
Author
Owner
Copy link
Copy source

Once upon a time, this worked fine. This must be a regression that was introduced by the CMessage "stuff". This handles both PRIVMSG CTCPs and NOTICE CTCPs as being of type CTCP. I guess the right fix would be to introduce a CTCPReply type here...
https://github.com/znc/znc/blob/b52fecc42d5c1d354c55d0c90eecd49051d4ab34/src/Message.cpp#L226-L240

Once upon a time, this worked fine. This must be a regression that was introduced by the `CMessage` "stuff". This handles both `PRIVMSG` CTCPs and `NOTICE` CTCPs as being of type `CTCP`. I guess the right fix would be to introduce a `CTCPReply` type here... https://github.com/znc/znc/blob/b52fecc42d5c1d354c55d0c90eecd49051d4ab34/src/Message.cpp#L226-L240 <!-- github-comment-id:449653667 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/znc#889