adam/znc
1
0 Fork 0
mirror of https://github.com/znc/znc.git synced 2026-10-31 01:32:02 +01:00
Code Issues 362 Packages Projects Releases Wiki Activity

znc does not include custom user prefixes in its 353 message to clients #868

New Issue
Closed
opened 2026-10-05 04:49:25 +02:00 by adam · 4 comments
adam commented 2026-10-05 04:49:25 +02:00
Owner
Copy link
Copy source

When joining a channel znc sends a list of the users in that channel to the client:

[2018-08-30 12:03:28.859593] (jkhsjdhjs/N0xyNet) CLI -> ZNC [JOIN #1239]
[2018-08-30 12:03:28.859857] (jkhsjdhjs/N0xyNet) ZNC -> IRC [JOIN #1239 :]
[2018-08-30 12:03:28.883918] (jkhsjdhjs/N0xyNet) IRC -> ZNC [:jkhsjdhjs!jkhsjdhjs@ntvu4f.rip JOIN #1239 jkhsjdhjs :jkhsjdhjs]
[2018-08-30 12:03:28.884038] (jkhsjdhjs/N0xyNet) ZNC -> IRC [MODE #1239]
[2018-08-30 12:03:28.884305] (jkhsjdhjs/N0xyNet) ZNC -> CLI [@time=2018-08-30T12:03:28.883Z :jkhsjdhjs!jkhsjdhjs@ntvu4f.rip JOIN #1239 jkhsjdhjs :jkhsjdhjs]
[2018-08-30 12:03:28.884395] (jkhsjdhjs/N0xyNet) ZNC -> CLI [:jkhsjdhjs!jkhsjdhjs@ntvu4f.rip JOIN #1239]
[2018-08-30 12:03:28.884447] (jkhsjdhjs/N0xyNet) IRC -> ZNC [:judas.n0xy.net 353 jkhsjdhjs = #1239 :Uwe!NSA@neuken.in.de.keuken jkhsjdhjs!jkhsjdhjs@ntvu4f.rip !&@Flummi!bark@bark @flashcode!flashcode@bdn9pi.flashtux.org ]
[2018-08-30 12:03:28.884565] (jkhsjdhjs/N0xyNet) ZNC -> CLI [@time=2018-08-30T12:03:28.884Z :judas.n0xy.net 353 jkhsjdhjs = #1239 :Uwe!NSA@neuken.in.de.keuken jkhsjdhjs!jkhsjdhjs@ntvu4f.rip !&@Flummi!bark@bark @flashcode!flashcode@bdn9pi.flashtux.org ]
[2018-08-30 12:03:28.884615] (jkhsjdhjs/N0xyNet) ZNC -> CLI [:judas.n0xy.net 353 jkhsjdhjs = #1239 :Uwe jkhsjdhjs Flummi @flashcode]
[2018-08-30 12:03:28.884653] (jkhsjdhjs/N0xyNet) IRC -> ZNC [:judas.n0xy.net 366 jkhsjdhjs #1239 :End of /NAMES list.]
[2018-08-30 12:03:28.884722] (jkhsjdhjs/N0xyNet) ZNC -> CLI [@time=2018-08-30T12:03:28.884Z :judas.n0xy.net 366 jkhsjdhjs #1239 :End of /NAMES list.]
[2018-08-30 12:03:28.884800] (jkhsjdhjs/N0xyNet) ZNC -> CLI [:judas.n0xy.net 366 jkhsjdhjs #1239 :End of /NAMES list.]
[2018-08-30 12:03:28.909168] (jkhsjdhjs/N0xyNet) IRC -> ZNC [:judas.n0xy.net 324 jkhsjdhjs #1239 +nt]
[2018-08-30 12:03:28.909406] (jkhsjdhjs/N0xyNet) IRC -> ZNC [:judas.n0xy.net 329 jkhsjdhjs #1239 1535627383]

As you can see there are 4 users on the channel: Uwe, jkhsjdhjs, Flummi and flashcode.
Flummi hat modes corresponding to the prefixes ! and & and flashcode has the prefix @.

znc also includes those modes when sending the first 353 to the client. However, only @ is included in the second 353 message with only the nicknames. This is causing the users to not appear with the correct prefix in the userlist.

I first thought it was a weechat issue because the users appeared with the correct prefix in hexchat and mutter for example, but this is just because hexchat and mutter are sending an additional WHO command on the channel after joining. See https://github.com/weechat/weechat/issues/1239 for additional information.

When joining a channel znc sends a list of the users in that channel to the client: ``` [2018-08-30 12:03:28.859593] (jkhsjdhjs/N0xyNet) CLI -> ZNC [JOIN #1239] [2018-08-30 12:03:28.859857] (jkhsjdhjs/N0xyNet) ZNC -> IRC [JOIN #1239 :] [2018-08-30 12:03:28.883918] (jkhsjdhjs/N0xyNet) IRC -> ZNC [:jkhsjdhjs!jkhsjdhjs@ntvu4f.rip JOIN #1239 jkhsjdhjs :jkhsjdhjs] [2018-08-30 12:03:28.884038] (jkhsjdhjs/N0xyNet) ZNC -> IRC [MODE #1239] [2018-08-30 12:03:28.884305] (jkhsjdhjs/N0xyNet) ZNC -> CLI [@time=2018-08-30T12:03:28.883Z :jkhsjdhjs!jkhsjdhjs@ntvu4f.rip JOIN #1239 jkhsjdhjs :jkhsjdhjs] [2018-08-30 12:03:28.884395] (jkhsjdhjs/N0xyNet) ZNC -> CLI [:jkhsjdhjs!jkhsjdhjs@ntvu4f.rip JOIN #1239] [2018-08-30 12:03:28.884447] (jkhsjdhjs/N0xyNet) IRC -> ZNC [:judas.n0xy.net 353 jkhsjdhjs = #1239 :Uwe!NSA@neuken.in.de.keuken jkhsjdhjs!jkhsjdhjs@ntvu4f.rip !&@Flummi!bark@bark @flashcode!flashcode@bdn9pi.flashtux.org ] [2018-08-30 12:03:28.884565] (jkhsjdhjs/N0xyNet) ZNC -> CLI [@time=2018-08-30T12:03:28.884Z :judas.n0xy.net 353 jkhsjdhjs = #1239 :Uwe!NSA@neuken.in.de.keuken jkhsjdhjs!jkhsjdhjs@ntvu4f.rip !&@Flummi!bark@bark @flashcode!flashcode@bdn9pi.flashtux.org ] [2018-08-30 12:03:28.884615] (jkhsjdhjs/N0xyNet) ZNC -> CLI [:judas.n0xy.net 353 jkhsjdhjs = #1239 :Uwe jkhsjdhjs Flummi @flashcode] [2018-08-30 12:03:28.884653] (jkhsjdhjs/N0xyNet) IRC -> ZNC [:judas.n0xy.net 366 jkhsjdhjs #1239 :End of /NAMES list.] [2018-08-30 12:03:28.884722] (jkhsjdhjs/N0xyNet) ZNC -> CLI [@time=2018-08-30T12:03:28.884Z :judas.n0xy.net 366 jkhsjdhjs #1239 :End of /NAMES list.] [2018-08-30 12:03:28.884800] (jkhsjdhjs/N0xyNet) ZNC -> CLI [:judas.n0xy.net 366 jkhsjdhjs #1239 :End of /NAMES list.] [2018-08-30 12:03:28.909168] (jkhsjdhjs/N0xyNet) IRC -> ZNC [:judas.n0xy.net 324 jkhsjdhjs #1239 +nt] [2018-08-30 12:03:28.909406] (jkhsjdhjs/N0xyNet) IRC -> ZNC [:judas.n0xy.net 329 jkhsjdhjs #1239 1535627383] ``` As you can see there are 4 users on the channel: `Uwe`, `jkhsjdhjs`, `Flummi` and `flashcode`. Flummi hat modes corresponding to the prefixes `!` and `&` and flashcode has the prefix `@`. znc also includes those modes when sending the first `353` to the client. However, only `@` is included in the second `353` message with only the nicknames. This is causing the users to not appear with the correct prefix in the userlist. I first thought it was a weechat issue because the users appeared with the correct prefix in hexchat and mutter for example, but this is just because hexchat and mutter are sending an additional `WHO` command on the channel after joining. See https://github.com/weechat/weechat/issues/1239 for additional information. <!-- github-sync-id:355564448 -->
adam closed this issue 2026-10-05 04:49:25 +02:00
adam commented 2026-10-05 04:49:26 +02:00
Author
Owner
Copy link
Copy source

My guess would be WeeChat not requesting multi-prefix as per https://wiki.znc.in/Weechat#Enabling_server-time_.26_other_IRCv3_capabilities .

Sorry for commenting to multiple places, I hope to save someone from saying the same thing later.

My guess would be WeeChat not requesting `multi-prefix` as per https://wiki.znc.in/Weechat#Enabling_server-time_.26_other_IRCv3_capabilities . Sorry for commenting to multiple places, I hope to save someone from saying the same thing later. <!-- github-comment-id:417306725 -->
adam commented 2026-10-05 04:49:27 +02:00
Author
Owner
Copy link
Copy source

What's your ZNC version?

Your debug output is confusing me. Every message sent to the client is duplicated, once with a timestamp and once without.
The first JOIN looks like it is forwarded from the IRC server to the client since it has the same arguments. The second one is without any arguments but otherwise the same.
Same for the 353s: The first one looks like it is just forwarded from the IRC server, with an added timestamp, while the second one... seems creative (and without UHNAMES and NAMESX).
Even the 366 is duplicated.

Do you have two clients connected to ZNC? Does one of them support all kinds of fancy IRC extensions while the other one is dumb?

What's your ZNC version? Your debug output is confusing me. Every message sent to the client is duplicated, once with a timestamp and once without. The first `JOIN` looks like it is forwarded from the IRC server to the client since it has the same arguments. The second one is without any arguments but otherwise the same. Same for the `353`s: The first one looks like it is just forwarded from the IRC server, with an added timestamp, while the second one... seems creative (and without UHNAMES and NAMESX). Even the `366` is duplicated. Do you have two clients connected to ZNC? Does one of them support all kinds of fancy IRC extensions while the other one is dumb? <!-- github-comment-id:417306763 -->
adam commented 2026-10-05 04:49:28 +02:00
Author
Owner
Copy link
Copy source

Also, is this a duplicate of #1528? Assuming @jkhsjdhjs really had two clients connected to ZNC, I would guess so. The symptom is the same: the mode ! disappears since some code confuses this with the separator between nick and ident.

Also, is this a duplicate of #1528? Assuming @jkhsjdhjs really had two clients connected to ZNC, I would guess so. The symptom is the same: the mode `!` disappears since some code confuses this with the separator between nick and ident. <!-- github-comment-id:417307373 -->
adam commented 2026-10-05 04:49:29 +02:00
Author
Owner
Copy link
Copy source

@Mikaela irc.server_default.capabilities was an empty string, adding multi-prefix causes znc to send & instead of no prefix at all, correct would be !.

@psychon Yes, I had two clients connected to znc. Same symptoms as in #1528, duplicate issue then. Closing this, thanks!

@Mikaela `irc.server_default.capabilities` was an empty string, adding `multi-prefix` causes znc to send `&` instead of no prefix at all, correct would be `!`. @psychon Yes, I had two clients connected to znc. Same symptoms as in #1528, duplicate issue then. Closing this, thanks! <!-- github-comment-id:417310052 -->
Sign in to join this conversation.
No Branch/Tag Specified
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Wojcieszonek)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: adam/znc#868